Re: [dpdk-dev] [PATCH v2] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
The new error message looks great. As I've already given my ack, I'm happy for this to be applied. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday 4 February 2021 16:51 > To: Ferriter, Cian > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org >

Re: [dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Ferruh Yigit > Sent: Thursday 4 February 2021 16:29 > To: Ferriter, Cian > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/pcap: fix infinite Rx with large files > > On 2/4/2021 4:03 PM, Ferriter, Cian wrote: > >

Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Ferriter, Cian > Sent: Thursday 4 February 2021 15:48 > To: Yigit, Ferruh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/pcap: fix byte stats for drop Tx > > > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH] net/pcap: fix infinite Rx with large files

2021-02-04 Thread Ferriter, Cian
riter > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday 3 February 2021 15:49 > To: Ferriter, Cian > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/pcap: fix infinite Rx with large files > > Packet forwarding is not working when inf

Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx

2021-02-04 Thread Ferriter, Cian
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday 3 February 2021 17:30 > To: Ferriter, Cian > Cc: Yigit, Ferruh ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/pcap: fix byte stats for drop Tx > > Drop Tx path in pcap is Tx that just dro

Re: [dpdk-dev] [PATCH v2] net/pcap: truncate packet if it is too large

2019-12-09 Thread Ferriter, Cian
1:53 > To: dev@dpdk.org > Cc: wangzh...@jd.com; Yigit, Ferruh ; Ferriter, Cian > ; Zhike Wang > Subject: [PATCH v2] net/pcap: truncate packet if it is too large > > From: Zhike Wang > > Previously large packet would be dropped, instead now it is better to keep it > via

Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks

2019-11-05 Thread Ferriter, Cian
> -Original Message- > From: Kevin Traynor > Sent: Tuesday 5 November 2019 16:41 > To: David Marchand > Cc: dev ; Ferriter, Cian ; dpdk > stable ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks > > On 30/10/2019 07:52, D

Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks

2019-10-04 Thread Ferriter, Cian
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday 1 October 2019 13:53 > To: dev@dpdk.org > Cc: Kevin Traynor ; Ferriter, Cian > ; sta...@dpdk.org > Subject: [PATCH 1/9] net/pcap: fix argument checks > > Previously rx

Re: [dpdk-dev] [PATCH 19.08 v2] doc: announce infinite Rx PCAP PMD feature

2019-07-03 Thread Ferriter, Cian
v2 changes: * added the commit ID to which the announcement is relevant > -Original Message- > From: Ferriter, Cian > Sent: 03 July 2019 12:04 > To: Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org; Ferriter, Cian > Subject: [PATCH 19.08 v2] doc: announce

Re: [dpdk-dev] [PATCH 19.08 v3 2/2] net/pcap: enable infinitely rxing a pcap file

2019-06-28 Thread Ferriter, Cian
minor here, I'd be happy if you wanted to make the changes and apply the patches to save going through another version + review cycle. Let me know if there is anything else. Thanks, Cian > -Original Message- > From: Yigit, Ferruh > Sent: 27 June 2019 18:56 > To: Ferriter, Ci

Re: [dpdk-dev] [PATCH 19.08 v2] net/pcap: enable infinitely rxing a pcap file

2019-06-14 Thread Ferriter, Cian
Hi Ferruh, Thanks for the review. I've send a v3 and responded to your comments below. Thanks, Cian > -Original Message- > From: Yigit, Ferruh > Sent: 12 June 2019 15:10 > To: Ferriter, Cian ; Richardson, Bruce > ; Mcnamara, John > ; Kovacevic, Marko > > C

Re: [dpdk-dev] [PATCH 19.08] net/pcap: enable infinitely rxing a pcap file

2019-06-05 Thread Ferriter, Cian
Hi Ferruh, Thanks for the review! I've posted the v2 of this patch. My replies are inline Thanks, Cian > -Original Message- > From: Yigit, Ferruh > Sent: 27 May 2019 16:15 > To: Ferriter, Cian ; Richardson, Bruce > ; Mcnamara, John > ; Kovacevic, Marko > &g

Re: [dpdk-dev] [PATCH 19.08 v2] net/pcap: enable infinitely rxing a pcap file

2019-06-05 Thread Ferriter, Cian
finite_rx = infinite_rx assignment unconditional * add cleanup for infinite_rx in eth_dev_close and pmd_pcap_remove * add cleanup when multi seg mbufs are found * add some clarifications to the documentation update > -Original Message----- > From: Ferriter, Cian > Sent: 05 June 2019 12:5

[dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve

2015-01-22 Thread Ferriter, Cian
Hey guys, I just wanted to ask is there anything more that can be done with this patch or is it in an acceptable state for pushing? Cian -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferriter, Cian Sent: Monday, January 19, 2015 6:39 PM To: Richardson, Bruce

[dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve

2015-01-19 Thread Ferriter, Cian
"--socket-mem" allocated. Cian -Original Message- From: Richardson, Bruce Sent: Wednesday, January 14, 2015 10:10 AM To: Ferriter, Cian Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve On Tue, Jan 13, 2015 at

[dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve

2015-01-13 Thread Ferriter, Cian
uot;rte_eth_dev_data" struct for each socket that there is a NIC attached to, reserving memory from that socket? Cian -Original Message- From: Richardson, Bruce Sent: Tuesday, January 13, 2015 1:56 PM To: Ferriter, Cian Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib/librte_et

[dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve

2015-01-13 Thread Ferriter, Cian
issues as the master lcore doesn't change. -Original Message- From: Ferriter, Cian Sent: Tuesday, January 13, 2015 9:22 AM To: dev at dpdk.org Cc: Ferriter, Cian Subject: [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve Change the socket id that is passed to rte