Re: cryptodev API question with out of order support

2023-03-20 Thread Doherty, Declan
Hey Suanming, I haven't been actively involved in the development of DPDK in a number of years but as far as I'm aware (and I don't believe this has changed recently), out of order processing from the cryptodev API user perspective is not supported, and for most scenarios I'm aware of (for sy

Re: [dpdk-dev] maintainers: update for qat and ipsec-mb pmds

2021-05-20 Thread Doherty, Declan
On 20/05/2021 10:47 AM, Fan Zhang wrote: Add myself to Crypto API, QAT, SW PMDs based on ipsec-mb, and NULL PMD maintainer. Signed-off-by: Fan Zhang --- MAINTAINERS | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5877

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-04-30 Thread Doherty, Declan
On 23/04/2021 5:18 PM, Ciara Power wrote: The current crypto unit test framework is not granular enough to accurately track unit test results. This is caused by one testcase in a suite actually running multiple testcases, but only returning one result. The approach taken in this patchset al

Re: [dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites

2021-04-30 Thread Doherty, Declan
On 23/04/2021 5:18 PM, Ciara Power wrote: The existing implementation runs a giant cryptodev testsuite for most autotests, which in turns runs one setup function regardless of device. This is now broken down into multiple testsuites, that are used as sub-testsuites. Each autotest runs a gener

Re: [dpdk-dev] [PATCH v3 1/1] crypto/qat: support Single-Pass GMAC on QAT GEN3

2021-04-14 Thread Doherty, Declan
On 14/04/2021 12:33 PM, Adam Dybkowski wrote: This patch implements Single-Pass AES-GMAC possible on QAT GEN3 which improves the performance. On GEN1 and GEN2 the previous chained method is used. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_qp.c | 3 +- drivers/crypt

Re: [dpdk-dev] [EXT] [PATCH v2 3/6] test/crypto: refactor to use sub-testsuites

2021-04-14 Thread Doherty, Declan
On 13/04/2021 6:51 PM, Akhil Goyal wrote: Hi Ciara, //snip nb_devs = rte_cryptodev_count(); if (nb_devs < 1) { RTE_LOG(WARNING, USER1, "No crypto devices found?\n"); @@ -838,6 +630,228 @@ testsuite_setup(void) return TEST_SUCCESS; } +static int +qa

Re: [dpdk-dev] [PATCH] crypto/qat: fix to small sgl oop min offset

2021-04-14 Thread Doherty, Declan
On 18/03/2021 1:16 PM, Arek Kusztal wrote: This commit fixes problem with to small offset when both offsets (auth, cipher) are non zero in digest encrypt case, when using out-of-place and sgl. Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypted auth-cipher") Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-03-30 Thread Doherty, Declan
Hey Aaron, based on the work you've been doing on the unit test documentation we would appreciate if you could take a look over this patchset and get your thoughts. The primary drive here is to make it easier to get a clear picture of what is being executed in the cryptodev testsuite, as at t

Re: [dpdk-dev] Potential bug in QAT PMD code

2021-03-03 Thread Doherty, Declan
H On 23/02/2021 12:34 AM, Linfeng Li wrote: Hi, We believe we found a potential bug in the QAT PMD code. file link: https://github.com/DPDK/dpdk/blob/main/drivers/crypto/qat/qat_sym.c The undesired behavior happens when: * symmetric operation * out-of-place operation *

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2021-01-19 Thread Doherty, Declan
On 19/01/2021 5:00 PM, Akhil Goyal wrote: Hi Tejasree, Subject: [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations Adding support for SSL/TLS way of cipher-auth operations order - auth generation followed by encryption - decryption followed by auth verify Sign

Re: [dpdk-dev] [PATCH] test/cryptodev: fix spelling in app output

2021-01-19 Thread Doherty, Declan
On 18/01/2021 11:34 AM, Ciara Power wrote: Fixes some spelling errors in app logs and help text. Fixes: 7da018731c56 ("app/crypto-perf: add help option") Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: pablo.de.lara.gua...@intel.com Cc: slawomirx.mrozow...@

Re: [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-15 Thread Doherty, Declan
On 14/01/2021 10:41 AM, Ciara Power wrote: This patchset introduces a python script to run various crypto performance test cases, and graph the results in a consumable manner. The test suites are configured via JSON file. Some config files are provided, or the user may create one. Currently th

Re: [dpdk-dev] [PATCH 3/4] usertools: add script to graph crypto perf results

2021-01-11 Thread Doherty, Declan
On 11/12/2020 5:31 PM, Ciara Power wrote: The python script introduced in this patch runs the crypto performance test application for various test cases, and graphs the results. Test cases are defined in the config JSON file, this is where parameters are specified for each test. Currently the

Re: [dpdk-dev] [PATCH 2/4] test/cryptodev: improve csv output for perf tests

2021-01-11 Thread Doherty, Declan
On 11/12/2020 5:31 PM, Ciara Power wrote: The csv outputs for performance tests were not easily consumed, due to unnecessary whitespaces and capitals. The delimiter is modified to now be "," instead of ";" which was present in some cases. Some unnecessary values were also removed from the outp

Re: [dpdk-dev] [PATCH] crypto/qat: fix possible access to an uninitialized variable

2020-12-16 Thread Doherty, Declan
On 15/12/2020 6:23 PM, Vladimir Medvedkin wrote: QAT_LOG() has access to the uninitialized variable "name" Fixes: 21792c443205 ("crypto/qat: add multi-process handling of driver ID") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for ChaCha20-Poly1305

2020-10-07 Thread Doherty, Declan
On 06/10/2020 1:32 PM, David Marchand wrote: For the title, I would suggest: "cryptodev: remove v20 ABI compatibility" You did this change using a revert, but still, we can avoid restoring coding style issues, see nits below. On Fri, Aug 14, 2020 at 12:00 PM Adam Dybkowski wrote: This reve

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-31 Thread Doherty, Declan
On 29/07/2020 3:22 PM, Arek Kusztal wrote: This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. It is however not 100% conformant GMAC as instead of aad pointer data to be authenticated is passed normally and aead.data.length field is used to specify length of data to be authen

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-21 Thread Doherty, Declan
On 15/04/2020 11:33 PM, Thomas Monjalon wrote: 16/04/2020 00:19, Doherty, Declan: On 14/04/2020 3:44 PM, Thomas Monjalon wrote: 14/04/2020 16:02, Trahe, Fiona: From: Thomas Monjalon 14/04/2020 15:04, Trahe, Fiona: 14/04/2020 12:21, Ferruh Yigit: http://inbox.dpdk.org/dev

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-15 Thread Doherty, Declan
On 14/04/2020 3:44 PM, Thomas Monjalon wrote: 14/04/2020 16:02, Trahe, Fiona: Hi Thomas, From: Thomas Monjalon 14/04/2020 15:04, Trahe, Fiona: 14/04/2020 12:21, Ferruh Yigit: http://inbox.dpdk.org/dev/mn2pr11mb35507d4b96677a41e66440c5e3...@mn2pr11mb3550.na mprd11.prod.outlook.com/ I am n

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-11 Thread Doherty, Declan
this? Thanks, Anoob -Original Message- From: Shetty, Praveen Sent: Tuesday, March 10, 2020 5:11 PM To: Anoob Joseph ; dev@dpdk.org; Doherty, Declan ; Iremonger, Bernard ; Ananyev, Konstantin Subject: [EXT] RE: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file ... -- 2.17.1

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-13 Thread Doherty, Declan
On 07/02/2020 2:18 PM, Jerin Jacob wrote: On Fri, Feb 7, 2020 at 6:08 PM Coyle, David wrote: Hi Jerin, see below Hi David, On Thu, Feb 6, 2020 at 10:01 PM Coyle, David wrote: There is a risk in drafting API that meant for HW without any HW exists. Because there could be inefficiency

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-13 Thread Doherty, Declan
On 06/02/2020 5:13 PM, Jerin Jacob wrote: On Thu, Feb 6, 2020 at 10:01 PM Coyle, David wrote: Hi David, - XGS-PON MAC: Crypto-CRC-BIP - Order: - Downstream: CRC, Encrypt, BIP I understand if the chain has two operations then it may possible to have handcrafted S

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-13 Thread Doherty, Declan
On 06/02/2020 10:54 AM, Jerin Jacob wrote: On Thu, Feb 6, 2020 at 3:35 PM Coyle, David wrote: Hi Jerin, Hi David, Thanks for the comments. Please see replies below. Kind Regards, David On Tue, Feb 4, 2020 at 8:15 PM David Coyle wrote: Introduction This RFC introduces a

Re: [dpdk-dev] [PATCH v3 9/9] test/ipsec: introduce functional test

2018-12-13 Thread Doherty, Declan
Can you add a note to the commit message that tests require the null crypto pmd to pass successfully, and also an ERR message in the test suite initialisation if no null pmd would be good. On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Create functional test for librte_ipsec. Signed-off-by:

Re: [dpdk-dev] [PATCH v3 8/9] ipsec: helper functions to group completed crypto-ops

2018-12-13 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH v3 7/9] ipsec: rework SA replay window/SQN for MT environment

2018-12-13 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window opera

Re: [dpdk-dev] [PATCH v3 6/9] ipsec: implement SA data-path API

2018-12-12 Thread Doherty, Declan
Only some minor some cosmetic questions On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Provide implementation for rte_ipsec_pkt_crypto_prepare() and ... +/* + * Move preceding (L3) headers up to free space for ESP header and IV. + */ +static inline void +insert_esph(char *np, char *op, uint

Re: [dpdk-dev] [PATCH v3 5/9] ipsec: add SA data-path API

2018-12-11 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authentic

Re: [dpdk-dev] [PATCH v3 4/9] lib: introduce ipsec library

2018-12-11 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Associati

Re: [dpdk-dev] [PATCH v3 3/9] net: add ESP trailer structure definition

2018-12-11 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1

Re: [dpdk-dev] [PATCH v3 2/9] security: add opaque userdata pointer into security session

2018-12-11 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal --- lib/librte_security/rte_sec

Re: [dpdk-dev] [PATCH v3 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-12-11 Thread Doherty, Declan
On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal ---

Re: [dpdk-dev] [PATCH v2 3/3] eal: allow probing a device again

2018-10-04 Thread Doherty, Declan
On 28/09/2018 5:40 PM, Thomas Monjalon wrote: In the devargs syntax for device representors, it is possible to add several devices at once: -w dbdf,representor=[0-3] It will become a more frequent case when introducing wildcards and ranges in the new devargs syntax. If a devargs string is provid

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-08-02 Thread Doherty, Declan
On 02/08/2018 3:24 PM, Matan Azrad wrote: Hi From: Doherty, Declan On 02/08/2018 7:35 AM, Matan Azrad wrote: Hi Chas, Radu From: Chas Williams On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote: On 8/1/2018 2:34 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau

Re: [dpdk-dev] [PATCH v5] net/bonding: fix slave add for mode 4

2018-08-02 Thread Doherty, Declan
On 18/07/2018 2:21 PM, Radu Nicolau wrote: Moved the link status validity check from the slave add to the slave activation step. Otherwise slave add will fail for mode 4 if the ports are all stopped but only one of them checked. Removed activate slave call from slave add function. Fixes: b77d21

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

2018-08-02 Thread Doherty, Declan
On 01/08/2018 2:18 PM, Radu Nicolau wrote: When a bonding port is stopped also stop and deactivate all slaves. Otherwise slaves will be still listed as active. Fixes: 69bce062132b ("net/bonding: do not clear active slave count") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

2018-08-02 Thread Doherty, Declan
On 02/08/2018 7:35 AM, Matan Azrad wrote: Hi Chas, Radu From: Chas Williams On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote: On 8/1/2018 2:34 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau wrote: Update the bonding promiscuous mode enable/disable functions as

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Doherty, Declan
On 06/07/2018 3:28 PM, Verma, Shally wrote: Hi Declan -Original Message- From: Doherty, Declan [mailto:declan.dohe...@intel.com] Sent: 05 July 2018 20:24 To: Verma, Shally ; pablo.de.lara.gua...@intel.com Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu ; Sahu, Sunila

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-05 Thread Doherty, Declan
Hey Shally, just a few things inline below mainly concerned with the need to be able to support session-less operations in future PMDs. I think with a few minor changes to the API now it should allow session-less to be supported later without the need for a major rework of the APIs, I don't t

Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement

2018-06-26 Thread Doherty, Declan
On 19/06/2018 7:26 AM, Anoob Joseph wrote: Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by applications, which is not strictly followed for crypto devs. This How is this done for NET PMDs, I don't se

Re: [dpdk-dev] [PATCH v4] net/bonding: add add/remove mac addrs

2018-06-25 Thread Doherty, Declan
On 20/06/2018 9:37 AM, Alex Kiselev wrote: add functions to add/remove MAC addresses Signed-off-by: Alex Kiselev --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-14 Thread Doherty, Declan
On 24/04/2018 12:29 PM, Matan Azrad wrote: The bonding PMD decides to activate\deactivate its slaves according to the slaves link statuses. Thus, it registers to the LSC events of the slaves ports and activates\deactivates them from its LSC callbacks called asynchronously by the host thread when

Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev

2018-05-01 Thread Doherty, Declan
On 01/05/2018 10:47 AM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty Sent: Monday, April 30, 2018 4:33 PM To: dev@dpdk.org Cc: Doherty, Declan Subject: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for

Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise nb_representor_ports value

2018-05-01 Thread Doherty, Declan
On 01/05/2018 10:46 AM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Declan Doherty Sent: Monday, April 30, 2018 4:33 PM To: dev@dpdk.org Cc: Doherty, Declan Subject: [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise

Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter support to rte_flow

2018-04-26 Thread Doherty, Declan
On 26/04/2018 3:43 PM, Ori Kam wrote: Hi, PSB Ori -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Thursday, April 26, 2018 5:28 PM To: Ori Kam ; Declan Doherty ; dev@dpdk.org; Matan Azrad Subject: Re: [dpdk-dev] [PATCH v6 4/4] ethdev: add shared counter sup

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Doherty, Declan
On 26/04/2018 1:03 PM, Ananyev, Konstantin wrote: -Original Message- From: Doherty, Declan Sent: Thursday, April 26, 2018 11:41 AM To: dev@dpdk.org Cc: Adrien Mazarguil ; Yigit, Ferruh ; Thomas Monjalon ; Shahaf Shuler ; Ananyev, Konstantin ; Horton, Remy ; Doherty, Declan Subject

Re: [dpdk-dev] [PATCH v7 4/9] ethdev: Add port representor device flag

2018-04-25 Thread Doherty, Declan
On 24/04/2018 8:37 PM, Thomas Monjalon wrote: 16/04/2018 15:06, Declan Doherty: Add new device flag to specify that an ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device flags to the user which enables applications to discover if a port is a representor port.

Re: [dpdk-dev] [PATCH] net/bonding: add rte flow support

2018-04-24 Thread Doherty, Declan
Firstly, apologies on the very large delay on reviewing this. This looks good to me and I've verified that flow configuration propagates as expected to bonded slaves using IXGBE PMDs for testing. I had to do some minor rebasing to get the patch to apply cleanly to next-net, so I'll leave it up

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions

2018-04-23 Thread Doherty, Declan
On 23/04/2018 12:00 PM, Shahaf Shuler wrote: Thursday, April 19, 2018 4:03 PM, Adrien Mazarguil: Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions On Wed, Apr 18, 2018 at 10:04:18PM +0100, Declan Doherty wrote: [...] I'm still unsure about the definition involvi

Re: [dpdk-dev] [PATCH v4 0/6] additions to support tunnel encap/decap

2018-04-23 Thread Doherty, Declan
On 23/04/2018 12:11 PM, Shahaf Shuler wrote: Hi Declan, Thursday, April 19, 2018 12:04 AM, Declan Doherty: ; Declan Doherty Subject: [dpdk-dev][PATCH v4 0/6] additions to support tunnel encap/decap This patchset contains the revised proposal to manage virtual tunnel endpoints hardware

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: Add tunnel encap/decap actions

2018-04-17 Thread Doherty, Declan
On 06/04/2018 9:26 PM, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote: Add new flow action types and associated action data structures to support the encapsulation and decapsulation of the virtual tunnel endpoints. The RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP ac

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: Add group action type to rte_flow

2018-04-17 Thread Doherty, Declan
On 06/04/2018 9:26 PM, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:02PM +0100, Declan Doherty wrote: Add group action type which defines a terminating action which allows a matched flow to be redirect to a group. This allows logical flow table hierarchies to be managed through rte_flow

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: Add metadata flow and action items support

2018-04-17 Thread Doherty, Declan
On 06/04/2018 9:27 PM, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:03PM +0100, Declan Doherty wrote: Introduces a new action type RTE_FLOW_ACTION_TYPE_METADATA which enables metadata extraction from a packet into a specified metadata container for consumption on further pipeline stages

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-29 Thread Doherty, Declan
On 29/03/2018 11:12 AM, Shahaf Shuler wrote: Thursday, March 29, 2018 12:14 PM, Doherty, Declan: On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Hi Declan, Thanks for the series! See some comments below Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 2/8] ethdev

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device flag Add new device flag to specify that ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device fla

Re: [dpdk-dev] [PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs Add new bus generic ethdev create/destroy APIs which are bus independent and provide hooks for bus specific initialisat

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Hi Declan, Thanks for the series! See some comments below Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 2/8] ethdev: add switch identifier parameter to port Introduces a new port attribute to ethdev port's which den

Re: [dpdk-dev] [PATCH v6 1/8] doc: add switch representation documentation

2018-03-28 Thread Doherty, Declan
On 28/03/2018 3:53 PM, Thomas Monjalon wrote: 28/03/2018 15:54, Declan Doherty: From: Adrien Mazarguil Add document to describe a model for representing switching capable devices in DPDK, using a general ethdev port model and through port representors.This document also details the port model

[dpdk-dev] tunnel endpoint hw acceleration enablement

2018-02-27 Thread Doherty, Declan
Invite for a DPDK community call to discuss the tunnel endpoint hw acceleration proposal in this RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html) and the related community feedback. Proposed agenda: - Summary of RFC proposal, treating TEPs as standalone entities which flows get

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-02-26 Thread Doherty, Declan
the other hand I'm not sure a dedicated API for TEP is needed at all. I'm not convinced rte_security chose the right path and would like to avoid repeating the same mistakes if possible, more below. On Thu, Dec 21, 2017 at 10:21:13PM +0000, Doherty, Declan wrote: This RFC contains a p

Re: [dpdk-dev] [PATCH] doc: announce ABI change to support VF representors

2018-02-14 Thread Doherty, Declan
On 14/02/2018 12:32 PM, Shahaf Shuler wrote: This is following the RFC being discussed and targets 18.05 http://dpdk.org/ml/archives/dev/2018-January/085716.html Cc: declan.dohe...@intel.com Cc: mohammad.abdul.a...@intel.com Cc: ferruh.yi...@intel.com Cc: remy.hor...@intel.com Signed-off-by: S

Re: [dpdk-dev] [PATCH] maintainers: update for cryptodev

2018-01-24 Thread Doherty, Declan
On 24/01/2018 5:24 PM, Pablo de Lara wrote: Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..924426343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -276,6 +276,7 @@ F: examples/bbdev_app/ F: doc/guid

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
;t aware of devices which supported this type of function for overlaps, but it definitely sounds like we need to consider it here. -johnd -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Doherty, Declan Sent: Thursday, December 21, 2017 2:21 PM To: dev@dpdk.org Subject

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
On 16/01/2018 8:22 AM, Shahaf Shuler wrote: Thursday, January 11, 2018 11:45 PM, John Daley: Hi Declan and Shahaf, I can't see how the existing ethdev API could be used for statistics as a single ethdev could be supporting may concurrent TEPs, therefore we would either need to use the extended

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
On 11/01/2018 9:45 PM, John Daley (johndale) wrote: Hi Declan and Shahaf, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Doherty, Declan Sent: Tuesday, January 09, 2018 9:31 AM To: Shahaf Shuler ; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] tunnel endpoint hw

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-15 Thread Doherty, Declan
On 10/01/2018 7:26 PM, Thomas Monjalon wrote: 10/01/2018 14:46, Doherty, Declan: On 09/01/2018 11:22 PM, Thomas Monjalon wrote: Hi, 08/01/2018 15:37, Remy Horton: Port Representors provide a logical presentation in DPDK of VF (virtual function) ports for the purposes of control and

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-10 Thread Doherty, Declan
Adding discussion back to list. On 24/12/2017 2:18 PM, Boris Pismenny wrote: Hi Declan On 12/22/2017 12:21 AM, Doherty, Declan wrote: This RFC contains a proposal to add a new tunnel endpoint API to DPDK that when used in conjunction with rte_flow enables the configuration of inline data

Re: [dpdk-dev] [PATCH] test: register test as failed if setup failed

2018-01-10 Thread Doherty, Declan
On 22/12/2017 10:21 AM, Anatoly Burakov wrote: If test set up couldn't be completed, the test was previously shown as succeeding, even though setup failed. Fix this to report test as failed, and count all tests that should've been executed, as failed as well. Fixes: ffac67b1f71b ("app/test: new

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-10 Thread Doherty, Declan
On 09/01/2018 11:22 PM, Thomas Monjalon wrote: Hi, 08/01/2018 15:37, Remy Horton: Port Representors provide a logical presentation in DPDK of VF (virtual function) ports for the purposes of control and monitoring. Each port representor device represents a single VF and is associated with it's p

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-09 Thread Doherty, Declan
On 24/12/2017 5:30 PM, Shahaf Shuler wrote: Hi Declan, Hey Shahaf, apologies for the delay in responding, I have been out of office for the last 2 weeks. Friday, December 22, 2017 12:21 AM, Doherty, Declan: This RFC contains a proposal to add a new tunnel endpoint API to DPDK that when

Re: [dpdk-dev] [PATCH] net/bonding: set slave MAC addresses correctly

2018-01-09 Thread Doherty, Declan
On 28/12/2017 2:12 AM, Chas Williams wrote: From: Chas Williams Use rte_eth_dev_default_mac_addr_set() to change a slave MAC address. mac_address_set() only updates the software copy and does nothing to update the hardware. Signed-off-by: Chas Williams --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH] net/bonding: add ethdev ops function for MTU set

2018-01-09 Thread Doherty, Declan
On 04/01/2018 6:34 AM, Sharmila Podury wrote: From: Sharmila Podury Set the MTU for bonding device by calling .mtu_set for all the slaves. Set the MTU only if all slaves support .mtu_set, and there is no error returned from any slave. Signed-off-by: Sharmila Podury --- drivers/net/bonding/r

[dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2017-12-21 Thread Doherty, Declan
This RFC contains a proposal to add a new tunnel endpoint API to DPDK that when used in conjunction with rte_flow enables the configuration of inline data path encapsulation and decapsulation of tunnel endpoint network overlays on accelerated IO devices. The proposed new API would provide for th

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-13 Thread Doherty, Declan
On 29/11/2017 11:41 AM, Jerin Jacob wrote: -Original Message- ... Adding Declan and Hemant. > IMO, RTE_EVENT_CRYPTO_ENQ_MULTI_EVENTQ may not be very useful from application perceptive as the scope is very limited. In real world use cases, we will be attaching destination event queue

Re: [dpdk-dev] [PATCH] net/bonding: fix bond 8023ad mode enable using wrong index

2017-12-12 Thread Doherty, Declan
On 20/11/2017 7:15 AM, Lilijun (Jerry) wrote: Hi all, In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave(). I think this variable is only a index for array internals->ac

Re: [dpdk-dev] rte_eth_bond 8023ad behaviour under congestion

2017-11-10 Thread Doherty, Declan
On 08/11/2017 7:33 PM, Kyle Larose wrote: Hello, I've been doing some testing using the 8023ad link bonding driver on a system with 4 10G i40e interfaces in the link bond. One thing I've noticed is that if any of the links are overloaded when I don't have dedicated control queues enabled, it

Re: [dpdk-dev] rte_eth_bond 8023ad dedicated queues with i40e with vectorized rx does not work

2017-11-10 Thread Doherty, Declan
On 08/11/2017 7:21 PM, Kyle Larose wrote: Hello, I've been doing some testing using the 8023ad link bonding driver on a system with 4 10G i40e interfaces in the link bond. It's working fine, except that when any of the links are overloaded, it starts dropping the LACPDUs, which is rather unfo

Re: [dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure*

2017-10-23 Thread Doherty, Declan
Hey folks, to assist in the work of moving the PCI (http://dpdk.org/ml/archives/dev/2017-October/078803.html) and virtual bus (http://dpdk.org/ml/archives/dev/2017-October/077858.html, http://dpdk.org/ml/archives/dev/2017-October/078783.html) out of EAL I've put together this patch set which

Re: [dpdk-dev] [PATCH v2 00/14] Move PCI away from the EAL

2017-10-11 Thread Doherty, Declan
On 18/09/2017 10:31 AM, Gaetan Rivet wrote: Hi all, Here is a new version of the PCI bus move out of the EAL. The EAL PCI implementation is divided in two parts: - librte_pci: library offering helpers to handle PCI objects - librte_bus_pci: bus driver for PCI devices This allows other l

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-10-10 Thread Doherty, Declan
On 03/10/2017 4:49 PM, Ferruh Yigit wrote: On 9/19/2017 5:09 AM, zengganghui wrote: Local LACP packets do not have VLANs, and ethertype must be ETHER_TYPE_SLOW. But when the PMD supports VLAN strip, you cannot directly determine the ethertype from the packet, but depends on whether the VLAN is

Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-02 Thread Doherty, Declan
On 20/09/2017 7:04 PM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan At present, creating bonding devices using --vdev is broken for PMD like mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown to find_port_id_by_pci_addr(), as below. testpmd --vdev 'net_bonding0,m

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-09-18 Thread Doherty, Declan
t VLAN on egress as that isn't supported in the bonding implementation. BR. Zeng Ganghui Huawei Technologies Co., Ltd. -Original Message- From: Doherty, Declan [mailto:declan.dohe...@intel.com] Sent: Monday, September 18, 2017 8:34 PM To: zengganghui; dev@dpdk.org Subject: Re: [PAT

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-09-18 Thread Doherty, Declan
Huawei Technologies Co., Ltd. -Original Message- From: Doherty, Declan [mailto:declan.dohe...@intel.com] Sent: Monday, September 18, 2017 5:14 PM To: zengganghui; dev@dpdk.org Subject: Re: [PATCH] net/bonding: strengthen the judgment of lacp packets On 30/08/2017 4:46 AM, ZengGanghui wrote: Wh

Re: [dpdk-dev] [PATCH] bonding: fix wrong slaves capacity check

2017-09-18 Thread Doherty, Declan
On 27/07/2017 1:00 PM, Tomasz Kulasek wrote: For fortville NIC bond_ethdev_8023ad_flow_verify fails when action queue index indicates unavailable queue before slaves configuration. This fix verifies flow settings for queue 0, which is always available, and checks if slaves max queue number capac

Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-09-18 Thread Doherty, Declan
On 30/08/2017 4:46 AM, ZengGanghui wrote: When the nic does not support vlan rx offload may be wrong, resulting in lacp packets will not be processed. Signed-off-by: ZengGanghui --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH 09/11] net/ixgbe: enable inline ipsec

2017-09-15 Thread Doherty, Declan
On 15/09/2017 5:48 AM, Hemant Agrawal wrote: Hi Radu, On 9/14/2017 1:56 PM, Akhil Goyal wrote: +static const struct rte_security_capability ixgbe_security_capabilities[] = { +    { /* IPsec Inline Crypto AH Transport Egress */ +    .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, +  

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function

2017-03-30 Thread Doherty, Declan
-Original Message- From: De Lara Guarch, Pablo Sent: Thursday, March 30, 2017 12:54 PM To: Doherty, Declan ; Gonzalez Monroy, Sergio ; dev@dpdk.org Cc: sta...@dpdk.org Subject: RE: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function > -Original Message- >

Re: [dpdk-dev] [PATCH] crypto/scheduler: add enqueue and dequeue operations

2017-02-24 Thread Doherty, Declan
On 21/02/2017 11:43 AM, Fan Zhang wrote: This patch adds enqueue and dequeue operations to rte_cryptodev_scheduler_ops structure. This helps improving the performance by reducing unnecessary function calls. Signed-off-by: Fan Zhang --- ... rte_cryptodev_scheduler_create_private_ctx c

Re: [dpdk-dev] [PATCH v2 3/5] crypto/null: use ring size function

2017-02-24 Thread Doherty, Declan
On 23/02/2017 4:42 PM, Bruce Richardson wrote: Rather than reading the size directly from the ring structure, use the dedicated function for that purpose. Signed-off-by: Bruce Richardson --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] crypto drivers in the API

2017-02-14 Thread Doherty, Declan
On 14/02/2017 11:04 AM, Thomas Monjalon wrote: 2017-02-14 10:44, Doherty, Declan: On 13/02/2017 1:25 PM, Thomas Monjalon wrote: In the crypto API, the drivers are listed. In my opinion, it is a wrong designed and these lists should be removed. Do we need a deprecation notice to plan this

Re: [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev ops structure

2017-02-14 Thread Doherty, Declan
On 14/02/2017 10:41 AM, Fan Zhang wrote: Signed-off-by: Fan Zhang Acked-by: Hemant Agrawal --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] crypto drivers in the API

2017-02-14 Thread Doherty, Declan
On 13/02/2017 1:25 PM, Thomas Monjalon wrote: In the crypto API, the drivers are listed. In my opinion, it is a wrong designed and these lists should be removed. Do we need a deprecation notice to plan this removal in 17.05, while working on bus abstraction? ... Hey Thomas, I agree that the

Re: [dpdk-dev] [PATCH] doc: add deprecation note to add parameter in rte_cryptodev_info.sym

2017-02-14 Thread Doherty, Declan
On 14/02/2017 12:11 PM, akhil.go...@nxp.com wrote: From: Akhil Goyal A new parameter is planned to be added in 17.05 release in rte_cryptodev_info.sym - max_nb_sessions_per_qp. This will allow applications to know the maximum number of session which can be attached to queue_pairs of device. S

[dpdk-dev] [RFC 0/4] Use Google Test as DPDK unit test framework

2016-08-03 Thread Doherty, Declan
> -Original Message- ... > You are not advocating but the unit test must be written in C++. > I don't think it is a good idea to force people to write and maintain the > tests > in a different language than the code it tests. I know where you are coming from on this point, and I general

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-04-01 Thread Doherty, Declan
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley > Sent: Saturday, March 26, 2016 12:45 AM > To: dev at dpdk.org > Cc: Nelson Escobar ; John Daley > Subject: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt > mode > > From: Nelson

[dpdk-dev] [PATCH 0/2] bonding fixes

2016-02-22 Thread Doherty, Declan
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, February 10, 2016 10:14 AM > To: dev at dpdk.org > Cc: Doherty, Declan ; Iremonger, Bernard > > Subject: [PATCH 0/2] bonding fixes > > These patches fix segmentation faults which were occurrin

[dpdk-dev] [PATCH] cryptodev: mark experimental state

2015-11-26 Thread Doherty, Declan
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, November 26, 2015 10:09 AM > To: Panu Matilainen; Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: mark experimental state > >

[dpdk-dev] [PATCH] bond: fix check initial link status of slave

2015-06-26 Thread Doherty, Declan
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Wednesday, June 24, 2015 1:51 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] bond: fix check initial link status of slave > > On Fortville NIC, link status change interrupt callbac

[dpdk-dev] [PATCH] Make bond_ethdev_stop iterate only over active slaves

2015-06-26 Thread Doherty, Declan
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jan Blunck > Sent: Wednesday, June 24, 2015 2:01 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Make bond_ethdev_stop iterate only over active > slaves > > When stopping the bond device we don't need to

[dpdk-dev] [PATCH v2 0/8] Dynamic RSS Configuration for Bonding

2015-06-26 Thread Doherty, Declan
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tomasz Kulasek > Sent: Friday, June 19, 2015 7:13 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/8] Dynamic RSS Configuration for Bonding > > OVERVIEW > > 1) Setting .rxmode.mq_mode for bond

  1   2   >