"double free" issue the ena calls to
allocate and free mbufs in bulk were migrated to the mbuf based APIs
so the common mbuf alloc/free routines are exercised.
Fixes: 79405ee17585 ("net/ena: fix out of order completion")
Fixes: 1173fca25af9 ("ena: add polling-mode drive
"double free" issue the ena calls to
allocate and free mbufs in bulk were migrated to the mbuf based APIs
so the common mbuf alloc/free routines are exercised.
Fixes: 79405ee17585 ("net/ena: fix out of order completion")
Fixes: 1173fca25af9 ("ena: add polling-mode drive
> -Original Message-
> From: dev On Behalf Of Bruce Richardson
> Sent: Thursday, November 12, 2020 11:32 AM
> To: dev@dpdk.org
> Cc: Bruce Richardson
> Subject: [dpdk-dev] [RFC PATCH] build: allow passing extra config header
> to build
>
> To allow per-build override of some settings,
> -Original Message-
> From: Bruce Richardson
> Sent: Thursday, November 12, 2020 11:33 AM
> To: David Harton (dharton)
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] Eliminate config/rte_config.h?
>
> On Thu, Nov 12, 2020 at 03:48:20PM +, Bruce Richardson w
Hi folks,
Been experimenting with DPDK 20.11 and the loss of the old "config" hierarchy.
I wonder if anyone considered eliminating config/rte_config.h in favor of a
config/dpdk_conf that can contain the default values at the start of the file
but can be overridden with values later in the f
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, January 29, 2020 6:23 AM
> To: David Harton (dharton) ; dev@dpdk.org
> Cc: wenzhuo...@intel.com; konstantin.anan...@intel.com;
> xiaolong...@intel.com; intel@cisco.com
> Subject: Re: [dpdk-dev] [
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, January 29, 2020 5:10 AM
> To: David Harton (dharton) ; dev@dpdk.org
> Cc: wenzhuo...@intel.com; konstantin.anan...@intel.com;
> xiaolong...@intel.com; intel@cisco.com
> Subject: Re: [dpdk-dev] [PATCH
id (re)adding
the default mac when it differs from the permanent mac.
Fixes: b6562244b4f3 ("ixgbevf: skip null and permanent mac addresses")
Cc: ivan.bo...@6wind.com
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 9 +
1 file changed, 5 insertions(+), 4 de
Added rollover logic to UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT macros.
Fixes: af75078fece3 ("first public release")
Cc: intel.com
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/d
Modified UPDATE_VF_STAT to properly handle rollover conditions.
Fixes: d82170d27918 ("igb: add VF support")
Cc: intel.com
Signed-off-by: David Harton
---
drivers/net/e1000/igb_ethdev.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, December 12, 2019 9:54 AM
> To: David Harton (dharton) ; dev@dpdk.org;
> m...@semihalf.com; m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com;
> igo...@amazon.com
> Subject: Re: [dpdk-dev] [PATCH] ne
Modified UPDATE_VF_STAT to properly handle rollover conditions.
Signed-off-by: David Harton
---
drivers/net/e1000/igb_ethdev.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index a3e30dbe5
Added rollover logic to UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT macros.
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
id (re)adding
the default mac when it differs from the permanent mac.
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 2c6
Network drivers were originally modified to initialize PCI info with
commit eeefe73f0af1 ("drivers: copy PCI device info to ethdev data").
Modifying net/ena to conform.
Signed-off-by: David Harton
---
drivers/net/ena/ena_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/d
Network drivers were originally modified to initialize PCI info
with commit eeefe73f. Modifying net/ena to conform.
Signed-off-by: David Harton
---
drivers/net/ena/ena_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index
Network drivers were originally modified to initialize PCI info
with commit eeefe73f. Modifying net/ena to conform.
Signed-off-by: David Harton
---
drivers/net/ena/ena_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index
Recent modifications to admin command queue polling logic
did not support 32-bit applications. Updated the driver to
work for 32 or 64 bit applications
Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version")
Signed-off-by: David Harton
---
v2: Leave existing timeout method and
> -Original Message-
> From: Michał Krawczyk
> Sent: Monday, July 01, 2019 3:24 AM
> To: David Harton (dharton)
> Cc: dev@dpdk.org; Marcin Wojtas ; Tzalik, Guy
> ; Schmeilin, Evgeny ; Belgazal,
> Netanel ; Kiyanovski, Arthur ;
> Chauskin, Igor ; Matushe
> -Original Message-
> From: Michał Krawczyk
> Sent: Friday, June 28, 2019 11:03 AM
> To: David Harton (dharton)
> Cc: dev@dpdk.org; Marcin Wojtas ; Tzalik, Guy
> ; Schmeilin, Evgeny
> Subject: Re: [PATCH] net/ena: Fix admin cq polling for 32-bit apps
>
>
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, June 04, 2019 12:00 PM
> To: Bruce Richardson ; David Harton (dharton)
>
> Cc: dev@dpdk.org; beilei.x...@intel.com; qi.z.zh...@intel.com
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: Eliminate weak sym
Recent modifications to admin command queue polling logic
did not support 32-bit applications. Updated the driver to
work for 32 or 64 bit applications as well as avoiding
roll-over possibility.
Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version")
Signed-off-by: Da
Use of weak symbols can hide makefile errors especially when
custom makefiles are used. Removing the use of weak symbols
to avoid a stub function being linked in production code.
Signed-off-by: David Harton
---
v3 - added CONFIG_RTE_LIBRTE_I40E_INC_VECTOR to makefile
v2 - added CC_AVX2_SUPPORT
Use of weak symbols can hide makefile errors especially when
custom makefiles are used. Removing the use of weak symbols
to avoid a stub function being linked in production code.
Signed-off-by: David Harton
---
v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors
drivers/net/i40e
Use of weak symbols can hide makefile errors especially when
custom makefiles are used. Removing the use of weak symbols
to avoid a stub function being linked in production code.
Signed-off-by: David Harton
---
drivers/net/i40e/Makefile| 1 +
drivers/net/i40e/i40e_rxtx.c | 52
Hi,
> -Original Message-
> From: Zhao1, Wei
> Sent: Tuesday, April 02, 2019 10:26 PM
> To: David Harton (dharton) ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Zhang, Qi Z
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation
>
according new MTU value.
After this patch, driver may select different receive function
automatically after MTU set, according MTU values selected.
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a
ixgbevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.
Restoring the capbility to enable the vlan strip offload at
configuration time.
Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton
---
ixgbevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.
Restoring the capbility to enable these offloads at
configuration time.
Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton
---
v3
Hi Qi,
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, March 14, 2019 11:14 AM
> To: David Harton (dharton)
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; dev@dpdk.org
> Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf
>
>
&
> -Original Message-
> From: David Harton
> Sent: Friday, March 08, 2019 3:35 PM
> To: dev@dpdk.org
> Cc: wenzhuo...@intel.com; konstantin.anan...@intel.com;
> qi.z.zh...@intel.com; David Harton (dharton)
> Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for
ixgbevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.
Restoring the capbility to enable these offloads at
configuration time.
Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton
---
v2: remo
Hi
> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, March 08, 2019 1:35 AM
> To: David Harton (dharton) ; dev@dpdk.org; Lu, Wenzhuo
> ; Ananyev, Konstantin
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for
> ixgbvef
&
Hi,
> -Original Message-
> From: Zhang, Qi Z
> Sent: Thursday, March 07, 2019 8:11 AM
> To: David Harton (dharton) ; dev@dpdk.org; Lu, Wenzhuo
> ; Ananyev, Konstantin
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for
> ixgbvef
>
&
ixgevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.
Restoring the capbility to enable these offloads at
configuration time.
Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton
---
drivers
The zalloc and calloc functions do not actually zero the memory.
Added memset to rte_zmalloc_socket() so allocated memory is cleared.
Signed-off-by: David Harton
---
v2 Indented if clause
lib/librte_eal/common/rte_malloc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
> -Original Message-
> From: Wiles, Keith
> Sent: Friday, December 07, 2018 6:41 PM
> To: David Harton (dharton)
> Cc: dev@dpdk.org; Burakov, Anatoly
> Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_zalloc_socket to zero memory
>
>
>
> > On Dec
The zalloc and calloc functions do not actually zero the memory.
Added memset to rte_zmalloc_socket() so allocated memory is cleared.
Signed-off-by: David Harton
---
lib/librte_eal/common/rte_malloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common
i40evf_dev_info_get clears dev_info when data has already
been set by the calling function. Remove the call to
memset() to fix the problem.
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: helin.zh...@intel.com
Signed-off-by: David Harton
---
drivers/net/i40e/i40e_ethdev_vf.
Excellent!
I unicasted Yong earlier when I saw the ACKs to vmxnet3 patches. I'll add you
there.
Thanks Louis,
Dave
> -Original Message-
> From: Louis Luo
> Sent: Wednesday, May 02, 2018 5:55 PM
> To: Thomas Monjalon ; David Harton (dharton)
>
> Cc: dev@dpdk.or
I've encountered a couple scenarios with vmxnet3 (dpdk 2.2 and 16.07) that look
pretty much identical to this:
http://dpdk.org/ml/archives/users/2016-October/001063.html
Do we have a maintainer for the vmxnet3 driver? I tried emailing the one
listing in the MAINTAINERS file but the mail bounced
It is used and tested in production and non-production environments.
Regards,
Dave
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Tuesday, April 17, 2018 2:31 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] Retire x86 32 bit?
>
> I wonder if x86 32 bit is still usef
> -Original Message-
> From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com]
>
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David C Harton
> >
> > Calling i40evf_dev_xstats_reset can sometimes crash.
> >
> > Fixed issue by adding a pstats NULL check.
>
> Perhaps add a n
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
>
> On 9/1/2017 3:36 AM, David Harton wrote:
> > Some devices may not support or fail setting VLAN offload
> > configuration based on dynamic circurmstances so the
> > vlan_offload_set_
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
>
> On 9/1/2017 3:26 AM, David Harton wrote:
> > Some devices do not support reset of eth stats. An application may
> > need to know not to clear shadow stats if the device cannot.
> &
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, September 14, 2017 6:10 AM
> To: David Harton (dharton) ;
> konstantin.anan...@intel.com
> Cc: dev@dpdk.org; Wenzhuo Lu
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: eliminate
From: David Harton
The i40e maintains a single MAC filter table for both
unicast and multicast addresses. The i40e_validate_mac_addr
function was preventing multicast addresses from being added
to the table via i40evf_add_mac_addr. Fixed the issue by
adjusting the check in i40evf_add_mac_addr
Hi Beilei,
> -Original Message-
> From: Xing, Beilei [mailto:beilei.x...@intel.com]
>
> Hi Harton,
>
> > -Original Message-
> > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab]
> >
> > From: David Harton
> >
> > Th
From: David Harton
The i40e maintains a single MAC filter table for both
unicast and multicast addresses. The i40e_validate_mac_addr
function was preventing multicast addresses from being added
to the table via i40evf_add_mac_addr. Fixed the issue by
adjusting the check in i40evf_add_mac_addr
Hi Beilei,
> -Original Message-
> From: Xing, Beilei [mailto:beilei.x...@intel.com]
>
> Hi,
>
> > -Original Message-
> > From: David Harton [mailto:dhar...@cisco.com]
> >
> > The i40e maintains a single MAC filter table for both un
Hi Jingjing/Beilei,
A kind reminder to review the patch and the discussion between
Ferruh and myself.
Thanks,
Dave
> -Original Message-
> From: David Harton (dharton)
> > -Original Message-
> > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> >
&
Hi Konstantin,
A gentle reminder to weigh in on this patch and the
discussion between Ferruh and myself below.
Thanks,
Dave
> -Original Message-
> From: David Harton (dharton)
>
> > -Original Message-
> > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
>
> On 9/1/2017 6:24 PM, David Harton (dharton) wrote:
> >
> >> -Original Message-
> >> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> >>
> >&g
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Friday, September 01, 2017 3:41 AM
> To: David Harton (dharton) ; tho...@monjalon.net;
> ferruh.yi...@intel.com; ajit.khapa...@broadcom.com; John Daley (johndale)
> ; konstantin
facilitate dynamically turning VLAN strip on or off.
Signed-off-by: David Harton
---
v4
* Modified commit message heading
* Moved rel_note comments from ABI to API section
* Renamed locals of rte_eth_dev_set_vlan_offload from 'org*' to 'orig*'
v3
* Fixed a format error.
* Apologies.
Some devices do not support reset of eth stats. An application may
need to know not to clear shadow stats if the device cannot.
rte_eth_stats_reset is updated to provide a return code to share
whether the device supports reset or not.
Signed-off-by: David Harton
---
v5:
* squashed doc patch
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, August 31, 2017 6:04 PM
> To: David Harton (dharton)
> Cc: dev@dpdk.org; ferruh.yi...@intel.com; ajit.khapa...@broadcom.com; John
> Daley (johndale) ; konstantin
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, August 31, 2017 11:54 AM
> To: David Harton (dharton) ; jingjing...@intel.com;
> beilei.x...@intel.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] i40e: fix i40e
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com]
> Sent: Wednesday, August 30, 2017 10:27 AM
> To: David Harton (dharton) ; Tahhan, Maryam
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] ixgbe: add counter t
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com]
> Sent: Tuesday, August 29, 2017 3:29 PM
> To: David Harton (dharton)
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] ixgbe: add counter to track sw tx packets
>
>
>
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, August 29, 2017 2:43 PM
> To: David Harton (dharton)
> Cc: konstantin.anan...@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw
Add counter to track packets transmitted at the software layer
to help isolate output errors not reported otherwise.
Signed-off-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 98
drivers/net/ixgbe/ixgbe_ethdev.h | 9
drivers/net/ixgbe
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Monday, August 28, 2017 9:27 AM
> To: David Harton (dharton) ;
> konstantin.anan...@intel.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: eliminate duplicate filterlis
-by: David Harton
---
drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++--
drivers/net/ixgbe/ixgbe_ethdev.h | 7 +--
drivers/net/ixgbe/ixgbe_flow.c | 18 ++
3 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe
Updated vmxnet3_mac_addr_set() to store the newly set MAC address.
Modified vmxnet3_write_mac() so the h/w is updated in an endian
neutral manner.
Signed-off-by: David Harton
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
> -Original Message-
> From: Wiles, Keith [mailto:keith.wi...@intel.com]
> Sent: Friday, August 25, 2017 11:41 AM
> To: David Harton (dharton)
> Cc: skh...@vmware.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] vmxnet3: replenish ring buffers in rx
> processin
vmxnet3 rx processing should replenish ring buffers after new buffers
are available to prevent the interface from getting stuck in a state
that no new work is processed.
Signed-off-by: David Harton
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 +
1 file changed, 17 insertions
facilitate dynamically turning VLAN strip on or off.
Signed-off-by: David Harton
---
*v3
Fixed a format error.
Apologies...need to figure out why checkpatches.pl keeps saying
valid patch when I've got soft tabs.
*v2
Fixed a missed format error.
Removed vlan offload vector call casts and replaced
facilitate dynamically turning VLAN strip on or off.
Signed-off-by: David Harton
---
*v2
Fixed a missed format error.
Removed vlan offload vector call casts and replaced with checks
for return values.
*v1
This is an ABI breakage that has been previously negotiated
with Thomas and the proposed rel note
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, August 24, 2017 7:37 PM
> To: David Harton (dharton)
> Cc: tho...@monjalon.net; ferruh.yi...@intel.com;
> stephen.h...@broadcom.com; ajit.khapa...@broadcom.com; John
facilitate dynamically turning VLAN strip on or off.
This is an ABI breakage that has been previously negotiated
with Thomas and the proposed rel note change is included as well.
Signed-off-by: David Harton
---
doc/guides/rel_notes/release_17_11.rst | 2 +-
drivers/net/avp/avp_ethdev.c | 7
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, August 23, 2017 5:57 PM
> To: David Harton (dharton)
> Cc: tho...@monjalon.net; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overrid
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, August 23, 2017 9:24 AM
> To: David Harton (dharton)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by
> rte_eth_stats_get
>
> 23/
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, August 23, 2017 6:48 AM
> To: David Harton (dharton) ; m...@semihalf.com;
> m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-
> -Original Message-
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com]
> Sent: Wednesday, August 23, 2017 6:32 AM
> To: David Harton (dharton) ; wenzhuo...@intel.co
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] ixgbe: initialize scattered_rx during dev_confi
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, August 23, 2017 3:52 AM
> To: David Harton (dharton)
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by
> rte_eth_stats_get
>
> 23/
rte_eth_stats_get() unconditonally would set rx_nombuf
even if the device was setting the value. A check has
been added in rte_eth_stats_get() to leave the device
value in-tact when non-zero.
Signed-off-by: David Harton
---
v2: Fixed braces complaint required by other coding standards.
lib
An application may want to manipulate the MTU settings of
a device without having to start the device first.
In order to remove the need to start the device the
ixgbe/ixgbevf drivers need to initialize the scattered_rx
value during dev_configure.
Signed-off-by: David Harton
---
drivers/net
rte_eth_stats_get() unconditonally would set rx_nombuf
even if the device was setting the value. A check has
been added in rte_eth_stats_get() to leave the device
value in-tact when non-zero.
Signed-off-by: David Harton
---
lib/librte_ether/rte_ethdev.c | 5 -
1 file changed, 4 insertions
eth_ena_dev_init() was not initializing all of the common
pci dev info for the rte_eth_dev. Added call to
rte_eth_copy_pci_info() to complete the init particularly
the driver name.
Signed-off-by: David Harton
---
drivers/net/ena/ena_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
.
Signed-off-by: David Harton
---
drivers/net/i40e/base/i40e_common.c | 12 +---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_common.c
b/drivers/net/i40e/base/i40e_common.c
index 900d379..9779854
Signed-off-by: David Harton
---
v4:
* Added requested release note about ABI change.
doc/guides/rel_notes/release_17_11.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/rel_notes/release_17_11.rst
b/doc/guides/rel_notes/release_17_11.rst
index 170f4f9..e329f8a 100644
--- a
Some devices do not support reset of eth stats. An application may
need to know not to clear shadow stats if the device cannot.
rte_eth_stats_reset is updated to provide a return code to share
whether the device supports reset or not.
Signed-off-by: David Harton
---
v4:
* commented return
> -Original Message-
> From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com]
> Sent: Tuesday, August 08, 2017 5:03 AM
> To: David Harton (dharton) ; tho...@monjalon.net
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3] ethdev: add return code to
>
Some devices do not support reset of eth stats. An application may
need to know not to clear shadow stats if the device cannot.
rte_eth_stats_reset is updated to provide a return code to share
whether the device supports reset or not.
Signed-off-by: David Harton
---
v3:
* overcame noob errors
Some devices do not support reset of eth stats. An application
may need to know not to clear shadow stats if the device cannot.
rte_eth_stats_reset is updated to provide a return code to
share whether the device supports reset or not.
Signed-off-by: David Harton
---
v2:
* Fixed soft tab issue
Some devices do not support reset of eth stats. An application
may need to know not to clear shadow stats if the device cannot.
rte_eth_stats_reset is updated to provide a return code to
share whether the device supports reset or not.
Signed-off-by: David Harton
---
lib/librte_ether
>
> + enicpmd_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK);
> enic->hw_ip_checksum = eth_dev->data-
> >dev_conf.rxmode.hw_ip_checksum;
> return 0;
> }
> --
> 2.7.0
Reviewed-by: David Harton
Tested-by: David Harton
Acked-by: David Harton
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Monday, May 30, 2016 6:48 AM
> To: dev at dpdk.org; Thomas Monjalon ; Helin
> Zhang
> ; Wenzhuo Lu ; Jing Chen
> ; Huawei Xie
> Subject: [d
" Print port eth xstats",
> + .tokens = {
> + (void *)&pcmd_xstats_token_cmd,
> + (void *)&pcmd_int_token_port,
> + NULL
> + },
> +};
> cmdline_parse_inst_t pcmd_ringparam = {
> .f = pcmd_ringparam_callback,
> .data = NULL,
> @@ -858,6 +914,7 @@ cmdline_parse_ctx_t list_prompt_commands[] = {
> (cmdline_parse_inst_t *)&pcmd_stop,
> (cmdline_parse_inst_t *)&pcmd_validate,
> (cmdline_parse_inst_t *)&pcmd_vlan,
> + (cmdline_parse_inst_t *)&pcmd_xstats,
> (cmdline_parse_inst_t *)&pcmd_quit,
> NULL
> };
> --
> 2.5.5
Acked-by: David Harton
_xstats_get(struct rte_eth_dev *dev,
> struct rte_eth_xstats *xstats,
>
> /* TX Priority Stats */
> for (stat = 0; stat < IXGBE_NB_TXQ_PRIO_STATS; stat++) {
> - for (i = 0; i < 8; i++) {
> - snprintf(xstats[count].name, sizeof(xstats[count].name),
> - "tx_priority%u_%s", i,
> - rte_ixgbe_txq_strings[stat].name);
> + for (i = 0; i < IXGBE_NB_TXQ_PRIO_VALUES; i++) {
> + xstats[count].id = count;
> + xstats[count].name[0] = '\0';
> xstats[count].value = *(uint64_t *)(((char *)hw_stats) +
> rte_ixgbe_txq_strings[stat].offset +
> (sizeof(uint64_t) * i));
> count++;
> }
> }
> -
> return count;
> }
>
> --
> 2.5.5
Acked-by: David Harton
> + * Retrieve names of extended statistics of an Ethernet device.
> + *
> + * Names within ptr_strings will be aligned to RTE_ETH_XSTATS_NAME_SIZE
> +and
> + * will be listed in ascending mapping order.
> + *
> + * @param port_id
> + * The port identifier of the Ethernet device.
> + * @param ptr_names
> + * Block of memory to insert names into. Must be at least limit in size.
> + * @param limit
> + * Capacity of ptr_strings (number of names).
> + * @return
> + * If successful, number of statistics; negative on error.
> + */
> +int rte_eth_xstats_names(uint8_t port_id, struct rte_eth_xstats_name
> *ptr_names,
> + unsigned limit);
> +
> +/**
> + * Retrieve number of extended statistics of an Ethernet device.
> + *
> + * Names within ptr_strings will be aligned to RTE_ETH_XSTATS_NAME_SIZE
> +and
> + * will be listed in ascending mapping order.
> + *
> + * @param port_id
> + * The port identifier of the Ethernet device.
> + * @return
> + * If successful, number of statistics; negative on error.
> + */
> +int rte_eth_xstats_count(uint8_t port_id);
> +
> +/**
> * Retrieve extended statistics of an Ethernet device.
> *
> * @param port_id
> --
> 2.5.5
Acked-by: David Harton
> -Original Message-
> From: Remy Horton [mailto:remy.horton at intel.com]
> Sent: Tuesday, May 03, 2016 8:23 AM
> To: David Harton (dharton) ; dev at dpdk.org; Helin
> Zhang
>
> Subject: Re: [dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change
> xstats to us
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, April 15, 2016 10:44 AM
> To: dev at dpdk.org; Helin Zhang
> Subject: [dpdk-dev] [RFC PATCH v1 2/3] drivers/net/ixgbe: change xstats to
> use integers
>
> Signed-off-by: Remy Horton
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, April 15, 2016 10:44 AM
> To: dev at dpdk.org; Thomas Monjalon
> Subject: [dpdk-dev] [RFC PATCH v1 1/3] rte: change xstats to use integer
> keys
>
> Signed-off-by: Remy Horton
> --
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, April 15, 2016 10:44 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from
> xstats
>
> The current extended ethernet statistics fetching in
Happy Friday,
> -Original Message-
> From: Remy Horton [mailto:remy.horton at intel.com]
> Sent: Friday, April 29, 2016 6:22 AM
> To: David Harton (dharton) ; Tahhan, Maryam
> ; dev at dpdk.org
> Cc: Mcnamara, John ; Van Haaren, Harry
>
> Subject: Re: [dpdk-dev] [
> -Original Message-
> From: Tahhan, Maryam [mailto:maryam.tahhan at intel.com]
> Sent: Thursday, April 28, 2016 10:56 AM
> To: David Harton (dharton) ; Horton, Remy
> ; dev at dpdk.org
> Cc: Mcnamara, John ; Van Haaren, Harry
>
> Subject: RE: [dpdk-dev] [RFC PAT
> -Original Message-
> From: Mcnamara, John [mailto:john.mcnamara at intel.com]
> Sent: Wednesday, April 20, 2016 12:50 PM
> To: David Harton (dharton) ; Horton, Remy
> ; dev at dpdk.org
> Cc: Van Haaren, Harry
> Subject: RE: [dpdk-dev] [RFC PATCH v1 0/3] Remove s
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, April 15, 2016 10:44 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [RFC PATCH v1 0/3] Remove string operations from
> xstats
>
> The current extended ethernet statistics fetching inv
1 - 100 of 116 matches
Mail list logo
