On Fri, Jul 18, 2025 at 05:05:45PM +0100, Kevin Traynor wrote:
> On 18/07/2025 16:19, Bruce Richardson wrote:
> > On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote:
> >> On 03/07/2025 15:31, Ciara Loftus wrote:
> >>> The SSE rx and tx paths will be remov
: e0dcf94a0d7f ("net/ice: support VLAN ops")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/i40e/i40e_rxtx.c | 10 +++---
drivers/net/intel/iavf/iavf_rxtx.c | 12 +++-
drivers/net/intel/ice/ice_rxtx.c | 10 +++---
3 files changed, 21 insert
On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote:
> On 03/07/2025 15:31, Ciara Loftus wrote:
> > The SSE rx and tx paths will be removed from the i40e, iavf and ice
> > drivers in the 25.11 release. Each of these drivers have faster vector
> > paths (AVX2 and AVX-512) which have featur
On Fri, Jul 18, 2025 at 03:33:46PM +0100, Bruce Richardson wrote:
> When processing cmdline arguments in DPDK, we always do so with very
> little context. So, for example, when processing the "-l" flag, we have
> no idea whether there will be later a --proc-type=secondary flag.
Use a utility function and macro to simplify the code for checking for
conflicting cmdline options. The checking can also be done at the
initial argument collating stage, shortening the argument
processing function which is very much on the long side.
Signed-off-by: Bruce Richardson
---
lib/eal
Remove the separate function to check combinations of cmdline
parameters. Instead, just do those checks when parsing the parameters
since we have all info about what parameters are provided at that point.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_memory.c | 3 +-
lib/eal
args saved, and no run_once sentinel value,
but updating it keeps it consistent with FreeBSD and Linux versions.
Signed-off-by: Bruce Richardson
---
NOTE: this patch can probably be squashed in with the changes in the
previous one, but for easier review I've kept it separate for now.
--
-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 877 ++--
lib/eal/common/eal_options.h| 10 +-
lib/eal/common/eal_private.h| 11 +
lib/eal/freebsd/eal.c | 164 +-
lib/eal/linux/eal.c | 379 +---
lib
This table should allow us to parse all the eal args into a single
structure for later parsing in a fixed-order field basis. For those
elements that take multiple values, define a TAILQ and a callback to
process those elements.
Signed-off-by: Bruce Richardson
---
lib/eal/common
rvice-coremask option from the docs, rather than adding its
new long option.
Signed-off-by: Bruce Richardson
---
doc/guides/linux_gsg/eal_args.include.rst | 20
lib/eal/common/eal_common_options.c | 9 +
lib/eal/common/eal_options.h | 16 ++
When the arguments passed to argparse include -h/--help then usage
information is automatically printed. Provide the capability for the
user to supply their own help function for this.
Signed-off-by: Bruce Richardson
---
doc/guides/prog_guide/argparse_lib.rst | 16
lib/argparse
Make the function to print out the help text for an argparse object a
public function, which takes as a new parameter the file stream on which
to print. This can be used in future to allow application to extend
their own help information.
Signed-off-by: Bruce Richardson
---
lib/argparse
for
C conditional checks") which introduced the RTE_EXEC_ENV for a different
purpose. Now we can fix the docs with the new name reference.
Signed-off-by: Bruce Richardson
---
config/meson.build | 1 +
doc/guides/contributing/design.rst | 2 +-
2 files changed, 2 insert
e argument parsing for EAL
is much more centralised into common options. This single list with
ifdefs makes it clear to the viewer what options are common across OS's,
vs what are unix-only or linux-only.
Bruce Richardson (9):
build: add define for the OS environment name
argparse: export fu
On Fri, Jul 18, 2025 at 02:45:48PM +0200, David Marchand wrote:
> On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson
> wrote:
> > diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
> > index d3caa3a3b4..a9ff87e863 100644
> > --- a/drivers/net/virt
On Fri, Jul 18, 2025 at 02:21:45PM +0200, David Marchand wrote:
> On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson
> wrote:
> >
> > DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove
> > checks and workarounds for versions old than these.
> >
>
DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove
checks and workarounds for versions old than these.
Signed-off-by: Bruce Richardson
---
config/meson.build | 5
drivers/event/meson.build | 5 +---
drivers/meson.build | 2
On Thu, Jul 17, 2025 at 02:16:04PM +0800, hailinx wrote:
> Signed-off-by: hailinx
> ---
> doc/guides/nics/ixgbe.rst | 21 +
> 1 file changed, 21 insertions(+)
Acked-by: Bruce Richardson
>
> diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics
On Thu, Jul 17, 2025 at 02:16:03PM +0800, hailinx wrote:
> Signed-off-by: hailinx
> ---
Acked-by: Bruce Richardson
The tables in this file really need pruning in next release. They stretch
all the way back almost 10 years!
> doc/guides/nics/i40e.rst | 4
> 1 file changed,
On Fri, Jul 18, 2025 at 10:00:08AM +0800, hailinx wrote:
> Signed-off-by: hailinx
> ---
> doc/guides/nics/ice.rst | 23 +--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
Acked-by: Bruce Richardson
For next release update, I think we can prune the
On Thu, Jul 17, 2025 at 05:03:13PM -0400, Dean Marx wrote:
> I've created a v1 of a QinQ test suite around the set of test cases
> discussed earlier (which is not set in stone, and I expect it to
> change significantly across many future versions.) The PASS/FAIL
> values can be mostly disregarded i
On Thu, Jul 17, 2025 at 01:46:04PM +0200, David Marchand wrote:
> Rather than have a subset of the EAL parameters described in the sample
> apps documentation, prefer referring to the full list.
>
> Signed-off-by: David Marchand
> ---
Acked-by: Bruce Richardson
ng started guide for freebsd")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Acked-by: Bruce Richardson
On Thu, Jul 17, 2025 at 12:41:46PM +0200, David Marchand wrote:
> On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson
> wrote:
> >
> > This RFC is a second, more complete, prototype of one approach we may
> > want to take to help improve management of EAL cmdline argum
On Thu, Jul 17, 2025 at 11:42:32AM +0200, David Marchand wrote:
> The -S option is not described in EAL usage().
>
> Fixes: 7dbd7a6413ef ("service: add -S corelist option")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
> ---
Acked-by: Bruce
On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote:
> On Wed, Jul 16, 2025 at 7:39 PM Bruce Richardson
> wrote:
> >
> > The specific placement of outer/inner VLAN tags in E810 and related NICs
> > is configurable. Therefore, remove the assumption that if the L2
On Wed, Jul 16, 2025 at 03:24:55PM -0400, Dean Marx wrote:
> I've created a list of test cases which I'm planning on implementing
> in future QinQ testing. After talking with Bruce about some Intel test
> results earlier, I've got a solid idea of what the expected behaviors
> are in five of these,
issue where, with QinQ packets with different Tag ethtypes
(0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only
having had one tag stripped.
Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/ice/
On Wed, Jul 16, 2025 at 12:15:16PM +0200, Thomas Monjalon wrote:
> Time has passed since Mellanox acquisition by NVIDIA.
> No need to explain this anymore.
>
> Signed-off-by: Thomas Monjalon
> ---
I wonder if we should include in DPDK a "future_cleanups" doc which
describes cleanups that can or
On Mon, Jul 14, 2025 at 04:09:11PM -0400, Dean Marx wrote:
> On Mon, Jul 14, 2025 at 9:30 AM Bruce Richardson
> wrote:
> >
> > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and
> > not very well documented. Even the documentation that does exist a
On Tue, Jul 15, 2025 at 05:04:42PM +0200, Morten Brørup wrote:
> FYI:
> Last time I looked, it seemed like the VLAN/QINQ "tag present" mbuf RX flags
> were only set along with the RX _STRIPPED flags, i.e. not set when stripping
> was not enabled.
> Although setting the "tag present" flags (and th
n to changing the structures. However, for the actual
implementation we'll have to review the changes to ensure they are clear
enough to allow potential alternative implementations. For example, I
worry about just having one "QoS" flag defined - how would we manage if
different QoS schemes are implemented by various hw vendors in different
ways?
For the notice about structure changes though:
Acked-by: Bruce Richardson
; DPDK 25.11.
> + Modern x86 systems all support AVX2, if not AVX-512, so the SSE path is no
> longer
> + widely used. This change will not result in any feature loss, as the
> fallback
> + scalar paths which have feature parity with SSE will be used in the cases
> where
> + the SSE paths would have been used.
> +
Acked-by: Bruce Richardson
For testing purposes it can be desirable to enable RSS even when only a
single queue per port is in use. Add an "enable-rss" flag to testpmd to
match the existing "disable-rss" flag.
Signed-off-by: Bruce Richardson
---
app/test-pmd/parameters.c | 13 +
app/test-p
On Mon, Jul 14, 2025 at 04:09:11PM -0400, Dean Marx wrote:
> On Mon, Jul 14, 2025 at 9:30 AM Bruce Richardson
> wrote:
> >
> > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and
> > not very well documented. Even the documentation that does exist a
On Mon, Jul 14, 2025 at 01:45:14PM -0700, Stephen Hemminger wrote:
> The lines in .mailmap are supposed to be sorted, they have
> gotten out of order over time.
>
> Signed-off-by: Stephen Hemminger
> ---
> .mailmap | 70
> 1 file changed,
On Mon, Jul 14, 2025 at 06:33:43PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Monday, 14 July 2025 15.30
> >
> > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and
> > not very well docu
: de5da9d16430 ("net/ice: support double VLAN")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
drivers/net/intel/ice/ice_ethdev.c | 75 ++
1 file changed, 3 insertions(+), 72 deletions(-)
diff --git a/drivers/net/intel/ice/ice_ethdev.c
b/drivers/net
On Mon, Jul 14, 2025 at 08:06:54AM -0700, Stephen Hemminger wrote:
> On Mon, 14 Jul 2025 14:30:14 +0100
> Bruce Richardson wrote:
>
> > The behaviour of VLAN tag stripping Rx offloads is unclear in DPDK, and
> > not very well documented. Even the documentation th
| Inner tag in vlan_tci |
+---+--+----+
Signed-off-by: Bruce Richardson
---
doc/guides/nics/features.rst | 21 +
lib/ethdev/rte_ethdev.h | 20
lib/mbuf/rte_mbuf_core.h | 36
3 fil
On Wed, Jul 09, 2025 at 08:02:30PM +0200, Morten Brørup wrote:
> Are there any access control mechanisms to govern what a secondary process
> can do to a primary process?
>
> Let's say I'm running a primary process, and want to allow only authorized
> secondary processes to attach to it. No unau
On Wed, Jul 09, 2025 at 04:59:51PM +0200, Morten Brørup wrote:
> Looking at the i40e driver source code, I think it doesn't conform to the API
> when requesting small bursts.
>
> Let's say the hardware has received 31 packets.
> rte_eth_rx_burst(...,16) will return 16 packets and leave 15 in the
st, which
> will fix the compilation error due to correctly disabling 16-byte Rx
> descriptor support.
>
> Bugzilla ID: 1749
>
> Fixes: 11276ec5e042 ("net/iavf: use common Rx rearm")
>
> Signed-off-by: Anatoly Burakov
> ---
Acked-by: Bruce Richardson
On Wed, Jul 09, 2025 at 02:30:42PM +0200, David Marchand wrote:
> Hi Bruce,
>
> On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson
> wrote:
> >
> > This RFC is a second, more complete, prototype of one approach we may
> > want to take to help improve manag
g more parts of DPDK with UBSan.
>
> Though the calling code can explicitly request alignment,
> we would prefer to put the alignment constraints as part of the
> structure definition itself.
>
> Such changes are ABI breakages.
>
> Signed-off-by: David Marchand
> ---
Acked-by: Bruce Richardson
On Tue, Jul 08, 2025 at 04:15:36PM +0100, Bruce Richardson wrote:
> On Tue, Jul 08, 2025 at 05:07:05PM +0200, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Tuesday, 8 July 2025 12.16
> > >
> > > On Tue, J
On Tue, Jul 08, 2025 at 11:41:01AM -0700, Stephen Hemminger wrote:
> On Tue, 8 Jul 2025 17:20:34 +
> Bruce Richardson wrote:
>
> > This RFC is a second, more complete, prototype of one approach we may
> > want to take to help improve management of EAL cmdline arguments
Use a utility function and macro to simplify the code for checking for
conflicting cmdline options. The checking can also be done at the
initial argument collating stage, shortening the argument
processing function which is very much on the long side.
Signed-off-by: Bruce Richardson
---
lib/eal
Remove the separate function to check combinations of cmdline
parameters. Instead, just do those checks when parsing the parameters
since we have all info about what parameters are provided at that point.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_memory.c | 3 +-
lib/eal
-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 877 ++--
lib/eal/common/eal_options.h| 10 +-
lib/eal/common/eal_private.h| 11 +
lib/eal/freebsd/eal.c | 164 +-
lib/eal/linux/eal.c | 379 +---
lib
This table should allow us to parse all the eal args into a single
structure for later parsing in a fixed-order field basis. For those
elements that take multiple values, define a TAILQ and a callback to
process those elements.
Signed-off-by: Bruce Richardson
---
lib/eal/common
To simplify future rework of the EAL arg handling, add a long-option
equivalent for each short option that doesn't already have one.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 9 +
lib/eal/common/eal_options.h| 16
2 files ch
simple and correct, but the advantage
of #2 is that is makes it easier to move scripts and commandline args
between platforms - but at the cost of the arg list shown by help to be
less accurate.
Bruce Richardson (5):
eal: add long options for each short option
eal: define the EAL parameters in argpa
On Tue, Jul 08, 2025 at 05:07:05PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Tuesday, 8 July 2025 12.16
> >
> > On Tue, Jul 08, 2025 at 12:00:42AM +0200, Morten Brørup wrote:
> > >From: Vladimir Medve
On Tue, Jul 08, 2025 at 02:53:03PM +0200, David Marchand wrote:
> On Tue, Jul 8, 2025 at 2:48 PM Bruce Richardson
> wrote:
> >
> > On Tue, Jul 08, 2025 at 02:28:20PM +0200, David Marchand wrote:
> > > In the absence of drivers, skip tests instead of failing.
>
On Tue, Jul 08, 2025 at 02:46:04PM +0200, David Marchand wrote:
> On Tue, Jul 8, 2025 at 2:44 PM Bruce Richardson
> wrote:
> >
> > On Tue, Jul 08, 2025 at 02:28:16PM +0200, David Marchand wrote:
> > > Content (param[]) of received multiprocess messages are aligned with
On Tue, Jul 08, 2025 at 02:28:21PM +0200, David Marchand wrote:
> Skip the test in the absence of the required skeleton driver.
>
> Signed-off-by: David Marchand
Acked-by: Bruce Richardson
> ---
> app/test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, Jul 08, 2025 at 02:28:20PM +0200, David Marchand wrote:
> In the absence of drivers, skip tests instead of failing.
>
> Signed-off-by: David Marchand
> ---
> app/test/meson.build | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/meson.build b/a
On Tue, Jul 08, 2025 at 02:28:16PM +0200, David Marchand wrote:
> Content (param[]) of received multiprocess messages are aligned with
> a 4 bytes constraint.
>
> Before patch:
> struct mp_msg_internal {
> int type; /* 0 4 */
> struct rte
aresystems.com>:
>
> > From: Bruce Richardson [mailto:[2]bruce.richard...@intel.com]
> > Sent: Friday, 4 July 2025 13.32
> > Hi all,
> >
> > this email discussion comes at a bit of a fortunate time for me,
> as I'm
>
ing of SW flow types to HW
> pctypes")
> Cc: sta...@dpdk.org
>
Reported-by: Morten Brørup
> Signed-off-by: Dhanya Pillai
Acked-by: Bruce Richardson
Applied to dpdk-next-net-intel,
Thanks,
/Bruce
ad CLI commands..."
is a little ambiguous, as it could mean "I have read", or "Go and read",
i.e. job done or job about to start. Tweak the text to "Finished reading"
which is unambiguous.
Signed-off-by: Bruce Richardson
---
Owing to limitations of whats av
e
users to have a library of pre-canned cmdline files and pass multiple of
these in to the same run, e.g. have one cmdline file per NIC feature and
enable multiple features by passing in multiple filenames.
Signed-off-by: Bruce Richardson
---
app/test-pmd/parameters.c
when
loading multiple files.
Bruce Richardson (3):
app/testpmd: explicitly set command echoing on file load
app/testpmd: allow multiple commandline file parameters
app/testpmd: improve output when processing cmdline files
app/test-pmd/cmdline.c | 100
cho" command to match the "load" command.
Signed-off-by: Bruce Richardson
---
app/test-pmd/cmdline.c | 51 +++--
app/test-pmd/testpmd.c | 2 +-
app/test-pmd/testpmd.h | 2 +-
doc/guides/testpmd_app_ug/test
ad CLI commands..."
is a little ambiguous, as it could mean "I have read", or "Go and read",
i.e. job done or job about to start. Tweak the text to "Finished reading"
which is unambiguous.
Signed-off-by: Bruce Richardson
---
app/test-pmd/cmdline.c
e
users to have a library of pre-canned cmdline files and pass multiple of
these in to the same run, e.g. have one cmdline file per NIC feature and
enable multiple features by passing in multiple filenames.
Signed-off-by: Bruce Richardson
---
app/test-pmd/parameters.c
cho" command to match the "load" command.
Signed-off-by: Bruce Richardson
---
app/test-pmd/cmdline.c | 51 +++--
app/test-pmd/testpmd.c | 2 +-
app/test-pmd/testpmd.h | 2 +-
doc/guides/testpmd_app_ug/test
uses a global flag for
that - shared between cmdline parameters and interactive CLI commands.
V2:
* remove global echo flag, and now support echo/noecho per file loaded
* when echoing, output the file being processed, to clarify things when
loading multiple files.
Bruce Richardson (3):
app
e
users to have a library of pre-canned cmdline files and pass multiple of
these in to the same run, e.g. have one cmdline file per NIC feature and
enable multiple features by passing in multiple filenames.
Signed-off-by: Bruce Richardson
---
app/test-pmd/cmdline.c| 11 ---
ap
On Fri, Jul 04, 2025 at 12:18:45PM +0200, Morten Brørup wrote:
> > From: Dengdui Huang [mailto:huangdeng...@huawei.com]
> > Sent: Thursday, 3 July 2025 11.30
> >
> > The current rte_net_get_ptype() only supports parsing packets with
> > one 0x8100 VLAN tag or two 0x88a8 VLAN tags. This patch exten
On Thu, Jul 03, 2025 at 05:29:26PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Thursday, 3 July 2025 17.21
> >
> > On Thu, Jul 03, 2025 at 05:12:46PM +0200, Morten Brørup wrote:
> > > > From: Br
On Thu, Jul 03, 2025 at 05:12:46PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Thursday, 3 July 2025 16.14
> >
> > On Thu, Jul 03, 2025 at 03:59:14PM +0200, Morten Brørup wrote:
> > > For TX mbuf fast rele
On Thu, Jul 03, 2025 at 03:59:14PM +0200, Morten Brørup wrote:
> For TX mbuf fast release offload, I propose to add the mbuf mempool
> pointer to the ethdev tx queue configuration structure,
> so the ethdev TX burst operation doesn't need to fetch it from the
> first mbuf of each burst being fast f
On Thu, Jul 03, 2025 at 12:16:24PM +, Ciara Loftus wrote:
> The SSE rx and tx paths will be removed from the i40e, iavf and ice
> drivers in the 25.11 release. Each of these drivers have faster vector
> paths (AVX2 and AVX-512) which have feature parity with the soon to be
> removed SSE paths.
On Thu, Jul 03, 2025 at 03:50:46PM +0530, Amiya Ranjan Mohakud wrote:
> Ensure the correct virtchnl op is called for disabling vlan stripping by
> checking if the device supports either v1 or v2 vlan capability and
> choosing the op accordingly.
>
> Bugzilla ID:1735
> Cc: sta...@dpdk.org
> Fixes:
dev/null | grep AVX512 | wc
-l
0
gcc -march=haswell -march=skylake-avx512 -dM -E - < /dev/null | grep AVX512 |
wc -l
5
Bugzilla ID: 1736
Fixes: e361ae3f59d3 ("build: reduce use of AVX compiler flags")
Signed-off-by: Bruce Richardson
---
V3: fix build when using meson 0.57 whic
On Wed, Jul 02, 2025 at 11:22:42AM -0700, Stephen Hemminger wrote:
> On Wed, 2 Jul 2025 17:00:45 +0100
> Bruce Richardson wrote:
>
> > Some older compilers e.g. gcc 8.5, do not support overriding
> > -march=native with another architecture, leading to build warnings su
dev/null | grep AVX512 | wc
-l
0
gcc -march=haswell -march=skylake-avx512 -dM -E - < /dev/null | grep AVX512 |
wc -l
5
Bugzilla ID: 1736
Fixes: e361ae3f59d3 ("build: reduce use of AVX compiler flags")
Signed-off-by: Bruce Richardson
---
config/x86/meson.build | 7 ++-
1 file ch
On Wed, Jul 02, 2025 at 04:51:29PM +0100, Bruce Richardson wrote:
> Some older compilers e.g. gcc 8.5, do not support overriding
> -march=native with another architecture, leading to build warnings such
> as reported in Bugzilla (link below). Add a check for that case, and
> explic
ev/null | grep AVX
gcc -march=haswell -march=skylake-avx512 -dM -E - < /dev/null | grep AVX
...
Bugzilla ID: 1736
Fixes: e361ae3f59d3 ("build: reduce use of AVX compiler flags")
Signed-off-by: Bruce Richardson
---
config/x86/meson.build | 7 ++-
1 file changed, 6 insertions(+),
On Wed, Jul 02, 2025 at 09:36:49AM -0400, Khadem Ullah wrote:
> Some Intel Xeon processors (e.g., E5 v3 Haswell) do not support AVX-512
> instructions, and building DPDK targeting 'native' instruction set can
> fail with 'target specific option mismatch' errors.
>
> This patch updates the build gu
he copy
> function it no longer knew that.
>
> The workaround is to put the copy inside the same function
> and use structure assignment. Also macro should be upper case.
>
> Fixes: 6c5c6571601c ("argparse: verify argument config")
> Cc: fengcheng...@huawei.com
>
> Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
true,
> test_event_vector_adapter);
> +/* disabled because of reported failures, waiting for a fix
> + * REGISTER_FAST_TEST(event_vector_adapter_autotest, true, true,
> test_event_vector_adapter);
> + */
> --
Acked-by: Bruce Richardson
Thanks for this. It will be good to have patchwork reports "clean" again.
/Bruce
On Fri, Jun 27, 2025 at 04:31:20PM +0200, Burakov, Anatoly wrote:
> On 6/27/2025 3:52 PM, Bruce Richardson wrote:
> > When VLAN or QinQ stripping is enabled in the ice driver, an
> > inconsistency was observed between the placement of the VLAN tag in the
> > descriptors
-list based versions instead.
Depends-on: series-35540 ("use core lists not masks in documentation")
Signed-off-by: Bruce Richardson
Acked-by: Vipin Varghese
Acked-By: Anatoly Burakov
Acked-by: Konstantin Ananyev
---
V2:
* updated freebsd GSG doc
* additional changes to linux GSG samp
alignment
> 0x7ffd9c67f228: note: pointer points here
> 00 00 00 00 c0 5d 3e 00 01 00 00 00 01 00 00 00 00 00 00 00
> ^
> 00 00 00 00 00 00 00 00 00 00 00 00
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
> ../lib/eal/x86/include/rte_atomic_64.h:206:21 in
&g
ent
>
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Acked-by: Bruce Richardson
> ---
> lib/hash/rte_thash.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ha
i.com
>
> Signed-off-by: Stephen Hemminger
> ---
> v2 - simpler fix is to just inline the copy
>
> app/test/test_argparse.c | 31 +++
> 1 file changed, 15 insertions(+), 16 deletions(-)
>
LGTM. One suggestion inline, in case you feel like adjusting
On Mon, Jun 30, 2025 at 03:11:30PM +0200, David Marchand wrote:
> Hello Bruce,
>
> On Tue, Jun 24, 2025 at 3:35 PM Bruce Richardson
> wrote:
> >
> > For the guides for applications and examples, use the "-l" flag rather
> > than the "-c" flag t
All supported linux versions support F_ADD_SEALS (Linux 3.17+) and
MFD_HUGETLB (Linux 4.14+), so no need to have #ifdefs and fallbacks to
support systems which do not support those features.
Signed-off-by: Bruce Richardson
---
drivers/net/memif/rte_eth_memif.h | 41
All supported linux versions support F_ADD_SEALS (Linux 3.17+) and
MFD_HUGETLB (Linux 4.14+), so no need to have #ifdefs and fallbacks to
support systems which do not support those features.
Signed-off-by: Bruce Richardson
---
lib/vhost/vhost_user.c | 7 ---
1 file changed, 7 deletions
All supported linux versions support F_ADD_SEALS (Linux 3.17+) and
MFD_HUGETLB (Linux 4.14+), so no need to have #ifdefs and fallbacks to
support systems which do not support those features.
Signed-off-by: Bruce Richardson
---
lib/eal/linux/eal_memalloc.c | 174
/sys_reqs.html#system-software
Bruce Richardson (3):
eal/linux: remove fallbacks for old Linux versions
vhost: : remove fallbacks for old Linux versions
memif: : remove fallbacks for old Linux versions
drivers/net/memif/rte_eth_memif.h | 41 ---
lib/eal/linux/eal_memalloc.c | 174
{
| ^
1 error generated.
Fix the error by omitting the persistent_data field when it is
zero-sized, since it's unusable. Any app using the field must already
specify a size for the persistent data.
Fixes: 746e8736da70 ("node: add global mbuf dynfield")
Signe
{
| ^
1 error generated.
Fix the error by defaulting to a having a 1-byte sized union rather than
zero-sized.
Fixes: 746e8736da70 ("node: add global mbuf dynfield")
Signed-off-by: Bruce Richardson
---
lib/node/rte_node_mbuf_dynfield.h | 5 +++--
1 file
On Fri, Jun 27, 2025 at 04:59:53PM +0800, Yuan Wang wrote:
> Since the default value of the port mask is set to 0, the port mask does
> not change in some cases when creating SCTP flow rules, which results in
> incorrect L4P register configuration.
>
> This patch fixes this issue by setting the ma
On Fri, Jun 27, 2025 at 09:22:35AM -0700, Stephen Hemminger wrote:
> The rte_argparse API use variable length arrays for the args.
> But the test was only putting space on stack for the argparse
> part, not the args. This can lead to out of bounds writes.
>
> The bug only gets detected if DPDK is
Program python3 (elftools) found: NO
New output:
Program python3 found: YES (/usr/bin/python3)
Program python3 (elftools) found: NO
../buildtools/meson.build:15:31: ERROR: python3 is missing modules: elftools
Signed-off-by: Bruce Richardson
---
buildtools/meson.build | 5 -
1 file
- when updating l2tsel (L2 tag selection) field -
used the queue id, rather than the register index for the queue. Queue 0
is normally HW queue 1, etc., meaning the final queue never had its
field updated.
Fixes: de5da9d16430 ("net/ice: support double VLAN")
Cc: sta...@dpdk.org
Signed-off
1 - 100 of 2054 matches
Mail list logo
