ot;Warning in " substr(last_file,6) ":"
> + print "Warning in " substr(last_file,7) ":"
> print MESSAGE
> exit RET_ON_FAIL
> }
> --
> 2.23.0
>
>
Acked-By: Arnon Warshavsky
Have rte_eal_config_reattach clean up the mapped address
which is a valid address but not the one intended.
Coverity issue: 343439
Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init")
Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary")
Signed-off-
Have rte_eal_config_reattach clean up the mapped address
which is a valid address but not the one intended.
Coverity issue: 343439
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linux/eal/eal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib
This patch changes some void functions to return a value,
so that the init sequence may tear down orderly
instead of calling panic.
Signed-off-by: Arnon Warshavsky
---
The calls for launching core messaging threads were left in tact
in all 3 eal implementations.
This should be addressed in a
On Wed, Jun 5, 2019 at 10:50 AM David Marchand
wrote:
>
>
> On Tue, Jun 4, 2019 at 5:45 PM Arnon Warshavsky wrote:
>
>> This patch changes some void functions to return a value,
>> so that the init sequence may tear down orderly
>> instead of calling panic.
&g
This patch changes some void functions to return a value,
so that the init sequence may tear down orderly
instead of calling panic.
Signed-off-by: Arnon Warshavsky
---
The calls for launching core messaging threads were left in tact
in all 3 eal implementations.
This should be addressed in a
Hi
>
> The part below can go after a --- marker, this is more a comment for the
> work in progress rather than something to put in this patch commitlog.
>
Ack
>
> The calls for launching core messaging threads were left in tact
>> in all 3 eal implementations.
>>
>
> For these I will submit a p
where the PMDs or message threads
may call panic with no context for the user.
For these I will submit a patch suggesting a callback registration,
allowing the user to register a context to be called
in case of a panic that takes place outside the init sequence.
Signed-off-by: Arnon Warshavsky
where the PMDs or message threads
may call panic with no context for the user.
For these I will submit a patch suggesting a callback registration,
allowing the user to register a context to be called
in case of a panic that takes place outside the init sequence.
Signed-off-by: Arnon Warshavsky
where the PMDs or message threads
may call panic with no context for the user.
For these I will submit a patch suggesting a callback registration,
allowing the user to register a context to be called
in case of a panic that takes place outside the init sequence.
Signed-off-by: Arnon Warshavsky
Hi, I plan to work on it on the first week of June. Will be pretty much
off-grid till then.
thanks
/Arnon
On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon
> ---
>
> --
> 2.21.0
>
>
Acked-By: Arnon Warshavsky
>
>
>
> I am preparing a deprecation notice for rte_eal_remote_launch
> and rte_metrics_init.
>
>
> hmm, I followed panic and not exit, so missed rte_metrics_init.
rte_eal_remote_launch currently returns int. what deprecation goes there?
>
>
> Changing 'kni_fifo_init()' return type shouldn't be a problem at all,
> perhaps it would be a problem if the content of the fifo changed but it is
> not
> the case.
>
Should I move this patch to deferred or reject?
For the purpose of removing instances of rte_panic
from the init sequence, some void functions need to change
to return an error code.The planned modifications of 19.08
require to change one eal function and one kni function.
Signed-off-by: Arnon Warshavsky
---
doc/guides/rel_notes
>
>
> What happened to this patchset?
>
> This is definitely an improvement. We must remove rte_panic from libs.
> Arnon, are you still available to rebase this patchset in preparation
> of 19.08? Or someone else?
>
> What are the required API breakages? I see one in ethdev which requires
> a depre
Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky
Explicitly collect the error code of the
multiple awk script calls
---
devtools/checkpatches.sh | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
di
>
> No need for all those checks on $? and the output saving.
>
You blew my cover guys. I am not a shell scripts person :)
You are right. WIll change that
The reason I did not use the && approach is that if both checks have errors,
only the first will be reported and we want all errors to be reported at
once
without discovering them one by one after every fix.
Bugzilla ID: 165
Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
Signed-off-by: Arnon Warshavsky
Explicitly collect the output and result of the
multiple awk script calls, print and return error
if any of them fails
---
devtools/checkpatches.sh | 21 ++
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
v2 - fix typo
v3 - reduce message not to exceed 80 chars
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh
>
>
> I think I prefer passing the string directly.
> You can make a shorter message:
> Using explicit .svg extension in rST instead of .*
> or
> Using explicit .svg extension instead of .*
>
>
> Ok
>
> > + message="Using explicit .svg extension in figures instead of .*"
> > awk -v FOLDERS='doc' \
> > -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
> > -v RET_ON_FAIL=1 \
> > + -v MESSAGE="$message" \
> > -f $(dirname $(readli
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
v2 - spelling typo
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh| 3 +++
2 files changed, 4
Replace the content of warning in the forbidden tokens script
from using the searched regex into using explicit messages
Signed-off-by: Arnon Warshavsky
---
devtools/check-forbidden-tokens.awk | 7 +--
devtools/checkpatches.sh| 3 +++
2 files changed, 4 insertions(+), 6
>
>> Yes it is a good idea.
>> I think it can be a separate patch. Would you like to send it please?
>>
>> Sure. Will do
>
> Just to make sure - I am waiting for your patch to get in, so that I apply
the warning patch for both checks
--
*Arnon Warshavsk
>
>
> Yes it is a good idea.
> I think it can be a separate patch. Would you like to send it please?
>
> Sure. Will do
6:28 PM, Thomas Monjalon
wrote:
> Including svg files with the svg extension is a common mistake:
> .. figure:: example.svg
> must be
> .. figure:: example.*
> So it will work also when building pdf doc with figures converted
> to png files.
>
> A check is add
> > and added an extra backslash
>
> Are you sure we need an extra backslash?
> Note that I am using single quotes.
> I thought we need only 2 backslashes in this case.
>
You are right.
Its only required with double quotes
Hi Thomas
Glad the function gets to be reused :)
Now that it has more than one consumer apparently the function
check_forbidden_additions() cannot be fed by stdin.
I got it working with 3 changes:
1. call the awk script with $tmpinput as a parameter instead of stdin. This
aligns with Neils change
If your patch arrived to your colleagues on the same domain but not to
dev@dpdk,
I would place a bet on your outgoing smtp server not sending it outside
your domain.
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
Acked-by: Andrzej Ostruszka
---
v2 - place original comment in the
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
---
v2 - place original comment in the awk file
devtools/check
On Fri, Sep 21, 2018 at 2:37 PM, Andrzej Ostruszka wrote:
> Acked-by: Andrzej Ostruszka
>
> However you might consider keeping this comment in the awk script.
>
> On 20.09.2018 23:11, Arnon Warshavsky wrote:
> [...]
> > @@ -44,
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
---
devtools/check-forbidden-tokens.awk | 68
> > I was under the wrong impression the opposite was desired, so yes,
> > moving the entire awk code to a separate file would indeed be the
> cleanest.
>
> OK, who can do this change please?
>
>
> I will do the move to a different file later on this week
thanks
/Arnon
> HI
> >
> > Let's use single quotes instead of variable.
> >
> >
> > Using the script directly with single quotes loses the ability to reuse
> it
> > with an additional set of folders , expressions and RET_ON_FAIL.
>
> I don't know awk. Please could you explain what we are loosing and why?
>
The a
I get some warning when running this on Ubuntu 18.04.
>
> marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
> sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
> ./devtools/checkpatches.sh: 52: read: Illegal option -d
>
> Hi,
A patch that fixes that was already sent a few days
++ b/devtools/checkpatches.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#! /bin/bash
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2015 6WIND S.A.
>
> --
> 2.7.4
>
>
Acked-By: Arnon Warshavsky
thanks
/Arnon
Hi Ilya
Let's use single quotes instead of variable.
Using the script directly with single quotes loses the ability to reuse it
with an additional set of folders , expressions and RET_ON_FAIL.
If we wish to keep the awk code in this file and not in a separate file,
maybe receiving the awk script
> + awk -v FOLDERS="lib net drivers" \
>
> I don't know why net is listed as a root directory here?
> I am going to apply the patch without the "net" directory. OK?
>
Yes please. Its not necessarily root rather in any location of the path,
but having added drivers, net is now redundant.
thank
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
>
> One more nit: the title says "additions/removals" but the function is
> only about additions.
>
>
> Yup. No removals there..
> > + read -d '' awk_script << 'EOF'
>
> EOF must be quoted?
>
Missed that one. Yes, the quotes are there to prevent parameter expansion
of the awk variables.
The script breaks without them
> > +check_forbidden_additions() { #
>
> This function looks to work with stdin, not a file.
> Better to remove the comment about a .
>
It can actually work with both but you are right. The comment is not
beneficial there
Will fix with the rest of the list below
...
>
> > + if [ $? -ne 0 ]
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
This is consuming stdin.
> I guess the checkpatch.pl will have nothing to check in the next step.
> We should merge Neil's patch first, because he is adding a tmpfile
> to solve the issue of stdin read only once.
>
Yup. Missed the fact stdin is consumed. temp file is a good idea
>
> > +
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly
> that patches with rte_panic/exit should flag some warning message, but
> the maintainer should have final say. I don't think failing checkpatch
> is the solution for that.
>
Ok. will leave that to the maintainers and change t
On Fri, Apr 27, 2018, 19:40 Thomas Monjalon wrote:
> 27/04/2018 18:31, Arnon Warshavsky:
> > On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote:
> > > What is the status of this patchset?
> > > It seems not ready for RC1 (today).
> > > I don't want to p
On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote:
> 26/04/2018 08:20, Arnon Warshavsky:
> > The purpose of this patch series is to cleanup the library code
> > from paths that end up aborting the process,
> > and move to checking error values, in order to allow the runnin
On Fri, Apr 27, 2018 at 1:08 AM, Arnon Warshavsky wrote:
> Hi Kevin
>
>> > + if (rte_config_init() != 0)
>> > + return -1;
>> > +
>>
>> I'm confused, is this deliberate? there is now two rte_config_init()
>> calls.
>
&g
Hi Kevin
> > + if (rte_config_init() != 0)
> > + return -1;
> > +
>
> I'm confused, is this deliberate? there is now two rte_config_init()
> calls.
Please note that there are 2 eal.c files. One under linux and one under bsd
There is a copy of rte_config_init() in each.
> Aaron'
On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor wrote:
> I think the first line of the commit msg ^^^ should change as it no
> longer prevents but just warns
>
> Actually the return value did not change, only the warning text did.
I would rather keep the word 'prevents' as an intention declaration
>
> Similar to 1/11 in that there is some allocate before this and maybe you
> should jump to the release at the end of the function
>
> >
>
Same as I wrote in 1/10 - I want to handle this not in this patchset
> > -void __rte_experimental
> > +int __rte_experimental
> > rte_eth_dev_owner_delete(const uint64_t owner_id)
> > {
> > uint16_t port_id;
> > + int error;
>
> it's inconsistent that this function returns the error code from
> rte_eth_dev_shared_data_prepare() and all these other functi
> > - if (cryptodev->data->dev_private == NULL)
> > - rte_panic("Cannot allocate memzone for private "
> > - "device data");
> > + if (cryptodev->data->dev_private == NULL) {
> > + DPAA_SEC_ERR("%s() Canno
Hi Kevin
> /* Any memory allocation failure in initialization is critical
> because
> >* resources can't be free, so reinitialization is impossible. */
>
> What about this comment? Not sure if it is just stale or if there is
> something else you need to do.
>
This comment was origin
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
Acked-by: Anatoly Burakov
---
lib/librte_eal/bsdapp/eal/eal.c | 71
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
Acked-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
after rebase
v9:
- Add missing file descriptor closing when retruning with error
Arnon Warshavsky (10):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
Acked-by: Akhil Goyal
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a
Replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
> I think i've already acked this. You should keep acks etc. between
> versions (unless you're making significant enough changes that you think
> would invalidate a prior ack). Having acks makes it easier to track what
> still needs to be reviewed and what is good to go, and it makes it easier
> to
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 69 +++---
lib/librte_eal
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
Replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
after rebase
Arnon Warshavsky (10):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_panic instances in ixgbe driver
eal: replace rte_panic instanc
>
>
> You mixed dpaa2 with bonding in this set.
>
Indeed. Thanks
> Just a general comment - i'm not too familiar with this code, but it looks
> like all of these failures will only happen on thread init. Can we make
> sure it starts?
>
> You can use similar approach to Olivier's (recently merged) thread
> affinity patches, with pthread barriers etc. to ensure th
<...>
>
> + if (rte_config_init() != 0) {
>> + rte_eal_init_alert("Failed to init configuration");
>> + rte_errno = EFAULT;
>> + return -1;
>> + }
>> +
>> + if (rte_mp_channel_init() < 0) {
>> + rte_eal_init_alert("failed to
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 78 +++
lib
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/net/bonding/rte_eth_bond_8023ad.c | 29
bond specific , dpaa2 specific and eventdev specific log macros
Arnon Warshavsky (11):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_panic instances in
Thanks. Same as with dpaa
On Tue, Apr 24, 2018 at 6:06 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Tue, 24 Apr 2018 09:41:57 +0300
> Arnon Warshavsky wrote:
>
> > + if (eventdev->data->dev_private == NULL) {
> > +
>
>
> > + if (cryptodev->data->dev_private == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone
> for private device data",
> > + __func__);
>
> dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro.
>
> You should go th
On Tue, Apr 24, 2018 at 9:44 AM, Arnon Warshavsky wrote:
> please ignore this patchset.
> The v6 formatting is messed up. resending
> Sorry for the mess
>
My bad. Ignore the ignore request
Its gmail thread aggregation view that made me think I mixed v5 and v6.
thanks
/Arnon
1 - 100 of 230 matches
Mail list logo
