RE: [PATCH v3 00/14] add lookup fib nodes in graph library

Hi Morten, >> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] >> Sent: Monday, 2 June 2025 08.36 >> >> This patch series adds two inbuilt nodes ip4_lookup_fib and >> ip6_lookup_fib in graph library. These nodes uses the existing >> Forwarding Information Bas

[PATCH v3 14/14] doc: add FIB nodes in graph guide

Adds the ip4_lookup_fib and ip6_lookup_fib nodes in inbuilt nodes section of graph guide. Signed-off-by: Ankur Dwivedi --- doc/guides/prog_guide/graph_lib.rst | 32 .../img/graph_inbuilt_node_flow.svg | 150 +- 2 files changed, 108 insertions(+), 74

[PATCH v3 13/14] app/graph: add IP6 lookup mode command

Adds a command to setup lookup mode for IP6 packets. By default LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP6 lookup fib node. Signed-off-by: Ankur Dwivedi

[PATCH v3 11/14] node: add process callback for IP6 FIB

Adds the process callback function for ip6_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 148 ++ 1 file changed, 148 insertions(+) diff --git a/lib/node/ip6_lookup_fib.c b/lib/node/ip6_lookup_fib.c index b510452ad8..3df61890e9

[PATCH v3 12/14] node: add next node in packet classification

The ip6_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/rte_node_pkt_cls_api.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index f6e76989bc..ca323ea573

[PATCH v3 10/14] node: add IP6 FIB route add

Adds a public function to add IP6 route to FIB. The applications should call this function to add IP6 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 35 +++ lib/node/rte_node_ip6_api.h | 19 +++ 2 files changed, 54

[PATCH v3 08/14] fib: move macro to header file

Moves the macro FIB6_NAMESIZE to header file and rename it to RTE_FIB6_NAMESIZE. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib6.c | 11 --- lib/fib/rte_fib6.h | 3 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/fib/rte_fib6.c b/lib/fib/rte_fib6.c index

[PATCH v3 09/14] node: add IP6 lookup FIB node

Adds a lookup FIB node for IP6. Adds a public function to do fib configuration from application. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 139 lib/node/meson.build| 1 + lib/node/rte_node_ip6_api.h | 15 3 files changed

[PATCH v3 06/14] node: add next node in packet classification

The ip4_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/rte_node_pkt_cls_api.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 5d6409fdbf..f6e76989bc

[PATCH v3 04/14] node: add process callback for IP4 FIB

Adds the process callback function for ip4_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 154 ++ 1 file changed, 154 insertions(+) diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c index f300266c00..f9a5c5aa5a

[PATCH v3 07/14] app/graph: add IP4 lookup mode command

Adds a command to setup lookup mode for IP4 packets. By default the LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP4 lookup fib node. Signed-off-by: Ankur

[PATCH v3 05/14] node: move next nodes to public header file

Moves the next nodes of packet classification node to a public header files, so that it can be used from applications. Signed-off-by: Ankur Dwivedi --- lib/node/meson.build| 1 + lib/node/pkt_cls.c | 33 +++-- lib/node/pkt_cls_priv.h

[PATCH v3 03/14] node: add IP4 FIB route add

Adds a public function to add IP4 route to FIB. The applications should call this function to add IP4 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 37 + lib/node/rte_node_ip4_api.h | 19 +++ 2 files changed, 56

[PATCH v3 01/14] fib: move macro to header file

Moves RTE_FIB_NAMESIZE to header file, in order to use it outside the fib library. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib.c | 3 --- lib/fib/rte_fib.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c index 2c05d46500

[PATCH v3 02/14] node: add IP4 lookup FIB node

Adds a lookup FIB node for IP4. Adds a public function to do fib configuration from application. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 141 lib/node/meson.build| 3 +- lib/node/rte_node_ip4_api.h | 15 3 files changed

[PATCH v3 00/14] add lookup fib nodes in graph library

classification next nodes id in public header file, so that they can be used by library and application. - Changed the macro FIB_DEFAULT_NH to point to pkt drop node. Ankur Dwivedi (14): fib: move macro to header file node: add IP4 lookup FIB node node: add IP4 FIB route add node: add process

[PATCH v2 10/13] node: add IP6 FIB route add

Adds a public function to add IP6 route to FIB. The applications should call this function to add IP6 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 35 +++ lib/node/rte_node_ip6_api.h | 19 +++ 2 files changed, 54

[PATCH v2 00/13] add lookup fib nodes in graph library

, so that they can be used by library and application. - Changed the macro FIB_DEFAULT_NH to point to pkt drop node. Ankur Dwivedi (13): fib: move macro to header file node: add IP4 lookup FIB node node: add IP4 FIB route add node: add process callback for IP4 FIB node: move next nodes

[PATCH v2 04/13] node: add process callback for IP4 FIB

Adds the process callback function for ip4_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 154 ++ 1 file changed, 154 insertions(+) diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c index f300266c00..f9a5c5aa5a

[PATCH v2 02/13] node: add IP4 lookup FIB node

Adds a lookup FIB node for IP4. Adds a public function to do fib configuration from application. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 141 lib/node/meson.build| 3 +- lib/node/rte_node_ip4_api.h | 15 3 files changed

[PATCH v2 08/13] fib: move macro to header file

Moves the macro FIB6_NAMESIZE to header file and rename it to RTE_FIB6_NAMESIZE. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib6.c | 11 --- lib/fib/rte_fib6.h | 3 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/fib/rte_fib6.c b/lib/fib/rte_fib6.c index

[PATCH v2 05/13] node: move next nodes to public header file

Moves the next nodes of packet classification node to a public header files, so that it can be used from applications. Signed-off-by: Ankur Dwivedi --- lib/node/meson.build| 1 + lib/node/pkt_cls.c | 33 +++-- lib/node/pkt_cls_priv.h

[PATCH v2 06/13] node: add next node in packet classification

The ip4_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/rte_node_pkt_cls_api.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 5d6409fdbf..f6e76989bc

[PATCH v2 09/13] node: add IP6 lookup FIB node

Adds a lookup FIB node for IP6. Adds a public function to do fib configuration from application. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 139 lib/node/meson.build| 1 + lib/node/rte_node_ip6_api.h | 15 3 files changed

[PATCH v2 12/13] node: add next node in packet classification

The ip6_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/rte_node_pkt_cls_api.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index f6e76989bc..ca323ea573

[PATCH v2 13/13] app/graph: add IP6 lookup mode command

Adds a command to setup lookup mode for IP6 packets. By default LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP6 lookup fib node. Signed-off-by: Ankur Dwivedi

[PATCH v2 11/13] node: add process callback for IP6 FIB

Adds the process callback function for ip6_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 148 ++ 1 file changed, 148 insertions(+) diff --git a/lib/node/ip6_lookup_fib.c b/lib/node/ip6_lookup_fib.c index b510452ad8..3df61890e9

[PATCH v2 07/13] app/graph: add IP4 lookup mode command

Adds a command to setup lookup mode for IP4 packets. By default the LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP4 lookup fib node. Signed-off-by: Ankur

[PATCH v2 03/13] node: add IP4 FIB route add

Adds a public function to add IP4 route to FIB. The applications should call this function to add IP4 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 37 + lib/node/rte_node_ip4_api.h | 19 +++ 2 files changed, 56

[PATCH v2 01/13] fib: move macro to header file

Moves RTE_FIB_NAMESIZE to header file, in order to use it outside the fib library. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib.c | 3 --- lib/fib/rte_fib.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c index 2c05d46500

RE: [EXTERNAL] Re: [PATCH v1 04/12] node: add process callback for IP4 FIB

Hi Vladimir, >Hi Ankur, > >пт, 18 апр. 2025 г. в 15:45, Ankur Dwivedi <mailto:adwiv...@marvell.com> >: > > > > Hi Vladimir, > >> diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c > >> index e87864e

RE: [EXTERNAL] Re: [PATCH v1 04/12] node: add process callback for IP4 FIB

Hi Vladimir, >> diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c >> index e87864e672..c535b191f8 100644 >> --- a/lib/node/ip4_lookup_fib.c >> +++ b/lib/node/ip4_lookup_fib.c >> @@ -40,6 +40,169 @@ static struct ip4_lookup_fib_node_main >ip4_lookup_fib_nm; >> #define IP4_LOOKUP_

RE: [EXTERNAL] Re: [PATCH v1 02/12] node: add IP4 lookup FIB node

Hi Nitin, >> lib/node/ip4_lookup_fib.c | 127 >++ >> lib/node/meson.build | 3 +- >> 2 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 >> lib/node/ip4_lookup_fib.c >> >> diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.

RE: [EXTERNAL] Re: [PATCH v1 02/12] node: add IP4 lookup FIB node

Hi Vladimir, >On 15/04/2025 13:10, Ankur Dwivedi wrote: >> Adds a lookup FIB node for IP4. >> >> Signed-off-by: Ankur Dwivedi >> --- >> lib/node/ip4_lookup_fib.c | 127 >++ >> lib/node/meson.build | 3 +-

[PATCH v1 03/12] node: add IP4 FIB route add

Adds a public function to add IP4 route to FIB. The applications should call this function to add IP4 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 36 lib/node/rte_node_ip4_api.h | 19 +++ 2 files changed, 55

[PATCH v1 06/12] app/graph: add IP4 lookup mode command

Adds a command to setup lookup mode for IP4 packets. By default the LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP4 lookup fib node. Signed-off-by: Ankur

[PATCH v1 01/12] fib: move macro to header file

Moves RTE_FIB_NAMESIZE to header file, in order to use it outside the fib library. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib.c | 3 --- lib/fib/rte_fib.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c index 2c05d46500

[PATCH v1 10/12] node: add process callback for IP6 FIB

Adds the process callback function for ip6_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 158 ++ 1 file changed, 158 insertions(+) diff --git a/lib/node/ip6_lookup_fib.c b/lib/node/ip6_lookup_fib.c index caf3e9d1fa..6ad975dddb

[PATCH v1 08/12] node: add IP6 lookup FIB node

Adds a lookup FIB node for IP6. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 124 ++ lib/node/meson.build | 1 + 2 files changed, 125 insertions(+) create mode 100644 lib/node/ip6_lookup_fib.c diff --git a/lib/node/ip6_lookup_fib.c b

[PATCH v1 07/12] fib: move macro to header file

Moves the macro FIB6_NAMESIZE to header file and rename it to RTE_FIB6_NAMESIZE. Signed-off-by: Ankur Dwivedi --- lib/fib/rte_fib6.c | 11 --- lib/fib/rte_fib6.h | 3 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/fib/rte_fib6.c b/lib/fib/rte_fib6.c index

[PATCH v1 12/12] app/graph: add IP6 lookup mode command

Adds a command to setup lookup mode for IP6 packets. By default LPM mode is used. FIB can be given as a lookup mode by specifying the mode in CLI file. When FIB is given as lookup mode, the next node of packet classification node is updated to use IP6 lookup fib node. Signed-off-by: Ankur Dwivedi

[PATCH v1 11/12] node: add next node in packet classification

The ip6_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/pkt_cls_priv.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 3bd0ec0bbc..56bd5176b2 100644 --- a/lib

[PATCH v1 09/12] node: add IP6 FIB route add

Adds a public function to add IP6 route to FIB. The applications should call this function to add IP6 routes to FIB. Signed-off-by: Ankur Dwivedi --- lib/node/ip6_lookup_fib.c | 34 ++ lib/node/rte_node_ip6_api.h | 19 +++ 2 files changed, 53

[PATCH v1 05/12] node: add next node in packet classification

The ip4_lookup_fib is added as next node in packet classification. Signed-off-by: Ankur Dwivedi --- lib/node/pkt_cls.c | 1 + lib/node/pkt_cls_priv.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/node/pkt_cls.c b/lib/node/pkt_cls.c index 9d21b7f307..3bd0ec0bbc 100644 --- a/lib

[PATCH v1 04/12] node: add process callback for IP4 FIB

Adds the process callback function for ip4_lookup_fib node. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 164 ++ 1 file changed, 164 insertions(+) diff --git a/lib/node/ip4_lookup_fib.c b/lib/node/ip4_lookup_fib.c index e87864e672..c535b191f8

[PATCH v1 02/12] node: add IP4 lookup FIB node

Adds a lookup FIB node for IP4. Signed-off-by: Ankur Dwivedi --- lib/node/ip4_lookup_fib.c | 127 ++ lib/node/meson.build | 3 +- 2 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 lib/node/ip4_lookup_fib.c diff --git a/lib/node

[PATCH v1 00/12] add lookup fib nodes in graph library

the dpdk-graph application. fib or lpm can be given as lookup mode. If these new lookup mode commands are not given, the dpdk-graph uses lpm (Longest Prefix Match) or lpm6 by default. If fib is given as lookup mode then the ip4_lookup_fib or ip6_lookup_fib nodes are used by the application. Ankur

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Ankur Dwivedi >Sent: Tuesday, November 5, 2024 12:37 PM >To: Stephen Hemminger >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob >Subject: RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in >checkpatch > >

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Ankur Dwivedi >Sent: Monday, October 21, 2024 7:37 PM >To: Stephen Hemminger >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob >Subject: RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in >checkpatch > >>On

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>On Wed, 9 Oct 2024 06:03:58 +0000 >Ankur Dwivedi wrote: > >> >> Please let me know if this patch series can be merged in DPDK or if >> >> there are >> >any comments. >> > >> >Not sure why the patch got ignored. >> >Perhaps if c

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Stephen Hemminger >Sent: Tuesday, October 8, 2024 6:11 AM >To: Ankur Dwivedi >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob >Subject: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in >checkpatch > >On Wed, 1

[PATCH v1] common/cnxk: fix integer overflow

94318e ("common/cnxk: fix flow aging on application exit") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc_aging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_npc_aging.c b/drivers/common/cnxk/roc_n

RE: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Ankur Dwivedi >Sent: Friday, December 15, 2023 12:14 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch > >This patch

[PATCH v1] doc: fix aging poll frequency devargs information

rg Signed-off-by: Ankur Dwivedi --- doc/guides/nics/cnxk.rst | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst index 9ec52e380f..67cfe001ab 100644 --- a/doc/guides/nics/cnxk.rst +++ b/doc/guides/nic

[PATCH v6 2/2] devtools: add tracepoint check in checkpatch

skipped for them. Signed-off-by: Ankur Dwivedi --- devtools/check-tracepoint.sh | 148 +++ devtools/checkpatches.sh | 9 +++ devtools/trace-skiplist.txt | 0 3 files changed, 157 insertions(+) create mode 100755 devtools/check-tracepoint.sh create mode 100644

[PATCH v6 1/2] devtools: move build map changes function

This patch moves the build_map_changes function from check-symbol-change.sh to a new symbol-map-util.sh file. This function can be used in other scripts by including symbol-map-util.sh file. The license in check-symbol-change.sh is copied to symbol-map-util.sh. Signed-off-by: Ankur Dwivedi

[PATCH v6 0/2] devtools: add tracepoint check in checkpatch

check-tracepoint.py file. - Code improvements in check-tracepoint.sh. v2: - Add check for parent directory. Ankur Dwivedi (2): devtools: move build map changes function devtools: add tracepoint check in checkpatch devtools/check-symbol-change.sh | 76 +--- devtools/check

RE: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Thomas Monjalon >Sent: Thursday, November 30, 2023 2:11 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran >Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in >checkpatch > >30/11/2023 06:56, Ank

RE: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Thomas Monjalon >Sent: Tuesday, November 28, 2023 9:25 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran >Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in >checkpatch > >28/11/2023 15:07, An

RE: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

>07/03/2023 13:05, Ankur Dwivedi: >> This patch series adds a validation in checkpatch tool to check if >> tracepoint is present in any new function added in ethdev, eventdev >> cryptodev and mempool library. >> >> v5: >> - Copied the build_map_changes

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Thomas Monjalon >Sent: Friday, September 1, 2023 12:59 PM >To: Morten Brørup ; Jerin Jacob > >Cc: Ankur Dwivedi ; Stephen Hemminger >; Jerin Jacob Kollanukkaran >; dev@dpdk.org; techbo...@dpdk.org >Subject: Re: [EXT] Re: [PATCH v5 1/

[PATCH v1] common/cnxk: fix aged flows bitmap alloc

The allocation of bitmap for aged flows should be done in npc_aging_ctrl_thread_create() instead of roc_npc_init(), as the bitmap free is being done in npc_aging_ctrl_thread_destroy(). Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Ank

[PATCH v1] common/cnxk: fix flow add in age flow list

flow is added or deleted to/from age flow list if the flow has age action. Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc.c | 9 ++--- drivers/common/cnxk/roc_npc.h | 1 + driv

RE: [EXT] Re: [PATCH v2 1/2] common/cnxk: add support to get aged flows

> > >Ankur, following changes in upstream changed the thread APIs. I have >adapted to this change in [1]. Please review ASAP - It is blocking rc1 PR. I have reviewed the changes. The changes are fine. Thanks. > >commit 1c1abf1786a6de044bd396da4cc316961e3fd812 >Author: Thomas Monjalon >Date:

[PATCH v1] common/cnxk: fix initialization of MCAM ID

The start and end mcam id is initialized when aged_flows_cnt is 0. The boolean variable aging_enabled is not needed. Fixes: d110c44d29e7 ("common/cnxk: support flow aging") Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_npc_aging.c | 4 +--- 1 file changed, 1 inser

[PATCH v2 1/1] net/cnxk: support MACsec PN threshold events on multiple ports

Adds sa to port mapping in roc mcs. The sa to port map is updated when the sa is created. A portid field is also added to macsec event callback function. The above changes helps to propagate the tx and rx pn threshold events to the correct ethernet device. Signed-off-by: Ankur Dwivedi

[PATCH v2 0/1] support for MACsec PN threshold events on multiple ports

: - Squashed the v1 patches, to resolve compilation error. Ankur Dwivedi (1): net/cnxk: support MACsec PN threshold events on multiple ports drivers/common/cnxk/roc_mcs.c | 22 +++--- drivers/common/cnxk/roc_mcs.h | 8 ++-- drivers/common/cnxk/roc_mcs_sec_cfg.c

[PATCH v1 2/2] net/cnxk: update sa to port map

The sa to port map is updated when the sa is created. In this patch the portid field is also added to macsec event callback function. Signed-off-by: Ankur Dwivedi --- drivers/net/cnxk/cnxk_ethdev_mcs.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v1 1/2] common/cnxk: add sa to port mapping

Adds sa to port mapping in roc mcs. This helps to propagate the tx and rx pn threshold events to the correct ethernet device. Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk/roc_mcs.c | 22 +++--- drivers/common/cnxk/roc_mcs.h | 8 ++-- drivers/common

[PATCH v1 0/2] support of MACsec PN threshold events on multiple ports

This patch series adds support for packet number threshold events to be received on the respective ethernet port. For this a sa to port mapping is created during sa creation. When the pn threshold event is received then the check for port id is made to receive the event on the correct port. Ankur

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Stephen Hemminger >Sent: Thursday, May 18, 2023 9:04 PM >To: Ankur Dwivedi >Cc: Thomas Monjalon ; Jerin Jacob Kollanukkaran >; dev@dpdk.org >Subject: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpa

[PATCH v2 2/2] net/cnxk: add get flow aged ops

Adds get flow aged ops in CNXK driver. Also adds the devargs to get the poll frequency of control thread. Signed-off-by: Ankur Dwivedi --- doc/guides/nics/cnxk.rst | 12 +++ doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1 + drivers

[PATCH v2 1/2] common/cnxk: add support to get aged flows

Adds support to get aged flows in CNXK driver. The control thread polls the status of flows having age action, every 10 seconds and updates a bitmap array with the aged flows. The poll frequency of control thread can be set by devargs. Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk

[PATCH v2 0/2] add support for flow aging in CNXK driver

Adds support for flow aging in CNXK driver. v2: - Resolved checkpatch warning in patch (2/2) net/cnxk: add get flow aged ops. Ankur Dwivedi (2): common/cnxk: add support to get aged flows net/cnxk: add get flow aged ops doc/guides/nics/cnxk.rst | 12 + doc/guides/nics

[PATCH v1 2/2] net/cnxk: add get flow aged ops

Adds get flow aged ops in CNXK driver. Also adds the devargs to get the poll frequency of control thread. Signed-off-by: Ankur Dwivedi --- doc/guides/nics/cnxk.rst | 12 +++ doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1 + drivers

[PATCH v1 1/2] common/cnxk: add support to get aged flows

Adds support to get aged flows in CNXK driver. The control thread polls the status of flows having age action, every 10 seconds and updates a bitmap array with the aged flows. The poll frequency of control thread can be set by devargs. Signed-off-by: Ankur Dwivedi --- drivers/common/cnxk

[PATCH v1 0/2] add support for flow aging in CNXK driver

Adds support for flow aging in CNXK driver. This patch series is for DPDK 23.11. Ankur Dwivedi (2): common/cnxk: add support to get aged flows net/cnxk: add get flow aged ops doc/guides/nics/cnxk.rst | 12 + doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics

RE: [EXT] [PATCH] ethdev: fix asynchronous destroy and push tracepoints

>The rte_flow_async_destroy() and rte_flow_push() API is intended to be as >fast as possible and tracepoints for these functions must be marked as fast- >path tracepoints. > >Fixes: 6679cf21d608 ("ethdev: add trace points") > >Signed-off-by: Alexander Kozyrev Acke

RE: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

Hi Thomas, Please let me know if there is any feedback on this patch. Regards, Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Tuesday, March 7, 2023 5:35 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [P

RE: [PATCH v10 6/6] ethdev: add trace points for tm

ation. I have up streamed a patch in dpdk patchworks, which resolves this issue as a workaround. The following is the link of the patch: https://patches.dpdk.org/project/dpdk/list/?series=27418 > >Best regards, >Dukai,Yuan > >> -Original Message- >> From: Ankur Dwivedi

[PATCH v1] ethdev: fix address sanitizer bug

and instead adds rte_trace_point_emit_ptr to capture the iterator pointer. Bugzilla ID: 1184 Fixes: 6679cf21d608 ("ethdev: add trace points") Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/

[PATCH v5 1/1] devtools: add tracepoint check in checkpatch

which trace is not needed, they can be added to devtools/trace-skiplist.txt file. The above tracepoint check will be skipped for them. Signed-off-by: Ankur Dwivedi --- devtools/check-tracepoint.sh | 223 +++ devtools/checkpatches.sh | 9 ++ devtools/trace

[PATCH v5 0/1] devtools: add tracepoint check in checkpatch

the v2 patch into 2 patches. - The file common-func.sh is renamed to build-symbol-map.sh. - Removed check-tracepoint.py file. - Code improvements in check-tracepoint.sh. v2: - Add check for parent directory. Ankur Dwivedi (1): devtools: add tracepoint check in checkpatch devtools/check

[PATCH v4 2/2] devtools: add tracepoint check in checkpatch

: Ankur Dwivedi --- devtools/check-tracepoint.sh | 146 +++ devtools/checkpatches.sh | 9 +++ devtools/trace-skiplist.txt | 0 3 files changed, 155 insertions(+) create mode 100755 devtools/check-tracepoint.sh create mode 100644 devtools/trace-skiplist.txt

[PATCH v4 0/2] devtools: add tracepoint check in checkpatch

in check-tracepoint.sh. v2: - Add check for parent directory. Ankur Dwivedi (2): devtools: move build symbol map function devtools: add tracepoint check in checkpatch devtools/build-symbol-map.sh| 78 + devtools/check-symbol-change.sh | 76 + devtools

[PATCH v4 1/2] devtools: move build symbol map function

This patch moves the build_map_changes function from check-symbol-change.sh to a new build-symbol-map.sh file. This function can be used in other scripts by including build-symbol-map.sh file. Signed-off-by: Ankur Dwivedi --- devtools/build-symbol-map.sh| 78

[PATCH v2 2/2] ethdev: pass structure pointer

The rte_eth_xstat_name structure is of size 64 bytes. Instead of passing the structure as value it is passed as a pointer, to avoid copy of 64 bytes in function call stack. Signed-off-by: Ankur Dwivedi Acked-by: Ferruh Yigit --- lib/ethdev/ethdev_trace.h | 4 ++-- lib/ethdev/rte_ethdev.c | 2

[PATCH v2 1/2] ethdev: fix null pointer dereference

() is also resolved. Coverity issue: 383238 Bugzilla ID: 1162 Fixes: 6679cf21d608 ("ethdev: add trace points") Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 28 1 file c

[PATCH v2 0/2] bug fix in ethdev trace

and rte_flow_trace_create. - Added Ack by Ferruh in patch (2/2). Ankur Dwivedi (2): ethdev: fix null pointer dereference ethdev: pass structure pointer lib/ethdev/ethdev_trace.h | 32 ++-- lib/ethdev/rte_ethdev.c | 2 +- 2 files changed, 11 insertions(+), 23

RE: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

>On 2/28/2023 4:27 PM, Ferruh Yigit wrote: >> On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: >>>> >>>> -- On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >>>>> The speed_fec_capa pointer ca

[PATCH v1] ethdev: remove bitfields from trace

in trace. Bugzilla ID: 1167 Fixes: 6679cf21d608 ("ethdev: add trace points") Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 80 ++- 1 file changed, 3 insertions(+), 7

RE: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

>-- >On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: >> The speed_fec_capa pointer can be null. So dereferencing the pointer >> is removed and only the pointer is captured in trace function. >> Fixed few more

RE: [PATCH v11 0/6] add trace points in ethdev library

>> Subject: [PATCH v11 0/6] add trace points in ethdev library >> >> This series adds trace points for functions in the ethdev library. >> The trace points are added in ethdev, flow, mtr and tm files. >> > >Hi Ankur, > >Testpmd segfaults at startup in debug mode on ppc64le, and git-bisect points >t

[PATCH v1 2/2] ethdev: pass structure pointer

The rte_eth_xstat_name structure is of size 64 bytes. Instead of passing the structure as value it is passed as a pointer, to avoid copy of 64 bytes in function call stack. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 4 ++-- lib/ethdev/rte_ethdev.c | 2 +- 2 files changed, 3

[PATCH v1 1/2] ethdev: fix null pointer dereference

oints") Fixes: ed04fd4072e9 ("ethdev: add trace points for flow") Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index 53

[PATCH v1 0/2] bug fix in ethdev trace

The first patch in this series adds fix for bug and coverity. The second patch makes change to pass structure pointer instead of the structure value, to avoid 64 bytes copy in function call stack for rte_eth_trace_xstats_get_names. Ankur Dwivedi (2): ethdev: fix null pointer dereference

[PATCH v3 5/5] eventdev: remove internal tracepoints from version map

The internal tracepoints are removed from the version.map file. Also, removed eventdev_trace.h from meson.build. Signed-off-by: Ankur Dwivedi Acked-by: Jerin Jacob --- lib/eventdev/eventdev_trace.h | 6 +++--- lib/eventdev/meson.build | 1 - lib/eventdev/version.map | 30

[PATCH v3 3/5] eal: remove internal tracepoints from version map

The file rte_eal_trace.h contains some tracepoints which are internal to the eal library. Those tracepoints are moved to a new file eal_trace_internal.h. The internal tracepoints are removed from the version.map file. Signed-off-by: Ankur Dwivedi Acked-by: Jerin Jacob --- doc/guides/prog_guide

[PATCH v3 4/5] ethdev: remove internal tracepoints from version map

The internal tracepoints are removed from the version.map file. Also, removed ethdev_trace.h from meson.build. Signed-off-by: Ankur Dwivedi Acked-by: Ferruh Yigit Acked-by: Jerin Jacob --- lib/ethdev/ethdev_trace.h | 6 +++--- lib/ethdev/meson.build| 1 - lib/ethdev/version.map| 6

[PATCH v3 2/5] cryptodev: remove internal tracepoints from version map

The file rte_cryptodev_trace.h contains tracepoints which are internal to the cryptodev library. This file is renamed to cryptodev_trace.h, and is made an internal header. The tracepoints in this file are removed from the experimental and internal section in version.map file. Signed-off-by: Ankur

  1   2   3   4   >