Re: [PATCH 03/10] test/mempool: fix test without stack driver

2025-06-20 Thread Andrew Rybchenko
On 6/19/25 10:10 AM, David Marchand wrote: In a minimal build, the mempool/stack driver is disabled. Separate the code specific to this external driver and rename unrelated variables. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [PATCH v2 08/45] common/sfc_efx/base: add Medford4 support to PHY module

2025-04-23 Thread Andrew Rybchenko
On 4/23/25 18:59, Ivan Malov wrote: From: Denis Pryazhennikov Use common EF10 method table for that. Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_phy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/common/sfc_efx/base

Re: [PATCH v2 00/45] Support AMD Solarflare X45xx adaptors

2025-04-23 Thread Andrew Rybchenko
efx/base/medford4_phy.c With few nits fixed Series-acked-by: Andrew Rybchenko Frankly speaking I'd squash trivial patches which add M4 support to various modules inheriting ef10 ops. Also it is always better to update documentation in patches with corresponding code (when support is really added and starts to work).

Re: [PATCH v2 45/45] doc: advertise support for AMD Solarflare X45xx adapters

2025-04-23 Thread Andrew Rybchenko
On 4/23/25 19:00, Ivan Malov wrote: The two NICs, X4522 and X4542, are based on EF10 architecture. Signed-off-by: Ivan Malov --- doc/guides/nics/sfc_efx.rst| 9 - doc/guides/rel_notes/release_25_07.rst | 4 2 files changed, 12 insertions(+), 1 deletion(-) diff --gi

Re: [PATCH 02/46] common/sfc_efx/base: add efsys option for Medford4

2025-04-18 Thread Andrew Rybchenko
On 4/17/25 18:07, Stephen Hemminger wrote: On Thu, 17 Apr 2025 10:08:20 +0300 Andrew Rybchenko wrote: #if EFSYS_OPT_ALLOW_UNCONFIGURED_NIC /* Support adapters with missing static config (for factory use only) */ -# if !(EFSYS_OPT_RIVERHEAD || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2

Re: [PATCH 03/46] common/sfc_efx/base: add Medford4 support to NIC module

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 16:59, Ivan Malov wrote: From: Denis Pryazhennikov Implement NIC family discovery and minimum probe support. Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton [snip] @@ -1922,6 +1923,36 @@ static struct ef10_external_port_map_s { (1U << TLV_PORT_MODE

Re: [PATCH 00/46] Support AMD Solarflare X45xx adaptors

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 16:59, Ivan Malov wrote: New X4522 (dual port SFP56) and X4542 (dual port QSFP56) adaptors are Medford4 (X4) chips that are based on EF10 architecture. An X4 NIC supports multiple network engine types. This series provides support only for the Medford2-alike, 'full-feature' (FF) networ

Re: [PATCH 44/46] common/sfc_efx/base: support controls for netport lane count

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 17:00, Ivan Malov wrote: On netport MCDI capable adaptors, link modes exported by libefx can be backed by different technologies with different lane counts. Allow the client drivers to get and set the lane count and query possible values. Signed-off-by: Ivan Malov Reviewed-by: Andy M

Re: [PATCH 35/46] common/sfc_efx/base: support MAC statistics on Medford4 NICs

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 17:00, Ivan Malov wrote: Supply Medford4-specific methods to clear, upload and update MAC statistics, as well as the method to toggle periodic DMA updates. All of these leverage the same netport MCDI command. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Pieter Ja

Re: [PATCH 32/46] common/sfc_efx/base: add MAC reconfigure method for Medford4

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 17:00, Ivan Malov wrote: That leverages MAC control functionality of new netport MCDI. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Pieter Jansen Van Vuuren --- drivers/common/sfc_efx/base/efx_impl.h | 13 drivers/common/sfc_efx/base/efx_mac.c

Re: [PATCH 30/46] common/sfc_efx/base: implement PHY link control for Medford4

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 17:00, Ivan Malov wrote: Use new MCDI to select loopback, speed, flow control and FEC. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Pieter Jansen Van Vuuren [snip] +static void +efx_np_cap_sw_mask_to_hw_enum( + __in_ecou

Re: [PATCH 02/46] common/sfc_efx/base: add efsys option for Medford4

2025-04-17 Thread Andrew Rybchenko
On 4/16/25 16:59, Ivan Malov wrote: From: Denis Pryazhennikov Later patches will use this to implement support for Medford4. Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_check.h | 24 ++-- drivers/common/sfc_efx/efsys

Re: [PATCH] mempool perf test: test random bulk sizes

2025-04-05 Thread Andrew Rybchenko
to make checkpatches happy. IMHO, it would be much better and easier to review if all above changes are done one by one in separate patches. Signed-off-by: Morten Brørup Overall the idea looks good, so Acked-by: Andrew Rybchenko but I'd be thankful if you split the

Re: [PATCH v12 03/10] net/sfc: replace use of rte_mbuf_sanity_check

2025-04-05 Thread Andrew Rybchenko
On 4/3/25 02:23, Stephen Hemminger wrote: Renamed to rte_mbuf_verify. Signed-off-by: Stephen Hemminger Thanks Stephen, Acked-by: Andrew Rybchenko

Re: [PATCH v12 10/10] drivers: remove use of term sanity check

2025-04-04 Thread Andrew Rybchenko
On 4/3/25 02:23, Stephen Hemminger wrote: Don't use term "sanity" because it is considered derogatory. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal For sfc: Acked-by: Andrew Rybchenko

Re: [PATCH v7 5/8] build: mark exported symbols

2025-04-04 Thread Andrew Rybchenko
On 4/4/25 08:48, Hemant Agrawal wrote: for DPAA/FSLMC changes Acked-by: Hemant Agrawal For common/sfc_efx: Acked-by: Andrew Rybchenko

Re: [PATCH v7 5/8] build: mark exported symbols

2025-04-04 Thread Andrew Rybchenko
/meson.build. Signed-off-by: David Marchand For common/sfc_efx: Acked-by: Andrew Rybchenko

Re: [PATCH 02/10] common/sfc_efx: use common base code build handling

2025-04-01 Thread Andrew Rybchenko
On 3/31/25 19:09, Bruce Richardson wrote: Use the base code build handling logic in the drivers/meson.build file, rather than re-implementing it in the driver itself. Signed-off-by: Bruce Richardson Acked-by: Andrew Rybchenko

Re: [PATCH v2 0/4] mempool perf test: test random bulk sizes

2025-03-31 Thread Andrew Rybchenko
, to make checkpatches happy. v2: * Split patch into individual patches. (Andrew Rybchenko) Thanks Morten, LGTM except a couple of nits Morten Brørup (4): mempool perf test: replace bare unsigned with unsigned int mempool perf test: test default mempool with cache mempool perf test: im

Re: [PATCH v2 4/4] mempool perf test: test random bulk sizes

2025-03-31 Thread Andrew Rybchenko
On 3/31/25 13:03, Morten Brørup wrote: Bulk requests to get or put objects in a mempool often vary in size. A series of tests with pseudo random request sizes, to mitigate the benefits of the CPU's dynamic branch predictor, was added. Signed-off-by: Morten Brørup Acked-by: Andrew Rybc

Re: [PATCH] mempool: micro optimizations

2025-03-30 Thread Andrew Rybchenko
-by: Bruce Richardson Acked-by: Andrew Rybchenko

Re: [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers

2025-02-19 Thread Andrew Rybchenko
On 2/20/25 05:32, Stephen Hemminger wrote: The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko one nit below @@ -6995

Re: [PATCH 1/1] common/sfc_efx/base: remove unreachable code

2024-12-21 Thread Andrew Rybchenko
mport libefx base") Signed-off-by: Ariel Otilibili -- Cc: sta...@dpdk.org Cc: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_mon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_mon.c b/drivers/common/sfc_efx/base/efx_mon.c index ee449ef5eb..

Re: [PATCH v2 1/5] ethdev: check that device supports deferred start

2024-12-16 Thread Andrew Rybchenko
On 12/16/24 21:58, Stephen Hemminger wrote: On Sun, 15 Dec 2024 11:56:55 +0300 Andrew Rybchenko wrote: On 12/14/24 21:07, Stephen Hemminger wrote: The check for supporting deferred start should be handled at the ethdev level for all devices. It is a good idea to check it on ethdev level

[PATCH] net/sfc: avoid duplicate configuration restore

2024-12-16 Thread Andrew Rybchenko
MAC address, promiscuous and all-multicast modes are restored correctly upon device start by the PMD itself. ethdev layer should not duplicate it. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/sfc

Re: [PATCH v2 2/6] drivers: drop export of driver headers

2024-12-16 Thread Andrew Rybchenko
pretty clear that they should be sdk-only headers. Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko

Re: [PATCH 13/21] drivers/net: use portable variadic macros

2024-12-16 Thread Andrew Rybchenko
acros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie For sfc, Acked-by: Andrew Rybchenko

Re: [PATCH v2 1/5] ethdev: check that device supports deferred start

2024-12-15 Thread Andrew Rybchenko
. In fact, I don't mind to couple deferred start to queue start/stop features. One nit below. Anyway: Acked-by: Andrew Rybchenko Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/e

Re: [PATCH] mempool: enable code to be compiled with MSVC compiler

2024-11-13 Thread Andrew Rybchenko
: Andre Muezerie --- Reviewed-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-25 Thread Andrew Rybchenko
On 10/23/24 20:59, Mattias Rönnblom wrote: On 2024-07-16 00:11, Wathsala Vithanage wrote: ... +/** + * + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * Discover cache stashing hints and object types supported in the ethernet + * device. +

Re: [PATCH] ethdev: fix link with C++

2024-10-25 Thread Andrew Rybchenko
ed-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [PATCH] ethdev: convert string initialization

2024-10-04 Thread Andrew Rybchenko
1135 | .hdr.vni = "\xff\xff\xff", |^~ Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko

Re: [PATCH v3 09/18] net/sfc: fix use-after-free warning messages

2024-09-29 Thread Andrew Rybchenko
flows") Signed-off-by: Stephen Hemminger Reviewed-by: Ivan Malov Acked-by: Andrew Rybchenko

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

2024-09-23 Thread Andrew Rybchenko
or the fix. Reviewed-by: Andrew Rybchenko

Re: [PATCH 11/11] drivers: use per line logging in helpers

2024-09-09 Thread Andrew Rybchenko
On 9/9/24 09:55, David Marchand wrote: On Sun, Sep 8, 2024 at 10:55 AM Andrew Rybchenko wrote: On 9/7/24 17:54, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand [snip] diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers

Re: [PATCH 11/11] drivers: use per line logging in helpers

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 17:54, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand [snip] diff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h index 1519ebdc17..b41ef3490b 100644 --- a/drivers/common/sfc_efx/sfc_ef

Re: [PATCH 05/11] drivers: reuse default logtype for SFC drivers

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 17:54, David Marchand wrote: Nothing is fixed here, just reuse the value coming from the build framework rather than use a fixed string that may get wrong in the future. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

Re: [PATCH 04/11] net/sfc: fix driver logtype token

2024-09-08 Thread Andrew Rybchenko
t; SFC_KVARG_VALUES_FW_VARIANT " " SFC_KVARG_RXD_WAIT_TIMEOUT_NS "= " SFC_KVARG_STATS_UPDATE_PERIOD_MS "="); -RTE_LOG_REGISTER_SUFFIX(sfc_logtype_driver, "driver", NOTICE); +RTE_LOG_REGISTER_SUFFIX(sfc_logtype_driver, driver, NOTICE); Reviewed-by: Andrew Rybchenko

Re: virtio: RSS support capa

2024-09-08 Thread Andrew Rybchenko
On 9/7/24 23:55, Morten Brørup wrote: From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Friday, 6 September 2024 21.38 Maxime, Chenbo, If the virtio PMD supports RSS, it should be announced in its capabilities. I think this should be added to virtio_dev_info_get(): if (hos

Re: [PATCH 1/4] ethdev: verify queue ID when Tx done cleanup

2024-09-05 Thread Andrew Rybchenko
On 9/5/24 09:46, Jie Hai wrote: From: Chengwen Feng Verify queue_id for rte_eth_tx_done_cleanup API. If I'm not mistaken the function is considered data path API (fast). If so, it should not validate it's parameters as in rte_eth_tx_burst(). It may be done under RTE_ETHDEV_DEBUG_TX only. May

Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload

2024-09-04 Thread Andrew Rybchenko
ength to pkt_len. So it is very necessary to add comments for this. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Morten Brørup Acked-by: Huisong Li Acked-by: Jie Hai Acked-by: Andrew Rybchenko

Re: [PATCH 3/6] net/sfc: remove use of EAL logtype

2024-06-25 Thread Andrew Rybchenko
On 6/25/24 15:24, David Marchand wrote: When registering a common logtype for this driver, instead of explicitly fall back to EAL, rely on the log registration macro to achieve the same. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko Thanks

Re: [PATCH 1/6] vdpa/sfc: remove dead code

2024-06-25 Thread Andrew Rybchenko
d Marchand Reviewed-by: Andrew Rybchenko

Re: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Andrew Rybchenko
On 5/16/24 11:59, Morten Brørup wrote: Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

2024-06-03 Thread Andrew Rybchenko
On 6/3/24 05:33, Stephen Hemminger wrote: On Mon, 3 Jun 2024 09:38:19 +0800 Jie Hai wrote: On 2024/3/1 19:10, Ferruh Yigit wrote: On 3/1/2024 6:55 AM, huangdengdui wrote: On 2024/2/29 17:25, Ferruh Yigit wrote: On 2/29/2024 3:58 AM, huangdengdui wrote: On 2024/2/28 21:07, Ferruh Yigit

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

2024-05-29 Thread Andrew Rybchenko
Retzlaff --- Reviewed-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

2024-05-29 Thread Andrew Rybchenko
RTE_TOOLCHAIN_MSVC +#define __rte_constant(e) 0 +#else +#define __rte_constant(e) __extension__(__builtin_constant_p(e)) +#endif + Acked-by: Bruce Richardson Reviewed-by: Andrew Rybchenko

Re: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

2024-05-29 Thread Andrew Rybchenko
On 4/1/24 11:34, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, 1 April 2024 00.03 On Wed, 20 Mar 2024 14:33:35 -0700 Tyler Retzlaff wrote: +#ifdef RTE_TOOLCHAIN_MSVC +#define __rte_constant(e) 0 +#else +#define __rte_constant(e) __extension__(_

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-23 Thread Andrew Rybchenko
On 2/22/24 21:28, Konstantin Ananyev wrote: +CC: Ethernet API maintainers +CC: Jerin (commented on another branch of this thread) From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] Sent: Sunday, 11 February 2024 16.04 TSO breaks when MSS spans more than 8 data fragments. Those

Re: [PATCH] common/sfc: replace out of bounds condition with static_assert

2024-02-12 Thread Andrew Rybchenko
nd for toolchain issues with missing C11 macro in FreeBSD. Maybe not in this file, but somewhere. Acked-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [PATCH v2 8/8] net/sfc: fix calloc parameters

2024-01-24 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 1/6] eal: introduce RTE_MIN_T() and RTE_MAX_T() macros

2024-01-18 Thread Andrew Rybchenko
in other scenarios when bounded range is useful. Naming is chosen to be similar to Linux kernel conventions. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [PATCH v4 2/6] event/opdl: fix non-constant compile time assertion

2024-01-18 Thread Andrew Rybchenko
("event/opdl: add OPDL ring infrastructure library") Cc: liang.j...@intel.com Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko

Re: [PATCH v4 5/6] mempool: avoid floating point expression in static assertion

2024-01-18 Thread Andrew Rybchenko
with same effect. Modify comment in mlx5 so that developers don't go searching for old value. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 3/6] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON()

2024-01-18 Thread Andrew Rybchenko
ative datapath") Cc: ivan.ma...@oktetlabs.ru Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff One nit below, anyway: Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ef

Re: [PATCH v3 1/1] ethdev: parsing multiple representor devargs string

2024-01-17 Thread Andrew Rybchenko
On 1/16/24 12:55, Harman Kalra wrote: Adding support for parsing multiple representor devargs strings passed to a PCI BDF. There may be scenario where port representors for various PFs or VFs under PFs are required and all these are representor ports shall be backed by single pci device. In such

Re: static_assert, sfc, and clang issues

2024-01-17 Thread Andrew Rybchenko
On 1/17/24 01:49, Stephen Hemminger wrote: On Tue, 16 Jan 2024 23:14:36 +0100 Morten Brørup wrote: +1 for #2 just make it a block. I prefer that you implement the workaround in the RTE_BUILD_BUG_ON() macro, by surrounding it by "do { } while (0)", like this: #define RTE_BUILD_BUG_ON(condit

Re: [PATCH v3 4/5] mempool: avoid floating point expression in static assertion

2024-01-17 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: Clang does not handle casts in static_assert() expressions. It doesn't like use of floating point to calculate threshold. Use a different expression with same effect; yes this will cause checkpatch nag. Signed-off-by: Stephen Hemminger --- lib/mempoo

Re: [PATCH v3 1/5] event/opdl: fix non-constant compile time assertion

2024-01-16 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: RTE_BUILD_BUG_ON() was being used with a non-constant value. The inline function rte_is_power_of_2() is not constant since inline expansion happens later in the compile process. Replace it with macro which will be constant. Fixes: 4236ce9bf5bf ("event/o

Re: [PATCH v3 2/5] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON()

2024-01-16 Thread Andrew Rybchenko
On 1/16/24 21:41, Stephen Hemminger wrote: The macro RTE_MIN has some hidden assignments to provide type safety which means the statement can not be fully evaluated in first pass of compiler. Replace RTE_MIN() with equivalent macro. This will cause errors from checkpatch about multiple evaluatio

Re: [PATCH v3 5/5] eal: replace out of bounds VLA with static_assert

2024-01-16 Thread Andrew Rybchenko
Acked-by: Tyler Retzlaff Acked-by: Andrew Rybchenko Does it imply any limitations on Gcc / Clang versions to be used? Is it documented somewhere in DPDK?

Re: [PATCH v2 2/3] ethdev: add compare item

2024-01-12 Thread Andrew Rybchenko
than) - RTE_FLOW_ITEM_COMPARE_LE (less than or equal) - RTE_FLOW_ITEM_COMPARE_GT (great than) - RTE_FLOW_ITEM_COMPARE_GE (great than or equal) Signed-off-by: Suanming Mou Just one nit below, anyway Acked-by: Andrew Rybchenko I dislike that many line of code are moved, but it looks like

Re: [PATCH v2 1/3] ethdev: rename action modify field data structure

2024-01-12 Thread Andrew Rybchenko
to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou --- Acked-by: Ori Kam Best, Ori Acked-by: Andrew Rybchenko

Re: [RFC] ethdev: introduce entropy calculation

2024-01-11 Thread Andrew Rybchenko
Hi Ori, sorry for delay with reply. On 12/17/23 13:07, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Saturday, December 16, 2023 11:19 AM On 12/10/23 11:30, Ori Kam wrote: When offloading rules with the encap action, the HW may calculate entropy based

Re: [PATCH 2/2] doc: multiple representors in one device

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Updating the documentation with the pattern format for enabling multiple representors in one device Signed-off-by: Harman Kalra IMHO it should be squashed into previous patch.

Re: [PATCH 1/2] ethdev: parsing multiple representor devargs string

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Adding support for parsing multiple representor devargs strings passed to a PCI BDF. There may be scenario where port representors for various PFs or VFs under PFs are required and all these are representor ports shall be backed by single pci device. In such

Re: [dpdk-dev v4 2/2] net/tap: fix buffer overflow for ptypes list through driver API update

2024-01-11 Thread Andrew Rybchenko
On 1/4/24 20:51, Sivaramakrishnan Venkat wrote: Incorrect ptypes list causes buffer overflow for Address Sanitizer run. Previously, the last element in the ptypes lists to be "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was not clearly documented and many PMDs did not foll

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Andrew Rybchenko
. A notable use case could be implementing Random Early Discard (RED) in software based on Tx queue occupancy. Signed-off-by: Jerin Jacob with few nits below Reviewed-by: Andrew Rybchenko [snip] diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index f7d9980849

Re: [PATCH v3 08/14] lib: simplify multilines log messages

2023-12-18 Thread Andrew Rybchenko
On 12/18/23 12:27, David Marchand wrote: Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name

2023-12-16 Thread Andrew Rybchenko
(function name). Other than that: Reviewed-by: Andrew Rybchenko

Re: [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get

2023-12-16 Thread Andrew Rybchenko
On 12/16/23 13:06, Andrew Rybchenko wrote: On 7/10/23 20:07, Stephen Hemminger wrote: From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya Signed-off-by: Stephen

Re: [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get

2023-12-16 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH v3 11/22] ethdev: replace strtok with reentrant version

2023-12-16 Thread Andrew Rybchenko
-reentrant, it is better to replace it with a reentrant version. Fixes: f38f62650f7b ("ethdev: add Rx queue telemetry query") Fixes: 9e7533aeb80a ("ethdev: add telemetry command for TM level capabilities") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Acked-by: Chengwen Feng

Re: [RFC v2 03/14] lib: use dedicated logtypes

2023-12-16 Thread Andrew Rybchenko
the rest of eventdev (private) macros. Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko

Re: [RFC v2 04/14] lib: add newline in logs

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 17:59, David Marchand wrote: Fix places leading to a log message not terminated with a newline. Cc: sta...@dpdk.org Signed-off-by: David Marchand For ethdev: Reviewed-by: Andrew Rybchenko

Re: [RFC v2 13/14] lib: replace logging helpers

2023-12-16 Thread Andrew Rybchenko
y publicly exposed logging helpers, when such helper is not publicly used (iow in public inline API), it is removed from the public API (this is the case for the member library), Signed-off-by: David Marchand For ethdev Reviewed-by: Andrew Rybchenko

Re: [RFC v2 14/14] lib: use per line logging in helpers

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 17:59, David Marchand wrote: Use RTE_LOG_LINE in existing macros that append a \n. Signed-off-by: David Marchand --- Changes since RFC v1: - converted all logging helpers in lib/, --- For ethdev Reviewed-by: Andrew Rybchenko

Re: [RFC v2 12/14] lib: convert to per line logging

2023-12-16 Thread Andrew Rybchenko
cial cases, Signed-off-by: David Marchand For mempool, Reviewed-by: Andrew Rybchenko

Re: [RFC v2 08/14] lib: simplify multilines log messages

2023-12-16 Thread Andrew Rybchenko
On 12/8/23 20:05, Stephen Hemminger wrote: On Fri, 8 Dec 2023 15:59:42 +0100 David Marchand wrote: Those error log messages don't need to span on multiple lines. Signed-off-by: David Marchand --- lib/acl/tb_mem.c| 2 +- lib/bpf/bpf_stub.c | 4 ++-- lib/eal

Re: [RFC] ethdev: introduce entropy calculation

2023-12-16 Thread Andrew Rybchenko
On 12/10/23 11:30, Ori Kam wrote: When offloading rules with the encap action, the HW may calculate entropy based on the encap protocol. Each HW can implement a different algorithm. When the application receives packets that should have been encaped by the HW, but didn't reach this stage yet (f

Re: [RFC] ethdev: introduce entropy calculation

2023-12-16 Thread Andrew Rybchenko
On 12/15/23 19:21, Thomas Monjalon wrote: 15/12/2023 14:44, Ferruh Yigit: On 12/14/2023 5:26 PM, Stephen Hemminger wrote: On Thu, 14 Dec 2023 17:18:25 + Ori Kam wrote: Since encap groups number of different 5 tuples together, if HW doesn’t know how to RSS based on the inner application w

Re: [PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-08 Thread Andrew Rybchenko
minimum of the maximum suported MTU and the default DPDK MTU. Fixes: 1bb4a528c4 ("ethdev: fix max Rx packet length") Signed-off-by: Joshua Washington Signed-off-by: Rushil Gupta Acked-by: Andrew Rybchenko

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-06 Thread Andrew Rybchenko
On 11/6/23 15:29, fengchengwen wrote: Hi Andrew, On 2023/11/6 18:28, Andrew Rybchenko wrote: On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of

Re: [PATCH v2 1/2] mempool: fix internal function documentation

2023-11-06 Thread Andrew Rybchenko
On 10/23/23 12:38, Ferruh Yigit wrote: static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the internal function documenta

Re: [PATCH v9 1/9] ethdev: overwrite some comment related to RSS

2023-11-06 Thread Andrew Rybchenko
On 11/2/23 11:20, Jie Hai wrote: In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be greater than or equal to the "hash_key_size" which get from rte_eth_dev_info_get() API. And the "rss_key" should contain at least "hash_key_size" bytes. If these requirements are not met, the query un

Re: [PATCH v9 7/9] ethdev: add API to get RSS algorithm names

2023-11-06 Thread Andrew Rybchenko
On 11/2/23 11:20, Jie Hai wrote: This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Chengwen Feng @@ -4791,6 +4802,20 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id, return r

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

2023-11-06 Thread Andrew Rybchenko
On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.

Re: [PATCH] maintainers: update for mempool library

2023-11-01 Thread Andrew Rybchenko
On November 1, 2023 19:20:29 Morten Brørup wrote: Add co-maintainer for Memory pool. Suggested-by: Thomas Monjalon Signed-off-by: Morten Brørup Acked-by: Andrew Rybchenko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4083658697

Re: [PATCH] net/sfc: support packet replay in transfer flows

2023-09-29 Thread Andrew Rybchenko
-off-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH] mempool: add cache guard to per-lcore debug statistics

2023-09-29 Thread Andrew Rybchenko
Reviewed-by: Andrew Rybchenko

Re: [PATCH 2/2] net/sfc: support updating indirect VXLAN encap action

2023-09-21 Thread Andrew Rybchenko
On 8/10/23 21:06, Ivan Malov wrote: Such updates are helpful as they let applications avoid costly flow re-insertions when the header data changes. Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH 1/2] net/sfc: offer indirect VXLAN encap action in transfer flows

2023-09-21 Thread Andrew Rybchenko
Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH 07/11] drivers: convert to internal control threads

2023-09-11 Thread Andrew Rybchenko
t would be interesting to rework them in future. Signed-off-by: Thomas Monjalon For net/sfc Acked-by: Andrew Rybchenko

Re: [PATCH] net/sfc: account for data offset on Tx

2023-09-11 Thread Andrew Rybchenko
C DMA memory mapping type") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH] net/sfc: set max Rx packet length for representors

2023-09-11 Thread Andrew Rybchenko
On 9/11/23 13:47, Viacheslav Galaktionov wrote: Maximum packet length must be set to configure representor devices. Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Galaktionov Reviewed-by: Andy Moreton Acked-

Re: [PATCH 30/36] net/sfc: fix Rx and Tx queue state

2023-09-08 Thread Andrew Rybchenko
On 9/8/23 14:28, Jie Hai wrote: The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the d

Re: [RFC] ethdev: introduce maximum Rx buffer size

2023-08-11 Thread Andrew Rybchenko
On 8/8/23 07:02, Huisong Li wrote: The Rx buffer size stands for the size hardware supported to receive packets in one mbuf. The "min_rx_bufsize" is the minimum buffer hardware supported in Rx. Actually, some engines also have the maximum buffer specification, like, hns3. For these engines, the a

Re: [PATCH] doc: announce ethdev operation struct changes

2023-07-17 Thread Andrew Rybchenko
interrupt to the application, -- 2.25.1 Ping~ Acked-by: Morten Brørup Acked-by: Andrew Rybchenko

Re: [PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow type

2023-07-17 Thread Andrew Rybchenko
urces") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko

Re: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse

2023-07-13 Thread Andrew Rybchenko
") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko

  1   2   3   4   5   6   7   8   9   10   >