RE: [EXTERNAL] [PATCH] doc: announce DMA configuration structure changes

2025-06-23 Thread Amit Prakash Shukla
Acked-by: Amit Prakash Shukla From: pbhagavat...@marvell.com Sent: Wednesday, April 16, 2025 4:36 PM To: Jerin Jacob Cc: Vamsi Krishna Attunuru ; g.si...@nxp.com; sachin.sax...@nxp.com; hemant.agra...@nxp.com; fengcheng...@huawei.com; bruce.richard...@intel.com; kevin.la...@intel.com

RE: [PATCH RFC 3/4] doc: update prog guide to use rte_dma_op

2025-02-25 Thread Amit Prakash Shukla
> -Original Message- > From: Kommula Shiva Shankar > Sent: Wednesday, January 29, 2025 8:07 PM > To: Jerin Jacob ; Amit Prakash Shukla > ; Vamsi Krishna Attunuru > ; fengcheng...@huawei.com; dev@dpdk.org > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagav

RE: [PATCH RFC 2/4] eventdev: refactor rte_event_dma_adapater_op calls

2025-02-25 Thread Amit Prakash Shukla
> -Original Message- > From: Kommula Shiva Shankar > Sent: Wednesday, January 29, 2025 8:07 PM > To: Jerin Jacob ; Amit Prakash Shukla > ; Vamsi Krishna Attunuru > ; fengcheng...@huawei.com; dev@dpdk.org > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagav

RE: [PATCH v3 02/14] eventdev: remover unnecessary deref on function pointers

2025-02-25 Thread Amit Prakash Shukla
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Tuesday, February 25, 2025 6:48 PM > To: Gujjar, Abhinandan S ; Stephen > Hemminger ; dev@dpdk.org > Cc: Morten Brørup ; Richardson, Bruce > ; Jerin Jacob ; Amit > Prakash Shukla ; Naga Harish

RE: [EXTERNAL] [RFC 3/6] eventdev: do not include driver header in DMA adapter

2024-11-27 Thread Amit Prakash Shukla
lib/eventdev/rte_event_dma_adapter.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Amit Prakash Shukla Thanks > diff --git a/lib/eventdev/rte_event_dma_adapter.h > b/lib/eventdev/rte_event_dma_adapter.h > index 5c480b82ff..34142f26db 100644 > ---

RE: [EXTERNAL] Re: [PATCH v2] app/dma-perf: per device config support

2024-11-12 Thread Amit Prakash Shukla
12/11/2024 16:26, Amit Prakash Shukla: >> Hi Thomas, >> >> Gentle ping. >> >Yes it was not a top priority for -rc2, >so I will check it soon for -rc3. Sure, thanks.

RE: [PATCH v2] app/dma-perf: per device config support

2024-11-12 Thread Amit Prakash Shukla
Hi Thomas, Gentle ping. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Monday, October 21, 2024 2:07 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Jerin Jacob ; Vamsi Krishna > Attunuru ; Anoob Joseph ; > Gowrishankar Muthuk

RE: [PATCH v2] app/dma-perf: per device config support

2024-10-21 Thread Amit Prakash Shukla
Hi Thomas, Gentle ping. Could you please consider merging this patch. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, September 26, 2024 5:43 PM > To: Cheng Jiang ; Chengwen Feng > > Cc: dev@dpdk.org; Jerin Jacob ; Vamsi

RE: [EXTERNAL] [PATCH v2 1/2] test/dma: update the sg test to verify wrap around case

2024-10-04 Thread Amit Prakash Shukla
extern int test_dma_api(uint16_t dev_id); > > #define TEST_MEMCPY_SIZE 1024 > #define TEST_WAIT_US_VAL 5 > -#define TEST_SG_MAX 64 > > static int16_t test_dev_id; > static int16_t invalid_dev_id; > diff --git a/app/test/test_dmadev_api.h b/app/test/test_dmadev_api.h index > 33fbc5bd41..a03f7acd4f 100644 > --- a/app/test/test_dmadev_api.h > +++ b/app/test/test_dmadev_api.h > @@ -2,4 +2,6 @@ > * Copyright(c) 2021 HiSilicon Limited > */ > > +#define TEST_SG_MAX 64 > + > int test_dma_api(uint16_t dev_id); > -- > 2.25.1 Acked-by: Amit Prakash Shukla Thanks

RE: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fill

2024-10-04 Thread Amit Prakash Shukla
lengths[i], dst_data[j], > 0); > } > - /* check that the data after the fill operation was not written > to */ > - for (; j < rte_pktmbuf_data_len(dst); j++) > - if (dst_data[j] != 0) > - ERR_RETURN("Error, fill operation wrote too > far (lengths = %u): got (%x), not (%x)\n", > - lengths[i], dst_data[j], 0); > } > > rte_pktmbuf_free(dst); > -- > 2.25.1 Acked-by: Amit Prakash Shukla Thanks

Re: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fill

2024-10-04 Thread Amit Prakash Shukla
lengths[i], dst_data[j], 0); } rte_pktmbuf_free(dst); -- 2.25.1 Acked-by: Amit Prakash Shukla Thanks

Re: [EXTERNAL] [PATCH v2 1/2] test/dma: update the sg test to verify wrap around case

2024-10-04 Thread Amit Prakash Shukla
ight(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 + int test_dma_api(uint16_t dev_id); -- 2.25.1 Acked-by: Amit Prakash Shukla Thanks

[PATCH v2] app/dma-perf: per device config support

2024-09-26 Thread Amit Prakash Shukla
Add support to configure device specific config parameters for a testcase. Example: lcore_dma0=lcore=11,dev=:00:04.1,dir=mem2dev,raddr=0x3, coreid=1,pfid=2,vfid=3 lcore_dma1=lcore=12,dev=:00:04.2,dir=dev2mem,raddr=0x2, coreid=3,pfid=2,vfid=1 Signed-off-by: Amit Prakash

RE: [PATCH] app/test-eventdev: improve DMA adapter test

2024-09-18 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, August 23, 2024 11:43 AM > To: Jerin Jacob ; Amit Prakash Shukla > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH] app/test-eventdev: improve DMA adapter test &g

RE: [PATCH] test/event: fix incorrect target event queue

2024-08-22 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, August 22, 2024 2:08 AM > To: Jerin Jacob ; Amit Prakash Shukla > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH] test/event: fix incorrect target event queue > >

[PATCH] app/dma-perf: per device config support

2024-08-05 Thread Amit Prakash Shukla
Add support to configure device specific config parameters for a testcase. Example: lcore_dma0=lcore=11,dev=:00:04.1,dir=mem2dev,raddr=0x3, coreid=1,pfid=2,vfid=3 lcore_dma1=lcore=12,dev=:00:04.2,dir=dev2mem,raddr=0x2, coreid=3,pfid=2,vfid=1 Signed-off-by: Amit Prakash

[PATCH v4] doc: announce changes to dma device structures

2024-07-30 Thread Amit Prakash Shukla
level. Signed-off-by: Vamsi Attunuru Signed-off-by: Amit Prakash Shukla --- v4 changes: - Fix checkpatch warning. v3 changes: - Add maintainers in email list. v2 changes: - Add more description to commit log. - Add more description to deprecation.rst. doc/guides/rel_notes/deprecation.rst | 5 +++

[PATCH v3] doc: announce changes to dma device structures

2024-07-30 Thread Amit Prakash Shukla
uired priority level. Signed-off-by: Vamsi Attunuru Signed-off-by: Amit Prakash Shukla --- v3 changes: - Add maintainers in email list. v2 changes: - Add more description to commit log. - Add more description to deprecation.rst. doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 inser

[PATCH v2] doc: announce changes to dma device structures

2024-07-30 Thread Amit Prakash Shukla
uired priority level. Signed-off-by: Vamsi Attunuru Signed-off-by: Amit Prakash Shukla --- v2 changes: - Add more description to commit log. - Add more description to deprecation.rst. doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_

[PATCH] doc: fix dma perf typo

2024-07-25 Thread Amit Prakash Shukla
Fixing typo in command line arguments for dma perf application. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Amit Prakash Shukla --- doc/guides/tools/dmaperf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

RE: [PATCH] eventdev/dma: fix missing response info in forward mode

2024-06-25 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, June 24, 2024 2:53 PM > To: Jerin Jacob ; Amit Prakash Shukla > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH] eventdev/dma: fix missing response info in forward mode &g

RE: [PATCH v2] doc: add dma perf feature details

2024-05-27 Thread Amit Prakash Shukla
Hi, Gentle Ping. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Tuesday, March 19, 2024 12:16 AM > To: Cheng Jiang ; Chengwen Feng > > Cc: dev@dpdk.org; Jerin Jacob ; Vamsi Krishna Attunuru > ; Anoob Joseph ; > Gowrishankar Muth

RE: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops

2024-05-16 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, April 17, 2024 1:57 PM > To: Jerin Jacob ; Amit Prakash Shukla > ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH v3 1/2] eventdev/dm

RE: [PATCH 1/2] eventdev/dma: reorganize event DMA ops

2024-05-16 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Saturday, April 6, 2024 3:43 PM > To: Jerin Jacob ; Amit Prakash Shukla > ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH 1/2] eventdev/dma: reorgan

[PATCH v2] doc: add dma perf feature details

2024-03-18 Thread Amit Prakash Shukla
Update dma perf test document with below support features: 1. Memory-to-device and device-to-memory copy. 2. Skip support. 3. Scatter-gather support. Signed-off-by: Amit Prakash Shukla --- v2: - Rebased the patch. doc/guides/tools/dmaperf.rst | 89 ++-- 1 file

[PATCH] doc: add dma perf feature details

2024-03-18 Thread Amit Prakash Shukla
Update dma perf test document with below support features: 1. Memory-to-device and device-to-memory copy. 2. Skip support. 3. Scatter-gather support. Signed-off-by: Amit Prakash Shukla --- doc/guides/tools/dmaperf.rst | 89 ++-- 1 file changed, 64 insertions

[PATCH v4] app/eventdev: support DMA adapter test

2024-03-12 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla Acked-by: Pavan Nikhilesh --- v4: - Updated release notes. v3: - Resolved review comments. v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c

[PATCH v3] app/eventdev: support DMA adapter test

2024-03-06 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- v3: - Resolved review comments. v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 36

[PATCH v5 3/3] event/cnxk: support DMA event functions

2024-03-03 Thread Amit Prakash Shukla
Added support of dma driver callback assignment to eventdev enqueue and dequeue. The change also defines dma adapter capabilities function. Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID") Signed-off-by: Amit Prakash Shukla --- v5: - Fixed checkpatch warning. v

[PATCH v5 2/3] dma/cnxk: support for DMA event enqueue dequeue

2024-03-03 Thread Amit Prakash Shukla
Added cnxk driver support for dma event enqueue and dequeue. Also added changes for work queue entry completion status and dual workslot DMA event enqueue. Signed-off-by: Pavan Nikhilesh Signed-off-by: Amit Prakash Shukla --- v5: - Fixed checkpatch warning. v4: - Fixed compilation error

[PATCH v5 1/3] common/cnxk: dma result to an offset of the event

2024-03-03 Thread Amit Prakash Shukla
Adds support to configure writing result to offset of the DMA response event. Signed-off-by: Amit Prakash Shukla --- v5: - Fixed checkpatch warning. v4: - Fixed compilation error. - Updated release notes. v3: - Rebased and fixed compilation error. v2: - Added dual workslot enqueue support

[PATCH v4 3/3] event/cnxk: support DMA event functions

2024-03-01 Thread Amit Prakash Shukla
Added support of dma driver callback assignment to eventdev enqueue and dequeue. The change also defines dma adapter capabilities function. Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID") Signed-off-by: Amit Prakash Shukla --- v4: - Fixed compilation error.

[PATCH v4 2/3] dma/cnxk: support for DMA event enqueue dequeue

2024-03-01 Thread Amit Prakash Shukla
Added cnxk driver support for dma event enqueue and dequeue. Also added changes for work queue entry completion status and dual workslot DMA event enqueue. Signed-off-by: Pavan Nikhilesh Signed-off-by: Amit Prakash Shukla --- v4: - Fixed compilation error. - Updated release notes. v3

[PATCH v4 1/3] common/cnxk: dma result to an offset of the event

2024-03-01 Thread Amit Prakash Shukla
Adds support to configure writing result to offset of the DMA response event. Signed-off-by: Amit Prakash Shukla --- v4: - Fixed compilation error. - Updated release notes. v3: - Rebased and fixed compilation error. v2: - Added dual workslot enqueue support. - Fixed compilation error

RE: [PATCH v2] app/eventdev: support DMA adapter test

2024-03-01 Thread Amit Prakash Shukla
Hi Pavan, Thanks for the review and feedback. I will send next version with suggested changes. Thanks, Amit Shukla > > diff --git a/app/test-eventdev/test_perf_common.c b/app/test- > > eventdev/test_perf_common.c index 5e0255cfeb..509d3f9232 100644 > > --- a/app/test-eventdev/test_perf_common

RE: [EXTERNAL] Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-03-01 Thread Amit Prakash Shukla
Hi Chengwen, Please find my reply in-line. Thanks, Amit Shukla > Hi Amit, > > On 2024/3/1 16:31, Amit Prakash Shukla wrote: > > Hi Chengwen, > > > > If I'm not wrong, your concern was about config file additions and not > > about the test as such. If the

RE: [EXTERNAL] Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-03-01 Thread Amit Prakash Shukla
10@:00:04.2, lcore12@:00:04.4 will do dev2mem and lcore11@:00:04.3, lcore13@:00:04.5 will do mem2dev. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Friday, March 1, 2024 7:16 AM > To: Amit Prakash Shukla ; Cheng Jiang > ; Gowrishan

[PATCH v3] app/dma-perf: support bi-directional transfer

2024-02-29 Thread Amit Prakash Shukla
Adds bi-directional DMA transfer support to test performance. One DMA device on one core will do mem2dev transfer and another DMA device on another core will do dev2mem transfer. Depends-on: series-31298 ("PCI Dev and SG copy support") Signed-off-by: Amit Prakash Shukla --- v3: - Re

RE: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-02-29 Thread Amit Prakash Shukla
/20231206112952.1588-1-vipin.vargh...@amd.com/. I believe this patch can be taken as-is and we can come up with the solution when we can increase the CFG_VALUE_LEN as changing CFG_VALUE_LEN in this release is causing ABI breakage. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash

RE: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-02-28 Thread Amit Prakash Shukla
Hi Chengwen, Please see my reply in-line. Thanks Amit Shukla > -Original Message- > From: fengchengwen > Sent: Wednesday, February 28, 2024 12:34 PM > To: Amit Prakash Shukla ; Cheng Jiang > ; Gowrishankar Muthukrishnan > > Cc: dev@dpdk.org; Jerin Jacob ; Anoob J

[PATCH v2] app/eventdev: support DMA adapter test

2024-02-27 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 28 +++ app/test-eventdev

[PATCH v2] app/dma-perf: support bi-directional transfer

2024-02-27 Thread Amit Prakash Shukla
Adds bi-directional DMA transfer support to test performance. One DMA device on one core will do mem2dev transfer and another DMA device on another core will do dev2mem transfer. Depends-on: series-31252 ("PCI Dev and SG copy support") Signed-off-by: Amit Prakash Shukla --- v2: - Fix

[PATCH v10 2/4] app/dma-perf: add PCI device support

2024-02-27 Thread Amit Prakash Shukla
Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v10: - PCI config parsing using kvargs. app/test-dma-pe

[PATCH v10 4/4] app/dma-perf: add SG copy support

2024-02-27 Thread Amit Prakash Shukla
From: Gowrishankar Muthukrishnan Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v10: - SG config variables renamed. app/test-dma-perf/benchmark.c | 278 +- app/test-dma-perf/config.ini | 25

[PATCH v10 3/4] app/dma-perf: validate copied memory

2024-02-27 Thread Amit Prakash Shukla
From: Gowrishankar Muthukrishnan Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++-

[PATCH v10 1/4] app/dma-perf: add skip support

2024-02-27 Thread Amit Prakash Shukla
Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 48 ++-- app/test-dma-perf/main.h | 1 + 3 files

[PATCH v10 0/4] PCI Dev and SG copy support

2024-02-27 Thread Amit Prakash Shukla
Improve dma-perf application to support PCI dev and SG copy, along with additional supports as below: - validate copied memory - skip tests if not opted. v10: - Review suggestions. - v9 sent again. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support

[PATCH v9 1/4] app/dma-perf: add skip support

2024-02-27 Thread Amit Prakash Shukla
Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 48 ++-- app/test-dma-perf/main.h | 1 + 3 files

[PATCH v9 2/4] app/dma-perf: add PCI device support

2024-02-27 Thread Amit Prakash Shukla
Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v9: - PCI config parsing using kvargs. app/test-dma-pe

[PATCH v9 4/4] app/dma-perf: add SG copy support

2024-02-27 Thread Amit Prakash Shukla
From: Gowrishankar Muthukrishnan Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v9: - SG config variables renamed. app/test-dma-perf/benchmark.c | 278 +- app/test-dma-perf/config.ini | 25 +

[PATCH v9 3/4] app/dma-perf: validate copied memory

2024-02-27 Thread Amit Prakash Shukla
From: Gowrishankar Muthukrishnan Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++-

[PATCH v9 0/4] PCI Dev and SG copy support

2024-02-27 Thread Amit Prakash Shukla
Improve dma-perf application to support PCI dev and SG copy, along with additional supports as below: - validate copied memory - skip tests if not opted. v9: - Review suggestions. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support Gowrishankar

RE: [EXT] Re: [PATCH] app/dma-perf: support bi-directional transfer

2024-02-27 Thread Amit Prakash Shukla
Hi Chengwen, Please see my reply in-line. Thanks > -Original Message- > From: fengchengwen > Sent: Wednesday, February 21, 2024 11:54 AM > To: Amit Prakash Shukla ; Cheng Jiang > > Cc: dev@dpdk.org; Jerin Jacob ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilp

RE: [EXT] Re: [PATCH v8 2/4] app/dma-perf: add PCI device support

2024-02-27 Thread Amit Prakash Shukla
Hi Chengwen, Thanks for the review and feedback. I will send the next version with suggested changes. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Wednesday, February 21, 2024 8:56 AM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org; Amit Praka

[PATCH] app/eventdev: support DMA adapter test

2024-02-26 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 28 +++ app/test-eventdev/evt_options.h | 12 ++ app/test-eventdev

[PATCH v3 3/3] event/cnxk: support DMA event functions

2024-02-26 Thread Amit Prakash Shukla
Added support of dma driver callback assignment to eventdev enqueue and dequeue. The change also defines dma adapter capabilities function. Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID") Signed-off-by: Amit Prakash Shukla --- v3: - Rebased and fixed compila

[PATCH v3 2/3] dma/cnxk: support for DMA event enqueue dequeue

2024-02-26 Thread Amit Prakash Shukla
Added cnxk driver support for dma event enqueue and dequeue. Also added changes for work queue entry completion status and dual workslot DMA event enqueue. Signed-off-by: Pavan Nikhilesh Signed-off-by: Amit Prakash Shukla --- v3: - Rebased and fixed compilation error. v2: - Added dual workslot

[PATCH v3 1/3] common/cnxk: dma result to an offset of the event

2024-02-26 Thread Amit Prakash Shukla
Adds support to configure writing result to offset of the DMA response event. Signed-off-by: Amit Prakash Shukla --- v3: - Rebased and fixed compilation error. v2: - Added dual workslot enqueue support. - Fixed compilation error. drivers/common/cnxk/roc_dpi.c | 6 +- drivers/common

[PATCH v2 3/3] event/cnxk: support DMA event functions

2024-02-09 Thread Amit Prakash Shukla
Added support of dma driver callback assignment to eventdev enqueue and dequeue. The change also defines dma adapter capabilities function. Depends-on: series-30612 ("lib/dmadev: get DMA device using device ID") Signed-off-by: Amit Prakash Shukla --- v2: - Added dual workslot enque

[PATCH v2 2/3] dma/cnxk: support for DMA event enqueue dequeue

2024-02-09 Thread Amit Prakash Shukla
Added cnxk driver support for dma event enqueue and dequeue. Also added changes for work queue entry completion status and dual workslot DMA event enqueue. Signed-off-by: Pavan Nikhilesh Signed-off-by: Amit Prakash Shukla --- v2: - Added dual workslot enqueue support. - Fixed compilation error

[PATCH v2 1/3] common/cnxk: dma result to an offset of the event

2024-02-09 Thread Amit Prakash Shukla
Adds support to configure writing result to offset of the DMA response event. Signed-off-by: Amit Prakash Shukla --- v2: - Added dual workslot enqueue support. - Fixed compilation error. drivers/common/cnxk/roc_dpi.c | 6 +- drivers/common/cnxk/roc_dpi.h | 2 +- drivers

RE: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Amit Prakash Shukla
> > > > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, > > > vchan, event), > > > > > > at cnxk driver, this ops will check whether the DMA is > > > cnxk_dmadev_pci_driver. > > > > > > I think this is because the cnxk's event-and-dma implement has deep > > > coupling > > > >

RE: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Amit Prakash Shukla
Hi Thomas and Chengwen, Thank you for the review and feedback. Please find my comment in-line. Thanks, Amit Shukla > -- > Hi Thomas, > > > On 2024/2/9 0:25, Thomas Monjalon wrote: > > 19/12/2023 12:00

RE: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-05 Thread Amit Prakash Shukla
> Sent: Monday, January 8, 2024 8:17 PM > To: Amit Prakash Shukla ; Chengwen Feng > ; Kevin Laatz ; Bruce > Richardson > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Vamsi > Krishna Attunuru ; Nithin Kumar Dabilpuram > ; m...@smartsharesystems.com; Amit Prakash > Shukla > S

[PATCH] cnxk: fix representor stats

2024-02-02 Thread Amit Prakash Shukla
Representor stats were not matching the PF/VF stats as seen linux kernel. This patch fixes the same. Depends-on: series-30966 ("support for port representors") Signed-off-by: Amit Prakash Shukla --- drivers/common/cnxk/roc_mbox.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] app/dma-perf: support bi-directional transfer

2024-01-08 Thread Amit Prakash Shukla
Adds bi-directional DMA transfer support to test performance. Signed-off-by: Amit Prakash Shukla --- Depends-on: series-30357 ("PCI Dev and SG copy support") app/test-dma-perf/benchmark.c | 89 +-- app/test-dma-perf/config.ini | 5 ++ app/test-dma-p

[PATCH v2] lib/dmadev: get DMA device using device ID

2023-12-19 Thread Amit Prakash Shukla
DMA library has a function to get DMA device based on device name but there is no function to get DMA device using device id. Added a function that lookup for the dma device using device id and returns the pointer to the same. Signed-off-by: Amit Prakash Shukla Acked-by: Chengwen Feng --- v2

RE: [EXT] Re: [PATCH] lib/dmadev: get DMA device using device ID

2023-12-18 Thread Amit Prakash Shukla
Hi Bruce, Thanks for the review and feedback. Please find my reply in-line. Thanks, Amit Shukla > -Original Message- > From: Bruce Richardson > Sent: Monday, December 11, 2023 3:54 PM > To: Amit Prakash Shukla > Cc: Chengwen Feng ; Kevin Laatz > ; dev@dpd

RE: [EXT] Re: [PATCH] lib/dmadev: get DMA device using device ID

2023-12-18 Thread Amit Prakash Shukla
Hi Chengwen, Thanks for the review and feedback. I will send the next version with suggested changes. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Saturday, December 9, 2023 12:42 PM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richar

[PATCH 3/3] event/cnxk: support DMA event functions

2023-12-08 Thread Amit Prakash Shukla
Added support of dma driver callback assignment to eventdev enqueue and dequeue. The change also defines dma adapter capabilities function. Depends-on: patch-134955 ("lib/dmadev: get DMA device using device ID") Signed-off-by: Amit Prakash Shukla --- drivers/event/cnxk/cn10k_

[PATCH 2/3] dma/cnxk: support for DMA event enqueue dequeue

2023-12-08 Thread Amit Prakash Shukla
Added cnxk driver support for dma event enqueue and dequeue. Also added changes for work queue entry completion status. Signed-off-by: Amit Prakash Shukla --- doc/guides/eventdevs/cnxk.rst| 5 + drivers/dma/cnxk/cnxk_dma_event_dp.h | 21 +++ drivers/dma/cnxk/cnxk_dmadev.c | 2

[PATCH 1/3] common/cnxk: dma result to an offset of the event

2023-12-08 Thread Amit Prakash Shukla
Adds support to configure writing result to offset of the DMA response event. Signed-off-by: Amit Prakash Shukla --- drivers/common/cnxk/roc_dpi.c | 6 +- drivers/common/cnxk/roc_dpi.h | 2 +- drivers/common/cnxk/roc_dpi_priv.h | 4 drivers/common/cnxk/roc_idev.c

[PATCH] lib/dmadev: get DMA device using device ID

2023-12-07 Thread Amit Prakash Shukla
DMA library has a function to get DMA device based on device name but there is no function to get DMA device using device id. Added a function that lookup for the dma device using device id and returns the pointer to the same. Signed-off-by: Amit Prakash Shukla --- lib/dmadev/rte_dmadev.c

RE: [EXT] Re: [PATCH v7 1/4] app/dma-perf: add skip support

2023-11-22 Thread Amit Prakash Shukla
vember 20, 2023 8:25 AM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org > Cc: Anoob Joseph ; Cheng Jiang > ; Kevin Laatz ; Bruce > Richardson ; Pavan Nikhilesh Bhagavatula > ; Amit Prakash Shukla > > Subject: [EXT] Re: [PATCH v7 1/4] app/dma-perf: add

RE: [EXT] [PATCH v3 10/22] eal: replace strtok with reentrant version

2023-11-14 Thread Amit Prakash Shukla
> -Original Message- > From: Jie Hai > Sent: Tuesday, November 14, 2023 4:30 PM > To: dev@dpdk.org; Anatoly Burakov ; Amit > Prakash Shukla > Cc: haij...@huawei.com; lihuis...@huawei.com; > fengcheng...@huawei.com > Subject: [EXT] [PATCH v3 10/22] eal: repla

[PATCH v2] test/dma: fix for buffer auto free

2023-11-03 Thread Amit Prakash Shukla
uffer auto free offload") Signed-off-by: Amit Prakash Shukla --- v2: - Incorporated review suggestion from Chengwen. app/test/test_dmadev.c | 81 -- 1 file changed, 38 insertions(+), 43 deletions(-) diff --git a/app/test/test_dmadev.c b/app/test/tes

RE: [EXT] Re: [PATCH] test/dma: fix for buffer auto free

2023-11-02 Thread Amit Prakash Shukla
Hi Chengwen, Thanks for the review and feedback. I will send v2 with suggested changes. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Thursday, November 2, 2023 7:37 AM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richardson > Cc: dev@dpd

[PATCH] test/dma: fix for buffer auto free

2023-11-01 Thread Amit Prakash Shukla
Buffer auto free test failed for more than 1 dma device as the device initialization for the test was been done only for the first dma device. This changeset fixes the same. Fixes: 877cb3e37426 ("dmadev: add buffer auto free offload") Signed-off-by: Amit Prakash Shukla ---

[PATCH v2] dma/cnxk: offload source buffer free

2023-10-17 Thread Amit Prakash Shukla
Added support in driver, to offload source buffer free to hardware on completion of DMA transfer. Signed-off-by: Amit Prakash Shukla --- v2: - Patch rebased. v1: - Driver implementation from RFC. drivers/dma/cnxk/cnxk_dmadev.c| 48 +++ drivers/dma/cnxk

RE: [EXT] Re: [PATCH v4 1/2] dmadev: offload to auto free DMA buffer

2023-10-16 Thread Amit Prakash Shukla
Hi Thomas, Gentle ping. Could you please consider merging this series in RC1. Thanks, Amit Shukla From: fengchengwen Sent: Tuesday, October 10, 2023 7:10 AM To: Amit Prakash Shukla ; Kevin Laatz ; Bruce Richardson Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; conor.wa...@intel.com; Vamsi

[PATCH v4 2/2] test/dma: auto free offload test to free DMA buffer

2023-10-09 Thread Amit Prakash Shukla
Add a test case to validate the functionality of drivers' dma buffer offload auto free. As part of dmadev_autotest, test case will be executed only if the driver supports buffer offload auto free and if the test is exported by env variable DPDK_ADD_DMA_TEST. Signed-off-by: Amit Prakash S

[PATCH v4 1/2] dmadev: offload to auto free DMA buffer

2023-10-09 Thread Amit Prakash Shukla
This changeset adds support in DMA library to auto free DMA buffer by hardware. On a supported hardware, application can pass on the mempool information as part of vchan config. Signed-off-by: Amit Prakash Shukla Acked-by: Morten Brørup Acked-by: Anoob Joseph --- lib/dmadev/rte_dmadev.h | 43

[PATCH v4 0/2] offload support to auto free dma buffer

2023-10-09 Thread Amit Prakash Shukla
: - Implementation from RFC. - Add test support to validate functionality. Amit Prakash Shukla (2): dmadev: offload to auto free DMA buffer test/dma: auto free offload test to free DMA buffer app/test/test_dmadev.c | 167 +++- lib/dmadev/rte_dmadev.h | 43 +++ 2

RE: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer

2023-10-09 Thread Amit Prakash Shukla
Hi Chengwen, Ack, I will make the changes in next version of the patch. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Monday, October 9, 2023 2:29 PM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richardson > Cc: dev@dpdk.org; Jerin J

RE: [EXT] Re: [PATCH v3 2/2] test/dma: add source buffer offload free test

2023-10-09 Thread Amit Prakash Shukla
> -Original Message- > From: fengchengwen > Sent: Saturday, October 7, 2023 3:03 PM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richardson > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > m...@smartsharesystems.com; conor.wa...@intel.com; Vamsi Kris

RE: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer

2023-10-09 Thread Amit Prakash Shukla
Hi Chengwen, Thanks for the review and feedback. Please find my reply in-line. Thanks, Amit Shukla > -Original Message- > From: fengchengwen > Sent: Saturday, October 7, 2023 2:31 PM > To: Amit Prakash Shukla ; Kevin Laatz > ; Bruce Richardson > Cc: dev@dpd

RE: [PATCH v3 0/2] offload support to free dma source buffer

2023-10-05 Thread Amit Prakash Shukla
> -Original Message- > From: Anoob Joseph > Sent: Thursday, September 28, 2023 5:29 PM > To: Amit Prakash Shukla > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > m...@smartsharesystems.com; fengcheng...@huawei.com; > kevin.la...@intel.com; bruce.richard...@intel.com;

[PATCH] doc: add cnxk dmadev performance tuning details

2023-09-29 Thread Amit Prakash Shukla
Updated cnxk DMA driver document to explain about performance tuning parameters for kernel module. Signed-off-by: Amit Prakash Shukla --- doc/guides/dmadevs/cnxk.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/dmadevs/cnxk.rst b/doc/guides

[PATCH v8 12/12] app/test: add event DMA adapter auto-test

2023-09-29 Thread Amit Prakash Shukla
Added testsuite to test the dma adapter functionality. The testsuite detects event and DMA device capability and accordingly dma adapter is configured and modes are tested. Test command: sudo /app/test/dpdk-test --vdev=dma_skeleton \ event_dma_adapter_autotest Signed-off-by: Amit Prakash Shukla

[PATCH v8 11/12] eventdev/dma: support adapter event port get

2023-09-29 Thread Amit Prakash Shukla
Added support for DMA adapter event port get. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index f299914dec

[PATCH v8 10/12] eventdev/dma: support adapter enqueue

2023-09-29 Thread Amit Prakash Shukla
Added API support to enqueue a DMA operation to the DMA driver. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index

[PATCH v8 09/12] eventdev/dma: support adapter stats

2023-09-29 Thread Amit Prakash Shukla
Added DMA adapter stats API support to get and reset stats. DMA SW adapter stats and eventdev driver supported stats for enqueue and dequeue are reported by get API. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 95 1 file changed, 95

[PATCH v8 08/12] eventdev/dma: support adapter runtime params

2023-09-29 Thread Amit Prakash Shukla
Added support to set and get runtime params for DMA adapter. The parameters that can be set/get are defined in struct rte_event_dma_adapter_runtime_params. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 93 1 file changed, 93

[PATCH v8 07/12] eventdev/dma: support adapter service ID get

2023-09-29 Thread Amit Prakash Shukla
Added API support to get DMA adapter service ID. Service id returned in the variable by the API call shall be used by application to map a service core. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 17 + 1 file changed, 17 insertions(+) diff

[PATCH v8 06/12] eventdev/dma: support adapter start and stop

2023-09-29 Thread Amit Prakash Shukla
Added API support to start and stop DMA adapter. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 69 1 file changed, 69 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index

[PATCH v8 05/12] eventdev/dma: support adapter service function

2023-09-29 Thread Amit Prakash Shukla
Added support for DMA adapter service function for event devices. Enqueue and dequeue of event from eventdev and DMA device are done based on the adapter mode and the supported HW capabilities. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 592

[PATCH v8 04/12] eventdev/dma: support vchan add and delete

2023-09-29 Thread Amit Prakash Shukla
Added API support to add and delete vchan's from the DMA adapter. DMA devid and vchan are added to the addapter instance by calling rte_event_dma_adapter_vchan_add and deleted using rte_event_dma_adapter_vchan_del. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adap

[PATCH v8 03/12] eventdev/dma: support adapter create and free

2023-09-29 Thread Amit Prakash Shukla
Added API support to create and free DMA adapter. Create function shall be called with event device to be associated with the adapter and port configuration to setup an event port. Signed-off-by: Amit Prakash Shukla --- config/rte_config.h | 1 + lib/eventdev/meson.build

[PATCH v8 02/12] eventdev/dma: support adapter capabilities get

2023-09-29 Thread Amit Prakash Shukla
Added a new eventdev API rte_event_dma_adapter_caps_get(), to get DMA adapter capabilities supported by the driver. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/meson.build| 2 +- lib/eventdev/rte_eventdev.c | 23 +++ 2 files changed, 24 insertions(+), 1 deletion

[PATCH v8 01/12] eventdev/dma: introduce DMA adapter

2023-09-29 Thread Amit Prakash Shukla
Introduce event dma adapter interface to transfer packets between dma device and event device. Signed-off-by: Amit Prakash Shukla Acked-by: Jerin Jacob --- MAINTAINERS |6 + doc/api/doxy-api-index.md |1 + doc/guides/eventdevs

  1   2   3   4   >