probe().
The fix is to call rte_eth_dev_attach_secondary(), for secondary
process, from virtio_user_pmd_probe.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Cc: sta...@dpdk.org
Signed-off-by: Ami Sabo
---
drivers/net/virtio/virtio_user_ethdev.c | 26 --
Today eth_dev_attach_secondary is defined as static and can only be
called by pci drivers. However, the functionality is also required for
non-pci drivers - so the patch export the function.
Signed-off-by: Ami Sabo
---
v2: Fix coding style issues (Yuanhan Liu)
---
lib/librte_ether/rte_ethdev.c
initialized.
The patchset contains 2 patches:
1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be
allowed to call it.
2. Fix the actual bug by calling the function during virtio_user probe.
Ami Sabo (2):
lib/librte_ether: export secondary attach function
net/virtio-user: fix multi
Fixed code style issues following Yuanhan Liu's review.
Signed-off-by: Ami Sabo
---
lib/librte_ether/rte_ethdev.h | 2 +-
lib/librte_ether/rte_ether_version.map | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_
l bug by calling the function during virtio_user probe.
3. Code style fixes following Yuanhan Lio's comments.
Ami Sabo (3):
lib/librte_ether: export secondary attach function
net/virtio-user: fix multi-process issue
lib/librte_ether: fix code style issues
drivers/net/virtio/virtio_user_
Today eth_dev_attach_secondary is defined as static and can only be
called by pci drivers. However, the functionality is also required for
non-pci drivers - so the patch export the function.
Signed-off-by: Ami Sabo
---
lib/librte_ether/rte_ethdev.c | 6 +++---
lib/librte_ether
probe().
The fix is to call rte_eth_dev_attach_secondary(), for secondary
process, from virtio_user_pmd_probe.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Cc: sta...@dpdk.org
Signed-off-by: Ami Sabo
---
drivers/net/virtio/virtio_user_ethdev.c | 26 --
ailto:yuanhan@linux.intel.com]
Sent: Tuesday, February 28, 2017 8:40 AM
To: Ami Sabo
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: Re: [PATCH 2/2] net/virtio-user: fix multi-process issue
On Sun, Feb 26, 2017 at 11:55:26AM +0200, Ami Sabo wrote:
> Secondary process doesn't properly attach to the rte_eth_
probe().
The fix is to call rte_eth_dev_attach_secondary(), for secondary
process, from virtio_user_pmd_probe.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Cc: sta...@dpdk.org
Signed-off-by: Ami Sabo
---
drivers/net/virtio/virtio_user_ethdev.c | 26 --
Today eth_dev_attach_secondary is defined as static and can only be
called by pci drivers. However, the functionality is also required for
non-pci drivers - so the patch export the function.
Signed-off-by: Ami Sabo
---
lib/librte_ether/rte_ethdev.c | 6 +++---
lib/librte_ether
initialized.
The patchset contains 2 patches:
1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be
allowed to call it.
2. Fix the actual bug by calling the function during virtio_user probe.
Ami Sabo (2):
lib/librte_ether: export secondary attach function
net/virtio-user: fix multi
o_user_pmd_probe() is called instead of
rte_eth_dev_pci_probe().
To fix it: Allow non-pci drivers call to dev_attach_secondary() and
call it (for secondary process) from virtio_user_pmd_probe.
Signed-off-by: Ami Sabo
---
drivers/net/virtio/virtio_user_ethdev.c | 29 +
l
Mistakenly sent only partial diff.
Resent the all patch (from the original code base) as a reply to the first
message in the thread.
-- Ami
-Original Message-
From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
Sent: Thursday, February 23, 2017 4:55 AM
To: Ami Sabo
Cc: dev@dpdk.org
ndary().
However, for virtio-user virtio_user_pmd_probe() is called instead of
rte_eth_dev_pci_probe().
To fix it: Allow non-pci drivers call to dev_attach_secondary() and
call it (for secondary process) from virtio_user_pmd_probe.
Signed-off-by: Ami Sabo
---
drivers/net/virt
o_user_pmd_probe() is called instead of
rte_eth_dev_pci_probe().
To fix it: Allow non-pci drivers call to dev_attach_secondary() and
call it (for secondary process) from virtio_user_pmd_probe.
---
v2:
* Fix coding style issues.
Signed-off-by: Ami Sabo
---
drivers/net/virt
tio-user virtio_user_pmd_probe() is called instead of
rte_eth_dev_pci_probe().
To fix it: Allow non-pci drivers call to dev_attach_secondary() and
call it (for secondary process) from virtio_user_pmd_probe.
Signed-off-by: Ami Sabo
---
drivers/net/virtio/virtio_user_ethdev.c | 32 +++--
16 matches
Mail list logo
