RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> On Wed, 9 Jul 2025 at 18:03, Akhil Goyal wrote: > > > > > On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > > > > > To get better performance, using async mode to replace sync mode > > > > > > > > > > Si

RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > To get better performance, using async mode to replace sync mode > > > > > > Signed-off-by: Zhangfei Gao > > > --- > > > doc/guides/compressdevs/uadk.rst | 15 +++ >

RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> To get better performance, using async mode to replace sync mode > > Signed-off-by: Zhangfei Gao > --- > doc/guides/compressdevs/uadk.rst | 15 +++ > drivers/compress/uadk/meson.build | 4 +- > drivers/compress/uadk/uadk_compress_pmd.c | 94 ++- >

RE: [PATCH] crypto/virtio: fix virtio desc flags virtq info

2025-07-08 Thread Akhil Goyal
> -Original Message- > From: Rajesh Mudimadugula > Sent: Thursday, June 26, 2025 2:49 PM > To: dev@dpdk.org > Cc: jianjay.z...@huawei.com; Akhil Goyal ; Rajesh > Mudimadugula [C] > Subject: [PATCH] crypto/virtio: fix virtio desc flags virtq info > >

RE: [EXTERNAL] [PATCH v4 2/2] crypto/uadk: use async mode to replace sync mode

2025-07-08 Thread Akhil Goyal
> To get better performance, using async mode to replace sync mode > > However, case UADK_CHAIN_CIPHER_AUTH and UADK_CHAIN_AUTH_CIPHER > still use sync mode for the first operation and async mode for > the second operation since the dependence. > > Also RTE_CRYPTO_AUTH_OP_VERIFY will hold the gen

RE: [EXTERNAL] [PATCH v3 0/2] uadk: realize async mode

2025-06-30 Thread Akhil Goyal
> Hi, Akhil > > On Mon, 30 Jun 2025 at 17:04, Akhil Goyal wrote: > > > > > > > make[2]: Entering directory '/home/gakhil/up/uadk' > > > > > depbase=`echo wd_alg.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ > >

RE: [EXTERNAL] [PATCH v3 0/2] uadk: realize async mode

2025-06-30 Thread Akhil Goyal
> > > make[2]: Entering directory '/home/gakhil/up/uadk' > > > depbase=`echo wd_alg.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ > > > /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > > > - > Wall -Werror -fno-strict-aliasing -I./include -fPIC -fPIE -pie > -fstack-protecto

RE: [EXTERNAL] [PATCH v3 2/2] crypto/uadk: use async mode to replace sync mode

2025-06-25 Thread Akhil Goyal
Recheck-request: rebase=main, iol-unit-amd64-testing, iol-compile-amd64-testing

RE: [PATCH] app/test: update EdDSA test vector description

2025-06-25 Thread Akhil Goyal
> Subject: [PATCH] app/test: update EdDSA test vector description > > Changed the message parameter from 1 to 3 in the EdDSA 25519PH test > vector description. > > Fixes: 2fba5232e77e ("test/crypto: add asymmetric EdDSA cases") > Cc: sta...@dpdk.org > > Signed-off-by: Sucharitha Sarananaga > --

RE: [PATCH v3 0/2] add crypto adapter support in cn20k

2025-06-25 Thread Akhil Goyal
> -Original Message- > From: Nithinsen Kaithakadan > Sent: Wednesday, June 18, 2025 2:07 PM > To: dev@dpdk.org > Cc: Ankur Dwivedi ; Anoob Joseph > ; Tejasree Kondoj ; Akhil Goyal > ; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH v3 0/2] add crypto adapter

RE: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets

2025-06-25 Thread Akhil Goyal
> Subject: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets > > While running ipsec-secgw application if IPV6 rules are not > configured in ipsec configuration lpm look up fails and > destination port is updated as BAD_PORT.During process_packet > ethernet_hdr is updated resulti

RE: [EXTERNAL] [PATCH v3 0/2] uadk: realize async mode

2025-06-25 Thread Akhil Goyal
> Realize async mode to replace sync mode for better performance > > v3: > uadk 2.9 is released > use different label name to fix build warning: > "duplicate label table_uadk_versions" I am unable to build uadk x86. It seems macros are not defined for x86 make[2]: Entering directory '/hom

RE: [PATCH 3/3] test/crypto: fix RSA decrypt op validation

2025-06-25 Thread Akhil Goyal
> Subject: [PATCH 3/3] test/crypto: fix RSA decrypt op validation > > Following RSA encrypt op, same plaintext buffer is used as output > buffer for decrypt op, hence comparing plaintext buffer against > same buffer pointer in crypto op always succeed irrespective of > whether decrypt op succeeds

RE: [PATCH v3] app/crypto-perf: add support for RSA decrypt

2025-06-25 Thread Akhil Goyal
> Subject: [PATCH v3] app/crypto-perf: add support for RSA decrypt > > This patch enables support for RSA decrypt and verify operations > and added cipher and sign test vectors. > > v2: > * Added macro for buffer size > * Fixed RSA sign buffer corruption > > v3: > * Restrict default public key u

RE: [PATCH 0/3] fixes and addition of aes ctr test vectors

2025-06-25 Thread Akhil Goyal
> Include AES CTR test cases and resolve test failures > > Nithinsen Kaithakadan (3): > test/crypto: add ctr test cases and vectors > test/crypto: set iv len to 32B for auth and cipher > test/crypto: set ptr to null post crypto op free > > app/test/test_cryptodev.c | 3

RE: [PATCH v2 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets

2025-06-25 Thread Akhil Goyal
> Subject: [PATCH v2 1/1] examples/ipsec-secgw: resolve segfault for IPsec > packets > > launching ipsec-segw application in event vector mode > after traffic has started results in segfault because > we are receiving few IPSEC packet and application is trying > to decrypt IPSEC packets using loo

RE: [PATCH 3/3] test/crypto: fix RSA decrypt op validation

2025-06-24 Thread Akhil Goyal
Recheck-request: rebase=main, iol-unit-amd64-testing

RE: [PATCH v3] app/crypto-perf: add support for RSA decrypt

2025-06-24 Thread Akhil Goyal
Recheck-request: rebase=main, iol-compile-amd64-testing, iol-unit-amd64-testing

RE: [PATCH] app/test: update EdDSA test vector description

2025-06-24 Thread Akhil Goyal
Recheck-request: rebase=main, iol-compile-amd64-testing, iol-unit-amd64-testing

RE: [PATCH v3 2/2] crypto/cnxk: add sessionless asym cn20k support

2025-06-24 Thread Akhil Goyal
Recheck-request: rebase=main, iol-compile-amd64-testing

RE: [PATCH 3/3] test/crypto: set ptr to null post crypto op free

2025-06-24 Thread Akhil Goyal
Recheck-request: rebase=main, iol-compile-amd64-testing, iol-unit-amd64-testing

RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

2025-06-17 Thread Akhil Goyal
> compress/zlib: support PDCP checksum > > compress/zlib: support zlib dictionary > > compressdev: add PDCP checksum > > compressdev: support zlib dictionary > > Adds support to provide predefined dictionaries to zlib. Handles setting > and getting of dictionaries using zlib apis. Also includes

RE: [PATCH v2] crypto/cnxk: add crypto adapter for cn20k

2025-06-17 Thread Akhil Goyal
Recheck-request: iol-compile-amd64-testing

RE: [PATCH] app/test: update EdDSA test vector description

2025-06-17 Thread Akhil Goyal
Recheck-request: iol-compile-amd64-testing

RE: [PATCH v3] app/crypto-perf: add support for RSA decrypt

2025-06-17 Thread Akhil Goyal
Recheck-request: iol-compile-amd64-testing

RE: [EXTERNAL] [dpdk-dev v1] app/test-crypto-perf: remove unsupported test cases from perf json

2025-06-17 Thread Akhil Goyal
> Remove all unsupported test cases in json files > > Signed-off-by: Kai Ji Applied to dpdk-next-crypto

RE: [EXTERNAL] [PATCH v3] crypto/qat: remove ZUC 256 support

2025-06-17 Thread Akhil Goyal
> Due to changes in the specification related to IV size and initialization > sequence remove ZUC 256 support from Gen 3 and 5 hardware > > Signed-off-by: Radu Nicolau > Acked-by: Kai Ji > --- Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/qat: fix out-of-place chain/cipher/auth headers

2025-06-17 Thread Akhil Goyal
> Acked-by: Kai Ji > > From: Radu Nicolau > Sent: 12 June 2025 11:14 > To: Ji, Kai ; Kusztal, ArkadiuszX > > Cc: dev@dpdk.org ; Nicolau, Radu ; > sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix out-of-place chain/cipher/auth headers > > Extend the original fix to gen3 and gen4 code. > >

RE: [PATCH v2 0/7] fixes and new features to cnxk crypto PMD

2025-06-17 Thread Akhil Goyal
> -Original Message- > From: Tejasree Kondoj > Sent: Monday, June 9, 2025 4:11 PM > To: Akhil Goyal > Cc: Anoob Joseph ; Nithinsen Kaithakadan > ; Rupesh Chiluka ; Vidya > Sagar Velumuri ; dev@dpdk.org > Subject: [PATCH v2 0/7] fixes and new features to c

RE: [PATCH] test/crypto: test vectors for additional ECDH groups

2025-06-17 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Wednesday, May 28, 2025 8:30 PM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Gowrishankar Muthukrishnan > > Subject: [PATCH] test/crypto: test vectors for additional E

RE: [EXTERNAL] [PATCH v1 1/1] compress/zsda: code cleanup

2025-06-17 Thread Akhil Goyal
> zsda compress code cleanup. > > Signed-off-by: Hanxiao Li Patch applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH v2 0/2] uadk: realize async mode

2025-06-17 Thread Akhil Goyal
> Realize async mode to replace sync mode for better performance > > v2: > Add version check, requires uadk >= 2.9 This version DO NOT exist as of now. > Add version table describing DPDK and external UADK library > version compatibility > Mention version dependence in release notes > >

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-06-04 Thread Akhil Goyal
> On Mon, 26 May 2025 at 14:15, Akhil Goyal wrote: > > > > > DPDK deprecation notice need not include API changes in external libraries. > > We just need to notify the users about the version of ZSDA external lib is > > going > to change in next release or s

RE: [EXTERNAL] [PATCH] crypto/virtio: fix driver ID for virtio

2025-06-03 Thread Akhil Goyal
> This patch corrects driver id for virtio and virtio_user > pmds. > > Fixes: 25500d4b8076 ("crypto/virtio: support device init") > > Signed-off-by: Rajesh Mudimadugula Cc: sta...@dpdk.org Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH] crypto/virtio: fix PMD cleanup

2025-06-03 Thread Akhil Goyal
> Improper cleanup resulted in a segfault when more > than 1 device was used > > Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") > Cc: jianjay.z...@huawei.com > Cc: sta...@dpdk.org > > Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH] crypto/virtio: add request check on request side

2025-06-03 Thread Akhil Goyal
> Add same request checks on the request side. > > Fixes: b2866f473369 ("vhost/crypto: fix missed request check for copy mode") > Cc: roy.fan.zh...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Radu Nicolau Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2 00/25] add CN20K support to cnxk crypto PMD

2025-06-03 Thread Akhil Goyal
> Subject: [PATCH v2 00/25] add CN20K support to cnxk crypto PMD > > This series adds CN20K support to cnxk crypto PMD. > > v2: > * Fixed individual patch compilation > * Fixed unnecessary code movement > * Updated patch titles > * Added release notes Series Applied to dpdk-next-crypto Fixed a c

RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
Also update release notes. > Subject: RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD > > Please fix individual patch compilation > > [2/34] Compiling C object > drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o > FAILED: > drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cn

RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
Please fix individual patch compilation [2/34] Compiling C object drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o FAILED: drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o ccache gcc -Idrivers/libtmp_rte_crypto_cnxk.a.p -Idrivers -I../drivers -Idrivers

RE: [PATCH 0/6] fixes and improvements to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
> -Original Message- > From: Tejasree Kondoj > Sent: Tuesday, May 27, 2025 9:31 AM > To: Akhil Goyal > Cc: Anoob Joseph ; Aakash Sasidharan > ; Vidya Sagar Velumuri ; > dev@dpdk.org > Subject: [PATCH 0/6] fixes and improvements to cnxk crypto PMD >

RE: [PATCH] crypto/virtio: fix DER encoding of RSA public key

2025-05-28 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, May 10, 2025 4:11 PM > To: dev@dpdk.org; Jay Zhou > Cc: Anoob Joseph ; Akhil Goyal ; > Gowrishankar Muthukrishnan > Subject: [PATCH] crypto/virtio: fix DER encoding of RSA public key >

RE: [EXTERNAL] [PATCH v2 0/9] DPAA2 crypto driver changes

2025-05-28 Thread Akhil Goyal
> V2 changes: > - fix checkpatch warning > - fix 32 bit compilation error > - fix a commit message > - update document > > Gagandeep Singh (5): > common/dpaax: fix invalid key command error > common/dpaax: fix for PDCP AES only 12bit SN case > common/dpaax: support 12bit SN in pdcp uplan

RE: [EXTERNAL] [PATCH v6 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-27 Thread Akhil Goyal
e mode 100644 doc/guides/cryptodevs/zsda.rst > create mode 100644 drivers/crypto/zsda/zsda_crypto.c > create mode 100644 drivers/crypto/zsda/zsda_crypto.h > create mode 100644 drivers/crypto/zsda/zsda_crypto_capabilities.h > create mode 100644 drivers/crypto/zsda/zsda_crypto_pmd.c >

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-25 Thread Akhil Goyal
> On Thu, 22 May 2025 at 19: 50, Akhil Goyal wrote: > > > > > Hi, Akhil > > > > > > On Wed, 21 May 2025 at 20: 39, Akhil Goyal wrote: > > > > ZjQcmQRYFpfptBannerStart Prioritize security for external emails:

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-22 Thread Akhil Goyal
> Hi, Akhil > > On Wed, 21 May 2025 at 20:39, Akhil Goyal wrote: > > > > > Realize async mode to replace sync mode for better performance > > > > > > Zhangfei Gao (2): > > > compress/uadk: use async mode to replace sync mode >

RE: [EXTERNAL] Re: [v5,1/9] crypto/zsda: add skeleton

2025-05-22 Thread Akhil Goyal
> Hi akhil: > > There is a critical warning, maybe can called error, that the patches can't be > applied. > > Because I formatted some files in patch "[v1] compress/zsda: code formatting", > whose link is > https://patches.dpdk.org/project/dpdk/patch/20250522062351.2266776-1- > li.hanx...@zte.com

RE: [EXTERNAL] [PATCH] cryptodev: allow use of global variables from C++

2025-05-21 Thread Akhil Goyal
7,10 @@ rte_crypto_asym_ke_strings[]; > > extern const char * > > rte_crypto_asym_op_strings[]; > > > > +#ifdef __cplusplus > > +} > > +#endif > > + > > #define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_NO_PADDING > > RTE_BIT32(0) > > It seems only th

RE: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets

2025-05-21 Thread Akhil Goyal
> Subject: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets > > launching ipsec-segw application in event vector mode > after traffic has started results in segfault because > we are receiving few IPSEC packet and application is trying > to decrypt IPSEC packets using lookasi

RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf

2025-05-21 Thread Akhil Goyal
d will be > > costly. > > So to workaround this, if segment-sz is passed as argument, use values in > > buffer-sz in descending order. > > > > Signed-off-by: Akhil Goyal > > Acked-by: Anoob Joseph Applied to dpdk-next-crypto

RE: [EXTERNAL] [PATCH v4 1/9] crypto/zsda: add skeleton

2025-05-21 Thread Akhil Goyal
> diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c > index 0ef7cac585..a5f00d8ab6 100644 > --- a/drivers/common/zsda/zsda_qp.c > +++ b/drivers/common/zsda/zsda_qp.c > @@ -15,6 +15,9 @@ static uint8_t zsda_num_used_qps; > static struct ring_size zsda_qp_hw_ring_size[ZSDA_M

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-21 Thread Akhil Goyal
> Realize async mode to replace sync mode for better performance > > Zhangfei Gao (2): > compress/uadk: use async mode to replace sync mode > crypto/uadk: use async mode to replace sync mode > > drivers/compress/uadk/uadk_compress_pmd.c | 107 -- > .../compress/uadk/uadk_compress_pmd

RE: [EXTERNAL] [PATCH v2 0/9] DPAA2 crypto driver changes

2025-05-21 Thread Akhil Goyal
> V2 changes: > - fix checkpatch warning > - fix 32 bit compilation error > - fix a commit message > - update document > > Gagandeep Singh (5): > common/dpaax: fix invalid key command error > common/dpaax: fix for PDCP AES only 12bit SN case > common/dpaax: support 12bit SN in pdcp uplan

RE: [EXTERNAL] Re: [dpdk-dev v1] app/test-crypto-perf: remove decrypt test case from perf

2025-05-21 Thread Akhil Goyal
> On 02-May-25 11:12 AM, Kai Ji wrote: > > > Remove all decrypt test cases in aesni-mb throughput perf as the > decrypt throughput testing only support OOP by dpdk-test-crypto-perf > > Signed-off-by: Kai Ji > --- > > Acked-by: Radu Nicolau App

RE: [EXTERNAL] [PATCH] crypto/qat: fix out-of-place chain, cipher and auth headers

2025-05-21 Thread Akhil Goyal
> This commit fixes a problem with overwriting data in the OOP header > in RAW API crypto processing when using chain, cipher and auth algorithms. > > Signed-off-by: Arkadiusz Kusztal Fied check patch issue Applied to dpdk-next-crypto

RE: [PATCH] test/crypto: add test case for modex group 24

2025-05-21 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: add test case for modex group 24 > > > > Add test case for modex group 24. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Acked-by: Anoob Joseph > Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/qat: fix out-of-place header bytes in aead raw api

2025-05-21 Thread Akhil Goyal
> Hey Arek > > > -Original Message- > > From: Kusztal, ArkadiuszX > > Sent: Thursday 20 March 2025 16:57 > > To: dev@dpdk.org > > Cc: gak...@marvell.com; Ji, Kai ; Dooley, Brian > > ; Kusztal, ArkadiuszX > > ; sta...@dpdk.org > > Subject: [PATCH] crypto/qat: fix out-of-place header bytes

RE: [EXTERNAL] [PATCH] app/crypto-perf: avoid infinite loop

2025-05-21 Thread Akhil Goyal
r PMD can process the packet. > > Signed-off-by: Rupesh Chiluka > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXTERNAL] [PATCH] app/crypto-perf: fix aad offset alignment

2025-05-21 Thread Akhil Goyal
> > > > > > Hi, > > > > AAD offset in AES-GCM crypto test was calculated by adding 16-byte > > > > alignment after the IV, which is only needed in AES-CCM. > > > > > > Agreed that CCM has a requirement for 16B alignment. > > > But for GCM, does it break any protocol? Can we not align to byte > > >

RE: [PATCH] test/crypto: fix return value in RSA test

2025-05-21 Thread Akhil Goyal
Cc: sta...@dpdk.org > Subject: [PATCH] test/crypto: fix return value in RSA test > > This patch fixes incorrect return value when RSA negative > test scenario is validated. > > Coverity-issue: 457463 > Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification") > > Signed-off-by:

RE: [PATCH] test/crypto: fix return value in RSA test

2025-05-21 Thread Akhil Goyal
> This patch fixes incorrect return value when RSA negative > test scenario is validated. > > Coverity-issue: 457463 > Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification") > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goya

RE: [PATCH] crypto/cnxk: fix uninitialized scalar variable

2025-05-21 Thread Akhil Goyal
> > This change fixes an uninitialized local variable as reported in coverity > > issue > > 445390. > > > > Coverity-issue: 445390 > > Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA") > > Cc: sta...@dpdk.org > > > > Signed-off-by:

RE: [PATCH] crypto/cnxk: fix out-of-bounds access

2025-05-21 Thread Akhil Goyal
> > Fix coverity issue on out-of-bounds access. > > Coverity-issue: 403166, 403171, 403172 > Fixes: 5686b573e4b ("crypto/cnxk: support SM2") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/virtio: check for invalid IOVA address

2025-05-21 Thread Akhil Goyal
Muthukrishnan Cc: sta...@dpdk.org Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks

RE: [PATCH v2] test/crypto: increment dequeue timeout

2025-05-21 Thread Akhil Goyal
> Increment dequeue timeout to allow implementations taking > longer cycles. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks

[PATCH] doc: add limitation in using segment-sz in crypto-perf

2025-05-16 Thread Akhil Goyal
and rest of the SGs are lost resulting in segfault. Buffers cannot be re-initialized as that will come in datapath and will be costly. So to workaround this, if segment-sz is passed as argument, use values in buffer-sz in descending order. Signed-off-by: Akhil Goyal --- doc/guides/tools

RE: [EXTERNAL] [PATCH v3 1/9] crypto/zsda: add skeleton

2025-05-15 Thread Akhil Goyal
> + > +int zsda_sym_dev_create(struct zsda_pci_device *zsda_pci_dev); > + > +void zsda_sym_dev_destroy(struct zsda_pci_device *zsda_pci_dev); > + sym->crypto missed here.

RE: [EXTERNAL] [PATCH v3 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-15 Thread Akhil Goyal
Please fix CI. https://mails.dpdk.org/archives/test-report/2025-May/877907.html > > v3: > - Modify the code according to the advise > > v2: > - Modify the errors about cryptodevs/zsda.rst. > - Modify the errors about author. > > v1: > - Add zsda cryptodev driver. > > > Hanxiao Li (9): > cryp

RE: [EXTERNAL] [PATCH v2 9/9] app/test: add zsda cryptodev test

2025-05-14 Thread Akhil Goyal
> Add crypto test for zsda device and driver. > > Signed-off-by: Hanxiao Li > --- > app/test/test_cryptodev.c| 7 +++ > app/test/test_cryptodev.h| 1 + > doc/guides/compressdevs/zsda.rst | 6 ++ > 3 files changed, 14 insertions(+) > > diff --git a/app/test/test_cryptodev

RE: [EXTERNAL] [PATCH v2 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-14 Thread Akhil Goyal
Hi Hanxiao, I have completed my first level review. Please rework and rebase on TOT and ensure all patches are getting compiled sequentially. Thanks for your patience. Will try to merge in RC1 if all goes well. Regards, Akhil > v2: > - Modify the errors about cryptodevs/zsda.rst. > - Modify th

RE: [EXTERNAL] [PATCH v2 5/9] crypto/zsda: add session configuration

2025-05-14 Thread Akhil Goyal
> +static void > +zsda_sym_session_clear(struct rte_cryptodev *dev __rte_unused, > +struct rte_cryptodev_sym_session *sess __rte_unused) > +{} I believe you need to clear session private data in session clear.

RE: [EXTERNAL] [PATCH v2 3/9] crypto/zsda: add statistics

2025-05-14 Thread Akhil Goyal
> Add crypto statistics operations for zsda devices. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/crypto/zsda/zsda_sym_pmd

RE: [EXTERNAL] [PATCH v2 4/9] crypto/zsda: add queue pair configuration

2025-05-14 Thread Akhil Goyal
> Add crypto queue pair configuration operations for zsda device. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 68 +- > 1 file changed, 66 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/cryp

RE: [EXTERNAL] [PATCH v2 2/9] crypto/zsda: add device operations

2025-05-14 Thread Akhil Goyal
> Add crypto device operations for zsda devices. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 94 -- > 1 file changed, 89 insertions(+), 5 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/crypto/zsda/zsda_sym_

RE: [EXTERNAL] [PATCH v2 1/9] crypto/zsda: add skeleton

2025-05-13 Thread Akhil Goyal
> diff --git a/doc/guides/compressdevs/zsda.rst > b/doc/guides/compressdevs/zsda.rst > index 25b7884535..34cbf235af 100644 > --- a/doc/guides/compressdevs/zsda.rst > +++ b/doc/guides/compressdevs/zsda.rst > @@ -174,6 +174,15 @@ e.g. for the 1cf2 device:: > Use ``modprobe vfio-pci disable_denylist=

RE: [EXTERNAL] [PATCH 1/2] vhost: fix cipher data length

2025-04-09 Thread Akhil Goyal
value. This is > rectified and using correct cipher data length in vhost crypto. > > Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Cc: sta...@dpdk.org > > Signed-off-by: Rajesh Mudimadugula Acked-by: Akhil Goyal

RE: [EXTERNAL] [PATCH 2/2] crypto/virtio: fix cipher data src length

2025-04-09 Thread Akhil Goyal
> In symmetric algorithm chaining, we need to consider both > cipher and auth data length for cipher source. > > Fixes: 82adb12a1fce ("crypto/virtio: support burst enqueue/dequeue") Cc: sta...@dpdk.org > > Signed-off-by: Rajesh Mudimadugula Acked-by: Akhil Goyal

RE: [EXTERNAL] [PATCH] app/crypto-perf: fix aad offset alignment

2025-03-17 Thread Akhil Goyal
Hi, > AAD offset in AES-GCM crypto test was calculated by adding > 16-byte alignment after the IV, which is only needed in AES-CCM. Agreed that CCM has a requirement for 16B alignment. But for GCM, does it break any protocol? Can we not align to byte boundary for performance? This is a performanc

RE: [PATCH] test/crypto: skip test when virtio PMD not loaded

2025-03-17 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: skip test when virtio PMD not loaded > > Skip asymmetric test when virtio PMD is not loaded. > > Fixes: 7e2e9d5f3227 ("test/crypto: add asymmetric cases for virtio") > Fixes: a8f3d4f5b547 ("test/crypto: add cases for virtio-user") > > Signed-off-by: Gowrishankar M

RE: [EXTERNAL] [PATCH v2] common/qat: fix incorrect size in the parser

2025-03-17 Thread Akhil Goyal
> The function `strlen` returns the size of the string without a terminating > null-character, therefore a request to allocate memory space for a parsed > argument is too small by 1. > > Fixes: 99ab2806687b ("common/qat: isolate parser arguments configuration") > Cc: sta...@dpdk.org > > Signed-of

RE: [v2] app/crypto-perf: add RSA support

2025-03-11 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, February 27, 2025 11:51 PM > To: dev@dpdk.org; Brian Dooley > Cc: Anoob Joseph ; Akhil Goyal > Subject: [v2] app/crypto-perf: add RSA support > > From: Akhil Goyal > >

RE: [v6 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-03-05 Thread Akhil Goyal
ivers/crypto/virtio/virtio_rxtx.h > create mode 100644 drivers/crypto/virtio/virtio_user/vhost.h > create mode 100644 drivers/crypto/virtio/virtio_user/vhost_vdpa.c > create mode 100644 drivers/crypto/virtio/virtio_user/virtio_user_dev.c > create mode 100644 drivers/crypto/virtio/virt

RE: [EXTERNAL] [PATCH] app/test: fix the check of the oop header data

2025-03-02 Thread Akhil Goyal
> The data of the out-of-place header is never checked. Therefore, > the faulty PMD, which overwrites this data, will not be able to > verify that with tests. New checks to support that were added to > the GCM OOP functions. > > Fixes: 51e202f0596f ("test/crypto: rename GCM test code") > Cc: sta..

RE: [EXTERNAL] [PATCH] crypto/qat: fix incorrect sm3 state size

2025-03-02 Thread Akhil Goyal
> This commit fixes incorrectly set state size within > the QAT PMD. > > Fixes: 75fd4bbc94ab ("crypto/qat: support SM3 hash algorithm") > Cc: sta...@dpdk.org > > Signed-off-by: Arkadiusz Kusztal Applied to dpdk-next-crypto

RE: [EXTERNAL] [PATCH] test/crypto: remove unused variable

2025-03-02 Thread Akhil Goyal
isunderstanding that session_priv_mpool still needs initialization. > > Fixes: bdce2564dbf7 ("cryptodev: rework session framework") > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > > Signed-off-by: Shaokai Zhang > Reviewed-by: Joey Xing

RE: [EXTERNAL] [PATCH v5 1/3] cryptodev: add SM4 GCM

2025-03-02 Thread Akhil Goyal
> Added support for symmetric algorithm SM4 GCM in cryptodev. > > Signed-off-by: Brian Dooley > --- > v5: > Change with GCM mode to in GCM mode Acked-by: Akhil Goyal Series applied to dpdk-next-crypto Thanks.

RE: [PATCH] common/qat: fix incorrect size in the parser

2025-03-02 Thread Akhil Goyal
> > Subject: [PATCH] common/qat: fix incorrect size in the parser > > > > The function `strlen` returns the size of the string without a terminating > > null- > > character, therefore a request to allocate memory space for a parsed > > argument > > is too small by 1. > > > > Fixes: 99ab2806687b (

RE: [v2 1/2] crypto/openssl: validate incorrect signature in verify op

2025-03-02 Thread Akhil Goyal
...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal Series applied to dpdk-next-crypto

RE: [PATCH] crypto/cnxk: fix status code in asymmetric operation

2025-03-02 Thread Akhil Goyal
> Subject: [PATCH] crypto/cnxk: fix status code in asymmetric operation > > Return error code in an asymmetric operation status > when none of the known conditions met. > > Fixes: d29c4e0a4bea ("crypto/cnxk: fix ECDH public key verification") > > Signed-off-by: Gowrishankar Muthukrishnan > ---

RE: [PATCH] examples/ipsec-secgw: fix iv len in ctr 192/256

2025-03-02 Thread Akhil Goyal
> -Original Message- > From: Nithinsen Kaithakadan > Sent: Friday, February 7, 2025 7:16 PM > To: Radu Nicolau ; Akhil Goyal > Cc: Anoob Joseph ; Tejasree Kondoj > ; Nithin Kumar Dabilpuram > ; dev@dpdk.org > Subject: [PATCH] examples/ipsec-secgw: fix iv len

RE: [EXTERNAL] [PATCH] test/crypto: fix the bug of AES-ECB test

2025-03-02 Thread Akhil Goyal
ectly describes it as "192-byte plaintext". > > Fixes: c94c520b4163 ("crypto/aesni_mb: support AES-ECB") > Cc: sta...@dpdk.org > > Signed-off-by: Shaokai Zhang > Reviewed-by: Joey Xing Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [External] [PATCH v2] cryptodev: not close device when secondary exit

2025-03-02 Thread Akhil Goyal
close need to be called from the application separately before it is > > released > > which I think is already happening. > > > > Adding more people for review. > > > > > Hi Akhil, I suppose the change of removing `dev_close` in > `pmd_release_device` requires much more effort and commit size because > this change will impact a lot of examples and cases. As there is no more > comments from other people, can we accept this patch as a little > improvement for the second process's scenario and wait for the entire > improvement from anyone who is interested in this entire work? Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [EXTERNAL] [PATCH] cryptodev: allow use of global variables from C++

2025-03-02 Thread Akhil Goyal
Hi Mattias, Can you update this patch? > > Avoid C++ name mangling of the two global variables being exported > > from . > > > > Suggested-by: David Marchand > > Signed-off-by: Mattias Rönnblom > > --- > > lib/cryptodev/rte_crypto_asym.h | 8 > > 1 file changed, 8 insertions(+) > > >

RE: [v4 0/5] vhost: add RSA support

2025-02-23 Thread Akhil Goyal
Hi Maxime, Can you pick these patches in vhost tree first so that virtio/crypto patches can be merged in crypto tree? Regards, Akhil > Subject: [v4 0/5] vhost: add RSA support > > This patch series supports asymmetric RSA in vhost crypto library. > It also includes changes to improve vhost cryp

RE: [v4 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-02-23 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, February 22, 2025 2:47 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Akhil Goyal ; > Gowrishankar Muthukrishnan > Subject: [v4 0/6] crypto/virtio: enhancements for RSA and vDPA > > This p

RE: [v4 4/5] vhost: support asymmetric RSA crypto ops

2025-02-23 Thread Akhil Goyal
> Subject: [v4 4/5] vhost: support asymmetric RSA crypto ops > > Support asymmetric RSA crypto operations in vhost-user. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal You may want to update documentation and release notes also.

RE: [v4 1/5] vhost: skip crypto op fetch before vring init

2025-02-23 Thread Akhil Goyal
rypto: add public function implementation") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [v4 5/5] examples/vhost_crypto: support asymmetric crypto

2025-02-23 Thread Akhil Goyal
> Subject: [v4 5/5] examples/vhost_crypto: support asymmetric crypto > > Support asymmetric crypto operations. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Update documentation for newly added parameter. Apart from that. Acked-by: Akhil Goyal

RE: [v4 3/5] examples/vhost_crypto: fix user callbacks

2025-02-23 Thread Akhil Goyal
gt; > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [v4 2/5] vhost: update vhost_user crypto session parameters

2025-02-23 Thread Akhil Goyal
te QEMU version in documentation somewhere? > Due to additional parameters added in QEMU, received payload from > QEMU would be larger than existing payload, hence breaks parsing > vhost_user message. > > This patch addresses both of the above problems. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [EXTERNAL] Re: [PATCH v6 7/8] app: reduce app dependencies

2025-02-19 Thread Akhil Goyal
> On Wed, Feb 19, 2025 at 11:18:46AM +0100, Morten Brørup wrote: > > > From: Akhil Goyal [mailto:gak...@marvell.com] > > > Sent: Wednesday, 19 February 2025 09.16 > > > > > > Hi David, > > > > Hello, > > > > > > > >

  1   2   3   4   5   6   7   8   9   10   >