Re: Driver: bnxt_en

2025-03-27 Thread Ajit Khaparde
e you need the actual PCI-ID, using pcilookup.com >> 14e4:16d7 >> >> Look at source of drivers/net/bnxt/bnxt_ethdev.c for the pci table >> bnxt_id_pci_map. >> The entry for 16d7 is >> #define BROADCOM_DEV_ID_57414 0x16d7 >> >&

Re: [PATCH v3 04/11] drivers/net: remove AVX2 build-time define

2025-03-18 Thread Ajit Khaparde
f RTE_ARCH_x86" used in its place. > > Signed-off-by: Bruce Richardson For bnxt: Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c| 2 -- > drivers/net/octeon_ep/meson.build | 1 - > drivers/net/octeon_ep/otx_ep_ethdev.c | 4 > 3 files change

Re: [PATCH 0/2] bxnt fixes

2025-03-11 Thread Ajit Khaparde
On Mon, Mar 10, 2025 at 2:01 PM Ajit Khaparde wrote: > > These patches address a couple of issues in the BNXT PMD. > Please apply. Merged in dpdk-next-net-brcm. Thanks > > Ajit Khaparde (2): > net/bnxt: configure burst threshold based on speed > net/bnxt: fix

[PATCH 0/2] bxnt fixes

2025-03-10 Thread Ajit Khaparde
These patches address a couple of issues in the BNXT PMD. Please apply. Ajit Khaparde (2): net/bnxt: configure burst threshold based on speed net/bnxt: fix epoch bit calculation drivers/net/bnxt/bnxt_ethdev.c | 20 drivers/net/bnxt/bnxt_ring.h| 19

[PATCH 1/2] net/bnxt: configure burst threshold based on speed

2025-03-10 Thread Ajit Khaparde
The fixed value of Rx burst threshold may not be optimal for all the NIC speeds. For high speed NIC ports, like 400G configure a higher Rx burst value. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt

[PATCH 2/2] net/bnxt: fix epoch bit calculation

2025-03-10 Thread Ajit Khaparde
tting") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ring.h| 19 +++ drivers/net/bnxt/bnxt_rxq.c | 1 + drivers/net/bnxt/bnxt_rxq.h | 1 + driver

Re: MPLS Push action

2025-03-03 Thread Ajit Khaparde
+Thomas Monjalon On Mon, Mar 3, 2025 at 8:02 AM Kishore Padmanabha wrote: > > Hi, > > > > Anyone has any inputs on this. Or should I add new CLI commands in testpmd to > support action for push MPLS tag. > > > > Thanks, > > Kishore > > > > > > From: Kishore Padmanabha > Sent: Thursday, February

Re: [PATCH 00/11] bnxt patch set

2025-02-06 Thread Ajit Khaparde
On Wed, Feb 5, 2025 at 9:20 AM Ajit Khaparde wrote: > > Patchset with bug fixes for bnxt PMD. > Also addresses various Coverity issues reported in the recent > Coverity scan. > > Please apply. Patchset applied to dpdk-next-net-brcm subtree. Thanks > > Ajit Khaparde (4

[PATCH 11/11] net/bnxt: address coverity control flow issues

2025-02-05 Thread Ajit Khaparde
From: Peter Spreadborough This change addresses the CID 449072: Control flow issues (DEADCODE) reported by coverity. Coverity issue: 449072 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 06/11] net/bnxt: address coverity deadcode issue

2025-02-05 Thread Ajit Khaparde
Spreadborough Reviewed-by: Ajit Khaparde --- .../hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c| 90 +-- .../p70/host/cfa_bld_p70_host_mpc_wrapper.c | 150 +- 2 files changed, 120 insertions(+), 120 deletions(-) diff --git a/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c b

[PATCH 10/11] net/bnxt: address coverity uninitialized variables issues

2025-02-05 Thread Ajit Khaparde
From: Peter Spreadborough This change addresses the CID 449065: Uninitialized variables (UNINIT) issues reported by coverity. Coverity issue: 449065 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 + drivers/net/bnxt/tf_ulp

[PATCH 08/11] net/bnxt: address coverity overflow issues

2025-02-05 Thread Ajit Khaparde
From: Peter Spreadborough This change addresses the CID 449058: Integer handling issues (OVERFLOW_BEFORE_WIDEN) reported by coverity. Coverity issue: 449058 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 2 +- 1 file changed, 1

[PATCH 09/11] net/bnxt: address coverity integer overflow issues

2025-02-05 Thread Ajit Khaparde
From: Peter Spreadborough This change addresses the CID 449059: Integer handling issues (INTEGER_OVERFLOW) reported by coverity. Coverity issue: 449059 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c | 6 +- 1 file changed, 5

[PATCH 07/11] net/bnxt: address coverity checked return issues

2025-02-05 Thread Ajit Khaparde
From: Peter Spreadborough This change addresses the CID 449056: Error handling issues (CHECKED_RETURN) reported by coverity. The changes add return code handling to address the issue. Coverity issue: 449056 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt

[PATCH 03/11] net/bnxt: fix Rx handler

2025-02-05 Thread Ajit Khaparde
.@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 5b43bcbea6..b53d9a917a 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/driver

[PATCH 05/11] net/bnxt/truFlow: Fix seg fault when rep are re-attached

2025-02-05 Thread Ajit Khaparde
PF/VF) along with children (VFRs). Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Cc: sta...@dpdk.org Signed-off-by: Sangtani Parag Satishbhai Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnx

[PATCH 02/11] net/bnxt: simplify check for CQE mode

2025-02-05 Thread Ajit Khaparde
Simplify the check for the CQE mode. We don't have to check the Rx offload mode to determine which CQE mode is supported. CQE mode is configured at load time and once set will decide if TCP LRO or buffer split can be supported or not. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath

[PATCH 04/11] net/bnxt: set burst handler correctly

2025-02-05 Thread Ajit Khaparde
We are incorrectly setting the Rx and Tx burst handlers to static mode by default. Fix that by using the bnxt_receive_function and bnxt_transmit_function calls to determine if the vector mode is enabled and identify the appropriate burst handler during the initialization. Signed-off-by: Ajit

[PATCH 01/11] net/bnxt: disable TruFlow if compressed CQE is set

2025-02-05 Thread Ajit Khaparde
: Ajit Khaparde Signed-off-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 5 + drivers/net/bnxt/bnxt_hwrm.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 21e9aa902c..81a7723c7e 100644 --- a

[PATCH 00/11] bnxt patch set

2025-02-05 Thread Ajit Khaparde
Patchset with bug fixes for bnxt PMD. Also addresses various Coverity issues reported in the recent Coverity scan. Please apply. Ajit Khaparde (4): net/bnxt: disable TruFlow if compressed CQE is set net/bnxt: simplify check for CQE mode net/bnxt: fix Rx handler net/bnxt: fix burst

Re: [PATCH] net/bnxt: remove unnecessary checks for null pointer

2025-01-28 Thread Ajit Khaparde
On Tue, Jan 28, 2025 at 9:42 AM Stephen Hemminger wrote: > > The function rte_free() handles a NULL pointer as no-op. > This patch was automatically generated from nullfree.cocci script. > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > --- > driver

Re: [RFC 4/7] net/bnxt: fix use after free

2025-01-27 Thread Ajit Khaparde
location of PF info struct") > Cc: ajit.khapa...@broadcom.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_filter.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [PATCH] net/bnxt: fix segmentation fault

2024-11-20 Thread Ajit Khaparde
On Wed, Nov 20, 2024 at 9:01 AM Ajit Khaparde wrote: > > From: Kishore Padmanabha > > The mbuf offload flags were not reset before the flags were > populated with the received packet details. This causes certain > applications to act differently on the offload flags. That can &

[PATCH] net/bnxt: fix segmentation fault

2024-11-20 Thread Ajit Khaparde
/bnxt: support Rx completion v3") Cc: sta...@dpdk.org Signed-off-by: Kishore Padmanabha Reviewed-by: Jay Ding Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_r

Re: [PATCH v3 0/2] bnxt patchset

2024-11-18 Thread Ajit Khaparde
On Mon, Nov 18, 2024 at 1:13 PM Ajit Khaparde wrote: > > v1->v2: Rebasing patchset based on latest dpdk tree. > v2->v3: Dropped an incomplete patch which ended up on mailing list. Patches rebased and applied to dpdk-next-net-brcm. > > Please apply. > > Ajit Khapard

Re: [PATCH v1 0/4] TruFlow fixes for Thor2

2024-11-18 Thread Ajit Khaparde
On Mon, Nov 18, 2024 at 8:07 AM Sriharsha Basavapatna wrote: > > This patch series fixes a few issues in TruFlow for Broadcom Thor2 NIC. Patchset applied to dpdk-next-net-brcm. Fixed up a couple of typos during merge. > > Kishore Padmanabha (2): > net/bnxt/tf_ulp: fix vfr clean up and stats loc

[PATCH v3 2/2] net/bnxt: add support for Rx profile selection

2024-11-18 Thread Ajit Khaparde
Some firmware versions can support the selection of Rx profile during Rx and AGG ring allocation. Check if the firmware sets the HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT3_RX_RATE_PROFILE_SEL_SUPPORTED flag and set the new Rx profile. Signed-off-by: Ajit Khaparde Reviewed-by: Andy Gospodarek

[PATCH v3 0/2] bnxt patchset

2024-11-18 Thread Ajit Khaparde
v1->v2: Rebasing patchset based on latest dpdk tree. v2->v3: Dropped an incomplete patch which ended up on mailing list. Please apply. Ajit Khaparde (2): net/bnxt: update HWRM API net/bnxt: add support for Rx profile selection drivers/net/bnxt/bnxt.h| 1 + drivers/ne

[PATCH v3 1/2] net/bnxt: update HWRM API

2024-11-18 Thread Ajit Khaparde
Update HWRM API to select ring profile. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/hsi_struct_def_dpdk.h index

[PATCH 0/3] bnxt patchset

2024-11-18 Thread Ajit Khaparde
bnxt patchset rebased against the latest dpdk repository. Ajit Khaparde (3): net/bnxt: update HWRM API net/bnxt: add support for Rx profile selection net/bnxt: set max VFs count for P7 drivers/net/bnxt/bnxt.h| 2 + drivers/net/bnxt/bnxt_hwrm.c | 15

[PATCH 2/3] net/bnxt: add support for Rx profile selection

2024-11-18 Thread Ajit Khaparde
Some firmware versions can support the selection of Rx profile during Rx and AGG ring allocation. Check if the firmware sets the HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT3_RX_RATE_PROFILE_SEL_SUPPORTED flag and set the new Rx profile. Signed-off-by: Ajit Khaparde Reviewed-by: Andy Gospodarek

[PATCH 3/3] net/bnxt: set max VFs count for P7

2024-11-18 Thread Ajit Khaparde
The number of max VFs per PF is 128 for P7 devices. Cap the vnic hash table creation if the number of max VNICs is less than 8. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_vnic.c | 6 ++ 2 files changed, 7

[PATCH 1/3] net/bnxt: update HWRM API

2024-11-18 Thread Ajit Khaparde
Update HWRM API to select ring profile. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/hsi_struct_def_dpdk.h index

[PATCH 1/2] net/bnxt: update HWRM API

2024-11-15 Thread Ajit Khaparde
Update HWRM API to select ring profile. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h b/drivers/net/bnxt/hsi_struct_def_dpdk.h index

[PATCH 2/2] net/bnxt: add support for Rx profile selection

2024-11-15 Thread Ajit Khaparde
Some firmware versions can support the selection of Rx profile during Rx and AGG ring allocation. Check if the firmware sets the HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT3_RX_RATE_PROFILE_SEL_SUPPORTED flag and set the new Rx profile. Signed-off-by: Ajit Khaparde Reviewed-by: Andy Gospodarek

Re: [PATCH v3 08/10] app/test-pmd: remove redundant condition

2024-11-15 Thread Ajit Khaparde
md: support policy actions per color") > Cc: haif...@nvidia.com > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson Acked-by: Ajit Khaparde > --- > app/test-pmd/config.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/app/test-

Re: [PATCH v2 08/10] app/test-pmd: remove redundant condition

2024-11-14 Thread Ajit Khaparde
md: support policy actions per color") > Cc: haif...@nvidia.com > Signed-off-by: Stephen Hemminger Reviewed-by: Ajit Khaparde > --- > app/test-pmd/config.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/co

Re: [PATCH v8 00/47] TruFlow update for Thor2

2024-11-07 Thread Ajit Khaparde
On Thu, Nov 7, 2024 at 6:05 PM Sriharsha Basavapatna wrote: > > On Thu, Nov 7, 2024 at 7:12 PM Sriharsha Basavapatna > wrote: > > > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > > > TruFlow(TF) is the software library that exposes CFA HW resources to > > upper l

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-29 Thread Ajit Khaparde
On Tue, Oct 29, 2024 at 7:48 AM Ori Kam wrote: > > Hi Ajit, Nithin and Olivier > > > -Original Message- > > From: Ajit Khaparde > > Sent: Friday, October 25, 2024 2:33 AM > > > > On Thu, Oct 24, 2024 at 12:30 PM Alexander Kozyrev > >

[PATCH v2 11/13] net/bnxt: remove some unnecessary logs

2024-10-27 Thread Ajit Khaparde
Remove some unnecessary logs messages when buffer allocation fails. We already have stats to indicate such failures. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net

[PATCH v2 13/13] net/bnxt: remove unnecessary ifdef

2024-10-27 Thread Ajit Khaparde
Remove the unnecessary and useless compile-time option for IEEE 1588. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 8f0a1b9cfd..5b43bcbea6 100644 --- a

[PATCH v2 10/13] net/bnxt: remove the VNIC async event handler

2024-10-27 Thread Ajit Khaparde
From: Kishore Padmanabha The VNIC async event handler is removed, it is no longer required if during the port initialization if svif is used instead of VNIC which could be invalid for rep port if the rep's VF port link is down. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle ---

[PATCH v2 09/13] net/bnxt: disable VLAN filter when TF is enabled

2024-10-27 Thread Ajit Khaparde
From: Kishore Padmanabha For p7 platform, the vlan filter and strip is disabled if the truflow is enabled on the platform. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/bnxt/bnxt_rxq.c| 17 +++-- 2 files

[PATCH v2 12/13] net/bnxt: add support for buffer split Rx offload

2024-10-27 Thread Ajit Khaparde
Add header and data split Rx offload support if the hardware supports it. The packet will be split at fixed offset for IPv4 or IPv6 packets. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + drivers/net/bnxt/bnxt_hwrm.c | 29

[PATCH v2 05/13] net/bnxt: add check for invalid mbuf passed by application

2024-10-27 Thread Ajit Khaparde
From: Kalesh AP If the application passes invalid mbuf for a Tx pkt, this could escape all the existing driver checks and driver could end up sending down invalid TX BDs to the HW. This in turn could lead to a FW reset. Fix by validating the "mbuf->buf_iova" or "mbuf->buf_addr" passed for the Tx

[PATCH v2 07/13] net/bnxt: register for and handle RSS change event

2024-10-27 Thread Ajit Khaparde
unction only "sets" the new QCAPS flags, but not clearing them, if they were cleared due to some events. Fixed this by clearing the flags first, so that we could correctly set the new ones (for that bp). Signed-off-by: Manish Kurup Reviewed-by: Kalesh AP Reviewed-by: Ajit K

[PATCH v2 08/13] net/bnxt: fix LRO offload capability

2024-10-27 Thread Ajit Khaparde
Signed-off-by: Ajit Khaparde Reviewed-by: Vasuthevan Maheswaran --- drivers/net/bnxt/bnxt_rxq.c | 7 ++- drivers/net/bnxt/bnxt_rxr.c | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 1c25c57ca6..249fe7f6e5 10

[PATCH v2 06/13] net/bnxt: free and account a bad Tx mbuf

2024-10-27 Thread Ajit Khaparde
encounteres a bad mbuf during transmit. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_stats.c | 9 + drivers/net/bnxt/bnxt_txq.h | 1 + drivers/net/bnxt/bnxt_txr.c | 65 +-- 3 files changed, 57 insertions(+), 18 deletions

[PATCH v2 04/13] net/bnxt: add check for number of segs

2024-10-27 Thread Ajit Khaparde
pipeline stall. Fix it by validating the number of segs passed for the Tx pkt against what is actually set by the application to prevent this. Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH v2 03/13] net/bnxt: add check to validate TSO segment size

2024-10-27 Thread Ajit Khaparde
requested in the MBUF flags. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_txr.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt

[PATCH v2 02/13] net/bnxt: fix bad action offset in Tx bd

2024-10-27 Thread Ajit Khaparde
;) Cc: sta...@dpdk.org Signed-off-by: Peter Spreadborough Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index

[PATCH v2 01/13] net/bnxt: fix TCP and UDP checksum flags

2024-10-27 Thread Ajit Khaparde
Set TCP and UDP checksum flags explicitly for LSO capable packets. In some older chip variants, this will enable the hardware compute the checksum correctly for tunnel and non-tunnel packets. Fixes: 1d76c878b21d ("net/bnxt: support updating IPID") Cc: sta...@dpdk.org Signed-off-by: Aji

[PATCH v2 00/13] patchset for bnxt PMD

2024-10-27 Thread Ajit Khaparde
This patchset contains changes to the BNXT PMD. Some of them are fixes. Please accept and apply. v1->v2: Fixed up coding style issues, spelling errors. Ajit Khaparde (6): net/bnxt: fix TCP and UDP checksum flags net/bnxt: free and account a bad Tx mbuf net/bnxt: fix LRO offload capabil

Re: [PATCH 2/2] drivers/net: support single queue per port

2024-10-25 Thread Ajit Khaparde
_PORT]; > | ^~ > > To fix this, a hint is added to the network drivers where a compiler in > the CI has been seen to emit the above error when DPDK is configured for > one queue per port, but we know that the error cannot occur. > > Signed-off

[PATCH 07/13] net/bnxt: register for and handle RSS change event

2024-10-25 Thread Ajit Khaparde
unction only "sets" the new QCAPS flags, but not clearing them, if they were cleared due to some events. Fixed this by clearing the flags first, so that we could correctly set the new ones (for that bp). Signed-off-by: Manish Kurup Reviewed-by: Kalesh AP Reviewed-by: Ajit K

[PATCH 10/13] net/bnxt: remove the VNIC async event handler

2024-10-25 Thread Ajit Khaparde
From: Kishore Padmanabha The VNIC async event handler is removed, it is no longer required if during the port initialization if svif is used instead of VNIC which could be invalid for rep port if the rep's VF port link is down. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle ---

[PATCH 13/13] net/bnxt: remove unnecessary ifdef

2024-10-25 Thread Ajit Khaparde
Remove the unnnecessary and useless compile-time option for IEEE 1588. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 8f0a1b9cfd..5b43bcbea6 100644 --- a

[PATCH 12/13] net/bnxt: add support for buffer split Rx offload

2024-10-25 Thread Ajit Khaparde
Add header and data split Rx offload support if the hardware supports it. The packet will be split at fixed offset for IPv4 or IPv6 packets. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + drivers/net/bnxt/bnxt_hwrm.c | 29

[PATCH 11/13] net/bnxt: remove some unnecessary logs

2024-10-25 Thread Ajit Khaparde
Remove some unnecessary logs messages when buffer allocation fails. We already have stats to indicate such failures. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net

[PATCH 09/13] net/bnxt: disable VLAN filter when TF is enabled

2024-10-25 Thread Ajit Khaparde
From: Kishore Padmanabha For p7 platform, the vlan filter and strip is disabled if the truflow is enabled on the platform. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/bnxt/bnxt_rxq.c| 17 +++-- 2 files

[PATCH 08/13] net/bnxt: fix LRO offload capability

2024-10-25 Thread Ajit Khaparde
Signed-off-by: Ajit Khaparde Reviewed-by: Vasuthevan Maheswaran --- drivers/net/bnxt/bnxt_rxq.c | 7 ++- drivers/net/bnxt/bnxt_rxr.c | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 1c25c57ca6..249fe7f6e5 10

[PATCH 06/13] net/bnxt: free and account a bad Tx mbuf

2024-10-25 Thread Ajit Khaparde
encounteres a bad mbuf during transmit. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_stats.c | 7 drivers/net/bnxt/bnxt_txq.h | 1 + drivers/net/bnxt/bnxt_txr.c | 64 +-- 3 files changed, 54 insertions(+), 18 deletions

[PATCH 05/13] net/bnxt: add check for invalid mbuf passed by application

2024-10-25 Thread Ajit Khaparde
From: Kalesh AP If the application passes invalid mbuf for a Tx pkt, this could escape all the existing driver checks and driver could end up sending down invalid TX BDs to the HW. This in turn could lead to a FW reset. Fix by validating the "mbuf->buf_iova" or "mbuf->buf_addr" passed for the Tx

[PATCH 04/13] net/bnxt: add check for number of segs

2024-10-25 Thread Ajit Khaparde
pipeline stall. Fix it by validating the number of segs passed for the Tx pkt against what is actually set by the application to prevent this. Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH 03/13] net/bnxt: add check to validate TSO segment size

2024-10-25 Thread Ajit Khaparde
requested in the MBUF flags. Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_txr.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt

[PATCH 00/13] patchset for bnxt PMD

2024-10-25 Thread Ajit Khaparde
This patchset contains changes to the BNXT PMD. Some of them are fixes. Please accept and apply. Ajit Khaparde (6): net/bnxt: fix TCP and UDP checksum flags net/bnxt: free and account a bad Tx mbuf net/bnxt: fix LRO offload capability net/bnxt: remove some unnecessary logs net/bnxt: add

[PATCH 02/13] net/bnxt: fix bad action offset in Tx bd

2024-10-25 Thread Ajit Khaparde
;) Cc: sta...@dpdk.org Signed-off-by: Peter Spreadborough Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index

[PATCH 01/13] net/bnxt: fix TCP and UDP checksum flags

2024-10-25 Thread Ajit Khaparde
Set TCP and UDP checksum flags explicitly for LSO capable packets. In some older chip variants, this will enable the hardware compute the checksum correctly for tunnel and non-tunnel packets. Fixes: 1d76c878b21d ("net/bnxt: support updating IPID") Cc: sta...@dpdk.org Signed-off-by: Aji

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-24 Thread Ajit Khaparde
On Thu, Oct 24, 2024 at 12:30 PM Alexander Kozyrev wrote: > > >>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support. > >Isn't this already taken care when mbuf->packet_type = > >(RTE_PTYPE_L4_UDP | RTE_PTYPE_TUNNEL_ESP) ? > > This is ambigous. And both UDP and ESP are L4 headers

Re: [PATCH v6 00/47] TruFlow update for Thor2

2024-10-23 Thread Ajit Khaparde
On Mon, Oct 21, 2024 at 1:14 AM Sriharsha Basavapatna wrote: > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > TruFlow(TF) is the software library that exposes CFA HW resources to > upper layer protocols or applications. This patch series implements the > tfc (tf_c

Re: [PATCH v2] net/bnxt: fix issue reading sff8436 sfp eeproms

2024-10-23 Thread Ajit Khaparde
since the > length of these eeproms is 512 bytes but we are > only ever selecting 2 pages (256 bytes) to read. > > Signed-off-by: Peter Morrow Reviewed-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm for-next-net branch. > --- > Corrected sob email address. > > d

Re: [PATCH v10] examples/ptp: replace terms master and slave

2024-10-23 Thread Ajit Khaparde
On Tue, Oct 22, 2024 at 10:26 AM Ajit Khaparde wrote: > > On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger > wrote: > > > > On Fri, 14 Jun 2024 08:41:07 -0700 > > Stephen Hemminger wrote: > > > > > Remove one of the few remaining uses of master/sla

Re: [PATCH v4 21/42] net/bnxt: use rte strerror

2024-10-23 Thread Ajit Khaparde
by: Morten Brørup Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_stats.c | 2 +- > drivers/net/bnxt/rte_pmd_bnxt.c | 26 +- > drivers/net/bnxt/tf_core/tf_core.c| 240 +- > drivers/net/bnxt/tf_core/tf_em_commo

Re: [PATCH v6 12/47] net/bnxt: tf_ulp: add vxlan-gpe base support

2024-10-22 Thread Ajit Khaparde
pe base support > > > net/bnxt: tf_ulp: add custom l2 etype tunnel support > > > net/bnxt: tf_ulp: add support for vf to vf flow offload > > > net/bnxt: tf_ulp: support Wh+ mirroring > > > net/bnxt: tf_ulp: miscellaneous fixes > > > > > > Si

Re: [PATCH v10] examples/ptp: replace terms master and slave

2024-10-22 Thread Ajit Khaparde
On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger wrote: > > On Fri, 14 Jun 2024 08:41:07 -0700 > Stephen Hemminger wrote: > > > Remove one of the few remaining uses of master/slave. > > > > The IEEE 1588 standard has been updated to remove the use > > of master-slave terminology. Change the samp

Re: [PATCH] net/bnxt: fix newline character in speed display

2024-10-04 Thread Ajit Khaparde
: support async link notification") > Cc: sta...@dpdk.org > Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/dr

Re: [PATCH v6 17/17] eal: add function attributes for allocation functions

2024-10-02 Thread Ajit Khaparde
fs.h. > > Note: The rte_free function prototype was moved ahead of the allocation > > functions since the dealloc attribute now refers to it. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Chengwen Feng > > Acked-by: Anatoly Burakov > > Acked-by: Wathsala Vithanage Acked-by: Ajit Khaparde smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v4 02/17] cryptodev/bcmfs: fix mis-matched free

2024-09-30 Thread Ajit Khaparde
e BCMFS driver") > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > --- > drivers/crypto/bcmfs/bcmfs_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/bcmfs/bcmfs_device.c > b/drivers/

Re: [PATCH] MAINTAINERS: remove Raveendra Padasalagi

2024-09-29 Thread Ajit Khaparde
On Sat, Sep 28, 2024 at 12:18 PM Thomas Monjalon wrote: > > Cc Ajit for ack > > > 28/09/2024 18:53, Stephen Hemminger: > > This email address is bouncing remove from MAINTAINERS. > > > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > > --- >

Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

2024-09-27 Thread Ajit Khaparde
> > Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v6 1/2] ethdev: Add link_speed lanes support

2024-09-27 Thread Ajit Khaparde
> > > > * Infos for port 0 * > > MAC address: 14:23:F2:C3:BA:D2 > > Device name: :b1:00.0 > > Driver name: net_bnxt > > Firmware-version: 228.9.115.0 > > Connect to socket: 2 > > memory allocation on the socket:

Re: [PATCH 00/47] TruFlow update for Thor2

2024-09-25 Thread Ajit Khaparde
On Fri, Aug 30, 2024 at 9:51 AM Sriharsha Basavapatna wrote: > > Update TruFlow to support the Thor2 device. Patchset applied to the dpdk-next-net-brcm branch. Thanks > > Farah Smith (2): > net/bnxt: tf_core: Thor TF EM key size check > net/bnxt: tfc: support tf-core for Thor2 > > Jay Ding (

[PATCH 2/2] gpu/cuda: extend cuda code to get PA of GPU

2024-09-05 Thread Ajit Khaparde
Add code to get the physical address of the GPU memory. This should allow some NIC hardware to directly use the physical address for DMA instead of the CUDA Unified Memory provided by cuda_mem_map. Signed-off-by: Ajit Khaparde --- drivers/gpu/cuda/common.h | 2 + drivers/gpu/cuda/cuda.c

[PATCH 1/2] gpudev: add API to get GPU physical address

2024-09-05 Thread Ajit Khaparde
Add API to get the physical address of the peer GPU. This should allow some NIC hardware to directly use the physical address for DMA instead of the CUDA Unified Memory provided by rte_gpu_mem_map. Signed-off-by: Ajit Khaparde --- lib/gpudev/gpudev.c| 61

[PATCH 0/2] add API to get GPU physical address

2024-09-05 Thread Ajit Khaparde
open here. https://github.com/NVIDIA/gdrcopy/pull/304 Please review. Thanks Ajit Khaparde (2): gpudev: add API to get GPU physical address gpu/cuda: extend cuda code to get PA of GPU drivers/gpu/cuda/common.h | 2 + drivers/gpu/cuda/cuda.c| 117

Re: [V1] doc: announce deprecation of flow item VXLAN-GPE

2024-07-29 Thread Ajit Khaparde
; + and the header struct ``rte_vxlan_gpe_hdr`` with the macro > > > ``RTE_ETHER_VXLAN_GPE_HLEN`` > > > + will be removed in DPDK 25.11. > > > > Acked-by: Ferruh Yigit > > Acked-by: Thomas Monjalon Acked-by: Ajit Khaparde > > smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-07-08 Thread Ajit Khaparde
socket: 2 > memory allocation on the socket: 2 > Link status: up > Link speed: 200 Gbps > Active Lanes: 4 > Link duplex: full-duplex > Autoneg status: Off > > Signed-off-by: Damodharam Ammepalli Acked-by: Ajit Khaparde smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 0/3] bnxt bug fixes

2024-06-07 Thread Ajit Khaparde
On Thu, Jun 6, 2024 at 4:31 PM Ajit Khaparde wrote: > > Some bug fixes for the bnxt PMD. > Please apply. Patchset merged into dpdk-next-net-brcm. > > Ajit Khaparde (2): > net/bnxt: fix vector mode for P7 devices > net/bnxt: fix backing store logging > > Damodharam

[PATCH 3/3] net/bnxt: fix backing store logging

2024-06-06 Thread Ajit Khaparde
;) Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_hwrm.c | 48 1 file changed, 5 insertions(+), 43 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index

[PATCH 2/3] net/bnxt: refactor backing store qcaps v2

2024-06-06 Thread Ajit Khaparde
has valid types to return if queried. Fixes: fe2f715ca580 ("net/bnxt: support backing store v2") Cc: sta...@dpdk.org Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 16 1 file changed, 12 insertions(+), 4 deletions(-)

[PATCH 1/3] net/bnxt: fix vector mode for P7 devices

2024-06-06 Thread Ajit Khaparde
Fix vector code to update the producer index correctly especially for P7 devices where the code needs to handle epoch bit indication correctly to the hardware. Fixes: 30656a1cace8 ("net/bnxt: refactor epoch setting") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- driver

[PATCH 0/3] bnxt bug fixes

2024-06-06 Thread Ajit Khaparde
Some bug fixes for the bnxt PMD. Please apply. Ajit Khaparde (2): net/bnxt: fix vector mode for P7 devices net/bnxt: fix backing store logging Damodharam Ammepalli (1): net/bnxt: refactor backing store qcaps v2 drivers/net/bnxt/bnxt_hwrm.c| 64

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Ajit Khaparde
On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde wrote: > > On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > > 26/03/2024 02:42, lihuisong (C): > > >> 在 2024/3/25 17:30, Thomas Monjal

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Ajit Khaparde
On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > 26/03/2024 02:42, lihuisong (C): > >> 在 2024/3/25 17:30, Thomas Monjalon 写道: > >>> 25/03/2024 07:24, huangdengdui: > On 2024/3/22 21:58, Thomas Monjalon wrote: > > 22/03/2024 08:09, Dengd

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-25 Thread Ajit Khaparde
On Mon, Mar 25, 2024 at 6:42 PM lihuisong (C) wrote: > > > 在 2024/3/25 17:30, Thomas Monjalon 写道: > > 25/03/2024 07:24, huangdengdui: > >> On 2024/3/22 21:58, Thomas Monjalon wrote: > >>> 22/03/2024 08:09, Dengdui Huang: > -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps */ > >>

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-22 Thread Ajit Khaparde
On Fri, Mar 22, 2024 at 6:58 AM Thomas Monjalon wrote: > > 22/03/2024 08:09, Dengdui Huang: > > -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps */ > > -#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9) /**< 20 Gbps */ > > -#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps

Re: [PATCH 0/3] support setting lanes

2024-03-21 Thread Ajit Khaparde
On Thu, Mar 21, 2024 at 9:39 PM Jerin Jacob wrote: > > On Fri, Mar 22, 2024 at 7:58 AM huangdengdui wrote: > > > > > > > > On 2024/3/21 16:28, Thomas Monjalon wrote: > > > 21/03/2024 03:02, huangdengdui: > > >> > > >> On 2024/3/20 20:31, Ferruh Yigit wrote: > > >>> On 3/18/2024 9:26 PM, Damodhara

Re: [PATCH 0/3] support setting lanes

2024-03-18 Thread Ajit Khaparde
On Mon, Mar 18, 2024 at 2:42 PM Stephen Hemminger wrote: > > On Mon, 18 Mar 2024 14:26:33 -0700 > Damodharam Ammepalli wrote: > > > On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote: > > > > > > 12/03/2024 08:52, Dengdui Huang: > > > > Some speeds can be achieved with different number of lan

Re: [PATCH 0/2] bnxt fixes

2024-03-16 Thread Ajit Khaparde
On Fri, Mar 15, 2024 at 9:11 PM Ajit Khaparde wrote: > > Fixes to the bnxt driver. Please apply. Patches merged in dpdk-next-net-brcm. Thanks > > Ajit Khaparde (1): > net/bnxt: fix init failures > > Kishore Padmanabha (1): > net/bnxt: fix number of Tx queues being

[PATCH 2/2] net/bnxt: fix init failures

2024-03-15 Thread Ajit Khaparde
Fix init failures in some cases when contiguous memory may not be available for cases when a larger chunk of memory may be needed. Fixes: fe2f715ca580 ("net/bnxt: support backing store v2") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 ++ drivers/net/bnxt/b

  1   2   3   4   5   6   7   8   9   10   >