Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Ahmed Mansour
;> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Wednesday, March 14, 2018 12:51 PM >> To: Trahe, Fiona ; Ahmed Mansour >> ; dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; Athreya, >> Narayana Prasad >> ; Gupta, Ashish

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-06 Thread Ahmed Mansour
On 3/5/2018 9:32 AM, Verma, Shally wrote: > >> -Original Message- >> From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >> Sent: 03 March 2018 01:19 >> To: Trahe, Fiona ; Verma, Shally >> ; dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; Athreya, >&

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
ow many qps it intends to use - > typically one per thread, must be < device max > - qp_setup() - called per qp. Creates the qp based on the size indicated by > max_inflights > - dev_start() - once started device can't be reconfigured, must call > dev_stop to reconfigu

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
On 3/2/2018 4:53 AM, Trahe, Fiona wrote: > >> On 3/1/2018 9:41 AM, Trahe, Fiona wrote: >>> Hi Shally >>> >>> //snip// [Shally] This looks better to me. So it mean app would always call xform_init() for stateless and attach >> an updated priv_xform to ops (depending upon if there's s

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-01 Thread Ahmed Mansour
On 3/1/2018 9:41 AM, Trahe, Fiona wrote: > Hi Shally > > //snip// >> [Shally] This looks better to me. So it mean app would always call >> xform_init() for stateless and attach an >> updated priv_xform to ops (depending upon if there's shareable or not). So >> it does not need to have >> NULL poi

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Ahmed Mansour
> Hi Fiona, Ahmed >> Hi Fiona, >> >> Thanks for starting this discussion. In the current API the user must >> make 12 API calls just to get information to compress. Maybe there is a >> way to simplify. At least for some use cases (stateless). I think a call >> sometime next week would be good to he

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-26 Thread Ahmed Mansour
>> Hi Fiona, >> >> Thanks for starting this discussion. In the current API the user must >> make 12 API calls just to get information to compress. Maybe there is a >> way to simplify. At least for some use cases (stateless). I think a call >> sometime next week would be good to help clarify coalesc

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-23 Thread Ahmed Mansour
Hi Fiona, Thanks for starting this discussion. In the current API the user must make 12 API calls just to get information to compress. Maybe there is a way to simplify. At least for some use cases (stateless). I think a call sometime next week would be good to help clarify coalesce some of the com

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-22 Thread Ahmed Mansour
On 2/21/2018 11:47 PM, Verma, Shally wrote: > >> -Original Message- >> From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >> Sent: 22 February 2018 01:06 >> To: Trahe, Fiona ; Verma, Shally >> ; dev@dpdk.org >> Cc: Athreya, Narayana Prasad ; Gupta,

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-21 Thread Ahmed Mansour
On 2/21/2018 9:35 AM, Trahe, Fiona wrote: > Hi Ahmed, Shally, > > >> -Original Message- >> From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >> Sent: Tuesday, February 20, 2018 7:56 PM >> To: Verma, Shally ; Trahe, Fiona >> ; dev@dpdk.org

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-20 Thread Ahmed Mansour
/// snip /// >>> D.2.1 Stateful operation state maintenance >>> --- >>> It is always an ideal expectation from application that it >>> should parse >> through all related chunk o

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-16 Thread Ahmed Mansour
>> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Friday, February 16, 2018 7:17 AM >> To: Ahmed Mansour ; Trahe, Fiona >> ; >> dev@dpdk.org >> Cc: Athreya, Narayana Prasad ; Gupta, >> Ashish >>

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Ahmed Mansour
On 2/15/2018 1:47 PM, Trahe, Fiona wrote: > Hi Shally, Ahmed, > Sorry for the delay in replying, > Comments below > >> -Original Message- >> From: Verma, Shally [mailto:shally.ve...@cavium.com] >> Sent: Wednesday, February 14, 2018 7:41 AM >> To: Ahmed

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-15 Thread Ahmed Mansour
/// snip /// > [Fiona] I propose if BFINAL bit is detected before end of input the decompression should stop. In this case consumed will be < src.length. produced will be < dst buffer size. Do we need an extra STATUS response? STATUS_BFINA

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-14 Thread Ahmed Mansour
On 2/14/2018 12:41 AM, Verma, Shally wrote: > Hi Ahmed > >> -Original Message----- >> From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] >> Sent: 02 February 2018 02:20 >> To: Trahe, Fiona ; Verma, Shally >> ; dev@dpdk.org >> Cc: Athreya, Narayana

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-01 Thread Ahmed Mansour
>>> [Fiona] I propose if BFINAL bit is detected before end of input >>> the decompression should stop. In this case consumed will be < src.length. >>> produced will be < dst buffer size. Do we need an extra STATUS response? >>> STATUS_BFINAL_DETECTED ? >> [Shally] @fiona, I assume you mean here de

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-01 Thread Ahmed Mansour
On 1/31/2018 2:03 PM, Trahe, Fiona wrote: > Hi Ahmed, Shally, > > ///snip/// >>> D.1.1 Stateless and OUT_OF_SPACE >>> >>> OUT_OF_SPACE is a condition when output buffer runs out of space and >> where PMD still has more data to pr

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-29 Thread Ahmed Mansour
On 1/29/2018 7:26 AM, Verma, Shally wrote: > Hi > >> -Original Message- >> From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >> Sent: 26 January 2018 00:13 >> To: Verma, Shally ; Ahmed Mansour >> ; dev@dpdk.org; Akhil Goyal >> >> Cc: Challa,

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-25 Thread Ahmed Mansour
Hi All, Sorry for the delay. Please see responses inline. Ahmed On 1/12/2018 8:50 AM, Verma, Shally wrote: > Hi Fiona > >> -Original Message- >> From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >> Sent: 12 January 2018 00:24 >> To: Verma, Shally ; Ahmed M

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-24 Thread Ahmed Mansour
; >> akhil.go...@nxp.com >> Cc: Challa, Mahipal ; Athreya, Narayana >> Prasad ; De Lara Guarch, Pablo >> ; Gupta, Ashish >> ; Sahu, Sunila ; >> Jain, Deepak K ; Hemant Agrawal >> ; Roy Pledge ; Youri >> Querry ; Ahmed Mansour >> ; Trahe, Fiona >>

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-01-09 Thread Ahmed Mansour
Hi Shally, Thanks for the summary. It is very helpful. Please see comments below On 1/4/2018 6:45 AM, Verma, Shally wrote: > This is an RFC v2 document to brief understanding and requirements on > compression API proposal in DPDK. It is based on "[RFC v3] Compression API in > DPDK > https://e

Re: [dpdk-dev] [RFC v3 0/1] Compression API in DPDK

2018-01-09 Thread Ahmed Mansour
Hi Fiona, Thanks for your response. I added comments inline On 12/22/2017 8:44 AM, Trahe, Fiona wrote: > Hi Ahmed, > thanks for your feedback and sorry for the slow response. > Comments below. > >> -Original Message----- >> From: Ahmed Mansour [mailto:ahmed.mans...@

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2017-12-18 Thread Ahmed Mansour
On 12/15/2017 11:19 PM, Trahe, Fiona wrote: .. > + > +/** Compression Algorithms */ > +enum rte_comp_algorithm { > + RTE_COMP_NULL = 0, > + /**< No compression. > + * Pass-through, data is copied unchanged from source buffer to > + * destination buffer. > + */ > + RTE_C

Re: [dpdk-dev] [RFC v3 0/1] Compression API in DPDK

2017-12-18 Thread Ahmed Mansour
Hi Fiona, On 12/15/2017 11:16 PM, Trahe, Fiona wrote: > With the vast amounts of data being transported around networks and stored in > storage systems, reducing data size is becoming ever more important. There > are both software libraries and hardware devices available that provide > compressio