Re: Polling for patchseries in DPDK - the /series/ and /events/ endpoints

2025-07-11 Thread Aaron Conole
Adam Hassick writes: > Hi All, > > It appears that there already is a filter for projects for events, but > the filter is configured to be hidden from the HTML view for some > reason. We don't need to make any code changes to enable this feature. > See here: > https://github.com/getpatchwork/pat

Re: [PATCH v3 10/18] build: support Undefined Behavior Sanitizer

2025-07-11 Thread Aaron Conole
s a number > of build issues. It's probably okay for many of the issues because we have other builds in github that should enable the code path analysis. Maybe someday in the future we can get this with UBSan as well. > Signed-off-by: David Marchand > --- Acked-by: Aaron Cono

Re: Proposal: AI-Based Code Review for DPDK

2025-07-09 Thread Aaron Conole
Aaron Conole writes: > Jerin Jacob writes: > >> On Thu, Jun 19, 2025 at 7:42 PM Ori Kam wrote: >>> >>> >>> Nice idea, >>> Some comments: >>> >>> >>> 1. The first link is broken for me. >> >> Yes. https://g

Re: [PATCH v2] ci: check C++ headers with clang

2025-07-07 Thread Aaron Conole
- moved CXX tweaking in the branch enabling headers check, > Not sure why we got a segfault with this in IOL: 36/120 DPDK:fast-tests / eal_flags_misc_autotestFAIL 3.78s killed by signal 11 SIGSEGV I don't think it is related. Acked-by: Aaron Conole

Re: Proposal: AI-Based Code Review for DPDK

2025-07-02 Thread Aaron Conole
ents associated with the specific hunks and reply to the patch (and all the folks CC'd) with the comments. At the very least, we can send the pull request URL and reply with that. > Good input. > > > Adding @Aaron Conole . He has some plans to implement this workflow.

Re: [PATCH 10/10] build: support Undefined Behavior Sanitizer

2025-06-25 Thread Aaron Conole
s a number > of build issues. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole > .ci/linux-build.sh | 27 +-- > .github/workflows/build.yml | 5 + > app/test/suites/meson.build | 3 +-- > config/meson.build | 18 ++

Re: [PATCH 01/10] ci: save ccache on failure

2025-06-25 Thread Aaron Conole
David Marchand writes: > When troubleshooting unit test failures and repeating jobs in GHA, > the absence of ccache makes the whole process way slower. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole > .github/workflows/build.yml | 6 ++ > 1 file

Re: [PATCH 1/2] ci: treat warning as error for MSVC builds in GHA

2025-06-12 Thread Aaron Conole
David Marchand writes: > Some trivial builds warnings with MSVC were missed as those were not > treated as errors. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole > .github/workflows/build.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: Polling for patchseries in DPDK - the /series/ and /events/ endpoints

2025-05-06 Thread Aaron Conole
Patrick Robb writes: > There was some discussion at last week's CI meeting about usage of the > Patchwork > /events/ endpoint for polling for patches, and issues with that process. Here > is a relevant > blurb, explaining some issues Aaron has run into using the dpdk-ci repo > "poll-pw.sh" she

[NOTICE] Github Robot: Missing Reports

2025-04-22 Thread Aaron Conole
Greetings, Last week on April 16th, there was a disruption with the credentials for the github robot's email reporting. Patches were submitted to github, but the emails that were supposed to report status did not get sent out. The issue has been resolved as of April 22nd. If you see a series wi

[PATCH] doc: Document frequency and volume limits on patches.

2025-04-17 Thread Aaron Conole
more time for reviews, and also encourage developers to spend a bit more time to put their submissions in a 'default accept' condition. Signed-off-by: Aaron Conole --- RFC->v1: Incorporate feedback from Thomas. doc/guides/contributing/patches.rst | 43

Re: [PATCH] ci: check licenses

2025-04-14 Thread Aaron Conole
David Marchand writes: > Call check-spdx.tag.sh so that all committed files are checked. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH v6 6/8] build: use dynamically generated version maps

2025-03-28 Thread Aaron Conole
way, my previous note still applies. Acked-by: Aaron Conole > .github/workflows/build.yml | 1 - > MAINTAINERS | 7 - > buildtools/check-symbols.sh | 33 +- > buildtools/map-list-symbol.sh |

Re: [PATCH v5 6/8] build: use dynamically generated version maps

2025-03-28 Thread Aaron Conole
ow. Otherwise, Acked-by: Aaron Conole > .github/workflows/build.yml | 1 - > MAINTAINERS | 7 - > buildtools/check-symbols.sh | 33 +- > buildtools/map-list-symbol.sh |

Re: [PATCH] ci: point at GitHub mirror.

2025-03-05 Thread Aaron Conole
to say we can use the ``GITHUB_REPOSITORY`` variable, but the problem with that is that it will pull references to the local users repo instead. I guess there isn't actually a good reference to a 'source of truth' that is predefined. Acked-by: Aaron Conole > .github/workflows/build.yml | 2

[RFC] doc: Document frequency and volume limits on patches.

2025-03-04 Thread Aaron Conole
more time for reviews, and also encourage developers to spend a bit more time to put their submissions in a 'default accept' condition. Signed-off-by: Aaron Conole --- NOTE: This is a discussion item from the techboard and I'm submitting as RFC first to gather feedb

Re: [PATCH] ci: build with MSVC in GHA

2025-02-18 Thread Aaron Conole
David Marchand writes: > On Tue, Feb 18, 2025 at 2:32 PM Aaron Conole wrote: >> >> David Marchand writes: >> >> > Add a build target in Windows 2022 for MSVC. >> > >> > Loading MSVC environment and having successive commands in a single >

Re: [PATCH] ci: build with MSVC in GHA

2025-02-18 Thread Aaron Conole
mmands in separate shells. > > Signed-off-by: David Marchand > --- LGTM. Acked-by: Aaron Conole How far back will this work (ie: can we backport this to older branches?) > .github/workflows/build.yml | 38 + > 1 file changed, 38 insertions(+) &

Re: [RFC] ci: Add support for Cirrus-CI service to test FreeBSD.

2025-02-05 Thread Aaron Conole
Patrick Robb writes: > On Tue, Feb 4, 2025 at 11:07 AM Aaron Conole wrote: > > This commit adds preliminary support for developer driven FreeBSD testing > via the Cirrus-CI cloud continuous integration system. > > NOTE: Currently, this does not successfully execute.

[RFC] ci: Add support for Cirrus-CI service to test FreeBSD.

2025-02-04 Thread Aaron Conole
-ci.com/v1/task/5626189961756672/logs/check.log The tests themselves may need to be run as root. Signed-off-by: Aaron Conole --- .ci/freebsd-build.sh | 5 + .ci/freebsd-setup.sh | 3 +++ .cirrus.yml | 33 + MAINTAINERS | 1 + 4 files changed

Re: [PATCH v4 7/9] test/eal: fix core check in c flag test

2024-11-26 Thread Aaron Conole
> Cc: msant...@redhat.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson > --- Acked-by: Aaron Conole > app/test/test_eal_flags.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/te

Re: [PATCH v2 2/2] ci: install libvirt

2024-11-14 Thread Aaron Conole
David Marchand writes: > Install libvirt so that vm_power_manager example compilation is tested. > > Signed-off-by: David Marchand > --- LGTM Acked-by: Aaron Conole > .github/workflows/build.yml | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > &

Tech Board Meeting Minutes - Sept. 23, 2024

2024-10-24 Thread Aaron Conole
Attendees - Aaron Conole Bruce Richardson David Marchand Hemant Agrawal Honnappa Nagarahalli Kevin Traynor Konstantin Ananyev Maxime Coquelin Morten Brorup Robin Jarry Stephen Hemminger Thomas Monjalon Notes - The Tech Board met at a f2f session in Montreal, prior to the DPDK

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Aaron Conole
Patrick Robb writes: > Haha... I guess that serves as a lesson. > > Thanks Bruce. Probably worth it to try that patch out and add your tested-by tag :)

Re: Depends-on

2024-06-03 Thread Aaron Conole
On Wed, May 29, 2024 at 10:40 AM Morten Brørup > wrote: > > > From: Aaron Conole [mailto:acon...@redhat.com] > > Sent: Wednesday, 29 May 2024 16.34 > > > > > I'll try to spend some time and add patch based support, but I think > > there was some w

Re: Depends-on

2024-05-29 Thread Aaron Conole
Morten Brørup writes: > Aaron, > > I have been trying to submit a patch with a dependency on another > patch, but it keeps failing, and the error message "Apply patch set > 140352 failed: 404 Not Found" isn't very helpful. > > Could you please take a look at it and let me know what's going on: >

Re: [PATCH v12 07/12] net/tap: use libbpf to load new BPF program

2024-05-21 Thread Aaron Conole
Ferruh Yigit writes: > On 5/21/2024 5:23 AM, Patrick Robb wrote: >> On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote: >>> >>> @Patric, I assume test environment also doesn't have 'libbpf', version: >>> '>= 1.0' which we need to test this feature. >>> Is it possible to update test environment t

Minutes of Technical Board meeting 17-April-2024

2024-05-03 Thread Aaron Conole
Next Meeting will be May 15th, with Bruce as chair. Attendees - - Aaron (chair) - Morten Brorup - David Marchand - Konstantin Ananyev - Tyler Retzlaff - Mykola Kostenok - Paul Szczepanik - Kevin Traynor - Jerin Jacob Kollanukkaran - Nathan Southern - Patrick Robb - Stephen Hemminger - Bruc

Re: [PATCH 15/46] net/sfc: use rte stdatomic API

2024-03-21 Thread Aaron Conole
Tyler Retzlaff writes: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional rte stdatomic API. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/sfc/meson.build | 5 ++--- > drivers/net/sfc/sfc_mae_counter.c | 30 +++---

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-03-19 Thread Aaron Conole
Patrick Robb writes: > On Tue, Mar 19, 2024 at 4:37 AM zhoumin wrote: >> >> >> One more thing I want to confirm is whether we should apply the patch >> onto the branch commit which existed at the time when that patch was >> submitted or onto the latest tip of branch if users request doing >> reb

[PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

2024-03-12 Thread Aaron Conole
://reviews.llvm.org/D148280 But these are not available in Ubuntu 22.04 image. This should be fixed by GitHub, but until new images are available reducing ASLR entropy manually to 28 bits to make builds work. Reported-at: https://github.com/actions/runner-images/issues/9491 Signed-off-by: Aaron Conole

Re: [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

2024-03-12 Thread Aaron Conole
ut these are not available in Ubuntu 22.04 image. > > This should be fixed by GitHub, but until new images are available > reducing ASLR entropy manually to 28 bits to make builds work. > > Reported-at: https://github.com/actions/runner-images/issues/9491 > Signed-off-by: Ilya Maximets >

Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-08 Thread Aaron Conole
"Power, Ciara" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole >> Sent: Wednesday, March 6, 2024 2:57 PM >> To: Power, Ciara >> Cc: Sivaramakrishnan, VenkatX ; Akhil >> Goyal ; Ji, Kai ; pr...@iol.unh.edu; >>

Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Aaron Conole
"Power, Ciara" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole >> Sent: Tuesday, March 5, 2024 6:37 PM >> To: Power, Ciara >> Cc: Sivaramakrishnan, VenkatX ; Akhil >> Goyal ; Ji, Kai ; pr...@iol.unh.edu; >>

Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-05 Thread Aaron Conole
"Power, Ciara" writes: > + Patrick > > > > From: Power, Ciara > Sent: Tuesday, March 5, 2024 10:05 AM > To: Sivaramakrishnan, VenkatX ; Akhil > Goyal > Cc: Ji, Kai ; Aaron Conole > Subject: RE: reg. https://patches.dpdk.org/project/dpdk/list/?ser

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-03-04 Thread Aaron Conole
zhoumin writes: > On Wed, Feb 21, 2024 at 2:24AM, Patrick Robb wrote: > > On Tue, Feb 20, 2024 at 1:12 PM Aaron Conole wrote: > > Why not something like: > > Recheck-request: [attribute-list],[test-list]... > > For example, then we can do: > > Re

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-02-20 Thread Aaron Conole
Patrick Robb writes: > Hi all, > > I want to poll the CI group and dev community about a proposed feature > addition to the CI retest request framework. > Currently, you can respond to a patchseries or patch email, requesting a > retest like so: > > Recheck-request: iol-compile-amd64-testing, i

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Aaron Conole
Ferruh Yigit writes: > On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: >> When rte_log.h was moved to a new directory, the include path was not >> updated for the generated C code produced by the pipeline library, >> which results in build failure for this code. >> >> Fixes: 09ce41310930 ("log:

Re: [PATCH 2/2] ci: update versions of actions in GHA

2024-02-08 Thread Aaron Conole
ng-from-node-16-to-node-20/ > > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH 1/2] ci: bump tested distributions in GHA

2024-02-08 Thread Aaron Conole
> Install additional dependencies like ipsec-mb, isal and other > libbpf/libxdp devel packages. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Aaron Conole
Morten Brørup writes: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, 10 January 2024 17.58 >> >> The last version of 4.14 kernel was just released (4.14.336), >> and it is now end of life. Update the DPDK kernel minimum version >> to the next LTS kernel versio

[CI] Github Robot - Recheck support

2023-12-14 Thread Aaron Conole
Greetings DPDK Developers, The UNH IOL, and the DPDK CI community at large, have developed a mechanism to request a test recheck for failures. This allows patch authors or maintainers who suspect that a failing test is really a byproduct of something unrelated (flaky test, network issue, etc) to

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Dec 13, 2023 at 11:50:46AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > We only need to consult the timer value when the driver waits for a >> > timeout, so skip making the call to get the current timer/TSC

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Had a bad config value - retryin

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Recheck-request: github-robot

Tech Board Meeting Minutes, Nov-01, 2023

2023-12-01 Thread Aaron Conole
* Attendees ** Nathan Southern ** Thomas Monjalon ** Honnappa Nagarahalli ** Kevin Traynor ** Hemant Agrawal ** Jerin Jacob Kollanukkaran ** Ben Thomas ** Patrick Robb ** Lincoln Lavoie * Agenda ** UNH Retrospective *** Patrick presented the retrospective at https://docs.google.com/document/

Re: [PATCH v5 3/9] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
ne for other paths e.g. the > PKG_CONFIG_PATH variable. > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Aaron Conole

Re: [PATCH] ci: test manuals generation in GHA

2023-10-17 Thread Aaron Conole
David Marchand writes: > Add missing package so manuals are generated as part of the docs check. > > Signed-off-by: David Marchand > --- Good catch! Reviewed-by: Aaron Conole

Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
Bruce Richardson writes: > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > from within the makefiles of our examples, we need to export the PATH > variable with the location of our installed scripts from within our CI > scripts. This matches what is already done for other p

[PATCH v2] common/mlx5: Optimize mlx5 mempool get extmem

2023-10-10 Thread Aaron Conole
From: John Romein This patch reduces the time to allocate and register tens of gigabytes of GPU memory from hours to seconds, by sorting the heap only once instead of for each object in the mempool. Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") Signed-off-by: John Rom

Re: [PATCH v4] app/test: add support for skipping tests

2023-10-04 Thread Aaron Conole
Patrick Robb writes: > Thanks, this should help greatly going forward in the community lab. > > As it relates to our arm64 unit testing, I will give it a few days (or longer > if needed) for next branches to rebase off of > main and then re-enable arm64 unit testing with the > eal_flags_file_pr

Minutes of Technical Board Meeting, 2023-05-31

2023-10-04 Thread Aaron Conole
Attendees: - Aaron - Bruce - David - Ferruh - Jerin - Kevin - Konstantin - Maxime - Nathan - Patrick - Stephen - Tyler Minutes: - Bruce will be moderator on June 14, 2023 - Call for additional items - Userspace Dublin - CFP - Ready to go. - Awaiting on final TB review, feedback received fr

Re: [PATCH] ci: test stdatomic API

2023-09-29 Thread Aaron Conole
David Marchand writes: > Add some compilation tests with C11 atomics enabled. > The headers check can't be enabled (as gcc and clang don't provide > stdatomic before C++23). > > Signed-off-by: David Marchand > --- Reviewed-by: Aaron Conole

Re: [PATCH 0/2] add checks for tests not in a suite

2023-09-27 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Sep 27, 2023 at 11:31:07AM +0200, David Marchand wrote: >> On Wed, Sep 27, 2023 at 10:27 AM Bruce Richardson >> wrote: >> > On Wed, Sep 27, 2023 at 08:30:05AM +0200, David Marchand wrote: >> > > On Tue, Sep 26,

[PATCH] common/mlx5: Optimize mlx5 mempool get extmem

2023-09-26 Thread Aaron Conole
From: John Romein This patch reduces the time to allocate and register tens of gigabytes of GPU memory from hours to seconds, by sorting the heap only once instead of for each object in the mempool. Fixes: 690b2a8 ("common/mlx5: add mempool registration facilities") Signed-off-by: John Romein

[PATCH] gpu/cuda: Add missing stdlib include

2023-09-26 Thread Aaron Conole
From: John Romein getenv needs stdlib.h to be included. Bugzilla ID: 1133 Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy") Signed-off-by: John Romein --- NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the mailing list. drivers/gpu/cuda/gdrcopy.c | 2 ++

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-26 Thread Aaron Conole
Bruce Richardson writes: > On Sat, Sep 23, 2023 at 10:21:04AM +0200, Thomas Monjalon wrote: >> 22/09/2023 15:23, Bruce Richardson: >> > On Fri, Sep 22, 2023 at 02:57:32PM +0200, Thomas Monjalon wrote: >> > > 20/09/2023 12:09, Bruce Richardson: >> > > > On Wed, Sep 20, 2023 at 12:00:08PM +0200, Da

Re: DPDK patch

2023-09-26 Thread Aaron Conole
John Romein writes: > Dear Elena, Aaron, Hi John, > I hope you had a nice time after the DPDK workshop. > > I was unable to solve the issues with our mailserver to submit a patch > with git sendmail.  So I created a pull request: > https://github.com/DPDK/dpdk/pull/69 > @Elena, could you plea

Re: [PATCH 0/2] add checks for tests not in a suite

2023-09-26 Thread Aaron Conole
David Marchand writes: > On Tue, Sep 19, 2023 at 10:36 AM Bruce Richardson > wrote: >> >> On Tue, Sep 19, 2023 at 10:29:07AM +0200, David Marchand wrote: >> > On Fri, Sep 15, 2023 at 1:52 PM Bruce Richardson >> > wrote: >> > > >> > > To help ensure that we don't have "orphaned" tests not in any

Re: [PATCH v4] app/test: add support for skipping tests

2023-09-25 Thread Aaron Conole
; Timeout:0 > > Signed-off-by: Bruce Richardson > Acked-by: Thomas Monjalon > > --- Acked-by: Aaron Conole

Re: [PATCH] gpu/cuda: Add missing stdlib include

2023-09-13 Thread Aaron Conole
John Romein writes: > getenv needs stdlib.h to be included. > > Bugzilla ID: 1133 > > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy") > Signed-off-by: John Romein > --- Hi John, Thanks so much for the contribution. It looks like the patch got corrupted by something. Please chec

Re: [RFC PATCH] app/test: add support for skipping tests

2023-08-29 Thread Aaron Conole
Bruce Richardson writes: > When called from automated tools, like meson test, it is often useful to > skip tests in a test suite, without having to alter the test build. To > do so, we add support for DPDK_TEST_SKIP environment variable, where one > can provide a comma-separated list of tests. Wh

Re: [PATCH] ci: fix race on container image name

2023-08-02 Thread Aaron Conole
ora:37-2023-08-02 > > Fix this by directly reusing the prepare job output. > > Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole The dangers of dates... :-)

Re: [PATCH v7 1/2] build: select deprecated libraries

2023-07-31 Thread Aaron Conole
ling optional libraries more > straightforward by taking the deprecated libraries out of the picture. > > Signed-off-by: David Marchand > Acked-by: Morten Brørup > Acked-by: Bruce Richardson > --- Acked-by: Aaron Conole

Re: [PATCH 1/3] version: 23.11-rc0

2023-07-31 Thread Aaron Conole
> > The telemetry and vhost libraries compat code is cleaned up in next > commits. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

[PATCH] test: eal: update base-virtaddr parameter test

2023-07-20 Thread Aaron Conole
dependent on both build and link time options. The simplest resolution is to just update the base virtaddr parameter to move the rte config location. Reported-by: Patrick Robb Suggested-by: Ajit Khaparde Signed-off-by: Aaron Conole --- app/test/test_eal_flags.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] Updated to dpdk20.11

2023-06-29 Thread Aaron Conole
Hi David, David Young writes: > --- Thanks for the contribution! Very happy to have someone working on the docs. Thanks for getting a patch to the mailing list. Just a few nits to address before the patch can get merged. Customarily, a change to each area will describe that in the subject -

Re: [PATCH v6 1/2] build: select deprecated libraries

2023-06-29 Thread Aaron Conole
David Marchand writes: > Rework deprecated libraries selection by introducing a new configuration > option. > > This breaks existing configurations that were relying on disable_libs='' > for enabling deprecated libraries. > On the other hand, it will make enabling optional libraries more > straig

Re: [PATCH v5 1/2] build: select deprecated libraries

2023-06-29 Thread Aaron Conole
David Marchand writes: > Rework deprecated libraries selection by introducing a new configuration > option. > > This breaks existing configurations that were relying on disable_libs='' > for enabling deprecated libraries. > On the other hand, it will make enabling optional libraries more > straig

Re: [PATCH] ci: fix libabigail cache in GHA

2023-06-20 Thread Aaron Conole
pile libabigail but it fails as > the packages used for building libabigail are missing. > > Add the version to the cache entry name to avoid this collision. > > Fixes: 443267090edc ("ci: enable v21 ABI checks") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH v2 4/4] ci: build examples externally

2023-06-16 Thread Aaron Conole
David Marchand writes: > Enhance our CI coverage by building examples against an installed DPDK. > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson > --- Acked-by: Aaron Conole

Re: [PATCH v3] build: announce requirement for C11

2023-05-19 Thread Aaron Conole
st > > V2: > - add requirement for stdatomics > - fix sphinx formatting > --- > doc/guides/rel_notes/deprecation.rst | 18 ++++++++++ > 1 file changed, 18 insertions(+) Acked-by: Aaron Conole Per the meeting, I guess we're still waiting on the patches that int

Re: [PATCH] ci: switch to Fedora 37

2023-04-21 Thread Aaron Conole
> > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole FYI, Fedora 38 also just got released. Perhaps that can be a candidate as well, but I didn't try it out.

Re: [PATCH v3 1/2] net/i40e: replace put function

2023-02-17 Thread Aaron Conole
Ferruh Yigit writes: > On 2/17/2023 7:52 AM, Morten Brørup wrote: >>> From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] >>> Sent: Friday, 17 February 2023 03.03 >>> >>> Hi Kamalakshitha, >>> From: Kamalakshitha Aligeri Sent: Tuesday, February 14, 2023 2:18 AM Integrated zero-co

Re: [PATCH v3 1/2] net/i40e: replace put function

2023-02-17 Thread Aaron Conole
Morten Brørup writes: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Friday, 17 February 2023 11.05 >> >> On 2/17/2023 7:52 AM, Morten Brørup wrote: >> >> From: Lu, Wenzhuo [mailto:wenzhuo...@intel.com] >> >> Sent: Friday, 17 February 2023 03.03 >> >> >> >> Hi Kamalakshitha, >> >>

Minutes of Technical Board Meeting, 2022-07-13

2023-01-16 Thread Aaron Conole
Members Attending: 6 * Aaron Conole (chair) * Hement Agarwal * Maxime Coquelin * Nathan Southern * Stephen Hemminger * Thomas Monjalon NOTE: The Technical Board meetings take place every second Wednesday on https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are

Re: [PATCH] ci: drop Travis configuration

2022-12-14 Thread Aaron Conole
nfiguration in our repository with > the argument that "if it is not tested, it is broken". > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH] devtools: update Meson setup command

2022-12-07 Thread Aaron Conole
Thomas Monjalon writes: > The command "meson build" causes a deprecation warning with meson 0.64: > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Aaron Conole

Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

2022-12-02 Thread Aaron Conole
y: David Marchand > Tested-by: Ferruh Yigit > Reviewed-by: Bruce Richardson > --- Acked-by: Aaron Conole

Re: [PATCH] ci: combine static and shared linking build tests

2022-10-20 Thread Aaron Conole
o saves overall time because we would need fewer runners. I think this is a good change. Acked-by: Aaron Conole

Re: rte_service unit test failing randomly

2022-10-06 Thread Aaron Conole
Morten Brørup writes: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Wednesday, 5 October 2022 23.34 >> >> On 2022-10-05 22:52, Thomas Monjalon wrote: >> > 05/10/2022 22:33, Mattias Rönnblom: >> >> On 2022-10-05 21:14, David Marchand wrote: >> >>> Hello, >> >>> >> >>>

Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-06 Thread Aaron Conole
Morten Brørup writes: > @Aaron, do you have any insights or comments to my curiosity below? Sorry, the perf tests from Feb to Oct should *generally* be comparable but keep in mind that they are based on different baseline versions of DPDK. Also, the perf tests are done as thresholds rather than

Re: [NOTICE] 0-day Robot offline for upgrades

2022-09-14 Thread Aaron Conole
David Marchand writes: > Hey Aaron, Michael, > > On Fri, Sep 9, 2022 at 5:34 PM Aaron Conole wrote: >> >> Greetings, >> >> This is to let you know that we are executing upgrades today for the open >> 0-day robot that we run for OVS and DPDK projects. We

Re: [RFC PATCH 0/1] Add support for code-coverage analysis

2022-09-14 Thread Aaron Conole
Felix Moessbauer writes: > This patch has been developed as part of the DPDK Userspace Summit Hackathon. > It provides a PoC for code-coverage analysis for the DPDK project. > > To generate the report, a developer simply follows the official > meson coverage workflow, described in [1]. > In doing

[NOTICE] 0-day Robot offline for upgrades

2022-09-09 Thread Aaron Conole
Greetings, This is to let you know that we are executing upgrades today for the open 0-day robot that we run for OVS and DPDK projects. We don't expect that the robot will be offline for a very long time, but just note that there will be some down time as we bring the systems back online. Upgrad

Re: [PATCH v2 2/2] app/test: invoke all telemetry commands

2022-07-29 Thread Aaron Conole
v, eventdev and rawdev devices are created > using dummy drivers. > > Output of the commands is not checked, the point of this test is mainly > to catch simple issues and leaks (when coupled with ASan in the CI). > > Signed-off-by: David Marchand > Acked-by: Chengwen Feng > --- Acked-by: Aaron Conole

Re: [PATCH 3/3] ci: use crossbuild-essential-riscv64 for compiling

2022-06-14 Thread Aaron Conole
use the full toolchain install > to enable the C++ test. > > Besides, the user's guide for RISC-V cross-compilation recommends the > use of crossbuild-essential-riscv64. > > Signed-off-by: Stanislaw Kardach > --- Acked-by: Aaron Conole

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-13 Thread Aaron Conole
Stanisław Kardach writes: > On Thu, 12 May 2022, 17:47 Aaron Conole, wrote: > > Stanislaw Kardach writes: > > > Checks cross-compilation using Ubuntu 20.04 x86. > > > > Signed-off-by: David Marchand > > Signed-off-by: Stanislaw Kardach > >

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-12 Thread Aaron Conole
Stanislaw Kardach writes: > Checks cross-compilation using Ubuntu 20.04 x86. > > Signed-off-by: David Marchand > Signed-off-by: Stanislaw Kardach > --- > .ci/linux-build.sh | 4 > .github/workflows/build.yml | 11 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) S

Re: [PATCH v2 2/2] ci: build some job with ASan

2022-05-10 Thread Aaron Conole
e_autotest in "ASan-safe" list of ut, This is great! Acked-by: Aaron Conole

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-29 Thread Aaron Conole
Honnappa Nagarahalli writes: > > >> >> On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole >> wrote: >> > > >> > > TBH, I did not test Travis by lack of interest (plus I don't want to >> > > be bothered with their ui / credit st

Re: [PATCH 2/2] ci: add mingw cross compilation in GHA

2022-04-26 Thread Aaron Conole
> > Only the helloworld example is compiled (same as what is tested in > test-meson-builds.sh). > > Note: the mingw cross compilation toolchain (version 5.0) in Ubuntu > 18.04 was broken (missing a ENOMSG definition). > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [PATCH 1/2] ci: switch to Ubuntu 20.04

2022-04-26 Thread Aaron Conole
> > Signed-off-by: David Marchand > --- LGTM Acked-by: Aaron Conole

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-26 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 26, 2022 at 9:09 AM David Marchand > wrote: >> >> On error, the build logs are displayed in GHA console and logs unless >> the GITHUB_WORKFLOW env variable is set. >> However, containers in GHA do not automatically inherit this variable. >> We could pass this

[CI OUTAGE] GitHub Actions currently having issues with workflow API calls

2022-04-12 Thread Aaron Conole
The github actions API is currently undergoing some kind of outage - and has been for the last 12-14 hours (from what I can see). This particular issue seems to impact how we can retrieve results from various runs. I am working towards a workaround that will let us move past this. GitHub is awar

Re: [PATCH v5] ip_frag: add IPv4 options fragment and test data

2022-04-07 Thread Aaron Conole
Hi, "Ananyev, Konstantin" writes: > Hi Huichao, > > > > In general yes, it is developer responsibility to address any issues with > his/her patches. +1 > In that particular case, looking at the logs, it seems to be some > misconfiguration > > on test-machine not related anyhow to your chan

Minutes of tech-board meeting: 2022-01-12

2022-04-05 Thread Aaron Conole
Members Attending: - Aaron Conole - Bruce Richardson - David Marchand - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz

Re: [PATCH v3] ci: add Fedora 35 container in GHA

2022-04-04 Thread Aaron Conole
; > Signed-off-by: David Marchand > --- > Changes since v2: > - used a two stage pipeline so that container image generation > is done only once, > - changed image name local:dpdk to dpdk-local (closer to conventions), > > Changes since v1: > - switched to Fedora project hub, > - cached container image, > > --- This is fantastic! Acked-by: Aaron Conole

Re: [PATCH] ci: run more checks in private repositories

2022-03-25 Thread Aaron Conole
shouldn't take too long (since we refresh main branch weekly to the robot repository). The checks look good - and since it's part of the same build workflow, it will be reported in the same place (and hopefully in a readable form). Acked-by: Aaron Conole

Re: [PATCH] version: 22.07-rc0

2022-03-18 Thread Aaron Conole
David Marchand writes: > Start a new release cycle with empty release notes. > Bump version and ABI minor. > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon > --- Acked-by: Aaron Conole

  1   2   3   4   5   6   7   8   9   10   >