[PATCH] examples/ip_reassembly: remove conflicting Tx offload

2025-09-18 Thread Zhichao Zeng
IP packet reassembly requires the MULTI_SEGS offload to be enabled in order to handle fragmented packets across multiple memory segments. However, the MBUF_FAST_FREE offload conflicts with MULTI_SEGS and cannot be enabled simultaneously. Remove the MBUF_FAST_FREE offload to avoid conflicts with MU

RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

2025-09-18 Thread Akhil Goyal
Hi Sameer, > Hey Akhil, > > I attempted to split the changes into multiple patches and added a depends-on > the second patch. But automation does not seem to be picking up the patch as a > dependency. Is there a process step I messed up: When you have dependent patches, you should send them as a

[PATCH v2 2/3] net/mlx5: fix ESP item validation to match on seqnum

2025-09-18 Thread Maayan Kashani
From: Viacheslav Ovsiienko The match on ESP sequence number is supported by hardware steering implementation but was rejected in validation routine shared by all steering engines. This patch allows validation to pass with requested match on ESP sequence number for hardware steering engine. Fixe

[PATCH v9 12/17] net/nbl: add nbl device rxtx queue setup and release ops

2025-09-18 Thread Dimon Zhao
Implement NBL device Rx and Tx queue setup & release functions Signed-off-by: Dimon Zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 75 + drivers/net/nbl/nbl_dev/nbl_dev.h | 7 + drivers/net/nbl/nbl_ethdev.c | 4 + .../nbl/nbl_hw/nbl_hw_leonis/nbl_r

Re: [PATCH 2/2] net/xsc: support compressed PCI BAR

2025-09-18 Thread Renyong Wan
On 9/18/2025 11:54 PM, Stephen Hemminger wrote: > On Tue, 16 Sep 2025 18:08:54 +0800 > "Renyong Wan" wrote: > >> This commit allows the driver to correctly handle device >> with compressed PCI BAR. >> >> Signed-off-by: Rong Qian >> Signed-off-by: Renyong Wan >> --- > > Queued to next-net. > Shou

[PATCH v4] test/argparse: change initialization to workaround LTO

2025-09-18 Thread Stephen Hemminger
When compiled with Link Time Optimization, the existing code generated an error, because the compiler was unable to intuit that there was space in the flexible array. In function ‘test_argparse_copy’, inlined from ‘test_argparse_init_obj’ at ../app/test/test_argparse.c:108:2, inlined from

[V8 14/17] net/hinic3: add Rx/Tx functions

2025-09-18 Thread Feifei Wang
From: Feifei Wang This patch add package sending and receiving function codes. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- drivers/net/hinic3/hinic3_ethdev.c | 3 + drivers/net/hinic3/hinic3_rx.c | 285 +++ drivers/net/hinic3/hinic3_tx.c | 75

[PATCH v2] test: support SVA copy for dmadev test

2025-09-18 Thread Chengwen Feng
This commit supports SVA copy for dmadev test. Signed-off-by: Chengwen Feng --- v2: fix CI error (use uninitialized value) --- app/test/test_dmadev.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c

[V10 11/17] net/hinic3: add a mailbox communication module

2025-09-18 Thread Feifei Wang
From: Yi Chen This patch adds support for mailbox of hinic3 PMD driver, mailbox is used for communication between PF/VF driver and MPU. This patch provides mailbox-related data structures and functional code. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/n

[V10 02/17] net/hinic3: add basic header files

2025-09-18 Thread Feifei Wang
From: Xin Wang Add HW registers definition header file for SP series NIC. Add some headers that define commands and basic defines for use in the code. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- MAINTAINERS | 1 + drivers/net/hinic3

[PATCH 3/3] member: hide internal macro

2025-09-18 Thread Thomas Monjalon
The hash function used by the library is not supposed to be exposed and be part of the API. Signed-off-by: Thomas Monjalon --- lib/member/member.h | 9 + lib/member/rte_member.h | 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/member/member.h b/lib/me

Re: [PATCH v1 1/2] dts: move testpmd into API

2025-09-18 Thread Patrick Robb
Per the discussion at the CI meeting this morning I ran all the existing tests on a cx5 card and saw no difference in results with this series applied vs running on for-main. So, I will merge this series tomorrow morning. Thanks Paul. On Thu, Sep 18, 2025 at 1:30 AM Patrick Robb wrote: > Review

Re: [PATCH] compress/zlib: support for dictionary and PDCP checksum

2025-09-18 Thread Stephen Hemminger
On Thu, 18 Sep 2025 14:32:10 -0600 Sameer Vaze wrote: > Adds support to provide predefined dictionaries to zlib. Handles setting > and getting of dictionaries using zlib apis. Also includes support to > read dictionary files > > Adds support for passing in and validationg 3GPP PDCP spec defined

Re: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

2025-09-18 Thread Sameer Vaze
Hey Akhil, I attempted to split the changes into multiple patches and added a depends-on the second patch. But automation does not seem to be picking up the patch as a dependency. Is there a process step I messed up: Patch 1: compress/zlib: support for dictionary and PDCP checksum - Patchwork<

[PATCH] app/compress-perf: support dictionary files

2025-09-18 Thread Sameer Vaze
Adds support to pass in pre-defined dictionaries to zlib PMD. Signed-off-by: Sameer Vaze --- Depends-on: patch-156722 ("compress/zlib: support for dictionary and PDCP checksum") app/test-compress-perf/comp_perf_options.h| 4 + .../comp_perf_options_parse.c | 16 .../co

Re: [PATCH] eal: fix DMA mask validation inconsistency in IOVA VA

2025-09-18 Thread Patrick Robb
Hi Thomas, FYI the recheck you submitted is for Shani's v1 patch. The recheck pipeline picked up your request and is not running a recheck because the patch state is superseded (which blocks the recheck). If you still want a recheck on the v1, I will just remove the line in our script which stops

[PATCH] compress/zlib: support for dictionary and PDCP checksum

2025-09-18 Thread Sameer Vaze
Adds support to provide predefined dictionaries to zlib. Handles setting and getting of dictionaries using zlib apis. Also includes support to read dictionary files Adds support for passing in and validationg 3GPP PDCP spec defined checksums as defined under the Uplink Data Compression(UDC) featur

[PATCH] compress/zlib: support for dictionary and PDCP checksum

2025-09-18 Thread Sameer Vaze
Adds support to provide predefined dictionaries to zlib. Handles setting and getting of dictionaries using zlib apis. Also includes support to read dictionary files Adds support for passing in and validationg 3GPP PDCP spec defined checksums as defined under the Uplink Data Compression(UDC) featur

[PATCH v4] dts: enable port binding on the TG

2025-09-18 Thread Andrew Bailey
Currently, ports on the TG are not bound to the correct drivers prior to running DTS. This causes DTS to crash if they are not initially bound to the intended drivers. Binding the TG ports to the proper driver caused DTS to fail when the OS and DPDK drivers were the same, due to the port link not b

Re: [RFC v2 8/9] uapi: import VFIO header

2025-09-18 Thread Thomas Monjalon
06/09/2025 06:11, Stephen Hemminger: > On Wed, 3 Sep 2025 17:17:58 +0200 > David Marchand wrote: > > > Import VFIO header (from v6.16) to be included in many parts of DPDK. > > > > Signed-off-by: David Marchand > > --- > > kernel/linux/uapi/linux/vfio.h | 1836

DPDK Release Status Meeting 2025-09-09

2025-09-18 Thread Mcnamara, John
Release status meeting minutes 2025-09-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Nvidia * Red Hat Release Dates - The following are the proposed working dates for 25.11: - Propos

Re: [PATCH 1/1] ring: safe partial ordering for head/tail update

2025-09-18 Thread Wathsala Vithanage
On Wed, 2025-09-17 at 08:47 +0100, Bruce Richardson wrote: > On Tue, Sep 16, 2025 at 06:19:41PM +, Ola Liljedahl wrote: > > (I am sending this from Outlook, I hope I have been able to fake a > > proper > > email client) > > > > > On 2025-09-16, 17:43, "Bruce Richardson" > > > > > >

RE: [RFC] lib/dma: introduce inter-process and inter-OS DMA

2025-09-18 Thread Vamsi Krishna Attunuru
Hi Feng, Anatoly, Gentle ping for the review. Thanks >-Original Message- >From: Vamsi Krishna >Sent: Monday, September 1, 2025 6:04 PM >To: dev@dpdk.org >Cc: fengcheng...@huawei.com; tho...@monjalon.net; >bruce.richard...@intel.com; vladimir.medved...@intel.com; >anatoly.bura...@intel.c

RE: [PATCH v2] eal: fix DMA mask validation inconsistency in IOVA VA

2025-09-18 Thread Shani Peretz
> -Original Message- > From: Shani Peretz > Sent: Thursday, 18 September 2025 9:48 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Shani Peretz ; sta...@dpdk.org; Bruce Richardson > ; Dmitry Kozlyuk ; > Tyler Retzlaff ; Alejandro Lucero > > Subject: [PATCH v2] eal: f

Re: Fixing MBUF_FAST_FREE TX offload requirements?

2025-09-18 Thread Bruce Richardson
On Thu, Sep 18, 2025 at 10:50:11AM +0200, Morten Brørup wrote: > Dear NIC driver maintainers (CC: DPDK Tech Board), > > The DPDK Tech Board has discussed that patch [1] (included in DPDK 25.07) > extended the documented requirements to the RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE > offload. > These cha

[PATCH] lib: fix include guards

2025-09-18 Thread Thomas Monjalon
Fix the namespace of include guards by prefixing with "RTE", and add a missing include guard in rte_eal_paging.h. Signed-off-by: Thomas Monjalon --- lib/eal/include/rte_eal_paging.h | 11 --- lib/eal/include/rte_keepalive.h | 6 +++--- lib/jobstats/rte_jobstats.h | 6 +++--- lib/

Re: [PATCH] app/testpmd: fix L4 protocol retrieval from L3 header

2025-09-18 Thread Stephen Hemminger
On Sat, 30 Aug 2025 09:29:13 +0800 Dengdui Huang wrote: > Currently, when retrieving the L4 protocol from the L3 header, > the case of IPv6 with extension headers is not handled correctly. > This patch fixes it. > > Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") > Cc: sta...@dp

Re: [PATCH v9 04/17] net/nbl: add Channel layer definitions and implementation

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 01:08:30 -0700 Dimon Zhao wrote: > + if (wait_head->ack_err >= 0 && (data_len > 3 * sizeof(uint32_t))) { > + if (data_len - 3 * sizeof(uint32_t) != wait_head->ack_data_len) > + NBL_LOG(ERR, "payload_len do not match ack_len!," > +

Re: [PATCH v5] app/testpmd: stop secondary process fwd_lcores during primary teardown

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 23:47:03 -0700 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > When the secondary process testpmd application running any fwd_engine > and after that primary has exited will cause a crash. > > This patch forces secondary process forwarding lcores > in fwd_engine to stop

Re: [PATCH v9 04/17] net/nbl: add Channel layer definitions and implementation

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 01:08:30 -0700 Dimon Zhao wrote: > +static void nbl_chan_recv_ack_msg(void *priv, uint16_t srcid, uint16_t msgid, > + void *data, uint32_t data_len) > +{ > + struct nbl_channel_mgt *chan_mgt = (struct nbl_channel_mgt *)priv; > + union nbl_

Re: [PATCH v9 04/17] net/nbl: add Channel layer definitions and implementation

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 01:08:30 -0700 Dimon Zhao wrote: > + > +static struct nbl_channel_ops chan_ops = { > + .send_msg = nbl_chan_send_msg, > + .send_ack = nbl_chan_send_ack, > + .register_msg = nbl_chan_register_msg, > +

Re: [PATCH v9 04/17] net/nbl: add Channel layer definitions and implementation

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 01:08:30 -0700 Dimon Zhao wrote: > +static int nbl_chan_send_ack(void *priv, struct nbl_chan_ack_info *chan_ack) > +{ > + struct nbl_channel_mgt *chan_mgt = (struct nbl_channel_mgt *)priv; > + struct nbl_chan_send_info chan_send; > + u32 *tmp; > + u32 len = 3 *

Re: [PATCH 2/2] net/xsc: support compressed PCI BAR

2025-09-18 Thread Stephen Hemminger
On Tue, 16 Sep 2025 18:08:54 +0800 "Renyong Wan" wrote: > This commit allows the driver to correctly handle device > with compressed PCI BAR. > > Signed-off-by: Rong Qian > Signed-off-by: Renyong Wan > --- Queued to next-net. Should there be a Fixes tag on this?

Re: [V11 02/18] net/hinic3: add basic header files

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 18:15:36 +0800 Feifei Wang wrote: > + > +#ifdef CLOCK_MONOTONIC_RAW /**< Defined in glibc bits/time.h . */ > +#define CLOCK_TYPE CLOCK_MONOTONIC_RAW > +#else > +#define CLOCK_TYPE CLOCK_MONOTONIC > +#endif Defined but not used. > +#define HINIC3_S_TO_MS_UNIT 1000 > +#defin

Re: [V11 02/18] net/hinic3: add basic header files

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 18:15:36 +0800 Feifei Wang wrote: > + > +static inline int > +hinic3_get_bit(int nr, volatile RTE_ATOMIC(uint64_t) *addr) > +{ > + RTE_ASSERT(nr < 0x20); > + > + uint32_t mask = UINT32_C(1) << nr; > + return (*addr) & mask; > +} Shouldn't nr be unsigned? You don't

Re: [PATCH 1/2] net/xsc: improve interrupt uninstall

2025-09-18 Thread Stephen Hemminger
On Tue, 16 Sep 2025 18:08:51 +0800 "Renyong Wan" wrote: > Use synchronous callback unregister to ensure no callbacks > are running after interrupt uninstallation. This improves > stability and prevents potential use-after-free issues during > device teardown. > > Signed-off-by: Rong Qian > Sign

Re: [PATCH] sched: fix wrr parameter data type

2025-09-18 Thread Stephen Hemminger
On Thu, 18 Sep 2025 08:16:09 +0530 Megha Ajmera wrote: > wrr tokens getting truncated to uint8_t in wrr_store function() due to > type mismatch. This patch changes the data type to uint16_t. > > Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues") > > Signed-off-by: Megha Aj

DPDK Release Status Meeting 2025-09-16

2025-09-18 Thread Mcnamara, John
Release status meeting minutes 2025-09-16 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed working dates for 25.11:

RE: Fixing MBUF_FAST_FREE TX offload requirements?

2025-09-18 Thread Konstantin Ananyev
> Subject: RE: Fixing MBUF_FAST_FREE TX offload requirements? > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 18 September 2025 11.09 > > > > On Thu, Sep 18, 2025 at 10:50:11AM +0200, Morten Brørup wrote: > > > Dear NIC driver maintainers (CC: DPDK Tech Boar

[PATCH 0/3] lib: fix AVX2 checks and macro exposure

2025-09-18 Thread Thomas Monjalon
These are fixes for AVX2 in efd and member libraries. While at it, I've hidden a macro which was wrongly exported in the API without having a correct prefix. Thomas Monjalon (3): efd: fix AVX2 support member: remove AVX2 build-time checks member: hide internal macro lib/efd/rte_efd.c

RE: [PATCH v11 1/1] ethdev: add link connector type

2025-09-18 Thread Morten Brørup
> From: Sunil Kumar Kori > > Adding link connector parameter to provide the type > of connection for a port like twisted pair, fiber etc. > > Also added an API to convert the RTE_ETH_LINK_CONNECTOR_XXX > to a readable string. > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Sunil Kumar Ko

Re: [RFC v2 8/9] uapi: import VFIO header

2025-09-18 Thread Stephen Hemminger
On Thu, 18 Sep 2025 10:48:12 +0200 Thomas Monjalon wrote: > 06/09/2025 06:11, Stephen Hemminger: > > On Wed, 3 Sep 2025 17:17:58 +0200 > > David Marchand wrote: > > > > > Import VFIO header (from v6.16) to be included in many parts of DPDK. > > > > > > Signed-off-by: David Marchand > > > -

Re: Fixing MBUF_FAST_FREE TX offload requirements?

2025-09-18 Thread Stephen Hemminger
On Thu, 18 Sep 2025 10:50:11 +0200 Morten Brørup wrote: > Dear NIC driver maintainers (CC: DPDK Tech Board), > > The DPDK Tech Board has discussed that patch [1] (included in DPDK 25.07) > extended the documented requirements to the RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE > offload. > These changes

Re: [PATCH] test: raise fast test timeout to 60s on RISC-V

2025-09-18 Thread Thomas Monjalon
27/11/2024 04:26, Eric Long: > On 27/11/2024 04:29, David Marchand wrote: > > You can extend the timeout via the multiplier option (default timeout > > of 10s * multiplier). > > So in your case: > > $ meson test -C --suite fast-tests -t 6 > > I hope the RISC-V specific extended timeout could be u

Re: [PATCH v5] app/testpmd: stop secondary process fwd_lcores during primary teardown

2025-09-18 Thread Stephen Hemminger
On Wed, 17 Sep 2025 23:47:03 -0700 Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> wrote: > @@ -3628,6 +3709,7 @@ pmd_test_exit(void) > } > } > #endif > + > if (ports != NULL) { > no_link_check = 1; > RTE_ETH_FOREACH_DEV(pt_id) { I will drop th

Re: Re: [PATCH] test: raise fast test timeout to 60s on RISC-V

2025-09-18 Thread 孙越池
I think increasing the RISC-V timeout is reasonable and shouldn’t cause any issues. > -原始邮件- > 发件人: "Thomas Monjalon" > 发送时间: 2025-09-18 20:28:07 (星期四) > 收件人: "David Marchand" , dev@dpdk.org > 抄送: "Eric Long" > 主题: Re: [PATCH] test: raise fast test timeout to 60s on RISC-V > > 27/11/20

Re: [PATCH] gro: fix payload corruption in coalescing packets

2025-09-18 Thread kumaraparameshwaran rathinavel
Reviewed by : @kumaraparameshwaran rathinavel On Tue, Sep 2, 2025 at 4:14 PM Tathagat Priyadarshi wrote: > In the current implementation when cmp is larger than 0, > the new packet is appended to the original packet. However > the code is operating on the trailing packet to update the tcp flags

Re: [PATCH v1] net/zxdh: add support compiling on riscv-64 systems

2025-09-18 Thread Thomas Monjalon
11/09/2025 04:32, Junlong Wang: > modify meson.build for support compiling on riscv-64 systems [...] > -if not is_linux > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > build = false > -reason = 'only supported on Linux' > -subdir_done() > -endif > - > -if arch_subdir != 'x86'

Re: [PATCH 2/3] member: remove AVX2 build-time checks

2025-09-18 Thread Bruce Richardson
On Thu, Sep 18, 2025 at 09:28:04AM +0200, Thomas Monjalon wrote: > Since all supported compilers can generate AVX2 code, > no need to check for AVX2 support when x86 arch is already checked. > > Signed-off-by: Thomas Monjalon > --- > lib/member/rte_member_ht.c | 14 +++--- > lib/member/

Re: [PATCH v2 1/4] efd: fix AVX2 support

2025-09-18 Thread Thomas Monjalon
18/09/2025 11:40, Thomas Monjalon: > 18/09/2025 11:08, Thomas Monjalon: > > When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 > > became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. > > The function efd_lookup_internal_avx2() was never called, > > and its header includ

RE: Fixing MBUF_FAST_FREE TX offload requirements?

2025-09-18 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 18 September 2025 11.09 > > On Thu, Sep 18, 2025 at 10:50:11AM +0200, Morten Brørup wrote: > > Dear NIC driver maintainers (CC: DPDK Tech Board), > > > > The DPDK Tech Board has discussed that patch [1] (included in DPD

Re: [PATCH v2 1/4] efd: fix AVX2 support

2025-09-18 Thread Thomas Monjalon
18/09/2025 11:08, Thomas Monjalon: > When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 > became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. > The function efd_lookup_internal_avx2() was never called, > and its header include rte_efd_x86.h has been removed later. > >

[PATCH v2 4/4] member: hide internal macro

2025-09-18 Thread Thomas Monjalon
The hash function used by the library is not supposed to be exposed and be part of the API. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson --- lib/member/member.h | 9 + lib/member/rte_member.h | 9 - 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/

Fixing MBUF_FAST_FREE TX offload requirements?

2025-09-18 Thread Morten Brørup
Dear NIC driver maintainers (CC: DPDK Tech Board), The DPDK Tech Board has discussed that patch [1] (included in DPDK 25.07) extended the documented requirements to the RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload. These changes put additional limitations on applications' use of the MBUF_FAST_FREE

[PATCH v2 2/4] efd: remove AVX2 build-time check

2025-09-18 Thread Thomas Monjalon
Since all supported compilers can generate AVX2 code, it is possible to force AVX2 compilation on the specific function and remove the check for AVX2 support. The function has to be moved in a .c file, losing inlining. Signed-off-by: Thomas Monjalon --- lib/efd/{rte_efd_x86.h => efd_avx2.c} | 1

[PATCH v2 1/4] efd: fix AVX2 support

2025-09-18 Thread Thomas Monjalon
When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. The function efd_lookup_internal_avx2() was never called, and its header include rte_efd_x86.h has been removed later. AVX2 is assumed to be always supported on x86 w

[PATCH v2 0/4] lib: fix AVX2 checks and macro exposure

2025-09-18 Thread Thomas Monjalon
I've found the AVX2 function is not used in efd library. Then I tried to make AVX2 compilation simpler in efd and member libraries. While at it, I've hidden a macro which was wrongly exported in the API without having a correct prefix. Thomas Monjalon (4): efd: fix AVX2 support efd: remove AV

Re: DPDK LACP implemantation

2025-09-18 Thread Thomas Monjalon
Hello, 17/09/2025 16:07, Arik Alexander: > At Cato Networks we are currently working on implementing LACP LAG (bonding > device, mode 4) using the DPDK library. > During our evaluation, we identified some shortcomings in the implementation > — for example, the lack of support for short timeout a

Re: [PATCH 0/3] lib: fix AVX2 checks and macro exposure

2025-09-18 Thread Bruce Richardson
On Thu, Sep 18, 2025 at 10:10:59AM +0200, Thomas Monjalon wrote: > 18/09/2025 09:28, Thomas Monjalon: > > These are fixes for AVX2 in efd and member libraries. > > While at it, I've hidden a macro which was wrongly exported in the API > > without having a correct prefix. > > > > Thomas Monjalon (3

Re: [RFC v2 4/9] vfio: remove public wrappers

2025-09-18 Thread David Marchand
Hello Anatoly, On Tue, 9 Sept 2025 at 17:38, Burakov, Anatoly wrote: > > On 9/3/2025 5:17 PM, David Marchand wrote: > > The public header defines a number of wrappers that can be removed or > > hidden internally. > > > > Either, those concern old Linux kernel versions that are not supported by >

Re: [PATCH 1/3] efd: fix AVX2 support

2025-09-18 Thread Thomas Monjalon
18/09/2025 09:48, Bruce Richardson: > On Thu, Sep 18, 2025 at 09:28:03AM +0200, Thomas Monjalon wrote: > > -#if defined(RTE_ARCH_X86) && defined(CC_SUPPORT_AVX2) > > +#if defined(RTE_ARCH_X86) > > Ok to remove this, because indeed all supported compilers have AVX2. > > However, given that the efd

RE: [PATCH v2] app/crypto-perf: fix plaintext size exceeds buffer size

2025-09-18 Thread Shani Peretz
> -Original Message- > From: Shani Peretz > Sent: Monday, 25 August 2025 10:15 > To: dev@dpdk.org > Cc: step...@networkplumber.org; Shani Peretz ; > sta...@dpdk.org; Kai Ji ; Declan Doherty > ; Marcin Kerlin ; > Slawomir Mrozowicz ; Michal Kobylinski > ; Piotr Azarewicz > Subject: [PATC

Re: [PATCH 3/3] member: hide internal macro

2025-09-18 Thread Bruce Richardson
On Thu, Sep 18, 2025 at 09:28:05AM +0200, Thomas Monjalon wrote: > The hash function used by the library is not supposed > to be exposed and be part of the API. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Bruce Richardson

Re: [PATCH 1/3] efd: fix AVX2 support

2025-09-18 Thread Bruce Richardson
On Thu, Sep 18, 2025 at 09:28:03AM +0200, Thomas Monjalon wrote: > When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 > became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. > The function efd_lookup_internal_avx2() was never called, > and its header include rte_efd_x86.h

[PATCH 2/3] member: remove AVX2 build-time checks

2025-09-18 Thread Thomas Monjalon
Since all supported compilers can generate AVX2 code, no need to check for AVX2 support when x86 arch is already checked. Signed-off-by: Thomas Monjalon --- lib/member/rte_member_ht.c | 14 +++--- lib/member/rte_member_x86.h | 3 --- 2 files changed, 7 insertions(+), 10 deletions(-) d

[PATCH 1/3] efd: fix AVX2 support

2025-09-18 Thread Thomas Monjalon
When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. The function efd_lookup_internal_avx2() was never called, and its header include rte_efd_x86.h has been removed later. AVX2 is assumed to be always supported on x86 w