[PATCH] test-flow-perf: Enable to build on Windows

2025-08-05 Thread Andre Muezerie
This patch fixes some issues which were preventing this test to be built on Windows: - Remove VLAs (not supported by msvc). - Replace strsep() (which is not natively available on Windows) with strtok_r(). - Remove the "thousands" separator from printf() calls as it is not available on Windows.

[DPDK/DTS Bug 1764] dts: add missing type hints for function arguments and return types

2025-08-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1764 Bug ID: 1764 Summary: dts: add missing type hints for function arguments and return types Product: DPDK Version: 25.07 Hardware: All OS: All Status: UNC

[PATCH v2] doc: reword ethdev guide

2025-08-05 Thread Nandini Persad
With the help of Ajit Khaparde, I spent some time adding minor information and rewriting this section for grammar and clarity. Signed-off-by: Nandini Persad --- doc/guides/prog_guide/ethdev/ethdev.rst | 383 +--- 1 file changed, 209 insertions(+), 174 deletions(-) diff --git

Re: [PATCH] app/crypto-perf: fix plaintext size exceeds buffer size

2025-08-05 Thread Stephen Hemminger
On Tue, 5 Aug 2025 09:38:00 +0300 Shani Peretz wrote: > diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c > b/app/test-crypto-perf/cperf_test_vector_parsing.c > index 737d61d4af..04ca9cf019 100644 > --- a/app/test-crypto-perf/cperf_test_vector_parsing.c > +++ b/app/test-crypto-perf/c

Re: [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default

2025-08-05 Thread Stephen Hemminger
On Tue, 5 Aug 2025 07:48:41 +0200 Morten Brørup wrote: > > From: fengchengwen [mailto:fengcheng...@huawei.com] > > Sent: Tuesday, 5 August 2025 02.59 > > > > On 8/4/2025 3:42 AM, Morten Brørup wrote: > > > Enabling some offload by default may conflict with a manually > > configured > > > o

Re: [PATCH] net/mlx5: fix connection tracking state item validation

2025-08-05 Thread Ivan Malov
Hi, On Tue, 5 Aug 2025, Khadem Ullah wrote: This patch validate a connection tracking state when matching 'conntrack is' in rte_flow rules. The conntract possible CT states are SYN_RECV, ESTABLISHED, FIN_WAIT, CLOSE_WAIT, LAST_ACK and TIME_WAIT. Therefore the maximum possible value to match on

[PATCH] net/mlx5: fix connection tracking state item validation

2025-08-05 Thread Khadem Ullah
This patch validate a connection tracking state when matching 'conntrack is' in rte_flow rules. The conntract possible CT states are SYN_RECV, ESTABLISHED, FIN_WAIT, CLOSE_WAIT, LAST_ACK and TIME_WAIT. Therefore the maximum possible value to match on in rte_flow is TIME_WAIT but mlx5 allowed matchi

[PATCH] net/mlx5: fix ASan issue in RSS flow creation

2025-08-05 Thread Maayan Kashani
This patch addresses AddressSanitizer (ASan) stack-use-after-scope issues occurring during RSS flow creation in the MLX5 driver. The root cause stemmed from the use of compound literals to initialize flow action configurations, which could result in pointers to temporary stack memory being retained

RE: [PATCH v3 3/3] ethdev: Reject conflicting TX offloads configuration

2025-08-05 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Tuesday, 5 August 2025 04.10 > > On 8/4/2025 3:42 AM, Morten Brørup wrote: > > When an ethdev port is configured for fast mbuf release, the driver can > > use a TX burst function relying on the fast mbuf release preconditions. > > Thus,

[PATCH] This patch validate a connection tracking state when matching 'conntrack is' in rte_flow rules. The conntract possible CT states are SYN_RECV, ESTABLISHED, FIN_WAIT, CLOSE_WAIT, LAST_ACK and T

2025-08-05 Thread Khadem Ullah
This patch validate the CT state item. Fixes: aca19061e4b9 ('net/mlx5: validate connection tracking item') Cc: sta...@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1...@uetpeshawar.edu.pk> --- drivers/net/mlx5/mlx5_flow_dv.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5

Re: [PATCH] dts: update hinted return types of various methods

2025-08-05 Thread Luca Vizzarro
Hi Andrew, you may have noticed that the CI failed. It is worth running the following scripts prior to submitting: - devtools/dts-check-format.py (in a Poetry environment) - devtools/checkpatches.sh - devtools/check-git-log.sh mypy specifically fails in some occasions because of missed faults

Re: [PATCH] dts: update hinted return types of various methods

2025-08-05 Thread Luca Vizzarro
Hi Andrew, congratulations on your first patch to the mailing list! For v2 please make a change to the .mailmap file, adding your Git name and email address appropriately respecting the alphabetical order. Like I already pointed out a couple of times below, it may be worth considering fixing

RE: [PATCH 1/3] net/iavf: support qinq insertion offload for scalar path

2025-08-05 Thread Loftus, Ciara
> > On Thu, Jun 19, 2025 at 01:36:56PM +, Ciara Loftus wrote: > > Enable Tx QINQ offload if the VF reports support for inserting both an > > outer and inner VLAN tag. The VF capabilities report the locations for > > placing each of the tags - either L2TAG1 in the tx descriptor or L2TAG2 > > in

RE: [v3] net/cksum: compute raw cksum for several segments

2025-08-05 Thread Marat Khalili
> -Original Message- > From: Su Sai > Sent: Monday 4 August 2025 04:55 > To: step...@networkplumber.org > Cc: dev@dpdk.org; Su Sai > Subject: [v3] net/cksum: compute raw cksum for several segments > > The rte_raw_cksum_mbuf function is used to compute > the raw checksum of a packet. > If

Re: 22.11.9 patches review and test

2025-08-05 Thread Luca Boccassi
On Tue, 5 Aug 2025 at 10:28, Xu, HailinX wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Thursday, July 24, 2025 12:08 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; David Christensen > > ; Hemant Agrawal ; > > Ian Stokes

RE: 22.11.9 patches review and test

2025-08-05 Thread Xu, HailinX
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Thursday, July 24, 2025 12:08 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Ian Stokes ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Traynor

[PATCH] net/virtio-user: fix used ring address calculation

2025-08-05 Thread Maxime Coquelin
This patch fixes the used ring address calculation, to avoid Vhost-vDPA backends (such as VDUSE) to fail while trying to translate it. Fixes: 666ef294ddf7 ("net/virtio-user: share descriptor IOVA to backend") Cc: sta...@dpdk.org Reported-by: Adrian Moreno Signed-off-by: Maxime Coquelin --- dri

Re: [PATCH v4 1/4] eal: add basename function for common path manipulation

2025-08-05 Thread Bruce Richardson
On Fri, Aug 01, 2025 at 02:56:11PM -0700, Stephen Hemminger wrote: > On Thu, 31 Jul 2025 16:00:38 + > Bruce Richardson wrote: > > > There is no standard, cross-platform function to get the basename of a > > file path across all the supported DPDK platforms, Linux, BSD and > > Windows. Both Li

RE: [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default

2025-08-05 Thread Ivan Malov
Hi, On Tue, 5 Aug 2025, Morten Brørup wrote: From: fengchengwen [mailto:fengcheng...@huawei.com] Sent: Tuesday, 5 August 2025 02.59 On 8/4/2025 3:42 AM, Morten Brørup wrote: Enabling some offload by default may conflict with a manually configured offload. Specifically, the mbuf fast release

[PATCH] app/crypto-perf: fix plaintext size exceeds buffer size

2025-08-05 Thread Shani Peretz
When test vector plaintext exceeds buffer size, only the first max_buffer_size bytes are processed, causing incorrect digest verification (computed vs expected mismatch). This patch fixes this issue by checking that the plaintext size is larger than the buffer size and returns an error with a log.

[PATCH] app/crypto-perf: update result granularity

2025-08-05 Thread Akhil Goyal
In cases like RSA which has low performance numbers compared to AES, the Mops and gbps may not give accurate results. Hence updated the number of decimal places to have meaningful results. The results are not updated to show Kops or mbps as the results may be used in CI scripts which considers them