Re: [PATCH] app/testpmd: fix set cores list string size

2025-07-21 Thread Stephen Hemminger
On Tue, 8 Jul 2025 20:51:59 +0800 Dengdui Huang wrote: > The cmdline_fixed_string_t has a length of only 128, which will > become insufficient when there are many cores, so it should be > replaced with a cmdline_multi_string_t of larger capacity. > > Fixes: af75078fece3 ("first public release")

Re: [PATCH 0/3] common/sfc_efx/base: fix compiler warnings in X4 netport API

2025-07-21 Thread Stephen Hemminger
On Fri, 11 Jul 2025 18:43:46 +0400 Ivan Malov wrote: > The 25.07 release has got support for AMD Solarflare X45xx adapters [1]. > This series is a follow-up to [1] to fix compiler warnings in the base > driver that are seen in Windows driver build, also based on this driver. > > [1] https://patc

Re: [PATCH] app/testpmd: fix set cores list string size

2025-07-21 Thread Stephen Hemminger
On Tue, 8 Jul 2025 20:51:59 +0800 Dengdui Huang wrote: > The cmdline_fixed_string_t has a length of only 128, which will > become insufficient when there are many cores, so it should be > replaced with a cmdline_multi_string_t of larger capacity. > > Fixes: af75078fece3 ("first public release")

Re: [PATCH 0/7] net/gve: Tx datapath fixes for GVE DQO

2025-07-21 Thread Stephen Hemminger
On Mon, 7 Jul 2025 16:18:04 -0700 Joshua Washington wrote: > There are a number of consistency errors with the DQO Tx datapath, which > this series aims to address. These changes should make the driver much > more resilient against edge case and malformed packets overall. > > Joshua Washington

[PATCH v3] ethdev: Align enable logic handling with disable functions

2025-07-21 Thread Sunyang Wu
This patch modifies the handling logic of the "enable" related operations. The key intention is to align it with the processing approach of the "disable" functions. Previously, there was an inconsistency in how failure scenarios were dealt with between the "enable" and "disable" logic. Now, after a

DPDK 25.07 released

2025-07-21 Thread Thomas Monjalon
A new major release is available: https://fast.dpdk.org/rel/dpdk-25.07.tar.xz It was a small release cycle: 806 commits from 133 authors 1685 files changed, 94020 insertions(+), 27600 deletions(-) It is not planned to start a maintenance branch for 25.07. This version is A

[PATCH v2 1/2] eal: add strsep() for Windows builds

2025-07-21 Thread Andre Muezerie
Function strsep() is used by DPDK code but is not available on Windows. This patch adds an implementation from NetBSD, unblocking code depending on it from being compiled on Windows. Signed-off-by: Andre Muezerie --- lib/eal/windows/include/rte_os_shim.h | 1 + lib/eal/windows/include/strsep.h

[PATCH v2 2/2] test/strsep: add tests for function strsep()

2025-07-21 Thread Andre Muezerie
This patch adds tests for the strsep() function. Signed-off-by: Andre Muezerie --- app/test/meson.build | 1 + app/test/test_strsep.c | 108 + 2 files changed, 109 insertions(+) create mode 100644 app/test/test_strsep.c diff --git a/app/test/meson.bu

Re: [PATCH] doc: announce changes in structure alignments for UBSan

2025-07-21 Thread Thomas Monjalon
09/07/2025 14:40, David Marchand: > As part of the effort to limit undefined behaviors in DPDK code, some > structure alignments revealed not to be accurate enough. > At the moment two structures have been identified but others may be > found while running more parts of DPDK with UBSan. > > Though

Re: [PATCH v2] net/intel: deprecate some SSE paths

2025-07-21 Thread Thomas Monjalon
03/07/2025 16:31, Ciara Loftus: > The SSE rx and tx paths will be removed from the i40e, iavf and ice > drivers in the 25.11 release. Each of these drivers have faster vector > paths (AVX2 and AVX-512) which have feature parity with the soon to be > removed SSE paths. In environments where AVX2 or

Re: [PATCH] net/mlx5: deprecate representor matching devarg

2025-07-21 Thread Thomas Monjalon
16/07/2025 11:38, Dariusz Sosnowski: > Mark repr_matching_en device argument exposed by mlx5 PMD > as deprecated and schedule its removal in 25.11 release. > > Functionality exposed by this device argument does not fit > current E-Switch representor model exposed by DPDK. > A new unified represent

[PATCH v3] test_bbdev: enable to be compiled on Windows

2025-07-21 Thread Andre Muezerie
This patch fixes a few issues which were preventing this test from getting compiled on Windows: 1) VLAs were removed: Variable Length Arrays are not supported by MSVC. Where possible constant C arrays were used. Where that approach was not possible alloca() was called instead. 2) rte_os_shim is i

[PATCH v2] app/test-cmdline: add test to Windows build

2025-07-21 Thread Andre Muezerie
Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences. Sign

Re: [PATCH v0 1/1] doc: announce inter-device DMA capability support in dmadev

2025-07-21 Thread Thomas Monjalon
10/07/2025 10:51, Vamsi Krishna: > From: Vamsi Attunuru > > Modern DMA hardware supports data transfer between multiple > DMA devices, enabling data communication across isolated domains or > containers. To facilitate this, the ``dmadev`` library requires changes > to allow devices to register wi

Re: [EXTERNAL] [PATCH] doc: announce DMA configuration structure changes

2025-07-21 Thread Thomas Monjalon
> Deprecate rte_dma_conf structure to allow for a more flexible > configuration of DMA devices. > The new structure will have a flags field instead of multiple > boolean fields for each feature. > > Signed-off-by: Pavan Nikhilesh > --- > +* dmadev: The ``rte_dma_c

Re: [PATCH] rcu: add deprecation notice about limit on defer queue element size

2025-07-21 Thread Thomas Monjalon
14/07/2025 11:01, Konstantin Ananyev: > > 10/07/2025 16:37, Andre Muezerie: > > > On Tue, Jul 01, 2025 at 04:17:20PM +0200, Thomas Monjalon wrote: > > > > 23/05/2025 01:37, Andre Muezerie: > > > > > The functions rte_rcu_qsbr_dq_create and rte_rcu_qsbr_dq_reclaim > > > > > establish > > > > > no l

Re: [PATCH] doc: announce mbuf fast free configuration requirements

2025-07-21 Thread Thomas Monjalon
15/07/2025 17:12, Konstantin Ananyev: > > > For TX mbuf fast release offload, the mbuf mempool pointer will be added > > to the ethdev tx queue configuration structure, so the ethdev TX burst > > operation doesn't need to fetch it from the first mbuf of each burst being > > fast free'd to the memp

Re: [PATCH v2] doc: update kernel version requirement

2025-07-21 Thread Thomas Monjalon
21/07/2025 12:45, Kevin Traynor: > On 10/04/2025 16:20, Stephen Hemminger wrote: > > The 4.19 kernel version was end of life in December 2024. > > Update to 5.4 and also add better description of what "not supported" > > means in this case. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: M

Re: [RFC] doc: change recommendation for installation of tools on Fedora

2025-07-21 Thread Thomas Monjalon
09/06/2025 05:03, Stephen Hemminger: > The syntax changed with Fedora 41 and the old command is now: > $ sudo dnf group install development-tools > > Not sure what is on RHEL 9 or later. [...] > -* For RHEL/Fedora systems these can be installed using ``dnf > groupinstall "Development Tools"``

Re: [PATCH] doc: install guides and api docs to different directories

2025-07-21 Thread Thomas Monjalon
06/01/2025 11:30, Bruce Richardson: > On Mon, Dec 23, 2024 at 03:38:40PM +, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > Otherwise they both get installed to /usr/share/doc/dpdk/html/ and overwrite > > each other's files > > > > Signed-off-by: Luca Boccassi > > Acked-by:

[DPDK/DTS Bug 1759] make single link the default topology in DTS

2025-07-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1759 Bug ID: 1759 Summary: make single link the default topology in DTS Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: minor

Re: [PATCH v3] mailmap: add new email to DPDK

2025-07-21 Thread Thomas Monjalon
19/07/2025 17:17, Pravin Pathak: > Adding new mail for DPDK contribution > > Signed-off-by: Pravin Pathak > --- > -Pravin Pathak > +Pravin Pathak Applied, thanks.

Re: [PATCH] mailmap: keep only one name per contributor

2025-07-21 Thread Thomas Monjalon
21/07/2025 18:06, Bruce Richardson: > On Mon, Jul 21, 2025 at 05:44:01PM +0200, David Marchand wrote: > > Some duplicates have slipped in the mailmap file. > > Clean this up. > > > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson Applied, thanks.

Re: [PATCH] mailmap: keep only one name per contributor

2025-07-21 Thread Bruce Richardson
On Mon, Jul 21, 2025 at 05:44:01PM +0200, David Marchand wrote: > Some duplicates have slipped in the mailmap file. > Clean this up. > > Signed-off-by: David Marchand > --- > .mailmap | 4 > 1 file changed, 4 deletions(-) > Acked-by: Bruce Richardson

Re: [RFC] Proposal for stable developer-friendly DTS API

2025-07-21 Thread Patrick Robb
On Tue, Jul 15, 2025 at 2:57 AM Paul Szczepanek wrote: > Hi all, > > Now that we've written a significant number of tests and developed a > consistent usage pattern, I think it's a good time to take the next step > toward project maturity: establishing a stable, well-defined API that > developers

[PATCH] mailmap: keep only one name per contributor

2025-07-21 Thread David Marchand
Some duplicates have slipped in the mailmap file. Clean this up. Signed-off-by: David Marchand --- .mailmap | 4 1 file changed, 4 deletions(-) diff --git a/.mailmap b/.mailmap index 75e550e47a..656fcf826a 100644 --- a/.mailmap +++ b/.mailmap @@ -488,7 +488,6 @@ Gaurav Singh Gautam Dawar

Re: [PATCH v10 14/14] net/sxe: add Solve compilation problems.

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:37 +0800 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Build is failing on the check-doc-vs-code tool which compares rte_flow in code vs document.

Re: [PATCH v10 02/14] net/sxe: add ethdev probe and remove

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:25 +0800 Jie Liu wrote: > + > +#ifndef fallthrough > +# define fallthrough do {} while (0) > +#endif > + This won't do what is expected. Compilers will complain that switch statement has unexpected fall through. Either make it an attribute or use comment instead.

Re: [PATCH v10 13/14] net/sxe: add virtual function

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:36 +0800 Jie Liu wrote: > diff --git a/drivers/net/sxe/base/sxevf_hw.c b/drivers/net/sxe/base/sxevf_hw.c > new file mode 100644 > index 00..7425bafedb > --- /dev/null > +++ b/drivers/net/sxe/base/sxevf_hw.c > @@ -0,0 +1,951 @@ > +/* SPDX-License-Identifier: BSD-3

Re: [PATCH v10 10/14] net/sxe: add xstats function

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:33 +0800 Jie Liu wrote: > +s32 sxe_eth_stats_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_stats *stats) > +{ > + struct sxe_adapter *adapter = eth_dev->data->dev_private; > + struct sxe_stats_info *stats_info = &adapter->stats_i

Re: [PATCH v10 14/14] net/sxe: add Solve compilation problems.

2025-07-21 Thread Stephen Hemminger
On Sat, 19 Jul 2025 17:05:37 +0800 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Please incorporate review feedback in new versions. I and others gave the feedback that this patch should be combined in with the patches that were problematic. Rather than one fix u

[PATCH v4 2/3] drivers/net: remove use of non-standard array range initialization

2025-07-21 Thread Andre Muezerie
Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors like the one below: drivers/net/r8169/r8169_phy.c(380): error C2143: syntax error: missing ':' before '...' case CFG_METHOD_48 ... CFG_METHOD_57: The fix is

[PATCH v4 3/3] drivers: enable drivers to be compiled with MSVC

2025-07-21 Thread Andre Muezerie
Now that all issues related to drivers are addressed they can be enabled to be built with MSVC. Signed-off-by: Andre Muezerie --- drivers/meson.build | 4 1 file changed, 4 deletions(-) diff --git a/drivers/meson.build b/drivers/meson.build index b62880db02..d98ef27f66 100644 --- a/drivers

[PATCH v4 1/3] app/test: remove use of non-standard array range initialization

2025-07-21 Thread Andre Muezerie
Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors like the one below: drivers/net/r8169/r8169_phy.c(380): error C2143: syntax error: missing ':' before '...' case CFG_METHOD_48 ... CFG_METHOD_57: The fix is

[PATCH v4 0/3] enable drivers to be compiled with MSVC

2025-07-21 Thread Andre Muezerie
This patchset solves the last issues preventing drivers from being compiled with MSVC (array range initialization) and enables the drivers to be built with it. Array range initialization is non-standard and is not provided by all compilers. MSVC does not implement it and ends up emitting errors li

[PATCH v5 9/9] eal: simplify handling of conflicting cmdline options

2025-07-21 Thread Bruce Richardson
Use a utility function and macro to simplify the code for checking for conflicting cmdline options. The checking can also be done at the initial argument collating stage, shortening the argument processing function which is very much on the long side. Signed-off-by: Bruce Richardson --- lib/eal/

[PATCH v5 8/9] eal: combine parameter validation checks

2025-07-21 Thread Bruce Richardson
Remove the separate function to check combinations of cmdline parameters. Instead, just do those checks when parsing the parameters since we have all info about what parameters are provided at that point. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_memory.c | 3 +- lib/eal/c

[PATCH v5 7/9] eal: ensure proper cleanup on EAL init failure

2025-07-21 Thread Bruce Richardson
When rte_eal_init fails part way through, any saved EAL arguments need to be freed, and the run_once flag needs to be set back to zero again. The former task was never done on failure, and the latter was only done on some occasions. Rework the error handling to always go to an err_out label where c

[PATCH v5 6/9] eal: gather EAL args before processing

2025-07-21 Thread Bruce Richardson
DPDK traditionally has iterated through all args and processed them as they appear in the commandline. The arg processing logic can be simplified if instead we initially gather all arguments into a structure which is then processed with the arguments dealt with in a fixed/known order. Signed-off-b

[PATCH v5 4/9] eal: add long options for each short option

2025-07-21 Thread Bruce Richardson
To simplify future rework of the EAL arg handling, add a long-option equivalent for each short option that doesn't already have one. When updating the docs with the new long options, standardize the format of options which have both short and long variants, and drop the deprecated service-coremask

[PATCH v5 5/9] eal: define the EAL parameters in argparse format

2025-07-21 Thread Bruce Richardson
Create eal_option_list.h, containing all the possible EAL parameters, and basic info about them, such as type, whether they take a parameter or not. Each entry is defined using a macro, which will be then interpreted when the file is included. First time this header in included in the eal_common_o

[PATCH v5 3/9] argparse: allow user-override of help printing

2025-07-21 Thread Bruce Richardson
When the arguments passed to argparse include -h/--help then usage information is automatically printed. Provide the capability for the user to supply their own help function for this. Signed-off-by: Bruce Richardson --- doc/guides/prog_guide/argparse_lib.rst | 16 lib/argparse/

[PATCH v5 2/9] argparse: export function to print help text for object

2025-07-21 Thread Bruce Richardson
Make the function to print out the help text for an argparse object a public function, which takes as a new parameter the file stream on which to print. This can be used in future to allow application to extend their own help information. Signed-off-by: Bruce Richardson --- lib/argparse/rte_argp

[PATCH v5 1/9] build: add define for the OS environment name

2025-07-21 Thread Bruce Richardson
Introduce a string define for the currently running OS, or execution environment. Originally, with old make build system, CONFIG_RTE_EXEC_ENV used to hold this name string, but the variable seems to have been missed in the meson build system, until commit cadb255e25d6 ("eal: add OS defines for C c

[PATCH v5 0/9] rework EAL argument parsing

2025-07-21 Thread Bruce Richardson
When processing cmdline arguments in DPDK, we always do so with very little context. So, for example, when processing the "-l" flag, we have no idea whether there will be later a --proc-type=secondary flag. We have all sorts of post-arg-processing checks in place to try and catch these scenarios.

[PATCH v4 9/9] eal: simplify handling of conflicting cmdline options

2025-07-21 Thread Bruce Richardson
Use a utility function and macro to simplify the code for checking for conflicting cmdline options. The checking can also be done at the initial argument collating stage, shortening the argument processing function which is very much on the long side. Signed-off-by: Bruce Richardson --- lib/eal/

[PATCH v4 8/9] eal: combine parameter validation checks

2025-07-21 Thread Bruce Richardson
Remove the separate function to check combinations of cmdline parameters. Instead, just do those checks when parsing the parameters since we have all info about what parameters are provided at that point. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_memory.c | 3 +- lib/eal/c

[PATCH v4 7/9] eal: ensure proper cleanup on EAL init failure

2025-07-21 Thread Bruce Richardson
When rte_eal_init fails part way through, any saved EAL arguments need to be freed, and the run_once flag needs to be set back to zero again. The former task was never done on failure, and the latter was only done on some occasions. Rework the error handling to always go to an err_out label where c

[PATCH v4 6/9] eal: gather EAL args before processing

2025-07-21 Thread Bruce Richardson
DPDK traditionally has iterated through all args and processed them as they appear in the commandline. The arg processing logic can be simplified if instead we initially gather all arguments into a structure which is then processed with the arguments dealt with in a fixed/known order. Signed-off-b

[PATCH v4 5/9] eal: define the EAL parameters in argparse format

2025-07-21 Thread Bruce Richardson
Create eal_option_list.h, containing all the possible EAL parameters, and basic info about them, such as type, whether they take a parameter or not. Each entry is defined using a macro, which will be then interpreted when the file is included. First time this header in included in the eal_common_o

[PATCH v4 4/9] eal: add long options for each short option

2025-07-21 Thread Bruce Richardson
To simplify future rework of the EAL arg handling, add a long-option equivalent for each short option that doesn't already have one. When updating the docs with the new long options, standardize the format of options which have both short and long variants, and drop the deprecated service-coremask

[PATCH v4 3/9] argparse: allow user-override of help printing

2025-07-21 Thread Bruce Richardson
When the arguments passed to argparse include -h/--help then usage information is automatically printed. Provide the capability for the user to supply their own help function for this. Signed-off-by: Bruce Richardson --- doc/guides/prog_guide/argparse_lib.rst | 16 lib/argparse/

[PATCH v4 2/9] argparse: export function to print help text for object

2025-07-21 Thread Bruce Richardson
Make the function to print out the help text for an argparse object a public function, which takes as a new parameter the file stream on which to print. This can be used in future to allow application to extend their own help information. Signed-off-by: Bruce Richardson --- lib/argparse/rte_argp

[PATCH v4 1/9] build: add define for the OS environment name

2025-07-21 Thread Bruce Richardson
Introduce a string define for the currently running OS, or execution environment. Originally, with old make build system, CONFIG_RTE_EXEC_ENV used to hold this name string, but the variable seems to have been missed in the meson build system, until commit cadb255e25d6 ("eal: add OS defines for C c

[PATCH v4 0/9] rework EAL argument parsing

2025-07-21 Thread Bruce Richardson
When processing cmdline arguments in DPDK, we always do so with very little context. So, for example, when processing the "-l" flag, we have no idea whether there will be later a --proc-type=secondary flag. We have all sorts of post-arg-processing checks in place to try and catch these scenarios.

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Stephen Hemminger
On Mon, 21 Jul 2025 12:58:19 +0200 Dariusz Sosnowski wrote: > I don't think it's an issue on PMD level, but rather on > ethdev/multi-process handling level. > > When primary process closes the port, ethdev library zeroes and frees > device data shared between processes. > ethdev port data (rte_e

[DPDK/other Bug 1758] net/mlx5: Incompatible enum type used in bitwise operation

2025-07-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1758 Bug ID: 1758 Summary: net/mlx5: Incompatible enum type used in bitwise operation Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED

Re: [PATCH] buildtools/check-git-log: print expected driver prefix

2025-07-21 Thread Thomas Monjalon
24/01/2025 18:24, Bruce Richardson: > When outputting an error for an invalid log prefix, don't just tell the > user that the prefix is wrong - also tell them what the expected prefix > should be. > > Signed-off-by: Bruce Richardson Applied (with fixed prefix :), thanks.

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
On Mon, Jul 21, 2025 at 01:59:59PM +0200, Thomas Monjalon wrote: > 21/07/2025 13:46, Ivan Malov: > > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > > > + mlx5 maintainers > > > > > > Thank you for the patch. > > > > > > Could you please include other PMD maintainers (or other maintainers, >

Re: [PATCH] devtools: forbid use of compiler pragmas

2025-07-21 Thread Thomas Monjalon
30/01/2025 09:52, David Marchand: > On Thu, Jan 30, 2025 at 9:45 AM Morten Brørup > wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, 30 January 2025 09.38 > > > > > > Using pragma must be prevented to avoid breaking builds with other > > > compilers.

Re: [PATCH] doc/mlx5: document firmware requirement for flex item

2025-07-21 Thread Dariusz Sosnowski
On Wed, Jul 16, 2025 at 03:49:40AM -0400, Khadem Ullah wrote: > Hi Dariusz, > > Thanks for the follow-up. > > I was using DPDK v23.11 with the following flex item configuration: > > { > "next_header": { "field_mode": "FIELD_MODE_FIXED", "field_size": 0, > "field_base": 0 }, > "next_protocol

Re: [PATCH] devtools: exclude atomic checks for common cnxk

2025-07-21 Thread Thomas Monjalon
12/06/2025 15:39, Jerin Jacob: > On Thu, Mar 27, 2025 at 4:50 PM wrote: > > > > From: Pavan Nikhilesh > > > > Since driver/common/cnxk has common code that is > > used across multiple platforms, allow use of > > GCC builtin atomic functions. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by:

Re: [PATCH v2] ethdev: Align enable logic handling with disable functions

2025-07-21 Thread Thomas Monjalon
21/07/2025 15:05, Sunyang Wu: > This patch modifies the handling logic of the "enable" related > operations. The key intention is to align it with the processing > approach of the "disable" functions. > Previously, there was an inconsistency in how failure scenarios were > dealt with between the "e

Re: [PATCH] mailmap: fix entries with many aliases

2025-07-21 Thread Thomas Monjalon
16/07/2025 16:41, David Marchand: > According to gitmailmap manual, a line is composed of a contact > information followed by commit information. > > Which translates to the following formats: > Proper Name > > Proper Name > Proper Name Commit Name > > Some lines had multiple commit infos

[PATCH v2] ethdev: Align enable logic handling with disable functions

2025-07-21 Thread Sunyang Wu
This patch modifies the handling logic of the "enable" related operations. The key intention is to align it with the processing approach of the "disable" functions. Previously, there was an inconsistency in how failure scenarios were dealt with between the "enable" and "disable" logic. Now, after a

Re: [PATCH v3 5/9] eal: define the EAL parameters in argparse format

2025-07-21 Thread Bruce Richardson
On Mon, Jul 21, 2025 at 10:05:23AM +0100, Bruce Richardson wrote: > On Mon, Jul 21, 2025 at 10:41:33AM +0200, David Marchand wrote: > > On Fri, Jul 18, 2025 at 4:34 PM Bruce Richardson > > wrote: > > > +struct eal_init_args { > > > + /* define a struct member for each EAL option, member name

Re: [PATCH v2] doc: no longer support end of life CentOS versions

2025-07-21 Thread David Marchand
On Wed, Nov 20, 2024 at 12:09 AM Stephen Hemminger wrote: > > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream. > Both CentOS 7 and 8 are now end of life (EOL). > > CentOS Linux 7 EOL: 2024-06-30 > CentOS Linux 8 EOL: 2021-12-31 > CentOS Stream 8 EOL:

Re: [PATCH v2] doc: no longer support end of life CentOS versions

2025-07-21 Thread Kevin Traynor
On 19/11/2024 23:09, Stephen Hemminger wrote: > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream. > Both CentOS 7 and 8 are now end of life (EOL). > > CentOS Linux 7 EOL: 2024-06-30 > CentOS Linux 8 EOL: 2021-12-31 > CentOS Stream 8 EOL: 2024-05-31 > > Upd

Re: 回复: [PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Thomas Monjalon
21/07/2025 14:13, Sunyang Wu: > Hi, Thomas: > Thanks for your note. The main purpose of this modification is to align the > handling logic with the "disable" functions, > aiming to enhance the overall consistency and maintainability of the code. > > Previously, the handling of failure scenarios i

回复: [PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Sunyang Wu
Hi, Thomas: Thanks for your note. The main purpose of this modification is to align the handling logic with the "disable" functions, aiming to enhance the overall consistency and maintainability of the code. Previously, the handling of failure scenarios in the "enable" related logic differed fro

Re: [PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Thomas Monjalon
21/07/2025 13:51, Sunyang Wu: > The values of the promiscuous and allmulticast variables > are set after calling the driver, according to the return value. > > Fixes: 400d75818266 ("ethdev: check device promiscuous state") > de5ccf0775ae ("ethdev:do nothing if all-multicast mode is applied > again

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Thomas Monjalon
21/07/2025 13:46, Ivan Malov: > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > + mlx5 maintainers > > > > Thank you for the patch. > > > > Could you please include other PMD maintainers (or other maintainers, > > depending on changed code) > > in the future patches? > > There is a script whi

[PATCH] ethdev: keep promiscuous/allmulti value before enabling

2025-07-21 Thread Sunyang Wu
The values of the promiscuous and allmulticast variables are set after calling the driver, according to the return value. Fixes: 400d75818266 ("ethdev: check device promiscuous state") de5ccf0775ae ("ethdev:do nothing if all-multicast mode is applied again") Cc: sta...@dpdk.org Signed-off-by: Sun

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Ivan Malov
On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: + mlx5 maintainers Thank you for the patch. Could you please include other PMD maintainers (or other maintainers, depending on changed code) in the future patches? There is a script which automatically adds maintainers while sending a patch. It is

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-21 Thread Khadem Ullah
Hi Dariusz, Thanks for the feedback. Agreed, this check only papers over a deeper issue with multi-process lifecycle in ethdev. If the primary process exits after freeing ethdev data, all subsequent PMD-level calls (e.g., dev_infos_get) in secondary are inherently unsafe due to dangling pointers.

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
+ mlx5 maintainers Thank you for the patch. Could you please include other PMD maintainers (or other maintainers, depending on changed code) in the future patches? There is a script which automatically adds maintainers while sending a patch. It is described in: https://doc.dpdk.org/guides/contr

[PATCH] net/ice: fix segfault in secondary process by validating dev_private pointer

2025-07-21 Thread Khadem Ullah
In secondary processes, accessing 'dev->data->dev_private' directly can cause a segmentation fault if the primary process has exited or the shared memory is unavailable. This patch adds a check for dev/data/dev_private and uses rte_mem_virt2phy to ensure the pointer is still valid. Fixes: 690175e

Re: [PATCH v7 7/8] trace: add PMU

2025-07-21 Thread Thomas Monjalon
21/07/2025 12:24, Tomasz Duszynski: > > On Fri, Jun 27, 2025 at 5:41 PM Tomasz Duszynski > > wrote: > > > > > > In order to profile app, one needs to store significant amount of samples > > > somewhere for an analysis later on. > > > Since trace library supports storing data in a CTF format, > >

Re: [PATCH v2] doc: update kernel version requirement

2025-07-21 Thread Kevin Traynor
On 10/04/2025 16:20, Stephen Hemminger wrote: > The 4.19 kernel version was end of life in December 2024. > Update to 5.4 and also add better description of what "not supported" > means in this case. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Brørup > --- > v2 - better wording > >

Re: [PATCH v7 7/8] trace: add PMU

2025-07-21 Thread Tomasz Duszynski
> On Fri, Jun 27, 2025 at 5:41 PM Tomasz Duszynski > wrote: > > > > In order to profile app, one needs to store significant amount of samples > > somewhere for an analysis later on. > > Since trace library supports storing data in a CTF format, > > lets take advantage of that and add a dedicated

Re: [PATCH] maintainers: update for dlb2

2025-07-21 Thread Thomas Monjalon
> > Subject: [PATCH] maintainers: update for dlb2 > > > > Add myself as maintainer for dlb2. > > > > Signed-off-by: Tirthendu Sarkar > Acked-by: Pravin Pathak Applied, thanks.

Re: [PATCH] maintainers: update for ethdev library

2025-07-21 Thread Thomas Monjalon
15/07/2025 17:10, Ferruh Yigit: > On 7/11/2025 3:43 PM, Thomas Monjalon wrote: > > Ferruh Yigit has no time this year for ethdev maintenance. > > > > Signed-off-by: Thomas Monjalon > > --- > > MAINTAINERS | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2025-07-21 Thread Thomas Monjalon
14/07/2025 08:38, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 25.07 release notes. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2025-07-21 Thread Thomas Monjalon
15/07/2025 07:57, Yu Jiang: > Add tested Intel platforms with Intel NICs to v25.07 release note. > > Signed-off-by: Yu Jiang Applied, thanks.

Re: [PATCH v2] net/ice: updated latest recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 12:48, Bruce Richardson: > On Fri, Jul 18, 2025 at 10:00:08AM +0800, hailinx wrote: > > Signed-off-by: hailinx > > --- > > doc/guides/nics/ice.rst | 23 +-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > Acked-by: Bruce Richardson Applied, thanks.

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 12:51, Bruce Richardson: > On Thu, Jul 17, 2025 at 02:16:03PM +0800, hailinx wrote: > > Signed-off-by: hailinx > > --- > Acked-by: Bruce Richardson Applied, thanks.

[PATCH v3] mailmap: add new email to DPDK

2025-07-21 Thread Pravin Pathak
Adding new mail for DPDK contribution Signed-off-by: Pravin Pathak --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index c7d55c7386..ca677c1c67 100644 --- a/.mailmap +++ b/.mailmap @@ -1240,7 +1240,7 @@ Prateek Agarwal Prathisna Padmasanan

Re: [PATCH v3 5/9] eal: define the EAL parameters in argparse format

2025-07-21 Thread Bruce Richardson
On Mon, Jul 21, 2025 at 10:41:33AM +0200, David Marchand wrote: > On Fri, Jul 18, 2025 at 4:34 PM Bruce Richardson > wrote: > > +struct eal_init_args { > > + /* define a struct member for each EAL option, member name is the > > same as option name. > > +* Parameters that take an arg

Re: [PATCH v1] net/ixgbe: add nic and updated recommended matching list

2025-07-21 Thread Thomas Monjalon
18/07/2025 14:13, David Marchand: > On Thu, Jul 17, 2025 at 8:55 AM hailinx wrote: > > > > Signed-off-by: hailinx Please make sure to have your name here as Hailin Xu. > > --- > > doc/guides/nics/ixgbe.rst | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git a/do

Re: [PATCH v3 3/9] argparse: allow user-override of help printing

2025-07-21 Thread Bruce Richardson
On Mon, Jul 21, 2025 at 10:43:05AM +0200, David Marchand wrote: > On Fri, Jul 18, 2025 at 4:34 PM Bruce Richardson > wrote: > > diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c > > index d3b32c6357..e7b9bf573d 100644 > > --- a/lib/argparse/rte_argparse.c > > +++ b/lib/argpars

Re: [PATCH v3 3/9] argparse: allow user-override of help printing

2025-07-21 Thread David Marchand
On Fri, Jul 18, 2025 at 4:34 PM Bruce Richardson wrote: > diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c > index d3b32c6357..e7b9bf573d 100644 > --- a/lib/argparse/rte_argparse.c > +++ b/lib/argparse/rte_argparse.c > @@ -821,7 +821,10 @@ rte_argparse_parse(const struct rte_

Re: [PATCH v3 5/9] eal: define the EAL parameters in argparse format

2025-07-21 Thread David Marchand
On Fri, Jul 18, 2025 at 4:34 PM Bruce Richardson wrote: > +struct eal_init_args { > + /* define a struct member for each EAL option, member name is the > same as option name. > +* Parameters that take an argument e.g. -l, are char *, > +* parameters that take no options e.g.

[PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Khadem Ullah
When the primary process exits, the shared mlx5 state becomes unavailable to secondary processes. If a secondary process attempts to query device information (e.g., via testpmd), a NULL dereference may occur due to missing shared data. This patch adds a check for shared context availability and fa