RE: [PATCH] event/eth_tx: prefetch mbuf headers

2025-07-09 Thread Naga Harish K, S V
> -Original Message- > From: Mattias Rönnblom > Sent: Monday, July 7, 2025 5:27 PM > To: Naga Harish K, S V ; Mattias Rönnblom > ; dev@dpdk.org > Cc: Jerin Jacob ; Peter Nilsson > > Subject: Re: [PATCH] event/eth_tx: prefetch mbuf headers > > On 2025-07-07 11:00, Naga Harish K, S V wro

[PATCH v5 14/14] net/sxe: add Solve compilation problems.

2025-07-09 Thread Jie Liu
Add Fix compiling issues. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_compat_version.h | 1 - drivers/net/sxe/base/sxe_hw.c | 21 drivers/net/sxe/base/sxe_offload_common.c | 1 - drivers/net/sxe/base/sxe_queue_common.c | 3 +- drivers/net/sxe/base/sxe_rx_com

[PATCH v5 12/14] net/sxe: add simd function

2025-07-09 Thread Jie Liu
Add simd function. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_queue_common.c | 52 +- drivers/net/sxe/base/sxe_rx_common.c| 125 - drivers/net/sxe/meson.build | 9 + drivers/net/sxe/pf/sxe.h| 3 + drivers/net/sxe/pf/sxe_vec_common.h | 315 +++

[PATCH v5 11/14] net/sxe: add custom cmd led ctrl

2025-07-09 Thread Jie Liu
Add custom cmd led ctrl. Signed-off-by: Jie Liu --- drivers/net/sxe/include/sxe/sxe_cli.h | 218 drivers/net/sxe/include/sxe/sxe_ioctl.h | 21 +++ drivers/net/sxe/meson.build | 2 + drivers/net/sxe/pf/sxe_main.c | 3 + drivers/net/sxe/sxe_tes

[PATCH v5 10/14] net/sxe: add xstats function

2025-07-09 Thread Jie Liu
Add xstats function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build| 1 + drivers/net/sxe/pf/sxe.h | 2 + drivers/net/sxe/pf/sxe_main.c | 2 + drivers/net/sxe/pf/sxe_stats.c | 577 + drivers/net/sxe/pf/sxe_stats.h | 71 5 files chang

[PATCH v5 09/14] net/sxe: support ptp

2025-07-09 Thread Jie Liu
Add ptp module. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/sxe.h | 9 ++ drivers/net/sxe/pf/sxe_ptp.c | 209 +++ drivers/net/sxe/pf/sxe_ptp.h | 26 + 4 files changed, 245 insertions(+) create mode 100644 drivers

[PATCH v5 08/14] net/sxe: add dcb function

2025-07-09 Thread Jie Liu
Add dcb function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/rte_pmd_sxe.h| 2 + drivers/net/sxe/pf/sxe.h| 2 + drivers/net/sxe/pf/sxe_dcb.c| 944 drivers/net/sxe/pf/sxe_dcb.h

[PATCH v5 07/14] net/sxe: support rss offload

2025-07-09 Thread Jie Liu
Support rss offload. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 11 +- drivers/net/sxe/pf/sxe.h | 2 + drivers/net/sxe/pf/sxe_offload.c | 300 +- drivers/net/sxe/pf/sxe_offload.h | 33 +++ 4 files changed, 340

[PATCH v5 06/14] net/sxe: add filter function

2025-07-09 Thread Jie Liu
Add filter function. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe.h| 4 + drivers/net/sxe/pf/sxe_filter.c | 191 drivers/net/sxe/pf/sxe_filter.h | 29 + drivers/net/sxe/pf/sxe_main.c | 1 + 4 files changed, 225 insertions(+) diff --git a/

[PATCH v5 05/14] net/sxe: support vlan filter

2025-07-09 Thread Jie Liu
Support vlan filter. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 4 + drivers/net/sxe/pf/sxe.h | 5 +- drivers/net/sxe/pf/sxe_filter.c | 277 ++ drivers/net/sxe/pf/sxe_filter.h | 13 + drivers/net/sxe/pf/sxe

[PATCH v5 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function

2025-07-09 Thread Jie Liu
Add link, flow ctrl, mac ops, mtu ops function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build| 3 + drivers/net/sxe/pf/sxe.h | 11 + drivers/net/sxe/pf/sxe_ethdev.c| 443 +- drivers/net/sxe/pf/sxe_filter.c| 279 + drivers/net/sxe/pf/sxe_f

[PATCH v5 01/14] net/sxe: add base driver directory and doc

2025-07-09 Thread Jie Liu
Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS | 6 +++ doc/guides/nics/features/sxe.ini| 78 + doc/guides/nics/features/sxe_vf.ini

[PATCH net] net/vmxnet3: fix mapping of mempools to queues

2025-07-09 Thread Ronak Doshi
Index bitmask variable used was uint8_t, too small for bitmask with 9 or more queues. This patch changes it to uint16_t for now, to be same as in the Vmxnet3_MemoryRegion structure. This way txQueues can be lesser than rxQueues and have correct mapping of memory regions. Also, the patch fixes memo

DPDK release candidate 25.07-rc3

2025-07-09 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v25.07-rc3 There are 86 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_25_07.html Please test and report new issues on https://bugs.dpdk.org Only docu

Re: Secondary process access control mechanism

2025-07-09 Thread Stephen Hemminger
On Wed, 9 Jul 2025 20:02:30 +0200 Morten Brørup wrote: > Are there any access control mechanisms to govern what a secondary process > can do to a primary process? > > Let's say I'm running a primary process, and want to allow only authorized > secondary processes to attach to it. No unauthoriz

Re: [PATCH v3] doc: remove known issues

2025-07-09 Thread Thomas Monjalon
11/04/2025 18:15, Nandini Persad: > I have uploaded all these known issues into Bugzilla, > so they are not needed here anymore. > > Signed-off-by: Nandini Persad Applied, thanks.

Re: [PATCH v2 2/2] dts: rewrite dts rst

2025-07-09 Thread Thomas Monjalon
25/06/2025 06:07, Patrick Robb: > Applied to next-dts, thanks Dean. I'm almost sure it has overriden some doc added recently by Nicholas Pratte. Anyway it is too difficult to understand what is changed in this series, because there are too many unrelated changes. I prefer not pulling this series

Re: [PATCH] examples/ipsec-secgw: fix number of queue pairs

2025-07-09 Thread Thomas Monjalon
09/07/2025 10:23, Volodymyr Fialko: > Fix a mismatch between the signature of the cryptodevs_init() function > and the arguments passed to it during the call. This caused incorrect > initialization of queue pairs in ipsec-secgw example. > > Fixes: 253265f8fb97 ("examples/ipsec-secgw: reduce queues

Re: [PATCH] examples/flow_filtering: add re-route to kernel snippet

2025-07-09 Thread Thomas Monjalon
21/05/2025 09:27, Shani Peretz: > The snippet enables direct packet re-routing to kernel by using > the new RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL action. > > Added support for snippet-specific configurations: > * port configuration: set promiscuous mode / flow isolation mode > * Flow configurati

Secondary process access control mechanism

2025-07-09 Thread Morten Brørup
Are there any access control mechanisms to govern what a secondary process can do to a primary process? Let's say I'm running a primary process, and want to allow only authorized secondary processes to attach to it. No unauthorized secondary processes should be able to attach to it. I assume t

Re: [RFC v2 01/12] ethdev: allow start/stop from secondary process

2025-07-09 Thread Khadem Ullah
Does that means that the RSS of the secondary application can be also applied to the primary application, or in case of multiple instances on the same interface ? Best, Khadem On Wed, Jul 9, 2025, 22:36 Stephen Hemminger wrote: > Before this patch if secondary process called start/stop > it wou

Re: [PATCH v8 1/1] app/testpmd: canonicalize short PCI name format

2025-07-09 Thread Stephen Hemminger
On Tue, 8 Jul 2025 11:37:40 +0300 Shani Peretz wrote: > when providing short format PCI device names in devargs > (e.g. "08:00:0") it is converted and stored as long format. > however when attach_port is called from testpmd, the user might > provide a short format, which will be passed to find_de

[RFC v2 12/12] pdump: mark API and application as deprecated

2025-07-09 Thread Stephen Hemminger
When the pdump application is run print a warning. Add release note about deprecation and mark the API's as deprecated. Signed-off-by: Stephen Hemminger pdump build deprecated --- app/pdump/main.c | 3 +++ app/pdump/meson.build| 1 + app/test-pmd/meson.buil

[RFC v2 11/12] app/dumpcap: use port mirror instead of pdump

2025-07-09 Thread Stephen Hemminger
Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 443 +--- app/dumpcap/meson.build | 2 +- 2 files changed, 373 insertions(+), 72 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c i

[RFC v2 10/12] app/testpmd: support for port mirroring

2025-07-09 Thread Stephen Hemminger
Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 129 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd/me

[RFC v2 09/12] test: add tests for ethdev mirror

2025-07-09 Thread Stephen Hemminger
Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 285 ++ 2 files changed, 286 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git a

[RFC v2 08/12] pcapng: make queue optional

2025-07-09 Thread Stephen Hemminger
The queue field is optional in pcapng received packet. Use UINT16_MAX as flag value. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 7 --- lib/pcapng/rte_pcapng.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte

[RFC v2 07/12] pcapng: split packet copy from header insertion

2025-07-09 Thread Stephen Hemminger
In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git a

[RFC v2 06/12] ethdev: add port mirroring feature

2025-07-09 Thread Stephen Hemminger
This adds new feature port mirroring to the ethdev layer. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 1 + lib/ethdev/ethdev_driver.h | 6 + lib/ethdev/ethdev_private.c | 58 +- lib/ethdev/ethdev_private.h | 3 + lib/ethdev/ethdev_trace.h

[RFC v2 05/12] mbuf: add dynamic flag for use by port mirroring

2025-07-09 Thread Stephen Hemminger
Add names for new port mirror fields. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_dyn.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/mbuf/rte_mbuf_dyn.h b/lib/mbuf/rte_mbuf_dyn.h index 865c90f579..72a31b22b3 100644 --- a/lib/mbuf/rte_mbuf_dyn.h +++ b/lib/mbuf/rte_m

[RFC v2 03/12] net/ring: allow lockfree transmit if ring supports it

2025-07-09 Thread Stephen Hemminger
Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index

[RFC v2 04/12] net/ring: add new devargs for dumpcap use

2025-07-09 Thread Stephen Hemminger
Need ability to allow process like dumpcap to make a ring ethdev with a pre-existing ring. Do this via devargs so it can work with hotplug. It looked like the API rte_eth_from_ring() would work for this, but it doesn't do the right thing. Add argument to ring PMD creation to force packets going in

[RFC v2 02/12] test: add test for hotplug and secondary process operations

2025-07-09 Thread Stephen Hemminger
Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondar

[RFC v2 01/12] ethdev: allow start/stop from secondary process

2025-07-09 Thread Stephen Hemminger
Before this patch if secondary process called start/stop it would only impact the secondary process, the ethdev on the primary process was not started. With this patch, when start/stop is called from secondary, it calls the primary and does the operation there. The design is generic, and we can la

[RFC v2 00/12] Packet capture using port mirroring

2025-07-09 Thread Stephen Hemminger
This is a rework of how packet capture is done in DPDK. The existing mechanism using callbacks has a number of problems: it won't work when packets are sent and received in secondary process because callbacks only function in the primary process; pdump requires that the main program "opt-in" to hav

Re: [PATCH v4 14/14] net/sxe: add Solve compilation problems.

2025-07-09 Thread Stephen Hemminger
On Wed, 9 Jul 2025 04:43:14 -0400 Jie Liu wrote: > Add Fix compiling issues. > > Signed-off-by: Jie Liu > --- Please integrate these into earlier patches. Overall will not go further in review and build tests until driver passes CI build tests.

RE: Intel i40e rx burst API non-conformance?

2025-07-09 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 9 July 2025 17.28 > > On Wed, Jul 09, 2025 at 04:59:51PM +0200, Morten Brørup wrote: > > Looking at the i40e driver source code, I think it doesn't conform to > the API when requesting small bursts. > > > > Let's say t

Re: [PATCH] examples/flow_filtering: fix make clean

2025-07-09 Thread Thomas Monjalon
> > make clean is unable to delete build directory because *.o files are not > > removed. > > > > The other way to fix this would be to add all the c files into SRCS-y. > > > > Signed-off-by: Tanzeel Ahmed > > I checked and looks good on my side Applied with fixes line, thanks.

Re: Intel i40e rx burst API non-conformance?

2025-07-09 Thread Bruce Richardson
On Wed, Jul 09, 2025 at 04:59:51PM +0200, Morten Brørup wrote: > Looking at the i40e driver source code, I think it doesn't conform to the API > when requesting small bursts. > > Let's say the hardware has received 31 packets. > rte_eth_rx_burst(...,16) will return 16 packets and leave 15 in the

[PATCH v2] test_bbdev: enable to be compiled on Windows

2025-07-09 Thread Andre Muezerie
This patch fixes a few issues which were preventing this test from getting compiled on Windows: 1) VLAs were removed: Variable Length Arrays are not supported by MSVC. Where possible constant C arrays were used. Where that approach was not possible alloca() was called instead. 2) rte_os_shim is i

Intel i40e rx burst API non-conformance?

2025-07-09 Thread Morten Brørup
Looking at the i40e driver source code, I think it doesn't conform to the API when requesting small bursts. Let's say the hardware has received 31 packets. rte_eth_rx_burst(...,16) will return 16 packets and leave 15 in the driver's staging buffer (which has capacity for 32 packets). Time passe

Re: [PATCH] examples/ntb: fix the heap allocation check

2025-07-09 Thread Thomas Monjalon
21/05/2025 19:23, Bing Zhao: > In some rare case, the libc memory heap allocation may fail and > return NULL pointer. Before accessing the memory via the pointer, > the NULL pointer check should be done to ensure the code locates > in the safe side and no crash. > > Some newer GCC version will che

Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-09 Thread Thomas Monjalon
09/07/2025 15:30, Burakov, Anatoly: > On 7/8/2025 9:09 AM, Maayan Kashani wrote: > > Device was started but not stopped on exit signal. > > Added port stop and close on exit. > > > > Fixes: af75078fece3 ("first public release") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Maayan Kashani > > --

Re: [PATCH] examples/symmetric_mp: log/ignore promiscuous fail

2025-07-09 Thread Thomas Monjalon
20/05/2025 20:37, mamcg...@microsoft.com: > From: Matthew G McGovern > > The example apps have a few different failure modes when enabling promiscuous > mode: > > - testpmd will warn about the failure and continue. > > - l3fwd has a flag '-P' to explicitly require promiscuous mode. > > - symm

RE: [PATCH] net: support VLAN stacking packet type parsing

2025-07-09 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 9 July 2025 13.44 > > On Tue, Jul 08, 2025 at 04:15:36PM +0100, Bruce Richardson wrote: > > On Tue, Jul 08, 2025 at 05:07:05PM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.c

Re: [PATCH v1 1/1] net/iavf: fix order of inclusion in vector code

2025-07-09 Thread Thomas Monjalon
09/07/2025 15:28, Bruce Richardson: > On Wed, Jul 09, 2025 at 02:06:29PM +0100, Anatoly Burakov wrote: > > IAVF driver does not support 16-byte descriptors (because there is no PF > > that can support a VF using 16-byte descriptor), but if IAVF is built with > > a flag that enables 16-byte descript

Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-09 Thread Burakov, Anatoly
On 7/8/2025 9:09 AM, Maayan Kashani wrote: Device was started but not stopped on exit signal. Added port stop and close on exit. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: Proposal: AI-Based Code Review for DPDK

2025-07-09 Thread Aaron Conole
Aaron Conole writes: > Jerin Jacob writes: > >> On Thu, Jun 19, 2025 at 7:42 PM Ori Kam wrote: >>> >>> >>> Nice idea, >>> Some comments: >>> >>> >>> 1. The first link is broken for me. >> >> Yes. https://github.com/DPDK/dpdk-ai-code-review is the proposed name >> of the repository. It is not c

Re: [PATCH v1 1/1] net/iavf: fix order of inclusion in vector code

2025-07-09 Thread Bruce Richardson
On Wed, Jul 09, 2025 at 02:06:29PM +0100, Anatoly Burakov wrote: > IAVF driver does not support 16-byte descriptors (because there is no PF > that can support a VF using 16-byte descriptor), but if IAVF is built with > a flag that enables 16-byte descriptors, this flag is then propagated > through

[PATCH v1 1/1] net/iavf: fix order of inclusion in vector code

2025-07-09 Thread Anatoly Burakov
IAVF driver does not support 16-byte descriptors (because there is no PF that can support a VF using 16-byte descriptor), but if IAVF is built with a flag that enables 16-byte descriptors, this flag is then propagated through the inclusion chain in certain cases, because IAVF includes common vector

RE: [PATCH] doc: announce changes in structure alignments for UBSan

2025-07-09 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 9 July 2025 14.40 > > As part of the effort to limit undefined behaviors in DPDK code, some > structure alignments revealed not to be accurate enough. > At the moment two structures have been identified but others may be

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-09 Thread Bruce Richardson
On Wed, Jul 09, 2025 at 02:30:42PM +0200, David Marchand wrote: > Hi Bruce, > > On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson > wrote: > > > > This RFC is a second, more complete, prototype of one approach we may > > want to take to help improve management of EAL cmdline arguments. > > > > BACK

Re: [PATCH] doc: announce changes in structure alignments for UBSan

2025-07-09 Thread Bruce Richardson
On Wed, Jul 09, 2025 at 02:40:22PM +0200, David Marchand wrote: > As part of the effort to limit undefined behaviors in DPDK code, some > structure alignments revealed not to be accurate enough. > At the moment two structures have been identified but others may be > found while running more parts o

Re: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Zhangfei Gao
On Wed, 9 Jul 2025 at 18:44, Akhil Goyal wrote: > > > On Wed, 9 Jul 2025 at 18:03, Akhil Goyal wrote: > > > > > > > On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > > > > > > > To get better performance, using async mode to replace sync mode > > > > > > > > > > > > Signed-off-by: Zhangf

[PATCH] doc: announce changes in structure alignments for UBSan

2025-07-09 Thread David Marchand
As part of the effort to limit undefined behaviors in DPDK code, some structure alignments revealed not to be accurate enough. At the moment two structures have been identified but others may be found while running more parts of DPDK with UBSan. Though the calling code can explicitly request align

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-09 Thread David Marchand
Hi Bruce, On Tue, Jul 8, 2025 at 7:21 PM Bruce Richardson wrote: > > This RFC is a second, more complete, prototype of one approach we may > want to take to help improve management of EAL cmdline arguments. > > BACKGROUND: > - The first problem that led to this work was that of providing a > wa

Re: [PATCH] net: support VLAN stacking packet type parsing

2025-07-09 Thread Bruce Richardson
On Tue, Jul 08, 2025 at 04:15:36PM +0100, Bruce Richardson wrote: > On Tue, Jul 08, 2025 at 05:07:05PM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Tuesday, 8 July 2025 12.16 > > > > > > On Tue, Jul 08, 2025 at 12:00:42AM +0200, Morten Br

Re: [PATCH v2] net/mlx5: fix out of order completions in ordinary Rx burst

2025-07-09 Thread Raslan Darawsheh
Hi, On 08/07/2025 1:46 PM, Viacheslav Ovsiienko wrote: The existing Rx burst routines suppose the completions in CQ arrive in order and address the WQEs in receiving queue in order. That is not true for the shared RQs, CQEs can arrive in out of order and to address appropriate WQE we should fet

RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> On Wed, 9 Jul 2025 at 18:03, Akhil Goyal wrote: > > > > > On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > > > > > To get better performance, using async mode to replace sync mode > > > > > > > > > > Signed-off-by: Zhangfei Gao > > > > > --- > > > > > doc/guides/compressdevs/uadk.rst

[PATCH] net/mlx5: fix panic for non template age rules flush

2025-07-09 Thread Maayan Kashani
When a user creates a non-template rule with both age and counter actions, both actions share the same counter. If a flow flush occurs, the rule is destroyed and the counter is released. However, the age sampling callback may still access the counter after it has been freed, leading to a panic on a

Re: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Zhangfei Gao
On Wed, 9 Jul 2025 at 18:03, Akhil Goyal wrote: > > > On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > > > To get better performance, using async mode to replace sync mode > > > > > > > > Signed-off-by: Zhangfei Gao > > > > --- > > > > doc/guides/compressdevs/uadk.rst | 15

Re: [PATCH] bus/auxiliary: fix auxiliary device port destruction

2025-07-09 Thread Thomas Monjalon
07/07/2025 12:06, Gregory Etelson: > DPDK auxiliary bus first creates a list of known devices in the > `auxiliary_bus.device_list` and then tries to attach a driver to each > device on that list. > > If the driver attachment has failed, a device will remain on the list. > > The device destruction

RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > > > To get better performance, using async mode to replace sync mode > > > > > > Signed-off-by: Zhangfei Gao > > > --- > > > doc/guides/compressdevs/uadk.rst | 15 +++ > > > drivers/compress/uadk/meson.build | 4 +-

Re: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Zhangfei Gao
On Wed, 9 Jul 2025 at 15:19, Akhil Goyal wrote: > > > To get better performance, using async mode to replace sync mode > > > > Signed-off-by: Zhangfei Gao > > --- > > doc/guides/compressdevs/uadk.rst | 15 +++ > > drivers/compress/uadk/meson.build | 4 +- > > drivers/co

Re: [PATCH v2] ci: check C++ headers with clang

2025-07-09 Thread David Marchand
On Thu, Jul 3, 2025 at 10:20 AM David Marchand wrote: > > If not passing an explicit compiler for C++, meson uses c++ which > defaults to /usr/bin/g++ on a Ubuntu system. > Explicitly choose which compiler to use for C++. > > Signed-off-by: David Marchand > Acked-by: Aaron Conole Applied, thank

Re: [PATCH] net/virtio: revert Tx free threshold fix

2025-07-09 Thread David Marchand
On Wed, Jul 9, 2025 at 3:34 AM Hengqi Chen wrote: > > On Tue, Jul 8, 2025 at 10:23 PM David Marchand > wrote: > > > > This fix introduced a performance regression. > > > > The problem is under investigation, but we are too close to the release > > (and the virtio/vhost maintainer is not available

RE: [PATCH v2 1/3] net/rnp: add check firmware respond info

2025-07-09 Thread 11
Hi Stephen, Thank you for your review. Regarding the changes to the rte_bitops API, should these updates be implemented in V3 or deferred to the next release version? Regards Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年6月30日 23:07 > To: Wenbo Cao > Cc: Ferruh Yigi

[PATCH v4 14/14] net/sxe: add Solve compilation problems.

2025-07-09 Thread Jie Liu
Add Fix compiling issues. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_compat_version.h | 1 - drivers/net/sxe/base/sxe_hw.c | 21 drivers/net/sxe/base/sxe_offload_common.c | 1 - drivers/net/sxe/base/sxe_queue_common.c | 3 +- drivers/net/sxe/base/sxe_rx_com

[PATCH v4 12/14] net/sxe: add simd function

2025-07-09 Thread Jie Liu
Add simd function. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_queue_common.c | 52 +- drivers/net/sxe/base/sxe_rx_common.c| 125 - drivers/net/sxe/meson.build | 9 + drivers/net/sxe/pf/sxe.h| 3 + drivers/net/sxe/pf/sxe_vec_common.h | 315 +++

[PATCH v4 11/14] net/sxe: add custom cmd led ctrl

2025-07-09 Thread Jie Liu
Add custom cmd led ctrl. Signed-off-by: Jie Liu --- drivers/net/sxe/include/sxe/sxe_cli.h | 218 drivers/net/sxe/include/sxe/sxe_ioctl.h | 21 +++ drivers/net/sxe/meson.build | 2 + drivers/net/sxe/pf/sxe_main.c | 3 + drivers/net/sxe/sxe_tes

[PATCH v4 10/14] net/sxe: add xstats function

2025-07-09 Thread Jie Liu
Add xstats function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build| 1 + drivers/net/sxe/pf/sxe.h | 2 + drivers/net/sxe/pf/sxe_main.c | 2 + drivers/net/sxe/pf/sxe_stats.c | 577 + drivers/net/sxe/pf/sxe_stats.h | 71 5 files chang

[PATCH v4 08/14] net/sxe: add dcb function

2025-07-09 Thread Jie Liu
Add dcb function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/rte_pmd_sxe.h| 2 + drivers/net/sxe/pf/sxe.h| 2 + drivers/net/sxe/pf/sxe_dcb.c| 944 drivers/net/sxe/pf/sxe_dcb.h

[PATCH v4 07/14] net/sxe: support rss offload

2025-07-09 Thread Jie Liu
Support rss offload. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 11 +- drivers/net/sxe/pf/sxe.h | 2 + drivers/net/sxe/pf/sxe_offload.c | 300 +- drivers/net/sxe/pf/sxe_offload.h | 33 +++ 4 files changed, 340

[PATCH v4 09/14] net/sxe: support ptp

2025-07-09 Thread Jie Liu
Add ptp module. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/sxe.h | 9 ++ drivers/net/sxe/pf/sxe_ptp.c | 209 +++ drivers/net/sxe/pf/sxe_ptp.h | 26 + 4 files changed, 245 insertions(+) create mode 100644 drivers

[PATCH v4 06/14] net/sxe: add filter function

2025-07-09 Thread Jie Liu
Add filter function. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe.h| 4 + drivers/net/sxe/pf/sxe_filter.c | 191 drivers/net/sxe/pf/sxe_filter.h | 29 + drivers/net/sxe/pf/sxe_main.c | 1 + 4 files changed, 225 insertions(+) diff --git a/

[PATCH v4 05/14] net/sxe: support vlan filter

2025-07-09 Thread Jie Liu
Support vlan filter. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 4 + drivers/net/sxe/pf/sxe.h | 5 +- drivers/net/sxe/pf/sxe_filter.c | 277 ++ drivers/net/sxe/pf/sxe_filter.h | 13 + drivers/net/sxe/pf/sxe

[PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function

2025-07-09 Thread Jie Liu
Add link, flow ctrl, mac ops, mtu ops function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build| 3 + drivers/net/sxe/pf/sxe.h | 11 + drivers/net/sxe/pf/sxe_ethdev.c| 443 +- drivers/net/sxe/pf/sxe_filter.c| 279 + drivers/net/sxe/pf/sxe_f

[PATCH v4 1/2] net/sxe: add base driver directory and doc

2025-07-09 Thread Jie Liu
Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS | 6 +++ doc/guides/nics/features/sxe.ini| 78 + doc/guides/nics/features/sxe_vf.ini

[PATCH] net/i40e: support GTP in tunnel parameters parsing

2025-07-09 Thread Yijun Geng
i40e I40E_TX_OFFLOAD_MASK indicates that all tunnel types are supported, but gtp type is not considered in i40e_parse_tunneling_params(), tunneling parameter: L4TUNLEN is not set. During TX checksum offloading, the incorrect L3 header offset was used when calculating the inner IP checksum, resulti

[PATCH] examples/ipsec-secgw: fix number of queue pairs

2025-07-09 Thread Volodymyr Fialko
Fix a mismatch between the signature of the cryptodevs_init() function and the arguments passed to it during the call. This caused incorrect initialization of queue pairs in ipsec-secgw example. Fixes: 253265f8fb97 ("examples/ipsec-secgw: reduce queues for event lookaside") Cc: sta...@dpdk.org Si

RE: [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit

2025-07-09 Thread Konstantin Ananyev
> -Original Message- > From: David Marchand > Sent: Tuesday, July 8, 2025 1:28 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Bruce Richardson ; Gage Eads > ; Olivier Matz > ; Honnappa Nagarahalli > Subject: [PATCH v3 09/18] stack: fix unaligned accesses on 128-bit > > Caught by UBSan:

Re: [PATCH] net/mlx5: fix the queue length checking

2025-07-09 Thread Raslan Darawsheh
Hi, On 09/07/2025 7:00 AM, Bing Zhao wrote: In the new consecutive memory mode of Tx queues allocation, the needed WQ length is calculated via txq_calc_wqebb_cnt(). This function is used both in Verbs and Devx modes, but in the Devx queue creation, the actual length is re-calculated / adjusted

Re: [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK

2025-07-09 Thread Bruce Richardson
On Tue, Jul 08, 2025 at 11:41:01AM -0700, Stephen Hemminger wrote: > On Tue, 8 Jul 2025 17:20:34 + > Bruce Richardson wrote: > > > This RFC is a second, more complete, prototype of one approach we may > > want to take to help improve management of EAL cmdline arguments. > > > > BACKGROUND:

Re: [PATCH v3] net/mlx5: remove use of sizeof(rte_v128u32_t)

2025-07-09 Thread Dariusz Sosnowski
Thank you for addressing the comments. On Tue, Jul 08, 2025 at 08:11:56AM -0700, Andre Muezerie wrote: > When compiling with MSVC the error below is hit: > > drivers\net\mlx5\mlx5_tx.h(1148): error C2065: 'rte_v128u32_t': > undeclared identifier > > The reference to rte_v128u32_t (in code an

RE: [EXTERNAL] [PATCH v5 1/2] compress/uadk: use async mode to replace sync mode

2025-07-09 Thread Akhil Goyal
> To get better performance, using async mode to replace sync mode > > Signed-off-by: Zhangfei Gao > --- > doc/guides/compressdevs/uadk.rst | 15 +++ > drivers/compress/uadk/meson.build | 4 +- > drivers/compress/uadk/uadk_compress_pmd.c | 94 ++- >