Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-07-06 Thread Hengqi Chen
Hi Yu, On Fri, Jul 4, 2025 at 7:29 PM Jiang, YuX wrote: > > Hi Hengqi, > > Can you help to check the ticket: https://bugs.dpdk.org/show_bug.cgi?id=1747? > The perf drop is caused by your patch. Thanks so much. > The `[Expect Result]` section contains a non-zero `TX-errors` counter, is this expe

Re: [PATCH v3] test/argparse: change initialization to workaround LTO

2025-07-06 Thread fengchengwen
Acked-by: Chengwen Feng On 2025/7/1 23:41, Stephen Hemminger wrote: > When compiled with Link Time Optimization, the existing code > generated an error, because the compiler was unable to intuit > that there was space in the flexible array. > > In function ‘test_argparse_copy’, > inlined fro

[PATCH v1 6/6] net/zxdh: add support I510/511 PF device ID

2025-07-06 Thread Junlong Wang
add support I510/511 pf device ID. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_common.c | 2 +- drivers/net/zxdh/zxdh_ethdev.c | 80 +++--- drivers/net/zxdh/zxdh_ethdev.h | 5 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 5 ++ drivers/net/zxdh/zxdh_msg

[PATCH v1 5/6] net/zxdh: add support VLAN TPID set ops

2025-07-06 Thread Junlong Wang
provided vlan tpid set ops implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 1 + drivers/net/zxdh/zxdh_ethdev_ops.c | 37 ++ drivers/net/zxdh/zxdh_ethdev_ops.h | 1 + drivers/net/zxdh/zxdh_msg.c| 31 ++

[PATCH v1 3/6] net/zxdh: fix some VLAN related issues

2025-07-06 Thread Junlong Wang
modify some vlan related issues, which were discovered during the testing process. Fixes: b4f996b7fcf6 ("net/zxdh: optimize VLAN filter and offload") Cc: sta...@dpdk.org Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 9 - drivers/net/zxdh/zxdh_ethdev_ops.c | 2 +-

[PATCH v1 4/6] net/zxdh: fix RSS related issues

2025-07-06 Thread Junlong Wang
modify rss related issues in testing process. Modify the comments of the maintainers. Fixes: 01acc23bab13 ("net/zxdh: optimize RSS operations") Cc: sta...@dpdk.org Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_ethdev_ops.c | 64

[PATCH v1 2/6] net/zxdh: fix issues related to MAC configuration

2025-07-06 Thread Junlong Wang
Fix error handling when MAC configuration fails. This is issue was discovered during internal testing. Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") Cc: sta...@dpdk.org Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 15 +++ drivers/net/zxdh/zxdh_ethdev_

[PATCH v1 1/6] net/zxdh: fix meson.build issues in compilation

2025-07-06 Thread Junlong Wang
fix meson.build issus in compilation, which caused the inability to compile in the arm64 environment. Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton") Cc: sta...@dpdk.org Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

RE: [RFC PATCH 0/5] Introduce mempool object new debug capabilities

2025-07-06 Thread Shani Peretz
> -Original Message- > From: Morten Brørup > Sent: Thursday, 19 June 2025 15:57 > To: Stephen Hemminger ; Shani Peretz > > Cc: dev@dpdk.org > Subject: RE: [RFC PATCH 0/5] Introduce mempool object new debug > capabilities > > External email: Use caution opening links or attachments > >

RE: [RFC PATCH 0/5] Introduce mempool object new debug capabilities

2025-07-06 Thread Shani Peretz
> -Original Message- > From: Stephen Hemminger > Sent: Monday, 16 June 2025 18:30 > To: Shani Peretz > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH 0/5] Introduce mempool object new debug > capabilities > > External email: Use caution opening links or attachments > > > On Mon, 16 Jun 2

Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-07-06 Thread Hengqi Chen
Hi Maxime and other maintainers, On Fri, Jul 4, 2025 at 7:57 PM Maxime Coquelin wrote: > > Hi Yu, Hengqi, > > First, thanks Yu for testing and reporting the performance degradation, > this is much appreciated! > > On 7/4/25 1:29 PM, Jiang, YuX wrote: > > Hi Hengqi, > > > > Can you help to check t

Re: [PATCH] test/argparse: fix out of bound memcpy

2025-07-06 Thread fengchengwen
Acked-by: Chengwen Feng On 2025/6/28 0:22, Stephen Hemminger wrote: > The rte_argparse API use variable length arrays for the args. > But the test was only putting space on stack for the argparse > part, not the args. This can lead to out of bounds writes. > > The bug only gets detected if DPDK

Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-07-06 Thread Hengqi Chen
Hi Yu, On Fri, Jul 4, 2025 at 7:29 PM Jiang, YuX wrote: > > Hi Hengqi, > > Can you help to check the ticket: https://bugs.dpdk.org/show_bug.cgi?id=1747? > The perf drop is caused by your patch. Thanks so much. > Thanks for the testing. Will investigate. > Best regards, > Yu Jiang > > > -Or

Re: 回复: [V5 00/18] add hinic3 pmd driver

2025-07-06 Thread Stephen Hemminger
On Mon, 7 Jul 2025 03:27:20 + "wangfeifei (J)" wrote: > -邮件原件- > 发件人: Stephen Hemminger > 发送时间: 2025年7月2日 22:56 > 收件人: Feifei Wang > 抄送: dev@dpdk.org; chenyi (CY) > 主题: Re: [V5 00/18] add hinic3 pmd driver > > On Wed, 2 Jul 2025 10:09:23 +0800 > Feifei Wang wrote: > > > From:

回复: [V5 00/18] add hinic3 pmd driver

2025-07-06 Thread wangfeifei (J)
-邮件原件- 发件人: Stephen Hemminger 发送时间: 2025年7月2日 22:56 收件人: Feifei Wang 抄送: dev@dpdk.org; chenyi (CY) 主题: Re: [V5 00/18] add hinic3 pmd driver On Wed, 2 Jul 2025 10:09:23 +0800 Feifei Wang wrote: > From: Yi Chen > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver

Re: [PATCH] net/mlx5: fix decreasing the reference count of a Tx queue

2025-07-06 Thread Raslan Darawsheh
Hi, On 03/07/2025 6:02 PM, Bing Zhao wrote: When changing the order of the Tx queues startup, the depth of the queue is compared. If not equal to the current big log2 value, next queue will be checked and the current one will be skipped for the next iteration. The mlx5_txq_get() will increase

Re: [PATCH] net/mlx5: fix inline data size adjustment for Verbs API

2025-07-06 Thread Raslan Darawsheh
Hi, On 02/07/2025 12:34 PM, Shani Peretz wrote: This fix ensures that when using Verbs for queue creation, the maximum inline data size is adjusted to prevent rejection in mlx5_calc_send_wqe() from the rdma_core library. The adjustment is achieved by reducing the Ethernet minimal inline size an

Re: [PATCH] net/mlx5: fix masked indirect age action validation

2025-07-06 Thread Raslan Darawsheh
Hi, On 01/07/2025 1:32 PM, Dariusz Sosnowski wrote: Masked indirect age flow action is not supported in actions templates. Up to this patch, this case was checked only through debug assertion. As a side effect, in a build without assertions, this lead to a segfault on the attempt to create a ta

RE: [PATCH v4 0/7] net/ena: release 2.13.0

2025-07-06 Thread Brandes, Shai
> -Original Message- > From: Stephen Hemminger > Sent: Monday, June 30, 2025 5:55 PM > To: Brandes, Shai > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v4 0/7] net/ena: release 2.13.0 > > CAUTION: This email originated from outside of the organization. Do not click > links or ope