RE: [PATCH v4] build: reduce use of AVX compiler flags

2025-06-08 Thread Varghese, Vipin
[Public] Snipped > > > When doing a build for a target that already has the instruction sets for > AVX2/AVX512 enabled, skip emitting the AVX compiler flags, or the > skylake-avx512 '-march' flags, as they are unnecessary. Instead, when the > default > flags produce the desired output, just use

RE: [PATCH v5 00/11] remove component-specific logic for AVX builds

2025-06-08 Thread Varghese, Vipin
[Public] Snipped > > > > A number of libs and drivers had special optimized AVX2 and AVX512 > > code paths for performance reasons, and these tended to have > > copy-pasted logic to build those files. Centralise that logic in the > > main drivers/ and lib/ meson.build files to avoid duplication.

RE: [PATCH] net/intel: allow fast-free to empty cache

2025-06-08 Thread Varghese, Vipin
[Public] Snipped > > > When freeing transmitted mbufs, there is no reason to send the freed > > > mbufs directly to the ring if the cache is empty - only if it is > > > zero size (in which case the cache pointer is NULL). Therefore, > > > remove the empty check and only check for a null cache poi

[PATCH v3 11/11] net/dpaa2: enable software taildrop for ordered queues

2025-06-08 Thread Gagandeep Singh
This patch adds support for software taildrop on ordered queues in the DPAA2 driver. It also enables congestion notification by default on traffic management (TM) queues, which is a prerequisite for software taildrop functionality. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_rxtx

[PATCH v4 2/2] test/dma: add functions to verify zero and one fill

2025-06-08 Thread Vidya Sagar Velumuri
Add test cases to verify zero fill and one fill Signed-off-by: Vidya Sagar Velumuri Acked-by: Amit Prakash Shukla diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 88c3d02fd6..0c67aaceb2 100644 --- a/app/test/test_dmadev.c +++ b/app/test/test_dmadev.c @@ -872,42 +872,51 @@ test

[PATCH v4 1/2] test/dma: update the sg test to verify wrap around case

2025-06-08 Thread Vidya Sagar Velumuri
Run the sg test in a loop to verify wrap around case. Total number commands submitted to be more than the number descriptors allocated to verify the scenario. Signed-off-by: Vidya Sagar Velumuri Acked-by: Amit Prakash Shukla diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 9cb

[RFC] doc: change recommendation for installation of tools on Fedora

2025-06-08 Thread Stephen Hemminger
The syntax changed with Fedora 41 and the old command is now: $ sudo dnf group install development-tools Not sure what is on RHEL 9 or later. Signed-off-by: Stephen Hemminger --- doc/guides/howto/af_xdp_dp.rst| 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- 2 files changed, 2 insertions(+)

[PATCH v3 02/11] net/dpaa2: fix shaper rate

2025-06-08 Thread Gagandeep Singh
This patch fixes the shaper rate by configuring the user given rate in bytes. Earlier driver was considering the user given rate value in bits. Fixes: ac624068ee25 ("net/dpaa2: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_tm.c | 8 +

[PATCH v3 09/11] net/dpaa2: retrieve DPNI API version at init time

2025-06-08 Thread Gagandeep Singh
From: Ioana Ciornei The list of availabla DPNI APIs depends on the DPNI API version available on a system. Retrieve the API version in the init stage and store it in the private structure so that it can be used at a later stage. Signed-off-by: Ioana Ciornei --- .mailmap

[PATCH v3 08/11] net/dpaa2: support dpmac Tx stats in xstats

2025-06-08 Thread Gagandeep Singh
From: Apeksha Gupta Added all mac counters including Tx stats buckets for packet sizes in xstats. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 20 +++- drivers/net/dpaa2/dpaa2_ethdev.h | 4 ++-- 2 files changed, 21 inserti

[PATCH v3 10/11] net/dpaa2: setup the speed cap based on the actual MAC

2025-06-08 Thread Gagandeep Singh
From: Ioana Ciornei Previously, the speed_capa field from struct rte_eth_dev_info was populated with all possible speeds that the MACs on the system could sustain. What this meant is that the bitmap of speed capability did not reflect what the MAC could do in the current circumstance. Fix this b

[PATCH v3 06/11] net/dpaa2: support dpmac counters in stats

2025-06-08 Thread Gagandeep Singh
From: Apeksha Gupta Add support of dpmac counters in xstats. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c| 118 ++-- drivers/net/dpaa2/dpaa2_ethdev.h| 12 +++ drivers/net/dpaa2/mc/dpni.c | 29 ++-

[PATCH v3 04/11] mempool/dpaa2: use unified VA to IOVA conversion

2025-06-08 Thread Gagandeep Singh
From: Jun Yang Use DPAA2_VADDR_TO_IOVA to convert va to iova for both VA and PA modes. Signed-off-by: Jun Yang --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 222 +++ 1 file changed, 142 insertions(+), 80 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c

[PATCH v3 07/11] net/dpaa2: support dpmac Tx stats

2025-06-08 Thread Gagandeep Singh
From: Apeksha Gupta Added all mac counters including Tx stats buckets for packet sizes. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/mc/fsl_dpmac.h | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 05/11] net/dpaa2: add dpmac MC header file

2025-06-08 Thread Gagandeep Singh
From: Apeksha Gupta This patch upgrades the MC firmware release API compatibility to 10.39.0. Added mc/fsl_dpmac.h file. Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/mc/fsl_dpmac.h | 465 +++ 1 file changed, 465 insertions(+) create mode 100644 drivers/net/dp

[PATCH v3 03/11] bus/fslmc: add DPBP APIs for setting depletion thresholds

2025-06-08 Thread Gagandeep Singh
From: Vanshika Shukla This patch adds DPBP APIs for setting and getting the depletion/surplus thresholds for controlling pause frame generation. By default, depletion_entry is set as 128 by MC. This API would help user configure the buffer in depletion state as per requirement. Signed-off-by: V

[PATCH v3 01/11] net/dpaa2: fix issue of extract buffer preparation

2025-06-08 Thread Gagandeep Singh
From: Jun Yang 1) The max size of extract buffer should be size of "struct dpni_ext_set_rx_tc_dist"(488), which is greater than 256. 2) dpkg_prepare_key_cfg is responsible to clear extract buffer before preparing. Fixes: 25d0ae624245 ("net/dpaa2: check IOVA before sending MC command") Cc:

[PATCH v3 00/11] NXP DPAA2 driver enhancements and fixes

2025-06-08 Thread Gagandeep Singh
V1-logs: This patch series introduces enhancements and fixes to the NXP DPAA2 Ethernet driver. It includes support for - software taildrop on ordered queues. - setup speed capabilities. - DPAA2 resource version. - MAC level statistics. - improve PA-VA conversion. - add buffer pool depletion s

[PATCH] uapi: update to 6.15 for vduse.h

2025-06-08 Thread Stephen Hemminger
Use the header as produced by the kernel: $ make headers_install So that it exact match to what would be in distros and other tools. Signed-off-by: Stephen Hemminger --- kernel/linux/uapi/linux/vduse.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/linux/uapi/l

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h > index 48f2b57564..9880d415c4 100644 > --- a/lib/pcapng/rte_pcapng.h > +++ b/lib/pcapng/rte_pcapng.h > @@ -71,6 +71,8 @@ rte_pcapng_close(rte_pcapng_t *self); > * The handle to

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > +RTE_VERSION_SYMBOL(25, int, rte_pcapng_add_interface, > + (rte_pcapng_t *self, uint16_t port, > +const char *ifname, const char *ifdescr, > +const ch

Re: [PATCH v5 0/3] lcore options cleanup

2025-06-08 Thread Thomas Monjalon
27/05/2025 17:29, Bruce Richardson: > This patchset performs some basic cleanup of EAL lcore arguments before > any more serious work is done on them (as discussed in previous patchset > revisions). > > * mark the old coremask parameter (-c) and service core mask (-s) as > deprecated, so they ca

Re: [PATCH] test: fix race in per lcore test

2025-06-08 Thread Thomas Monjalon
17/03/2025 15:30, David Marchand: > In some CI, this unit test can fail, as the main thread may get > rescheduled while lcores execute the callback waiting 100ms. > > Bugzilla ID: 1668 > Fixes: af75078fece3 ("first public release") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied

Re: [PATCH] eal: fix return value of lcore role

2025-06-08 Thread Thomas Monjalon
20/05/2025 22:17, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Update rte_lcore_has_role() to return false instead of a > negative value for invalid lcore IDs, removing the need > for callers to pre-validate the ID. > > Fixes: b0a1502a277c ("eal: make semantics of lcore role function mo

Re: [PATCH] eal: warn if no lcore is available

2025-06-08 Thread Thomas Monjalon
08/05/2025 13:23, Burakov, Anatoly: > On 5/8/2025 7:19 AM, David Marchand wrote: > > On systems with more cpu than RTE_MAX_LCORE, starting DPDK with > > cores >= RTE_MAX_LCORE ends up with an ambiguous error log. > > > > Example with RTE_MAX_LCORE=8: > > $ taskset -c 8 ./build/app/dpdk-testpmd > >

[PATCH v3 6/6] doc: announce TxPP support for E830 adapters

2025-06-08 Thread Soumyadeep Hore
E830 adapters currently support Tx Time based queues. Signed-off-by: Soumyadeep Hore --- doc/guides/nics/ice.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 77985ae5a2..73c5477946 100644 --- a/doc/guides/nics/ice.r

[PATCH v3 5/6] net/intel: add AVX512 Support for TxPP

2025-06-08 Thread Soumyadeep Hore
Tx Time based queues are supported using AVX512 vector. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 206 +++- 1 file changed, 205 insertions(+), 1 deletion(-) diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx512.c b/drivers/net/intel/ice/i

[PATCH v3 4/6] net/intel: add AVX2 Support for TxPP

2025-06-08 Thread Soumyadeep Hore
Tx Time based queues are supported using AVX2 vector. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 135 +++- drivers/net/intel/ice/ice_rxtx_vec_common.h | 17 +++ 2 files changed, 151 insertions(+), 1 deletion(-) diff --git a/drivers/net/inte

[PATCH v3 3/6] net/intel: add TxPP Support for E830

2025-06-08 Thread Soumyadeep Hore
Add support for Tx Time based queues. This is used to schedule packets based on Tx timestamp. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/common/tx.h | 14 ++ drivers/net/intel/ice/base/ice_lan_tx_rx.h | 4 + drivers/net/intel/ice/ice_ethdev.c | 3 +- drivers/n

[PATCH v3 2/6] net/intel: add read clock feature in ICE

2025-06-08 Thread Soumyadeep Hore
Adding eth_ice_read_clock() feature to get current time for scheduling Packets based on Tx time. Signed-off-by: Soumyadeep Hore --- drivers/net/intel/ice/ice_ethdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ic

[PATCH v3 0/6] Add TxPP Support for E830

2025-06-08 Thread Soumyadeep Hore
Added TxPP support for E830 adapters. --- v2: - Fixed Compilation warnings --- v3: - Fixed further Compilation warnings (uinitialised one) --- Paul Greenwalt (1): net/intel: update E830 Tx Time Queue Context Structure Soumyadeep Hore (5): net/intel: add read clock feature in ICE net/intel: a

[PATCH v3 1/6] net/intel: update E830 Tx Time Queue Context Structure

2025-06-08 Thread Soumyadeep Hore
From: Paul Greenwalt Updated the Tx Time Queue Context Structure to align with HAS. Signed-off-by: Soumyadeep Hore Signed-off-by: Paul Greenwalt --- drivers/net/intel/ice/base/ice_common.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net

Re: [PATCH v3 0/4] mempool perf test: test random bulk sizes

2025-06-08 Thread Thomas Monjalon
> Morten Brørup (4): > mempool perf test: replace bare unsigned with unsigned int > mempool perf test: test default mempool with cache > mempool perf test: improve output readability > mempool perf test: test random bulk sizes Applied, thanks.

Re: [PATCH] mempool: micro optimizations

2025-06-08 Thread Thomas Monjalon
30/03/2025 10:09, Andrew Rybchenko: > On 3/27/25 20:15, Bruce Richardson wrote: > > On Wed, Feb 26, 2025 at 03:59:22PM +, Morten Brørup wrote: > >> The comparisons lcore_id < RTE_MAX_LCORE and lcore_id != LCORE_ID_ANY are > >> equivalent, but the latter compiles to fewer bytes of code space. >

Re: [PATCH v3] ethdev: fix the bug where the flag variables are assigned

2025-06-08 Thread Thomas Monjalon
22/05/2025 09:42, Sunyang Wu: > Set the values of the promiscuous and all_multicast variables > according to the return value. > > Fixes: af75078fece3 ("first public release") This is reset to 0 since day 1, so next root cause is not needed. > Fixes: de5ccf0775ae ("ethdev: do nothing if all-mult

Re: Question regarding rte_hash_hash and rte_hash_add_key_with_hash_data

2025-06-08 Thread Stephen Hemminger
On Sun, 8 Jun 2025 00:36:02 +0530 venkatesh bs wrote: > Hi @dpdk community, > > In my application, I am using the dpdk hash table as below. > > 1. calculate the hash value. > 2. using this signature add the key and data into a table. > 3. lock is used in the 2nd call (add). > > Below is the c

Question regarding rte_hash_hash and rte_hash_add_key_with_hash_data

2025-06-08 Thread venkatesh bs
Hi @dpdk community, In my application, I am using the dpdk hash table as below. 1. calculate the hash value. 2. using this signature add the key and data into a table. 3. lock is used in the 2nd call (add). Below is the code sniffer for the same.

[PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Schneide
From: Dylan Schneider Allow the user to specify protocol link type when creating pcapng files. This change is needed to specify the protocol type in the pcapng file, DLT_EN10MB specifies ethernet packets only. This will allow dissectors for other protocols to be used on files generated by pcapng.

Re: [dpdk-dev] [PATCH v3 4/8] crypto/cnxk: add security capabilities

2025-06-08 Thread Zhen Yit Chong