RE: rte_lcore_has_role() return value

2025-06-02 Thread Morten Brørup
Hi Vipin, No need. Pavan fixed it already: https://patchwork.dpdk.org/project/dpdk/patch/20250520201726.7420-1-pbhagavat...@marvell.com/ -Morten > From: Varghese, Vipin [mailto:vipin.vargh...@amd.com] > Sent: Tuesday, 3 June 2025 08.08 > > [Public] > > Hi @Morten Brørup > > Would you need me

RE: [v1 07/10] net/dpaa: add Tx rate limiting DPAA PMD API

2025-06-02 Thread Varghese, Vipin
[Public] Hi Vanishka, I believe you were trying to reach out using email id `vipin.vargh...@intel.com`. Please use `vipin.vargh...@amd.com` as I no longer have access to intel.com Snipped > > > From: Vinod Pullabhatla > > Add support to set Tx rate on DPAA platform through PMD APIs > > Sign

RE: [PATCH v3 00/14] add lookup fib nodes in graph library

2025-06-02 Thread Ankur Dwivedi
Hi Morten, >> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] >> Sent: Monday, 2 June 2025 08.36 >> >> This patch series adds two inbuilt nodes ip4_lookup_fib and >> ip6_lookup_fib in graph library. These nodes uses the existing >> Forwarding Information Base (FIB) library to create FIB, to do r

RE: [PATCH v4 0/4] Introduce Topology NUMA grouping for lcores

2025-06-02 Thread Varghese, Vipin
[Public] Hi All, Saring `rte_topology_` API patch next version targeted for upcoming release. Extras adding support for Cache-ID for L2 and L3 for Cache line stashing, Code Data Prioritization too. Snipped > > > > > Hello Vipin and others, > > > > please, will there be any progress or update o

RE: rte_lcore_has_role() return value

2025-06-02 Thread Varghese, Vipin
[Public] Hi @Morten Brørup Would you need me to check this under `rte_topology` pcoming patches? > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, May 19, 2025 7:46 PM > To: Morten Brørup > Cc: dev > Subject: RE: rte_lcore_has_role() return value > > Caution: Th

Re: [PATCH v3 00/14] add lookup fib nodes in graph library

2025-06-02 Thread Nitin Saxena
Hi Morten, Let me take a stab regarding the VRF question. Please find answers inline Thanks, Nitin On Mon, Jun 2, 2025 at 2:12 PM Morten Brørup wrote: > > +TO: Robin Jarry, might have relevant feedback for such a node > > > From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > > Sent: Monday, 2 J

Re: [PATCH] net/mlx5: use portable version of __builtin_ffsl

2025-06-02 Thread Andre Muezerie
On Mon, May 05, 2025 at 08:04:52AM -0700, Andre Muezerie wrote: > Builtin __builtin_ffsl is not available with MSVC therefore a > portable replacement should be used. > > Function rte_ffs32 is already available in eal and should be used > instead. > > Signed-off-by: Andre Muezerie > --- > drive

Re: [PATCH] common/mlx5: use intrinsics instead of inline assembly

2025-06-02 Thread Andre Muezerie
On Mon, May 05, 2025 at 07:57:42AM -0700, Andre Muezerie wrote: > When compiling with MSVC the errors below are hit because msvc does not > support inline assembly: > > 1) > ../drivers/common/mlx5/mlx5_common.c(86): warning C4013: '__asm__' > undefined; assuming extern returning int > ../drive

Re: [PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create

2025-06-02 Thread Andre Muezerie
On Mon, May 05, 2025 at 07:45:36AM -0700, Andre Muezerie wrote: > When compiling DPDK with mlx5 using clang on Windows with > "debug" buildtype the error below is hit: > > net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol > mlx5_geneve_tlv_parser_create referenced in func

Re: [PATCH v4 0/4] allow pmdinfo to be inserted and parsed using MSVC

2025-06-02 Thread Andre Muezerie
On Wed, Apr 16, 2025 at 02:44:54PM -0700, Andre Muezerie wrote: > DPDK uses GCC attribute "used" through macro __rte_used to indicate > that a variable not referenced in the code should be assumed being > used and therefore not be optimized away. This technique is used to embed > information in the

[PATCH] doc: remove the public interfaces from bus/vmbus

2025-06-02 Thread longli
From: Long Li The deprecation notice has been sent in 7642e3b0e0 ("doc: announce vmbus API deprecation") Remove those interfaces in this release. Signed-off-by: Long Li --- doc/guides/rel_notes/release_25_07.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/

RE: [PATCH v5 1/4] pci: add non-merged Linux uAPI changes

2025-06-02 Thread Wathsala Wathawana Vithanage
> Hi Maxim, > > Here is the link to the kernel VFIO patch you have asked earlier (v4). > https://lore.kernel.org/kvm/20250221224638.1836909-1- > wathsala.vithan...@arm.com/T/#me73cf9b9c87da97d7d9461dfb97863b78ca17 > 55b > Sorry, here is the correct link to V2 of the VFIO patch https://lore.ker

[PATCH v5 1/4] pci: add non-merged Linux uAPI changes

2025-06-02 Thread Wathsala Vithanage
This commit is a hack to prevent build failures the next commit in this patch series causes due to missing vfio uapi definitions. This commit should NEVER BE MERGED. Next commit in this patch series depends on additions to vfio uapi that enable TPH icotl in the vfio-pci driver in the Linux kernel.

RE: [PATCH v5 1/4] pci: add non-merged Linux uAPI changes

2025-06-02 Thread Wathsala Wathawana Vithanage
Hi Maxim, Here is the link to the kernel VFIO patch you have asked earlier (v4). https://lore.kernel.org/kvm/20250221224638.1836909-1-wathsala.vithan...@arm.com/T/#me73cf9b9c87da97d7d9461dfb97863b78ca1755b Thanks --wathsala > -Original Message- > From: Wathsala Vithanage > Sent: Monday

[PATCH v5 0/4] An API for Cache Stashing with TPH

2025-06-02 Thread Wathsala Vithanage
Today, DPDK applications benefit from Direct Cache Access (DCA) features like Intel DDIO and Arm's write-allocate-to-SLC. However, those features do not allow fine-grained control of direct cache access, such as stashing packets into upper-level caches (L2 caches) of a processor or the shared cache

[PATCH v5 4/4] net/i40e: enable TPH in i40e

2025-06-02 Thread Wathsala Vithanage
Adds stashing_capabilities_get, stashing_{rx,tx}_hinst_set functions to eth_dev_ops of the i40e driver. Enables TPH in device-specific mode, so that steering-tags are set in LAN queue contexts. Signed-off-by: Wathsala Vithanage --- drivers/net/intel/i40e/i40e_ethdev.c | 128 +

[PATCH v5 3/4] ethdev: introduce the cache stashing hints API

2025-06-02 Thread Wathsala Vithanage
Extend the ethdev library to enable the stashing of different data objects, such as the ones listed below, into CPU caches directly from the NIC. - Rx/Tx queue descriptors - Rx packets - Packet headers - packet payloads - Data of a packet at an offset from the start of the packet The APIs are des

[PATCH v5 2/4] bus/pci: introduce the PCIe TLP Processing Hints API

2025-06-02 Thread Wathsala Vithanage
Extend the PCI bus driver to enable or disable TPH capability and set or get PCI Steering-Tags (STs) on an endpoint device. The functions rte_pci_tph_{enable, disable,st_set,st_get} provide the primary interface for DPDK device drivers. Implementation of the interface is OS dependent. For Linux, th

ethdev use from secondary process

2025-06-02 Thread Ashish Sadanandan
Hi everyone, I'm trying to use a secondary process to rx/tx packets through a NIC and running into segfaults due to some data structures not being populated on the secondary. I've figured out a solution, but it involves the use of internal APIs and I wanted to check with the community if there's a

Re: [PATCH v3 3/3] app/eventdev: add vector adapter performance test

2025-06-02 Thread Jerin Jacob
On Fri, May 30, 2025 at 9:56 PM wrote: > > From: Pavan Nikhilesh > > Add performance test for event vector adapter. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-eventdev/for-main. Thanks. > --- > app/test-eventdev/evt_common.h | 9 +- > app/test-eventdev/evt_optio

[v2 01/10] bus/dpaa: avoid using same structure and variable name

2025-06-02 Thread vanshika . shukla
From: Hemant Agrawal rte_dpaa_bus was being used as structure and variable name both. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/bus/d

[v2 08/10] net/dpaa: add devargs for enabling err packets on main queue

2025-06-02 Thread vanshika . shukla
From: Vanshika Shukla Currently, error queue is mapped to the Rx queue and enabled by default. This patch adds the devargs to control the err packets on main queue. Also, in VSP mode the error queue should be disabled because the error packets from kernel are diverted to the Rx queue/err queue ca

[v2 10/10] bus/dpaa: optimize qman enqueue check

2025-06-02 Thread vanshika . shukla
From: Hemant Agrawal This patch improves data access during qman enequeue ring check. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 41 - drivers/bus/dpaa/include/fsl_qman.h | 2 +- 2 files changed, 23 insertions(+

[v2 09/10] bus/dpaa: improve DPAA cleanup

2025-06-02 Thread vanshika . shukla
From: Gagandeep Singh This patch addresses DPAA driver issues with the introduction of rte_eal_cleanup, which caused driver-specific destructors to fail due to memory cleanup. To resolve this, we remove the driver destructor and relocate the code to the bus cleanup function. So, this patch also

[v2 04/10] bus/dpaa: optimize bman acquire/release

2025-06-02 Thread vanshika . shukla
From: Jun Yang 1) Reduce byte swap between big endian and little endian. 2) Reduce ci(cache invalid) access by 128bit R/W instructions. These methods improve ~10% buffer acquire/release performance. Signed-off-by: Jun Yang --- drivers/bus/dpaa/base/qbman/bman.c | 149 -

[v2 07/10] net/dpaa: add Tx rate limiting DPAA PMD API

2025-06-02 Thread vanshika . shukla
From: Vinod Pullabhatla Add support to set Tx rate on DPAA platform through PMD APIs Signed-off-by: Vinod Pullabhatla Signed-off-by: Vanshika Shukla --- .mailmap | 1 + drivers/net/dpaa/dpaa_flow.c | 87 +++- drivers/net/dpaa/fmlib/

[v2 06/10] mempool/dpaa: adjust pool element for LS1043A errata

2025-06-02 Thread vanshika . shukla
From: Jun Yang Adjust every element of pool by populate callback. 1) Make sure start DMA address is aligned with 16B. 2) For buffer across 4KB boundary, make sure start DMA address is aligned with 256B. Signed-off-by: Jun Yang --- drivers/mempool/dpaa/dpaa_mempool.c | 145 ++

[v2 05/10] mempool/dpaa: fast acquire and release

2025-06-02 Thread vanshika . shukla
From: Jun Yang Use new BMan APIs to improve performance and support burst release. Improve release performance ~90% by burst release. Signed-off-by: Jun Yang --- drivers/mempool/dpaa/dpaa_mempool.c | 85 - drivers/mempool/dpaa/dpaa_mempool.h | 2 +- 2 files changed

[v2 03/10] bus/dpaa: enhance DPAA SoC version

2025-06-02 Thread vanshika . shukla
From: Jun Yang Provide internal API to identify DPAA1 SoC version instead of accessing global variable directly. Signed-off-by: Jun Yang --- drivers/bus/dpaa/base/qbman/qman.c | 9 +++--- drivers/bus/dpaa/bus_dpaa_driver.h | 9 +++--- drivers/bus/dpaa/dpaa_bus.c| 48 +

[v2 02/10] bus/dpaa: add FMan node

2025-06-02 Thread vanshika . shukla
From: Jun Yang Add FMan node(s) and associate FMan to it's interface(port). This method describes FMan attributes and avoid accessing FMan from port directly. Logically, something like IEEE 1588 is FMan global resource, which is in range of 0xF_E000–0xF_EFFF. Port specific resource is in range of

[v2 00/10] DPAA specific fixes

2025-06-02 Thread vanshika . shukla
From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. V2: Handled review comments and checkpatch warnings Gagandeep Singh (1): bus/dpaa: improve DPAA cleanup Hemant Agrawal (2): bus/dpaa: avoid using same structure and variable name bus/dpaa: optimize qman enqueue check

[PATCH v2 11/11] net/dpaa2: enable software taildrop for ordered queues

2025-06-02 Thread Gagandeep Singh
This patch adds support for software taildrop on ordered queues in the DPAA2 driver. It also enables congestion notification by default on traffic management (TM) queues, which is a prerequisite for software taildrop functionality. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_rxtx

RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
Also update release notes. > Subject: RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD > > Please fix individual patch compilation > > [2/34] Compiling C object > drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o > FAILED: > drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cn

RE: [PATCH 00/25] add CN20K support to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
Please fix individual patch compilation [2/34] Compiling C object drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o FAILED: drivers/libtmp_rte_crypto_cnxk.a.p/crypto_cnxk_cn20k_cryptodev_ops.c.o ccache gcc -Idrivers/libtmp_rte_crypto_cnxk.a.p -Idrivers -I../drivers -Idrivers

RE: [PATCH 0/6] fixes and improvements to cnxk crypto PMD

2025-06-02 Thread Akhil Goyal
> -Original Message- > From: Tejasree Kondoj > Sent: Tuesday, May 27, 2025 9:31 AM > To: Akhil Goyal > Cc: Anoob Joseph ; Aakash Sasidharan > ; Vidya Sagar Velumuri ; > dev@dpdk.org > Subject: [PATCH 0/6] fixes and improvements to cnxk crypto PMD > > This patch adds fixes and improvem

[PATCH v2 04/11] mempool/dpaa2: use unified VA to IOVA conversion

2025-06-02 Thread Gagandeep Singh
From: Jun Yang Use DPAA2_VADDR_TO_IOVA to convert va to iova for both VA and PA modes. Signed-off-by: Jun Yang --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 222 +++ 1 file changed, 142 insertions(+), 80 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c

RE: [PATCH v1 3/4] ring: fix potential sync issue between head and tail values

2025-06-02 Thread Konstantin Ananyev
Hi Wathsala, > > > > Thanks for the clarification, I now see your concern. > > > > So, in summary what you are saying is that tail update from > > Thread #1 that happened at T0 is not observed by the thread #2 > > at T2 when it computed new_head and entries calculation. Yes > > That cannot happ

[PATCH v2 05/11] net/dpaa2: add dpmac MC header file

2025-06-02 Thread Gagandeep Singh
From: Apeksha Gupta This patch upgrades the MC firmware release API compatibility to 10.39.0. Added mc/fsl_dpmac.h file. Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/mc/fsl_dpmac.h | 490 +++ 1 file changed, 490 insertions(+) create mode 100644 drivers/net/dp

[PATCH v2 09/11] net/dpaa2: retrieve DPNI API version at init time

2025-06-02 Thread Gagandeep Singh
From: Ioana Ciornei The list of availabla DPNI APIs depends on the DPNI API version available on a system. Retrieve the API version in the init stage and store it in the private structure so that it can be used at a later stage. Signed-off-by: Ioana Ciornei --- .mailmap

[PATCH v2 10/11] net/dpaa2: setup the speed cap based on the actual MAC

2025-06-02 Thread Gagandeep Singh
From: Ioana Ciornei Previously, the speed_capa field from struct rte_eth_dev_info was populated with all possible speeds that the MACs on the system could sustain. What this meant is that the bitmap of speed capability did not reflect what the MAC could do in the current circumstance. Fix this b

[PATCH v2 08/11] net/dpaa2: support dpmac Tx stats in xstats

2025-06-02 Thread Gagandeep Singh
From: Apeksha Gupta Added all mac counters including Tx stats buckets for packet sizes in xstats. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 20 +++- drivers/net/dpaa2/dpaa2_ethdev.h | 4 ++-- 2 files changed, 21 inserti

[PATCH v2 07/11] net/dpaa2: support dpmac Tx stats

2025-06-02 Thread Gagandeep Singh
From: Apeksha Gupta Added all mac counters including Tx stats buckets for packet sizes. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/mc/fsl_dpmac.h | 50 ++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v2 06/11] net/dpaa2: support dpmac counters in stats

2025-06-02 Thread Gagandeep Singh
From: Apeksha Gupta Add support of dpmac counters in xstats. Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c| 118 ++-- drivers/net/dpaa2/dpaa2_ethdev.h| 12 +++ drivers/net/dpaa2/mc/dpni.c | 29 ++-

[PATCH v2 03/11] bus/fslmc: add DPBP APIs for setting depletion thresholds

2025-06-02 Thread Gagandeep Singh
From: Vanshika Shukla This patch adds DPBP APIs for setting and getting the depletion/surplus thresholds for controlling pause frame generation. By default, depletion_entry is set as 128 by MC. This API would help user configure the buffer in depletion state as per requirement. Signed-off-by: V

[PATCH v2 02/11] net/dpaa2: fix shaper rate

2025-06-02 Thread Gagandeep Singh
This patch fixes the shaper rate by configuring the user given rate in bytes. Earlier driver was considering the user given rate value in bits. Fixes: ac624068ee25 ("net/dpaa2: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/dpaa2/dpaa2_tm.c | 8 +

[PATCH v2 01/11] net/dpaa2: fix issue of extract buffer preparation

2025-06-02 Thread Gagandeep Singh
From: Jun Yang 1) The max size of extract buffer should be size of "struct dpni_ext_set_rx_tc_dist"(488), which is greater than 256. 2) dpkg_prepare_key_cfg is responsible to clear extract buffer before preparing. Fixes: 25d0ae624245 ("net/dpaa2: check IOVA before sending MC command") Cc:

[PATCH v2 00/11] NXP DPAA2 driver enhancements and fixes

2025-06-02 Thread Gagandeep Singh
V1-logs: This patch series introduces enhancements and fixes to the NXP DPAA2 Ethernet driver. It includes support for - software taildrop on ordered queues. - setup speed capabilities. - DPAA2 resource version. - MAC level statistics. - improve PA-VA conversion. - add buffer pool depletion s

[PATCH v2 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
For vDPA devices, virtqueues are not locked once the device has been configured. In the commit 5e8fcc60b59d ("vhost: enhance virtqueue access lock asserts"), the asserts were enhanced to trigger rte_panic functionality, preventing access to virtqueues without locking. However, this change introduce

[PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
For vDPA devices, virtqueues are not locked once the device has been configured. In the commit 5e8fcc60b59d ("vhost: enhance virtqueue access lock asserts"), the asserts were enhanced to trigger rte_panic functionality, preventing access to virtqueues without locking. However, this change introduce

Re: [PATCH v3 03/10] net/ice/base: fix integer overflow issue

2025-06-02 Thread Burakov, Anatoly
On 5/27/2025 3:17 PM, Dhanya Pillai wrote: From: Lukasz Krakowiak Fix issue related to INTEGER_OVERFLOW. I would also suggest rewording the commit message. Even something like the following would be better: Fix integer overflow issue in power of 2 calculation. Fixes: f636f2888cec ("net/

[PATCH v4 0/1] Memory hotplug fix

2025-06-02 Thread Danylo Vodopianov
Hi everyone. We detected an issue with the memory hotplug feature and virtio devices while working with vitrio in DPDK.In general, the issue is around the user request VHOST_USER_SET_MEM_TABLE and locking queues for this request (https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n1512)

[PATCH v3 0/1] Memory hotplug fix

2025-06-02 Thread Danylo Vodopianov
Hi everyone. We detected an issue with the memory hotplug feature and virtio devices while working with vitrio in DPDK.In general, the issue is around the user request VHOST_USER_SET_MEM_TABLE and locking queues for this request (https://git.dpdk.org/dpdk-stable/tree/lib/vhost/vhost_user.c#n1512)

Re: [PATCH v3 02/10] net/ice/base: fix typo in media type check

2025-06-02 Thread Burakov, Anatoly
On 5/27/2025 3:17 PM, Dhanya Pillai wrote: From: Paul Greenwalt Found a typo in original implementation of ice_set_media_type, where one of the checks for FIBER checks for C2C media type instead of C2M. This results in failure of this check for some AOC devices, consequently setting the media

[PATCH v3 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-02 Thread Danylo Vodopianov
For vDPA devices, virtqueues are not locked once the device has been configured. In the commit 5e8fcc60b59d ("vhost: enhance virtqueue access lock asserts"), the asserts were enhanced to trigger rte_panic functionality, preventing access to virtqueues without locking. However, this change introduce

RE: [PATCH v3 00/14] add lookup fib nodes in graph library

2025-06-02 Thread Morten Brørup
+TO: Robin Jarry, might have relevant feedback for such a node > From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Monday, 2 June 2025 08.36 > > This patch series adds two inbuilt nodes ip4_lookup_fib and > ip6_lookup_fib in graph library. These nodes uses the existing > Forwarding Inform

[PATCH] app/compress-perf: support dictionary files

2025-06-02 Thread Sameer Vaze
compress/zlib: support PDCP checksum compress/zlib: support zlib dictionary compressdev: add PDCP checksum compressdev: support zlib dictionary Adds support to provide predefined dictionaries to zlib. Handles setting and getting of dictionaries using zlib apis. Also includes support to read dic