[PATCH v5 9/9] app/test: add zsda cryptodev test

2025-05-21 Thread Hanxiao Li
Add crypto test for zsda device and driver. Signed-off-by: Hanxiao Li --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + doc/guides/cryptodevs/zsda.rst | 6 ++ 3 files changed, 14 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

[PATCH v5 5/9] crypto/zsda: add session configuration

2025-05-21 Thread Hanxiao Li
Add crypto session configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_crypto_pmd.c | 45 +- drivers/crypto/zsda/zsda_crypto_session.c | 498 ++ drivers/crypto/zsda/zsda_crypto_session.

[PATCH v5 7/9] crypto/zsda: add dequeue datapath

2025-05-21 Thread Hanxiao Li
Add crypto dequeue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto.c | 16 drivers/crypto/zsda/zsda_crypto.h | 2 ++ drivers/crypto/zsda/zsda_crypto_pmd.c | 12 ++-- 3 files changed, 28 insertions(+), 2 delet

[PATCH v5 6/9] crypto/zsda: add enqueue datapath

2025-05-21 Thread Hanxiao Li
Add crypto enqueue datapath configuration for zsda device. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_crypto.c | 256 ++ drivers/crypto/zsda/zsda_crypto.h | 45 + drivers/crypto/zsda/zsda_crypto_pmd.

[PATCH v5 4/9] crypto/zsda: add queue pair configuration

2025-05-21 Thread Hanxiao Li
Add crypto queue pair configuration operations for zsda device. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 80 ++- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_c

[PATCH v5 8/9] crypto/zsda: add capabilities

2025-05-21 Thread Hanxiao Li
Add crypto capabilities scope for zsda device. Signed-off-by: Hanxiao Li --- doc/guides/cryptodevs/features/zsda.ini | 51 doc/guides/cryptodevs/zsda.rst| 26 doc/guides/rel_notes/release_25_07.rst| 8 ++ .../crypto/zsda/zsda_crypto_capabilities.h

[PATCH v5 1/9] crypto/zsda: add skeleton

2025-05-21 Thread Hanxiao Li
Add crypto driver skeleton for zsda devices. Signed-off-by: Hanxiao Li --- MAINTAINERS | 6 ++ doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryptodevs/zsda.rst| 26 ++ drivers/common/zsda/meson.build | 12 ++- drivers/common/zsda/zsda_

[PATCH v5 3/9] crypto/zsda: add statistics

2025-05-21 Thread Hanxiao Li
Add crypto statistics operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_crypto_pmd.c inde

[PATCH v5 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-21 Thread Hanxiao Li
v5: - Modify the code according to the advise v4: - change some "sym" to "crypto". v3: - Modify the code according to the advise v2: - Modify the errors about cryptodevs/zsda.rst. - Modify the errors about author. v1: - Add zsda cryptodev driver. Hanxiao Li (9): crypto/zsda: add skeleton

[PATCH v5 2/9] crypto/zsda: add device operations

2025-05-21 Thread Hanxiao Li
Add crypto device operations for zsda devices. Signed-off-by: Hanxiao Li --- drivers/crypto/zsda/zsda_crypto_pmd.c | 82 +-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/zsda/zsda_crypto_pmd.c b/drivers/crypto/zsda/zsda_crypto_pmd.c index

[PATCH v1] compress/zsda: code formatting

2025-05-21 Thread Hanxiao Li
Organize the format of zsda compress, including the location of macros and the format of some code comments, etc. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_device.h | 4 +-- drivers/common/zsda/zsda_qp.h | 48 +-- drivers/common/zsda/zsda_qp_comm

RE: [EXTERNAL] Re: [PATCH v2 1/2] net: fix offset calculation for GENEVE packet

2025-05-21 Thread Sunil Kumar Kori
> > diff --git a/lib/net/rte_net.c b/lib/net/rte_net.c index > > be24690fdf..1264f33d61 100644 > > --- a/lib/net/rte_net.c > > +++ b/lib/net/rte_net.c > > @@ -251,7 +251,8 @@ ptype_tunnel_with_udp(uint16_t *proto, const struct > rte_mbuf *m, > > if (unlikely(gnh == NULL)) > >

RE: [EXTERNAL] [PATCH v2 0/9] DPAA2 crypto driver changes

2025-05-21 Thread Gagandeep Singh
Hi, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, May 21, 2025 5:30 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: Hemant Agrawal > Subject: RE: [EXTERNAL] [PATCH v2 0/9] DPAA2 crypto driver changes > > > V2 changes: > > - fix checkpatch warning > > - fix 32 bit compilati

Re: [PATCH v1 2/2] app/testpmd: sort commands by help string

2025-05-21 Thread Stephen Hemminger
On Wed, 14 May 2025 14:02:12 +0100 Anatoly Burakov wrote: > When using '?' to find commands, it occasionally is difficult to find the > needed commands because all commands are not in alphabetical order, but > rather can be ordered rather arbitrarily. > > To address this, use help string to orde

RE: [PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 21 May 2025 21.39 > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > Sent: Wednesday, 21 May 2025 14.35 > > > > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] >

RE: [PATCH v1 3/4] ring: fix potential sync issue between head and tail values

2025-05-21 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 21 May 2025 13.15 > > This patch aims several purposes: > - provide an alternative (and I think a better) way to fix the > issue discussed in previous patch: > "ring/soring: fix synchronization issue between h

Re: [RFC v2 2/6] dts: rework traffic generator inheritance structure.

2025-05-21 Thread Dean Marx
On Fri, May 16, 2025 at 4:19 PM Nicholas Pratte wrote: > > Rework TG class hierarchy to include performance traffic generators, in > addition to capturing traffic generators. As such, methods garnered > to capturing traffic have been moved to the CapturingTrafficGenerator > subclass. This commit

Re: [PATCH] eal: add getline() function for Windows

2025-05-21 Thread Andre Muezerie
On Wed, May 21, 2025 at 09:00:48AM +0200, Thomas Monjalon wrote: > 21/05/2025 02:35, Andre Muezerie: > > On Tue, May 20, 2025 at 10:14:33AM -0700, Stephen Hemminger wrote: > > > On Mon, 5 May 2025 13:40:07 -0700 > > > Andre Muezerie wrote: > > > > > > > Existing DPDK code uses getline(), which i

[PATCH v2 2/3] dts: add jump and priority tests to flow suite

2025-05-21 Thread Dean Marx
Add jump action verification method and test case to Flow API test suite, as well as a case for validating flows with different priority levels. Signed-off-by: Dean Marx --- dts/tests/TestSuite_flow.py | 187 +++- 1 file changed, 165 insertions(+), 22 deletions(-)

RE: [PATCH v1 4/4] config/x86: enable RTE_USE_C11_MEM_MODEL by default

2025-05-21 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 21 May 2025 13.15 > > As an attempt to reduce legacy code usage within rte_ring - > enable RTE_USE_C11_MEM_MODEL by default on all x86 platforms. I theory, after requiring C11, RTE_USE_C11_MEM_MODEL should be the

RE: [PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Konstantin Ananyev
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Wednesday, 21 May 2025 14.35 > > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > > Sent: Wednesday, 21 May 2025 13.14 > > > > > > > > Add RTE_ASSERT() to check that different move_tail() f

[PATCH] net/bnxt: fix free of not allocated object

2025-05-21 Thread Stephen Hemminger
This was found as error when compiling with LTO. The function allocates new data with rte_zmalloc and then stores pointer in the pointer-to-pointer passed as argument. In the unwind case, it would call rte_free() with wrong one. Fixes: 80317ff6adfd ("net/bnxt/tf_core: support Thor2") Signed-off-b

RE: [PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 21 May 2025 14.35 > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > Sent: Wednesday, 21 May 2025 13.14 > > > > > > Add RTE_ASSERT() to check that different move_tail() flavors > > > ret

[PATCH v2 3/3] dts: add flow validation

2025-05-21 Thread Dean Marx
Add a method for validating flow rules to the testpmd shell class. Implement test case skipping for flow rules that do not pass validation. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 15 dts/framework/test_run.py | 3 + dts/framework/te

[PATCH v2 1/3] dts: add rte flow test suite

2025-05-21 Thread Dean Marx
Add an RTE Flow API testing suite, which covers some basic synchronous Flow API rules that should be supported across PMDs. This suite will be added to over time, as the Flow API is too large to cover all in one suite, and sending one monolithic series would be impossible. Signed-off-by: Dean Marx

[PATCH] examples/ntb: fix the heap allocation check

2025-05-21 Thread Bing Zhao
In some rare case, the libc memory heap allocation may fail and return NULL pointer. Before accessing the memory via the pointer, the NULL pointer check should be done to ensure the code locates in the safe side and no crash. Some newer GCC version will check this by default and report warning on

[PATCH v1] net/virtio-user: implement MAC setting for Vhost-kernel

2025-05-21 Thread Maxime Coquelin
This patch implements MAC address setting with Vhost-kernel backends. With this, it is possible to set the TAP interface MAC address using the Ethdev API. Signed-off-by: Maxime Coquelin --- Change from RFC: Rebased on latest main --- drivers/net/virtio/virtio_user/vhost_kernel.c | 23 +++

[DPDK/ethdev Bug 1536] net/tap: crash in tap pmd when using more than RTE_MP_MAX_FD_NUM rx queues

2025-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1536 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added CC||step...@networkpl

Re: [PATCH v1] net/virtio-user: implement MAC setting for Vhost-kernel

2025-05-21 Thread Stephen Hemminger
On Wed, 21 May 2025 16:23:05 +0200 Maxime Coquelin wrote: > iff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > index 611e2e25ec..3e13f8f65b 100644 > --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > +++ b/drivers/net/virt

RE: [EXTERNAL] [PATCH] cryptodev: allow use of global variables from C++

2025-05-21 Thread Akhil Goyal
> > Avoid C++ name mangling of the two global variables being exported > > from . > > > > Suggested-by: David Marchand > > Signed-off-by: Mattias Rönnblom > > --- > > lib/cryptodev/rte_crypto_asym.h | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/lib/cryptodev/rte_crypto_a

[DPDK/ethdev Bug 1710] net/bnxt build failure with LTO enabled

2025-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1710 Bug ID: 1710 Summary: net/bnxt build failure with LTO enabled Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[DPDK/ethdev Bug 1709] net/mlx5 warnings when build with lto

2025-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1709 Bug ID: 1709 Summary: net/mlx5 warnings when build with lto Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH 7/8] net/ena: fix virtual address calc for unaligned BARs

2025-05-21 Thread Shai Brandes
On 64K page systems, DPDK `pci_uio` driver aligns the physical address to a 64K boundary before assigning a virtual address. If the original physical BAR address is not 64K-aligned, this adjustment leads to an incorrect mapping. The fix ensures that the BAR virtual address received in the driver a

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-21 Thread Stephen Hemminger
On Mon, 28 Apr 2025 16:55:07 +0530 farooq basha wrote: > Hello DevTeam, > > I am planning to use DPDK HQOS for Traffic shaping with a > run-to-completion Model. While I was reading the dpdk-qos document, I came > across the following statement. > > "*Running enqueue and dequeue operations f

[PATCH 5/8] net/ena: fix unhandled interrupt config failure

2025-05-21 Thread Shai Brandes
Fixed the device initialization routine to correctly handle failure during the registration or enabling of interrupts when operating in control path interrupt mode. Fixes: ca1dfa85f0d3 ("net/ena: add control path pure polling mode") Cc: sta...@dpdk.org Signed-off-by: Shai Brandes Reviewed-by: Ami

[PATCH 8/8] net/ena: upgrade driver version to 2.13.0

2025-05-21 Thread Shai Brandes
Upgraded the driver version to 2.13.0. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index bdb49

RE: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets

2025-05-21 Thread Akhil Goyal
> Subject: [PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPsec packets > > launching ipsec-segw application in event vector mode > after traffic has started results in segfault because > we are receiving few IPSEC packet and application is trying > to decrypt IPSEC packets using lookasi

RE: [PATCH] doc: add limitation in using segment-sz in crypto-perf

2025-05-21 Thread Akhil Goyal
> > Subject: [PATCH] doc: add limitation in using segment-sz in crypto-perf > > > > When segment-sz is given as parameter, > > use buffer-sz in descending order. > > The reason is, same scatter gather buffer list is being used for all packet > > sizes > > which is initialized once in the beginning

[PATCH 4/8] net/ena: support fragment bypass mode

2025-05-21 Thread Shai Brandes
Introduce devarg `enable_frag_bypass` to toggle the fragment bypass mode for egress packets. When enabled, this feature bypasses the PPS limit enforced by EC2 for fragmented egress packets on every ENI. Note that enabling this might negatively impact network performance. By default, this feature

[PATCH 2/8] net/ena/base: coding style changes

2025-05-21 Thread Shai Brandes
Reordered variable declarations to follow the reverse Christmas tree style. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/base/ena_com.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_c

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-21 Thread Stephen Hemminger
On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: > +NUMERIC_TYPES = { > +"UINT8": "uint8_t", > +"UINT16": "uint16_t", > +"UINT32": "uint32_t", > +"UINT64": "uint64_t", > +"INT8": "int8_t", > +"INT16": "int16_t", > +"INT32": "int32_t", > +"INT64": "int64_t"

[PATCH 6/8] net/ena: fix aenq timeout with low poll interval

2025-05-21 Thread Shai Brandes
The driver can work in polling-based functionality of the admin queue, eliminating the need for interrupts in the control-path. This mode is mandatory when using the uio_pci_generic driver, which lacks interrupt support. The control_path_poll_interval devarg is being set within the range [1..1000]

Re: [PATCH v2] ethdev: optimize how the values of the flag variables are assigned

2025-05-21 Thread Stephen Hemminger
On Wed, 21 May 2025 18:15:31 +0800 Sunyang Wu wrote: > Set the values of the promiscuous and all_multicast variables > according to the return value. > > Signed-off-by: Morten Brørup > Signed-off-by: Sunyang Wu > --- > lib/ethdev/rte_ethdev.c | 11 +-- > 1 file changed, 5 insertions(+

[PATCH 3/8] net/ena: separate doorbell logic for Rx and Tx

2025-05-21 Thread Shai Brandes
The function ena_com_write_sq_doorbell() currently checks for LLQ mode using is_llq_max_tx_burst_exists() which is relevant only for TX queues. Since RX queues do not operate in LLQ mode, this check is unnecessary for the RX path. This patch separates the doorbell write logic into two distinct han

[PATCH 1/8] net/ena/base: avoid recalculating desc per entry

2025-05-21 Thread Shai Brandes
desc_per_entry is precomputed in ena_com_config_llq_info() using desc_stride_ctrl and desc_list_entry_size, which remain unchanged after device negotiation. Reuse the existing value instead of recalculating it in the fast path. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by:

[PATCH 0/8] net/ena: release 2.13.0

2025-05-21 Thread Shai Brandes
This patchset includes an upgrade of the ENA HAL, introduces a new feature, and addresses three bug fixes. Thank you in advance to the net maintainers and community members for your time and effort reviewing the code. Best regards, Shai Brandes AWS Elastic Network Adapter team Shai Brandes (8):

RE: [EXTERNAL] [PATCH v4 1/9] crypto/zsda: add skeleton

2025-05-21 Thread Akhil Goyal
> diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c > index 0ef7cac585..a5f00d8ab6 100644 > --- a/drivers/common/zsda/zsda_qp.c > +++ b/drivers/common/zsda/zsda_qp.c > @@ -15,6 +15,9 @@ static uint8_t zsda_num_used_qps; > static struct ring_size zsda_qp_hw_ring_size[ZSDA_M

Re: [PATCH 2/2] test/power_intel_uncore: skip test if init fails

2025-05-21 Thread Kevin Laatz
On 15/05/2025 17:58, Bruce Richardson wrote: If the initialization of the uncore power management fails, mark the test as skipped rather than a failure. This prevents false failures in the case where we are running as a normal user, who doesn't have permissions to edit uncore power states. Signe

Re: [PATCH 1/2] power/intel_uncore: fix crash closing uninitialized driver

2025-05-21 Thread Kevin Laatz
On 15/05/2025 17:58, Bruce Richardson wrote: When the power_intel_uncore_autotest unit test is run as an unprivileged user which cannot init the power library, it crashes the unit test binary due to calling "rte_power_uncore_exit" after the first test case (initialization) fails. This crash is du

RE: [EXTERNAL] [PATCH 0/2] uadk: realize async mode

2025-05-21 Thread Akhil Goyal
> Realize async mode to replace sync mode for better performance > > Zhangfei Gao (2): > compress/uadk: use async mode to replace sync mode > crypto/uadk: use async mode to replace sync mode > > drivers/compress/uadk/uadk_compress_pmd.c | 107 -- > .../compress/uadk/uadk_compress_pmd

RE: [PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Konstantin Ananyev
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Wednesday, 21 May 2025 13.14 > > > > Add RTE_ASSERT() to check that different move_tail() flavors > > return meaningful *entries value. > > It also helps to ensure that inside move_tail(), it uses correct > > head/tai

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-21 Thread Burakov, Anatoly
On 5/20/2025 6:19 PM, Stephen Hemminger wrote: On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. Use C library for parsing. Signed-off-by: Anatoly Burakov This looks

RE: [PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 21 May 2025 13.14 > > Add RTE_ASSERT() to check that different move_tail() flavors > return meaningful *entries value. > It also helps to ensure that inside move_tail(), it uses correct > head/tail values. > > S

RE: [EXTERNAL] [PATCH v2 0/9] DPAA2 crypto driver changes

2025-05-21 Thread Akhil Goyal
> V2 changes: > - fix checkpatch warning > - fix 32 bit compilation error > - fix a commit message > - update document > > Gagandeep Singh (5): > common/dpaax: fix invalid key command error > common/dpaax: fix for PDCP AES only 12bit SN case > common/dpaax: support 12bit SN in pdcp uplan

RE: [PATCH] eal/linux: unregister alarm callback before free ptr

2025-05-21 Thread Konstantin Ananyev
> Subject: [PATCH] eal/linux: unregister alarm callback before free ptr > > This was flagged by Address sanitizer as a use after free. The > intr_handle ptr is shared between the main thread and the interrupt > thread, and the interrupt thread can dereference the ptr after free > is called when

RE: [PATCH] eal: fix return value of lcore role

2025-05-21 Thread Konstantin Ananyev
> > From: Pavan Nikhilesh > > Update rte_lcore_has_role() to return false instead of a > negative value for invalid lcore IDs, removing the need > for callers to pre-validate the ID. > > Fixes: b0a1502a277c ("eal: make semantics of lcore role function more > intuitive") > Cc: sta...@dpdk.org

RE: [EXTERNAL] Re: [dpdk-dev v1] app/test-crypto-perf: remove decrypt test case from perf

2025-05-21 Thread Akhil Goyal
> On 02-May-25 11:12 AM, Kai Ji wrote: > > > Remove all decrypt test cases in aesni-mb throughput perf as the > decrypt throughput testing only support OOP by dpdk-test-crypto-perf > > Signed-off-by: Kai Ji > --- > > Acked-by: Radu Nicolau App

[PATCH v1 3/4] ring: fix potential sync issue between head and tail values

2025-05-21 Thread Konstantin Ananyev
This patch aims several purposes: - provide an alternative (and I think a better) way to fix the issue discussed in previous patch: "ring/soring: fix synchronization issue between head and tail values" - make sure that such problem wouldn’t happen within other usages of __rte_ring_headtail_mo

[PATCH v1 2/4] ring/soring: fix head-tail synchronization issue

2025-05-21 Thread Konstantin Ananyev
While running soring_stress_autotest on machine with Ampere Altra Max CPU, observed the following synchronization issue: ... TEST-CASE MT MT_DEQENQ-MT_STG1-PRCS test_worker_prcs:_st_ring_dequeue_bulk: check_updt_elem(lc=11, num=42) failed at 11-th iter, offending object: 0x103df1480 ... EAL: PANIC

[PATCH v1 4/4] config/x86: enable RTE_USE_C11_MEM_MODEL by default

2025-05-21 Thread Konstantin Ananyev
As an attempt to reduce legacy code usage within rte_ring - enable RTE_USE_C11_MEM_MODEL by default on all x86 platforms. Signed-off-by: Konstantin Ananyev --- config/x86/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/x86/meson.build b/config/x86/meson.build index c3564b0

[PATCH v1 0/4] ring: some fixes and improvements

2025-05-21 Thread Konstantin Ananyev
First two patches are ‘low risk’ ones. Third one touches some core functions within rte_ring library and would probably requires extra reviews/testing from different vendors. 4th one enables C11 based code on all x86 platforms by default. The stretch goal for it – make all supported platforms to us

[PATCH v1 1/4] ring: introduce extra run-time checks

2025-05-21 Thread Konstantin Ananyev
Add RTE_ASSERT() to check that different move_tail() flavors return meaningful *entries value. It also helps to ensure that inside move_tail(), it uses correct head/tail values. Signed-off-by: Konstantin Ananyev --- lib/ring/rte_ring_c11_pvt.h | 2 +- lib/ring/rte_ring_elem_pvt.h | 8 +

RE: [PATCH] net/ice: fix support for 3 scheduler levels

2025-05-21 Thread Loftus, Ciara
> > When using only 3 scheduler levels, the VSI node needs to be a node > further down the scheduler hierarchy, rather than one up it as with all > other possible level settings (5-9). Take account of this possibility in > the code. > > Fixes: 4ace7701eb44 ("net/ice: provide parameter to limit sc

RE: [EXTERNAL] [PATCH] crypto/qat: fix out-of-place chain, cipher and auth headers

2025-05-21 Thread Akhil Goyal
> This commit fixes a problem with overwriting data in the OOP header > in RAW API crypto processing when using chain, cipher and auth algorithms. > > Signed-off-by: Arkadiusz Kusztal Fied check patch issue Applied to dpdk-next-crypto

RE: [PATCH] test/crypto: add test case for modex group 24

2025-05-21 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: add test case for modex group 24 > > > > Add test case for modex group 24. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Acked-by: Anoob Joseph > Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/qat: fix out-of-place header bytes in aead raw api

2025-05-21 Thread Akhil Goyal
> Hey Arek > > > -Original Message- > > From: Kusztal, ArkadiuszX > > Sent: Thursday 20 March 2025 16:57 > > To: dev@dpdk.org > > Cc: gak...@marvell.com; Ji, Kai ; Dooley, Brian > > ; Kusztal, ArkadiuszX > > ; sta...@dpdk.org > > Subject: [PATCH] crypto/qat: fix out-of-place header bytes

RE: [EXTERNAL] [PATCH] app/crypto-perf: avoid infinite loop

2025-05-21 Thread Akhil Goyal
> The enqueue/dequeue loop's exit condition is > (ops_enqd_total >= total_ops). If the PMD driver cannot process the > ops (returns zero), ops_enqd_total won't increase, resulting in an > infinite loop. A check is added to process one op to determine > whether PMD can process the packet. > > Signe

Re: [PATCH v2] net/ice: fix flow creation failure

2025-05-21 Thread Bruce Richardson
On Thu, May 15, 2025 at 11:23:44AM +, Dhanya Pillai wrote: > In non-pipeline mode, priority is ignored, a flow rule can be created > as a flow director rule or a switch rule depends on its pattern/action. > Hence removing the priority field check from ice_fdir_parse which is > causing valid flo

RE: [EXTERNAL] [PATCH] app/crypto-perf: fix aad offset alignment

2025-05-21 Thread Akhil Goyal
> > > > > > Hi, > > > > AAD offset in AES-GCM crypto test was calculated by adding 16-byte > > > > alignment after the IV, which is only needed in AES-CCM. > > > > > > Agreed that CCM has a requirement for 16B alignment. > > > But for GCM, does it break any protocol? Can we not align to byte > > >

Re: [PATCH] net/intel: fix igb tx queue offloads capability

2025-05-21 Thread Bruce Richardson
On Wed, May 21, 2025 at 11:14:21AM +0100, Bruce Richardson wrote: > patch prefix should be "net/e1000" rather than "net/intel". Even though > patches are moved to an "intel" subdir, we still use the prefix of the > actual driver name. As a general guideline, only use "intel" when modifying > multip

[PATCH v2] ethdev: optimize how the values of the flag variables are assigned

2025-05-21 Thread Sunyang Wu
Set the values of the promiscuous and all_multicast variables according to the return value. Signed-off-by: Morten Brørup Signed-off-by: Sunyang Wu --- lib/ethdev/rte_ethdev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rt

Re: [PATCH] net/intel: fix igb tx queue offloads capability

2025-05-21 Thread Bruce Richardson
On Wed, May 07, 2025 at 09:59:04AM +0100, Deng, KaiwenX wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, April 28, 2025 11:21 PM > > To: Deng, KaiwenX > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > > Yaroslav Brustinov > > Subject: Re: [PATCH] net

Re: [PATCH] net/intel: fix igb tx queue offloads capability

2025-05-21 Thread Bruce Richardson
patch prefix should be "net/e1000" rather than "net/intel". Even though patches are moved to an "intel" subdir, we still use the prefix of the actual driver name. As a general guideline, only use "intel" when modifying multiple intel drivers or the common directory. On Mon, Apr 14, 2025 at 04:53:5

Re: [PATCH v2 1/2] net: fix offset calculation for GENEVE packet

2025-05-21 Thread huangdengdui
I have also found some bugs about the tunnel packet type parsing API[1], including one of the problems fixed by this patch. [1] https://patchwork.dpdk.org/project/dpdk/list/?series=35233 On 2025/5/21 13:11, sk...@marvell.com wrote: > From: Sunil Kumar Kori > > While parsing packet headers, off

[DPDK/core Bug 1708] rte_malloc_socket failed to allocate with large alignment and ASan

2025-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1708 Bug ID: 1708 Summary: rte_malloc_socket failed to allocate with large alignment and ASan Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCO

RE: [PATCH] test/crypto: fix return value in RSA test

2025-05-21 Thread Akhil Goyal
Cc: sta...@dpdk.org > Subject: [PATCH] test/crypto: fix return value in RSA test > > This patch fixes incorrect return value when RSA negative > test scenario is validated. > > Coverity-issue: 457463 > Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification") > > Signed-off-by:

RE: [PATCH] test/crypto: fix return value in RSA test

2025-05-21 Thread Akhil Goyal
> This patch fixes incorrect return value when RSA negative > test scenario is validated. > > Coverity-issue: 457463 > Fixes: 9682e8246ae ("test/crypto: add negative case for RSA verification") > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal Applied to dpdk-next-crypto Than

RE: [PATCH] crypto/cnxk: fix uninitialized scalar variable

2025-05-21 Thread Akhil Goyal
> > This change fixes an uninitialized local variable as reported in coverity > > issue > > 445390. > > > > Coverity-issue: 445390 > > Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal Applied to dp

RE: [PATCH] crypto/cnxk: fix out-of-bounds access

2025-05-21 Thread Akhil Goyal
> > Fix coverity issue on out-of-bounds access. > > Coverity-issue: 403166, 403171, 403172 > Fixes: 5686b573e4b ("crypto/cnxk: support SM2") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH] crypto/virtio: check for invalid IOVA address

2025-05-21 Thread Akhil Goyal
> This change fixes coverity issue on overflowed constant. > Bad phys address should be checked before using it in > descriptor. > > Coverity issue: 457462, 457465 > Fixes: 10702138f1a ("crypto/virtio: support asymmetric RSA") > > Signed-off-by: Gowrishankar Muthukrishnan Cc: sta...@dpdk.org Ack

RE: [PATCH v2] test/crypto: increment dequeue timeout

2025-05-21 Thread Akhil Goyal
> Increment dequeue timeout to allow implementations taking > longer cycles. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks

Re: [PATCH] eal/linux: unregister alarm callback before free ptr

2025-05-21 Thread David Marchand
On Tue, May 20, 2025 at 5:08 PM Rui Ferreira wrote: > > This was flagged by Address sanitizer as a use after free. The > intr_handle ptr is shared between the main thread and the interrupt > thread, and the interrupt thread can dereference the ptr after free > is called when the main thread cleans

RE: [PATCH 6/9] crypto/dpaa2_sec: add null algo capability

2025-05-21 Thread Gagandeep Singh
Hi, > -Original Message- > From: Hemant Agrawal (OSS) > Sent: Tuesday, May 20, 2025 11:50 AM > To: Gagandeep Singh ; dev@dpdk.org; Hemant Agrawal > > Subject: Re: [PATCH 6/9] crypto/dpaa2_sec: add null algo capability > > > On 20-05-2025 11:21, Gagandeep Singh wrote: > > This patch add

[PATCH v2] net/tap: fix add qdisc failed when create tap

2025-05-21 Thread Yan Lu
From: luyan The errno variable was assigned a positive value in the previous handling, but here it is compared against -EEXIST, When the tap already exists, this would falsely report an error. Fixes: 6fc6de7e0eaf ("net/tap: update netlink error code management") Signed-off-by: Yan Lu --- .mai

[PATCH v2 1/2] net: fix offset calculation for GENEVE packet

2025-05-21 Thread skori
From: Sunil Kumar Kori While parsing packet headers, offset must be added to get next header but for geneve header parsing offset is overwritten. Also inner_l2_len is not set in case of geneve packets. Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing") Signed-off-by: Sunil Kumar Kori

[PATCH] examples/flow_filtering: add re-route to kernel snippet

2025-05-21 Thread Shani Peretz
The snippet enables direct packet re-routing to kernel by using the new RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL action. Added support for snippet-specific configurations: * port configuration: set promiscuous mode / flow isolation mode * Flow configuration: Setup beyond basic ingress flows Signed

[PATCH v2 8/9] mempool/dpaa2: mempool operation index

2025-05-21 Thread Gagandeep Singh
From: Jun Yang For user to identify dpaa2 mempool by operation index. Signed-off-by: Jun Yang --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 20 +++- drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 5 - 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/mem

[PATCH v2 9/9] crypto/dpaa2_sec: add support for simple IPsec FD

2025-05-21 Thread Gagandeep Singh
From: Jun Yang For IVP mode of simple IPsec FD, store op context point just before expansion and align with point size(8). Otherwise, store op context point in offset to mbuf with rte_mbuf_dynfield register. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 143

Re: [PATCH] eal: add getline() function for Windows

2025-05-21 Thread Thomas Monjalon
21/05/2025 02:35, Andre Muezerie: > On Tue, May 20, 2025 at 10:14:33AM -0700, Stephen Hemminger wrote: > > On Mon, 5 May 2025 13:40:07 -0700 > > Andre Muezerie wrote: > > > > > Existing DPDK code uses getline(), which is a POSIX function and is > > > not available in the Windows APIs. > > > > >