[RFC 12/13] app/testpmd: support for port mirroring

Add new commands to enable testing of port mirror functionality. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 1 + app/test-pmd/cmdline_mirror.c | 120 app/test-pmd/cmdline_mirror.h | 12 ++ app/test-pmd/me

Re: [PATCH v4 1/1] mbuf: enable to be compiled with MSVC

On Wed, Apr 09, 2025 at 06:42:10AM -0700, Andre Muezerie wrote: > On Wed, Apr 09, 2025 at 01:39:36PM +0200, David Marchand wrote: > > On Tue, Apr 8, 2025 at 11:24 PM Andre Muezerie > > wrote: > > > diff --git a/lib/net/meson.build b/lib/net/meson.build > > > index 7a6c419f40..c528fcc9a2 100644 > >

Re: [PATCH v6 00/10] enable "app" to be compiled with MSVC

On Fri, Apr 11, 2025 at 08:49:40AM +0200, David Marchand wrote: > Hello Andre, > > On Mon, Feb 24, 2025 at 5:25 PM Andre Muezerie > wrote: > > > > v6: > > - remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC > > qualified lcore_count, which is cleaner than using "volatile". > > >

[RFC 07/13] net/null: all lockfree transmit

For testing mirror, useful if this device allows lockfree Tx. Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 6764cf2ec1..d9210d867f 100644 --- a/drive

[RFC 06/13] net/ring: add timestamp devargs

Add argument to ring PMD creation to force packets going into ring to be timestamped. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 44 +++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/driv

[RFC 03/13] test: add test for hotplug and secondary process operations

Use null device to exercise ethdev start/stop in secondary process. Signed-off-by: Stephen Hemminger --- app/test/test_mp_secondary.c | 51 +--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondar

[RFC 13/13] app/dumpcap: use port mirror instead of pdump

Use the new port mirror API instead of pdump. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 361 +++- app/dumpcap/meson.build | 2 +- 2 files changed, 284 insertions(+), 79 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c i

[RFC 11/13] test: add tests for ethdev mirror

Simple API and packet mirroring standalone tests. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 1 + app/test/test_ethdev_mirror.c | 286 ++ 2 files changed, 287 insertions(+) create mode 100644 app/test/test_ethdev_mirror.c diff --git a

[RFC 10/13] pcapng: split packet copy from header insertion

In new model, the packet was already copied, only need to wrap it in pcapng format. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 178 +--- lib/pcapng/rte_pcapng.h | 27 +- 2 files changed, 120 insertions(+), 85 deletions(-) diff --git a

[RFC 09/13] ethdev: add port mirror capability

This adds new feature for port mirroring. Signed-off-by: Stephen Hemminger --- config/rte_config.h | 2 + lib/ethdev/ethdev_driver.h | 3 + lib/ethdev/ethdev_private.c | 3 + lib/ethdev/ethdev_trace.h| 14 +++ lib/ethdev/ethdev_trace_points.c | 6 + lib/e

[RFC 05/13] net/ring: add argument to attach existing ring

Need ability to allow process like dumpcap to make a ring ethdev with a pre-existing ring. Do this via devargs so it can work with hotplug. The API rte_eth_from_ring() doesn't do this. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 30 ++ 1 fi

[RFC 08/13] mbuf: add fields for mirroring

Add field to union used for sched/event etc, for use when an mbuf is mirrored. Signed-off-by: Stephen Hemminger --- lib/mbuf/rte_mbuf_core.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h index a0df265b5d..180667 100644 --- a/l

[RFC 04/13] net/ring: allow lockfree transmit if ring supports it

Need to be able have multiple threads all using same transmit queue when using SPAN. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index

[RFC 02/13] ethdev: allow start/stop from secondary process

Before this patch if secondary process called start/stop it would only impact the secondary process, the ethdev on the primary process will still not be started. With this patch, when start/stop is called from secondary, it calls the primary and does the operation there. The design is generic, and

[RFC 01/13] app/testpmd: revert auto attach/detach

Revert "app/testpmd: add port attach/detach for multiple process" This reverts commit 994635edb2c038e64617bcf2790a8cd326c3e8e0. This commit breaks using pdump and other secondary processes that create there own devices. The patch makes testpmd grab any new hotplug device and configure it. It may

[RFC 00/13] Packet capture using port mirroring

This is a rework of how packet capture is done in DPDK. The existing mechanism using callbacks has a number of problems; the main one is that any packets sent/received in a secondary process are not visible. The root cause is that callbacks can not function across process boundaries, they are speci

Re: [PATCH 3/4] usertools: parse strings from PE images

On 11.04.2025 22:39, Andre Muezerie wrote: diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 9189a2fdbc..77789c979c 100755 --- a/usertools/dpdk-pmdinfo.py +++ b/usertools/dpdk-pmdinfo.py @@ -40,6 +40,12 @@ import elftools from elftools.elf.elffile import ELFError, ELFFi

Re: [PATCH 2/4] buildtools: use macro to embed information in binaries

On 11.04.2025 22:39, Andre Muezerie wrote: buildtools/meson.build was updated to require Python module "pefile" on Windows. This module is used to parse symbols on Windows images. Windows images are in PE format (opposed to ELF on Linux). It is not used on build stage and thus is not needed. Th

[PATCH] mldev: enable to be compiled with msvc

Now that the issues preventing this lib from being compiled with MSVC are solved, it can be enabled. Signed-off-by: Andre Muezerie --- lib/mldev/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build index 2c933baad6..0079ccd205 100644

DTS Meeting Minutes - April 10, 2025

# April 10, 2025 Attendees * Patrick Robb * Luca Vizzarro # Minutes = General Discussion * DT

[PATCH 4/4] drivers: use macro to embed information in binaries

DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

[PATCH 3/4] usertools: parse strings from PE images

Script usertools\dpdk-pmdinfo.py was enhanced to also be able to parse symbols from sections in PE images. Signed-off-by: Andre Muezerie --- usertools/dpdk-pmdinfo.py | 47 ++- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/usertools/dpdk-pmdin

[PATCH 2/4] buildtools: use macro to embed information in binaries

The archiver tool from the MSVC toolset is lib.exe. It has different parameters then it's GNU counterpart "ar". buildtools\meson.build was updated to use lib.exe when MSVC compiler is used. This is to allow the code to be built without requiring GNU "ar" to be installed in that scenario. Script g

[PATCH 0/4] allow pmdinfo to be inserted and parsed using MSVC

DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

[PATCH 1/4] eal: add macro to embed information in binaries

DPDK uses GCC attribute "used" through macro __rte_used to indicate that a variable not referenced in the code should be assumed being used and therefore not be optimized away. This technique is used to embed information in the binaries, by having crafted information stored in them. MSVC offers si

Re: 24.11.2 patches review and test

On 28/03/2025 10:14, Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 24.11.2. > > The planned date for the final release is 14 April. > Hi Hailin/John, Do you have any updates or ETA for testing on 24.11.2 ? If possible I would like to release by 15th

[PATCH v2] doc: reword contributor's guide for grammar/clarity

Reviewing the Contributor Guidleines for grammar and comprehension. Signed-off-by: Nandini Persad --- doc/guides/contributing/coding_style.rst | 105 +++ doc/guides/contributing/design.rst | 9 +- doc/guides/contributing/new_library.rst | 31 --- 3 files changed

Re: [PATCH 1/3] app/testpmd: add/remove multiple VLAN filter IDs at once

On Fri, 11 Apr 2025 16:10:03 +0800 Chaoyong He wrote: > From: Long Wu > > The command of setting VLAN filter IDs can only set one VLAN filter > ID at once. For example: > testpmd> rx_vlan add 100 0 > > This is very inefficient in some case because it forces the > user type this command as ma

Re: [RFC PATCH] add rust binding support to DPDK

> From: Etelson, Gregory > Sent: Friday, April 11, 2025 4:39 PM > To: Van Haaren, Harry > Cc: Richardson, Bruce; dev@dpdk.org > Subject: Re: [RFC PATCH] add rust binding support to DPDK > > Hello Bruce & Harry, > > > > > > >> My concern is how to properly maintain Rust crate once DPDK starts to

[PATCH v3] doc: remove known issues

I have uploaded all these known issues into Bugzilla, so they are not needed here anymore. Signed-off-by: Nandini Persad --- doc/guides/rel_notes/index.rst| 1 - doc/guides/rel_notes/known_issues.rst | 875 -- 2 files changed, 876 deletions(-) delete mode 10064

Re: [RFC PATCH] add rust binding support to DPDK

Hello Bruce & Harry, My concern is how to properly maintain Rust crate once DPDK starts to implement it's own API. I'm not really sure what is meant here. I don't understand what "own" word refers to? I see it like this: - DPDK has the public C API exported (and that stays the same as to

Re: 24.11.2 patches review and test

On 10/04/2025 15:40, Ali Alnubani wrote: > Hello, > > We ran the following functional tests with Nvidia hardware on v24.11.2-rc1: > > - Basic functionality: >   Send and receive multiple types of traffic. > - testpmd xstats counter test. > - testpmd timestamp test. > - Changing/checking link st

Re: [PATCH v1] net/idpf: avoid truncation of constant value

On Fri, Apr 11, 2025 at 08:52:12AM +0200, David Marchand wrote: > On Wed, Apr 9, 2025 at 4:27 PM Bruce Richardson > wrote: > > > > On Wed, Apr 09, 2025 at 12:54:40PM +, Praveen Shetty wrote: > > > Truncation of constant value compiler warning was reported in clang/msvc > > > compiler for the V

Re: [RFC PATCH] add rust binding support to DPDK

> From: Etelson, Gregory > Sent: Thursday, April 10, 2025 6:28 AM > To: Richardson, Bruce > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH] add rust binding support to DPDK > > Hello Bruce, Hi Bruce & Gregory, > > Add a Cargo.toml file in the root folder and a number of other scripts > > and rust-re

Re: [PATCH v1 00/32] add new adapter NT400D13

Hi Stephen, Some time ago we received the change request about usage of threads inside of the ntnic PMD driver. I would like to discuss this request. In our case, some threads are part of the design of the protocols between the driver and the FPGA, and are required for both functionality, robust

[PATCH v2 5/5] app/eventdev: update eventdev app for SNOW-V

Update eventdev app to handle SNOW-V correctly. Signed-off-by: Radu Nicolau --- app/test-eventdev/evt_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c index 323d1e724d..7903b5959c 100644 --- a/app/te

[PATCH v2 4/5] app/crypto-perf: add support for SNOW-V

Add support for SNOW-V and SNOW-V AEAD algorithms. Signed-off-by: Radu Nicolau --- app/test-crypto-perf/cperf_ops.c | 6 -- doc/guides/tools/cryptoperf.rst | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_op

[PATCH v2 2/5] examples/l2fwd-crypto: add support for SNOW-V

Update l2fwd-crypto to be able to correctly handle SNOW-V Signed-off-by: Radu Nicolau --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index a441312f55..f1a6ca8899 100644 --- a/examp

[PATCH v2 3/5] tests: add unit tests and test vectors for SNOW-V

Add unit tests and test vectors for SNOW-V and SNOW-V AEAD. Signed-off-by: Radu Nicolau --- app/test/test_cryptodev.c | 599 ++ app/test/test_cryptodev_aead_test_vectors.h | 275 app/test/test_cryptodev_snow_v_test_vectors.h | 213 +++ 3 files c

[PATCH v2 1/5] crypto/ipsec_mb: add support for SNOW-V

Add support for SNOW-V and SNOW-V AEAD algorithms to crypto/ipsec_mb PMD. Signed-off-by: Radu Nicolau --- doc/guides/cryptodevs/aesni_mb.rst | 2 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 70 +++-- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 52 +++

[PATCH v2 0/5] add SNOW-V support in ipsec_mb PMD

Add support for SNOW-V and SNOW-V AEAD in ipsec_mb PMD. Add unit tests and test vectors for SNOW-V and SNOW-V AEAD. Add support in cryptoperf and eventdev test apps. Radu Nicolau (5): crypto/ipsec_mb: add support for SNOW-V examples/l2fwd-crypto: add support for SNOW-V tests: add unit tests

Re: [PATCH] maintainers: update for hns3

Hi, maintainers, Kindly ping for reviews. Thanks. On 2025/4/2 16:47, Jie Hai wrote: I am moving on to other things and dengdui is going to take over the role of hns3 maintainer. Update the MAINTAINERS accordingly. Signed-off-by: Jie Hai --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] net: fix GTP packet parsing

Good job! Acked-by: Jie Hai On 2025/4/11 16:43, Dengdui Huang wrote: After parsing the GTP packet header, the next protocol type should be converted from RTE_GTP_TYPE_IPV4/IPV6 to RTE_ETHER_TYPE_IPV4/IPV6. Otherwise, the next protocol cannot be parsed. Fixes: 64ed7f854cf4 ("net: add tunnel pa

[PATCH] net: fix GTP packet parsing

After parsing the GTP packet header, the next protocol type should be converted from RTE_GTP_TYPE_IPV4/IPV6 to RTE_ETHER_TYPE_IPV4/IPV6. Otherwise, the next protocol cannot be parsed. Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang ---

[PATCH 2/3] ethdev: retrieve VLAN filter configuration

From: Long Wu Added an API `rte_eth_dev_get_vlan_filter_conf()` to retrieve the VLAN filter configuration of an Ethernet device. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- doc/guides/rel_notes/release_25_07.rst | 5 + lib/ethdev/ethdev_trace.h | 8 lib/eth

[PATCH 3/3] app/testpmd: add a command to show VLAN filter IDs

From: Long Wu Introduce a new command to show the VLAN identifiers filtered by a port. Usage example: testpmd> rx_vlan show port 0 VLAN filter IDs: 1,4-5,9,12,14,18,3864-3865,3869,3874,3878,4076-4091,4093,4095, testpmd> Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- app/test-pmd/cmdline.

[PATCH 1/3] app/testpmd: add/remove multiple VLAN filter IDs at once

From: Long Wu The command of setting VLAN filter IDs can only set one VLAN filter ID at once. For example: testpmd> rx_vlan add 100 0 This is very inefficient in some case because it forces the user type this command as many times as the VLAN filter IDs they want to set. This patch supports the

[PATCH 0/3] enhance the vlan filter feature

This patch series aims to enhance the vlan filter feature: - Support add/remove multiple vlan IDs just in one comment. - Support show the already configured vlan IDs. Long Wu (3): app/testpmd: add/remove multiple VLAN filter IDs at once ethdev: retrieve VLAN filter configuration app/testpmd:

[PATCH] ci: check licenses

Call check-spdx.tag.sh so that all committed files are checked. Signed-off-by: David Marchand --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a6b679fe5..1e289979e3 100644 --- a/.github/workflows/