[PATCH] common/mlx5: add ConnectX-8 device ID

2025-02-22 Thread Raslan Darawsheh
This adds the ConnectX-8 device id to the list of supported Nvidia devices that run the MLX5 PMDs. The devices is still in development stage. Signed-off-by: Raslan Darawsheh --- doc/guides/cryptodevs/mlx5.rst | 6 -- doc/guides/nics/mlx5.rst | 28 +

[v2 2/2] test/crypto: add negative test for RSA verify op

2025-02-22 Thread Gowrishankar Muthukrishnan
Add negative test for RSA verify operation to check if incorrect signature is validated. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - no changes, but added openssl pmd patch for CI. --- app/test/test_cryptodev_asym.c | 27 +-- 1 file changed, 25 insertions(+), 2 d

[v2 1/2] crypto/openssl: validate incorrect signature in verify op

2025-02-22 Thread Gowrishankar Muthukrishnan
Return correct error status when incorrect signature is used in RSA verify op. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- v2: - clubbed with test patch --- drivers/crypto/openssl/rte_openssl_pmd.

[RFC 2/5] net/zxdh: remove __rte_unused attribute

2025-02-22 Thread Stephen Hemminger
These are all function arguments that are used but incorrectly labeled as unused. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_ethdev.c | 2 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 2 +- drivers/net/zxdh/zxdh_msg.c| 20 drivers/net/zxdh/zxdh_mtr.c

[RFC 5/5] net/zxdh: fix indentation in mtr get and use assign

2025-02-22 Thread Stephen Hemminger
Fix the indentation of the initialized structure and use assignment instead of memcpy Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_mtr.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/zxdh/zxdh_mtr.c b/drivers/net/zxdh

[RFC 4/5] net/zxdh: make callback table const and static

2025-02-22 Thread Stephen Hemminger
Tables of function pointers should be const, and since only used in one file can be marked static. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_msg.c | 2 +- drivers/net/zxdh/zxdh_msg.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/zxdh/zxdh_msg.c

[RFC 3/5] net/zxdh: fix RTE_ASSERT expression

2025-02-22 Thread Stephen Hemminger
The parameter in RTE_ASSERT() was incorrect. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_msg.c b/drivers/net/zxdh/zxdh_msg.c index 5a47b4fde6..4cd58ca0cb 100644 --- a/drivers/net/zxdh/z

[RFC 1/5] net/zxdh: remove __rte_unused from function prototypes

2025-02-22 Thread Stephen Hemminger
The unused attribute needs to be used on the function definition only. It is meaningless on function prototype. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_ethdev_ops.h | 10 -- drivers/net/zxdh/zxdh_mtr.h| 4 ++-- drivers/net/zxdh/zxdh_np.h | 2 +- drive

[RFC 0/5] net/zxdh: possible changes

2025-02-22 Thread Stephen Hemminger
Reviewing zxdh driver these are some obvious things that could be fixed Stephen Hemminger (5): net/zxdh: remove __rte_unused from function prototypes net/zxdh: remove __rte_unused attribute net/zxdh: fix RTE_ASSERT expression net/zxdh: make callback table const and static net/zxdh: fix i

Re: [PATCH v1 25/32] net/ntnic: add SPI v3 support for FPGA

2025-02-22 Thread Stephen Hemminger
On Thu, 20 Feb 2025 23:03:49 +0100 Serhii Iliushyk wrote: > +/* > + * Send Tx data using the SPIM module and receive any data using the SPIS > module. > + * The data are sent and received being wrapped into a SPI v3 container. > + */ > +int nthw_spi_v3_transfer(nthw_spi_v3_t *p, uint16_t opcode,

Re: [PATCH v1 00/32] add new adapter NT400D13

2025-02-22 Thread Stephen Hemminger
On Thu, 20 Feb 2025 23:03:24 +0100 Serhii Iliushyk wrote: > This patchset adds support for the new adapter NT400D13. > > Danylo Vodopianov (23): > net/ntnic: add link agx 100g > net/ntnic: add link state machine > net/ntnic: add rpf and gfg init > net/ntnic: add agx setup for port > ne

[v4 2/6] crypto/virtio: refactor queue operations

2025-02-22 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34682 ("vhost: add RSA support") --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virti

Re: [PATCH v2 14/14] net/zxdh: clean stat values

2025-02-22 Thread Stephen Hemminger
On Sat, 22 Feb 2025 15:22:32 +0800 Bingbin Chen wrote: > Implement stat values clean operation by agent channel. > > Signed-off-by: Bingbin Chen > --- The conversion to spinlock is good idea, but now the lock annotation is catching a different issue. It helps to have a cover letter on each pa

[PATCH v2 07/14] net/zxdh: get flow tables resources

2025-02-22 Thread Bingbin Chen
Implement the flow tables resources get operation by agent channel. Signed-off-by: Bingbin Chen --- drivers/net/zxdh/zxdh_ethdev.c | 18 ++ drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_np.c | 490 + drivers/net/zxdh/zxdh_np.h | 336 ++

[PATCH v2 00/14] add network processor ops

2025-02-22 Thread Bingbin Chen
V2: - resolve code style and github-robot build issue. - eliminate commit warning. - remove unnecessary initialization, which first usage will set. - replace mutex lock with spinlock. V1: - updated network processor driver. - improve insert/delete/get table code funcs. Bingbin Chen (1

[v4 4/6] crypto/virtio: add vDPA backend

2025-02-22 Thread Gowrishankar Muthukrishnan
Add vDPA backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34682 ("vhost: add RSA support") v4: - fixed CI issue. --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virti

[v4 5/6] test/crypto: add asymmetric tests for virtio PMD

2025-02-22 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 28 1 file changed, 28 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 9b5f3c545e..ac47be724f 100644

[v4 5/5] examples/vhost_crypto: support asymmetric crypto

2025-02-22 Thread Gowrishankar Muthukrishnan
Support asymmetric crypto operations. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 50 +++- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index b1fe4120b9

[v4 6/6] test/crypto: add tests for virtio user PMD

2025-02-22 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a/app

[v4 2/5] vhost: update vhost_user crypto session parameters

2025-02-22 Thread Gowrishankar Muthukrishnan
As per requirements on vhost_user spec, session id should be located at the end of session parameter. Update VhostUserCryptoSessionParam structure to support newer QEMU. Due to additional parameters added in QEMU, received payload from QEMU would be larger than existing payload, hence breaks parsi

[v4 3/6] crypto/virtio: add packed ring support

2025-02-22 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34682 ("vhost: add RSA support") --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers

[v4 1/6] crypto/virtio: add asymmetric RSA support

2025-02-22 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34682 ("vhost: add RSA support") --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c |

[v4 0/6] crypto/virtio: enhancements for RSA and vDPA

2025-02-22 Thread Gowrishankar Muthukrishnan
This patch series enhances virtio crypto PMD to: * support RSA * support packed virtio ring * support vDPA backend v4: - CI issue fixed. Depends-on: series-34682 ("vhost: add RSA support") Gowrishankar Muthukrishnan (6): crypto/virtio: add asymmetric RSA support crypto/virtio: refactor q

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

2025-02-22 Thread Thomas Monjalon
22/02/2025 00:05, Stephen Hemminger: > On Wed, 19 Feb 2025 15:55:17 +0100 > Thomas Monjalon wrote: > > > 14/02/2025 18:20, Stephen Hemminger: > > > The Linux version of sys/queue.h is frozen at an older version > > > and is missing the _SAFE macro variants. Several drivers started > > > introduci

[v4 4/5] vhost: support asymmetric RSA crypto ops

2025-02-22 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- v4: - fixed CI issue. --- lib/vhost/vhost_crypto.c | 486 +++--- lib/vhost/virtio_crypto.h | 67 ++ 2 files changed, 518 insertions(+), 35 deletions(-) di

[v4 3/5] examples/vhost_crypto: fix user callbacks

2025-02-22 Thread Gowrishankar Muthukrishnan
In order to handle new vhost user connection, use new_connection and destroy_connection callbacks. Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 4 ++-- 1 file changed, 2 ins

[v4 0/5] vhost: add RSA support

2025-02-22 Thread Gowrishankar Muthukrishnan
This patch series supports asymmetric RSA in vhost crypto library. It also includes changes to improve vhost crypto library: * support newer QEMU versions. * fix broken vhost_crypto example application. * stabilize crypto fastpath operations. v4: - fixed CI issues. Gowrishankar Muthukrishnan

[v4 1/5] vhost: skip crypto op fetch before vring init

2025-02-22 Thread Gowrishankar Muthukrishnan
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory fault. Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- li