RE: [PATCH 1/3] eventdev/eth_rx: add API to burst add queues to Rx adapter

2025-02-17 Thread Shijith Thotton
> >This patch introduces a new API, rte_event_eth_rx_adapter_queues_add(), >to allow bulk addition of multiple Rx queues in the eventdev Rx adapter. > >The existing rte_event_eth_rx_adapter_queue_add() API supports adding >multiple queues by specifying rx_queue_id = -1, but it lacks the ability >to

RE: [PATCH 0/3] Rx adapter API to add Rx queues in burst

2025-02-17 Thread Shijith Thotton
> > Documentation update is missing. > Missed it, I will update in v2. Thanks, Shijith >This patch series introduces the rte_event_eth_rx_adapter_queues_add() >API, allowing multiple Rx queues to be added to an Rx adapter in a >single burst. This enhancement benefits applications that require bu

Re: [RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Stephen Hemminger
I found a bunch more cases will send V2 On Mon, Feb 17, 2025, 12:24 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 17 February 2025 19.54 > > > > A common pattern in DPDK internals is to have an array of function > > pointers. When using th

[DPDK/testpmd Bug 1663] [dpdk-25.03] flexible_rxd/check_IPv4_IPv6_TCP_fields_in_RXD_on_specific_queues: port config rxq/txq failed after attach port

2025-02-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1663 Bug ID: 1663 Summary: [dpdk-25.03] flexible_rxd/check_IPv4_IPv6_TCP_fields_in_RXD_on_spec ific_queues: port config rxq/txq failed after attach port Product: DPDK

RE: [RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 17 February 2025 19.54 > > A common pattern in DPDK internals is to have an array of function > pointers. When using these pointers an unnecessary derefence is done; > this is allowed in C because of a historical quirk b

[RFC 08/11] dmadev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent. Signed-off-by: Stephen Hemminger --- lib/dmadev/rte_dmadev.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev

[RFC 01/11] ethdev: remove unnecessary deref on function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_driver.c | 16 +- lib/ethdev/ethdev_private.c | 4 +- lib/ethdev/rte_ethdev.c | 489 +++

[RFC 11/11] regexdev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/regexdev/rte_regexdev.c | 72 ++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c

[RFC 10/11] mldev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/mldev/rte_mldev.c | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/lib/mldev/rte_mldev.c b/lib/

[RFC 06/11] crypto/scheduler: remove unnecessary dereference

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->sym_session_get_size and dev->dev_ops->sym_session_get_size are equivalent. Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd_ops.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_

[RFC 09/11] rawdev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_configure and dev->dev_ops->dev_configure are equivalent. Signed-off-by: Stephen Hemminger --- lib/rawdev/rte_rawdev.c | 99 - 1 file changed, 48 insertions(+), 51 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/r

[RFC 07/11] compressdev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->info_get are equivalent. Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_compressdev.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b

[RFC 05/11] cryptodev: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->dev_info_gets are equivalent. Cleanup and remove unnecessary parenthesis as well. Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 72 +-- 1 file changed, 35 insertions(+), 37 deleti

[RFC 04/11] net/memif: remove unnecessary deref of function pointers

2025-02-17 Thread Stephen Hemminger
Since queue release functions are local to driver, prefer those over dereferencing the dev_ops table. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/

[RFC 02/11] eventdev: remover unnecessary deref on function pointers

2025-02-17 Thread Stephen Hemminger
The expression *dev_dev_ops->foo and dev->dev_ops->foo are equivalent. Cleanup the result by removing unneeded parenthesis and make lines compact. Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 36 ++ lib/eventdev/rte_event_dma_adapter.c| 16 +-- lib/eve

[RFC 03/11] net/ixgbe: remove unnecessary dereference

2025-02-17 Thread Stephen Hemminger
The expression *dev->dev_ops->vlan_strip_queue_set and dev->dev_ops->vlan_strip_queue are equivalent in C. Signed-off-by: Stephen Hemminger --- drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/intel/ixgbe/rte_pmd_ixgbe.c

[RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Stephen Hemminger
A common pattern in DPDK internals is to have an array of function pointers. When using these pointers an unnecessary derefence is done; this is allowed in C because of a historical quirk but unnecessary. The PVS Studio checker flags these as: https://pvs-studio.com/en/docs/warnings/v516/ This l

Re: [PATCH v2 4/4] net/ixgbe: prevent crashes in secondary processes

2025-02-17 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 17/02/2025 13:54, Anatoly Burakov wrote: Currently, the architecture of IXGBE base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents IXGBE ethdev d

[PATCH v2] testpmd: support meter_mark init_color in indirect list configuration

2025-02-17 Thread Gregory Etelson
Flow actions parameters in indirect actions list are created as read-only and shared between all flows that reference that indirect list. If a flow rule needs to apply rule specific actions list parameters it does it with the indirect actions list conf parameter. The patch allows flow rule to set

Re: [PATCH v2 1/6] ethdev: check that device supports deferred start

2025-02-17 Thread Bruce Richardson
On Fri, Feb 14, 2025 at 09:38:54AM -0800, Stephen Hemminger wrote: > The check for supporting deferred start should be handled at > the ethdev level for all devices. > > Signed-off-by: Stephen Hemminger > Acked-by: Andrew Rybchenko > --- > lib/ethdev/rte_ethdev.c | 14 ++ > 1 file c

Re: [PATCH v2 0/6] fix the handling of deferred start in ethdev

2025-02-17 Thread Bruce Richardson
On Fri, Feb 14, 2025 at 09:38:53AM -0800, Stephen Hemminger wrote: > There is a inconsistency and lack of documentation around the deferred > start configuration flag. The queue deferred start only makes sense if > the driver has a way to start the queue later via ethdev ops. > Therefore move the c

Re: [PATCH] testpmd: support meter_mark init_color in indirect list configuration

2025-02-17 Thread Stephen Hemminger
On Sun, 16 Feb 2025 16:04:20 +0200 Gregory Etelson wrote: > Flow actions parameters in indirect actions list are created as > read-only and shared between all flows that reference that indirect > list. > > If a flow rule needs to apply rule specific actions list parameters it > does it with the

Re: [PATCH 0/3] Rx adapter API to add Rx queues in burst

2025-02-17 Thread Naga Harish K, S V
Documentation update is missing. From: Shijith Thotton Sent: Friday, February 7, 2025 7:39 PM To: jer...@marvell.com Cc: pbhagavat...@marvell.com ; Shijith Thotton ; dev@dpdk.org Subject: [PATCH 0/3] Rx adapter API to add Rx queues in burst This patch series

Re: [PATCH 1/3] eventdev/eth_rx: add API to burst add queues to Rx adapter

2025-02-17 Thread Naga Harish K, S V
From: Shijith Thotton Sent: Friday, February 7, 2025 7:39 PM To: jer...@marvell.com Cc: pbhagavat...@marvell.com ; Shijith Thotton ; dev@dpdk.org ; Pathak, Pravin ; Hemant Agrawal ; Sachin Saxena ; Mattias R_nnblom ; Liang Ma ; Mccarthy, Peter ; Van Haaren,

Re: [PATCH v2 1/4] net/e1000: prevent crashes in secondary processes

2025-02-17 Thread Bruce Richardson
On Mon, Feb 17, 2025 at 01:54:05PM +, Anatoly Burakov wrote: > Currently, the architecture of e1000 base driver is such that it uses > function pointers internally. These are not guaranteed to be valid in > secondary processes, which can lead to crashes. This patch prevents EM > ethdev driver f

Re: [PATCH] net/i40e: reduce log level of global register update msg

2025-02-17 Thread Bruce Richardson
On Tue, Feb 11, 2025 at 02:57:21PM +0100, David Marchand wrote: > On Tue, Jan 21, 2025 at 5:36 PM Bruce Richardson > wrote: > > > > The modifying of a global register value, which has an affect on multiple > > ports is an important change to HW. However, the actual details of that > > change is on

[PATCH v2 3/4] net/e1000: prevent crashes in secondary processes

2025-02-17 Thread Anatoly Burakov
Currently, the architecture of e1000 base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents IGC ethdev driver from calling into these functions. Fixes: 4f09bc55ac3d ("net/igc: implem

[PATCH v2 4/4] net/ixgbe: prevent crashes in secondary processes

2025-02-17 Thread Anatoly Burakov
Currently, the architecture of IXGBE base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents IXGBE ethdev driver from calling into these functions. Bugzilla ID: 1575 Fixes: af75078fe

[PATCH v2 2/4] net/e1000: prevent crashes in secondary processes

2025-02-17 Thread Anatoly Burakov
Currently, the architecture of e1000 base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents IGB ethdev driver from calling into these functions. Fixes: af75078fece3 ("first public re

[PATCH v2 1/4] net/e1000: prevent crashes in secondary processes

2025-02-17 Thread Anatoly Burakov
Currently, the architecture of e1000 base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. This patch prevents EM ethdev driver from calling into these functions. Fixes: 805803445a02 ("e1000: support E

Re: [PATCH] crypto/openssl: validate incorrect signature in verify op

2025-02-17 Thread Ji, Kai
From: Gowrishankar Muthukrishnan Sent: Sunday, February 16, 2025 14:28 To: dev@dpdk.org; Akhil Goyal; Ji, Kai; Fan Zhang Cc: ano...@marvell.com; Gowrishankar Muthukrishnan; sta...@dpdk.org Subject: [PATCH] crypto/openssl: validate incorrect signature in verify op

Re: [PATCH v2 6/7] dts: revamp runtime internals

2025-02-17 Thread Luca Vizzarro
On 14/02/2025 18:54, Nicholas Pratte wrote: This definitely cleans things up a lot! Reviewed-by: Nicholas Pratte @@ -217,9 +218,7 @@ def get_supported_capabilities( ) if cls.capabilities_to_check: capabilities_to_check_map = cls._get_decorated_capabilities_m

[DPDK/testpmd Bug 1662] [dpdk-25.03] [NNT] pmd_bonded_8023ad: port start failed after set bonding lacp

2025-02-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1662 Bug ID: 1662 Summary: [dpdk-25.03] [NNT] pmd_bonded_8023ad: port start failed after set bonding lacp Product: DPDK Version: 24.07 Hardware: x86 OS: Linux