DPDK detect vfio container according the existence of vfio
module. But for container with non-privileged mode, there is
possibility that no VFIO_DIR(/dev/vfio) mapping from host to
container when host have both Intel NIC and Mellanox NIC but
this conntainer only allocate VFs from Mellanox NIC.
In t
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, January 16, 2025 5:25 PM
> To: Stefan Lässer
> Cc: John W. Linville ; dev@dpdk.org
> Subject: Re: [PATCH] net/af_packet: provide packet drop stats
>
> On Thu, 16 Jan 2025 17:17:03 +0100
> Stefan Laesser wrote:
>
> > The L
On Thu, Jan 16, 2025 at 10:08:07AM +0100, Morten Brørup wrote:
> > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > Sent: Thursday, 16 January 2025 02.55
> >
> > It was a common pattern to have "GCC diagnostic ignored" pragmas
> > sprinkled over the code and only activate these pragm
On 2025/1/17 2:18, Stephen Hemminger wrote:
> On Tue, 07 Jan 2025 10:49:40 +0800
> "WanRenyong" wrote:
>
>> diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
>> new file mode 100644
>> index 00..a7dca46127
>> --- /dev/null
>> +++ b/drivers/net/xsc/xsc_ethdev.c
>> @@
On 2025/1/17 2:19, Stephen Hemminger wrote:
> On Tue, 07 Jan 2025 10:49:55 +0800
> "WanRenyong" wrote:
>
>> +static int
>> +xsc_ethdev_rss_hash_conf_get(struct rte_eth_dev *dev,
>> + struct rte_eth_rss_conf *rss_conf)
>> +{
>> +struct xsc_ethdev_priv *priv = TO_XSC_ETHD
On 2025/1/17 1:58, Stephen Hemminger wrote:
>
On Tue, 07 Jan 2025 10:50:09 +0800
> "WanRenyong" wrote:
>
>
>
Implement xsc ethdev basic statatics ops.
>
>
> Signed-off-by: WanRenyong
> ---
> doc/guides/nics/features/xsc.ini | 1 +
> drivers/net/xsc/xsc_ethdev.c | 75 ++
On 2025/1/17 1:58, Stephen Hemminger wrote:
> On Tue, 07 Jan 2025 10:50:09 +0800
> "WanRenyong" wrote:
>
>> Implement xsc ethdev basic statatics ops.
>>
>> Signed-off-by: WanRenyong
>> ---
>> doc/guides/nics/features/xsc.ini | 1 +
>> drivers/net/xsc/xsc_ethdev.c | 75
I will fix it and send a new version.
Thanks.
>> (np)network Processor initialize resources in host,
>> and initialize a channel for some tables insert/get/del.
>>
>> Signed-off-by: Junlong Wang
>> ---
> This does not apply cleanly to the current main branch because of the
> latest changes to
Both legs of the loop share the same logic: either to go out of the
function, or to fall through to the next instructions.
Depends-on: patch-1 ("net/af_xdp: fix use after free in af_xdp_tx_zc()")
Bugzilla ID: 1440
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 47 ++
tx_bytes is computed after both legs are tested. This might
produce a use after memory free.
The computation is now moved into each leg.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 4
Hello,
The series addresses Bugzilla ID 1440 in two steps;
1. Fix use after free.
2. Refactor af_xdp_tx_zc().
Thank you,
---
v2
* reworded commit messages
* addressed feedback from Stephen Hemminger
v1 (http://inbox.dpdk.org/dev/20250116195640.68885-1-ariel.otilib...@6wind.com/)
Ariel Otilibili
On Thu, Jan 16, 2025 at 11:26 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Thu, 16 Jan 2025 23:20:06 +0100
> Ariel Otilibili wrote:
>
> > Hi Stephen,
> >
> > On Thu, Jan 16, 2025 at 10:47 PM Stephen Hemminger <
> > step...@networkplumber.org> wrote:
> >
> > > On Thu, 16 Jan 2025
On Thu, 16 Jan 2025 23:20:06 +0100
Ariel Otilibili wrote:
> Hi Stephen,
>
> On Thu, Jan 16, 2025 at 10:47 PM Stephen Hemminger <
> step...@networkplumber.org> wrote:
>
> > On Thu, 16 Jan 2025 20:56:39 +0100
> > Ariel Otilibili wrote:
> >
> > > Both branches of the loop share the same logic
Hi Stephen,
On Thu, Jan 16, 2025 at 10:47 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Thu, 16 Jan 2025 20:56:39 +0100
> Ariel Otilibili wrote:
>
> > Both branches of the loop share the same logic. Now each one is a
> > goto dispatcher; either to out (end of function), or to
>
On Thu, 16 Jan 2025 20:56:39 +0100
Ariel Otilibili wrote:
> Both branches of the loop share the same logic. Now each one is a
> goto dispatcher; either to out (end of function), or to
> stats (continuation of the loop).
>
> Bugzilla ID: 1440
> Depends-on: patch-1 ("net/af_xdp: fix use after free
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> The configuration requires the user to explicitly set the requested test
> suites in the files. Sometimes we want to run all the test suites and
> don't want to manually specify all of them. It is therefore reasonable
> to change the default
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> The current handling of the configuration loading is inconsistent. After
> the whole configuration is loaded, if there are any CLI or environment
> overrides set, the code forcefully modifies the frozen configuration to
> use them.
>
> This
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> To avoid the creation of a big monolithic configuration file, nodes and
> test runs are now split into distinct files. This also allows
> flexibility to run different test runs on the same nodes.
>
> Since there are now 2 distinct configurat
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> From: Nicholas Pratte
>
> Rework 'lcores' and 'memory_channels' into a new 'dpdk_config'
> subsection in an effort to make these attributes SUT specific; the
> traffic generator, more often than not, does not need this information.
> Ideall
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> From: Nicholas Pratte
>
> To further the simplification of the user configuration, use_first_core
> can be inferred from the lcores. If the user explicitly includes the
> core 0 in the lcores range, it will only then be used.
>
> Bugzilla I
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> From: Nicholas Pratte
>
> The build options configuration contained redundant fields that were not
> in use, and there is no future scope for their use.
>
> Bugzilla ID: 1360
>
> Signed-off-by: Nicholas Pratte
> Signed-off-by: Luca Vizzarr
On Wed, Jan 15, 2025 at 9:19 AM Luca Vizzarro wrote:
>
> From: Nicholas Pratte
>
> The 'arch' attribute in the conf.yaml is unnecessary, as this can be
> readily discovered directly from any given node.
>
> Bugzilla ID: 1360
>
> Signed-off-by: Nicholas Pratte
> Signed-off-by: Luca Vizzarro
> Re
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Thursday, 16 January 2025 18.46
>
> On Thu, Jan 16, 2025 at 11:10:47PM +0530, Jerin Jacob wrote:
> > On Thu, Jan 16, 2025 at 10:50 PM Bruce Richardson
> > wrote:
> > >
> > > On Fri, Dec 20, 2024 at 02:38:57PM +, Bruce Richar
Both branches of the loop share the same logic. Now each one is a
goto dispatcher; either to out (end of function), or to
stats (continuation of the loop).
Bugzilla ID: 1440
Depends-on: patch-1 ("net/af_xdp: fix use after free in af_xdp_tx_zc()")
Signed-off-by: Ariel Otilibili
---
drivers/net/af
tx_bytes is computed after both branches are tested. This might
produce a use after memory free.
The computation is now moved into both branches.
Bugzilla ID: 1440
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Signed-off-by: Ariel Otilibili
---
drivers/net/af_xdp/rte_eth_af_
Hello,
The series addresses Bugzilla ID 1440 in two steps;
1. Fix use after free.
2. Refactor af_xdp_tx_zc().
Thank you,
Ariel Otilibili (2):
net/af_xdp: fix use after free in af_xdp_tx_zc()
net/af_xdp: Refactor af_xdp_tx_zc()
drivers/net/af_xdp/rte_eth_af_xdp.c | 53 ++---
Fixes verification method in multicast set function by changing
the stats capture to use show_port_info_all(). This way, the
method will continue to work even after DTS lifts the restriction
on port topologies.
Fixes: abf8a3bc793b ("dts: add multicast set function to shell")
Signed-off-by: Dean M
Fixes checksum offload test suite docstring format
by adding steps and verify sections. Changes variables
formatted in camel case to snake case to fit python standards.
Fixes: 8c9a7471a0e6 ("dts: add checksum offload test suite")
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_checksum_offload
On Thu, 16 Jan 2025 19:40:33 +0800
Huisong Li wrote:
> If application verify the validity of the port id or configure this port in
> the new event callback, application may happen to the port id is invalid.
>
> In case of similar confusion, this patch have to clarify something about
> RTE_ETH_EV
Fix a variable naming error within the verify method
that was causing an attribute error during runtime.
Fixes: 05d7ad873798 ("dts: resolve mypy type errors")
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_checksum_offload.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
On Tue, 07 Jan 2025 10:50:09 +0800
"WanRenyong" wrote:
> Implement xsc ethdev basic statatics ops.
>
> Signed-off-by: WanRenyong
> ---
> doc/guides/nics/features/xsc.ini | 1 +
> drivers/net/xsc/xsc_ethdev.c | 75
> 2 files changed, 76 insertions(+)
>
> d
On Thu, 16 Jan 2025 18:49:27 +0100
Thomas Monjalon wrote:
> Sorting depends on your locale,
> and how you want to consider space and accents.
>
> Also we need a command to reproduce how sort is supposed to be done.
>
> 16/01/2025 18:10, Stephen Hemminger:
> > Tomer Shmilovich
> > +Tomáš Ďurov
On Thu, Jan 16, 2025 at 06:49:27PM +0100, Thomas Monjalon wrote:
> Sorting depends on your locale,
> and how you want to consider space and accents.
>
Yes, looking at the changes, the corrections for dealing with spaces all
look correct to me. However, moving the accents to the end seems wrong.
/
Sorting depends on your locale,
and how you want to consider space and accents.
Also we need a command to reproduce how sort is supposed to be done.
16/01/2025 18:10, Stephen Hemminger:
> Tomer Shmilovich
> +Tomáš Ďurovec
> Tone Zhang
I don't think we should move accent at the end of the al
On Thu, Jan 16, 2025 at 11:10:47PM +0530, Jerin Jacob wrote:
> On Thu, Jan 16, 2025 at 10:50 PM Bruce Richardson
> wrote:
> >
> > On Fri, Dec 20, 2024 at 02:38:57PM +, Bruce Richardson wrote:
> > > This RFC attempts to reduce the amount of code duplication across a
> > > number of Intel NIC dr
On Thu, Jan 16, 2025 at 10:50 PM Bruce Richardson
wrote:
>
> On Fri, Dec 20, 2024 at 02:38:57PM +, Bruce Richardson wrote:
> > This RFC attempts to reduce the amount of code duplication across a
> > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice.
> >
> > The first patch
On Thu, Jan 16, 2025 at 05:22:21PM +, Bruce Richardson wrote:
> Consolidate all Intel HW NIC drivers into a driver/net/intel This
> matches the layout used for drivers in the kernel, and potentially
> enabling easier sharing among drivers.
>
> Signed-off-by: Bruce Richardson
> ---
Apologies,
Consolidate all Intel HW NIC drivers into a driver/net/intel This
matches the layout used for drivers in the kernel, and potentially
enabling easier sharing among drivers.
Signed-off-by: Bruce Richardson
---
drivers/meson.build | 6 +-
drivers/net/{ => intel}/cpfl
On Fri, Dec 20, 2024 at 02:38:57PM +, Bruce Richardson wrote:
> This RFC attempts to reduce the amount of code duplication across a
> number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice.
>
> The first patch extract a function from the Rx side, otherwise the
> majority of the
The mailmap file is supposed to be in alphabetic order
but it has gotten out of order in several spots over time.
Signed-off-by: Stephen Hemminger
---
.mailmap | 366 +++
1 file changed, 183 insertions(+), 183 deletions(-)
diff --git a/.mailma
On Thu, 16 Jan 2025 10:10:46 +0800
Junlong Wang wrote:
> (np)network Processor initialize resources in host,
> and initialize a channel for some tables insert/get/del.
>
> Signed-off-by: Junlong Wang
> ---
This does not apply cleanly to the current main branch because of the
latest changes to
Hello,
Is there any plan to resume this work?
31/07/2024 19:32, Thomas Monjalon:
> 29/03/2024 12:32, Ferruh Yigit:
> > On 9/26/2023 2:13 PM, Ferruh Yigit wrote:
> > > On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> > >> From: Renyong Wan
> > >>
> > >> The sssnic PMD (**librte_pmd_sssnic**) provid
Hello,
Is there any plan to resume this work?
01/09/2023 04:30, Wenbo Cao:
> For This patchset just to support the basic chip init work
> and user can just found the eth_dev, but can't control more.
> For Now just support 2*10g nic,the chip can support
> 2*10g,4*10g,4*1g,8*1g,8*10g.
> The Featur
Hello,
The first DPDK Summit of the year is confirmed:
8 & 9 May 2025 in Prague
You can prepare your talk proposals now,
the website with full instructions will be ready next week.
It is planned to close the CFP period after the end of February,
so the program will be announced in mid-Mar
On Thu, 16 Jan 2025 17:17:03 +0100
Stefan Laesser wrote:
> The Linux kernel provides the ability to query the packet drop counter
> of a socket. This information can be provided when the user requests
> stats.
>
> It is important to note that each call to getsockopt with
> PACKET_STATISTICS rese
The Linux kernel provides the ability to query the packet drop counter
of a socket. This information can be provided when the user requests
stats.
It is important to note that each call to getsockopt with
PACKET_STATISTICS resets the internal counters. So the caller needs to
keep track of the tota
> 06/12/2024 19:35, Konstantin Ananyev:
> > Testing coverage (passed):
> > x86_64, i686, PPC, ARM
> >
> > Would like to express my gratitude to all community members who helped
> > with testing it on different platforms, in particular:
> > David Christensen
> > Cody Cheng
> > Patrick Robb
> > P
16/01/2025 12:40, Huisong Li:
> During probing, before the port becomes generally available, the
> rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
> application.
>
> Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by
> default")
> Fixes: 53ef1b34776b ("ethdev
16/01/2025 12:40, Huisong Li:
> If application verify the validity of the port id or configure this port in
> the new event callback, application may happen to the port id is invalid.
>
> In case of similar confusion, this patch have to clarify something about
> RTE_ETH_EVENT_NEW in code.
>
> Sig
Reviewed-by: Luca Vizzarro
06/12/2024 19:35, Konstantin Ananyev:
> Testing coverage (passed):
> x86_64, i686, PPC, ARM
>
> Would like to express my gratitude to all community members who helped
> with testing it on different platforms, in particular:
> David Christensen
> Cody Cheng
> Patrick Robb
> Phanendra Vukkisal
Added verify to match_all_packets function
that if False and there are missing packets
causes the function to return False, if all
packets are present it returns True.
Signed-off-by: Thomas Wilks
---
Reviewed-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
---
dts/framework/test_suite.py | 23 +
Added verification that enables promiscuous mode,
sends a packet with a different destination mac address
and then disables promiscuous mode, sends the same packet
and checks if the packet was filtered out.
Signed-off-by: Thomas Wilks
---
Reviewed-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
v1:
- Added testsuite that verifies promiscuous mode.
- Added verify to match_all_packets function.
Depends-on: patch-149773 ("dts: allow expected packets to come from the TG")
Thomas Wilks (2):
dts: add promiscuous mode verification test
dts: add verify to match all packets
dts/framework/t
On Thu, Jan 16, 2025 at 10:54 AM Maxime Coquelin
wrote:
>
> With previous refactoring, we can now simplify the RARP
> packet injection handling in both the sync and async
> dequeue paths.
>
> Signed-off-by: Maxime Coquelin
Recheck-request: github-robot
--
David Marchand
On Fri, Jan 10, 2025 at 6:27 PM Stephen Hemminger
wrote:
>
> Gcc 15 now produces warning with the base code of Thunderx driver.
> The issue is that Gcc now defaults to C23 mode, and the standards
> gods have decided that partial initialization of a union has changed.
>
> The fix is to use an empty
> On Jan 16, 2025, at 17:54, Maxime Coquelin wrote:
>
> External email: Use caution opening links or attachments
>
>
> With previous refactoring, we can now simplify the RARP
> packet injection handling in both the sync and async
> dequeue paths.
>
> Signed-off-by: Maxime Coquelin
> ---
>
> On Jan 16, 2025, at 17:54, Maxime Coquelin wrote:
>
> External email: Use caution opening links or attachments
>
>
> This patch refactors the error handling in the Vhost
> dequeue paths to ease its maintenance and readability.
>
> Suggested-by: David Marchand
> Signed-off-by: Maxime Coqu
> On Jan 16, 2025, at 17:54, Maxime Coquelin wrote:
>
> External email: Use caution opening links or attachments
>
>
> This patch fixes the rte_vhost_dequeue_burst return value
> when the virtqueue is not ready. Without it, a discrepancy
> between the packet array and its size is faced by th
During probing, before the port becomes generally available, the
rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
application.
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Fixes: 53ef1b34776b ("ethdev: add sanity checks in control APIs")
Cc: sta
If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid.
In case of similar confusion, this patch have to clarify something about
RTE_ETH_EVENT_NEW in code.
Signed-off-by: Huisong Li
---
lib/ethdev/rte_
I've had some issues when I add the verification of the port id in the
event callback, which are discussed in another patch series[1]. So this
series clarify something about RTE_ETH_EVENT_NEW based on the previous
discussion.
[1]
https://patches.dpdk.org/project/dpdk/cover/20250113025521.32703-1-
On Thu, Jan 16, 2025 at 10:54 AM Maxime Coquelin
wrote:
>
> With previous refactoring, we can now simplify the RARP
> packet injection handling in both the sync and async
> dequeue paths.
>
> Signed-off-by: Maxime Coquelin
Reviewed-by: David Marchand
--
David Marchand
On Thu, Jan 16, 2025 at 10:54 AM Maxime Coquelin
wrote:
>
> This patch refactors the error handling in the Vhost
> dequeue paths to ease its maintenance and readability.
>
> Suggested-by: David Marchand
> Signed-off-by: Maxime Coquelin
Reviewed-by: David Marchand
--
David Marchand
On Thu, Jan 16, 2025 at 10:54 AM Maxime Coquelin
wrote:
>
> This patch fixes the rte_vhost_dequeue_burst return value
> when the virtqueue is not ready. Without it, a discrepancy
> between the packet array and its size is faced by the caller
> of this API when the virtqueue is not ready.
>
> Fixes
On 1/15/25 5:46 PM, David Marchand wrote:
On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin
wrote:
With previous refactoring, we can now simplify the RARP
packet injection handling in both the sync and async
dequeue paths.
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 42 +++
With previous refactoring, we can now simplify the RARP
packet injection handling in both the sync and async
dequeue paths.
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 72 ++
1 file changed, 30 insertions(+), 42 deletions(-)
diff --git a/l
This patch fixes the rte_vhost_dequeue_burst return value
when the virtqueue is not ready. Without it, a discrepancy
between the packet array and its size is faced by the caller
of this API when the virtqueue is not ready.
Fixes: 9fc93a1e2320 ("vhost: fix virtqueue access check in datapath")
Cc: s
This patch refactors the error handling in the Vhost
dequeue paths to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 58 +++---
1 file changed, 26 insertions(+), 32 deletions(-)
This series starts with a fix for a regression in the Vhost
dequeue error path.
The other patches improve the error handling to reduce the
chance of such regressions in the future.
Changes in v3:
==
- Squashed patches 2 & 3 (David)
- Simplify RARP handling further (David
Changes in v
On 1/15/25 5:49 PM, David Marchand wrote:
On Wed, Jan 15, 2025 at 5:42 PM David Marchand
wrote:
On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin
wrote:
This patch refactors the error handling in the Vhost async
dequeue path to ease its maintenance and readability.
Suggested-by: David Mar
在 2025/1/16 17:09, Thomas Monjalon 写道:
16/01/2025 07:14, lihuisong (C):
在 2025/1/15 19:36, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
allocating an ethdev. So this patch relaxes the conditions for using them.
You
在 2025/1/16 17:15, Thomas Monjalon 写道:
16/01/2025 07:16, lihuisong (C):
在 2025/1/15 19:31, Thomas Monjalon 写道:
15/01/2025 04:41, Huisong Li:
If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid.
Members Attending
-
Aaron Conole
Bruce Richardson
Hemant Agrawal
Honnappa Nagarahalli
Jerin Jacob
Kevin Traynor (Chair)
Maxime Coquelin
Morten Brørup
Stephen Hemminger
Thomas Monjalon
NOTE: The technical board meetings are on every second Wednesday at 3pm
UTC. Meetings are
16/01/2025 07:16, lihuisong (C):
>
> 在 2025/1/15 19:31, Thomas Monjalon 写道:
> > 15/01/2025 04:41, Huisong Li:
> >> If application verify the validity of the port id or configure this port in
> >> the new event callback, application may happen to the port id is invalid.
> >>
> >> Actually, when app
16/01/2025 07:14, lihuisong (C):
> 在 2025/1/15 19:36, Thomas Monjalon 写道:
> > 15/01/2025 04:41, Huisong Li:
> >> The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
> >> allocating an ethdev. So this patch relaxes the conditions for using them.
> > You should be more explicit:
>
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Thursday, 16 January 2025 02.55
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma f
On Wed, Jan 15, 2025 at 05:55:08PM -0800, Andre Muezerie wrote:
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma for
> compatibility with existing source
On Wed, Jan 15, 2025 at 05:55:11PM -0800, Andre Muezerie wrote:
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma for
> compatibility with existing source
The test vector aes_test_data_19 plaintext is 192 bytes and this vector
is used to test 192-byte plaintext, but test vector plaintext.len
value is incorrectly assigned to 64.
The test vector aes_test_data_20 plaintext length is 256 bytes, but
testcase comment incorrectly describes it as "192-byte
80 matches
Mail list logo
