[PATCH v4 6/6] lib/vhost: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Maxime Coquelin Cc: Chenbo Xia Signed-off-by: Ariel Otilibili Acked-by: Stephen

[PATCH v4 5/6] net/hinic: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Ziyang Xuan Cc: Xiaoyun Wang Signed-off-by: Ariel Otilibili Acked-by: Stephen He

[PATCH v4 4/6] net/failsafe: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Gaetan Rivet Signed-off-by: Ariel Otilibili Acked-by: Stephen Hemminger --- dri

[PATCH v4 3/6] common/cnxk: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Nithin Dabilpuram Cc: Kiran Kumar K Cc: Sunil Kumar Kori Cc: Satha Rao Cc: Harm

[PATCH v4 2/6] net/bnxt: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Ajit Khaparde Cc: Somnath Kotur Signed-off-by: Ariel Otilibili Acked-by: Stephen

[PATCH v4 1/6] raw/ifpga: remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
> pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html Bugzilla ID: 1586 Cc: Rosen Xu Signed-off-by: Ariel Otilibili Acked-by: Stephen Hemminger --- drivers

[PATCH v4 0/6] remove check around pthread_mutex_init()

2025-01-13 Thread Ariel Otilibili
Hello, This series addresses Bugzilla ID 1586; the man says > pthread_mutex_init always returns 0. The other mutex functions > return 0 on success and a non-zero error code on error. Meaning, the check around around pthread_mutex_init() is needless. ``` $ git grep -Pn '=\s?pthread_mutex_init\('

RE: [PATCH] eal: add worker threads cleanup in rte_eal_cleanup()

2025-01-13 Thread Gagandeep Singh
Hi, > -Original Message- > From: Stephen Hemminger > Sent: Monday, January 13, 2025 10:10 PM > To: Gagandeep Singh > Cc: dev@dpdk.org > Subject: Re: [PATCH] eal: add worker threads cleanup in rte_eal_cleanup() > > On Mon, 13 Jan 2025 05:13:01 + > Gagandeep Singh wrote: > > > Hi, >

[PATCH v16 32/60] drivers/baseband: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/baseband/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build index 3420d98564..6

[PATCH v16 42/60] drivers/regex: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/regex/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/regex/meson.build b/drivers/regex/meson.build index ff2a8fea89..06614f34e2

[PATCH v16 54/60] table: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/table/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/table/meson.build b/lib/table/meson.build index 9b3d9

[PATCH v16 56/60] drivers/common: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/common/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/meson.build b/drivers/common/meson.build index 8734af36aa..03debc9

[PATCH v16 60/60] lib: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- lib/meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index ce92cb5537..43a92be5fa 100644 ---

[PATCH v16 58/60] build: enable vla warnings on Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- config/meson.build | 4 1 file changed, 4 inserti

[PATCH v16 47/60] ipsec: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/ipsec/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/ipsec/meson.build b/lib/ipsec/meson.build index 5c5a4

[PATCH v16 53/60] power: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/power/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/power/meson.build b/lib/power/meson.build index b3a7

[PATCH v16 59/60] app: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- app/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/app/meson.build b/app/meson.build index e2db888ae1..894d126dde 100644 --- a/app/meson.build

[PATCH v16 55/60] vhost: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/vhost/meson.build | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/vhost/meson.build b/lib/vhost

[PATCH v16 57/60] drivers/net: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/net/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index dafd637ba4..170e7339e5 10064

[PATCH v16 52/60] pipeline: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pipeline/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pipeline/meson.build b/lib/pipeline/meson.build in

[PATCH v16 51/60] pdump: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pdump/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pdump/meson.build b/lib/pdump/meson.build index da8d5

[PATCH v16 48/60] member: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/member/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/member/meson.build b/lib/member/meson.build index 02

[PATCH v16 50/60] pdcp: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pdcp/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pdcp/meson.build b/lib/pdcp/meson.build index f4f9246b

[PATCH v16 43/60] acl: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/acl/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/acl/meson.build b/lib/acl/meson.build index 9cba08321a.

[PATCH v16 49/60] metrics: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/metrics/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/metrics/meson.build b/lib/metrics/meson.build index

[PATCH v16 44/60] bpf: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/bpf/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/bpf/meson.build b/lib/bpf/meson.build index aa258a9061.

[PATCH v16 45/60] dispatcher: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/dispatcher/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/dispatcher/meson.build b/lib/dispatcher/meson.bu

[PATCH v16 28/60] app/test-eventdev: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-eventdev/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-eventdev/meson.build b/app/test-eventdev

[PATCH v16 46/60] eventdev: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/eventdev/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build in

[PATCH v16 40/60] drivers/raw: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/raw/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index d173ac6097..726a786e0d 10064

[PATCH v16 24/60] app/test-acl: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-acl/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-acl/meson.build b/app/test-acl/meson.build in

[PATCH v16 35/60] drivers/compress: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/compress/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/compress/meson.build b/drivers/compress/meson.build index 91d7800a4a..2

[PATCH v16 23/60] app/test: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test/meson.build | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/app/test/meson.build b/app/test/

[PATCH v16 36/60] drivers/gpu: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/gpu/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/meson.build b/drivers/gpu/meson.build index b6edd12678..610151e9b1 10064

[PATCH v16 41/60] drivers/vdpa: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/vdpa/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/meson.build b/drivers/vdpa/meson.build index 896e8e0304..49e94584bc 10

[PATCH v16 27/60] app/test-dma-perf: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-dma-perf/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-dma-perf/meson.build b/app/test-dma-perf

[PATCH v16 39/60] drivers/power: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/power/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/power/meson.build b/drivers/power/meson.build index 0a703bce38..e7c16e2d47

[PATCH v16 31/60] app/test-sad: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-sad/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-sad/meson.build b/app/test-sad/meson.build in

[PATCH v16 25/60] app/test-bbdev: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-bbdev/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.bu

[PATCH v16 18/60] test: remove use of VLAs for Windows built code in bitset tests

2025-01-13 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v16 34/60] drivers/common: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/common/nfp/meson.build | 8 drivers/common/nitrox/meson.build | 8 drivers/common/sfc_efx/meson.build | 1 + 3 files changed, 17 insertio

[PATCH v16 16/60] common/mlx5: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v16 20/60] hash: remove use of VLAs by using standard arrays

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c index 1c6297

[PATCH v16 33/60] drivers/bus: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/bus/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build index d67db8576b..59af0f920e 10064

[PATCH v16 26/60] app/test-crypto-perf: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/test-crypto-perf/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-crypto-perf/meson.build b/app/test-cr

[PATCH v16 37/60] drivers/mempool: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/mempool/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build index dc88812585..4f74

[PATCH v16 38/60] drivers/ml: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/ml/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/ml/meson.build b/drivers/ml/meson.build index 54bc394c47..ae07c5292e 100644 -

[PATCH v16 29/60] app/flow-perf: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- app/test-flow-perf/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/test-flow-perf/meson.build b/app/test-flow-perf/meson.build index 766e451

[PATCH v16 22/60] app/proc-info: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/proc-info/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build

[PATCH v16 14/60] common/idpf: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v16 19/60] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie Acked-by: Chengwen Feng --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v16 30/60] app/test-pmd: check compiler supports flag when adding to set

2025-01-13 Thread Andre Muezerie
This is done so that multiple compilers can be supported. Signed-off-by: Andre Muezerie --- app/test-pmd/meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index f1c36529b4..8de1528428 100644 --- a/app/tes

[PATCH v16 21/60] app/pdump: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- app/pdump/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/app/pdump/meson.build b/app/pdump/meson.build index fb282

[PATCH v16 13/60] test: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test/test.c | 2 +-

[PATCH v16 12/60] app/testpmd: remove use of VLAs for Windows built

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 +- app/test

[PATCH v16 09/60] gro: remove use of VLAs

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v16 11/60] net/ice: remove use of VLAs

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v16 17/60] net/mlx5: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v16 10/60] net/ixgbe: remove use of VLAs

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v16 15/60] net/i40e: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/i40e/i40e_testpmd.c | 5 ++-

[PATCH v16 06/60] hash/thash: remove use of VLAs for Windows built

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ The tuple can exceed sizeof(union rte_thash_tuple), for example if any tunneling header is used in the RSS hash calculation. The longest RSS hash key currently supported is

[PATCH v16 07/60] rcu: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v16 08/60] gro: fix overwrite unprocessed packets

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v16 05/60] hash: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v16 00/60] remove use of VLAs for Windows

2025-01-13 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v16 04/60] ethdev: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v16 02/60] eal/linux: remove use of VLAs

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v16 03/60] eal/common: remove use of VLAs

2025-01-13 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev Acked-by: Stephen Hemminger --- lib/eal/common/eal_common

[PATCH v16 01/60] eal: include header required for alloca

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/freebsd/include/rte_os.h | 1 + lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 3 files changed, 3 insertions(+) d

Re: [PATCH] app/testpmd: add ipv6 extension header parse

2025-01-13 Thread Jie Hai
Hi, Stephen Hemminger, On 2025/1/9 1:02, Stephen Hemminger wrote: On Wed, 8 Jan 2025 10:46:32 +0800 Jie Hai wrote: From: Jie Hai To: , , , Aman Singh CC: , , , Subject: [PATCH] app/testpmd: add ipv6 extension header parse Date: Wed, 8 Jan 2025 10:46:32 +0800 X-Mailer: git-send-email 2.

Re: [PATCH v1 2/2] ethdev: fix skip valid port in probing callback

2025-01-13 Thread lihuisong (C)
在 2025/1/13 21:14, Thomas Monjalon 写道: 13/01/2025 13:47, lihuisong (C): 在 2025/1/13 20:30, Thomas Monjalon 写道: 13/01/2025 13:05, lihuisong (C): 在 2025/1/13 19:23, lihuisong (C) 写道: 在 2025/1/13 18:57, Thomas Monjalon 写道: 13/01/2025 10:35, lihuisong (C): 在 2025/1/13 16:16, Thomas Monjalon 写

[PATCH v15 49/60] metrics: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/metrics/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/metrics/meson.build b/lib/metrics/meson.build index

[PATCH v15 33/60] drivers/bus: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/bus/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build index d67db8576b..59af0f920e 10064

[PATCH v15 13/60] test: remove use of VLAs for Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test/test.c | 2 +-

[PATCH v15 32/60] drivers/baseband: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/baseband/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build index 3420d98564..6

Re: [PATCH 1/2] lib/ipsec: compile ipsec on Windows

2025-01-13 Thread Andre Muezerie
On Thu, Jan 09, 2025 at 05:27:11PM +, Konstantin Ananyev wrote: > > > > Removed VLA for compatibility with MSVC (which does not support VLAs). > > Used alloca when a constant fixed length that can be used instead is > > not known. > > > ... > > > Signed-off-by: Andre Muezerie > > --- > >

[PATCH v15 54/60] table: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/table/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/table/meson.build b/lib/table/meson.build index 9b3d9

[PATCH v15 51/60] pdump: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pdump/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pdump/meson.build b/lib/pdump/meson.build index da8d5

[PATCH v15 53/60] power: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/power/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/power/meson.build b/lib/power/meson.build index b3a7

[PATCH v15 50/60] pdcp: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pdcp/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pdcp/meson.build b/lib/pdcp/meson.build index f4f9246b

[PATCH v15 58/60] build: enable vla warnings on Windows built code

2025-01-13 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- config/meson.build | 4 1 file changed, 4 inserti

[PATCH v15 47/60] ipsec: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/ipsec/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/ipsec/meson.build b/lib/ipsec/meson.build index 5c5a4

[PATCH v15 52/60] pipeline: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/pipeline/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/pipeline/meson.build b/lib/pipeline/meson.build in

[PATCH v15 46/60] eventdev: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/eventdev/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build in

[PATCH v15 59/60] app: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- app/meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/app/meson.build b/app/meson.build index e2db888ae1..894d126dde 100644 --- a/app/meson.build

[PATCH v15 48/60] member: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/member/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/member/meson.build b/lib/member/meson.build index 02

[PATCH v15 45/60] dispatcher: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/dispatcher/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/dispatcher/meson.build b/lib/dispatcher/meson.bu

[PATCH v15 56/60] drivers/common: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/common/meson.build | 8 drivers/common/mlx5/meson.build | 1 + drivers/common/qat/meson.build | 8 3 files changed, 17 insertions(+) di

[PATCH v15 57/60] drivers/net: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/net/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index dafd637ba4..170e7339e5 10064

[PATCH v15 44/60] bpf: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/bpf/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/bpf/meson.build b/lib/bpf/meson.build index aa258a9061.

[PATCH v15 42/60] drivers/regex: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/regex/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/regex/meson.build b/drivers/regex/meson.build index ff2a8fea89..06614f34e2

[PATCH v15 60/60] lib: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- lib/meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index ce92cb5537..43a92be5fa 100644 ---

[PATCH v15 55/60] vhost: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/vhost/meson.build | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/vhost/meson.build b/lib/vhost

[PATCH v15 34/60] drivers/common: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/common/nfp/meson.build | 8 drivers/common/nitrox/meson.build | 8 drivers/common/sfc_efx/meson.build | 1 + 3 files changed, 17 insertio

[PATCH v15 41/60] drivers/vdpa: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/vdpa/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vdpa/meson.build b/drivers/vdpa/meson.build index 896e8e0304..49e94584bc 10

[PATCH v15 40/60] drivers/raw: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/raw/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index d173ac6097..726a786e0d 10064

[PATCH v15 39/60] drivers/power: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/power/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/power/meson.build b/drivers/power/meson.build index 0a703bce38..e7c16e2d47

[PATCH v15 36/60] drivers/gpu: add compile warning about use of VLAs

2025-01-13 Thread Andre Muezerie
MSVC does not support VLAs, so we want to prevent VLAs from being introduced under this path. Signed-off-by: Andre Muezerie --- drivers/gpu/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/meson.build b/drivers/gpu/meson.build index b6edd12678..610151e9b1 10064

[PATCH v15 43/60] acl: disable warning about use of VLAs

2025-01-13 Thread Andre Muezerie
This path is known to make use of VLAs, so we need to disable warnings issued for VLAs to prevent the build from breaking. Signed-off-by: Andre Muezerie --- lib/acl/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/lib/acl/meson.build b/lib/acl/meson.build index 9cba08321a.

[PATCH v15 30/60] app/test-pmd: check compiler supports flag when adding to set

2025-01-13 Thread Andre Muezerie
This is done so that multiple compilers can be supported. Signed-off-by: Andre Muezerie --- app/test-pmd/meson.build | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index f1c36529b4..8de1528428 100644 --- a/app/tes

  1   2   >