Driver: bnxt_en

2025-01-09 Thread Eldho Paul Mathew
We are using DPDK 18.05.1 We received a new network card. Broadcom Inc. and subsidiaries BCM57414 NetXtreme-E 10Gb/25Gb RDMA Ethernet Controller DPDK 18.05.1 has support for this card and driver bnxt_en? If not, which stable version onwards has this driver support added?

[PATCH] eal: add worker threads cleanup in rte_eal_cleanup()

2025-01-09 Thread Gagandeep Singh
This patch introduces a worker thread cleanup function in the EAL library, ensuring proper termination of created pthreads and invocation of registered pthread destructors. This guarantees the correct cleanup of thread-specific resources, used by drivers or applications. Signed-off-by: Gagandeep S

Re: [RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID

2025-01-09 Thread Stephen Hemminger
On Sun, 22 Dec 2024 17:38:19 +0200 Shani Peretz wrote: > This change introduces a new API to dynamically enable or disable > xstat counters by their IDs. Some counters may require hardware > resources that are potentially limited, so providing the ability > to toggle them on or off makes sense. >

Re: [PATCH] doc: fixing name of rfc2697 and rfc2698

2025-01-09 Thread Stephen Hemminger
On Mon, 23 Dec 2024 22:00:08 +0500 Farhat Ullah wrote: > This patch fixes typos in the testpmd > document for rfc2697 and rfc2698 > > Signed-off-by: Farhat Ullah Looks like your mail system is corrupting plain text patches. See patchwork for examples of how apply is failing Please resubmit.

Re: [PATCH 00/15] net/ngbe: add VF driver support

2025-01-09 Thread Stephen Hemminger
On Thu, 9 Jan 2025 12:02:10 +0800 Zaiyu Wang wrote: > This patch adds support to VF device for ngbe PMD > > Zaiyu Wang (15): > net/ngbe: add ethdev probe and remove for VF device > net/ngbe: add support for PF-VF mailbox interface > net/ngbe: add hardware configuration code for VF device

Re: [PATCH v13 00/21] remove use of VLAs for Windows

2025-01-09 Thread Andre Muezerie
On Wed, Jan 08, 2025 at 01:30:13PM +, Konstantin Ananyev wrote: > > > > As per guidance technical board meeting 2024/04/17. This series > > removes the use of VLAs from code built for Windows for all 3 > > toolchains. If there are additional opportunities to convert VLAs > > to regular C arra

Re: [PATCH RESEND v7 2/5] ethdev: fix skip valid port in probing callback

2025-01-09 Thread lihuisong (C)
Hi Stephen, Can you take a look at my below reply and reconsider this patch? /Huisong 在 2024/12/10 9:50, lihuisong (C) 写道: Hi Ferruh, Stephen and Thomas, Can you take a look at this patch? After all, it is an issue in ethdev layer. This also is the fruit we disscussed with Thomas and Ferruh

[PATCH] doc: document hash RSS limitations with CQE zipping

2025-01-09 Thread Alexander Kozyrev
RSS hash is only fully supported when the Hash RSS format is selected. Update MLX5 documentation about lack of RTE_MBUF_F_RX_RSS_HASH flag for some packets in case of any other CQE compression format is configured. Signed-off-by: Alexander Kozyrev --- doc/guides/nics/mlx5.rst | 7 +-- 1 file

Re: [PATCH v4] net/gve: allocate RX QPL pages using malloc

2025-01-09 Thread Stephen Hemminger
On Thu, 9 Jan 2025 12:05:43 -0800 Joshua Washington wrote: > Hello, > > I wish for this fix to be backported to stable release 22.11 and 23.11 > for DPDK. However, the patch as it is does not apply cleanly to either > release. What is the recommended way to include this patch in older > releases

Re: [PATCH v4] net/gve: allocate RX QPL pages using malloc

2025-01-09 Thread Joshua Washington
Hello, I wish for this fix to be backported to stable release 22.11 and 23.11 for DPDK. However, the patch as it is does not apply cleanly to either release. What is the recommended way to include this patch in older releases of DPDK? Should I create separate stable backport patches that apply cle

[PATCH v4] net/gve: allocate RX QPL pages using malloc

2025-01-09 Thread Joshua Washington
From: Praveen Kaligineedi Allocating QPL for an RX queue might fail if enough contiguous IOVA memory cannot be allocated. This can commonly occur when using 2MB huge pages because the 1024 4K buffers are allocated for each RX ring by default, resulting in 4MB for each ring. However, the only requ

[PATCH v4 2/2] dts: add dual VLAN test suite

2025-01-09 Thread Paul Szczepanek
From: Jeremy Spewock Test functionality of VLAN functions such as stripping, inserting and filtering with two tags present. Signed-off-by: Jeremy Spewock Signed-off-by: Paul Szczepanek --- dts/tests/TestSuite_dual_vlan.py | 287 +++ 1 file changed, 287 insertions(+

[PATCH v4 1/2] dts: add stop ports decorator for VLAN functions

2025-01-09 Thread Paul Szczepanek
Testpmd functions manipulating the VLAN options require the ports to be stopped when applying changes. Signed-off-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/fram

RE: [PATCH 1/2] lib/ipsec: compile ipsec on Windows

2025-01-09 Thread Konstantin Ananyev
> Removed VLA for compatibility with MSVC (which does not support VLAs). > Used alloca when a constant fixed length that can be used instead is > not known. > ... > Signed-off-by: Andre Muezerie > --- ... > diff --git a/lib/ipsec/esp_inb.c b/lib/ipsec/esp_inb.c > index f159bf7460..305ac48d

Re: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf

2025-01-09 Thread Stephen Hemminger
On Thu, 9 Jan 2025 15:43:12 +0800 huangdengdui wrote: > On 2025/1/9 0:57, Stephen Hemminger wrote: > > On Wed, 8 Jan 2025 10:40:43 +0800 > > Jie Hai wrote: > > > >> On 2024/12/31 1:55, Stephen Hemminger wrote: > >>> On Mon, 30 Dec 2024 14:54:03 +0800 > >>> Jie Hai wrote: > >>> >

Re: [PATCH] vhost: fix misleading log when setting max queue num

2025-01-09 Thread Ilya Maximets
On 1/9/25 15:31, Maxime Coquelin wrote: > rte_vhost_driver_set_max_queue_num API returns early when > called for a Vhost-user device, as this API is intended to > limit the maximum number of queue pairs supported by VDUSE > devices. However, a log mentioning the maximim number of > queue pairs is b

RE: [PATCH 1/2] lib/ipsec: compile ipsec on Windows

2025-01-09 Thread Konstantin Ananyev
> Removed VLA for compatibility with MSVC (which does not support VLAs). > Used alloca when a constant fixed length that can be used instead is > not known. > > Implementation for rte_ipsec_pkt_crypto_group and > rte_ipsec_ses_from_crypto was moved to new file > lib\ipsec\ipsec_group.c because

[PATCH] vhost: fix misleading log when setting max queue num

2025-01-09 Thread Maxime Coquelin
rte_vhost_driver_set_max_queue_num API returns early when called for a Vhost-user device, as this API is intended to limit the maximum number of queue pairs supported by VDUSE devices. However, a log mentioning the maximim number of queue pairs is being set is emitted unconditionally, which may con

[PATCH v3 2/2] dts: add softnic test

2025-01-09 Thread Thomas Wilks
From: Paul Szczepanek Add test that uses a softnic virtual device to forward packets. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/tests/TestSuite_softnic.py | 119 + 1 file changed, 119 insertions(+) create mode 100644 dts/tests/TestSuit

[PATCH v3 1/2] dts: allow expected packets to come from the TG

2025-01-09 Thread Thomas Wilks
From: Paul Szczepanek Add sent_from_tg variable to get_expected_packets for when packets are sent from the TG. Signed-off-by: Thomas Wilks Signed-off-by: Paul Szczepanek --- dts/framework/test_suite.py | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dts

[PATCH v3 0/2] dts: add softnic test

2025-01-09 Thread Thomas Wilks
v3: - Remove disable_device_start=True from shell start - Fixed Docstrings Paul Szczepanek (2): dts: allow expected packets to come from the TG dts: add softnic test dts/framework/test_suite.py| 18 +++-- dts/tests/TestSuite_softnic.py | 119 + 2 files ch

questions about pinned external buffers

2025-01-09 Thread Morten Brørup
Pinned external buffers were introduced with this patch: https://git.dpdk.org/dpdk/commit/lib/librte_mbuf/rte_mbuf.h?id=6ef1107ad4c6d4fcb6be627367ee0b97bb13e822 Question 1: Please confirm that the mbuf's pinned external buffer's refcnt is supposed to be 1 when an mbuf is returned to the mempool?

Re: [PATCH] examples/l3fwd: optimize packet prefetch

2025-01-09 Thread huangdengdui
On 2025/1/8 21:42, Konstantin Ananyev wrote: > > >> >> The prefetch window depending on the hardware platform. The current prefetch >> policy may not be applicable to all platforms. In most cases, the number of >> packets received by Rx burst is small (64 is used in most performance >> reports

[PATCH v23 11/13] compress/zsda: add zsda compressdev enqueue datapath

2025-01-09 Thread Hanxiao Li
Add zsda compressdev enqueue datapath. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/common/zsda/zsda_qp.c | 106 drivers/common/zsda/zsda_qp.h | 13 +- drivers/common/zsda/zsda_qp_common.c | 72 drivers/common/zsda

[PATCH v23 13/13] compress/zsda: add zsda compressdev capabilities

2025-01-09 Thread Hanxiao Li
Add zsda compressdev capabilities Signed-off-by: Hanxiao Li --- doc/guides/compressdevs/features/zsda.ini | 9 + doc/guides/compressdevs/zsda.rst | 23 +++ doc/guides/rel_notes/release_25_03.rst| 7 +++ drivers/compress/zsda/zsda_comp_pmd.c | 16

[PATCH v23 10/13] compress/zsda: add zsda compressdev qp ops

2025-01-09 Thread Hanxiao Li
Add zsda compressdev qp interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 267 ++ drivers/common/zsda/zsda_qp.h | 84 drivers/common/zsda/zsda_qp_common.h | 40 drivers/compress/zsda/zsda_comp_pmd.c |

[PATCH v23 04/13] common/zsda: add functions to operate hardware queue

2025-01-09 Thread Hanxiao Li
Add functions to operate hardware queue, such as queue start,stop and clear. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c| 7 + drivers/common/zsda/zsda_qp.c| 187 +++ drivers/common/zsda/zsda_

[PATCH v23 08/13] compress/zsda: add zsda compressdev stats ops

2025-01-09 Thread Hanxiao Li
Add zsda compressdev stats interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp_common.c | 63 +++ drivers/common/zsda/zsda_qp_common.h | 16 +++ drivers/compress/zsda/zsda_comp_pmd.c | 24 +- 3 files changed, 101 insertions(+)

[PATCH v23 07/13] compress/zsda: add zsda compressdev dev ops

2025-01-09 Thread Hanxiao Li
add zsda compressdev dev interface implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c | 9 +- drivers/common/zsda/zsda_qp_common.c | 57 +++ drivers/common/zsda/zsda_qp_common.h | 37 +++ drivers/co

[PATCH v23 05/13] common/zsda: add definition and use of msg chan.

2025-01-09 Thread Hanxiao Li
Add msg chan functions and the use to get hardware information or operate hardware. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c| 307 +++ drivers/common/zsda/zsda_qp.h| 48 + drivers/common/zsda/zsda_qp_common.h | 37 3 files cha

[PATCH v23 02/13] common/zsda: add zsdadev driver

2025-01-09 Thread Hanxiao Li
Add basic zsdadev init and register PCI probe functions Signed-off-by: Hanxiao Li --- MAINTAINERS | 3 + drivers/common/zsda/meson.build | 13 ++ drivers/common/zsda/zsda_device.c| 187 +++ drivers/common/zsda/zsda_device.h| 54 ++

[PATCH v23 12/13] compress/zsda: add zsda compressdev dequeue datapath

2025-01-09 Thread Hanxiao Li
Add zsda compressdev dequeue datapath. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 55 + drivers/common/zsda/zsda_qp.h | 1 + drivers/common/zsda/zsda_qp_common.h | 4 + drivers/compress/zsda/zsda_comp.c | 155 ++ driver

[PATCH v23 03/13] common/zsda: add logging macros

2025-01-09 Thread Hanxiao Li
Add zxdh logging implementation. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c| 22 +++--- drivers/common/zsda/zsda_logs.c | 19 +++ drivers/common/zsda/zsda_logs.h | 27 +

[PATCH v23 06/13] compress/zsda: add zsda compressdev driver skeleton

2025-01-09 Thread Hanxiao Li
Add zsda compressdev driver interface skeleton Signed-off-by: Hanxiao Li --- MAINTAINERS | 3 + doc/guides/compressdevs/features/zsda.ini | 6 + doc/guides/compressdevs/index.rst | 1 + doc/guides/compressdevs/zsda.rst | 171 ++

[PATCH v23 09/13] compress/zsda: add zsda compressdev xform ops

2025-01-09 Thread Hanxiao Li
Add zsda compressdev xform interface implementation. Signed-off-by: Hanxiao Li --- drivers/compress/zsda/zsda_comp_pmd.c | 54 ++- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/compress/zsda/zsda_comp_pmd.c b/drivers/compress/zsda/zsda_comp_pmd.c

[PATCH v23 01/13] config: add zsda device number

2025-01-09 Thread Hanxiao Li
Add the number of zsda devices. Signed-off-by: Hanxiao Li --- config/rte_config.h | 4 1 file changed, 4 insertions(+) diff --git a/config/rte_config.h b/config/rte_config.h index 3734db6bdc..86897de75e 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -119,6 +119,10 @@ #defin

[PATCH v23 00/13] drivers/zsda: introduce zsda drivers

2025-01-09 Thread Hanxiao Li
v23: - modify funcitons name to move the verb to the end - move the qp_setup and qp_release calls in same patch - make the queue setup APIs common with one function. - Fix some code in original patch. v22: - modify misspelled errors. v21: - modify some errors. v20 - add release note which was fo

Re: [RFC v2 1/1] eventdev: add atomic queue to test-eventdev app

2025-01-09 Thread Luka Jankovic
On Mon, 2024-12-23 at 12:16 +0100, Mattias Rönnblom wrote: > > > +static __rte_always_inline void > > Why is this __rte_always_inline? > The stage functions are based on the ones defined in test_order_queue.c and the test_order_common.h respectively, where they were defined with __rte_always_

[DPDK/testpmd Bug 1612] add a new flag to read from file without showing the input in cmd-line

2025-01-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1612 Bug ID: 1612 Summary: add a new flag to read from file without showing the input in cmd-line Product: DPDK Version: 25.03 Hardware: All OS: Windows Stat