[v1 16/16] test/crypto: test virtio_crypto_user PMD

2024-12-23 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a/app

[v1 15/16] crypto/virtio: add vhost backend to virtio_user

2024-12-23 Thread Gowrishankar Muthukrishnan
Add vhost backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_pci.h

[v1 14/16] common/virtio: support cryptodev in vdev setup

2024-12-23 Thread Gowrishankar Muthukrishnan
Support cryptodev in vdev setup. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/virtio_user/vhost_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/virtio/virtio_user/vhost_vdpa.c b/drivers/common/virtio/virtio_user/vhost_vdpa.c ind

[v1 13/16] common/virtio: move vDPA to common directory

2024-12-23 Thread Gowrishankar Muthukrishnan
Move vhost-vdpa backend implementation into common folder. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/meson.build | 13 + drivers/common/virtio/version.map | 9 ++ .../virtio/virtio_user/vhost.h| 2 -- .../virtio/virt

[v1 12/16] common/virtio: common virtio log

2024-12-23 Thread Gowrishankar Muthukrishnan
Common virtio log include file. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/{net => common}/virtio/virtio_logs.h | 16 ++ drivers/crypto/virtio/meson.build | 1 + .../{virtio_logs.h => virtio_crypto_logs.h} | 30 --- drivers/crypto/virtio/virtio_

[v1 11/16] crypto/virtio: add packed ring support

2024-12-23 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers/cryp

[v1 10/16] crypto/virtio: refactor queue operations

2024-12-23 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/virtio_crypto_algs.h | 2 +- drivers/crypto/virtio/virtio_c

[v1 09/16] crypto/virtio: fix dataqueues iteration

2024-12-23 Thread Gowrishankar Muthukrishnan
Fix dataqueues iteration using nb_queue_pairs info available in device data instead of max dataqueues as dataqueue count might have been changed in device configuration. Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan ---

[v1 08/16] examples/vhost_crypto: add asymmetric support

2024-12-23 Thread Gowrishankar Muthukrishnan
Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 54 ++-- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 558c09a60f..8bdfc40c4b 10

[v1 07/16] vhost: add asymmetric RSA support

2024-12-23 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- lib/vhost/vhost_crypto.c | 504 --- lib/vhost/vhost_user.h | 33 ++- 2 files changed, 498 insertions(+), 39 deletions(-) diff --git a/lib/vhost/vhost_cryp

[v1 04/16] test/crypto: check for RSA capability

2024-12-23 Thread Gowrishankar Muthukrishnan
In RSA crypto tests, check if it is supported by PMD before executing it. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c ind

[v1 06/16] test/crypto: add asymmetric tests for virtio PMD

2024-12-23 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 29 ++ app/test/test_cryptodev_rsa_test_vectors.h | 4 +++ 2 files changed, 33 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/tes

[v1 05/16] test/crypto: return proper codes in create session

2024-12-23 Thread Gowrishankar Muthukrishnan
From: Rajesh Mudimadugula Return proper error codes in create_auth_session() to avoid segfaults as a result of this. Signed-off-by: Rajesh Mudimadugula --- app/test/test_cryptodev.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/app

[v1 03/16] crypto/virtio: add asymmetric RSA support

2024-12-23 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c | 384 +++--- drivers/crypto/virtio/virtio_rxt

[v1 02/16] crypto/virtio: remove redundant crypto queue free

2024-12-23 Thread Gowrishankar Muthukrishnan
From: Rajesh Mudimadugula Remove multiple invocations of virtio_crypto_queue_release, and set virtio crypto queue as null upon free to avoid segfaults. Signed-off-by: Rajesh Mudimadugula --- .mailmap | 1 + drivers/crypto/virtio/virtio_cryptodev.c | 11 +---

[v1 01/16] vhost: include AKCIPHER algorithms in crypto_config

2024-12-23 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan --- lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/virtio_crypto.h b/lib/vhost/virtio_crypto.h index e3

[v1 00/16] crypto/virtio: vDPA and asymmetric support

2024-12-23 Thread Gowrishankar Muthukrishnan
This series introduces vDPA backend support to virtio crypto PMD. Also added asymmetric RSA support. Gowrishankar Muthukrishnan (14): vhost: include AKCIPHER algorithms in crypto_config crypto/virtio: add asymmetric RSA support test/crypto: check for RSA capability test/crypto: add asymmet

[PATCH 5/5] drivers/net: use portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. This patch replaces __rte_weak with macro RTE_WEAK. Signed-off-by: Andre Muezerie --- drivers/net/enic/enic_main.c

[PATCH 3/5] drivers/bus: use portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. This patch replaces __rte_weak with macro RTE_WEAK. Signed-off-by: Andre Muezerie --- drivers/bus/auxiliary/auxiliary

[PATCH 4/5] drivers/common: use portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. This patch replaces __rte_weak with macro RTE_WEAK. Signed-off-by: Andre Muezerie --- drivers/common/nitrox/nitrox_de

[PATCH 2/5] app/test-compress-perf: use portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. This patch replaces __rte_weak with macro RTE_WEAK. Signed-off-by: Andre Muezerie --- app/test-compress-perf/main.c |

[PATCH 0/5] use portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. Andre Muezerie (5): lib/eal: add portable macro for weak linking app/test-compress-perf: use portable macro for weak

[PATCH 1/5] lib/eal: add portable macro for weak linking

2024-12-23 Thread Andre Muezerie
MSVC uses pragmas to indicate weak linking, so the old __rte_weak attribute needs to made into a macro so that the same syntax can be used for MSVC and other compilers like gcc. This patch adds macro RTE_WEAK and deprecates __rte_weak. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_commo

Re: [PATCH] app/test: fix stack overflow in fib6_perf_autotest

2024-12-23 Thread Andre Muezerie
On Mon, Dec 23, 2024 at 01:30:00PM -0800, Stephen Hemminger wrote: > On Mon, 23 Dec 2024 13:10:33 -0800 > Andre Muezerie wrote: > > > From: Andre Muezerie > > To: Vladimir Medvedkin > > Cc: dev@dpdk.org, Andre Muezerie > > Subject: [PATCH] app/test: fix stack overflow in fib6_perf_autotest >

Re: [PATCH] app/test-cmdline: add test to Windows build

2024-12-23 Thread Stephen Hemminger
On Mon, 23 Dec 2024 11:35:41 -0800 Andre Muezerie wrote: > From: Andre Muezerie > To: > Cc: dev@dpdk.org, Andre Muezerie > Subject: [PATCH] app/test-cmdline: add test to Windows build > Date: Mon, 23 Dec 2024 11:35:41 -0800 > X-Mailer: git-send-email 1.8.3.1 > > Header termios.h was not foun

Re: [PATCH] app/test: fix stack overflow in fib6_perf_autotest

2024-12-23 Thread Stephen Hemminger
On Mon, 23 Dec 2024 13:10:33 -0800 Andre Muezerie wrote: > From: Andre Muezerie > To: Vladimir Medvedkin > Cc: dev@dpdk.org, Andre Muezerie > Subject: [PATCH] app/test: fix stack overflow in fib6_perf_autotest > Date: Mon, 23 Dec 2024 13:10:33 -0800 > X-Mailer: git-send-email 1.8.3.1 > > Tes

[PATCH] app/test: fix stack overflow in fib6_perf_autotest

2024-12-23 Thread Andre Muezerie
Test fib6_perf_autotest was hitting a stack overflow on Windows with MSVC. The fix is to move some of the data from the stack to the heap. Signed-off-by: Andre Muezerie --- app/test/test_fib6_perf.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/test/tes

[PATCH v2] net/gve: Allocate qpl pages using malloc if memzone allocation fails

2024-12-23 Thread Joshua Washington
From: Praveen Kaligineedi Allocating QPL for an RX queue might fail if enough contiguous IOVA memory cannot be allocated. However, the only requirement for QPL for RX is that each 4K buffer be IOVA contiguous, not the entire QPL. Therefore, use malloc to allocate 4K buffers if the allocation usin

[PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails

2024-12-23 Thread Joshua Washington
From: Praveen Kaligineedi Allocating QPL for an RX queue might fail if enough contiguous IOVA memory cannot be allocated. However, the only requirement for QPL for RX is that each 4K buffer be IOVA contiguous, not the entire QPL. Therefore, use malloc to allocate 4K buffers if the allocation usin

[PATCH] app/test-cmdline: add test to Windows build

2024-12-23 Thread Andre Muezerie
Header termios.h was not found on Windows, which was probably the reason this test was originally excluded from the Windows build. However, ir turns out this header is not needed for this test, so it can be removed and then test can be added to the Windows build without negative consequences. Sign

[PATCH v7 15/29] drivers/raw: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 28/29] lib/pipeline: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 19/29] examples/ip-pipeline: remove packed attributes

2024-12-23 Thread Andre Muezerie
Removed packed attributes from structs that are naturally packed already, or don't require packing. Signed-off-by: Andre Muezerie --- examples/ip_pipeline/cli.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c

[PATCH v7 29/29] lib/vhost: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 26/29] lib/ipsec: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 23/29] examples/ptpclient: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 22/29] examples/l3fwd: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 27/29] lib/net: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 16/29] drivers/regex: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 25/29] lib/eal: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 21/29] examples/l3fwd-power: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 20/29] examples/ipsec_secgw: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 24/29] examples/vhost_blk: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 17/29] drivers/vdpa: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 18/29] examples/common: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 13/29] drivers/mempool: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 06/29] drivers/baseband: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 11/29] drivers/dma: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 10/29] drivers/crypto: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 12/29] drivers/event: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 08/29] drivers/common: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 09/29] drivers/compress: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 04/29] app/test: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 07/29] drivers/bus: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 05/29] doc/guides: replace packed attributes

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v7 00/29] fix packing of structs when building with MSVC

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Provide a macro (__rte_packed_begin) that can be used to push existing pack value and sets packing to 1-byte. The existing __rte_packed macro is replaced with __rte_packed_end and restores the pack value prior to the push. Instead of providing macros

[PATCH v7 02/29] eal/include: add new packing macros

2024-12-23 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Add macro __rte_packed_begin which can be used to push existing pack value and set packing to 1-byte. Add macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler w

[PATCH v7 01/29] devtools: check packed attributes

2024-12-23 Thread Andre Muezerie
Ensure __rte_packed_begin and __rte_packed_end show up in pairs when checking patches. Signed-off-by: Andre Muezerie Acked-by: Tyler Retzlaff --- devtools/checkpatches.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatche

[PATCH v7 03/29] app/test-pmd: remove unnecessary packed attributes

2024-12-23 Thread Andre Muezerie
Removed __rte_packed attribute from structure that is naturally packed already. Signed-off-by: Andre Muezerie --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 2246c22e8e..d77a140641 100644 ---

Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread Andre Muezerie
On Mon, Dec 23, 2024 at 12:46:34PM +0100, David Marchand wrote: > On Mon, Dec 23, 2024 at 12:03 PM David Marchand > wrote: > > > v6: > > > * replace __rte_msvc_pack with __rte_packed_begin > > > * replace __rte_packed with __rte_packed_end > > > * update checkpatches.sh to ensure __rte_packe

Re: [PATCH v2 1/1] dts: add EAL confidence check suite

2024-12-23 Thread Patrick Robb
Hey Dean, I would retain the hello world name if I were you, in place of "eal" as you use here. I don't want to give off the impression that we are testing EAL in some intentional way, as opposed to providing a reference testsuite. On Mon, Dec 23, 2024 at 12:56 PM Dean Marx wrote: > Add a test

[PATCH v2 1/1] dts: add EAL confidence check suite

2024-12-23 Thread Dean Marx
Add a test suite to replace hello_world which simply starts and stops a testpmd session. The user can use this as a confidence check to verify their configuration. Signed-off-by: Dean Marx Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_eal.py | 27 +++ 1 file chang

[PATCH v13] dts: port over queue start/stop suite

2024-12-23 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. The verify argument in the deferred start method has been excluded due to a bug in testpmd, which renders checking port queue info for deferred start status impossible within a single method. Signed-

[PATCH] doc: fixing name of rfc2697 and rfc2698

2024-12-23 Thread Farhat Ullah
This patch fixes typos in the testpmd document for rfc2697 and rfc2698 Signed-off-by: Farhat Ullah --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testp

Re: [PATCH v2 00/14] use portable variadic macros

2024-12-23 Thread Andre Muezerie
On Mon, Dec 23, 2024 at 10:28:18AM +0100, David Marchand wrote: > On Wed, Dec 11, 2024 at 11:07 PM Andre Muezerie > wrote: > > > > Many places are using a GCC extension related to variadic macros, > > where a name prepends the ellipsis. This results in a warning like > > the one below when compili

[PATCH] doc: install guides and api docs to different directories

2024-12-23 Thread luca . boccassi
From: Luca Boccassi Otherwise they both get installed to /usr/share/doc/dpdk/html/ and overwrite each other's files Signed-off-by: Luca Boccassi --- doc/api/meson.build| 2 +- doc/guides/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/meson.build

[PATCH] doc: add install_tag to meson

2024-12-23 Thread luca . boccassi
From: "bl...@debian.org" This allows building and installing only the documentation, without recompiling the whole project, using: meson build -Denable_docs=true meson compile -C build doc meson install -C build --no-rebuild --tags doc In Debian/Ubuntu the documentation is built separately from

Re: [PATCH] net/vhost: improve devargs documentation

2024-12-23 Thread David Marchand
On Fri, Dec 20, 2024 at 3:58 PM Maxime Coquelin wrote: > > This patch adds missing 'client' devarg documentation and > improve other devargs. > > Bugzilla ID: 1603 > > Signed-off-by: Maxime Coquelin This fix lgtm. Note that legacy-ol-flags is not referenced in the pmdinfo usage string (RTE_PMD_

RE: net/mlx5: wrong Rx/Tx descriptor limits when DevX is off

2024-12-23 Thread Slava Ovsiienko
Confirm, it’s a bug, IIUC was introduced by reporting function update. AFAIK, we do not test with non-DevX environment anymore, so missed this. Fix should be provided. With best regards, Slava From: Asaf Penso Sent: Sunday, December 22, 2024 9:39 AM To: igooto...@gmail.com; Slava Ovsiienko Cc:

Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread David Marchand
On Mon, Dec 23, 2024 at 12:03 PM David Marchand wrote: > > v6: > > * replace __rte_msvc_pack with __rte_packed_begin > > * replace __rte_packed with __rte_packed_end > > * update checkpatches.sh to ensure __rte_packed_begin and > > __rte_packed_end are used in pairs > > I had mentionned

Re: [RFC v2 1/1] eventdev: add atomic queue to test-eventdev app

2024-12-23 Thread Mattias Rönnblom
On 2024-12-19 15:48, Luka Jankovic wrote: From 2e55ecd0e522f50cbb3635f53b025e165db7cf3e Mon Sep 17 00:00:00 2001 In-Reply-To: <228d44a6f2f1f6a4fb5519d9a91c99973f8d7352.ca...@ericsson.com> References: <228d44a6f2f1f6a4fb5519d9a91c99973f8d7352.ca...@ericsson.com> From: Luka Jankovic Date: Thu, 19

[PATCH v5 11/15] net/zxdh: promisc/allmulti ops implementations

2024-12-23 Thread Junlong Wang
provided promiscuous/allmulticast ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c | 21 ++- drivers/net/zxdh/zxdh_ethdev.h | 2 + drivers/net/zxdh/zxdh_ethdev_ops.c | 128 ++

[PATCH v5 15/15] net/zxdh: mtu update ops implementations

2024-12-23 Thread Junlong Wang
mtu update ops implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c | 5 +++ drivers/net/zxdh/zxdh_ethdev_ops.c | 65 ++ drivers/net/zxdh/zxdh_ethdev_

[PATCH v5 13/15] net/zxdh: rss hash config/update, reta update/get

2024-12-23 Thread Junlong Wang
provided rss hash config/update, reta update/get ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 3 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c | 52 drivers/net/zxdh/zxdh_ethdev.h | 3 + drivers/net/zxdh/zxdh_ethdev_op

[PATCH v5 08/15] net/zxdh: provided dev simple rx implementations

2024-12-23 Thread Junlong Wang
provided dev simple rx implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c| 1 + drivers/net/zxdh/zxdh_rxtx.c | 313 ++ drivers/net/zxdh/zxdh_r

[PATCH v5 12/15] net/zxdh: vlan filter/ offload ops implementations

2024-12-23 Thread Junlong Wang
provided vlan filter, vlan offload ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 3 + doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/zxdh_ethdev.c | 40 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 223 + drivers/net/zxd

[PATCH v5 09/15] net/zxdh: link info update, set link up/down

2024-12-23 Thread Junlong Wang
provided link info update, set link up /down, and link intr. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 22 +++- drivers/net/zxdh/zxdh_et

[PATCH v5 07/15] net/zxdh: provided dev simple tx implementations

2024-12-23 Thread Junlong Wang
provided dev simple tx implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 22 ++ drivers/net/zxdh/zxdh_queue.h | 26 ++- drivers/net/zxdh/zxdh_rxtx.c | 396 + drivers/net/zxdh/zxdh_rxtx.h

[PATCH v5 06/15] net/zxdh: dev start/stop ops implementations

2024-12-23 Thread Junlong Wang
dev start/stop implementations, start/stop the rx/tx queues. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c| 71 drivers/net/zxdh/zxdh_pci.c | 21 +++ driver

[PATCH v5 10/15] net/zxdh: mac set/add/remove ops implementations

2024-12-23 Thread Junlong Wang
provided mac set/add/remove ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_common.c | 24 +++ drivers/net/zxdh/zxdh_common.h | 1 + drivers/net/zxdh/zxdh_ethdev.c | 33 - drive

[PATCH v5 02/15] net/zxdh: zxdh np uninit implementation

2024-12-23 Thread Junlong Wang
(np)network processor release resources in host. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 48 drivers/net/zxdh/zxdh_np.c | 470 + drivers/net/zxdh/zxdh_np.h | 107 3 files changed, 625 insertions(+) diff --git a/driv

[PATCH v5 04/15] net/zxdh: port tables unint implementations

2024-12-23 Thread Junlong Wang
delete port tables in host. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 18 ++ drivers/net/zxdh/zxdh_msg.h| 1 + drivers/net/zxdh/zxdh_np.c | 103 + drivers/net/zxdh/zxdh_np.h | 9 +++ drivers/net/zxdh/zxdh_tables.c | 33

[PATCH v5 05/15] net/zxdh: rx/tx queue setup and intr enable

2024-12-23 Thread Junlong Wang
rx/tx queue setup and intr enable implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 4 + drivers/net/zxdh/zxdh_queue.c | 149 + drivers/net/zxdh/zxdh_queue.h | 33 3 files changed, 186 insertions(+) diff --git a/drive

[PATCH v5 00/15] net/zxdh: updated net zxdh driver

2024-12-23 Thread Junlong Wang
V5: - Simplify the notify_data part in the zxdh_notify_queue function. - Replace rte_zmalloc with rte_calloc in the rss_reta_update function. - Remove unnecessary check in mtu_set function. V4: - resolved ci compile issues. V3: - use rte_zmalloc and rte_calloc to avoid memset. - remov

Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread David Marchand
Hello Andre, On Wed, Nov 27, 2024 at 1:53 AM Andre Muezerie wrote: > > MSVC struct packing is not compatible with GCC. Provide a macro > (__rte_packed_begin) that can be used to push existing pack value > and sets packing to 1-byte. The existing __rte_packed macro is > replaced with __rte_packed_

RE: [RFC PATCH] ethdev: add new API for enable/disable xstat counters by ID

2024-12-23 Thread Shani Peretz
Sorry if it wasn't clear, in mlx5 there is limited number of counters, so if there are X counters and 2X queues, there won't be enough counters to get statistics for all queues at the same time. In this case we thought the best approach would be to allow the user to choose which queues they want

Re: [PATCH v3 01/10] devtools/cocci, lib/eal: remove unused rte_bitmap_free()

2024-12-23 Thread Ariel Otilibili-Anieli
On Sunday, December 22, 2024 17:43 CET, Stephen Hemminger wrote: > On Sun, 22 Dec 2024 02:19:53 +0100 > Ariel Otilibili wrote: > > > Coverity reports return values of calls to rte_bitmap_free() are not used. > > Some existing user code may actually be using this so this would be an API > cha

Re: [PATCH v2 0/5] Defer lcore variables allocation

2024-12-23 Thread Frode Nordahl
On Tue, Dec 17, 2024 at 10:00 AM David Marchand wrote: > > As I had reported in rc2, the lcore variables allocation have a > noticeable impact on applications consuming DPDK, even when such > applications does not use DPDK, or use features associated to > some lcore variables. > > While the amount

Re: The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6

2024-12-23 Thread Hu, Zhigang
Hi Thomas, Sorry for my mistake. I see the v2 patch. Best regards, Hu Zhigang From: Hu, Zhigang Sent: Friday, December 20, 2024 10:17 AM To: Thomas Monjalon Cc: dev@dpdk.org ; Dong, Yao ; Richardson, Bruce ; mattias.ronnb...@ericsson.com ; Liu1, Kai ; Chautru

Re: [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails

2024-12-23 Thread Praveen Kaligineedi
The TX queue requires IOVA contiguous QPL memory. So, we still need memzone code for TX queues. Regards, Praveen On Wed, Dec 18, 2024 at 7:51 PM Stephen Hemminger wrote: > > On Wed, 18 Dec 2024 15:46:35 -0800 > Joshua Washington wrote: > > > From: Praveen Kaligineedi > > > > Allocating QPL fo

Re: The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6

2024-12-23 Thread Hu, Zhigang
Hi Thomas, Thank you for your quick response. Your v1 patch works fine in my test. We are looking forward to your v2 patch. Best Regards, Zhigang From: Thomas Monjalon Sent: Thursday, December 19, 2024 7:48 PM To: Hu, Zhigang Cc: dev@dpdk.org ; Dong, Yao ; Rich

RE: [PATCH] bus/fslmc: fix use after rte_free

2024-12-23 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[PATCH 6/7] mlx5: use RDMA Netlink to update port information

2024-12-23 Thread Minggang Li(Gavin)
Previously, port information, such as adding and deleting, is updated via route netlink. And the events used are link up/down, not the exact event for port adding or deleting, which does not performance well. To improve the performance, use RDMA monitor events to track port adding and deleting eve

[PATCH 3/7] net/mlx5: add new devargs to control probe optimization

2024-12-23 Thread Minggang Li(Gavin)
From: Rongwei Liu Add a new devarg probe_opt_en to control probe optimization in PMD. By default, the value is 0 and no behavior changed. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst| 7 +++ drivers/common/mlx5/linux/mlx5_nl.c

[PATCH 7/7] mlx5: add backward compatibility for RDMA monitor

2024-12-23 Thread Minggang Li(Gavin)
Fallback to the old way to update port information if the kernel driver does not support RDMA monitor. Signed-off-by: Minggang Li(Gavin) Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_24_11.rst | 14 + drivers/common/mlx5/linux/mlx5_nl.c | 73 +

[PATCH 4/7] common/mlx5: fix Netlink socket leak

2024-12-23 Thread Minggang Li(Gavin)
Fixes: 72d7efe464b1 ("common/mlx5: share interrupt management") Cc: sta...@dpdk.org Signed-off-by: Minggang Li(Gavin) Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/

[PATCH 2/7] net/mlx5: optimize device probing

2024-12-23 Thread Minggang Li(Gavin)
From: Rongwei Liu Current DPDK probing logic is: 1. Query IB device index and total port number. 2. Query each port information by traversing the port index and get the port's ifindex, name and state information etc. 3. Compare the information with devargs until getting matched. 4. For each pr

[PATCH 5/7] common/mlx5: add RDMA monitor event awareness

2024-12-23 Thread Minggang Li(Gavin)
RDMA monitor is a new feature introduced by kernel driver. This commit adds backward compatibility for the kernels do not support it. Signed-off-by: Minggang Li(Gavin) Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/meson.build | 10 ++ drivers/common/mlx5/linux/mlx5_nl.c

[PATCH V1 0/7] port probe time optimization

2024-12-23 Thread Minggang Li(Gavin)
This patch series introduced a feature that the time to probe a VF/SF will be reduced greatly in large scale, eg hundreds of VF/SFs. This feature is controlled through the "probe_opt_en" device argument. Setting it to a non-zero value indicates the application will enable this functionality when pr

[PATCH 1/7] mailmap: update user name

2024-12-23 Thread Minggang Li(Gavin)
Signed-off-by: Minggang Li(Gavin) --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 818798273f..69afc5b6b2 100644 --- a/.mailmap +++ b/.mailmap @@ -464,7 +464,6 @@ Gary Mussar Gaurav Singh Gautam Dawar Gavin Hu -Gavin Li Geoffrey

  1   2   >