Re: [PATCH v8 00/47] TruFlow update for Thor2

2024-11-07 Thread Ajit Khaparde
On Thu, Nov 7, 2024 at 6:05 PM Sriharsha Basavapatna wrote: > > On Thu, Nov 7, 2024 at 7:12 PM Sriharsha Basavapatna > wrote: > > > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > > > TruFlow(TF) is the software library that exposes CFA HW resources to > > upper l

Re: [PATCH v8 00/47] TruFlow update for Thor2

2024-11-07 Thread Sriharsha Basavapatna
On Thu, Nov 7, 2024 at 7:12 PM Sriharsha Basavapatna wrote: > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > TruFlow(TF) is the software library that exposes CFA HW resources to > upper layer protocols or applications. This patch series implements the > tfc (tf_co

Re:RE: [EXTERNAL] [PATCH] graph: optimize graph search when scheduling nodes

2024-11-07 Thread Huichao Cai
> Is n't breaking the ABI? So can't we modify the ABI, or is there any special operation required to modify the ABI?

[PATCH v5 12/20] app/testpmd: remove use of VLAs for Windows built

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v5 13/20] test: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v5 15/20] net/i40e: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_testpmd.c | 5 ++--- 1 file changed, 2 insertion

[PATCH v5 19/20] test: remove use of VLAs for Windows built code in bitset tests

2024-11-07 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v5 20/20] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2024-11-07 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v5 18/20] build: enable vla warnings on Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v5 16/20] common/mlx5: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v5 17/20] net/mlx5: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v5 09/20] gro: remove use of VLAs

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v5 11/20] net/ice: remove use of VLAs

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v5 10/20] net/ixgbe: remove use of VLAs

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v5 14/20] common/idpf: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/idpf_common_rxtx.c| 2 +- drivers/common/i

[PATCH v5 07/20] rcu: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v5 04/20] ethdev: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v5 06/20] hash/thash: remove use of VLAs for Windows built

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v5 05/20] hash: remove use of VLAs for Windows built code

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v5 02/20] eal/linux: remove use of VLAs

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v5 01/20] eal: include header required for alloca

2024-11-07 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

[PATCH v5 03/20] eal/common: remove use of VLAs

2024-11-07 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

[PATCH v5 00/20] remove use of VLAs for Windows

2024-11-07 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v2 1/1] baseband/acc: fix ring memory allocation logic

2024-11-07 Thread Nicolas Chautru
Allowing ring memory allocation whose end address is aligned with 64 MB. Previous logic was off by one. Fixes: 060e76729302 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 2 +- 1 file changed, 1 insertion(+

[PATCH v2 0/1] baseband/acc: fix ring memory allocation logic\

2024-11-07 Thread Nicolas Chautru
Hi Maxime, v2: following your suggestion which is best indeed. Can you please review and apply that fix for 24.11. Thanks, Nic Nicolas Chautru (1): baseband/acc: fix ring memory allocation logic drivers/baseband/acc/acc_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.

Re: [PATCH v17 0/8] Lcore variables

2024-11-07 Thread Thomas Monjalon
> Mattias Rönnblom (8): > eal: add static per-lcore memory allocation facility > eal: add lcore variable functional tests > eal: add lcore variable performance test > eal: add lcore variables' programmer's guide > random: keep PRNG state in lcore variable > power: keep per-lcore state i

RE: RFC - Tap io_uring PMD

2024-11-07 Thread Morten Brørup
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, 6 November 2024 08.47 > > Hi Stephen, > > On 10/30/24 22:56, Stephen Hemminger wrote: > > The current tap device is slow both due to architectural choices and > the > > overhead of Linux system calls. I am exploring a

[PATCH v31 12/12] maintainers: update for log library

2024-11-07 Thread David Marchand
From: Stephen Hemminger "You touch it you own it". Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v31 11/12] log: colorize log output

2024-11-07 Thread David Marchand
From: Stephen Hemminger Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic t

[PATCH v31 10/12] log: support systemd journal

2024-11-07 Thread David Marchand
From: Stephen Hemminger If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dep

[PATCH v31 09/12] log: add timestamp option

2024-11-07 Thread David Marchand
From: Stephen Hemminger When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default i

[PATCH v31 08/12] log: add hook for printing log messages

2024-11-07 Thread David Marchand
From: Stephen Hemminger This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 in

[PATCH v31 07/12] eal: initialize log before everything else

2024-11-07 Thread David Marchand
From: Stephen Hemminger In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical, based on the support of non-OS isolated CPU's wh

[PATCH v31 06/12] log: rework syslog handling

2024-11-07 Thread David Marchand
From: Stephen Hemminger Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also adds syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use only sta

[PATCH v31 05/12] eal: improve exit output log

2024-11-07 Thread David Marchand
From: Stephen Hemminger The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EA

[PATCH v31 04/12] eal: do not log init failure twice

2024-11-07 Thread David Marchand
From: Stephen Hemminger The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen F

[PATCH v31 03/12] eal: introduce log options parser

2024-11-07 Thread David Marchand
Rename existing log level option parser and add a little helper tracking all options related to logs. This will make it easier to add more log options in the next commits. Signed-off-by: David Marchand --- lib/eal/common/eal_common_options.c | 26 ++ lib/eal/common/eal_op

[PATCH v31 02/12] eal: factorize parser for log level

2024-11-07 Thread David Marchand
From: Stephen Hemminger The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/co

[PATCH v31 01/12] eal/windows: align getopt to FreeBSD

2024-11-07 Thread David Marchand
From: Stephen Hemminger Having different prototypes on different platforms can lead to lots of unnecessary workarounds. It looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const

[PATCH v31 00/12] Log library enhancements

2024-11-07 Thread David Marchand
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

Re: [PATCH v2 2/2] dts: add blocklist test suite

2024-11-07 Thread Nicholas Pratte
Hi Luca, nice work! See my small comment below/ I ran some local tests and everything seems to be working fine, so other than that minor fix I pointed out, the rest should be all set! > +"""The DPDK device blocklisting test suite. > + > +This testing suite ensures tests the port blocklisting fun

[PATCH v8 42/47] net/bnxt: tf_ulp: TFC support flow scale query for Thor2

2024-11-07 Thread Sriharsha Basavapatna
From: Shuanglin Wang TFC supports the flow scale query feature for OVS application. The resource usage(WC-TCAM) is tracked inside Thor2 firmware. This patch is to query the wc-tcam usage info when adding/ deleting a flow. It is just for debugging purpose and disabled by default. Using the build

[PATCH v8 36/47] net/bnxt: tf_ulp: add support for rss flow query to ULP

2024-11-07 Thread Sriharsha Basavapatna
From: Randy Schacher Support flow query rss command for truflow in ULP layer. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c| 39 +- drivers/net/bnxt/bnxt_

Re: [v2 01/12] net/enetc: Add initial ENETC4 PMD driver support

2024-11-07 Thread Stephen Hemminger
On Wed, 23 Oct 2024 11:54:22 +0530 vanshika.shu...@nxp.com wrote: > +/* IOCTL */ > +#define KPG_NC_MAGIC_NUM 0xf0f0 > +#define KPG_NC_IOCTL_UPDATE _IOWR(KPG_NC_MAGIC_NUM, 1, size_t) > + > + > +#define KNRM "\x1B[0m" > +#define KRED "\x1B[31m" > +#define KGRN "\x1B[32m" > +#define K

RE: [PATCH v7 3/7] ring: make copying functions generic

2024-11-07 Thread Morten Brørup
It should be safe adding __rte_restrict to the "ring_table" and "obj_table" pointers. I don't know if it makes any real difference; these functions are called from applications via function pointers where the function type doesn't have __rte_restrict to the arrays. If __rte_restrict were added

[PATCH v8 14/47] net/bnxt: tf_ulp: add support for vf to vf flow offload

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support for the vf to vf flow offload for the whitney platform. It includes the change of the pipeline from using vlan tags to using custom L2 encap and decap of the packets. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shah

Re: [PATCH v2 1/2] dts: add blocked ports to EalParams

2024-11-07 Thread Nicholas Pratte
Hi Luca, this looks good to me! The only thing that needs to be fixed is the attributes component of the docstring for EalParams in eal.py. Aside from that: Reviewed-by: Nicholas Pratte On Thu, Nov 7, 2024 at 9:00 AM Luca Vizzarro wrote: > > Make the "ports" attribute of EalParams as it actuall

[PATCH v2 1/2] dts: add blocked ports to EalParams

2024-11-07 Thread Luca Vizzarro
Make the "ports" attribute of EalParams as it actually is to "allowed_ports", and add "blocked_ports". Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 6 +- dts/framework/params/types.py | 3 ++- dts/framework/rem

RE: [v5 00/42] DPAA2 specific patches

2024-11-07 Thread Hemant Agrawal
> -Original Message- > From: vanshika.shu...@nxp.com > Sent: Wednesday, October 23, 2024 5:29 PM > To: dev@dpdk.org > Subject: [v5 00/42] DPAA2 specific patches > > From: Vanshika Shukla > > This series includes: > -> Fixes and enhancements for NXP DPAA2 drivers. > -> Upgrade with MC ve

RE: [PATCH v7 0/7] Stage-Ordered API and other extensions for ring library

2024-11-07 Thread Konstantin Ananyev
> > > The concept of ‘ring with stages’ is similar to DPDK OPDL eventdev PMD [1], > > but the internals are different. > > In particular, SORING maintains internal array of 'states' for each element > > in the ring that is shared by all threads/processes that access the ring. > > That allows 're

[PATCH v1] mailmap: change primary mail address

2024-11-07 Thread Konstantin Ananyev
use working mail address as a main one. Signed-off-by: Konstantin Ananyev --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index fd02950d9f..a22d28989c 100644 --- a/.mailmap +++ b/.mailmap @@ -805,7 +805,7 @@ Kirill Rybalchenko Kishore Padman

RE: [PATCH v7 2/7] ring: common functions for 'move head' ops

2024-11-07 Thread Morten Brørup
Copy-paste bad! Cleaning up good! :-) Thank you, Konstantin. Acked-by: Morten Brørup I wonder if would improve anything marking the head/tail pointers ("d" and "s") in the inner functions __rte_restrict? And perhaps the ring pointer "r" in the outer functions?

RE: [PATCH v7 1/7] test/ring: fix failure with custom number of lcores

2024-11-07 Thread Morten Brørup
Simple change, Acked-by: Morten Brørup

[PATCH v3 0/2] examples/l3fwd fixes for ACL mode

2024-11-07 Thread Konstantin Ananyev
v2 -> v3 - rebased against main - fixed check-patch warnings (grammar) v1 -> v2 As Song Jiale pointed outprevious fix is not enough to fix the problem he is observing with l3fwd in ACl mode: https://bugs.dpdk.org/show_bug.cgi?id=1502 This is a second attempt to fix it. Konstantin Ananyev (2): e

[PATCH v3 2/2] examples/l3fwd: fix read beyond array boundaries in ACL mode

2024-11-07 Thread Konstantin Ananyev
With commit: ACL mode now can use send_packets_multi(). What I missed with that changes: send_packets_multi() can't deal properly with input dst_port[i] == BAD_PORT (though it can set it itself), as it uses dst_port[i] values to read L2 addresses for the port and assumes dst_port[] to contain valid

[PATCH v3 1/2] examples/l3fwd: fix read beyond array bondaries

2024-11-07 Thread Konstantin Ananyev
ASAN report: ERROR: AddressSanitizer: unknown-crash on address 0x7ef92e32 at pc 0x0053d1e9 bp 0x7ef92c00 sp 0x7ef92bf8 READ of size 16 at 0x7ef92e32 thread T0 #0 0x53d1e8 in _mm_loadu_si128 /usr/lib64/gcc/x86_64-suse-linux/11/include/emmintrin.h:703 #1 0x53d1e8 in send

Re: [PATCH] test/fib: clarify FIB RCU negative tests

2024-11-07 Thread David Marchand
On Wed, Oct 16, 2024 at 8:42 PM Vladimir Medvedkin wrote: > @@ -445,7 +454,7 @@ test_invalid_rcu(void) > rcu_cfg.v = qsv2; > rcu_cfg.mode = RTE_FIB_QSBR_MODE_SYNC; > status = rte_fib_rcu_qsbr_add(fib, &rcu_cfg); > - RTE_TEST_ASSERT(status != 0, "Secondary RCU was mist

[PATCH v2 0/2] dts: add blocklist test suite

2024-11-07 Thread Luca Vizzarro
Hi there, sending v2. v2: - rebased Best, Luca Luca Vizzarro (2): dts: add blocked ports to EalParams dts: add blocklist test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/params/eal.py | 6 +- dts/framework/params/types.py |

[PATCH v2 2/2] dts: add blocklist test suite

2024-11-07 Thread Luca Vizzarro
This test suite tests the port blocklisting functionality built in testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_blocklist.py | 63 ++ 2 files changed, 65 insertions(+)

[PATCH v8 7/7] test: add stress test suite

2024-11-07 Thread Konstantin Ananyev
Add a new test suite which purpose is to run 'stress' tests: main purpose is put a pressure to dpdk sync algorithms to flag their misbehaving/slowdown/etc. Right now it consists from just 2 test-cases: meson test --suite stress-tests --list DPDK:stress-tests / ring_stress_autotest DPDK:stress-tests

[PATCH v8 5/7] ring/soring: introduce Staged Ordered Ring

2024-11-07 Thread Konstantin Ananyev
Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues with multiple processing 'stages'. It is based on conventional DPDK rte_ring, re-uses many of its concepts, and even substantial part of its code. It can be viewed as an 'extension' of rte_ring functionality. In particular,

[PATCH v8 6/7] app/test: add unit tests for soring API

2024-11-07 Thread Konstantin Ananyev
Add both functional and stess test-cases for soring API. Stress test serves as both functional and performance test of soring enqueue/dequeue/acquire/release operations under high contention (for both over committed and non-over committed scenarios). Signed-off-by: Eimear Morrissey Signed-off-by:

[PATCH v8 0/7] Stage-Ordered API and other extensions for ring library

2024-11-07 Thread Konstantin Ananyev
Testing coverage (passed): x86_64, i686, PPC, ARM Would like to express my gratitude to all community members who helped with testing it on different platforms, in particular: David Christensen Cody Cheng Patrick Robb Phanendra Vukkisala Chengwen Feng v7 -> v8 - fixed several nits (spotte

[PATCH v8 4/7] ring: make dump function more verbose

2024-11-07 Thread Konstantin Ananyev
From: Eimear Morrissey The current rte_ring_dump function uses the generic rte_ring_headtail structure to access head/tail positions. This is incorrect for the RTS case where the head is stored in a different offset in the union of structs. Switching to a separate function for each sync type allo

[PATCH v8 3/7] ring: make copying functions generic

2024-11-07 Thread Konstantin Ananyev
Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - improve code modularity and re-usability - ability in future to re-use the same code to introduce new functionality There is no real need for enqueue_elems()/dequeue_elems() to

[PATCH v8 2/7] ring: common functions for 'move head' ops

2024-11-07 Thread Konstantin Ananyev
Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - code deduplication - ability in future to re-use the same code to introduce new functionality For each sync mode corresponding move_prod_head() and move_cons_head() are nearly i

[PATCH v8 1/7] test/ring: fix failure with custom number of lcores

2024-11-07 Thread Konstantin Ananyev
ring_stress_autotest fails to initialize the ring when RTE_MAX_LCORE value is not a number of 2. There is a flaw in calculation required number of elements in the ring. Fix it by aligning number of elements to next power of 2. Fixes: bf28df24e915 ("test/ring: add contention stress test") Cc: sta..

[PATCH v2] test/fib: clarify FIB RCU negative tests

2024-11-07 Thread Vladimir Medvedkin
Add additional negative tests for rte_fib_rcu_qsbr_add(). Also explicitly check returned codes. Additionally add a check into the rte_fib_rcu_qsbr_add() for passed fib argument. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 21 +++-- lib/fib/rte_fib.c | 3 +++ 2

Re: [PATCH] test/fib: clarify FIB RCU negative tests

2024-11-07 Thread Medvedkin, Vladimir
Hi David, On 07/11/2024 13:00, David Marchand wrote: On Wed, Oct 16, 2024 at 8:42 PM Vladimir Medvedkin wrote: @@ -445,7 +454,7 @@ test_invalid_rcu(void) rcu_cfg.v = qsv2; rcu_cfg.mode = RTE_FIB_QSBR_MODE_SYNC; status = rte_fib_rcu_qsbr_add(fib, &rcu_cfg); - RT

[PATCH v8 13/47] net/bnxt: tf_ulp: add custom l2 etype tunnel support

2024-11-07 Thread Sriharsha Basavapatna
From: Shahaji Bhosle Add hooks in the hwrm and ulp layer to enable, custom tunnel header support on wh+ generic app(ovs). Signed-off-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 4

[PATCH v8 19/47] net/bnxt: tf_ulp: convert recipe table to dynamic memory

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Converted the recipe table allocation from static model to dynamic memory allocation model. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 175

[PATCH v8 10/47] net/bnxt: tf_core: remove dead code from session-based priority TCAM mgr

2024-11-07 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to tx_tcam_supported and rx_tcam_supported logic which chooses between FW-based tcam resource allocation and driver-based tcam manager. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Peter Spreadborough Reviewed-by: Manis

[PATCH v8 16/47] net/bnxt: tf_ulp: miscellaneous fixes

2024-11-07 Thread Sriharsha Basavapatna
From: Mike Baucom Template compiler modifications for v3 api: Compile named/unnamed shared app resources for the applications that are capable. Change app id signature with base zero offset: The app id is used in the calculation of the matching signatures and as app id value incr

[PATCH v8 09/47] net/bnxt: tf_core: remove dead AFM code from session-based priority TCAM mgr

2024-11-07 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to AFM allocated memory which is no longer supported with TCAM mgr and truflow Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Farah Smith Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

Re: [PATCH 1/2] net/hns3: fix error code for repeatedly create counter

2024-11-07 Thread Stephen Hemminger
On Thu, 7 Nov 2024 19:56:44 +0800 Jie Hai wrote: > From: Dengdui Huang > > Return EINVAL instead of ENOSPC when the same counter ID is > used for multiple times to create a counter. > > Fixes: fcba820d9b9e ("net/hns3: support flow director") > Cc: sta...@dpdk.org > > Signed-off-by: Dengdui Hu

Re: RFC - Tap io_uring PMD

2024-11-07 Thread Stephen Hemminger
On Wed, 6 Nov 2024 03:52:51 +0300 Igor Gutorov wrote: > On Wed, Nov 6, 2024 at 2:54 AM Morten Brørup > wrote: > > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Wednesday, 6 November 2024 00.26 > > > > > > On Wed, 6 Nov 2024 00:22:19 +0100 > > > Morten Brørup w

Re: [PATCH 2/2] net/hns3: fix cannot fully use hardware flow director table

2024-11-07 Thread Stephen Hemminger
On Thu, 7 Nov 2024 19:56:45 +0800 Jie Hai wrote: > From: Dengdui Huang > > The hns3 driver checks whether the flow rule is repeatedly inserted based > on rte_hash. Currently, the rte_hash extendable bucket table feature is not > enabled. When there are many hash conflicts, the hash table space

Re: I am not able to see .rte_config file

2024-11-07 Thread Bruce Richardson
On Wed, Nov 06, 2024 at 07:57:35PM +0530, Eldho Paul Mathew wrote: >EAL: Detected 12 lcore(s) >EAL: Detected 1 NUMA nodes >PANIC in rte_eal_config_attach(): >Cannot open '/var/run/.rte_config' for rte_mem_config >I am using DPDK 18.05.1 version. >When I used this DPDK in a V

Re: [PATCH v7 0/7] Stage-Ordered API and other extensions for ring library

2024-11-07 Thread Stephen Hemminger
On Wed, 30 Oct 2024 17:22:57 -0400 Konstantin Ananyev wrote: > Testing coverage (passed): > x86_64, i686, PPC, ARM > > Would like to express my gratitude to all community members who helped me > with testing it on different platforms, in particular: > David Christensen > Cody Cheng > Patric

[PATCH v8 25/47] net/bnxt: tf_ulp: update template files

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. - enable recipe id generation - fix segfault in the wildcard recipe process Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v8 30/47] net/bnxt: tf_ulp: add mask defaults when mask is not specified

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha If application does not specify mask in a field description then use the default mask values from dpdk header files. This patch also includes the following related changes. fix stats collection for shared session The stats accumulation was being performed on def

[PATCH v8 45/47] net/bnxt: tf_ulp: support a few feature extensions

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch supports the following features. add support for port table write operation Added support for port table write operation from the template so that template can write mirror id details into the port database. support generic template fo

[PATCH v8 28/47] net/bnxt: tf_ulp: modify return values to adhere to C coding standard

2024-11-07 Thread Sriharsha Basavapatna
From: Shuanglin Wang Modified return values of the several ULP utilities to comply C coding standard. Like using macros EXIT_SUCCESS(0) and EXIT_FAILURE(1) for the conventional status value for success and failure, respectively. They are declared in the file stdlib.h. Signed-off-by: Shuanglin W

[PATCH v8 27/47] net/bnxt: tf_ulp: fixed parent child db counters

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha The locking for the parent child counters need to be done till the stats are retrieved. Also the OVS is creating multiple F1 flows for same tunnel hence reference count needs to be maintined for the F1 flows. Fix name conflicts for class and action tables. Matcher alloca

[PATCH v8 47/47] net/bnxt: tf_ulp: add stats cache for thor2

2024-11-07 Thread Sriharsha Basavapatna
From: Peter Spreadborough This change adds a stats cache for Thor2 flows using counters. Flow stats will be harvested periodically in the background and stats reads by the application will be returned stats from the cache and not by initiating a read from HW. This change also adds read-clear fun

[PATCH v8 15/47] net/bnxt: tf_ulp: Wh+ mirroring support

2024-11-07 Thread Sriharsha Basavapatna
From: Manish Kurup 1. ULP fixes to enable primitives to support mirroring 2. RTE parser changes to support and use multiple ports in RTE input msgs 3. Template changes required to support ingress mirroring 4. Template changes required to support egress mirroring (using VFR pipeline) Signed

[PATCH v8 21/47] net/bnxt: tf_ulp: add action read and clear support

2024-11-07 Thread Sriharsha Basavapatna
From: Jay Ding Implement action read and clear support. Change flow query count to reset the count after read in ULP. Update cli cmds accordingly. Fixed bnxt_mpc_xmit() to pad the mpc message to be multiple of 16 bytes. Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v8 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash

2024-11-07 Thread Sriharsha Basavapatna
From: Peter Spreadborough The RTE hash is highly optimized and will use HW acceleration when available. Signed-off-by: Peter Spreadborough Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 4 dr

[PATCH v8 26/47] net/bnxt: tf_ulp: enable recipe id generation

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support to generate recipe id generation. This patch includes a few related changes: fix segfault in the wildcard recipe process The recipe id is being passed as 8 bit instead of 64bit causing the crash. Ported code using default_non_ha resource

[PATCH v8 34/47] net/bnxt: tf_ulp: add rte_mtr support for Thor2

2024-11-07 Thread Sriharsha Basavapatna
From: Jay Ding 1. Implement Thor2 meter template tables 2. Add Thor2 meter support in ULP 3. Make rte_mtr API implementation device independent to adapt Thor2 meter hw change 4. Fix the round issue in xir calculation Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v8 41/47] net/bnxt: tf_ulp: support a few generic template items

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch provides the following changes. support generic template items Add support for jump action, dynamic tunnels and flow priority to thor2 platform. fix generic application template The queue action is enabled for Thor2 platform. E

I am not able to see .rte_config file

2024-11-07 Thread Eldho Paul Mathew
EAL: Detected 12 lcore(s) EAL: Detected 1 NUMA nodes PANIC in rte_eal_config_attach(): Cannot open '/var/run/.rte_config' for rte_mem_config I am using DPDK 18.05.1 version. When I used this DPDK in a VM, I am not able to init the EAL subsystem. When it is in a Appliances I am able to do. Question

Re: [PATCH v4 02/13] eal: replace strtok with reentrant version

2024-11-07 Thread Jie Hai
Hi, Stephen Hemminger, Thanks for your reviews. I'll replace all strtok with strtok_r, and Cc to stable only the necessary ones. Best regards, Jie Hai On 2024/10/29 10:51, Stephen Hemminger wrote: On Tue, 29 Oct 2024 08:56:20 +0800 fengchengwen wrote: This doesn't need to go to stable. p

RE: [PATCH v7 4/7] ring: make dump function more verbose

2024-11-07 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 30 October 2024 22.23 > > From: Eimear Morrissey > > The current rte_ring_dump function uses the generic rte_ring_headtail > structure to access head/tail positions. This is incorrect for the RTS > case where th

DTS WG Meeting Minutes - November 7, 2024

2024-11-07 Thread Patrick Robb
# November 7, 2024 Attendees * Patrick Robb * Paul Szczepanek * Thomas Wilks * Luca Vizzarro # Minutes ==

[PATCH v8 23/47] net/bnxt: tf_ulp: VFR updates for Thor 2

2024-11-07 Thread Sriharsha Basavapatna
From: Mike Baucom Update to VFR code to: - add the endpoint (efid) to the session - modify the generic tables to write the l2 context id - tfc session code changes to allow the efid to be added to the sid - release both rfid and efid from afm This patch includes a few related changes: Thor2 cha

[PATCH v8 35/47] net/bnxt: tf_ulp: TF support flow scale query

2024-11-07 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v8 44/47] net/bnxt: tf_ulp: enable support for truflow feature configuration

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added truflow feature bit meson configuration parameter to enable optional capability features of the application. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_u

[PATCH v8 29/47] net/bnxt: tf_ulp: update template files

2024-11-07 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. dynamic support for VF representor mode (template files only) The configurable VF representor mode is removed and it is dynamic. The action record

  1   2   >