Maxime,
Do you think you might be able to look at the info below (probably got lost in
the many emails this last week / weekend).
Kind regards,
-ChrisB
From: Chris Brezovec (cbrezove)
Date: Saturday, November 2, 2024 at 12:00 PM
To: dev@dpdk.org , maxime.coque...@redhat.com
Cc: Roger Melto
> -Original Message-
> From: pbhagavat...@marvell.com
> Sent: Monday, November 4, 2024 5:38 PM
> To: Jerin Jacob ; Pavan Nikhilesh Bhagavatula
> ; Shijith Thotton
> Cc: dev@dpdk.org
> Subject: [PATCH] event/cnxk: fix incorrect template macros
>
> From: Pavan Nikhilesh
>
> Fix incorr
On 2024/11/7 2:57, Stephen Hemminger wrote:
> On Tue, 14 Nov 2023 16:24:56 +0800
> Dengdui Huang wrote:
>
>> The function strerror() is insecure in a multi-thread environment.
>> This series of patches fix it. In this patchset, only the libs and
>> drivers are modified.
>
> strerror is ok in m
Thanks Dean. I reworded the commit message to "Condition set_forward_mode
verify code on the verify argument, which was originally omitted" because I
think even with a tiny bugfix, we want to explain for the commit history
what the commit is doing, instead of a vague "this is a bugfix" type
message
Series-reviewed-by: Patrick Robb
The added config validation here is great, thanks.
Reviewed-by: Patrick Robb
On Wed, 6 Nov 2024 22:02:16 +
Morten Brørup wrote:
> iff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 78fac63ab6..1752c58069 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1470,42 +1470,
Configuring one queue per port (#define RTE_MAX_QUEUES_PER_PORT 1) fails
compilation with e.g.:
../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop':
../drivers/net/bnxt/bnxt_rxq.c:587:34: error: array subscript 1 is above array
bounds of 'uint8_t[1]' {aka 'unsigned char[1]'} [-Werror
Configuring one queue per port (#define RTE_MAX_QUEUES_PER_PORT 1) fails
compilation with e.g.:
../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop':
../drivers/net/bnxt/bnxt_rxq.c:587:34: error: array subscript 1 is above array
bounds of 'uint8_t[1]' {aka 'unsigned char[1]'} [-Werror
On Fri, Jul 5, 2024 at 1:20 PM Nicholas Pratte wrote:
> Adjusted DPDK documentation to reflect the changes made to the dts
> conf.yaml configuration file.
>
> Bugzilla ID: 1360
> Signed-off-by: Nicholas Pratte
>
Reviewed-by: Dean Marx
On Fri, Jul 5, 2024 at 1:20 PM Nicholas Pratte wrote:
> There is some odd functionality/behavior in how the --test-suite
> parameters interacts in conjunction with the 'test_suites' attribute in
> the config file. If a user leaves an empty list underneath
> 'test_suites,' or if they negate the at
Hi,
There isn't a way to pass the patch through to coverity through our
scripting with how we have it written currently. It probably wouldn't be a
big update to start running it based on a given patch provided, if you
think there may be a somewhat regular need for this. I assume in this case
we wo
On Wed, Nov 6, 2024 at 7:18 PM Stephen Hemminger
wrote:
>
> On Tue, 5 Nov 2024 11:27:21 +
> Bruce Richardson wrote:
>
> > The callbacks(rx_cb) member of struct interface was unused inside
> > dumpcap, but was taking up a lot of memory space, since it was scaled
> > according to RTE_MAX_QUEUE
On Tue, Nov 5, 2024 at 10:05 PM David Marchand
wrote:
> On Thu, Oct 24, 2024 at 5:20 PM Robin Jarry wrote:
> >
> > Here are fixes for three coverity issues:
>
> This series fixes two coverity issues. The fixes look correct.
> But the Coverity reports are not obvious to me.
>
> Is there a way to p
On Fri, Jul 5, 2024 at 2:32 PM Nicholas Pratte wrote:
> Rework 'lcores' and 'memory_channels' into a new 'dpdk_config'
> subsection in an effort to make these attributes SUT specific; the
> traffic generator, more often than not, does not need this information.
> Ideally, if such information is n
On Tue, Nov 5, 2024 at 3:20 PM Morten Brørup wrote:
>
> > From: Robin Jarry [mailto:rja...@redhat.com]
> > Sent: Tuesday, 5 November 2024 15.13
> >
> > IPv6 headers are always aligned on a 2-bytes grid. Reflect this in the
> > structure definition.
> >
> > Signed-off-by: Robin Jarry
> Reviewed-by
On Tue, Nov 5, 2024 at 10:09 AM Morten Brørup
wrote:
>
> > From: David Marchand [mailto:david.march...@redhat.com]
> > Sent: Tuesday, 5 November 2024 09.59
> >
> > The new function breaks compilation with -Wcast-align.
> >
> > In file included from /home/runner/work/ovs/ovs/dpdk-
> > dir/include/
On Tue, Nov 5, 2024 at 2:28 PM David Marchand wrote:
> On Fri, Nov 1, 2024 at 8:54 AM wrote:
> >
> > From: Pavan Nikhilesh
> >
> > Free memory allocated for the node when xstats memory
> > allocation fails.
> >
> > Coverity issue: 445529
> > Fixes: 070db97e017b ("graph: support node xstats")
> >
On 30/10/2024 17:08, Nicholas Pratte wrote:
> There exists a bug within i40e NICs in which the async sniffer does not
> catch send packets as a result of the callback function sending packets
> too quickly before the NICs are ready to start capturing.
>
> There could be a multitude of reasons wh
Reviewed-by: Nicholas Pratte
On Fri, Jul 5, 2024 at 2:32 PM Nicholas Pratte wrote:
> The 'arch' attribute in the conf.yaml is unnecessary, as this can be
> readily discovered within the constructor of any given node. Since OS is
> determined within user configuration, finding system arch can be done
> both reliably and easil
Hello,
On Sat, Oct 26, 2024 at 12:26 PM Jie Hai wrote:
>
> Multiple threads calling the same function may cause condition
> race issues, which often leads to abnormal behavior and can cause
> more serious vulnerabilities such as abnormal termination, denial
> of service, and compromised data inte
On Fri, Jul 5, 2024 at 2:31 PM Nicholas Pratte wrote:
> Removed use_first_core from the conf.yaml in favor of determining this
> within the framework. use_first_core continue to serve a purpose in that
> it is only enabled when core 0 is explicitly provided in the
> configuration. Any other confi
On Fri, Jul 5, 2024 at 2:29 PM Nicholas Pratte wrote:
> Remove the list of devices from the schema, as these are unuesed.
> Likewise, removed build-target information since these is not currently
> used, and it is unlikely to be used in the future. Adjustments to the
> dts.rst are made to reflect
Code looks good. I ran some tests on my end and did not run into the
NULL test suite issue that Dean ran into. I'm guessing Dean ran into
an error changing up the code because the patch file wouldn't apply.
Reviewed-by: Nicholas Pratte
Tested-by: Nicholas Pratte
On Tue, 5 Nov 2024 11:27:21 +
Bruce Richardson wrote:
> The callbacks(rx_cb) member of struct interface was unused inside
> dumpcap, but was taking up a lot of memory space, since it was scaled
> according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
> memory by removing the whol
The introduction of TestSuiteSpec adds auto-discovery of test suites,
which are also automatically imported. This causes double imports as the
runner loads the test suites. This changes the behaviour of the runner
to load the imported classes from TestSuiteSpec instead of importing
them again.
Sig
Pydantic models are not treated the same way as dataclasses by autodoc.
As a consequence the docstrings need to be applied directly to each
field. Otherwise the generated API documentation page would present two
entries per each field with each their own differences.
Signed-off-by: Luca Vizzarro
Add and enable the autodoc-pydantic sphinx extension. Pydantic models
are not correctly recognised by autodoc, causing the generated docs to
lack all the actual model information. The autodoc-pydantic sphinx
extension fixes the original behaviour by correctly formatting them.
Signed-off-by: Luca V
Since pydantic has completely replaced warlock, there is no more need to
keep it as a dependency. This removes it.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
Reviewed-by: Nicholas Pratte
---
dts/poetry.lock| 227 +
dts/pyproject.to
This change brings in pydantic in place of warlock. Pydantic offers
a built-in model validation system in the classes, which allows for
a more resilient and simpler code. As a consequence of this change:
- most validation is now built-in
- further validation is added to verify:
- cross referenci
The DPDKBuildInfo and NodeInfo classes, representing information
gathered in runtime, were erroneously placed in the configuration
package. This moves them in more appropriate modules.
NodeInfo, specifically, is moved to os_session instead of node mostly
as a consequence of circular dependencies.
Currently there is a lack of a definition which identifies all the test
suites available to test. This change intends to simplify the process to
discover all the test suites and identify them.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
Reviewed-by: Nicholas Pratte
---
dts/framew
As part of configuration validation and deserialization improvements,
this adds pydantic as a project dependency. Pydantic is a library that
caters to all of the aforementioned needs, while improving the process
and code.
Signed-off-by: Luca Vizzarro
Reviewed-by: Paul Szczepanek
Reviewed-by: Nic
Hi there,
sending a v5 for the pydantic changes.
v5:
- rebased
- fixed typos
- renamed NodeInfo to OSSessionInfo
- fixed bug on DPDKRemoteTarballConfiguration object
v4:
- added autodoc_pydantic due to autodoc warnings
- fixed pydantic models docstrings
- updated docs
- refactored DPDKBuildInfo a
On 31/10/2024 20:52, Nicholas Pratte wrote:
--- a/doc/guides/tools/dts.rst
+++ b/doc/guides/tools/dts.rst
@@ -204,9 +204,10 @@ node, and then run the tests with the newly built binaries.
Configuring DTS
~~~
-DTS configuration is split into nodes and test runs and build targets w
On 31/10/2024 20:16, Nicholas Pratte wrote:
On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote:
The DPDKBuildInfo and NodeInfo classes, representing information
gathered in runtime, were erroneously placed in the configuration
package. This moves them in more appropriate modules.
NodeInfo,
On 31/10/2024 20:21, Nicholas Pratte wrote:
On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote:
Currently there is a lack of a definition which identifies all the test
suites available to test. This change intends to simplify the process to
discover all the test suites and idenfity them.
No
> Fixed a problem with setting the key in the session in the ECDSA
> algorithm. Since the key is being initialized in the session for EC,
> it should be reflected in the PMD session initialization function.
>
> Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session")
> Cc: sta.
> For the synchronous API the enqueue/dequeue burst functions are not
> called. Skip these tests when calling the synchronous API.
>
> Fixes: 4ad17a1c8fb3 ("test/crypto: fix enqueue/dequeue callback case")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Brian Dooley
Applied to dpdk-next-crypto
Thanks.
On Wed, Nov 06, 2024 at 08:22:29AM +, Soumyadeep Hore wrote:
> In ICE PMD, previously the ready bitmap checking before reading
> PHY timestamp was not present. This caused incorrect Tx
> timestamping.
>
> The ready bitmap checking is enabled and PHY timestamp is read once
> the ready bitmap gi
Most other device classes in DPDK which offer telemetry provide a list
of the devices of that class via "//list", e.g. /ethdev/list,
/ring/list, /mempool/list. However, eventdev provided that list via
"dev_list" command. For consistency, add "list" as an alias for
"dev_list" - after all the "dev" i
The eventdev telemetry support did not have a command for showing basic
info about each eventdev device, such as the name and driver in use. Add
this callback to allow telemetry user to determine which eventdev device
is which.
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.c | 37
Two small improvements for eventdev telemetry:
* add a device info command to show the name, driver and other minor
details for each device.
* add aliases for "dev_list" and "dev_info" to just "list" and "info"
for consistency with other commands.
V2: expand from single patch to a 2-patch set.
The eventdev telemetry support did not have a command for showing basic
info about each eventdev device, such as the name and driver in use. Add
this callback to allow telemetry user to determine which eventdev device
is which.
Signed-off-by: Bruce Richardson
---
lib/eventdev/rte_eventdev.c | 37
06/11/2024 13:19, Morten Brørup:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 6 November 2024 12.52
> >
> > On Fri, Oct 25, 2024 at 11:52:23AM +, Morten Brørup wrote:
> > > When configuring DPDK for one queue per port
> > > (#define RTE_MAX_QUEUES_PER_POR
Hi Kai,
Any update on this patch?
> > I'm not see any issue with original code, can you give more details about
> > crash
> so
> > I can try to reproduce at my end.
> > cc kirill.rybalche...@intel.com for review
>
> The details are there in Bugzilla
> https://bugs.dpdk.org/show_bug.cgi?id=1537
> From: Gagandeep Singh
>
> Setting ESN seq number initialization.
> Initialize the sequence number of ESP to 1.
>
> Signed-off-by: Gagandeep Singh
> Signed-off-by: Barry Cao
> ---
Series applied to dpdk-next-crypto
Thanks.
> Fixed a problem with setting the key in the session
> in the ECDSA alghorithm.
Please elaborate what is the problem and what is being done in the patch.
>
> Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Arkadiusz Kusztal
> This commit adds SM2 elliptic curve based asymmetric
> encryption and decryption to the Intel QuickAssist
> Technology PMD.
>
> Depends-on: patch-147900 ("[v2] crypto/qat: fix ecdsa session handling")
>
> Signed-off-by: Arkadiusz Kusztal
Update qat.ini file also.
> ---
> doc/guides/rel_note
> In the case when PMD cannot support the full process of the SM2,
> but elliptic curve computation only, additional fields
> are needed to handle such a case.
>
> Points C1, kP therefore were added to the SM2 crypto operation struct.
>
> Signed-off-by: Arkadiusz Kusztal
> ---
Please rebase. CI
On 11/6/2024 9:08 AM, David Marchand wrote:
> By using RTE_LOG*() macros, the log messages are prefixed by the logtype.
>
> RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "zxdh rx %s(): ", ...
> will emit messages like "ZXDH_RX: zxdh rx %s(): ...\n"
>
> There is no need to add a prefix repeating the same in
> > > > > > Probably the hardest part of using io_uring is figuring out how
> > to
> > > > > > collect
> > > > > > completions. The simplest way would be to handle all
> > completions rx
> > > > and
> > > > > > tx
> > > > > > in the rx_burst function.
> > > > >
> > > > > Please don't mix RX and T
> This commit fixes an unset length in modular algorithms
> in QAT asymmetric crypto PMD.
>
> Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Arkadiusz Kusztal
> ---
Applied to dpdk-next-crypto
Thanks.
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday, November 6, 2024 11:09 AM
> To: Kusztal, ArkadiuszX ; dev@dpdk.org
> Cc: Dooley, Brian
> Subject: RE: [EXTERNAL] [PATCH v8 1/3] cryptodev: add ec points to sm2 op
>
> > In the case when PMD cannot support the full pro
Fixed a problem with setting the key in the session in the ECDSA
algorithm. Since the key is being initialized in the session for EC,
it should be reflected in the PMD session initialization function.
Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session")
Cc: sta...@dpdk.org
On Wed, Nov 06, 2024 at 10:59:47AM +, Bruce Richardson wrote:
> On Wed, Nov 06, 2024 at 08:22:29AM +, Soumyadeep Hore wrote:
> > In ICE PMD, previously the ready bitmap checking before reading
> > PHY timestamp was not present. This caused incorrect Tx
> > timestamping.
> >
> > The ready b
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Wednesday, 6 November 2024 12.52
>
> On Fri, Oct 25, 2024 at 11:52:23AM +, Morten Brørup wrote:
> > When configuring DPDK for one queue per port
> > (#define RTE_MAX_QUEUES_PER_PORT 1), compilation of some network
> drivers
>
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday, November 6, 2024 12:52 PM
> To: Kusztal, ArkadiuszX ; dev@dpdk.org
> Cc: Dooley, Brian ; sta...@dpdk.org
> Subject: RE: [EXTERNAL] [PATCH v2] crypto/qat: fix ecdsa session handling
>
> > Fixed a problem with setting the key in
>
> > Subject: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version
> >
> > AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4.
> > A minimum IPsec Multi-buffer version of 1.4 or greater is now required for
> > the
> > 24.11 LTS release.
> >
> > Signed-off-by: Brian Dooley
> > Acked-b
> The algorithm name is a string and should be copied with strlcpy()
> rather than rte_memcpy(). This fixes a warning detected with
> clang and ASAN.
>
> Bugzilla ID: 1565
> Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations")
> Cc: asek...@marvell.com
>
> Signed-off-by: Stephen H
On Fri, Oct 25, 2024 at 11:52:23AM +, Morten Brørup wrote:
> When configuring DPDK for one queue per port
> (#define RTE_MAX_QUEUES_PER_PORT 1), compilation of some network drivers
> fails with e.g.:
>
> ../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop':
> ../drivers/net/bnxt/bn
On Fri, Oct 25, 2024 at 11:52:22AM +, Morten Brørup wrote:
> Added two new compiler/optimizer hints:
> * The __rte_unreachable hint for use in points in code known never to be
> reached.
> * The __rte_assume hint for providing information about preconditions the
> compiler/optimizer might be un
> Move the duplicate code in a common function and
> remove un-necessary newline characters from the logs.
>
> Signed-off-by: Jun Yang
> Signed-off-by: Gagandeep Singh
> ---
Applied to dpdk-next-crypto
Thanks.
On Wed, Nov 06, 2024 at 01:19:40PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Wednesday, 6 November 2024 12.52
> >
> > On Fri, Oct 25, 2024 at 11:52:23AM +, Morten Brørup wrote:
> > > When configuring DPDK for one queue per port
> > > (
Hi, David,
Sorry, my negligence caused this issue.
Thank you for helping with the modifications.
In switch mode, when ``repr_matching_en`` flag is enabled in the devarg,
the match with compare result item is not supported to the ``ingress``
rule as an implicit REPRESENTED_PORT need to be added to the matcher.
That REPRESENTED_PORT item conflicts with the single item limitation for
match with c
In ICE PMD, previously the ready bitmap checking before reading
PHY timestamp was not present. This caused incorrect Tx
timestamping.
The ready bitmap checking is enabled and PHY timestamp is read once
the ready bitmap gives positive value.
Fixes: 881169950d80 ("net/ice/base: implement initial PT
https://bugs.dpdk.org/show_bug.cgi?id=1574
Bug ID: 1574
Summary: bnxt dropping all packets when memory is low
Product: DPDK
Version: 23.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
By using RTE_LOG*() macros, the log messages are prefixed by the logtype.
RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "zxdh rx %s(): ", ...
will emit messages like "ZXDH_RX: zxdh rx %s(): ...\n"
There is no need to add a prefix repeating the same information.
Signed-off-by: David Marchand
---
Note: thi
> -Original Message-
> From: Bing Zhao
> Sent: Tuesday, November 5, 2024 11:48 AM
> To: Suanming Mou ; Dariusz Sosnowski
> ; Slava Ovsiienko ; Ori Kam
> ; Matan Azrad
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH] doc: update match with compare result item limitation
>
> T
Interrupt mode is not working on E610 device because
this device doesn't enable the queue interrupt mapping,
this patch fixed the issue.
Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Cc: sta...@dpdk.org
Signed-off-by: Yuan Wang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
1 file
> Initialize cryptodev of zsda and add capabilities.
>
> Signed-off-by: Hanxiao Li
> ---
> MAINTAINERS | 1 +
> doc/guides/cryptodevs/features/zsda.ini | 44 ++
> doc/guides/cryptodevs/zsda.rst | 22 +
> doc/guides/rel_notes/release_24_11.rst
73 matches
Mail list logo
