Re: [PATCH v2 1/2] net/hns3: fix variable type

2024-10-21 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/10/22 12:01, Jie Hai wrote: > The patch fixes variable type in case of data trunction. > > Fixes: dd4b8bba785f ("net/hns3: support reporting names of registers") > Cc: sta...@dpdk.org > > Signed-off-by: Jie Hai > --- > drivers/net/hns3/hns3_regs.c | 4 ++-- > 1

Re: Use of strtok() in dpdk code

2024-10-21 Thread fengchengwen
On 2024/10/22 9:08, Stephen Hemminger wrote: > On Mon, 21 Oct 2024 21:30:02 +0300 > Isaac Boukris wrote: > >> Hello, >> >> I was debugging a crash resulting from strtok() returning NULL >> unexpectedly (string still had tokens and delimiters), and the only >> explanation I could come up with was

RE: [PATCH v7 2/5] power: refactor uncore power management library

2024-10-21 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Huisong, > -Original Message- > From: lihuisong (C) > Sent: Tuesday, October 22, 2024 8:47 AM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > radu.nico...@intel.com; jer...@marve

RE: [PATCH v7 2/5] power: refactor uncore power management library

2024-10-21 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 6:49 AM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; ga

RE: [PATCH v7 1/5] power: refactor core power management library

2024-10-21 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 6:50 AM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; ga

[RFC] net/ice: add devargs to control link update

2024-10-21 Thread Mingjin Ye
This patch adds the ‘link_period’ devargs to adjust the link update period (microseconds), when the value is less than or equal to 0 it will be disabled, by default it is not enabled. Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 7 drivers/net/ice/ice_ethdev.c | 69

Re: [PATCH v2 2/2] net/hns3: fix pointer offset

2024-10-21 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/10/22 12:01, Jie Hai wrote: > If the register values of multiple modules are obtained at a time, > the register values are incorrect because the data field to be filled > pointing to a wrong address. Update the pointer offset of data to > get the correct address. >

[PATCH v3 6/8] app/test: extract parse empty elements testcase for kvargs

2024-10-21 Thread Chengwen Feng
Extract parse empty elements test as one stand-alone testcase. And also fix the kvlist was not released when the branch fails. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 68 ++ 1 file changed, 29 insertions(+), 3

[PATCH v3 8/8] maintainers: update for kvargs library

2024-10-21 Thread Chengwen Feng
Add myself for voluntary maintenance of the kvargs library. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cd78bc7db1..f0bcebc651 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1718,6 +

[PATCH v3 7/8] app/test: add process opt testcase for kvargs

2024-10-21 Thread Chengwen Feng
This commit adds rte_kvargs_process_opt() API's testcase. Signed-off-by: Chengwen Feng --- app/test/test_kvargs.c | 106 ++--- 1 file changed, 90 insertions(+), 16 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c index d1e668ac4a..43b

[PATCH v3 3/8] app/test: extract without keys testcase for kvargs

2024-10-21 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the without keys tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 115 ++--- 1 file changed, 63 insertions(+), 52 delet

[PATCH v3 5/8] app/test: extract parse list value testcase for kvargs

2024-10-21 Thread Chengwen Feng
Extract parse list value test as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 54 +- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_

[PATCH v3 4/8] app/test: extract with keys testcase for kvargs

2024-10-21 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the with keys tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 60 +- 1 file changed, 36 insertions(+), 24 deletion

[PATCH v3 2/8] app/test: extract basic token count testcase for kvargs

2024-10-21 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the basic token count tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 120 - 1 file changed, 45 insertions(+), 75

[PATCH v3 0/8] refactor kvargs test

2024-10-21 Thread Chengwen Feng
When developing patchset [1], I found the kvargs test is hard to understand when tried to add some testcase. So refactor kvargs by: 1. introduce UT suite framework. 2. extract big test_valid_kvargs() to five part. And add myself for voluntary maintenance of the kvargs library. [1] https://patch

[PATCH v3 1/8] app/test: introduce UT suite framework for kvargs

2024-10-21 Thread Chengwen Feng
Introduce unit test suite framework for test_kvargs.c. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c index 7a60cac4c1..1

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Akhil Goyal
> On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon > wrote: > > > > 08/10/2024 20:49, Akhil Goyal: > > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > > for application to configure hardware. > > > > In my opinion, we should not return PCI BAR addresses to an application. > > We should

RE: [PATCH] event/cnxk: remove single dequeue functions

2024-10-21 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, October 22, 2024 10:30 AM > To: Jerin Jacob ; mattias.ronnb...@ericsson.com; > Pavan Nikhilesh Bhagavatula ; Shijith Thotton > > Cc: dev@dpdk.org > Subject: [PATCH] event/cnxk: remove single dequeue functions > > F

[PATCH] event/cnxk: remove single dequeue functions

2024-10-21 Thread pbhagavatula
From: Pavan Nikhilesh Remove single dequeue template files. Signed-off-by: Pavan Nikhilesh --- Depends-on: series-33580 (event/dsw: remove single event enqueue and dequeue) drivers/event/cnxk/cn10k_eventdev.c | 5 +- drivers/event/cnxk/cn10k_worker.h | 107 --

[PATCH v2 2/2] net/hns3: fix pointer offset

2024-10-21 Thread Jie Hai
If the register values of multiple modules are obtained at a time, the register values are incorrect because the data field to be filled pointing to a wrong address. Update the pointer offset of data to get the correct address. Fixes: dd4b8bba785f ("net/hns3: support reporting names of registers")

[PATCH v2 0/2] net/hns3: bugfix on register dump

2024-10-21 Thread Jie Hai
Jie Hai (2): net/hns3: fix variable type net/hns3: fix pointer offset drivers/net/hns3/hns3_regs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.22.0

[PATCH v2 1/2] net/hns3: fix variable type

2024-10-21 Thread Jie Hai
The patch fixes variable type in case of data trunction. Fixes: dd4b8bba785f ("net/hns3: support reporting names of registers") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_regs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hn

Re: [PATCH v7 2/5] power: refactor uncore power management library

2024-10-21 Thread lihuisong (C)
LGTM except for one typo, Acked-by: Huisong Li 在 2024/10/21 12:07, Sivaprasad Tummala 写道: iThis patch refactors the power management library, addressing uncore iThis --> This power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/po

RE: [EXTERNAL] graph: make the in-built nodes better reusable

2024-10-21 Thread Nitin Saxena
Hi Robin, Thanks for initiating this thread. I agree with majority of your points that you highlighted We(Marvell) also started integrating *rte_graph* in various use-cases and found need of following items: 1. Hot-plugging of ports at runtime. (Example link status change from DOWN -> UP and v

RE: [PATCH] bus/vmbus: remove unnecessary packed attribute

2024-10-21 Thread Wei Hu
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 10:37 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Long Li > ; Wei Hu > Subject: [PATCH] bus/vmbus: remove unnecessary packed attribute > > The VMBus ring structure was marked packed which will cause w

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

2024-10-21 Thread lihuisong (C)
Hi Stephen, The modification for this issue has been sent out. please have a look at v11, thanks. /Huisong 在 2024/10/15 23:45, Stephen Hemminger 写道: On Tue, 15 Oct 2024 17:41:39 +0800 "lihuisong (C)" wrote: Hi Stephen, Can you take a look at this reply so as to send out the next version A

Re: [PATCH v7 1/5] power: refactor core power management library

2024-10-21 Thread lihuisong (C)
Hi Sivaprasad, Some comments inline. 在 2024/10/21 12:07, Sivaprasad Tummala 写道: This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' d

Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Jerin Jacob
On Tue, Oct 22, 2024 at 3:00 AM Thomas Monjalon wrote: > > 08/10/2024 20:49, Akhil Goyal: > > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > > for application to configure hardware. > > In my opinion, we should not return PCI BAR addresses to an application. > We should make an effort to

[PATCH] bus/vmbus: remove unnecessary packed attribute

2024-10-21 Thread Stephen Hemminger
The VMBus ring structure was marked packed which will cause warnings if the no-address-of-packed is enabled. The structure is all 32 bit values and the packed attribute has no impact on the code layout; remove it. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/rte_vmbus_reg.h | 2 +- 1 f

Re: [PATCH v12 03/12] common/zsda: add some common functions

2024-10-21 Thread Stephen Hemminger
On Sat, 19 Oct 2024 19:04:05 +0800 Hanxiao Li wrote: > +struct zsda_op_cookie { > + bool used; > + bool decomp_no_tail; > + void *op; > + uint16_t sid; > + struct zsda_sgl sgl_src; > + struct zsda_sgl sgl_dst; > + phys_addr_t sgl_src_phys_addr; > + phys_addr_t sgl_

Re: [PATCH v2 2/4] power: refactor uncore power management library

2024-10-21 Thread lihuisong (C)
Hi Sivaprasa, I have a inline question, please take a look. 在 2024/10/8 14:19, Tummala, Sivaprasad 写道: [AMD Official Use Only - AMD Internal Distribution Only] Hi Lihuisong, -Original Message- From: lihuisong (C) Sent: Tuesday, August 27, 2024 6:33 PM To: Tummala, Sivaprasad Cc: de

Re: [PATCH 06/20] event/cnxk: add CN20K SSO enqueue fast path

2024-10-21 Thread Stephen Hemminger
On Thu, 3 Oct 2024 18:52:23 +0530 wrote: Fix this in next version. Warning in drivers/event/cnxk/cn20k_worker.c: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx > + > +static inline int32_t > +sso_read_xaq_space(struct cn20k_sso_hws *ws) > +{ > + ret

Re: [PATCH v7 1/5] power: refactor core power management library

2024-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2024 04:07:19 + Sivaprasad Tummala wrote: > diff --git a/lib/power/version.map b/lib/power/version.map > index c9a226614e..016e599e90 100644 > --- a/lib/power/version.map > +++ b/lib/power/version.map > @@ -51,4 +51,19 @@ EXPERIMENTAL { > rte_power_set_uncore_env; >

Re: [PATCH v7 2/5] power: refactor uncore power management library

2024-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2024 04:07:20 + Sivaprasad Tummala wrote: > diff --git a/lib/power/rte_power_uncore_ops.h > b/lib/power/rte_power_uncore_ops.h > new file mode 100644 > index 00..f91994d3c1 > --- /dev/null > +++ b/lib/power/rte_power_uncore_ops.h > @@ -0,0 +1,230 @@ > +/* SPDX-License-

Re: [PATCH v7 0/5] power: refactor power management library

2024-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2024 04:07:18 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

[PATCH] doc: reword sample app guides

2024-10-21 Thread Nandini Persad
I revised these sections mostly for grammar and clarity. Signed-off-by: Nandini Persad --- doc/guides/sample_app_ug/l2_forward_cat.rst | 24 +++-- doc/guides/sample_app_ug/l2_forward_event.rst | 96 +-- .../sample_app_ug/l2_forward_macsec.rst | 8 +- .../sample_app_ug/l2

Re: [PATCH v1 52/73] net/ntnic: update alignment for virt queue structs

2024-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2024 23:04:54 +0200 Serhii Iliushyk wrote: > truct __rte_aligned(8) virtq_avail { > +struct __rte_packed __rte_aligned(1) virtq_avail { > uint16_t flags; > uint16_t idx; > uint16_t ring[];/* Queue Size */ > }; > > -struct __rte_aligned(8) virtq_used_ele

Re: [PATCH v1 37/73] net/ntnic: add flow dump feature

2024-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2024 23:04:39 +0200 Serhii Iliushyk wrote: > +void hw_db_inline_dump(struct flow_nic_dev *ndev, void *db_handle, const > struct hw_db_idx *idxs, > + uint32_t size, FILE *file) > +{ > + (void)ndev; Use __rte_unused, it is cleaner to read then.

[PATCH v1 64/73] net/ntnic: update documentation

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update required documentation Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/ntnic.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/nics/ntnic.rst b/doc/guides/nics/ntnic.rst index 2c160ae592..e7e1cbcff7 1006

[PATCH v3 7/7] dts: remove git ref option

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec Given the whole DPDK tree directory can now be copied to the nodes, there is no more need to use the git ref option, as the tree can be controlled directly by the user. Signed-off-by: Tomáš Ďurovec Signed-off-by: Luca Vizzarro --- doc/guides/tools/dts.rst | 9 --- dts/f

[PATCH v3 6/7] doc: update argument options for external DPDK build

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec By adding support for external build, we extend the argument documentation for supported options. Signed-off-by: Tomáš Ďurovec Signed-off-by: Luca Vizzarro --- doc/guides/tools/dts.rst | 75 1 file changed, 45 insertions(+), 30 dele

[PATCH v3 5/7] dts: add support for externally compiled DPDK

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec Enable the user to use either a DPDK source tree directory or a tarball, with and without a pre-built build directory. These can be stored on either SUT node or the DTS host. The DPDK build setup or the pre-built binaries can be specified through the configuration file, the co

[PATCH v3 4/7] dts: enable copying directories to and from nodes

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec Currently there is no support to transfer whole directories between the DTS host and the nodes. This change adds this new feature. Signed-off-by: Tomáš Ďurovec Signed-off-by: Luca Vizzarro --- dts/framework/testbed_model/os_session.py| 120 ++- dts/fram

[PATCH v3 3/7] dts: change remote and local paths objects

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec The OSSession (and its subclasses) should accept PurePaths for remote paths to translate from OS-unaware (PurePath) to OS-aware (Path) only on the remote side. For local paths, they should accept Paths, as Python is OS-aware locally. Signed-off-by: Tomáš Ďurovec Signed-off-b

[PATCH v3 2/7] dts: enforce one dpdk build per test run

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec Given a pre-built DPDK repository can be supplied to DTS, there is no need to define multiple build targets. To simplify the process this change makes each test run use only one DPDK build whether it's pre-built or it needs to be built by DTS. Signed-off-by: Tomáš Ďurovec Si

[PATCH v3 1/7] dts: rename build target to DPDK build

2024-10-21 Thread Luca Vizzarro
From: Tomáš Ďurovec Since the DPDK may already be built, some more general name is needed that includes both the DPDK location and the build config (if we are going to build). Signed-off-by: Tomáš Ďurovec Signed-off-by: Luca Vizzarro --- .mailmap | 1 + dts

[PATCH v3 0/7] DTS external DPDK build

2024-10-21 Thread Luca Vizzarro
Hello, sending a fix for some minor problems found in the meantime. v3: - added Tomáš to mailmap - fixed docstrings - amended commit subject v2: - rebased on top of dts-next and resolved conflicts - fixed bugs - rephrased some docstrings - improved settings naming for less ambiguity - improved co

[PATCH v1 34/73] net/ntnic: add flm rcp module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 4 +

[PATCH v1 61/73] net/ntnic: add xstats

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Extended statistics implementation and initialization were added. eth_dev_ops api was extended with new xstats apis. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/ntnic_stat.h| 36 + drive

[PATCH v1 59/73] net/ntnic: add STA module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets fpga map was extended with STA module support which enable statistics functionality. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 92 ++- .../nthw/supported/nthw_fpga_mod_str_map.c| 1 + .../nthw/support

[PATCH v1 70/73] net/ntnic: add age documentation

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov ntnic.rst document was exntede with age feature specification. ntnic.ini was extended with rte_flow action age support. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + doc/guides/nics/ntnic.rst | 18 ++ do

[PATCH v1 65/73] net/ntnic: added flow aged APIs

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov FLow aged API was added to the flow_filter_ops. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 71 +++ drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 88 +++ drivers/net/ntnic/ntnic_mod_reg.h

[PATCH v1 60/73] net/ntnic: add TSM module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets fpga map was extended with tsm module support which enable statistics functionality. Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini| 1 + .../supported/nthw_fpga_9563_055_049_.c | 394 +- .../nthw/suppor

Re: [PATCH v2 0/7] DTS external DPDK build

2024-10-21 Thread Dean Marx
Hi Luca, I noticed in the new version of this series the "improve statistics" patch was taken out, was there any reason for this? I believe Juraj wanted to create a feature that wrote all of the test suite/case summaries in a JSON/text output file, is this going to be implemented later or in a dif

[PATCH v1 66/73] net/ntnic: add aged API to the inline profile

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Added implementation for flow get aged API. Module which operate with age queue was extended with get, count and size operations. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/meson.build | 1 + .../flow_api/profile_inline/flm_age_queue.c |

[PATCH v1 58/73] net/ntnic: add tsm module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov tsm module which operate with timers in the physical nic was added. Necessary defines and implementation were added. The Time Stamp Module controls every aspect of packet timestamping, including time synchronization, time stamp format, PTP protocol, etc. Signed-off-by:

[PATCH v1 63/73] net/ntnic: add scrub registers

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Scrub fields were added to the fpga map file Remove duplicated macro Signed-off-by: Danylo Vodopianov --- .../supported/nthw_fpga_9563_055_049_.c | 17 - drivers/net/ntnic/ntnic_ethdev.c| 3 --- 2 files changed, 16 insertions(+),

[PATCH v1 62/73] net/ntnic: added flow statistics

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov xstats was extended with flow statistics support. Additional counters that shows learn, unlearn, lps, aps and other. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 40 drivers/net/ntnic/include/hw_mod_backend.h| 3 + dr

[PATCH v1 67/73] net/ntnic: add info and configure flow API

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Inline profile was extended with flow info and create APIS. Module which operate with age queue was extended with create and free operations. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/nthw/flow_api/flow

[PATCH v1 71/73] net/ntnic: add meter API

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Add meter API and implementation to the profile inline. management functions were extended with meter flow support. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 1 + drivers/net/ntnic/include/flow_api_engine.h | 5 + .../fl

[PATCH v1 68/73] net/ntnic: add aged flow event

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Port thread was extended with new age event callback handler. LRN, INF, STA registers getter setter was added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 7 + .../net/ntnic/nthw/flow_api/flow_id_table.c | 16 +++ .../net/nt

[PATCH v1 73/73] net/ntnic: add meter documentation

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov ntnic.ini was extended with rte_flow action meter support. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + doc/guides/nics/ntnic.rst | 1 + doc/guides/rel_notes/release_24_11.rst | 1 + 3 files changed, 3 insertions(+) di

[PATCH v1 69/73] net/ntnic: add thread termination

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduce clear_pdrv to unregister driver from global tracking. Modify drv_deinit to call clear_pdirv and ensure safe termination. Add flm sta and age event free. Signed-off-by: Danylo Vodopianov --- .../flow_api/profile_inline/flm_age_queue.c | 10 +++ .../flow_api

[PATCH v1 72/73] net/ntnic: add meter module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Meter module was added: 1. add/remove profile 2. create/destroy flow 3. add/remove meter policy 4. read/update stats eth_dev_ops struct was extended with ops above. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntos_drv.h | 14 + drivers/net/

Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-21 Thread Thomas Monjalon
08/10/2024 20:49, Akhil Goyal: > Added rte_pmd_rvu_lf_bar_get() API to get BAR address > for application to configure hardware. In my opinion, we should not return PCI BAR addresses to an application. We should make an effort to have all theses details managed in the driver. Giving this level of a

[PATCH v1 25/73] net/ntnic: add items gtp and actions raw encap/decap

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use * RTE_FLOW_ITEM_TYPE_GTP * RTE_FLOW_ITEM_TYPE_GTP_PSC * RTE_FLOW_ACTION_TYPE_RAW_ENCAP * RTE_FLOW_ACTION_TYPE_RAW_DECAP Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 4 + drivers/net/ntnic/include/create_el

[PATCH v1 54/73] net/ntnic: add statistics API

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Statistics init, setup, get, reset APIs and their implementation were added. Statistics fpga defines were added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 29 +- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 192 +

[PATCH v1 56/73] net/ntnic: add statistics poll

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Mechanism which poll statistics module and update values with dma module. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 343 ++ drivers/net/ntnic/include/ntdrv_4ga.h | 1 + drivers/net/ntnic/include/ntnic_

[PATCH v1 57/73] net/ntnic: added flm stat interface

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov flm stat module interface was added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 2 ++ drivers/net/ntnic/include/flow_filter.h| 1 + drivers/net/ntnic/nthw/flow_api/flow_api.c | 11 +++ drivers/net/ntnic/ntnic_mod_reg.

[PATCH v1 53/73] net/ntnic: enable RSS feature

2024-10-21 Thread Serhii Iliushyk
Enable receive side scaling Signed-off-by: Serhii Iliushyk --- doc/guides/nics/features/ntnic.ini| 3 + drivers/net/ntnic/include/create_elements.h | 1 + drivers/net/ntnic/include/flow_api.h | 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c| 6 ++ .../profile_inli

[PATCH v1 55/73] net/ntnic: add rpf module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Receive Port FIFO module controls the small FPGA FIFO that packets are stored in before they enter the packet processor pipeline. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 25 +++- drivers/net/ntnic/include/ntnic_stat.h

[PATCH v1 50/73] net/ntnic: add Tx INS module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 19 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 ++-

[PATCH v1 49/73] net/ntnic: add Tx CPY module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Copy module writes data to packet fields based on the lookup performed by the FLM module. This is used for NAT and can support other actions based on the RTE action MODIFY_FIELD. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_

[PATCH v1 52/73] net/ntnic: update alignment for virt queue structs

2024-10-21 Thread Serhii Iliushyk
Update incorrect alignment Signed-off-by: Serhii Iliushyk --- Cc: dvo-...@napatech.com --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c b/drivers/net/ntnic/dbsconfig/ntnic_d

[PATCH v1 51/73] net/ntnic: add Tx RPL module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 41 ++-

[PATCH v1 48/73] net/ntnic: add MOD SLC LR

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055

[PATCH v1 47/73] net/ntnic: add RPP LR module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX Packet Process for Local Retransmit module can add bytes in the FPGA TX pipeline, which is needed when the packet increases in size. Note, this makes room for packet expansion, but the actual expansion is done by the modules. Signed-off-by: Oleksandr Kolomeiets

[PATCH v1 45/73] net/ntnic: add MAC Rx module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 61 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 +- .../ntnic/nthw/s

[PATCH v1 43/73] net/ntnic: add HFU module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Header Field Update module updates protocol fields if the packets have been changed, for example length fields and next protocol fields. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 38 ++- 1 file changed

[PATCH v1 46/73] net/ntnic: add MAC Tx module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Media Access Control Transmit module contains counters that keep track on transmitted packets. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 38 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 +- .

[PATCH v1 33/73] net/ntnic: add FLM module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 42 ++

[PATCH v1 42/73] net/ntnic: add MOD FLM

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c |

[PATCH v1 44/73] net/ntnic: add IFR module

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 41 ++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/n

[PATCH v1 41/73] net/ntnic: add MOD CSU

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Checksum Update module updates the checksums of packets that has been modified in any way. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

[PATCH v1 36/73] net/ntnic: match and action db attributes were added

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Implements match/action dereferencing Signed-off-by: Danylo Vodopianov --- .../profile_inline/flow_api_hw_db_inline.c| 795 ++ .../profile_inline/flow_api_hw_db_inline.h| 35 + .../profile_inline/flow_api_profile_inline.c | 55 ++ 3 files chan

[PATCH v1 39/73] net/ntnic: add GMF (Generic MAC Feeder) module

2024-10-21 Thread Serhii Iliushyk
The Generic MAC Feeder module provides a way to feed data to the MAC modules directly from the FPGA, rather than from host or physical ports. The use case for this is as a test tool and is not used by NTNIC. This module is requireqd for correct initialization Signed-off-by: Serhii Iliushyk --- .

[PATCH v1 37/73] net/ntnic: add flow dump feature

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add posibilyty to dump flow in human readable format Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api_engine.h | 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c| 17 ++ .../profile_inline/flow_api_hw_db_inline.c| 264 +++

[PATCH v1 31/73] net/ntnic: add hash API

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 40 + drivers/net/ntnic/include/flow_api_engine.

[PATCH v1 40/73] net/ntnic: sort FPGA registers alphanumerically

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Beatification commit. It is required for pretty supporting different FPGA Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 364 +- 1 file changed, 182 insertions(+), 182 deletions(-) diff --git a/drivers/net/ntn

[PATCH v1 29/73] net/ntnic: add QSL module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/hw_mod_backe

[PATCH v1 32/73] net/ntnic: add TPE module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 16 + .../ntnic/nthw/flow_api/h

[PATCH v1 35/73] net/ntnic: add learn flow queue handling

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Implements thread for handling flow learn queue Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 5 + drivers/net/ntnic/include/ntdrv_4ga.h | 1 + .../ntnic/nthw/flow_api/hw_mod/hw_mod_flm.c | 33 +++ .../flow_api/prof

[PATCH v1 38/73] net/ntnic: add flow flush

2024-10-21 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Implements flow flush API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 13 ++ .../profile_inline/flow_api_profile_inline.c | 43 +++ .../profile_inline/flow_api_profile_inline.h | 4 ++ drivers/net/ntn

[PATCH v1 27/73] net/ntnic: add SLC LR module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_back

[PATCH v1 30/73] net/ntnic: add KM module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api_engine.h |

[PATCH v1 28/73] net/ntnic: add PDB module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 3 + .../ntnic/nthw/flow_api/hw_mod/hw_mod_pdb.c | 144 ++ .../profile

[PATCH v1 26/73] net/ntnic: add cat module

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov The Categorizer module’s main purpose is to is select the behavior of other modules in the FPGA pipeline depending on a protocol check. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 24 ++ .../ntnic/nthw/flow_api/hw_mod/hw_mod_cat

[PATCH v1 23/73] net/ntnic: add items IPv6 and ICMPv6

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use * RTE_FLOW_ITEM_TYPE_IPV6 * RTE_FLOW_ITEM_TYPE_ICMP6 Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 2 + drivers/net/ntnic/include/hw_mod_backend.h| 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c|

[PATCH v1 21/73] net/ntnic: add action VLAN

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use RTE_FLOW_ITEM_TYPE_VLAN Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/hw_mod_backend.h| 1 + .../profile_inline/flow_api_profile_inline.c | 96 ++- 3 file

[PATCH v1 19/73] net/ntnic: add item UDP

2024-10-21 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use RTE_FLOW_ITEM_TYPE_UDP Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/hw_mod_backend.h| 2 + .../profile_inline/flow_api_profile_inline.c | 103 ++ 3 fil

  1   2   3   >