[RFC v3 10/10] eventdev: remove single event enqueue and dequeue

Remove the single event enqueue and dequeue, since they did not provide any noticeable performance benefits. This is a change of the ABI, previously announced as a deprecation notice. These functions were not directly invoked by the application, so the API remains unaffected. Signed-off-by: Matti

[RFC v3 08/10] event/cnxk: remove single event enqueue and dequeue

From: Pavan Nikhilesh Provide only burst enqueue and dequeue. Signed-off-by: Pavan Nikhilesh -- RFC v3: * Rewrite. Pavan Nikhilesh is now the author. --- drivers/event/cnxk/cn10k_eventdev.c | 74 ++--- drivers/event/cnxk/cn10k_worker.c | 49 +-- dri

[RFC v3 02/10] event/dlb2: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom -- RFCv2: * Remove unused function. (Stephen Hemminger) --- drivers/event/dlb2/dlb2.c | 40 ++- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c

[RFC v3 04/10] event/sw: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom --- drivers/event/sw/sw_evdev.c| 2 -- drivers/event/sw/sw_evdev.h| 2 -- drivers/event/sw/sw_evdev_worker.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/d

[RFC v3 07/10] event/opdl: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom --- drivers/event/opdl/opdl_evdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 25853166bf..ffa65ef930 100644 --- a/drivers/event/opdl/opdl_evd

[RFC v3 06/10] event/dpaa2: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom -- RFC v2: * Remove unused functions. --- drivers/event/dpaa2/dpaa2_eventdev.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev

[RFC v3 05/10] event/dpaa: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom --- drivers/event/dpaa/dpaa_eventdev.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 85ccb586e

[RFC v3 09/10] event/skeleton: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom -- RFC v2: * Remove unused functions. --- drivers/event/skeleton/skeleton_eventdev.c | 29 -- 1 file changed, 29 deletions(-) diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/s

[RFC v3 01/10] event/dsw: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 2 -- drivers/event/dsw/dsw_evdev.h | 2 -- drivers/event/dsw/dsw_event.c | 12 3 files changed, 16 deletions(-) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/

[RFC v3 03/10] event/octeontx: remove single event enqueue and dequeue

Provide only burst enqueue and dequeue. Signed-off-by: Mattias Rönnblom --- drivers/event/octeontx/ssovf_evdev.h | 1 - drivers/event/octeontx/ssovf_worker.c | 40 +++ 2 files changed, 4 insertions(+), 37 deletions(-) diff --git a/drivers/event/octeontx/ssovf_evdev.h

[RFC v3 00/10] eventdev: remove single-event enqueue and dequeue

Remove the single-event enqueue and dequeue functions from the eventdev "ops" struct, to reduce complexity, leaving performance unaffected. This ABI change has been announced as a DPDK deprication notice, originally scheduled for DPDK 23.11. Mattias Rönnblom (9): event/dsw: remove single event

[PATCH v2 18/18] doc/guides/nics: add documents for r8169 pmd

Signed-off-by: Howard Wang --- MAINTAINERS| 2 ++ doc/guides/nics/features/r8169.ini | 32 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/r8169.rst | 17 4 files changed, 52 insertions(+) create mode 10

[PATCH v2 17/18] net/r8169: add driver_start and driver_stop

rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_base.h| 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v2 16/18] net/r8169: add support for getting fw version

Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 579350af69..b6ce8461ba 100644 --- a/drivers/net/r8169/r8169_ethdev.c +++ b/drivers/ne

[PATCH v2 15/18] net/r8169: impelment MTU configuration

Add support for updating MTU value. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 3e6bc570d6..579350af69 100644 --- a/drivers/net/

[PATCH v2 14/18] net/r8169: implement promisc and allmulti modes

Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 68 1 file changed, 68 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index cf9ea4dca4

[PATCH v2 13/18] net/r8169: implement device statistics

Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 16 +++ drivers/net/r8169/r8169_ethdev.c | 49 ++- drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 drivers/net/r8169/r8169_hw.h | 6 +++ 5 f

[PATCH v2 12/18] net/r8169: implement Tx path

Add implementation for TX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 681 ++- 3 files changed, 682 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v2 11/18] net/r8169: implement Rx path

Add implementation for RX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 27 ++ drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers/net/r8169/r8169_rxtx.c | 779 ++- 4 files changed, 897 inserti

[PATCH v2 10/18] net/r8169: add link status and interrupt management

Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 5 +- drivers/net/r8169/r8169_ethdev.c | 279 ++- drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169/r8169_hw.h | 3 + drivers/net/r8169/r8169_

[PATCH v2 09/18] net/r8169: add support for hw initialization

Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 43 +++ drivers/net/r8169/r8169_dash.c | 89 + drivers/net/r8169/r8169_dash.h | 35 ++ drivers/net/r8169/r8169_ethdev.c | 47 ++- drivers/net/r8169/r8169_ethdev.h | 30 +- driv

[PATCH v2 08/18] net/r8169: add support for phy configuration

This patch contains phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 10 + drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 445 +++ drivers/net/r8169/r8169_phy.h| 100 +++ 4 file

[PATCH v2 06/18] net/r8169: add phy registers access routines

Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_phy.c| 219 +++ drivers/net/r8169/r8169_phy.h| 18 +++ 3 files changed, 238 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.h b/drivers/net/r8169/r8169_

[PATCH v2 05/18] net/r8169: add support for hw config

Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 2 + drivers/net/r8169/r8169_ethdev.h | 15 +- drivers/net/r8169/r8169_hw.

[PATCH v2 04/18] net/r8169: implement core logic for Tx/Rx

Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 17 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_rxtx.c | 57 ++

[PATCH v2 03/18] net/r8169: add hardware registers access routines

Add implementation for hardware registers access routines. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 389 +++ drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_hw.c | 94 d

[PATCH v2 02/18] net/r8169: add logging structure

Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 40 drivers/net/r8169/r8169_logs.h | 53 2 files changed, 93 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h

[PATCH v2 01/18] net/r8169: add PMD driver skeleton

Meson build infrastructure, r8169_ethdev minimal skeleton, header with Realtek NIC device and vendor IDs. Signed-off-by: Howard Wang --- MAINTAINERS | 7 ++ drivers/net/meson.build | 1 + drivers/net/r8169/meson.build| 7 ++ drivers/net/r8169/r8169_base.h

[PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk

PATCH v2: modify some code as suggested by the maintainer. Howard Wang (18): net/r8169: add PMD driver skeleton net/r8169: add logging structure net/r8169: add hardware registers access routines net/r8169: implement core logic for Tx/Rx net/r8169: add support for hw config net/r8169: a

[PATCH 6/6] net/nfp: correct of misspellings

From: Zerun Fu Correction of misspellings in logs. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 4 ++-- drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++--- 2 files changed, 5 inser

[PATCH 4/6] net/nfp: reformat the abbreviations of logs

From: Zerun Fu Unified do not apply abbreviations in log. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 2 +- drivers/net/nfp/flower/nfp_flower_flow.c | 8 drivers/net/nfp/nfp_ethdev.c

[PATCH 3/6] net/nfp: reformat the header of logs

From: Zerun Fu Capitalize the first letter of each sentence in the log. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 4 +- drivers/common/nfp/nfp_common_pci.c | 2 +- drivers/net

[PATCH 2/6] net/nfp: modify the level of speed update log

From: Zerun Fu Here the invoke of `nfp_eth_read_ports()` may fail, but it's acceptable because it will recover soon once the link status changed. So modify the level of the log to avoid confusing users. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Z

[PATCH 0/6] Adjust format and level of log

This patches unify the format of log, also adjust some log level. Zerun Fu (6): net/nfp: modify the level of some logs net/nfp: modify the level of speed update log net/nfp: reformat the header of logs net/nfp: reformat the abbreviations of logs net/nfp: reformat the period of logs net

[PATCH 1/6] net/nfp: modify the level of some logs

From: Zerun Fu Now when the app starts it will enable some features, but sometimes the firmware doesn't support them. Then it will print some error messages. Actually this doesn't affect the using of the app, so change the level of log to avoid exposing the information to users. Signed-off-by:

[PATCH v15 4/7] random: keep PRNG state in lcore variable

Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen F

[PATCH v15 0/7] Lcore variables

This patch set introduces a new API for static per-lcore id memory allocation. Lcore variables are designed to replace static lcore id-indexed arrays and thread-local storage. See for the rationale and comparison with alternatives. Mattias Rönnblom (7): eal: add static per-lcore memory alloc

[PATCH v15 6/7] service: keep per-lcore state in lcore variable

Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v14: * Merge with bit

[PATCH v15 5/7] power: keep per-lcore state in lcore variable

Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH

[PATCH v15 2/7] eal: add lcore variable functional tests

Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macro

[PATCH v15 3/7] eal: add lcore variable performance test

Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

[PATCH v15 7/7] eal: keep per-lcore power intrinsics state in lcore variable

Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --

[PATCH v15 1/7] eal: add static per-lcore memory allocation facility

Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

Re: [PATCH 2/2] devtools: forbid the use of ffs compiler builtins

On 2024-10-16 17:04, Stephen Hemminger wrote: On Wed, 16 Oct 2024 15:54:11 +0200 Mattias Rönnblom wrote: Extend checkpatches.sh to detect the use of __builtin_(ffs|ffsll). These intrinsics are not available in MSVC, and there are perfectly serviceable alternatives in . Signed-off-by: Mattias

Re: [PATCH v14 0/7] Lcore variables

On 2024-10-16 16:58, Stephen Hemminger wrote: On Wed, 16 Oct 2024 15:19:09 +0200 Mattias Rönnblom wrote: This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternat

Re: [PATCH v14 1/7] eal: add static per-lcore memory allocation facility

On 2024-10-16 16:53, Stephen Hemminger wrote: On Wed, 16 Oct 2024 15:19:10 +0200 Mattias Rönnblom wrote: + +/** + * Allocate space in the per-lcore id buffers for an lcore variable. + * + * The pointer returned is only an opaque identifier of the variable. To + * get an actual pointer to a par

Re: [PATCH 0/5] Increase minimum meson version

UNH CI testing is ready for this change. On Wed, Oct 16, 2024 at 9:08 AM Patrick Robb wrote: > UNH will be updated to be running from the linux setup script by the end > of the day today, and I'll send another response here. > > On Sun, Oct 13, 2024 at 9:26 PM zhoumin wrote: > >> Hi Patrick Rob

Re: [PATCH v3 2/4] hash: add dynamic polynomial calculation

On Wed, 16 Oct 2024 17:28:17 +0100 "Medvedkin, Vladimir" wrote: > Hi Stephen, > > On 15/10/2024 23:29, Stephen Hemminger wrote: > > On Fri, 11 Oct 2024 18:17:00 + > > Vladimir Medvedkin wrote: > > > >> + > >> +uint32_t > >> +rte_thash_get_rand_poly(uint32_t poly_degree) > >> +{ > >> + ui

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

On Thu, 17 Oct 2024 10:11:13 +0800 "lihuisong (C)" wrote: > Hi Stephen, > > 在 2024/10/15 23:45, Stephen Hemminger 写道: > > On Tue, 15 Oct 2024 17:41:39 +0800 > > "lihuisong (C)" wrote: > > > >> Hi Stephen, > >> > >> Can you take a look at this reply so as to send out the next version ASAP? > >

RE: [PATCH v4] test: fix option devices

> -Original Message- > From: Mingjin Ye > Sent: Wednesday, October 16, 2024 4:17 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; sta...@dpdk.org > Subject: [PATCH v4] test: fix option devices > > Without using allow (-a) or block (-b), EAL loads all devices by default. > Unexpected devices may

Re: [PATCH v10 2/2] examples/l3fwd-power: add PM QoS configuration

在 2024/10/16 8:24, Konstantin Ananyev 写道: Add PM QoS configuration to declease the delay after sleep in case of entering deeper idle state. Signed-off-by: Huisong Li Acked-by: Morten Brørup --- examples/l3fwd-power/main.c | 24 1 file changed, 24 insertions(+)

Re: [PATCH v10 1/2] power: introduce PM QoS API on CPU wide

Hi Stephen, 在 2024/10/15 23:45, Stephen Hemminger 写道: On Tue, 15 Oct 2024 17:41:39 +0800 "lihuisong (C)" wrote: Hi Stephen, Can you take a look at this reply so as to send out the next version ASAP? Thanks.😁 /Huisong 在 2024/10/14 20:19, lihuisong (C) 写道: The biggest issue is that lcore is

Re: [PATCH] net/nfp: modify Rx buffer size setting logic

On 10/16/2024 9:15 AM, Chaoyong He wrote: > From: Long Wu > > In the previous logic, NFP driver would modify hardware Rx buffer size > every time rxq was set. This will cause the setting of one Rx queue > to affect all Rx queues, resulting in the card being unable to receive > packets properly in

Re: [PATCH] net/dpaa/fmlib: remove new line char from the logs

On 10/15/2024 6:05 PM, Stephen Hemminger wrote: > On Tue, 15 Oct 2024 17:35:38 +0530 > Hemant Agrawal wrote: > >> This patch remove the new line char from several logs in the >> fmlib base driver. >> >> Signed-off-by: Hemant Agrawal >> --- > > Acked-by: Stephen Hemminger > Applied to dpdk-nex

Re: [PATCH v01] net/af_packet: don't specify protocol on socket create

On 10/13/2024 2:59 PM, Gur Stavi wrote: > When creating AF_PACKET socket with specified protocol it is > immediately implicitly bound to any existing interface and > becomes RUNNING. Calling bind on such socket is affectively unbind > from "any interface", then bind to the specific interface. > D

Re: [PATCH v02] net/af_packet: support link status update

On 10/15/2024 4:19 PM, Stephen Hemminger wrote: > On Tue, 15 Oct 2024 12:57:29 +0300 > Gur Stavi wrote: > >> For net_af_packet PMD, eth_link_update was an empty function. >> Application may be interested in link up/down status. >> This patch adds implementation that updates dev_link->link_status

Re: [PATCH 0/4] debug enhancement and bug fix

On 10/14/2024 3:43 AM, Chaoyong He wrote: > This patch series includes two bug fix commits and two debug enhancement > commits. > > Huaxing Zhu (2): > net/nfp: add more logs to debug probe process > net/nfp: clear errors status of aer after soft reset > > Shihong Wang (1): > net/nfp: do not

Re: [PATCH] examples/l3fwd: support setting the data size of mbuf

Sorry to interrupt the conversation - obviously the CI testing fail is a false failure and should be ignored by the maintainer here. For those curious, it failed like this, which I have seen previously in a similar case: tester: Pkt number not matched,2000 sent and 1999 received I'm removing this

Re: [PATCH 1/2] bitset: discontinue the use of GCC builtin

On Wed, Oct 16, 2024 at 4:03 PM Mattias Rönnblom wrote: > > Replace the use of __builtin_ffsll() with rte_bsf64() to be MSVC > compatible. > > Suggested-by: David Marchand > Signed-off-by: Mattias Rönnblom Series applied, thanks. -- David Marchand

Re: [PATCH 2/2] devtools: forbid the use of ffs compiler builtins

On Wed, Oct 16, 2024 at 5:39 PM Stephen Hemminger wrote: > > On Wed, 16 Oct 2024 17:32:27 +0200 > David Marchand wrote: > > > On Wed, Oct 16, 2024 at 5:04 PM Stephen Hemminger > > wrote: > > > > > > On Wed, 16 Oct 2024 15:54:11 +0200 > > > Mattias Rönnblom wrote: > > > > > > > Extend checkpatch

[PATCH] app/dumpcap: replace use of __builtin_clzl

DPDK applications should avoid direct use of compiler builtin. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/mai

[DPDK/cryptodev Bug 1552] free miss match in cryptodev

https://bugs.dpdk.org/show_bug.cgi?id=1552 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

[DPDK/ethdev Bug 1549] free() of non rte_malloc() memory in DMA dev

https://bugs.dpdk.org/show_bug.cgi?id=1549 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

[DPDK/ethdev Bug 1554] Use after free in cnxk_ethdev

https://bugs.dpdk.org/show_bug.cgi?id=1554 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[DPDK/ethdev Bug 1550] Use after free in E1000 driver

https://bugs.dpdk.org/show_bug.cgi?id=1550 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

[DPDK/ethdev Bug 1551] use after free in Sfc driver

https://bugs.dpdk.org/show_bug.cgi?id=1551 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

[DPDK/vhost/virtio Bug 1553] free called on rte_malloc block in vhost

https://bugs.dpdk.org/show_bug.cgi?id=1553 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[DPDK/ethdev Bug 1510] net/ena build failure on Ubuntu 24.04 with LTO

https://bugs.dpdk.org/show_bug.cgi?id=1510 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

Re: [PATCH v2 0/4] Enhance headers check

On Wed, Oct 16, 2024 at 1:38 PM David Marchand wrote: > > We currently check that exported headers are fine with > -DALLOW_EXPERIMENTAL_API and -DALLOW_INTERNAL_API. > > Such a check won't catch issues like the one fixed in patch 1, where OVS > compilation is broken by the additional of experiment

[PATCH v26 15/15] doc: add release note about log library

Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/guides/rel_n

[PATCH v26 14/15] log: colorize log output

Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic tests and other embedded us

[PATCH v26 13/15] log: add support for systemd journal

If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v26 12/15] log: add optional support of syslog

Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_eal_

[PATCH v26 10/15] log: add hook for printing log messages

This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 f

[PATCH v26 11/15] log: add timestamp option

When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v26 09/15] log: drop syslog support, and make code common

This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_option

[PATCH v26 08/15] eal: initialize log before everything else

In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v26 07/15] log: move handling of syslog facility out of eal

The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_option

[PATCH v26 06/15] eal: change rte_exit() output to match rte_log()

The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages

The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v26 04/15] eal: make eal_log_level_parse common

The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

[PATCH v26 03/15] windows: add os shim for localtime_r

Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 fi

[PATCH v26 02/15] windows: make getopt functions have const properties

Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v26 01/15] maintainers: add for log library

"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v26 00/15] Log subsystem improvements

Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH] test/fib: clarify FIB RCU negative tests

Add additional negative tests for rte_fib_rcu_qsbr_add(). Also explicitly check returned codes. Additionally add a check into the rte_fib_rcu_qsbr_add() for passed fib argument. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 21 +++-- lib/fib/rte_fib.c | 3 +++ 2

Re: [PATCH v6] lib/hash: add siphash

On 16/10/2024 18:07, Stephen Hemminger wrote: On Wed, 16 Oct 2024 16:48:12 +0100 "Medvedkin, Vladimir" wrote: Hi Stephen, Thanks for introducing this hash function. I have just a few nits: On 01/08/2024 16:31, Stephen Hemminger wrote: The existing hash functions in DPDK are not cryptograp

[PATCH v9 3/3] dts: mac filter test suite refactored for new dts

The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. The test suite assesses the behavior of ethdev api calls as it relates to mac address filtering using TestPMD. Specific test cases have been designed

[PATCH v9 2/3] dts: add capability check for multicast filtering

The multicast address filter component of the mac filter test suite is definitively supported across all vendors. Thus, a simple capability check is added to ensure that this functionality is supported. Bugzilla ID: 1454 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_she

[PATCH v9 1/3] dts: add methods for setting mac and multicast addresses

New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v9 0/3] dts: mac filter port to new dts

v9: * Removed the vlan component of the multicast filter test as there is an ongoing bug with this functionality across many NICs. * Added a multicast address capability check since some NICs do not support this feature. Nicholas Pratte (3): dts: add methods for setting mac and multi

Re: [PATCH] fib: fix return value behavior

On Wed, 16 Oct 2024 16:59:48 +0100 "Medvedkin, Vladimir" wrote: > Hi Stephen, > > On 16/10/2024 06:29, Stephen Hemminger wrote: > > On Tue, 15 Oct 2024 17:11:43 + > > Vladimir Medvedkin wrote: > > > >> Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its > >> return val

Re: [PATCH v6] lib/hash: add siphash

On Wed, 16 Oct 2024 16:48:12 +0100 "Medvedkin, Vladimir" wrote: > Hi Stephen, > > Thanks for introducing this hash function. > > I have just a few nits: > > On 01/08/2024 16:31, Stephen Hemminger wrote: > > The existing hash functions in DPDK are not cryptographically > > secure and can be sub

Re: [PATCH v3 2/4] hash: add dynamic polynomial calculation

Hi Stephen, On 15/10/2024 23:29, Stephen Hemminger wrote: On Fri, 11 Oct 2024 18:17:00 + Vladimir Medvedkin wrote: + +uint32_t +rte_thash_get_rand_poly(uint32_t poly_degree) +{ + uint32_t ret_poly; + + if (poly_degree > 32) + return 0; + + do +

Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API

16/10/2024 18:03, Mattias Rönnblom: > On 2024-10-16 17:42, Morten Brørup wrote: > >> From: David Marchand [mailto:david.march...@redhat.com] > >> Sent: Wednesday, 16 October 2024 17.37 > >> > >> On Wed, Oct 16, 2024 at 4:14 PM Mattias Rönnblom > >> wrote: > >>> > >>> On 2024-10-16 13:38, David Mar

Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API

On 2024-10-16 17:42, Morten Brørup wrote: From: David Marchand [mailto:david.march...@redhat.com] Sent: Wednesday, 16 October 2024 17.37 On Wed, Oct 16, 2024 at 4:14 PM Mattias Rönnblom wrote: On 2024-10-16 13:38, David Marchand wrote: For a reason similar to the change on bitops header, hid

Re: [PATCH] fib: fix return value behavior

Hi Stephen, On 16/10/2024 06:29, Stephen Hemminger wrote: On Tue, 15 Oct 2024 17:11:43 + Vladimir Medvedkin wrote: Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its return value to align with the existing rte_fib API. Fixes: 96c3d06a3547 ("fib: implement RCU rule re

Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API

On 2024-10-16 17:36, David Marchand wrote: On Wed, Oct 16, 2024 at 4:14 PM Mattias Rönnblom wrote: On 2024-10-16 13:38, David Marchand wrote: For a reason similar to the change on bitops header, hide bitset implementation relying on experimental API. Fixes: 99a1197647d8 ("eal: add bitset typ

Re: [PATCH v6] lib/hash: add siphash

Hi Stephen, Thanks for introducing this hash function. I have just a few nits: On 01/08/2024 16:31, Stephen Hemminger wrote: The existing hash functions in DPDK are not cryptographically secure and can be subject to carefully crafted packets causing DoS attack. Currently in DPDK we have 3 hash

RE: [PATCH v2 2/4] bitset: fix build for GCC without experimental API

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 16 October 2024 17.37 > > On Wed, Oct 16, 2024 at 4:14 PM Mattias Rönnblom > wrote: > > > > On 2024-10-16 13:38, David Marchand wrote: > > > For a reason similar to the change on bitops header, hide bitset > > > implemen

  1   2   >