Re: [PATCH v11 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 18:30, Stephen Hemminger wrote: On Mon, 14 Oct 2024 09:43:48 +0200 Mattias Rönnblom wrote: Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom A

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 10:17, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 14 October 2024 09.44 +struct lcore_var_buffer { + char data[RTE_MAX_LCORE_VAR * RTE_MAX_LCORE]; + struct lcore_var_buffer *prev; +}; In relation to Jerin's requ

Re: [PATCH v2 1/6] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 09:56, Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Wednesday, 18 September 2024 12.12 On Thu, Sep 12, 2024 at 8:52 PM Jerin Jacob wrote: On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sen

[PATCH v5 8/9] net/zxdh: add zxdh dev infos get ops

2024-10-14 Thread Junlong Wang
Add support for zxdh infos get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c index 4f6711c9af..e0f2c1985b 10064

[PATCH v5 6/9] net/zxdh: add zxdh get device backend infos

2024-10-14 Thread Junlong Wang
Add zxdh get device backend infos, use msg chan to send msg get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_common.c | 249 + drivers/net/zxdh/zxdh_common.h | 30 drivers/net/zxdh/zxdh_ethdev.c | 35 +

[PATCH v5 4/9] net/zxdh: add msg chan and msg hwlock init

2024-10-14 Thread Junlong Wang
Add msg channel and hwlock init implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 15 +++ drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_msg.c| 161 + drivers/net/zxdh/zxdh_

[PATCH v5 5/9] net/zxdh: add msg chan enable implementation

2024-10-14 Thread Junlong Wang
Add msg chan enable implementation to support send msg to get infos. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 + drivers/net/zxdh/zxdh_ethdev.h | 12 + drivers/net/zxdh/zxdh_msg.c| 655 - drivers/net/zxdh/zxdh_msg.h| 127 ++

[PATCH v5 7/9] net/zxdh: add configure zxdh intr implementation

2024-10-14 Thread Junlong Wang
configure zxdh intr include risc,dtb. and release intr. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 302 - drivers/net/zxdh/zxdh_ethdev.h | 8 + drivers/net/zxdh/zxdh_msg.c| 187 drivers/net/zxdh/zxdh_msg.h| 11

[PATCH v5 2/9] net/zxdh: add logging implementation

2024-10-14 Thread Junlong Wang
Adds zxdh logging implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 15 +-- drivers/net/zxdh/zxdh_logs.h | 35 ++ 2 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 drivers/net/zxdh/zxdh_logs.h diff

[PATCH v5 3/9] net/zxdh: add zxdh device pci init implementation

2024-10-14 Thread Junlong Wang
Add device pci init implementation, to obtain PCI capability and read configuration, etc Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 5 +- drivers/net/zxdh/zxdh_ethdev.c | 43 + drivers/net/zxdh/zxdh_ethdev.h | 20 ++- drivers/net/zxdh/zxdh_pci.c| 290 +++

[PATCH v5 1/9] net/zxdh: add zxdh ethdev pmd driver

2024-10-14 Thread Junlong Wang
Add basic zxdh ethdev init and register PCI probe functions Update doc files Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 9 +++ doc/guides/nics/index.rst | 1 + doc/guides/nics/zxdh.rst | 30 ++ drivers/net/meson.build | 1 + drivers/

[PATCH v5 0/9] net/zxdh: introduce net zxdh driver

2024-10-14 Thread Junlong Wang
V5: - split driver into multiple patches,part of the zxdh driver, later provide dev start/stop,queue_setup,mac,vlan,rss ,etc. - fix errors reported by scripts. - move the product link in zxdh.rst. - fix meson check use RTE_ARCH_X86_64/RTE_ARCH_ARM64. - modify other comments according

[PATCH v7 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K Reviewed-by: Robin Jarry --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lo

[PATCH v7 1/3] graph: add support for node specific xstats

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add ability for Nodes to advertise xstat counters during registration and increment them in fastpath. Add support for retrieving/printing stats for node specific xstats using rte_graph_cluster_stats_get(). Add `rte_node_xstat_increment` API to increment node specific xstat c

[PATCH v7 0/3] Introduce node-specific xstats in graph library

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Introduce the ability for nodes to advertise xstats counters during registration and increment them during the node process function in the graph library. This enhancement allows for better stats tracking and debugging capabilities within the graph framework. The number of

Re: [PATCH v6 1/3] graph: add support for node specific xstats

2024-10-14 Thread Jerin Jacob
On Mon, Oct 14, 2024 at 9:41 PM wrote: > > From: Pavan Nikhilesh > > Add ability for Nodes to advertise xstat counters > during registration and increment them in fastpath. > Add support for retrieving/printing stats for node > specific xstats using rte_graph_cluster_stats_get(). > Add `rte_node_

Re: [PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Stephen Hemminger
On Tue, 15 Oct 2024 02:49:53 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

Re: [PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 22:15:45 + Abdullah Ömer Yamaç wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style a

[PATCH v1 18/18] doc/guides/nics: add documents for r8169 pmd

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- MAINTAINERS| 2 ++ doc/guides/nics/features/r8169.ini | 32 ++ doc/guides/nics/r8169.rst | 17 3 files changed, 51 insertions(+) create mode 100644 doc/guides/nics/features/r8169.ini cr

[PATCH v1 17/18] net/r8169: add driver_start and driver_stop

2024-10-14 Thread Howard Wang
rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_base.h| 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v1 16/18] net/r8169: add support for getting fw version

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 70c3661691..dd2c7dda24 100644 --- a/drivers/net/r8169/r8169_ethdev.c +++ b/drivers/ne

[PATCH v1 15/18] net/r8169: impelment MTU configuration

2024-10-14 Thread Howard Wang
Add support for updating MTU value. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 3e6bc570d6..70c3661691 100644 --- a/dri

[PATCH v1 14/18] net/r8169: implement promisc and allmulti modes

2024-10-14 Thread Howard Wang
Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 68 1 file changed, 68 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index cf9ea4dca4

[PATCH v1 12/18] net/r8169: implement Tx path

2024-10-14 Thread Howard Wang
Add implementation for TX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 7 + drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 687 ++- 4 files changed, 695 insertions

[PATCH v1 13/18] net/r8169: implement device statistics

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 16 +++ drivers/net/r8169/r8169_ethdev.c | 49 ++- drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 drivers/net/r8169/r8169_hw.h | 6 +++ 5 f

[PATCH v1 11/18] net/r8169: implement Rx path

2024-10-14 Thread Howard Wang
Add implementation for RX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 27 ++ drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers/net/r8169/r8169_rxtx.c | 787 ++- 4 files changed, 905 inserti

[PATCH v1 10/18] net/r8169: add link status and interrupt management

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 5 +- drivers/net/r8169/r8169_ethdev.c | 279 ++- drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169/r8169_hw.h | 3 + drivers/net/r8169/r8169_

[PATCH v1 09/18] net/r8169: add support for hw initialization

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 43 +++ drivers/net/r8169/r8169_dash.c | 89 + drivers/net/r8169/r8169_dash.h | 35 ++ drivers/net/r8169/r8169_ethdev.c | 47 ++- drivers/net/r8169/r8169_ethdev.h | 30 +- driv

[PATCH v1 08/18] net/r8169: add support for phy configuration

2024-10-14 Thread Howard Wang
This patch contains phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 10 + drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 445 +++ drivers/net/r8169/r8169_phy.h| 100 +++ 4 file

[PATCH v1 06/18] net/r8169: add phy registers access routines

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_phy.c| 219 +++ drivers/net/r8169/r8169_phy.h| 18 +++ 3 files changed, 238 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.h b/drivers/net/r8169/r8169_

[PATCH v1 05/18] net/r8169: add support for hw config

2024-10-14 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 2 + drivers/net/r8169/r8169_ethdev.h | 15 +- drivers/net/r8169/r8169_hw.

[PATCH v1 04/18] net/r8169: implement core logic for Tx/Rx

2024-10-14 Thread Howard Wang
Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 17 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_rxtx.c | 57 ++

[PATCH v1 03/18] net/r8169: add hardware registers access routines

2024-10-14 Thread Howard Wang
Add implementation for hardware registers access routines. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 389 +++ drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_hw.c | 94 d

[PATCH v1 02/18] net/r8169: add logging structure

2024-10-14 Thread Howard Wang
Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 40 drivers/net/r8169/r8169_logs.h | 53 2 files changed, 93 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h

[PATCH v1 01/18] net/r8169: add PMD driver skeleton

2024-10-14 Thread Howard Wang
Meson build infrastructure, r8169_ethdev minimal skeleton, header with Realtek NIC device and vendor IDs. Signed-off-by: Howard Wang --- MAINTAINERS | 7 ++ drivers/net/meson.build | 1 + drivers/net/r8169/meson.build| 7 ++ drivers/net/r8169/r8169_base.h

[PATCH v1 00/18] net/r8169: add r8169 pmd to dpdk

2024-10-14 Thread Howard Wang
R8169 pmd supports Realtek 2.5G and 5G ethernet nics. Howard Wang (18): net/r8169: add PMD driver skeleton net/r8169: add logging structure net/r8169: add hardware registers access routines net/r8169: implement core logic for Tx/Rx net/r8169: add support for hw config net/r8169: add ph

Re: [v6 08/15] dma/dpaa: refactor driver

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 15:06:32 +0530 Gagandeep Singh wrote: > @@ -551,7 +485,7 @@ fsl_qdma_reg_init(struct fsl_qdma_engine *fsl_qdma) > > /* Initialize the status queue mode. */ > reg = FSL_QDMA_BSQMR_EN; > - val = ilog2(fsl_qdma->status[j]->n_cq) - 6; > +

[PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

[PATCH v4 5/5] maintainers: update for drivers/power

2024-10-14 Thread Sivaprasad Tummala
Update maintainers for drivers/power/*. Signed-off-by: Sivaprasad Tummala --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6814991735..9f14e8f8d6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1744,6 +1744,7 @@ M: Anatoly Burakov M: David Hunt

[PATCH v4 4/5] power/amd_uncore: uncore support for AMD EPYC processors

2024-10-14 Thread Sivaprasad Tummala
This patch introduces driver support for power management of uncore components in AMD EPYC processors. v2: - fixed typo in comments section. - added fabric frequency get support for legacy platforms. Signed-off-by: Sivaprasad Tummala --- drivers/power/amd_uncore/amd_uncore.c | 329 +++

[PATCH v4 3/5] test/power: removed function pointer validations

2024-10-14 Thread Sivaprasad Tummala
After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Siv

[PATCH v4 2/5] power: refactor uncore power management library

2024-10-14 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[DPDK/cryptodev Bug 1565] Lots of warnings from Clang Asan build in Openssl PMD

2024-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1565 Bug ID: 1565 Summary: Lots of warnings from Clang Asan build in Openssl PMD Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: criti

[PATCH v4 1/5] power: refactor core power management library

2024-10-14 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

Re: [v3 16/43] bus/fslmc: dynamic IOVA mode configuration

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:59 +0530 vanshika.shu...@nxp.com wrote: > iff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h > index 1695b6c078..408b35680d 100644 > --- a/drivers/bus/fslmc/fslmc_vfio.h > +++ b/drivers/bus/fslmc/fslmc_vfio.h > @@ -11,6 +11,10 @@ > #include > #

Re: [v3 13/43] bus/fslmc: get MC VFIO group FD directly

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:56 +0530 vanshika.shu...@nxp.com wrote: > +static int > +fslmc_vfio_open_group_fd(int iommu_group_num) > +{ > + int vfio_group_fd; > + char filename[PATH_MAX]; > + struct rte_mp_msg mp_req, *mp_rep; > + struct rte_mp_reply mp_reply = {0}; > + struct ti

Re: [v3 43/43] net/dpaa2: dpdmux single flow/multiple rules support

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:31:26 +0530 vanshika.shu...@nxp.com wrote: > From: Jun Yang > > Support multiple extractions as well as hardware descriptions > instead of hard code. > > Signed-off-by: Jun Yang > --- > drivers/net/dpaa2/dpaa2_ethdev.h | 1 + > drivers/net/dpaa2/dpaa2_flow.c

Re: [v3 14/43] bus/fslmc: enhance MC VFIO multiprocess support

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:57 +0530 vanshika.shu...@nxp.com wrote: > +#ifndef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA > + if (vaddr != iovaddr) { > + DPAA2_BUS_WARN("vaddr(0x%lx) != iovaddr(0x%lx)", > + vaddr, iovaddr); > + } > #endif Checkpatch complain shere. Warn

[PATCH v2] net/mlx5: fix potential memory leak in meter

2024-10-14 Thread Shun Hao
When meter not enabled, avoid allocate memory for meter profile table, which will not be freed in close process when meter not enabled Fixes: a295c69a8b24 ("net/mlx5: optimize meter profile lookup") Cc: sta...@dpdk.org Signed-off-by: Shun Hao Acked-by: Bing Zhao --- drivers/net/mlx5/linux/mlx5

[PATCH v1 2/2] baseband/acc: saturate input to 6 bits for VRB decoder

2024-10-14 Thread Nicolas Chautru
Making the decoder more robust by forcing a default 6 bits LLR saturation to LDPC Decoder input. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c i

[PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ device

2024-10-14 Thread Nicolas Chautru
Supporting recent change in the device to extend FFT capability processing in latest stepping. Also including cosmetic change to VRB2 register definition. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 2 +- drivers/baseband/acc/rte_vrb_pmd.c | 30

[PATCH v1 0/2] baseband/acc: vrb2 FFT support

2024-10-14 Thread Nicolas Chautru
Hi, Additional and final series for the VRB2 PMD. Now supporting latest FFT processing (available on final stepping of the device ) and generic improvement to decoder configuration. Thanks Nic Nicolas Chautru (2): baseband/acc: FFT support in VRB2 PRQ device baseband/acc: saturate input to 6

[PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

[PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

[PATCH v3 2/2] dts: port over unified packet suite

2024-10-14 Thread Dean Marx
Port over unified packet testing suite from old DTS. This suite tests the ability of the PMD to recognize valid or invalid packet flags. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_uni_pkt.py | 229

[PATCH v3 1/2] dts: add VXLAN port method to testpmd shell

2024-10-14 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 21 +++ 1 file changed, 21 insertions(+) diff --git a/d

[PATCH v3 0/2] dts: port over unified packet type suite

2024-10-14 Thread Dean Marx
Port over unified packet type flag testing suite from old DTS. According to DPDK documentation, each Poll Mode Driver should reserve 32 bits of packet headers for unified packet type flags. These flags serve as an identifier for user applications, and are divided into subcategories: L2, L3, L4, tu

Re: [PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 21:32:37 +0200 Robin Jarry wrote: > While invoking telemetry commands (which may happen at any time, out of > control of the application), an application thread may concurrently > add/remove ports. The telemetry callbacks may then access partially > initialized/uninitialised e

Re: [PATCH v5 4/5] test/graph_feature_arc: add functional tests

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 20:03:57 +0530 Nitin Saxena wrote: > Added functional unit test case for verifying feature arc control plane > and fast path APIs > > How to run: > $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test > > Signed-off-by: Nitin Saxena With current upstream kernel checkpatch

Re: [PATCH v4 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue

2024-10-14 Thread Stephen Hemminger
On Fri, 4 Oct 2024 23:22:52 +0530 Sriharsha Basavapatna wrote: > From: Shahaji Bhosle > > FW tries to update the HWRM request data in the > delete case to update the mode bit and also > update invalid profile id. This update only > happens when the data is send over DMA. HWRM > requests are re

Re: [PATCH v6 2/3] doc: update graph layout and node anatomy images

2024-10-14 Thread Robin Jarry
, Oct 14, 2024 at 18:10: From: Pavan Nikhilesh update the graph memory layout and node anatomy images to reflect the xstats memory region. Signed-off-by: Pavan Nikhilesh --- Reviewed-by: Robin Jarry

Re: [PATCH v6 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread Robin Jarry
, Oct 14, 2024 at 18:10: From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K --- Reviewed-by: Robin Jarry

[PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-14 Thread Robin Jarry
While invoking telemetry commands (which may happen at any time, out of control of the application), an application thread may concurrently add/remove ports. The telemetry callbacks may then access partially initialized/uninitialised ethdev data. Reuse the ethdev lock that protects port allocation

[PATCH dpdk v3 1/2] telemetry: add api to register command with private argument

2024-10-14 Thread Robin Jarry
Add a new rte_telemetry_register_cmd_arg public function to register a telemetry endpoint with a callback that takes an additional private argument. This will be used in the next commit to protect ethdev endpoints with a lock. Update perform_command() to take a struct callback object copied from

[PATCH dpdk v3 0/2] Fix race in ethdev telemetry

2024-10-14 Thread Robin Jarry
Following a discussion we had during the summit, here is one series to fix a race between an application thread and the telemetry thread handling requests on ethdev ports. The problem may be generic to other device classes providing telemetry callbacks, but for now, this series goes with a simple

Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess

2024-10-14 Thread David Marchand
On Tue, Sep 17, 2024 at 10:20 AM Maxime Coquelin wrote: > > At the moment, if VFIO is not available at DPDK init, it won't be > > available unless a subsequent rte_vfio_enable() is done. > > > > Yet, even if rte_vfio_enable() is called again in primary and secondary > > processes, a secondary proc

Re: [PATCH v2] eal/x86: cache queried CPU flags

2024-10-14 Thread David Marchand
On Fri, Oct 11, 2024 at 3:37 PM Konstantin Ananyev wrote: > > Rather than re-querying the HW each time a CPU flag is requested, we can > > just save the return value in the flags array. This should speed up > > repeated querying of CPU flags, and provides a workaround for a reported > > issue wher

[PATCH v4 1/2] dts: add csum HW offload to testpmd shell

2024-10-14 Thread Dean Marx
Add csum_set_hw method to testpmd shell class. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58 +++ 1 file changed, 58 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index

[PATCH v4 2/2] dts: checksum offload test suite

2024-10-14 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_checksum_offload.py| 266 + 2 files changed, 268 insertions(+), 1 deletion(-) create mo

[PATCH v4 0/2] dts: port over checksum offload suite

2024-10-14 Thread Dean Marx
Port over checksum hardware offload testing suite from old DTS. The suite verifies the ability of the PMD to recognize whether an incoming packet has valid or invalid L4/IP checksum values. - v1: * In the original test plan, there were two Tx checksum test cases. I removed them due to the

[PATCH v01] net/af_packet: support link status update

2024-10-14 Thread Gur Stavi
For net_af_packet PMD, eth_link_update was an empty function. Application may be interested in link up/down status. This patch adds implementation that updates dev_link->link_status based on socket IFF_RUNNING flag. Signed-off-by: Gur Stavi --- drivers/net/af_packet/rte_eth_af_packet.c | 16

[PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-14 Thread Gur Stavi
When creating AF_PACKET socket with specified protocol it is immediately implicitly bound to any existing interface and becomes RUNNING. Calling bind on such socket is affectively unbind from "any interface", then bind to the specific interface. When creating socket with 0 as protocol, it is creat

Re: [PATCH v2 00/10] net/ice: base code update for RC2

2024-10-14 Thread Medvedkin, Vladimir
Hi Bruce, Series-acked-by: Vladimir Medvedkin On 14/10/2024 12:02, Bruce Richardson wrote: A number of small fixes and other changes to enable Tx scheduler enhancements to our DPDK driver have been added to the base code. Upstream these changes for 24.11 RC2. Most have previously been submitte

Re: [PATCH v3 1/2] fib: implement RCU rule reclamation

2024-10-14 Thread David Marchand
On Thu, Oct 10, 2024 at 1:27 PM Vladimir Medvedkin wrote: > > Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the > readers might be using the tbl8 group entries. The freed tbl8 group can > be reallocated quickly. As a result, lookup may be performed incorrectly. > > To addre

[PATCH v3] doc: reword sample app guides

2024-10-14 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad Acked-by: Chengwen Feng --- doc/guides/sample_app_ug/

Re: [PATCH] fib: fix vector lookup

2024-10-14 Thread David Marchand
On Fri, Sep 6, 2024 at 7:04 PM Vladimir Medvedkin wrote: > > Vector lookup uses gather instructions which loads data in 4byte chunks. > This could lead to out of bounds access at the end of the tbl24 in case > of 1 or 2 byte entries if e.g. lookup is attempted for 255.255.255.255 > in IPv4 case. >

Re: [PATCH v5] fib: network byte order IPv4 lookup

2024-10-14 Thread David Marchand
On Mon, Oct 14, 2024 at 5:22 PM Stephen Hemminger wrote: > On Mon, 14 Oct 2024 13:37:07 + > Vladimir Medvedkin wrote: > > > Previously when running rte_fib_lookup IPv4 addresses must have been in > > host byte order. > > > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed

Re: [PATCH v3 1/2] fib: implement RCU rule reclamation

2024-10-14 Thread David Marchand
On Thu, Oct 10, 2024 at 1:27 PM Vladimir Medvedkin wrote: > diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c > index 4f9fba5a4f..730f50c1ba 100644 > --- a/lib/fib/rte_fib.c > +++ b/lib/fib/rte_fib.c > @@ -338,3 +338,14 @@ rte_fib_select_lookup(struct rte_fib *fib, > return -EINVA

Re: [PATCH v3] examples/flow_filtering: introduce use cases snippets

2024-10-14 Thread Stephen Hemminger
On Mon, 30 Sep 2024 22:53:21 +0300 Shani Peretz wrote: > These code snippets demonstrate rule creation using > template and non-template APIs. > They include functions that enable developers to create rules. > The purpose of providing these snippets is to allow developers > to reuse them, thereby

Re: [PATCH] net/bonding: add user callback for bond xmit policy

2024-10-14 Thread Vignesh Purushotham Srinivas
On Thu, 15 Aug 2024 14:10:14 +0200 wrote: > > diff --git a/drivers/net/bonding/rte_eth_bond.h > > b/drivers/net/bonding/rte_eth_bond.h > > index f10165f2c6..66bc41097a 100644 > > --- a/drivers/net/bonding/rte_eth_bond.h > > +++ b/drivers/net/bonding/rte_eth_bond.h > > @@ -91,6 +91,11 @@ extern "

Re: [RFC PATCH] build: automatically report minimum meson version

2024-10-14 Thread Patrick Robb
It seems like a good addition that meson.build and /.ci/linux-setup.sh are automatically in sync now. That's one less thing that someone has to "just remember" when increasing the meson minimum version. I will flag on the other thread (increasing the meson version) when UNH's scripts are updated t

Re: [PATCH v11 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 09:43:48 +0200 Mattias Rönnblom wrote: > Keep per-lcore power intrinsics state in a lcore variable to reduce > cache working set size and avoid any CPU next-line-prefetching causing > false sharing. > > Signed-off-by: Mattias Rönnblom > Acked-by: Morten Brørup > Acked-by: K

Re: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-10-14 Thread Vignesh Purushotham Srinivas
-Original Message- From: Konstantin Ananyev To: vignesh.purushotham.srini...@ericsson.com , konstantin.v.anan...@yandex.ru Cc: dev@dpdk.org Subject: RE: [PATCH] ip_frag: support IPv6 reassembly with extensions Date: Tue, 17 Sep 2024 18:07:25 + > > +/* > > + * Function to crawl throu

[PATCH v6 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib

[PATCH v6 1/3] graph: add support for node specific xstats

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add ability for Nodes to advertise xstat counters during registration and increment them in fastpath. Add support for retrieving/printing stats for node specific xstats using rte_graph_cluster_stats_get(). Add `rte_node_xstat_increment` API to increment node specific xstat c

[PATCH v6 0/3] Introduce node-specific xstats in graph library

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Introduce the ability for nodes to advertise xstats counters during registration and increment them during the node process function in the graph library. This enhancement allows for better stats tracking and debugging capabilities within the graph framework. The number of

Re: [PATCH v3] hash: separate param checks in hash create func

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 10:19:16 + Niall Meade wrote: > Separated name, entries and key_len parameter checks in > rte_hash_create(). Also made the error messages more > informative/verbose to help with debugging. Also added myself to the > mailing list. > > Signed-off-by: Niall Meade Acked-b

Re: [PATCH v10 0/2] power: introduce PM QoS interface

2024-10-14 Thread Stephen Hemminger
On Thu, 12 Sep 2024 10:38:10 +0800 Huisong Li wrote: > The deeper the idle state, the lower the power consumption, but the longer > the resume time. Some service are delay sensitive and very except the low > resume time, like interrupt packet receiving mode. > > And the "/sys/devices/system/cpu/

Re: [PATCH v5] fib: network byte order IPv4 lookup

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 13:37:07 + Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order

Re: [PATCH v9 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 08:51:09 +0200 Mattias Rönnblom wrote: > On 2024-10-11 10:04, Mattias Rönnblom wrote: > > On 2024-10-10 23:24, Thomas Monjalon wrote: > > > > >>> + * > >>> + * An lcore variable is not tied to the owning thread's lifetime. It's > >>> + * available for use by any thread im

Re: [PATCH v2 0/4] Add bitset type

2024-10-14 Thread David Marchand
On Thu, Oct 10, 2024 at 10:30 AM David Marchand wrote: > > v1 did not go through the CI. v2 is still pending in UNH lab. GHA and other envs look fine. Aside from a random failure like on the bitops side recently, we should be good... Series applied. -- David Marchand

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

2024-10-14 Thread David Marchand
On Mon, Oct 14, 2024 at 9:19 AM Jerin Jacob wrote: > On Sun, Oct 13, 2024 at 12:27 PM Mattias Rönnblom > wrote: > > > > On 2024-10-11 16:42, David Marchand wrote: > > > On Wed, Jul 5, 2023 at 1:18 PM Mattias Rönnblom > > > wrote: > > >> > > >> Announce the removal of the single-event enqueue an

Re: [PATCH v2] doc: announce single-event enqueue/dequeue ABI change

2024-10-14 Thread Thomas Monjalon
14/10/2024 09:18, Jerin Jacob: > On Sun, Oct 13, 2024 at 12:27 PM Mattias Rönnblom > wrote: > > > > On 2024-10-11 16:42, David Marchand wrote: > > > On Wed, Jul 5, 2023 at 1:18 PM Mattias Rönnblom > > > wrote: > > >> > > >> Announce the removal of the single-event enqueue and dequeue > > >> oper

[PATCH v5 5/5] docs: add programming guide for feature arc

2024-10-14 Thread Nitin Saxena
Updated graph library guide with feature arc Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 288 +++ doc/guides/prog_guide/img/feature_arc-1.svg | 277 +++ doc/guides/prog_guide/img/feature_arc-2.svg | 511 doc/guides/prog_guide

[PATCH v5 4/5] test/graph_feature_arc: add functional tests

2024-10-14 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_arc.c | 1410 +

[PATCH v5 3/5] graph: add IPv4 output feature arc

2024-10-14 Thread Nitin Saxena
add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node/node

[PATCH v5 2/5] graph: add feature arc option in graph create

2024-10-14 Thread Nitin Saxena
Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24

[PATCH v5 1/5] graph: add feature arc support

2024-10-14 Thread Nitin Saxena
add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236 ++

[PATCH v5 0/5] add feature arc in rte_graph

2024-10-14 Thread Nitin Saxena
Feature arc represents an ordered list of features/protocols at a given networking layer. It is a high level abstraction to connect various rte_graph nodes, as feature nodes, and allow packets steering across these nodes in a generic manner. Features (or feature nodes) are nodes which handles part

  1   2   3   >