[PATCH v6 2/3] net/ice: add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 16 drivers/net/ice/ice_ethdev.c | 176 +++

[PATCH v6 3/3] examples/ptpclient: add frequency adjustment

2024-10-10 Thread Mingjin Ye
This patch adds PI servo controller to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI controller is: dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 Signed-off-by: Simei Su Signed-off-by: Wenjun Wu Signed-off-by: Mingjin Y

[PATCH v6 1/3] ethdev: add frequency adjustment API

2024-10-10 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- v2: rte_eth_timesync_adjust_freq marked as experimental --- v3: Add more description for API. --- V4: Fix git commit conflict. --- doc/guides/nics/features.rst | 4 ++- do

[PATCH v6 0/3] add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment --- v2: rte_eth_timesync_adjust_freq marked as experimental. --- v3: Add more description for API. --- v4: Documentation for adding a ptpclient. ---

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-10 Thread David Marchand
On Fri, Oct 11, 2024 at 8:38 AM Konrad Sztyber wrote: > > On 10/9/24 17:12, Stephen Hemminger wrote: > > That is what tap, and xdp are doing. > > Thanks for the info. I'll take a look and will send a next rev doing > something similar in uio. My two cents. net/tap uses the rte_mp_* infrastructure

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-10 Thread Konrad Sztyber
On 10/9/24 17:12, Stephen Hemminger wrote: That is what tap, and xdp are doing. Thanks for the info. I'll take a look and will send a next rev doing something similar in uio. Konrad

RE: [EXTERNAL] Re: [PATCH v4 1/1] dmadev: support priority configuration

2024-10-10 Thread Vamsi Krishna Attunuru
Thank you, Feng, for reviewing the patch. I agree with the comments that are suggested, will rework, and send next version. Regards Vamsi >-Original Message- >From: fengchengwen >Sent: Tuesday, October 8, 2024 8:07 AM >To: Vamsi Krishna Attunuru ; >tho...@monjalon.net; bruce.richard...@

Re: [PATCH 1/7] app/test: introduce UT suite framework for kvargs

2024-10-10 Thread fengchengwen
On 2024/10/11 10:08, Stephen Hemminger wrote: > On Fri, 3 Nov 2023 09:53:19 + > Chengwen Feng wrote: > >> Introduce unit test suite framework for test_kvargs.c. >> >> Signed-off-by: Chengwen Feng >> --- >> app/test/test_kvargs.c | 20 +--- >> 1 file changed, 13 insertions(+)

[PATCH v2 2/7] app/test: extract basic token count testcase for kvargs

2024-10-10 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the basic token count tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 120 - 1 file changed, 45 insertions(+), 75

[PATCH v2 3/7] app/test: extract without keys testcase for kvargs

2024-10-10 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the without keys tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 115 ++--- 1 file changed, 63 insertions(+), 52 delet

[PATCH v2 6/7] app/test: extract parse empty elements testcase for kvargs

2024-10-10 Thread Chengwen Feng
Extract parse empty elements test as one stand-alone testcase. And also fix the kvlist was not released when the branch fails. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 68 ++ 1 file changed, 29 insertions(+), 3

[PATCH v2 7/7] maintainers: update for kvargs library

2024-10-10 Thread Chengwen Feng
Add myself for voluntary maintenance of the kvargs library. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d171e3d45..7e320335d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1713,6 +

[PATCH v2 4/7] app/test: extract with keys testcase for kvargs

2024-10-10 Thread Chengwen Feng
The test_valid_kvargs() function is too long to understand, extract the with keys tests as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 59 +- 1 file changed, 35 insertions(+), 24 deletion

[PATCH v2 1/7] app/test: introduce UT suite framework for kvargs

2024-10-10 Thread Chengwen Feng
Introduce unit test suite framework for test_kvargs.c. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c index 7a60cac4c1..1

[PATCH v2 5/7] app/test: extract parse list value testcase for kvargs

2024-10-10 Thread Chengwen Feng
Extract parse list value test as one stand-alone testcase. Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- app/test/test_kvargs.c | 54 +- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/app/test/test_kvargs.c b/app/test/test_

[PATCH v2 0/7] refactor kvargs test

2024-10-10 Thread Chengwen Feng
When developing patchset [1], I found the kvargs test is hard to understand when tried to add some testcase. So refactor kvargs by: 1. introduce UT suite framework. 2. extract big test_valid_kvargs() to five part. And add myself for voluntary maintenance of the kvargs library. Note: to ensure pa

[PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-10-10 Thread Chaoyong He
From: Long Wu The testpmd application can not modify the value of dedicated hardware Rx/Tx queue size, and hardcoded them as (128/512). This will cause the bonding port start fail if some NIC requires more Rx/Tx descriptors than the hardcoded number. Therefore, add a command into testpmd applica

[PATCH v2 1/2] net/bonding: standard the log message

2024-10-10 Thread Chaoyong He
From: Long Wu According to the check rules in the patch check script, drivers and libraries must use the logging framework. So standard the log message of bonding driver by using the logging framework. Signed-off-by: Long Wu Reviewed-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/b

[PATCH v2 0/2] add function to set dedicated queue size

2024-10-10 Thread Chaoyong He
This patch series mainly add a function to bonding PMD to set dedicated queue size, also add a command to testpmd application to invoke this function. At the same time, standard the log message of bonding PMD. --- v2: * Adjust some logs following the request of reviewer. --- Long Wu (2): net/b

[PATCH v5 3/3] examples/ptpclient: add frequency adjustment

2024-10-10 Thread Mingjin Ye
This patch adds PI servo controller to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI controller is: dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -c 1 Signed-off-by: Simei Su Signed-off-by: Wenjun Wu Signed-off-by: Mingjin Y

[PATCH v5 2/3] net/ice: add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- v2: Modify documents and delete old variables. --- doc/guides/nics/ice.rst | 16 +

[PATCH v5 1/3] ethdev: add frequency adjustment API

2024-10-10 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- v2: rte_eth_timesync_adjust_freq marked as experimental --- v3: Add more description for API. --- doc/guides/nics/features.rst | 4 ++- doc/guides/rel_notes/release_24_11.

[PATCH v5 0/3] add frequency adjustment support for PTP

2024-10-10 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment --- v2: rte_eth_timesync_adjust_freq marked as experimental. --- v3: Add more description for API. --- v4: Documentation for adding a ptpclient. ---

RE: [PATCH 1/2] net/bonding: standard the log message

2024-10-10 Thread Chaoyong He
> On Mon, 24 Jun 2024 10:03:54 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > According to the check rules in the patch check script, drivers and > > libraries must use the logging framework. > > > > So standard the log message of bonding driver by using the logging > > framework. > > >

RE: [PATCH 2/2] net/bonding: add command to set dedicated queue size

2024-10-10 Thread Chaoyong He
> On Mon, 24 Jun 2024 10:03:55 +0800 > Chaoyong He wrote: > > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > > index 06c21ebe6d..c19645aa4f 100644 > > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > > +++ b/drivers/net/bonding/rte_eth_bo

RE: [PATCH 10/10] net/nfp: fix memory leak in VF initialization logic

2024-10-10 Thread Chaoyong He
> On Thu, 10 Oct 2024 17:17:16 +0800 > Chaoyong He wrote: > > > Fix one memory leak problem in the logic of VF initialization. > > > > Fixes: d81e2b514dc9 ("net/nfp: move device info into process private > > data") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long

RE: [PATCH 04/10] net/nfp: improve the logic readability

2024-10-10 Thread Chaoyong He
> On Thu, 10 Oct 2024 17:17:10 +0800 > Chaoyong He wrote: > > > + > > +port_cleanup: > > + for (uint32_t j = 0; j < i; j++) { > > + struct rte_eth_dev *eth_dev; > > + > > + nfp_port_name_generate(port_name, sizeof(port_name), j, > pf_dev); > > + eth_dev = rte_eth_d

RE: [PATCH 02/10] net/nfp: fix malloc name problem in secondary process

2024-10-10 Thread Chaoyong He
> On Thu, 10 Oct 2024 17:17:08 +0800 > Chaoyong He wrote: > > > The original logic keeps using the same name parameter when malloc > > memory in secondary process, which may cause error when using multiple > > PF cards. > > > > Fixes: 3b00109d2b65 ("net/nfp: add PF ID used to format symbols") > >

RE: [PATCH 2/2] net/nfp: enhance the flower service framework

2024-10-10 Thread Chaoyong He
> On Thu, 10 Oct 2024 15:45:57 +0800 > Chaoyong He wrote: > > > +static void > > +nfp_flower_service_alarm_func(void *arg) { > > + int ret; > > + uint16_t slot; > > + struct nfp_net_hw_priv *hw_priv; > > + struct nfp_flower_service *service_handle; > > + > > + service_handle = arg; > >

Re: [PATCH 1/7] app/test: introduce UT suite framework for kvargs

2024-10-10 Thread Stephen Hemminger
On Fri, 3 Nov 2023 09:53:19 + Chengwen Feng wrote: > Introduce unit test suite framework for test_kvargs.c. > > Signed-off-by: Chengwen Feng > --- > app/test/test_kvargs.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/app/test/test_kvargs.c

[PATCH v9 12/12] crypto/zsda: add zsda crypto PMD

2024-10-10 Thread Hanxiao Li
The patch provides a series of interfaces for managing and controlling the configuration, start, stop, resource management, etc. of crypto devices. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_sym_capabilities.h | 112 + drivers

[PATCH v9 09/12] compress/zsda: add zsda compress PMD

2024-10-10 Thread Hanxiao Li
The patch provides a series of interfaces for managing and controlling the configuration, start, stop, resource management, etc. of compression devices. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/compress/zsda/zsda_comp_pmd.c | 464 +

[PATCH v9 06/12] common/zsda: configure zsda queue enqueue functions

2024-10-10 Thread Hanxiao Li
Add support for zsdadev queue enqueue. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 105 ++ drivers/common/zsda/zsda_qp.h | 2 + 2 files changed, 107 insertions(+) diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c index

[PATCH v9 08/12] compress/zsda: add zsda compress driver

2024-10-10 Thread Hanxiao Li
The patchset adds support for wqe configuration of compress and decompress, preliminary verification of results and preparation of checksums. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 12 +- drivers/compress/zsda/zsda_comp.c | 392 ++ drivers/

[PATCH v9 05/12] common/zsda: configure zsda queue base functions

2024-10-10 Thread Hanxiao Li
Add support for zsdadev queue interfaces, incluing queue start, stop, create, remove, etc. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_qp.c | 715 drivers/common/zsda/zsda_qp.h | 146 +++ 3 files changed

[PATCH v9 04/12] common/zsda: configure zsda device

2024-10-10 Thread Hanxiao Li
The patch provides a series of interfaces for driver probe remove,etc. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 1 + drivers/common/zsda/zsda_device.c | 263 ++ drivers/common/zsda/zsda_device.h | 112 + 3 files changed, 376 inse

[PATCH v9 11/12] crypto/zsda: add zsda crypto driver

2024-10-10 Thread Hanxiao Li
The patchset adds support for wqe configuration of encrypto and decrypto, preliminary verification of results and preparation of checksums. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 2 +- drivers/crypto/zsda/zsda_sym.c | 273 drivers/cryp

[PATCH v9 10/12] crypto/zsda: add crypto sessions configuration

2024-10-10 Thread Hanxiao Li
add session support for zsda cryptodev. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build| 15 +- drivers/crypto/zsda/zsda_sym_session.c | 512 + drivers/crypto/zsda/zsda_sym_session.h | 83 3 files changed, 609 insertions(+), 1 deletion(-) cre

[PATCH v9 07/12] common/zsda: configure zsda queue dequeue functions

2024-10-10 Thread Hanxiao Li
Add support for zsdadev queue dequeue. Signed-off-by: Hanxiao Li --- drivers/common/zsda/zsda_qp.c | 38 +++ drivers/common/zsda/zsda_qp.h | 1 + 2 files changed, 39 insertions(+) diff --git a/drivers/common/zsda/zsda_qp.c b/drivers/common/zsda/zsda_qp.c index 8

[PATCH v9 03/12] common/zsda: add some common functions

2024-10-10 Thread Hanxiao Li
Introduce common functions and logging macros. Signed-off-by: Hanxiao Li --- drivers/common/zsda/meson.build | 14 ++ drivers/common/zsda/zsda_common.c | 239 + drivers/common/zsda/zsda_common.h | 334 ++ drivers/common/zsda/zsda_logs.c | 21

[PATCH v9 02/12] config: add zsda device number

2024-10-10 Thread Hanxiao Li
Add the number of zsda devices. Signed-off-by: Hanxiao Li --- config/rte_config.h | 4 1 file changed, 4 insertions(+) diff --git a/config/rte_config.h b/config/rte_config.h index dd7bb0d35b..e1e85b3291 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -117,6 +117,10 @@ #defin

[PATCH v9 01/12] zsda: add zsdadev driver documents

2024-10-10 Thread Hanxiao Li
Introduce ZTE Storage Data Accelerator(ZSDA) drivers which can help accelerate storage data process. The official product documenttation web page is: https://enterprise.zte.com.cn/products.html?id=101 It is recommended to update MAINTAINERS in the first patch according to the new PMD guidelines h

[PATCH v9 00/12] drivers/zsda: introduce zsda drivers

2024-10-10 Thread Hanxiao Li
v9: - add a new feature in default.ini. - Re-split the patch according to the new PMD guidelines https://patches.dpdk.org/project/dpdk/patch/20241006184 254.53499-1-nandinipersad...@gmail.com/ - Split SM4-XTS tests into a new series to releases. - Separate out datapath(enqueue/dequeue) as a separa

[PATCH] doc: correct definition of Stats per queue feature

2024-10-10 Thread Stephen Hemminger
Change the documentation to match current usage of this feature in the NIC table. Moved this sub heading to be after basic stats because the queue stats reported now are in the same structure. Although the "Stats per Queue" feature was originally intended to be related to stats mapping, the overwh

[PATCH v1 2/2] app/test: add SM4-XTS test cases

2024-10-10 Thread Hanxiao Li
add support for SM4-XTS test. Signed-off-by: Hanxiao Li --- app/test/test_cryptodev_blockcipher.c | 3 +- app/test/test_cryptodev_sm4_test_vectors.h | 58 ++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test

[PATCH v1 0/2] cryptodev: add SM4-XTS algo and test cases

2024-10-10 Thread Hanxiao Li
v1: - add SM4-XTS algo and test cases. Signed-off-by: Hanxiao Li --- Hanxiao Li (2): cryptodev: add SM4-XTS app/test: add SM4-XTS test cases app/test/test_cryptodev_blockcipher.c | 3 +- app/test/test_cryptodev_sm4_test_vectors.h | 58 ++ doc/guides/cryptodevs/fea

[PATCH v1 1/2] cryptodev: add SM4-XTS

2024-10-10 Thread Hanxiao Li
add sm4-xts algo for crypto. Signed-off-by: Hanxiao Li --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/rel_notes/release_24_11.rst | 4 lib/cryptodev/rte_crypto_sym.h | 4 +++- lib/cryptodev/rte_cryptodev.c | 3 ++- 4 files changed, 10 insertion

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-10 Thread Wathsala Wathawana Vithanage
> -Original Message- > From: Konstantin Ananyev > Sent: Thursday, October 10, 2024 11:54 AM > To: Wathsala Wathawana Vithanage ; > dev@dpdk.org > Cc: Honnappa Nagarahalli ; > jer...@marvell.com; d...@linux.ibm.com; nd ; nd > > Subject: RE: rte_ring move head question for machines with

Re: [RFC 0/4] ethdev: rework config restore

2024-10-10 Thread Ferruh Yigit
On 10/10/2024 11:58 PM, Konstantin Ananyev wrote: > > > config restore External email: Use caution opening links or attachments On 10/10/2024 1:08 PM, Dariusz Sosnowski wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, October 10,

RE: [RFC 0/4] ethdev: rework config restore

2024-10-10 Thread Konstantin Ananyev
config restore > >> > >> External email: Use caution opening links or attachments > >> > >> > >> On 10/10/2024 1:08 PM, Dariusz Sosnowski wrote: > -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 10, 2024 01:17 > To: Dariusz Sosnowski ; Konstantin Ana

RE: [PATCH v3 1/2] power: enable CPPC support in power library

2024-10-10 Thread Wathsala Wathawana Vithanage
> > fix the name of the CPPC driver name. > > > > Signed-off-by: Wathsala Vithanage > > Reviewed-by: Dhruv Tripathi > > Series applied with a little more details about being a real fix. > > Thanks you Thomas.

Re: [PATCH v3 1/2] power: enable CPPC support in power library

2024-10-10 Thread Thomas Monjalon
10/10/2024 16:17, Wathsala Vithanage: > Power library already supports Linux CPPC driver. Enable its use > and fix the name of the CPPC driver name. > > Signed-off-by: Wathsala Vithanage > Reviewed-by: Dhruv Tripathi Series applied with a little more details about being a real fix.

Re: [PATCH] eal/windows: define standard file numbers

2024-10-10 Thread Thomas Monjalon
10/10/2024 14:33, Dmitry Kozlyuk: > 2024-10-10 12:39 (UTC+0100), Bruce Richardson: > > On Thu, Oct 10, 2024 at 01:43:41PM +0300, Dmitry Kozlyuk wrote: > > > 2024-10-10 10:54 (UTC+0100), Bruce Richardson: > > > > The macros for STD*_FILENO are missing on windows. Add defines for them > > > > to th

Re: [PATCH v9 1/7] eal: add static per-lcore memory allocation facility

2024-10-10 Thread Thomas Monjalon
Hello, This new feature looks to bring something interesting to DPDK. There was a good amount of discussion and review, and there is a real effort of documentation. However, some choices done in this implementation were not explained or advertised enough in the documentation, in my opinion. I th

[PATCH v4] dts: add flow rule dataclass to testpmd shell

2024-10-10 Thread Dean Marx
Add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 57 +

[PATCH v2] doc: reword sample app guides

2024-10-10 Thread Nandini Persad
I have reviewed these sections for grammar/clarity and made small modifications to the formatting of sections to adhere to a template which will create uniformality in the sample application user guides overall. Signed-off-by: Nandini Persad Acked-by: Chengwen Feng --- doc/guides/sample_app_ug/

[PATCH v7 2/2] dts: port over dynamic config test suite

2024-10-10 Thread Dean Marx
Suite for testing ability of Poll Mode Driver to turn promiscuous mode on/off, allmulticast mode on/off, and show expected behavior when sending packets with known, unknown, broadcast, and multicast destination MAC addresses. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.jso

[PATCH v7 1/2] dts: add multicast set function to shell

2024-10-10 Thread Dean Marx
Add set multicast function for changing allmulticast mode within testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 24 +++ 1 file changed, 24 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remot

[PATCH v7 0/2] dts: port over dynamic config suite

2024-10-10 Thread Dean Marx
Dynamic Configuration suite for verifying the Poll Mode Driver's ability to enable/disable promiscuous and allmulticast mode. Verifies the expected behavior in the following four test cases: 1. Default mode - verifies that promiscuous mode is enabled by default, and packets with any destination MA

[PATCH v7 1/2] dts: add multicast set funciton to shell

2024-10-10 Thread Dean Marx
Add set multicast function for changing allmulticast mode within testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 24 +++ 1 file changed, 24 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remot

[PATCH v7 2/2] dts: port over dynamic config test suite

2024-10-10 Thread Dean Marx
Suite for testing ability of Poll Mode Driver to turn promiscuous mode on/off, allmulticast mode on/off, and show expected behavior when sending packets with known, unknown, broadcast, and multicast destination MAC addresses. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.jso

[PATCH v7 0/2] dts: port over dynamic config suite

2024-10-10 Thread Dean Marx
Dynamic Configuration suite for verifying the Poll Mode Driver's ability to enable/disable promiscuous and allmulticast mode. Verifies the expected behavior in the following four test cases: 1. Default mode - verifies that promiscuous mode is enabled by default, and packets with any destination MA

[PATCH v8 2/2] dts: mac filter test suite refactored for new dts

2024-10-10 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. The test suite assesses the behavior of ethdev api calls as it relates to mac address filtering using TestPMD. Specific test cases have been designed

[PATCH v8 1/2] dts: add methods for setting mac and multicast addresses

2024-10-10 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v8 0/2] dts: mac filter port to new dts

2024-10-10 Thread Nicholas Pratte
v8: * final adjustments made for the merged version of vlan testpmd methods. Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_sess

Re: [PATCH dpdk v2 03/16] net: add structure for ipv6 addresses

2024-10-10 Thread Robin Jarry
Morten Brørup, Oct 06, 2024 at 10:18: This has been discussed before, but I want to double check... If - sometime in the future - we want to add a union to offer a 2-byte access variant and make the structure to 2-byte aligned (which is the common case in Ethernet packets), it will break both

Re: [PATCH dpdk v2 16/16] ipv6: add function to check ipv6 version

2024-10-10 Thread Robin Jarry
Hi Morten, Morten Brørup, Oct 06, 2024 at 11:02: Personally, I would prefer following the convention of rte_ether functions to return boolean (as int)... static inline int rte_is__ether_addr(const struct rte_ether_addr *ea) Sorry, I haven't followed your recommendation in v3, but I have a

[PATCH dpdk v3 17/17] ipv6: add function to check ipv6 version

2024-10-10 Thread Robin Jarry
Add a function to check the version in IPv6 headers. Signed-off-by: Robin Jarry --- Notes: v3: only check for the first byte app/test/test_net_ip6.c | 16 lib/net/rte_ip6.h | 14 ++ 2 files changed, 30 insertions(+) diff --git a/app/test/test_net_ip6.c b

[PATCH dpdk v3 16/17] net: add utilities for well known ipv6 address types

2024-10-10 Thread Robin Jarry
Add more utilities to work with IPv6 addresses. These functions will be required in order to help building IPv6 routing applications. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- Notes: v3: - replace string initializers and RTE_IPV6_ADDR() with RTE_IPV6() app/test/t

[PATCH dpdk v3 15/17] rte_flow: use struct rte_ipv6_addr

2024-10-10 Thread Robin Jarry
Update rte_flow_tunnel, rte_flow_action_set_ipv6, rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Use the IPv6 utils that go along. Update all code accordingly. Signed-off-by: Robin Jarry --- Notes: v3: replace string in

[PATCH dpdk v3 14/17] gro: use struct rte_ipv6_addr

2024-10-10 Thread Robin Jarry
Update tcp6_flow_key to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Use the IPv6 utils that go along. Signed-off-by: Robin Jarry --- Notes: v3: replace memcpy() with direct struct assignments doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.

[PATCH dpdk v3 13/17] thash: use struct rte_ipv6_addr

2024-10-10 Thread Robin Jarry
Update rte_ipv6_tuple to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Use IPv6 utils that go along. Signed-off-by: Robin Jarry --- Notes: v3: - replace memcpy() with direct struct assignments - replace string initializers with RTE_IPV6() app/test/test_thash.c

[PATCH dpdk v3 12/17] ipsec, security: use struct rte_ipv6_addr and utils

2024-10-10 Thread Robin Jarry
Update rte_ipsec_sadv6_key to use rte_ipv6_addr structures instead of ad-hoc uint8_t[16] arrays. Use the ipv6 utils that go along. Update rte_security_ipsec_tunnel_param to use rte_ipv6_addr instead of in6_addr. Signed-off-by: Robin Jarry --- Notes: v3: - replace *memcpy() with dir

[PATCH dpdk v3 11/17] pipeline: use struct rte_ipv6_addr

2024-10-10 Thread Robin Jarry
Update rte_table_action_ipv6_header and rte_table_action_nat_params to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- Notes: v3: - replace *memcpy() with direct struct assignments - replace more uint8_t arrays with rte_ipv6_addr in exa

[PATCH dpdk v3 10/17] graph,node: use struct rte_ipv6_addr and utils

2024-10-10 Thread Robin Jarry
Replace ad-hoc uint8_t[16] arrays with rte_ipv6_addr structures. Replace duplicated code with utils from rte_ip6.h. Signed-off-by: Robin Jarry --- Notes: v3: - replace *memcpy() with direct struct assignments - replace string initializers with RTE_IPV6() - replace in6_addr w

[PATCH dpdk v3 09/17] cmdline: replace in6_addr with rte_ipv6_addr

2024-10-10 Thread Robin Jarry
From: Robin Jarry The previous commits introduced a new rte_ipv6_addr structure without any alignment requirements. It is not compatible with the in6_addr POSIX type available in netinet/in.h. The main issue is that in6_addr is not uniform on all platforms which causes unaligned access warnings

[PATCH dpdk v3 08/17] rib6,fib6,lpm6: remove duplicate constants

2024-10-10 Thread Robin Jarry
Replace all address size and max depth macros with common ones from rte_ip6.h. Mark the old symbols as deprecated. Signed-off-by: Robin Jarry --- Notes: v3: - replace memcpy() with direct struct assignments - restore RTE_FIB6_IPV6_ADDR_SIZE, RTE_FIB6_MAXDEPTH, TRIE_MAX_DEPTH,

[PATCH dpdk v3 07/17] fib6,rib6,lpm6: use ipv6 utils

2024-10-10 Thread Robin Jarry
Replace duplicated and/or private functions by utilities from rte_ip6.h. Mark rib6 functions that deal with ipv6 addresses as deprecated. Signed-off-by: Robin Jarry --- Notes: v3: - replace rte_ipv6_addr_cpy with direct assignments app/test/test_fib6.c | 9 +--- app/test/tes

[PATCH dpdk v3 05/17] net: use struct rte_ipv6_addr for header addresses

2024-10-10 Thread Robin Jarry
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses. Replace these arrays with the newly added rte_ipv6_addr structure. Adapt all code accordingly. Signed-off-by: Robin Jarry --- Notes: v3: - replace *memcpy(ipv6) with direct struct assignments - replace RTE_I

[PATCH dpdk v3 04/17] net: add ipv6 address utilities

2024-10-10 Thread Robin Jarry
Add utility functions and macros that use the newly added rte_ipv6_addr structure. Add basic unit tests to ensure everything works as expected. These functions will be used in the next commits to replace private and/or duplicated functions. Signed-off-by: Robin Jarry --- Notes: v3:

[PATCH dpdk v3 02/17] net: split ipv6 symbols in separate header

2024-10-10 Thread Robin Jarry
Move all ipv6 related symbols to a dedicated header. Update all code accordingly. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- Notes: v3: strip braces to make checkpatch happy app/test/packet_burst_generator.c | 1 + app/test/test_cryptodev_security_ipsec.c|

[PATCH dpdk v3 03/17] net: add structure for ipv6 addresses

2024-10-10 Thread Robin Jarry
There is currently no structure defined for IPv6 addresses. Introduce one that is simply a uint8_t array of 16 elements. The idea is to ensure this structure alignment is 1 so that it can be mapped directly on unaligned packet memory. Signed-off-by: Robin Jarry --- Notes: v3: move RTE_IPV6_M

[PATCH dpdk v3 00/17] IPv6 APIs overhaul

2024-10-10 Thread Robin Jarry
Hi everyone, As discussed recently [1], here is a first draft of the IPv6 APIs rework. The API change was announced before the 24.07 release [2]. This series is intended for 24.11. [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6jeh...@redhat.com/ [2] https://git.dpdk.org/dpdk/commit/?id=835d4c

[PATCH dpdk v3 01/17] net: split raw checksum functions in separate header

2024-10-10 Thread Robin Jarry
The checksum functions are used by both ipv4 and ipv6 functions. In preparation of moving ipv6 symbols to a new header, move the checksum related symbols to another dedicated header. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- lib/net/meson.build | 1 + lib/net/rte_cksum.h | 18

[PATCH v7 2/2] dts: mac filter test suite refactored for new dts

2024-10-10 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. The test suite assesses the behavior of ethdev api calls as it relates to mac address filtering using TestPMD. Specific test cases have been designed

[PATCH v7 1/2] dts: add methods for setting mac and multicast addresses

2024-10-10 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v7 0/2] dts: mac filter port to new dts

2024-10-10 Thread Nicholas Pratte
v7: * adjusted commit messages to be more associative with the main branch Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_sessio

Re: [PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Patrick Robb
Reviewed-by: Patrick Robb

[PATCH v2] dts: fix verify argument in set forward mode

2024-10-10 Thread Dean Marx
Fix optional verify argument in set_forward_mode method in testpmd shell class. Bugzilla ID: 1410 Fixes: fc0f7dc47ee3 ("dts: add testpmd shell params") Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) d

Re: [PATCH v3] vfio: combine container_create and group_bind

2024-10-10 Thread Stephen Hemminger
On Wed, 3 Jul 2024 19:59:43 +0800 "BillXiang" wrote: > From: BillXiang > > For multi-devices in one group we can only create and bind to one > container. With this new function, device driver does not need to > save the binding info additionally between different devices. > > Signed-off-by: B

Re: [PATCH 2/2] net/bonding: add command to set dedicated queue size

2024-10-10 Thread Stephen Hemminger
On Mon, 24 Jun 2024 10:03:55 +0800 Chaoyong He wrote: > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > index 06c21ebe6d..c19645aa4f 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c >

Re: [PATCH 1/2] net/bonding: standard the log message

2024-10-10 Thread Stephen Hemminger
On Mon, 24 Jun 2024 10:03:54 +0800 Chaoyong He wrote: > From: Long Wu > > According to the check rules in the patch check script, > drivers and libraries must use the logging framework. > > So standard the log message of bonding driver by using > the logging framework. > > Signed-off-by: Long

Re: [PATCH v1] net/ice: updated 24.07 recommended matching list

2024-10-10 Thread Stephen Hemminger
On Thu, 1 Aug 2024 16:18:41 +0800 hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/ice.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ae975d19ad..59ed8e6808 100644 > --- a/doc/guides/nics/ice.rst > +++ b/

Re: [PATCH v1] net/i40e: updated 24.07 recommended matching list

2024-10-10 Thread Stephen Hemminger
On Thu, 1 Aug 2024 16:19:02 +0800 hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/i40e.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index ca6caa0cff..d4c9790d47 100644 > --- a/doc/guides/nics/i40e.rst >

Re: [PATCH v2] hash: separate param checks in hash create func

2024-10-10 Thread Stephen Hemminger
On Thu, 10 Oct 2024 16:46:02 + Niall Meade wrote: > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 577b5839d3..2569f7d977 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -190,11 +190,17 @@ rte_hash_create(const struct rte_hash_pa

Re: [PATCH v3] dts: add VLAN methods to testpmd shell

2024-10-10 Thread Patrick Robb
Applied to next-dts, thanks!

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread Thomas Monjalon
10/10/2024 19:17, David Marchand: > On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > > > With the annotations added to the allocation functions, > > more issues are detected at compilation time: > > > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > > > It is fixed by mo

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread David Marchand
On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > With the annotations added to the allocation functions, > more issues are detected at compilation time: > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > It is fixed by moving the assignment before freeing the parent poin

[PATCH] net/nfb: fix use after free

2024-10-10 Thread Thomas Monjalon
With the annotations added to the allocation functions, more issues are detected at compilation time: nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' It is fixed by moving the assignment before freeing the parent pointer. Fixes: 80da7efbb4c4 ("eal: annotate allocation functions") Si

Re: [RFC 0/4] ethdev: rework config restore

2024-10-10 Thread Ferruh Yigit
On 10/10/2024 5:23 PM, Dariusz Sosnowski wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, October 10, 2024 14:52 >> To: Dariusz Sosnowski ; Konstantin Ananyev >> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >> ; Andrew Rybchenko >> Cc: dev@dpdk.org; Bruce Richardson >> S

  1   2   3   >