Hi Stephen
On Tue, Sep 17, 2024 at 6:36 AM Stephen Hemminger
wrote:
>
> On Mon, 16 Sep 2024 20:38:51 +0300
> Isaac Boukris wrote:
>
> > + if (mac_pair) {
> > + struct rte_ether_addr *mac;
> > + mac = (struct rte_ether_addr*)ifr.ifr_hwaddr.sa_da
When doing automated testing it is useful to show packet meta
data in JSON.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline.c | 6 +-
app/test-pmd/config.c | 3 +
app/test-pmd/testpmd.h | 1 +
app/test-pmd/util.c
Add ability to get decode packet in summary tshark style format.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline.c | 6 ++--
app/test-pmd/config.c | 22 +
app/test-pmd/testpmd.h | 1 +
app/test-pmd/util.c
This adds new command:
testpmd> set format hex
which decodes packet in hex.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline.c | 40 +
app/test-pmd/config.c | 11 +
app/test-pmd/testpmd.c | 1 +
app/
When running tests in interactive mode, it is useful to be
able to redirect the packet decode (verbose output) into
a file.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline.c | 41 +
app/test-pmd/config.c | 23
Add some tests for new packet dissector.
Signed-off-by: Stephen Hemminger
---
app/test/meson.build| 1 +
app/test/test_dissect.c | 302
2 files changed, 303 insertions(+)
create mode 100644 app/test/test_dissect.c
diff --git a/app/test/meson.build
The function rte_dissect_mbuf is used to decode the contents
of an mbuf into ah uman readable format similar to what tshark uses.
For now, handles IP, IPv6, TCP, UDP, ICMP and ARP.
Signed-off-by: Stephen Hemminger
---
lib/net/meson.build | 2 +
lib/net/rte_dissect.c | 428 ++
Add more defines for additional defined ICMP types.
Signed-off-by: Stephen Hemminger
---
lib/net/rte_icmp.h | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_icmp.h b/lib/net/rte_icmp.h
index 4bf64d70ad..b51b60a6d2 100644
--- a/lib/net/rte_ic
While debugging TAP rte_flow discovered that test pmd verbose output
was confusing and unhelpful. Instead, made a simple dissector that
prints one line per packet like this in test-pmd.
The new commands are:
testpmd> set output /tmp/packet.log
testpmd> set format dissect
To enable
> > > +/**
> > > + * Get pointer to lcore variable instance of the current thread.
> > > + *
> > > + * May only be used by EAL threads and registered non-EAL threads.
> > > + */
> > > +#define RTE_LCORE_VAR_VALUE(handle) \
> > > + RTE_LCORE_VAR_LCORE_VALUE(rte_lcore_id(), handle)
> >
> > Would it
Hi Nicolas,
On 9/16/24 18:17, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Monday, September 16, 2024 12:57 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; Marchand, David
; Vargas, Hernan
Subject: Re: [PATCH v2 2/2] baseband/ac
From: Jeremy Spewock
Currently the runner target in the Dockerfile attempts to run the
`poetry install` command when building the image, but this fails due to
poetry not being found in the container. Poetry is installed in a
previous step with pipx, but doing so adds the binary to use poetry to
~
>+This commit should after "[PATCH v10 2/3] eventdev: add support for
>independent enqueue"
>+because this commit use the macro which defined in later commit. Suggest
>order:
>+1. lib's commit
>+2. driver's commits
Thanks this is addressed with v12
>+The above line will remove when DPDK 24.11 r
Normally, the MAC address of the kernel interface is the same as in the
interface in dpdk, as they represent the same interface. It is useful
to allow viewing them as separate connected interfaces (like ip's veth).
This solves a problem I have running a freebsd-based IPv6 stack on top
of dpdk and
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> Sent: Monday, 16 September 2024 16.02
>
> > Introduce DPDK per-lcore id variables, or lcore variables for short.
> >
> > An lcore variable has one value for every current and future lcore
> > id-equipped thread.
> >
> > The primar
On Mon, Sep 16, 2024 at 6:16 AM Juraj Linkeš wrote:
>
>
>
> On 11. 9. 2024 17:50, jspew...@iol.unh.edu wrote:
> > From: Jeremy Spewock
> >
> > Currently the runner target in the Dockerfile attempts to run the
> > `poetry install` command when building the image, but this fails due to
> > poetry n
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Monday, 16 September 2024 18.13
>
> On 2024-09-16 13:54, Morten Brørup wrote:
> >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> >> Sent: Monday, 16 September 2024 13.13
> >>
> >> The reason for TLS being slower than lcore v
>-Original Message-
>From: fengchengwen
>Sent: Saturday, September 14, 2024 3:12 PM
>To: Vamsi Krishna Attunuru ;
>tho...@monjalon.net; bruce.richard...@intel.com;
>m...@smartsharesystems.com
>Cc: dev@dpdk.org; kevin.la...@intel.com; Jerin Jacob ;
>conor.wa...@intel.com; Gowrishankar Mu
From: Nandini Persad
This document was created to assist contributors in creating DPDK drivers
and provides suggestions and guidelines on how to upstream effectively.
Co-authored-by: Ferruh Yigit
Co-authored-by: Thomas Monjalon
Signed-off-by: Nandini Persad
Reviewed-by: Stephen Hemminger
Ack
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Monday, September 16, 2024 12:57 AM
> To: Chautru, Nicolas ; dev@dpdk.org
> Cc: hemant.agra...@nxp.com; Marchand, David
> ; Vargas, Hernan
> Subject: Re: [PATCH v2 2/2] baseband/acc: improvement to logging mechanism
>
>
>
> Keep per-lcore power intrinsics state in a lcore variable to reduce
> cache working set size and avoid any CPU next-line-prefetching causing
> false sharing.
>
> Signed-off-by: Mattias Rönnblom
> Acked-by: Morten Brørup
> ---
Acked-by: Konstantin Ananyev
> 2.34.1
> Replace static array of cache-aligned structs with an lcore variable,
> to slightly benefit code simplicity and performance.
>
> Signed-off-by: Mattias Rönnblom
> Acked-by: Morten Brørup
>
> --
Acked-by: Konstantin Ananyev
> 2.34.1
On 2024-09-16 13:54, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
Sent: Monday, 16 September 2024 13.13
On 2024-09-16 12:52, Mattias Rönnblom wrote:
Add basic micro benchmark for lcore variables, in an attempt to assure
that the overhead isn't significantly greater
> Replace static array of cache-aligned structs with an lcore variable,
> to slightly benefit code simplicity and performance.
>
> Signed-off-by: Mattias Rönnblom
> Acked-by: Morten Brørup
>
> --
>
> RFC v3:
> * Replace for loop with FOREACH macro.
> ---
Acked-by: Konstantin Ananyev
> 2.3
> -Original Message-
> From: Mattias Rönnblom
> Sent: Monday, September 16, 2024 11:52 AM
> To: dev@dpdk.org
> Cc: hof...@lysator.liu.se; Morten Brørup ;
> Stephen Hemminger ;
> Konstantin Ananyev ; David Marchand
> ; Jerin Jacob
> ; Mattias Rönnblom
> Subject: [PATCH v4 4/7] random:
Thanks for the clarification.
We are okay to move forward with the revert.
בתאריך 16 בספט׳ 2024 18:12, Stephen Hemminger כתב:
CAUTION: This email originated from outside of the organization. Do not click
links or open attachments unless you can confirm the sender and know the
content is safe.
Bursts of up to 64, 128 and 256 packets are not uncommon, so increase the
maximum tested get and put burst sizes from 32 to 256.
For convenience, also test get and put burst sizes of
RTE_MEMPOOL_CACHE_MAX_SIZE.
Some applications keep more than 512 objects, so increase the maximum
number of kept ob
Recheck-request: iol-intel-Functional
Rerunning with David's DTS patch mentioned above.
https://bugs.dpdk.org/show_bug.cgi?id=1545
Bug ID: 1545
Summary: Docs are incorrect regarding how final testsuite list
is produced
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status:
On Tue, Sep 10, 2024 at 10:12:15AM +, Soumyadeep Hore wrote:
> Updated the IAVF Base driver with latest sharedcode patches.
>
> Ahmed Zaki (2):
> common/iavf: define the maximum MSIX index
> common/iavf: add RSS CONFIG hash function
>
> Jacob Keller (1):
> common/iavf: update the PTP en
16/09/2024 15:08, Morten Brørup:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Monday, 16 September 2024 14.41
> >
> > 13/09/2024 16:58, Morten Brørup:
> > > PING for apply.
> > >
> > > Patch has 2 acks.
> > > And since it was signed off by a co-maintainer (myself),
> > > I don'
> Introduce DPDK per-lcore id variables, or lcore variables for short.
>
> An lcore variable has one value for every current and future lcore
> id-equipped thread.
>
> The primary use case is for statically allocating
> small, frequently-accessed data structures, for which one instance
> shoul
https://bugs.dpdk.org/show_bug.cgi?id=1544
Bug ID: 1544
Summary: rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum
incorrect
Product: DPDK
Version: 24.07
Hardware: All
OS: All
Status: UNCONFIRM
On 22. 8. 2024 18:39, Luca Vizzarro wrote:
Add Pydantic to the project dependencies while dropping Warlock.
We should explain what pydantic is and why it's replacing warlock (and I
think make them lowercase as that's how they appear in pyproject.toml).
But maybe we shouldn't remove warlo
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, 16 September 2024 14.41
>
> 13/09/2024 16:58, Morten Brørup:
> > PING for apply.
> >
> > Patch has 2 acks.
> > And since it was signed off by a co-maintainer (myself),
> > I don't think an ack from the other co-maintainer (Andrew
There are some elements which seem to be present in
https://patches.dpdk.org/project/dpdk/patch/20240821145315.97974-4-juraj.lin...@pantheon.tech/,
which is an attempt at decorating test cases (buzgilla 1460) as part of
the capabilities series.
Looks like we could create a separate patch with
16/09/2024 10:51, Juraj Linkeš:
> On 12. 9. 2024 22:09, Thomas Monjalon wrote:
> > 21/08/2024 17:02, Juraj Linkeš:
> >> +req_deps = _get_dependencies(_DTS_DEP_FILE_PATH)
> >> +req_deps.pop('python')
> >> +
> >> +for req_dep, dep_data in (req_deps | _EXTRA_DEPS).items():
> >
> > Please
13/09/2024 16:58, Morten Brørup:
> PING for apply.
>
> Patch has 2 acks.
> And since it was signed off by a co-maintainer (myself),
> I don't think an ack from the other co-maintainer (Andrew) is required.
> Please correct me if I'm wrong?
It's not a matter of acks.
I feel we should reduce from
From: Konstantin Ananyev
Add both functional and stess test-cases for soring API.
Stress test serves as both functional and performance test of soring
enqueue/dequeue/acquire/release operations under high contention
(for both over committed and non-over committed scenarios).
Signed-off-by: Eimea
From: Konstantin Ananyev
Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues
with multiple processing 'stages'.
It is based on conventional DPDK rte_ring, re-uses many of its concepts,
and even substantial part of its code.
It can be viewed as an 'extension' of rte_ring fu
From: Eimear Morrissey
The current rte_ring_dump function uses the generic rte_ring_headtail
structure to access head/tail positions. This is incorrect for the RTS
case where the head is stored in a different offset in the union of
structs. Switching to a separate function for each sync type allo
From: Konstantin Ananyev
Note upfront: that change doesn't introduce any functional
or performance changes.
It is just a code-reordering for:
- improve code modularity and re-usability
- ability in future to re-use the same code to introduce new functionality
There is no real need for enqueue_
From: Konstantin Ananyev
Note upfront: that change doesn't introduce any functional or
performance changes.
It is just a code-reordering for:
- code deduplication
- ability in future to re-use the same code to introduce new functionality
For each sync mode corresponding move_prod_head() and
mo
From: Konstantin Ananyev
v2 -> v3:
- fix compilation/doxygen complains
- dropped patch:
"examples/l3fwd: make ACL work in pipeline and eventdev modes": [2]
As was mentioned in the patch desctiption it was way too big,
controversial and incomplete. If the community is ok to introduce
pipe
VFIO modules may get loaded/initialized after DPDK initialized (like when
starting an application without knowing which devices will be used, and
whether their drivers require VFIO).
Retry enabling VFIO if not available.
This way, it is not required to restart the DPDK application anymore.
Signed
At the moment, if VFIO is not available at DPDK init, it won't be
available unless a subsequent rte_vfio_enable() is done.
Yet, even if rte_vfio_enable() is called again in primary and secondary
processes, a secondary process will never get to know that VFIO has been
enabled in the primary process
Addendum to previous mail.
I missed some issues, but the CI did catch them.
On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom
wrote:
> diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
> index b774625d9f..06b249dca0 100644
> --- a/lib/eal/include/rte_vfio.h
> +++ b/lib/eal/incl
Hello,
On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom
wrote:
> diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h
> index 3c1dc402ca..e4c7d07c69 100644
> --- a/lib/acl/rte_acl_osdep.h
> +++ b/lib/acl/rte_acl_osdep.h
> @@ -5,10 +5,6 @@
> #ifndef _RTE_ACL_OSDEP_H_
> #define _RTE_AC
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Monday, 16 September 2024 13.13
>
> On 2024-09-16 12:52, Mattias Rönnblom wrote:
> > Add basic micro benchmark for lcore variables, in an attempt to assure
> > that the overhead isn't significantly greater than alternative
> > approac
Enabled the extended packet number(XPN) case so that
traffic runs for longer duration without raising interrupt
for PN threshold as the application currently does not handle
rekeying.
Signed-off-by: Akhil Goyal
---
examples/l2fwd-macsec/main.c | 8 +---
1 file changed, 5 insertions(+), 3 del
On 2024-09-16 12:52, Mattias Rönnblom wrote:
Add basic micro benchmark for lcore variables, in an attempt to assure
that the overhead isn't significantly greater than alternative
approaches, in scenarios where the benefits aren't expected to show up
(i.e., when plenty of cache is available compar
Keep per-lcore power intrinsics state in a lcore variable to reduce
cache working set size and avoid any CPU next-line-prefetching causing
false sharing.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
---
lib/eal/x86/rte_power_intrinsics.c | 17 +++--
1 file changed, 11 ins
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
small, frequently-accessed data structures, for which one instance
should exist for each l
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Replace for loop with FOREACH macro.
---
lib/power/rte_power_pmd_mgmt.c | 34 ---
This patch set introduces a new API for static
per-lcore id data allocation.
Please refer to the API documentation for both a
rationale for this new API, and a comparison to the alternatives
available.
The adoption of this API would affect many different DPDK modules, but
the author updated onl
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v6:
* Remove a now-redundant lcore variable value memset().
RFC v5:
* Fix lcore value pointer bug introdu
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a more cache-friendly lcore variable.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Remove cache alignment on unregist
Add functional test suite to exercise the API.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check all lcore id's values for all variables in the many variables
test case.
* Introduce tes
Add basic micro benchmark for lcore variables, in an attempt to assure
that the overhead isn't significantly greater than alternative
approaches, in scenarios where the benefits aren't expected to show up
(i.e., when plenty of cache is available compared to the working set
size of the per-lcore dat
On 2024-09-13 13:23, Jerin Jacob wrote:
On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom wrote:
On 2024-09-12 17:11, Jerin Jacob wrote:
On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom wrote:
On 2024-09-12 15:09, Jerin Jacob wrote:
On Thu, Sep 12, 2024 at 2:34 PM Mattias Rönnblom
wrote:
On 12. 8. 2024 16:23, Dean Marx wrote:
Add optional verify argument to the set_forward_mode
method in testpmd shell.
This doesn't add the method, just fixes it's use. Don't forget to fix
the subject as well. And also add the tags that Jeremy mentioned.
Signed-off-by: Dean Marx
---
dt
On 11. 9. 2024 17:50, jspew...@iol.unh.edu wrote:
From: Jeremy Spewock
Currently the runner target in the Dockerfile attempts to run the
`poetry install` command when building the image, but this fails due to
poetry not being found in the container. Poetry is installed in a
previous step wit
On 12. 8. 2024 18:35, Dean Marx wrote:
In the current DTS setup description, the user installs poetry
with the --no-root option. However, adding 'package-mode = false'
to the pyproject.toml sets the same configuration, and running
poetry install --no-root will become an error in a future
poetr
On 9. 9. 2024 17:55, Jeremy Spewock wrote:
On Mon, Sep 9, 2024 at 8:16 AM Juraj Linkeš wrote:
On 12. 8. 2024 19:22, jspew...@iol.unh.edu wrote:
From: Jeremy Spewock
The DTS framework in its current state supports binding ports to
different drivers on the SUT node but not the TG node. T
Delete non essential files and modify code style issues.
Signed-off-by: Jie Liu
---
drivers/net/sxe/include/readme.txt| 0
drivers/net/sxe/include/sxe_version.h | 31
drivers/net/sxe/pf/sxe.h | 3 -
drivers/net/sxe/pf/sxe_filter.c | 33 +++--
drivers/net/sxe/pf/
> From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> Sent: Monday, 16 September 2024 10.12
>
> On Fri, Sep 13, 2024 at 8:10 PM Morten Brørup
> wrote:
> >
> > > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > > Sent: Friday, 13 September 2024 13.24
> > >
> > > On Fri, Sep 13, 2024 at 12:17 PM
On Thu, Sep 12, 2024 at 10:27 AM David Marchand
wrote:
>
> This is a continuation of the cleanup effort in logging macros.
>
> As a reminder of what this series is about, RTE_LOG_LINE() has been
> introduced to check that the format string does not contain a trailing \n.
> The goal was to prevent
Hi Team
As part of DPDK-22.11.2, we were downloading the dpdk-kmods folder from the
following link: http://dpdk.org/git/dpdk-kmods.
Off late, this link is down and even the alternate link:
https://git.dpdk.org/dpdk-kmods/ is intermittently down.
Can you please guide us to the latest link to down
On 12. 9. 2024 22:09, Thomas Monjalon wrote:
21/08/2024 17:02, Juraj Linkeš:
+if 'dts' in src:
+os.environ['DTS_BUILD'] = "y"
That's more precisely "DTS doc build".
I think the variable name DTS_BUILD may be confusing.
Ack, I'll rename the variable.
[...]
--- /dev/null
+++ b/build
On Mon, Sep 16, 2024 at 2:01 PM David Marchand
wrote:
>
> On Mon, Sep 16, 2024 at 10:26 AM Jerin Jacob wrote:
> > > rte_flow_dev_dump;
> > >
> > > # added in 20.05
> > > - __rte_ethdev_trace_rx_burst;
> >
> > Removal of a public symbol breaks the ABI. The good news is that 2
On Mon, Sep 16, 2024 at 10:26 AM Jerin Jacob wrote:
> > rte_flow_dev_dump;
> >
> > # added in 20.05
> > - __rte_ethdev_trace_rx_burst;
>
> Removal of a public symbol breaks the ABI. The good news is that 24.11
> can break the ABI.
> IMO, It is OK to break this ABI.
This symb
On Sat, Sep 14, 2024 at 1:59 AM Adel Belkhiri wrote:
>
> From: Adel Belkhiri
>
> Split the tracepoints rte_ethdev_trace_rx_burst and
> rte_eth_trace_call_rx_callbacks into two separate ones
> for empty and non-empty calls to avoid saturating
> quickly the trace buffer.
>
> Signed-off-by: Adel Bel
On Fri, Sep 13, 2024 at 8:10 PM Morten Brørup
wrote:
>
> > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > Sent: Friday, 13 September 2024 13.24
> >
> > On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom
> > wrote:
> > >
> > > On 2024-09-12 17:11, Jerin Jacob wrote:
> > > > On Thu, Sep 12, 2
On 9/13/24 21:00, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Friday, September 13, 2024 7:18 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; Marchand, David
; Vargas, Hernan
Subject: Re: [PATCH v2 2/2] baseband/acc: improvem
74 matches
Mail list logo
