Re: [PATCH v4 0/6] refine argparse library

2024-07-04 Thread Jie Hai
For the patchset, Acked-by: Jie Hai On 2024/3/18 19:18, Chengwen Feng wrote: I found a couple of issues when I revisited the argparse_autotest output, so got this patchset. Chengwen Feng (6): argparse: refine error message argparse: remove dead code argparse: replace flag enum with

[PATCH v2 2/2] net/cpfl: fix +ve error codes for received ctlq messages

2024-07-04 Thread Soumyadeep Hore
Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_

[PATCH v2 1/2] net/cpfl: fix check for opcodes of received ctlq messages

2024-07-04 Thread Soumyadeep Hore
cpfl_process_rx_ctlq_msg() is used to check error status returned for specific opcodes and return error messages accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_fxp_rule.c | 52

[PATCH v2 0/2] Avoid rule duplication in CPFL PMD

2024-07-04 Thread Soumyadeep Hore
This patchset avoids flow rule duplication which was possible previously in CPFL PMD. --- v2: * Addressed review comments * Added Fixes tags * Fixed CI warnings --- Soumyadeep Hore (2): net/cpfl: fix check for opcodes of received ctlq messages net/cpfl: fix +ve error codes for received ctlq m

RE: [PATCH] test: fix option block

2024-07-04 Thread Ye, MingjinX
> -Original Message- > From: Stokes, Ian > Sent: Thursday, July 4, 2024 8:02 PM > To: Ye, MingjinX ; dev@dpdk.org > Subject: RE: [PATCH] test: fix option block > > > > -Original Message- > > > From: Stokes, Ian > > > Sent: Wednesday, July 3, 2024 10:35 PM > > > To: Ye, Mingjin

Re: [PATCH v5 23/23] net/ntnic: add GMF (Generic MAC Feeder) module

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:39 AM, Serhii Iliushyk wrote: > Add API for Generic MAC Feeder > > Signed-off-by: Serhii Iliushyk > Overall commit logs are very terse, can you please add more details, comment is not specific to this commit, but for this commit like explaining what GMF is for etc.. can help

Re: [PATCH v5 16/23] net/ntnic: add link management module

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add link control API > > Signed-off-by: Serhii Iliushyk <...> > static struct eth_dev_ops nthw_eth_dev_ops = { > .dev_configure = eth_dev_configure, > .dev_start = eth_dev_start, > .dev_stop = eth_dev_stop, > + .dev_set_link_

Re: [PATCH v5 11/23] net/ntnic: add FPGA initialization functionality

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Enable FPGA initialization > > Signed-off-by: Serhii Iliushyk <...> > static struct eth_dev_ops nthw_eth_dev_ops = { > .dev_configure = eth_dev_configure, > .dev_start = eth_dev_start, > .dev_stop = eth_dev_stop, > .dev_clo

Re: [PATCH v5 06/23] net/ntnic: add NT NIC driver dependencies

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add structures and interfaces specific for NT smartNiC > The commit log is not really descriptive, I can see patch improves driver with struct eth_dev_ops. And patch adds global 'struct drv_s' structure, I assume, as one pci device can have multiple

Re: [PATCH v5 04/23] net/ntnic: add NT utilities implementation

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add ntnic utilities. > > Signed-off-by: Serhii Iliushyk > --- > drivers/net/ntnic/meson.build | 2 ++ > drivers/net/ntnic/ntnic_ethdev.c | 2 ++ > drivers/net/ntnic/ntutil/include/nt_util.h | 28 ++ > drivers

Re: [PATCH v5 03/23] net/ntnic: add minimal initialization for PCI device

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > add implementation for probe/init and remove/deinit of the PCI device > > Signed-off-by: Serhii Iliushyk > --- > drivers/net/ntnic/ntnic_ethdev.c | 104 ++- > 1 file changed, 103 insertions(+), 1 deletion(-) > > diff --g

Re: [PATCH v5 02/23] net/ntnic: add logging implementation

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add ntnic specific implementation for logging > > Signed-off-by: Serhii Iliushyk > --- > drivers/net/ntnic/meson.build | 2 + > drivers/net/ntnic/ntlog/include/ntlog.h | 49 +++ > drivers/net/ntnic/ntlog/ntlog.c

Re: [PATCH v5 01/23] net/ntnic: add ethdev and makes PMD available

2024-07-04 Thread Ferruh Yigit
On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add ntnic ethdev base implementation > Hi Serhii, Thanks for the updated version, how driver constructed patch by patch is easier to grasp now. <...> > diff --git a/doc/guides/nics/ntnic.rst b/doc/guides/nics/ntnic.rst > new file mode 100644 > in

Re: [PATCH 1/4] cfgfile: remove dead code

2024-07-04 Thread Stephen Hemminger
On Tue, 20 Feb 2024 03:58:37 + Chengwen Feng wrote: > This memchr() will never return NULL because rte_cfgfile_load() function > will skip lines without useful content. > > Fixes: 74e0d3a17461 ("cfgfile: fix null pointer dereference in parsing") > Cc: sta...@dpdk.org > > Signed-off-by: Chen

Re: [PATCH 4/4] cfgfile: add unique name flag

2024-07-04 Thread Stephen Hemminger
On Tue, 20 Feb 2024 03:58:40 + Chengwen Feng wrote: > The cfgfile supports duplicate section name and entry name when parsing > config file, which may confused and hard to debug when accidentally set > duplicate name. > > So add unique name flag, it will treat as error if encounter duplicate

Re: [PATCH 3/4] cfgfile: verify add section and entry result

2024-07-04 Thread Stephen Hemminger
On Tue, 20 Feb 2024 03:58:39 + Chengwen Feng wrote: > The rte_cfgfile_add_section() and _add_entry()'s result were not > verified, so that potential errors may not be detected. > > This commit adds the verification. > > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng Should add more

Re: Hairpin Queues Throughput ConnectX-6

2024-07-04 Thread Dmitry Kozlyuk
2024-07-04 13:08 (UTC+0200), Mário Kuka: [...] > So I can't achieve my goal: traffic from the hairpin queues is not > dropped if the CPU queue is overloaded. > Any idea how to achieve this in example 4? > What is the problem, full packet buffers/memory in the device that are > shared between the

Re: [PATCH v10 1/4] hash: pack the hitmask for hash in bulk lookup

2024-07-04 Thread David Marchand
Hello Yoan, On Wed, Jul 3, 2024 at 7:13 PM Yoan Picchi wrote: > > Current hitmask includes padding due to Intel's SIMD > implementation detail. This patch allows non Intel SIMD > implementations to benefit from a dense hitmask. > In addition, the new dense hitmask interweave the primary > and sec

Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-04 Thread Thomas Monjalon
04/07/2024 16:55, Stephen Hemminger: > On Thu, 04 Jul 2024 16:14:42 +0200 > Thomas Monjalon wrote: > > > > > Let’s ask Pavan why this flag is used in cn10k driver. > > > > > > > > From our perspective, WFE is available on all the supported arm > > > > platforms in > > > > DPDK. > > > > Therefor

Re: [PATCH 0/2] provide toolchain abstracted __builtin_constant_p

2024-07-04 Thread Patrick Robb
On Wed, Jul 3, 2024 at 12:14 PM Thomas Monjalon wrote: > > > We had some doubts with CI. > It should be solved on the top of the main branch, let's see. > > Applied, thanks. > https://patchwork.dpdk.org/project/dpdk/patch/1710970416-27841-3-git-send-email-roret...@linux.microsoft.com/ Looks like

Re: [RFC 2/4] gro: remove use of VLAs

2024-07-04 Thread Ferruh Yigit
On 6/12/2024 1:48 AM, Ferruh Yigit wrote: > On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: >> From: Konstantin Ananyev >> >> ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] >> ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] >> >> In both cases the

Re: [RFC 2/4] gro: remove use of VLAs

2024-07-04 Thread Ferruh Yigit
On 7/4/2024 11:05 AM, Konstantin Ananyev wrote: > >>> >>> ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] >>> ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] >>> >>> In both cases the pattern is the same: we use unprocess_pkts[n

Re: [PATCH v6 0/8] latencystats: improvements to algorithm and test

2024-07-04 Thread David Marchand
On Thu, May 30, 2024 at 12:57 AM Stephen Hemminger wrote: > > Latencystats uses unnecessary floating point and is inaccurate if the number > of cycles per ns is not an integral value. Cleanup the code and add > more tests as well. > > v6 - rebase and combine updates to test > > Stephen Hemminger (

Re: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too small

2024-07-04 Thread David Marchand
On Thu, Jun 27, 2024 at 2:44 AM Kiran Kumar Kokkilagadda wrote: > > On 06/25, Kiran Kumar Kokkilagadda wrote: > > > From: Mahmoud Maatuq > > > Sent: Tuesday, June 25, 2024 1: 31 > > AM > To: Sunil Kumar Kori ; Rakesh Kudurumalla > > ; > > On 06/25, Kiran Kumar Kokkilagadda wrote: > > > Subject: [

Re: [PATCH 0/4] cfgfile: enhance error detecting

2024-07-04 Thread David Marchand
On Tue, Feb 20, 2024 at 5:00 AM Chengwen Feng wrote: > > When I was trying to debug a problem introduced by config.ini in > test-dma-perf, I found the cfgfile library should enhance error > detecting, so got this patchset. > > Chengwen Feng (4): > cfgfile: remove dead code > cfgfile: support v

Re: [PATCH v2 0/3] fix bpf load hangs with six IPv6 addresses

2024-07-04 Thread David Marchand
On Thu, Jun 27, 2024 at 8:05 PM Konstantin Ananyev wrote: > > From: Konstantin Ananyev > > v2: > - fix compilation warnings > - fix nit in comments (Stephen) > > Konstantin Ananyev (3): > bfp: fix MOV instruction evaluation > bfp: fix load hangs with six IPv6 addresses > test/bpf: add ext

Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-04 Thread Thomas Monjalon
04/07/2024 12:55, Pavan Nikhilesh Bhagavatula: > > > 03/07/2024 15:27, Wathsala Wathawana Vithanage: > > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > > >

Re: [PATCH v1] net/cpfl: add checks for received ctlq messages

2024-07-04 Thread Bruce Richardson
On Thu, Jul 04, 2024 at 05:18:35AM +, Soumyadeep Hore wrote: > cpfl_process_rx_ctlq_msg() is used to check error status > returned for specific opcodes. > > Previously error codes were only -ve for > cpfl_receive_ctlq_msg() but now there are +ve error codes. > Hence code changes are made accor

Re: [PATCH v3] net/ice: support FEC feature

2024-07-04 Thread Bruce Richardson
On Thu, Jul 04, 2024 at 01:00:00PM +0100, Medvedkin, Vladimir wrote: > > On 04/07/2024 07:50, Mingjin Ye wrote: > > This patch enable three Forward Error Correction(FEC) related ops > > in ice driver. As no speed information can get from HW, this patch > > only show FEC capability. > > > > Signed

RE: [PATCH] test: fix option block

2024-07-04 Thread Stokes, Ian
> > -Original Message- > > From: Stokes, Ian > > Sent: Wednesday, July 3, 2024 10:35 PM > > To: Ye, MingjinX ; dev@dpdk.org > > Subject: [PATCH] test: fix option block > > > > > > The options allow (-a) and block (-b) cannot be used at the same time. > > > > Therefore, allow (-a) will not

Re: [PATCH v3] net/ice: support FEC feature

2024-07-04 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 04/07/2024 07:50, Mingjin Ye wrote: This patch enable three Forward Error Correction(FEC) related ops in ice driver. As no speed information can get from HW, this patch only show FEC capability. Signed-off-by: Qiming Yang Signed-off-by: Mingjin Ye --- v3: opt

Re: [PATCH v6] net/i40e: support FEC feature

2024-07-04 Thread Bruce Richardson
On Wed, Jul 03, 2024 at 06:37:12PM +0100, Medvedkin, Vladimir wrote: > > On 02/07/2024 09:40, Zhichao Zeng wrote: > > This patch enabled querying Forward Error Correction(FEC) capabilities, > > set FEC mode and get current FEC mode functions. > > > > Signed-off-by: Zhichao Zeng > > > Acked-by:

Re: Hairpin Queues Throughput ConnectX-6

2024-07-04 Thread Mário Kuka
Hello I did experiments where I sent packets to the hairpin queues and the CPU queue at the same time. During testing, I found that when the CPU queue is overloaded too much, the hairpin queues also begin to drop packets. Example 1: Sending 10 Gbps to hairpin queues Resulting throughput is 10

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-04 Thread Pavan Nikhilesh Bhagavatula
> > 03/07/2024 15:27, Wathsala Wathawana Vithanage: > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > > > > > Perhaps we should change RTE_ARM_USE_WFE to somethi

Re: [PATCH v3] net/mlx5: fix matcher object memory leak

2024-07-04 Thread Raslan Darawsheh
Hi, From: Mahmoud Maatuq Sent: Tuesday, July 2, 2024 11:14 PM To: Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Maayan Kashani Cc: dev@dpdk.org; Mahmoud Maatuq Subject: [PATCH v3] net/mlx5: fix matcher object memory leak This makes sure that the allocated ma

[PATCH] crypto/qat: fix incorrect placement of oop offset

2024-07-04 Thread Arkadiusz Kusztal
This patch fixes incorrect placement of OOP offset. Data preceding crypto operation is not copied to the output buffer, which is conformant to the API. Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Cc: sta...@dpdk.org Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/

[PATCH v2] net/mlx5: add metadata split for compatibility API

2024-07-04 Thread Bing Zhao
The method will not create any new flow rule implicitly during split stage, but only generate needed items, actions and attributes based on the detection. All the rules will still be created in the flow_hw_list_create(). In the meanwhile, once the mark action is specified in the FDB rule, a new r

RE: [RFC 2/4] gro: remove use of VLAs

2024-07-04 Thread Konstantin Ananyev
> > > > ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] > > ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] > > > > In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to > > collect un-used by GRO packets,

Re: [PATCH] net/virtio-user: fix control queue allocation for non-vDPA

2024-07-04 Thread David Marchand
On Wed, Jul 3, 2024 at 6:27 PM Maxime Coquelin wrote: > > For non-vDPA backends, where the backend does not support > control queue, it is still emulated in the Virtio-user > layer to handle multiqueue feature. The frontend setups a > control queue, which is hidden to the device. It means the > nu

Re: [RFC 2/4] gro: remove use of VLAs

2024-07-04 Thread Ferruh Yigit
On 6/28/2024 1:57 PM, Konstantin Ananyev wrote: > On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] > ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla]

Re: [PATCH v6 1/2] bus/pci: fix secondary process PCI uio resource map problem

2024-07-04 Thread Chenbo Xia
> On Jul 2, 2024, at 15:40, Chaoyong He wrote: > > External email: Use caution opening links or attachments > > > From: Zerun Fu > > For the primary process, the logic loops all BARs and will skip > the map of BAR with an invalid physical address (0), also will > assign 'uio_res->nb_maps' w

[PATCH 1/1] maintainers: update for Chelsio cxgbe

2024-07-04 Thread Potnuri Bharat Teja
Update maintainers for chelsio cxgbe drivers. Signed-off-by: Potnuri Bharat Teja --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 533f707d5f76..72575b09557e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -717,7 +717,7 @@ F: doc/gu

RE: [PATCH] test: fix option block

2024-07-04 Thread Ye, MingjinX
> -Original Message- > From: Stokes, Ian > Sent: Wednesday, July 3, 2024 10:35 PM > To: Ye, MingjinX ; dev@dpdk.org > Subject: [PATCH] test: fix option block > > > > The options allow (-a) and block (-b) cannot be used at the same time. > > > Therefore, allow (-a) will not be added whe

[PATCH v3] vfio: combine container_create and group_bind

2024-07-04 Thread BillXiang
From: BillXiang For multi-devices in one group we can only create and bind to one container. With this new function, device driver does not need to save the binding info additionally between different devices. Signed-off-by: BillXiang --- lib/eal/include/rte_vfio.h | 17 + lib/

[PATCH v3] net/ice: support FEC feature

2024-07-04 Thread Mingjin Ye
This patch enable three Forward Error Correction(FEC) related ops in ice driver. As no speed information can get from HW, this patch only show FEC capability. Signed-off-by: Qiming Yang Signed-off-by: Mingjin Ye --- v3: optimize code details --- v2: fix some logic --- doc/guides/nics/features/