rte_pktmbuf_alloc_bulk is called by the zero-copy receiver to allocate
new mbufs to be provided to the sender. The allocated mbuf pointers
are stored in a ring, but the alloc function doesn't implement index
wrap-around, so it writes past the end of the array. This results in
memory corruption and
Hi Thomas,
Aditya the original author of this patch is no longer at Arm.
One of my colleagues will take over this patch, hence we will need some time to
address these comments.
Thank you
> There were many comments on previous versions, and no ack on the v3, so I'm
> not sure all comments are ad
rte_pktmbuf_alloc_bulk is called by the zero-copy receiver to allocate
new mbufs to be provided to the sender. The allocated mbuf pointers
are stored in a ring, but the alloc function doesn't implement index
wrap-around, so it writes past the end of the array. This results in
memory corruption and
From: Jeremy Spewock
Some NICs tested in DPDK allow for the scattering of packets without an
offload and others enforce that you enable the scattered_rx offload in
testpmd. The current version of the suite for testing support of
scattering packets only tests the case where the NIC supports testin
From: Jeremy Spewock
There are methods within DTS currently that support updating the MTU of
ports on a node, but the methods for doing this in a linux session rely
on the ip command and the port being bound to the kernel driver. Since
test suites are run while bound to the driver for DPDK, there
From: Jeremy Spewock
The InteractiveShell class currently relies on being cleaned up and
shutdown at the time of garbage collection, but this cleanup of the class
does no verification that the session is still running prior to cleanup.
So, if a user were to call this method themselves prior to ga
From: Jeremy Spewock
Interactive shells are managed in a way currently where they are closed
and cleaned up at the time of garbage collection. Due to there being no
guarantee of when this garbage collection happens in Python, there is no
way to consistently know when an application will be closed
From: Jeremy Spewock
v6:
* Fix port_start_then_stop decorator in the testpmd class to properly
accept parameters.
Jeremy Spewock (4):
dts: add context manager for interactive shells
dts: improve starting and stopping interactive shells
dts: add methods for modifying MTU to testpmd shel
Configuration schema for the queue_start_stop suite.
Signed-off-by: Dean Marx
---
dts/framework/config/conf_yaml_schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dts/framework/config/conf_yaml_schema.json
b/dts/framework/config/conf_yaml_schema.json
index f02a31
This suite tests the ability of the Poll Mode Driver to enable
and disable Rx/Tx queues on a port.
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_queue_start_stop.py | 95 +
1 file changed, 95 insertions(+)
create mode 100644 dts/tests/TestSuite_queue_start_stop.py
di
added set promisc, set verbose, and port stop
commands to testpmd shell.
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 124 ++
1 file changed, 124 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_sess
Update maintainers for Bitops, Ticketlock, and ARMv8 Crypto.
Signed-off-by: Jack Bond-Preston
Reviewed-by: Wathsala Vithanage
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index dfc022c0c6..6cfcf4cafe 100644
--- a/MAINTAINERS
Signed-off-by: Jack Bond-Preston
Reviewed-by: Wathsala Vithanage
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 533f707d5f..dfc022c0c6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -279,13 +279,13 @@ F: lib/eal/common/rte_r
On Fri, 28 Jun 2024 11:05:20 +0100
Daniel Gregory wrote:
> > > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> > > > memorder, which is not constant. This causes compile errors when it is
> > > > enabled with RTE_ARM_USE_WFE. eg.
> > > >
> > > > ../lib/eal/arm/include/rte_
On Mon, Jun 24, 2024 at 09:16:23AM +, Soumyadeep Hore wrote:
> ---
> v5:
> - Removed warning from patch 6
> ---
Patches 1-14 applied dpdk-next-net-intel. There are some open
questions/comments on later patches.
For v6, please rebase on dpdk-next-net-intel tree and submit only new
versions of
Hi,
When putting commit titles, checkpatch will complain if you use function
names, or macro/variable names. It does this by checking for underscores.
When this gets flagged, please rewrite the commit title to be more generic,
don't just remove the underscores from the function names! I've fixed
On Mon, Jun 24, 2024 at 09:16:39AM +, Soumyadeep Hore wrote:
> With the internal Linux upstream feedback that is received on
> IDPF driver and also some references available online, it
> is discouraged to use 1-sized array fields in the structures,
> especially in the new Linux drivers that are
On Mon, Jun 24, 2024 at 09:16:38AM +, Soumyadeep Hore wrote:
> Introduced through customer's feedback in their attempt to address some
> bugs this introduces a memory barrier before posting ctlq tail. This
> makes sure memory writes have a chance to take place before HW starts
> messing with th
On Mon, Jun 24, 2024 at 09:16:36AM +, Soumyadeep Hore wrote:
> When the message for getting timestamp latches is sent by the driver,
> number of latches is equal to 0. Current implementation of message
> validation function incorrectly notifies this kind of message length as
> invalid.
>
> Sig
On Mon, Jun 24, 2024 at 09:16:32AM +, Soumyadeep Hore wrote:
> Mask for VIRTCHNL2_RX_FLEX_DESC_ADV_FF1_M was defined wrongly
> and this patch fixes it.
>
Fixes: fb4ac04e9bfa ("common/idpf: introduce common library")
Will add on apply.
Test suite for verifying VLAN filtering, stripping, and insertion
functionality on Poll Mode Driver.
Signed-off-by: Dean Marx
---
dts/tests/TestSuite_vlan.py | 173
1 file changed, 173 insertions(+)
create mode 100644 dts/tests/TestSuite_vlan.py
diff --git
Configuration to run vlan test suite
Signed-off-by: Dean Marx
---
dts/framework/config/conf_yaml_schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dts/framework/config/conf_yaml_schema.json
b/dts/framework/config/conf_yaml_schema.json
index f02a310bb5..cd45902cc4
added the following methods to testpmd shell class:
vlan set filter on/off, rx vlan add/rm,
vlan set strip on/off, port stop/start all/port,
tx vlan set/reset, set promisc/verbose
Signed-off-by: Dean Marx
---
dts/framework/remote_session/testpmd_shell.py | 271 ++
1 file changed,
On 2/29/24 14:29, Srujana Challa wrote:
This patch series makes Virtio-user works in IOVA as PA mode
for vDPA backend.
First patch fixes the issue when having buffer IOVA address in
control queue descriptors.
Second and third patches helps to share descriptor IOVA address,
to the vhost backen
> >> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote:
> >>> From: Konstantin Ananyev
> >>>
> >>> ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla]
> >>> ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla]
> >>>
> >>> In both cases the pattern is the same
When a maintainer changes its mail address, check that the associated
entry in .mailmap knows this address, otherwise there is a chance
.mailmap points at an obsolete address.
While at it, fix Zhirun mail address in mailmap and add Jian and Srikanth.
Signed-off-by: David Marchand
---
Changes sin
On Fri, Jun 28, 2024 at 01:38:59PM +0100, Bruce Richardson wrote:
> On Wed, Jun 26, 2024 at 05:31:55PM +, Vladimir Medvedkin wrote:
> > Currently, ice_dev_init() calls ice_vsi_config_sw_lldp(), which uses
> > switch filters to match packets ethertype to redirect LLDP packets
> > to the default
On Wed, Jun 26, 2024 at 05:31:55PM +, Vladimir Medvedkin wrote:
> Currently, ice_dev_init() calls ice_vsi_config_sw_lldp(), which uses
> switch filters to match packets ethertype to redirect LLDP packets
> to the default VSI. However, some NVMs have an issue creating such a rule.
>
> This patc
On Tue, Jun 18, 2024 at 01:12:13PM +0100, Bruce Richardson wrote:
> On Mon, May 27, 2024 at 07:19:21PM +0300, Igor Gutorov wrote:
> > According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive
> > queue descriptor length is 0x1FE0 (8160 in base 10). This is specified
> > as QLEN in tab
On Thu, May 30, 2024 at 6:45 PM David Christensen wrote:
>
> From: David Christensen
>
> IBM POWER systems support more than one type of memory management unit
> (MMU). The Power ISA 3.0 specification, which applies to P9 and later
> CPUs, defined a new Radix MMU which, among other things, allow
Hello
27/06/2024 22:42, Patrick Robb:
> Hi Thomas,
>
> Last November when we chatted in tech board about 2024 DTS goals, you
> said testpmd should be the primary tool used to drive the testsuites,
> and that if testpmd was missing some support for any DPDK features we
> want to test in DTS, then
On Tue, Jun 25, 2024 at 2:25 PM David Marchand
wrote:
> diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c
> b/drivers/crypto/ccp/rte_ccp_pmd.c
> index 869399597e..022c1df182 100644
> --- a/drivers/crypto/ccp/rte_ccp_pmd.c
> +++ b/drivers/crypto/ccp/rte_ccp_pmd.c
> @@ -22,6 +22,7 @@
> static unsigned
On Wed, Jun 26, 2024 at 06:33:36PM +0100, Bruce Richardson wrote:
> On Wed, Jun 26, 2024 at 12:40:48PM +0100, Anatoly Burakov wrote:
> > This is a patchset loosely based on internal development tree which
> > tracked ICE driver development over a period of time since last
> > snapshot update.
> >
On Fri, Jun 28, 2024 at 05:54:00PM +0800, Wenwu Ma wrote:
> In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs,
> DPDK needs to write a correct value to this file when configuring a device
> instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be
> configured, thi
hi
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, June 28, 2024 5:28 PM
> To: Ma, WenwuX
> Cc: dev@dpdk.org; Jiale, SongX
> Subject: Re: [PATCH] dma/idxd: fix failure to configure a device instance for
> DSA
>
> On Fri, Jun 28, 2024 at 01:34:58PM +0800, Wenwu Ma wrote:
In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs,
DPDK needs to write a correct value to this file when configuring a device
instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be
configured, this patch fixes the issue.
Signed-off-by: Wenwu Ma
---
v2:
- refi
On Thu, Jun 27, 2024 at 05:08:51PM +0200, Thomas Monjalon wrote:
> 04/05/2024 02:59, Stephen Hemminger:
> > On Fri, 3 May 2024 19:27:30 +0100
> > Daniel Gregory wrote:
> >
> > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> > > memorder, which is not constant. This causes
On Fri, Jun 28, 2024 at 01:34:58PM +0800, Wenwu Ma wrote:
> In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs,
> DPDK needs to write a correct value to this file when configuring a device
> instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be
> configured, thi
The AmpereOneAC04 is efficient Cloud Native CPU:
Up to 192 Cores
2MB Private L2 Cache per Core
8 channel DDR5
128 lanes PCIe Gen5
Signed-off-by: Yutang Jiang
---
config/arm/arm64_ampereoneac04_linux_gcc | 17 +
config/arm/meson.build | 19 +++
On 2/29/24 14:29, Srujana Challa wrote:
This patch makes changes to avoid descriptor buffer address
accessing while processing shadow control queue.
So that Virtio-user can work with having IOVA as descriptor
buffer address.
Signed-off-by: Srujana Challa
---
.../net/virtio/virtio_user/virt
From: Zerun Fu
In the previous logic the 'fd' was only saved in the primary process,
but for some devices this value is also used in the secondary logic.
For example, the call of 'rte_pci_find_ext_capability()' will fail in
the secondary process.
Fix this problem by getting and saving the value
From: Zerun Fu
For the primary process, the logic loops all BARs and will skip
the map of BAR with an invalid physical address (0), also will
assign 'uio_res->nb_maps' with the real mapped BARs number. But
for the secondary process, instead of loops all BARs, the logic
using the 'uio_res->nb_map'
From: Zerun Fu
To makes the logic clearer, rename the variable 'i' into 'map_idx'
and the variable 'j' into 'i'.
Signed-off-by: Zerun Fu
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/bus/pci/pci_common_uio.c | 30 +++---
1 file cha
This patch series aims to fix some problems in secondary process PCI UIO
resource map logic.
---
v2:
* Modify as the advice from reviewer.
v3:
* Modify logic as the comments of reviewers.
v4:
* Split the commits to make it easier to understand.
---
Zerun Fu (3):
bus/pci: rename the variable in
44 matches
Mail list logo
