答复: [PATCH v2] r8126: add r8126 ethernet poll mode driver

2024-06-17 Thread 王颢
Dear Stephen, Thank you for your suggestions, I will take them into consideration. Regarding the queue quantity issue, I apologize that we only support one queue at the moment. If there are any updates in the future, I will provide patches. Thanks! Howard Wang -邮件原件- 发件人: Stephen Hemmin

Re: [PATCH 09/19] net/ngbe: add WOL and NCSI capability

2024-06-17 Thread David Marchand
On Mon, Jun 17, 2024 at 11:54 AM Jiawen Wu wrote: > > Support WOL and NCSI capability for devices. And there is one OEM > NCSI NIC which can not be identified from sub-system ID, it needs > to check NCSI pin status in firmware. > > Signed-off-by: Jiawen Wu It looks like this series is truncated.

RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-17 Thread Suanming Mou
Hi Akhil, Any other suggestions regarding the series? BR, Suanming > -Original Message- > From: Suanming Mou > Sent: Friday, June 14, 2024 5:32 PM > To: Akhil Goyal ; Matan Azrad > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM > IPsec operation

RE: [PATCH] net: add bit fields to IPv6 header definition

2024-06-17 Thread Morten Brørup
> From: Gregory Etelson [mailto:getel...@nvidia.com] > Sent: Tuesday, 18 June 2024 07.18 > > DPDK IPv6 header definition combined the `version`, `traffic class` > and `flow label` header fields into a single 32 bits structure member > `vtc_flow`. > > The patch expands IPv6 header definition with

Minutes of DPDK Technical Board Meeting, 2024-05-29

2024-06-17 Thread Hemant Agrawal
Members Attending: 09/11 - Aaron Conole - Bruce Richardson - Hemant Agrawal (Chair) - Honnappa Nagarahalli - Jerin Jacob Kollanukkaran - Kevin Traynor - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon NOTE: Th

[PATCH] net: add bit fields to IPv6 header definition

2024-06-17 Thread Gregory Etelson
DPDK IPv6 header definition combined the `version`, `traffic class` and `flow label` header fields into a single 32 bits structure member `vtc_flow`. The patch expands IPv6 header definition with dedicated structure members for the `version`, `traffic class` and `flow label` fields. The patch also

RE: [PATCH v5] net/i40e: support FEC feature

2024-06-17 Thread Zeng, ZhichaoX
Hi Bruce, Kindly ping for review~ Thanks. Regards Zhichao > -Original Message- > From: Zeng, ZhichaoX > Sent: Thursday, April 11, 2024 5:30 PM > To: dev@dpdk.org > Cc: Medvedkin, Vladimir ; Cui, KaixinX > ; Zeng, ZhichaoX ; Yang, > Qiming ; Yuying Zhang > Subject: [PATCH v5] net/i40e:

Re: [PATCH] config: fix warning for cross build with meson >= 1.3.0

2024-06-17 Thread Ruifeng Wang
On 2024/6/17 11:14 PM, David Marchand wrote: Starting meson 1.3.0, the pkgconfig variable is deprecated in favor of pkg-config. Keep both variables as suggested in meson RN. Link: https://mesonbuild.com/Release-notes-for-1-3-0.html#machine-files-pkgconfig-field-deprecated-and-replaced-by-pkgc

Re: [PATCH v2] r8126: add r8126 ethernet poll mode driver

2024-06-17 Thread Stephen Hemminger
On Thu, 13 Jun 2024 11:39:29 +0800 Howard Wang wrote: > +static void > +rtl8126_sw_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats > *rte_stats) > +{ > + struct rtl8126_adapter *adapter = RTL8126_DEV_PRIVATE(dev); > + struct rtl8126_sw_stats *sw_stats = &adapter->sw_stats; > + > +

[PATCH v3] ethdev: Add link_speed lanes support

2024-06-17 Thread Damodharam Ammepalli
Update the eth_dev_ops structure with new function vectors to get, get capabilities and set ethernet link speed lanes. Update the testpmd to provide required config and information display infrastructure. The supporting ethernet controller driver will register callbacks to avail link speed lanes c

Re: [RFC PATCH v1 2/2] dts: Remove XML-RPC server for Scapy TG and instead us ScapyShell

2024-06-17 Thread Jeremy Spewock
On Tue, Jun 11, 2024 at 6:46 AM Juraj Linkeš wrote: > > > diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py > > b/dts/framework/testbed_model/traffic_generator/scapy.py > > index 5676235119..2b299ad02f 100644 > > --- a/dts/framework/testbed_model/traffic_generator/scapy.py > > +

[PATCH v2 3/3] dts: queue suite conf schema

2024-06-17 Thread Dean Marx
Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index 4731f4

[PATCH v2 2/3] dts: added promisc/verbose func to testpmd shell

2024-06-17 Thread Dean Marx
Setting the verbose mode and promiscuous mode is a common command in test suites, these additions will allow the dev to set both modes from the testpmd shell module. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 179 +- 1 file changed, 178 insertion

[PATCH v2 1/3] dts: initial queue start/stop suite implementation

2024-06-17 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 79 + 1 file changed, 79 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py di

[PATCH v2 0/3] dts: queue start/stop suite

2024-06-17 Thread Dean Marx
Queue start/stop suite ensures the Poll Mode Driver can functionally enable and disable Rx/Tx queues on ports. The suite contains two test cases: 1. All queues enabled - verifies that packets are received when all queues on all ports are enabled. 2. Queue start/stop - verifies that packets are not

Re: [RFC PATCH v1 1/2] dts: Add interactive shell for managing Scapy

2024-06-17 Thread Jeremy Spewock
On Tue, Jun 11, 2024 at 7:12 AM Juraj Linkeš wrote: > > > > diff --git a/dts/framework/remote_session/scapy_shell.py > > b/dts/framework/remote_session/scapy_shell.py > > new file mode 100644 > > index 00..fa647dc870 > > --- /dev/null > > +++ b/dts/framework/remote_session/scapy_shell.py

Re: [PATCH v3 0/3] VLAN Test Suite

2024-06-17 Thread Patrick Robb
For CI Testing: re-applying to main and retesting because main was in a bad state (now fixed by Maxime), causing a virtio_smoke fail on this series. https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28

Re: [PATCH] examples/fips_validation: fix coverity issues

2024-06-17 Thread Patrick Robb
For CI Testing: re-applying to main and retesting because main was in a bad state (now fixed by Maxime), causing a virtio_smoke fail on this series. https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28

Re: [PATCH v2 0/3] malloc related cleanups

2024-06-17 Thread Patrick Robb
For CI Testing: re-applying to main and retesting because main was in a bad state (now fixed by Maxime), causing a virtio_smoke fail on this series. https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28 On Sat, Jun 15, 2024 at 12:02 PM Stephen Hemminger wrote: > > The typ

Re: [PATCH v3 2/2] dts: clean up config types

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte

Re: [PATCH v3 1/2] dts: update mypy static checker

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 30, 2024 at 11:20 AM Luca Vizzarro wrote: > > Update the mypy static checker to the latest version and fix all the > reported errors. > > Bump up supported Poetry shell version. > > Bugzilla ID: 1433 > > Signed-off-by: Luca Viz

Re: [PATCH v5 8/8] dts: use Unpack for type checking and hinting

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Interactive shells that inherit DPDKShell initialise their params > classes from a kwargs dict. Therefore, static type checking is > disabled. This change uses the functionality of

Re: [PATCH v5 7/8] dts: rework interactive shells

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > The way nodes and interactive shells interact makes it difficult to > develop for static type checking and hinting. The current system relies > on a top-down approach, attempting to

Re: [PATCH v5 6/8] dts: use testpmd params for scatter test suite

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed

Re: [PATCH v5 5/8] dts: add testpmd shell params

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Implement all the testpmd shell parameters into a data structure. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > Reviewed-by: Juraj Linkeš > Reviewed-by: Jerem

Re: [PATCH v5 4/8] dts: remove module-wide imports

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Remove the imports in the testbed_model and remote_session modules init > file, to avoid the initialisation of unneeded modules, thus removing or > limiting the risk of circular dep

Re: [PATCH v5 3/8] dts: refactor EalParams

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Move EalParams to its own module to avoid circular dependencies. > Also the majority of the attributes are now optional. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczep

Re: [PATCH v5 2/8] dts: use Params for interactive shells

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > Make it so that interactive shells accept an implementation of `Params` > for app arguments. Convert EalParameters to use `Params` instead. > > String command line parameters can st

Re: [PATCH v5 1/8] dts: add params manipulation module

2024-06-17 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Mon, Jun 17, 2024 at 10:54 AM Luca Vizzarro wrote: > > This commit introduces a new "params" module, which adds a new way > to manage command line parameters. The provided Params dataclass > is able to read the fields of its child class

Re: [PATCH] config: fix warning for cross build with meson >= 1.3.0

2024-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2024 at 05:14:58PM +0200, David Marchand wrote: > Starting meson 1.3.0, the pkgconfig variable is deprecated in favor of > pkg-config. Keep both variables as suggested in meson RN. > > Link: > https://mesonbuild.com/Release-notes-for-1-3-0.html#machine-files-pkgconfig-field-deprec

[PATCH] config: fix warning for cross build with meson >= 1.3.0

2024-06-17 Thread David Marchand
Starting meson 1.3.0, the pkgconfig variable is deprecated in favor of pkg-config. Keep both variables as suggested in meson RN. Link: https://mesonbuild.com/Release-notes-for-1-3-0.html#machine-files-pkgconfig-field-deprecated-and-replaced-by-pkgconfig Cc: sta...@dpdk.org Signed-off-by: David M

Re: [PATCH] telemetry: lower log level on socket error

2024-06-17 Thread Stephen Hemminger
On Mon, 17 Jun 2024 15:52:09 +0100 Bruce Richardson wrote: > > > > > > Would it be also worthwhile having the probing process wait a small amount > > > of time or check for an input string before closing the socket? That > > > should > > > avoid the error message being necessary at all for the

Re: [PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [RFC PATCH v2] dts: skip test cases based on capabilities

2024-06-17 Thread Luca Vizzarro
On 12/06/2024 10:15, Juraj Linkeš wrote: On 11. 6. 2024 11:51, Luca Vizzarro wrote: While working on my blocklist patch, I've just realised I forgot to add another comment. I think it would be ideal to make capabilities a generic class, and NicCapability a child of this. When collecting capabi

Re: [PATCH v3 2/3] dts: Add missing docstring from XML-RPC server

2024-06-17 Thread Jeremy Spewock
On Fri, Jun 14, 2024 at 4:48 PM Nicholas Pratte wrote: > > Just a small nitpick. Otherwise: > > Reviewed-by: Nicholas Pratte > > > > class QuittableXMLRPCServer(SimpleXMLRPCServer): > > -"""Basic XML-RPC server. > > +r"""Basic XML-RPC server. > > > > The server may be augmented by

Re: [PATCH v3] dts: rename execution to test run

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v3 3/3] dts: Improve logging for interactive shells

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v3 2/3] dts: Add missing docstring from XML-RPC server

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v3 1/3] dts: Improve output gathering in interactive shells

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH] maintainers: remove cxgbe maintainer

2024-06-17 Thread Potnuri Bharat Teja
Thursday, June 06/13/24, 2024 at 19:42:40 +0530, David Marchand wrote: > Hello, > > On Thu, Jun 13, 2024 at 4:02 PM David Marchand > wrote: > > > > Hello Raju, > > > > On Thu, Jun 13, 2024 at 3:58 PM David Marchand > > wrote: > > > > > > It looks like Rahul left Chelsio (at least, his mail addr

Re: [PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v3 3/3] Config schema

2024-06-17 Thread Jeremy Spewock
I think maybe we could find a more descriptive name than just "vlan", but I wasn't able to think of any that weren't overly verbose. Also, we're just testing the basic features of a vlan in a pmd, so maybe it makes enough sense as is. On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote: > > Configur

Re: [PATCH] maintainers: remove cxgbe maintainer

2024-06-17 Thread David Marchand
Hello, On Mon, Jun 17, 2024 at 4:53 PM Potnuri Bharat Teja wrote: > > Thursday, June 06/13/24, 2024 at 19:42:40 +0530, David Marchand wrote: > > Hello, > > > > On Thu, Jun 13, 2024 at 4:02 PM David Marchand > > wrote: > > > > > > Hello Raju, > > > > > > On Thu, Jun 13, 2024 at 3:58 PM David Mar

[PATCH v5] lib/hash: add siphash

2024-06-17 Thread Stephen Hemminger
The existing hash functions in DPDK are not cryptographically secure and can be subject to carefully crafted packets causing DoS attack. Add SipHash which is a fast and cryptographicly sound hash created by Jean-Philippe Aumasson and Daniel J. Bernstein. Siphash is widely used by Linux, FreeBSD, O

Re: [PATCH v3 2/3] Initial implementation for VLAN test suite

2024-06-17 Thread Jeremy Spewock
On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote: > > Test suite for ensuring Poll Mode Driver can enable or disable > vlan filtering, stripping, and header insertion of packets sent on > a port. > > Signed-off-by: Dean Marx > --- > + > +class TestVlan(TestSuite): > +"""DPDK VLAN test suite.

[PATCH v5 8/8] dts: use Unpack for type checking and hinting

2024-06-17 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v5 7/8] dts: rework interactive shells

2024-06-17 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v5 6/8] dts: use testpmd params for scatter test suite

2024-06-17 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/tests/TestSuite_pmd_buffer_scatter.py |

[PATCH v5 5/8] dts: add testpmd shell params

2024-06-17 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/testpmd.py | 607 ++ dts/frame

[PATCH v5 4/8] dts: remove module-wide imports

2024-06-17 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spe

[PATCH v5 3/8] dts: refactor EalParams

2024-06-17 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Also the majority of the attributes are now optional. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/eal.py

[PATCH v5 2/8] dts: use Params for interactive shells

2024-06-17 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Revie

[PATCH v5 1/8] dts: add params manipulation module

2024-06-17 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v5 0/8] dts: add testpmd params

2024-06-17 Thread Luca Vizzarro
v5: - fixed typo v4: - fixed up docstrings - made refactoring changes - removed params value only - rebased on top of show port info/stats v3: - refactored InteractiveShell methods - fixed docstrings v2: - refactored the params module - strengthened typing of the params module - moved the params mo

Re: [PATCH] telemetry: lower log level on socket error

2024-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2024 at 07:39:43AM -0700, Stephen Hemminger wrote: > On Mon, 17 Jun 2024 15:28:17 +0100 > Bruce Richardson wrote: > > > On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > > > When starting two DPDK programs using the same DPDK prefix (like for > > > example OVS and

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

2024-06-17 Thread Stephen Hemminger
On Fri, 31 May 2024 10:41:18 -0700 Stephen Hemminger wrote: > This reverts commit 628362c94a0b567a39a0177539c12c97d999. > > That commit broke use of dumpcap with vdev's and probably > other uses of secondary processes with vdev as well. > > Bugzilla ID: 1450 > > Signed-off-by: Stephen Hemm

[PATCH v4 8/8] dts: use Unpack for type checking and hinting

2024-06-17 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v4 7/8] dts: rework interactive shells

2024-06-17 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v4 6/8] dts: use testpmd params for scatter test suite

2024-06-17 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte Tested-by: Nicholas Pratte --- dts/tests/TestSu

[PATCH v4 5/8] dts: add testpmd shell params

2024-06-17 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte Tested-by: Nicholas Pratte --- dts/framework/params/testpmd.py | 607 +

[PATCH v4 4/8] dts: remove module-wide imports

2024-06-17 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas

[PATCH v4 3/8] dts: refactor EalParams

2024-06-17 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Also the majority of the attributes are now optional. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte Tested-by: Nicholas Pratte ---

[PATCH v4 2/8] dts: use Params for interactive shells

2024-06-17 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Revie

[PATCH v4 1/8] dts: add params manipulation module

2024-06-17 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v4 0/8] dts: add testpmd params and statefulness

2024-06-17 Thread Luca Vizzarro
v4: - fixed up docstrings - made refactoring changes - removed params value only - rebased on top of show port info/stats v3: - refactored InteractiveShell methods - fixed docstrings v2: - refactored the params module - strengthened typing of the params module - moved the params module into its own

Re: [PATCH] telemetry: lower log level on socket error

2024-06-17 Thread Stephen Hemminger
On Mon, 17 Jun 2024 15:28:17 +0100 Bruce Richardson wrote: > On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > > When starting two DPDK programs using the same DPDK prefix (like for > > example OVS and testpmd, both running as primary processes in > > --in-memory mode), the first

Re: Coding Style for local variables

2024-06-17 Thread Bruce Richardson
On Mon, Jun 10, 2024 at 05:10:01PM +0200, Morten Brørup wrote: > The coding style guide says: > > "Variables should be declared at the start of a block of code rather than in > the middle. The exception to this is when the variable is const in which case > the declaration must be at the point of

Re: [PATCH v3 1/3] Added VLAN commands to testpmd_shell class

2024-06-17 Thread Jeremy Spewock
In the methods you added here, you made all of the parameters to them optional with a default. This might make sense to allow developers to be less verbose when calling the method with the defaults, but in the case of things like the port ID, vlan IDs, and things of that nature I think making these

Re: [PATCH] eal: fix logs for '--lcores'

2024-06-17 Thread David Marchand
On Thu, Jun 13, 2024 at 6:20 PM David Marchand wrote: > On Thu, Jun 13, 2024 at 6:14 PM Kevin Traynor wrote: > > > > The argument is '--lcores' but it is being logged as '--lcore' > > in several places. > > > > e.g. > > $ dpdk-testpmd -l 8,10,12 --lcores 8,10,12 > > EAL: Option --lcore is ignored

Re: [PATCH v3 0/3] VLAN Test Suite

2024-06-17 Thread Jeremy Spewock
Hey Dean, Thanks for the series! One thing that caught my eye which I figured I'd mention here since it applies to all the commits is that generally with patches submitted to the dev mailing list the subject lines of the commits should include the component that the commit is relevant to. In our c

[PATCH] doc/guides: fix link to internal hugepage doc

2024-06-17 Thread David Marchand
As reported by Alessio, the link to the hugepage mapping page is broken. Fixes: 979bb5d493fb ("doc: add more instructions for running as non-root") Cc: sta...@dpdk.org Reported-by: Alessio Igor Bogani Signed-off-by: David Marchand --- .mailmap | 1 + doc/guides/linu

Re: [PATCH] telemetry: lower log level on socket error

2024-06-17 Thread Bruce Richardson
On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > When starting two DPDK programs using the same DPDK prefix (like for > example OVS and testpmd, both running as primary processes in > --in-memory mode), the first DPDK process of the two spews some error > log when the second starts

Re: [PATCH] vhost: fix FD registration to the fdset

2024-06-17 Thread David Marchand
On Mon, Jun 17, 2024 at 12:13 PM Maxime Coquelin wrote: > > A missing return statement in fdset_add() was making > the error path to be systematically executed, this patch > adds it back. > > Bugzilla ID: 1462 > Fixes: 0e38b42bf61c ("vhost: manage FD with epoll") It looks like the initial code wa

[PATCH] vhost: Fix the crash caused by accessing the released memory

2024-06-17 Thread zhaoxinxin
The rte_vhost_driver_unregister() 、vhost_user_read_cb()、vhost_user_client_reconnect() can be called at the same time by 3 threads. when memory of vsocket is freed in rte_vhost_driver_unregister(), then vhost_user_read_cb() maybe add vsocket to reconn_list, the invalid memory of vsocket is acces

RE: [PATCH] app/testpmd: fix parsing for connection tracking item

2024-06-17 Thread Maayan Kashani
Sure, This is an example of using connection tracking with testpmd: start set verbose 1 set conntrack com peer 1 is_orig 1 enable 1 live 1 sack 1 cack 0 last_dir 0 liberal 0 state 1 max_ack_win 7 r_lim 5 last_win 510 last_seq 2632987379 last_ack 2532480967 last_end 2632987379 last_index

[PATCH 2/2] net/mlx5: fix non-template IPv6 RSS hash

2024-06-17 Thread Gregory Etelson
MLX5 HW prioritizes IPv4 hash over IPv6 in TIR setup. If TIR was configured to hash both IPv4 and IPv6 the MLX5 HW will use IPv4 hash even if packet matched IPv6 flow item. The patch removes IPv4 hash from RSS action configuration if flow rule matched IPV6 item in the non-template PMD setup. Fixe

[PATCH 1/2] net/mlx5: refactor non-template RSS expansion

2024-06-17 Thread Gregory Etelson
The current PMD handled non-template RSS expansion in the `flow_nta_handle_rss()` function. The function returned flow handle for expanded RSS flow rule or NULL if there was no RSS expansion. The NULL result with non-zero rte_errno value pointed to an error during RSS expansion. If rte_errno value

[PATCH 0/2] fix non-template IPv6 RSS hash

2024-06-17 Thread Gregory Etelson
Gregory Etelson (2): net/mlx5: refactor non-template RSS expansion net/mlx5: fix non-template IPv6 RSS hash drivers/net/mlx5/mlx5_flow_hw.c | 6 +- drivers/net/mlx5/mlx5_nta_rss.c | 99 - 2 files changed, 85 insertions(+), 20 deletions(-) Acked-by: Dariusz S

[PATCH] net/mlx5: fix HWS VXLAN item validation

2024-06-17 Thread Gregory Etelson
HWS can match entire VXLAN, VXLAN-GPE and VXLAN-GBP headers. No need for mask validation. Fixes: 113feae56db6 ("net/mlx5: validate HWS template items") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 21 +++-- 1 file changed, 11 inse

Re: [PATCH v15 0/6] add pointer compression API

2024-06-17 Thread David Marchand
On Mon, Jun 17, 2024 at 3:47 PM Paul Szczepanek wrote: > This will solve it: > > diff --git a/lib/ptr_compress/rte_ptr_compress.h > b/lib/ptr_compress/rte_ptr_compress.h > index b9ab17b2db..a779f21fda 100644 > --- a/lib/ptr_compress/rte_ptr_compress.h > +++ b/lib/ptr_compress/rte_ptr_compress.h >

Re: [PATCH v15 0/6] add pointer compression API

2024-06-17 Thread Paul Szczepanek
On 17/06/2024 11:02, David Marchand wrote: > Hello Paul, > > On Fri, Jun 14, 2024 at 12:28 PM David Marchand > wrote: >> Even if this library only contains a header, with no tie to other >> public DPDK API, this library should be optional. >> If no objection, please work on this change for -rc

Re: [PATCH v3 7/8] dts: rework interactive shells

2024-06-17 Thread Luca Vizzarro
On 06/06/2024 19:03, Juraj Linkeš wrote: +class DPDKShell(InteractiveShell, ABC): +    """The base class for managing DPDK-based interactive shells. + +    This class shouldn't be instantiated directly, but instead be extended. +    It automatically injects computed EAL parameters based on the

Re: [PATCH v2 1/8] dts: add params manipulation module

2024-06-17 Thread Luca Vizzarro
On 06/06/2024 10:19, Juraj Linkeš wrote: The static method in the other patch is called compose and does essentially the same thing, right? Can we use the same name (or a similar one)? Also, what is the difference in approaches between the two patches (or, more accurately, the reason behind t

[dpdk-dev] [PATCH] common/cnxk: fix flow aging application exit

2024-06-17 Thread psatheesh
From: Kiran Kumar K If flow aging is enabled application termination may take time equivalent to aging timeout. This is because on termination flow thread uses a sleep call which is uninterruptible. Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Kiran

[PATCH] vhost: fix FD registration to the fdset

2024-06-17 Thread Maxime Coquelin
A missing return statement in fdset_add() was making the error path to be systematically executed, this patch adds it back. Bugzilla ID: 1462 Fixes: 0e38b42bf61c ("vhost: manage FD with epoll") Reported-by: Jiang Yu Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 1 + 1 file changed, 1

Re: [PATCH v15 0/6] add pointer compression API

2024-06-17 Thread David Marchand
Hello Paul, On Fri, Jun 14, 2024 at 12:28 PM David Marchand wrote: > Even if this library only contains a header, with no tie to other > public DPDK API, this library should be optional. > If no objection, please work on this change for -rc2, We have a build error on armv7 (tested in OBS). https

[PATCH 08/19] net/ngbe: keep PHY power down while device probing

2024-06-17 Thread Jiawen Wu
The internal PHY will be set to default power down after LAN reset, but the external PHY will not. To keep the PHY behavior consistent, set PHY power down uniformly here. Fixes: 708ebe7d0399 ("net/ngbe: fix external PHY power down") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/n

[PATCH 09/19] net/ngbe: add WOL and NCSI capability

2024-06-17 Thread Jiawen Wu
Support WOL and NCSI capability for devices. And there is one OEM NCSI NIC which can not be identified from sub-system ID, it needs to check NCSI pin status in firmware. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_hw.c | 30 ++-- drivers/net/ngbe/base/ngb

[PATCH 07/19] net/ngbe: special config for YT8531SH-CA PHY

2024-06-17 Thread Jiawen Wu
YT8531SH-CA PHY will switch to SDS space automatically when UTP and SDS media are not present, causing failure to link up. Add the special configuration to fix it. Fixes: 3d0af7066759 ("net/ngbe: setup PHY link") Fixes: 1c44384fce76 ("net/ngbe: support custom PHY interfaces") Cc: sta...@dpdk.org

[PATCH 06/19] net/txgbe: fix VF promiscuous and allmulticast

2024-06-17 Thread Jiawen Wu
The configuration of allmulti and promiscuous modes conflicts together. For instance, if we enable promiscuous mode, then enable and disable allmulti, then the promiscuous mode is wrongly disabled. Fix this behavior by: - doing nothing when we set/unset allmulti if promiscuous mode is on - restort

[PATCH 05/19] net/txgbe: reconfigure more MAC Rx registers

2024-06-17 Thread Jiawen Wu
When link status changes, there is a probability that no more packets can be received on the port, due to hardware defects. These MAC Rx registers should be reconfigured to fix this problem. Fixes: 950a6954df13 ("net/txgbe: reconfigure MAC Rx when link update") Cc: sta...@dpdk.org Signed-off-by:

[PATCH 04/19] net/txgbe: restrict the configuration of VLAN strip offload

2024-06-17 Thread Jiawen Wu
There is a hardware limitation that Rx ring config register is not writable when Rx ring is enabled, i.e. the TXGBE_RXCFG_ENA bit is set. But disabling the ring when there is traffic will cause ring get stuck. So restrict the configuration of VLAN strip offload only if device is started. Fixes: 22

[PATCH 03/19] net/txgbe: fix Tx hang on queue disable

2024-06-17 Thread Jiawen Wu
The problem of Tx hang also occurs on Wangxun 10Gb NICs, when stop device under heavy traffic. refer to commit ac6c5e9af56a ("net/ngbe: fix Tx hang on queue disable") Disable PCIe bus master to clear BME when stop hardware, and verify there are no pending requests. Move disabling Tx queue after d

[PATCH 02/19] net/txgbe: fix flow filters in VT mode

2024-06-17 Thread Jiawen Wu
In virtualization mode, target pool should be determined for the filters. For ether type filter, virtualization mode must be enabled to filter broadcast/multicast packets due to hardware limitations. Fixes: f8e2cfc7702b ("net/txgbe: support ethertype filter add and delete") Fixes: 77a72b4d9dc0 ("n

[PATCH 01/19] net/txgbe: fix to parse tunnel packets

2024-06-17 Thread Jiawen Wu
The outer-ipv6 tunnel packet was parsed to the wrong packet type, remove the default RTE_PTYPE_L2_ETHER and RTE_PTYPE_L3_IPV4 flags for tunnel packets. And correct the calculation of tunnel length for GRE and GENEVE packets. Fixes: ca46fcd753b1 ("net/txgbe: support Tx with hardware offload") Fixes

RE: [PATCH 0/7] Improvements and new test cases

2024-06-17 Thread Anoob Joseph
> > Adding new test cases and improvements to test application. > > Aakash Sasidharan (4): > test/crypto: add combined mode cases for TLS 1.3 > test/security: add TLS 1.3 data walkthrough tests > test/security: add out of place sgl tests for TLS > test/security: use single session in data

RE: [PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info

2024-06-17 Thread Slava Ovsiienko
Hi, Igor Thank you for the patch. 1. The absolute max descriptor number supported by ConnectX hardware is 32768. 2. The actual max descriptor number supported by the port (and its related representors) reported in log_max_wq_sz in HCA.caps. This value should be queried and save in mlx5_dev

RE: [PATCH v1 0/4] test/crypto: enhance modex tests

2024-06-17 Thread Anoob Joseph
> > This patch series enhances modex tests to: > * use common test function in existing test vectors > * add test for zero padded operands > > Gowrishankar Muthukrishnan (4): > test/crypto: validate modex result from first nonzero value > test/crypto: remove unused variable in modex test da

  1   2   >