RE: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-10 Thread Ori Kam
> -Original Message- > From: rongwei liu > Sent: Friday, June 7, 2024 5:02 PM > > The field string should be in the same order as the rte_flow_field_id > enumration definitions > > Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") > Cc: michae...@nvidia.com > Cc: sta..

[PATCH v3] mempool: dump includes list of memory chunks

2024-06-10 Thread Morten Brørup
Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Acked-by: Paul Szczepanek Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev --- v3: * Fix output indentation. * Print in existing lo

[PATCH v2] mempool: dump includes list of memory chunks

2024-06-10 Thread Morten Brørup
Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Acked-by: Paul Szczepanek Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev --- v2: * Dump one line per entry. Remove headline and i

[PATCH v2] mempool: dump includes list of memory chunks

2024-06-10 Thread Morten Brørup
Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Acked-by: Paul Szczepanek Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev --- v2: * Dump one line per entry. Remove headline and i

Re: [PATCH] maintainers: update email address for PPC

2024-06-10 Thread David Marchand
Hello, On Mon, Jun 10, 2024 at 5:37 PM David Christensen wrote: > > Modify email address to route email traffic through different > internal email servers. Please update .mailmap too. -- David Marchand

RE: Multiple paramters of input and output in DPDK-BBdev

2024-06-10 Thread Chautru, Nicolas
Hi, Multiple input/output in test vector is not for multiple code blocks, but as an option for scatter-gather (data split into 2 pointers for instance for same code block, ie. not contiguous in memory). If you want to do 2 code blocks, these would be 2 independent operations and not what you are

[PATCH v2] net/mana: fix uninitialized scalar variable

2024-06-10 Thread mmaatuq
in case we didn't enter or finished the loop without getting ifname we ret shouldn't have an arbitrary value. Coverity issue: 424690 Signed-off-by: mmaatuq --- v2: Fixed typo in word "arbitrary" --- drivers/net/mana/mana.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

RE: Input length paramter in DPDK-BBdev

2024-06-10 Thread Chautru, Nicolas
Hi, What MCS/code allocation did you use to create such code block? I would expect that from 3gpp specs, all TB size would end up being a multiple of 8 bits. Thanks, Nic From: Avijit Pandey Sent: Thursday, June 6, 2024 3:33 AM To: dev@dpdk.org Cc: Chautru, Nicolas Subject: Input length paramter

[PATCH] net/mana: fix uninitialized scalar variable

2024-06-10 Thread mmaatuq
in case we didn't enter or finished the loop without getting ifname we ret shouldn't have an arbitray value. Coverity issue: 424690 Signed-off-by: mmaatuq --- drivers/net/mana/mana.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/m

Re: [PATCH v1] dts: Initial vlan test suite implementation

2024-06-10 Thread Patrick Robb
Thanks Dean. I see there is some personal configuration you have included from the conf.yaml. You can drop that and resubmit the patch. Also if you can add a cover letter which briefly explains the vlan functions the testsuite aims to provide coverage for, I think that will help give people on th

[PATCH v1] dts: Initial vlan test suite implementation

2024-06-10 Thread Dean Marx
This test suite asserts the functionality of vlan filtering, stripping, and insertion on the poll mode driver. It consists of four test cases, which are all based off old DTS test plans, but are modified to account for framework changes. Bugzilla ID: 1453 Signed-off-by: Dean Marx --- dts/conf.y

Re: [PATCH v3 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-10 Thread Jeremy Spewock
On Mon, Jun 10, 2024 at 11:22 AM Juraj Linkeš wrote: > > > diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py > > b/dts/tests/TestSuite_pmd_buffer_scatter.py > > index 41f6090a7e..76eabb51f6 100644 > > --- a/dts/tests/TestSuite_pmd_buffer_scatter.py > > +++ b/dts/tests/TestSuite_pmd_buffer_sc

Re: [PATCH v3 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-10 Thread Jeremy Spewock
On Mon, Jun 10, 2024 at 11:03 AM Juraj Linkeš wrote: > > > > On 5. 6. 2024 23:31, jspew...@iol.unh.edu wrote: > > From: Jeremy Spewock > > > > There are methods within DTS currently that support updating the MTU of > > ports on a node, but the methods for doing this in a linux session rely > > on

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-10 Thread Jeremy Spewock
Overall, my thoughts are that it's definitely an interesting idea to make the normal shell subclass the critical. I explain more below, but basically I think it makes sense as long as we are fine with the normal shells having a context manager which likely won't really be used since it doesn't real

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
> -def load_config(config_file_path: Path) -> Configuration: > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> > Configuration: > """Load DTS test run configuration from a file. > > -Load the YAML test run configuration file > +Load both the YAML testbe

[PATCH v1] dts: Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
This implementation splits the execution and node configuration components of the conf.yaml into two separate config files. A new command line argument is added, allowing the user to specify both a node configuration file and an execution configuration file. Be default, these config files are now n

Re: [PATCH v3 1/4] dts: improve starting and stopping interactive shells

2024-06-10 Thread Jeremy Spewock
On Mon, Jun 10, 2024 at 9:36 AM Juraj Linkeš wrote: > > > diff --git a/dts/framework/remote_session/interactive_shell.py > > b/dts/framework/remote_session/interactive_shell.py > > index 5cfe202e15..921c73d9df 100644 > > --- a/dts/framework/remote_session/interactive_shell.py > > +++ b/dts/framew

Re: [PATCH v1] Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
On Mon, Jun 10, 2024 at 3:00 PM Nicholas Pratte wrote: > > > -def load_config(config_file_path: Path) -> Configuration: > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> > Configuration: > """Load DTS test run configuration from a file. > > -Load the YAML

[PATCH v1] Testbed And Node Configuration Split

2024-06-10 Thread Nicholas Pratte
This implementation splits the execution and node configuration components of the conf.yaml into two separate config files. A new command line argument is added, allowing the user to specify both a node configuration file and an execution configuration file. Be default, these config files are now n

RE: Coding Style for local variables

2024-06-10 Thread Konstantin Ananyev
> The coding style guide says: > > "Variables should be declared at the start of a block of code rather than in > the middle. The exception to this is when the variable is > const in which case the declaration must be at the point of first > use/assignment. Declaring variable inside a for loo

RE: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Konstantin Ananyev
Hi Morten, > > > Added information about the memory chunks holding the objects in the > > > mempool when dumping the status of the mempool to a file. > > > > > > Signed-off-by: Morten Brørup > > > --- > > > lib/mempool/rte_mempool.c | 10 ++ > > > 1 file changed, 10 insertions(+) > > >

Re: Coding Style for local variables

2024-06-10 Thread Tyler Retzlaff
On Mon, Jun 10, 2024 at 05:10:01PM +0200, Morten Brørup wrote: > The coding style guide says: > > "Variables should be declared at the start of a block of code rather than in > the middle. The exception to this is when the variable is const in which case > the declaration must be at the point of

RE: [PATCH v14 3/6] ptr_compress: add pointer compression library

2024-06-10 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 10 June 2024 17.19 > > Hello, > > On Fri, Jun 7, 2024 at 5:10 PM Paul Szczepanek > wrote: > > > > Add a new utility header for compressing pointers. The provided > > functions can store pointers as 32-bit or 16-bit offsets

Can rte_eth_tx_burst frees buffer to external cache which could be configured during rte_eth_tx_queue_setup

2024-06-10 Thread Syed Intekhab Anjum
Hi, Does DPDK support to free the transmitted buffers to external cache which is provided during tx queue configurations (rte_eth_tx_queue_setup). This is needed to extract better performance when multiple tx queues are being worked on by unregistered non-eal pthreads which sends the packets (mbu

[PATCH] maintainers: update email address for PPC

2024-06-10 Thread David Christensen
Modify email address to route email traffic through different internal email servers. Signed-off-by: David Christensen --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c9adff9846..ecc06c1216 100644 --- a/MAINTAINERS +++ b/MAINTAI

答复: [PATCH] r8126: add r8126 ethernet poll mode driver

2024-06-10 Thread 王颢
Dear Stephen, We will fix the issues and resubmit as soon as possible. Thanks! Howard Wang -邮件原件- 发件人: Stephen Hemminger 发送时间: 2024年5月29日 5:34 收件人: 王颢 抄送: dev@dpdk.org; Howard Wang 主题: Re: [PATCH] r8126: add r8126 ethernet poll mode driver External mail. Went to apply this to rev

答复: [PATCH] r8125: add r8125 ethernet poll mode driver

2024-06-10 Thread 王颢
Dear Stephen, The r8125 and r8126pmd are in one-to-one correspondence with the Realtek Linux kernel drivers r8125 and r8126, respectively. Keeping them separate is beneficial for future maintenance. The purpose of this submission is to integrate them into DPDK. If there is an opportunity in the

Re: [PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-10 Thread Juraj Linkeš
On 10. 6. 2024 17:20, Nicholas Pratte wrote: The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Bugzilla

Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-10 Thread Juraj Linkeš
On 10. 6. 2024 17:20, Nicholas Pratte wrote: The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended

Re: [PATCH v3 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-10 Thread Juraj Linkeš
diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_pmd_buffer_scatter.py index 41f6090a7e..76eabb51f6 100644 --- a/dts/tests/TestSuite_pmd_buffer_scatter.py +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py @@ -86,12 +99,15 @@ def scatter_pktgen_send_packet(self, pktsiz

[PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-10 Thread Nicholas Pratte
The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Bugzilla ID: 1370 Signed-off-by: Nicholas Pratte Reviewed

[PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-10 Thread Nicholas Pratte
The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended during runtime. This new implementation allows on

[PATCH v9 0/2] Methodology change for hugepage configuration

2024-06-10 Thread Nicholas Pratte
In order to prevent accidental misconfiguration of hugepages at runtime, the following changes are made to only allow for configuration of 2MB hugepages within the DTS config.yaml. In the previous implementation, a default hugepage size was selected via the size listed in /proc/meminfo. The problem

Re: [PATCH v14 3/6] ptr_compress: add pointer compression library

2024-06-10 Thread David Marchand
Hello, On Fri, Jun 7, 2024 at 5:10 PM Paul Szczepanek wrote: > > Add a new utility header for compressing pointers. The provided > functions can store pointers as 32-bit or 16-bit offsets. > > The compression takes advantage of the fact that pointers are > usually located in a limited memory regi

Coding Style for local variables

2024-06-10 Thread Morten Brørup
The coding style guide says: "Variables should be declared at the start of a block of code rather than in the middle. The exception to this is when the variable is const in which case the declaration must be at the point of first use/assignment. Declaring variable inside a for loop is OK." Sin

Re: [PATCH v3 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-10 Thread Juraj Linkeš
On 5. 6. 2024 23:31, jspew...@iol.unh.edu wrote: From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test su

RE: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Monday, 10 June 2024 15.45 > > > Added information about the memory chunks holding the objects in the > > mempool when dumping the status of the mempool to a file. > > > > Signed-off-by: Morten Brørup > > --- > > lib/mempo

Re: [PATCH v2 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-10 Thread Juraj Linkeš
On 31. 5. 2024 23:08, Jeremy Spewock wrote: On Fri, May 31, 2024 at 12:34 PM Luca Vizzarro wrote: Due to the nature of this patch the console is spammed with a lot of commands. Would it be better to log these in debug and instead log: Setting port X to MTU as INFO? Potentially, b

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

2024-06-10 Thread Juraj Linkeš
It seems to me the patch would benefit from Luca's testpmd changes, mainly how the Shell is created. Not sure if we actually want to do that with this series, but it sound enticing. diff --git a/dts/framework/remote_session/critical_interactive_shell.py b/dts/framework/remote_session/critical

Re: [PATCH 4/5] fib: properly include vector API header file

2024-06-10 Thread Tyler Retzlaff
On Wed, Jun 05, 2024 at 08:49:44AM +0200, Mattias Rönnblom wrote: > The trie implementation of the fib library relied on , but > failed to provide a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 3/5] distributor: properly include vector API header file

2024-06-10 Thread Tyler Retzlaff
On Wed, Jun 05, 2024 at 08:49:43AM +0200, Mattias Rönnblom wrote: > The distributor library relied on , but failed to provide > a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Tyler Retzlaff

RE: [PATCH v14 2/6] mempool: add functions to get extra mempool info

2024-06-10 Thread Konstantin Ananyev
> Add two functions: > - rte_mempool_get_mem_range - get virtual memory range > of the objects in the mempool, > - rte_mempool_get_obj_alignment - get alignment of > objects in the mempool. > > Add two tests that test these new functions. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Jack

RE: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-06-10 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Monday, 10 June 2024 15.40 > > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > > In the case where the size is known to be 16 at build time, omit the > > duplicate copy. > > > > Reduced the amount o

RE: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Konstantin Ananyev
> Added information about the memory chunks holding the objects in the > mempool when dumping the status of the mempool to a file. > > Signed-off-by: Morten Brørup > --- > lib/mempool/rte_mempool.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/mempool/rte_mempool.c

RE: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-06-10 Thread Konstantin Ananyev
> When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > In the case where the size is known to be 16 at build time, omit the > duplicate copy. > > Reduced the amount of effectively copy-pasted code by using #ifdef > inside functions instead of outside functions. > > Suggested-

Re: [PATCH v3 1/4] dts: improve starting and stopping interactive shells

2024-06-10 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/framework/remote_session/interactive_shell.py index 5cfe202e15..921c73d9df 100644 --- a/dts/framework/remote_session/interactive_shell.py +++ b/dts/framework/remote_session/interactive_shell.py @@ -32,6 +34,10 @@ class Interacti

Re: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Andrew Rybchenko
On 5/16/24 11:59, Morten Brørup wrote: Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Reviewed-by: Andrew Rybchenko

RE: [PATCH] mempool: dump includes list of memory chunks

2024-06-10 Thread Morten Brørup
PING (again) for review. It's only 10 lines of very simple code to dump some info. And it follows existing dump conventions. -Morten > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 16 May 2024 11.00 > > Added information about the memory chunks holding the objects in

RE: [PATCH v8] eal/x86: improve rte_memcpy const size 16 performance

2024-06-10 Thread Morten Brørup
PING for review. The CI failures can be ignored: Most of the CI doesn't support the Depends-on tag, and this patch uses __rte_constant(), provided by Tyler's patch series [1]. [1]: https://inbox.dpdk.org/dev/1710970416-27841-1-git-send-email-roret...@linux.microsoft.com/ -Morten > From: Morte

RE: [PATCH v7] mempool: test performance with larger bursts

2024-06-10 Thread Morten Brørup
PING (again) for review. Many applications use bursts of more than 32 packets, and some applications buffer more than 512 packets. This patch updates the mempool perf test accordingly. -Morten > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 4 April 2024 11.27 > > PI

[PATCH v5 6/6] net/mlx5: support FDB in non-template mode

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Support non-template flows API in FDB mode: dpdk-testpmd -a $PCI,dv_flow_en=2,representor=vf0-1 -- -i testpmd> flow create 0 group 0 transfer \ pattern eth / end \ actions count / drop / end Signed-off-by: Gregory Etelson Acked-by: Dariusz Sos

[PATCH v5 5/6] net/mlx5: update HWS ASO actions validation

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson HWS ASO actions validation required PMD to allocate resources during the port configuration, before the action validation was called. That approach does not work in the HWS non-template setup, because non-template setup does not have explicit port configuration procedure an

[PATCH v5 4/6] net/mlx5: update ASO resources in non-template setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Non-template PMD implementation allocates ASO flow actions resources on-demand. Current PMD implementation iterated over actions array in search for actions that required ASO resources allocations. The patch replaced the iteration with actions flags bitmap queries. Signed

[PATCH v5 3/6] net/mlx5: support indirect actions in non-template setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Add support for the RSS, AGE, COUNT and CONNTRACK indirect flow actions for the non-template flow rules. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 111 +--- 1 file changed, 89 insertions(+

[PATCH v5 2/6] net/mlx5: support RSS expansion in non-template HWS setup

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson The MLX5 PMD expands flow rule with the RSS action in the non-template environment. The patch adds RSS flow rule expansion for legacy flow rules in the template setup. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_definer.c |

[PATCH v5 1/6] net/mlx5: update NTA rule pattern and actions flags

2024-06-10 Thread Maayan Kashani
From: Gregory Etelson Move pattern flags bitmap to flow_hw_list_create. Create actions flags bitmap in flow_hw_list_create. PMD uses pattern and actions bitmaps for direct queries instead of iterating arrays. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx

Re: [PATCH v7 01/11] net/mlx5: initial design of non template to hws

2024-06-10 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Sunday, June 9, 2024 2:00 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH v7 01/11] net/mlx5: initial design of non template to hws Implement the frame and needed buil

Re: [PATCH v4 0/3] HWS non-template support

2024-06-10 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Thursday, June 6, 2024 1:31 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh Subject: [PATCH v4 0/3] HWS non-template support Initial coding to support non-template in mlxdr layer. Yevgeny Kliteynik (3): net/mlx5/hws: split the root ru

Re: [PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

2024-06-10 Thread Dooley, Brian
Recheck-request: iol-unit-amd64-testing From: Dooley, Brian Sent: Wednesday, June 5, 2024 9:48 AM To: Ji, Kai ; De Lara Guarch, Pablo Cc: dev@dpdk.org ; gak...@marvell.com ; Dooley, Brian Subject: [PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

Re: [PATCH v9 2/2] dts: Change hugepage 'amount' to a different term

2024-06-10 Thread Juraj Linkeš
On 7. 6. 2024 16:59, Nicholas Pratte wrote: The term 'amount' is used for uncountable nouns. Since total hugepages is a discrete value (i.e. countable), the declaration of the 'amount' key value pair should be changes to a different term in both the config and the rest of the code. Bugzilla I

Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-10 Thread Juraj Linkeš
On 7. 6. 2024 16:59, Nicholas Pratte wrote: The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended