[PATCH 2/2] net/bonding: add command to set dedicated queue size

From: Long Wu The testpmd application can not modify the value of dedicated hardware Rx/Tx queue size, and hardcoded them as (128/512). This will cause the bonding port start fail if some NIC requires more Rx/Tx descriptors than the hardcoded number. Therefore, add a command into testpmd applica

[PATCH 1/2] net/bonding: standard the log message

From: Long Wu According to the check rules in the patch check script, drivers and libraries must use the logging framework. So standard the log message of bonding driver by using the logging framework. Signed-off-by: Long Wu Reviewed-by: Peng Zhang Reviewed-by: Chaoyong He --- drivers/net/b

[PATCH 0/2] add function to set dedicated queue size

This patch series mainly add a function to bonding PMD to set dedicated queue size, also add a command to testpmd application to invoke this function. At the same time, standard the log message of bonding PMD. Long Wu (2): net/bonding: standard the log message net/bonding: add command to set

RE: [PATCH v4] net/cpfl: get running host ID for CPFL PMD

> + if (uname(&unamedata) != 0) > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n"); > + else if (strstr(unamedata.nodename, "ipu-imc")) > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be running on IMC."); > + else if (strstr(unamedata.nodename, "ipu-acc")) > +

[PATCH] net/mlx5: validate HWS template items

HWS item validation scheme is based on existing DV items validation. Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- Depends-on: series-32045 ("validate actions in HWS table") --- drivers/net/mlx5/linux/mlx5_flow_os.c | 21 +- drivers/net/mlx5/linux/mlx5_flow_os.h | 9 +-

Re: [PATCH v4 3/3] event/dlb2: enhance DLB credit handling

On Tue, Jun 4, 2024 at 11:52 PM Sevincer, Abdullah wrote: > > > > >+This new patch is full of compilation flags clutter, can you make it > >runtime? > Thanks for the reviews Jerin, we can make it run time but it will cost more > cycles and new APIs in the PMD to set those run time params. The re

[DPDK/DTS Bug 1453] Port over VLAN TestSuite

https://bugs.dpdk.org/show_bug.cgi?id=1453 Bug ID: 1453 Summary: Port over VLAN TestSuite Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

Re: [EXTERNAL] [PATCH v2 1/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

On May 30, 2024, at 8:02 AM, Akhil Goyal wrote: diff --git a/drivers/common/ionic/ionic_common_uio.c b/drivers/common/ionic/ionic_common_uio.c index e5c73faf96..c647b22eaf 100644 --- a/drivers/common/ionic/ionic_common_uio.c +++ b/drivers/common/ionic/ionic_common_uio.c @@ -23,10 +23,12 @@ #de

Re: [EXTERNAL] [PATCH v2 3/9] crypto/ionic: add device commands

> On Jun 1, 2024, at 9:57 AM, Akhil Goyal wrote: > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > >> Subject: [EXTERNAL] [PATCH v2 3/9] crypto/ionic: add device commands >> >> This defines the dev

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

BR Rongwei From: Thomas Monjalon Sent: Wednesday, June 5, 2024 2:37 To: rongwei liu ; Dariusz Sosnowski Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re:

Last 16 hours for CFP Submissions - DPDK APAC Summit 2024 - Get Your Submissions in Soon,

Dear DPDK Community, As you may already know, CFP submissions for the 2024 DPDK APAC Summit in Bangkok, Thailand end *tomorrow* at 9:59 am Pacific time/12:59pm Eastern Time/1859h Central European Summer Time and 11:59pm Bangkok Time. Again, we would encourage you to submit and invite anyone else

[PATCH] net/mlx5: add queue hardware object context dump

Add debug capability to mlx5 PMD to dump SQ/RQ/CQ HW object context for a given port/queue. The context dump can provide some real-time information on cause of certain Tx/Rx Failures. Signed-off-by: Kiran Vedere --- .mailmap | 1 + doc/guides/nics/mlx5.rst

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

04/06/2024 18:40, Dariusz Sosnowski: > > > 04/06/2024 14:38, Rongwei Liu: > > > > --- a/app/test-pmd/cmdline_flow.c > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = { > > > > "ipv6_flow_label", "ipv6_traffic_class", > > > >

RE: [PATCH v4 3/3] event/dlb2: enhance DLB credit handling

>+This new patch is full of compilation flags clutter, can you make it runtime? Thanks for the reviews Jerin, we can make it run time but it will cost more cycles and new APIs in the PMD to set those run time params. The reason we do it this way is to save cycles also not to make cli params lon

RE: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

> > 04/06/2024 14:38, Rongwei Liu: > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = { > > > "ipv6_flow_label", "ipv6_traffic_class", > > > "esp_spi", "esp_seq_num", "esp_proto", > > >

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 23:03 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Aman Singh ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [

[PATCH v2] eventdev/crypto: restore opaque field between dequeue and enqueue

For session-less crypto operations, event info is contained in crypto op metadata for each event which is restored in event from the crypto op metadata response info. For session based crypto operations, crypto op contains per session based event info in crypto op metadata. If any PMD passes any i

Re: [PATCH v4] net/cpfl: get running host ID for CPFL PMD

On Thu, 30 May 2024 09:39:58 + Shaiq Wani wrote: > + if (uname(&unamedata) != 0) > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n"); > + else if (strstr(unamedata.nodename, "ipu-imc")) > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be running on IMC."); > +

[PATCH v2] eventdev/crypto: restore opaque field between dequeue and enqueue

For session-less crypto operations, event info is contained in crypto op metadata for each event which is restored in event from the crypto op metadata response info. For session based crypto operations, crypto op contains per session based event info in crypto op metadata. If any PMD passes any i

[PATCH v1] eventdev/crypto: restore opaque field between dequeue and enqueue

For session-less crypto operations, event info is contained in crypto op metadata for each event which is restored in event from the crypto op metadata response info. For session based crypto operations, crypto op contains per session based event info in crypto op metadata. If any PMD passes any i

Re: [PATCH v2 5/5] dts: add `show port stats` command to TestPmdShell

On 9. 5. 2024 13:26, Luca Vizzarro wrote: Add a new TestPmdPortStats data structure to represent the output returned by `show port stats`, which is implemented as part of TestPmdShell. Bugzilla ID: 1407 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_se

Re: [PATCH v2 4/5] dts: add `show port info` command to TestPmdShell

Great work. I can't really review all of the milions of different options, so it's mainly annoying reminders of missing docstring sections. On 9. 5. 2024 13:26, Luca Vizzarro wrote: Add a new TestPmdPort data structure to represent the output returned by `show port info`, which is implemented a

Re: [PATCH v2 3/5] dts: add parsing utility module

There are mostly documentation and basically inconsequential minor comments. On 9. 5. 2024 13:26, Luca Vizzarro wrote: Adds parsing text into a custom dataclass. It provides a new `TextParser` dataclass to be inherited. This implements the `parse` method, which combined with the parser functions

Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field

04/06/2024 14:38, Rongwei Liu: > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = { > "ipv6_flow_label", "ipv6_traffic_class", > "esp_spi", "esp_seq_num", "esp_proto", > "random", > + "vxl

[PATCH] app/test-crypto-perf: add shared session option

Add the option to create one session for the PMD, and share it across all of the queue pairs. This may help to discover/debug concurrency issues (both correctness and performance) that can occur when using this configuration. Signed-off-by: Jack Bond-Preston Reviewed-by: Wathsala Vithanage Revie

Re: [PATCH v2 0/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

> On Jun 4, 2024, at 9:28 AM, Boyer, Andrew wrote: > > >> On Apr 30, 2024, at 4:21 PM, Boyer, Andrew wrote: >> >> This patchset introduces a new crypto PMD for AMD Pensando hardware >> accelerators. It allows applications running directly on the AMD Pensando >> DSC to offload cryptographic o

Re: [PATCH v2 2/5] dts: skip first line of send command output

On 9. 5. 2024 13:26, Luca Vizzarro wrote: The first line of the InteractiveShell send_command method is generally the command input field. This sometimes is unwanted, therefore this commit enables the possibility of omitting the first line from the returned output. Signed-off-by: Luca Vizzarr

Re: [PATCH v2 1/5] dts: fix InteractiveShell command prompt filtering

On 9. 5. 2024 13:26, Luca Vizzarro wrote: When sending a command using an instance of InteractiveShell the output should filter out the trailing shell prompt when returning it. After every command two shell prompts are summoned. One is consumed as it is used as a delimiter for the command outp

Re: [PATCH v2 0/9] crypto/ionic: introduce AMD Pensando ionic crypto driver

> On Apr 30, 2024, at 4:21 PM, Boyer, Andrew wrote: > > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks. > > V2: > - Remix p

[PATCH v4 2/3] ethdev: add VXLAN last reserved field

Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff --git a/app/te

[PATCH v4 1/3] app/testpmd: fix the testpmd field string sequence

The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c |

[PATCH v4 3/3] net/mlx5: implement VXLAN last reserved modification

Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v4 0/3] support VXLAN rsvd1 modification

Support to modify VXLAN the last byte reserved field. v4: specify the limitation with exact port number. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field net/mlx5: impl

Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification

BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 20:19 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modificati

Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification

27/05/2024 04:47, Rongwei Liu: > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -685,6 +685,11 @@ Limitations > - Second tunnel fields are not supported. > >- Encapsulation levels greater than ``2`` are not supported. > + - Modification of the VXLAN header is suppo

[PATCH v3 3/3] net/mlx5: implement VXLAN last reserved modification

Implementing the VxLAN last reserved byte modification. Following the RFC, the field is only 1 byte and needs to use the field_length as 8 instead of the real dst_field->size. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 5 + drivers/net/mlx5

[PATCH v3 2/3] ethdev: add VXLAN last reserved field

Add VXLAN last reserved byte in rte flow packet field. Add 'vxlan_last_rsvd' as the modification command string. Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 1 + lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+) diff --git a/app/te

[PATCH v3 1/3] app/testpmd: fix the testpmd field string sequence

The field string should be in the same order as the rte_flow_field_id enumration definitions Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c |

[PATCH v3 0/3] support VXLAN rsvd1 modification

Support to modify VXLAN the last byte reserved field. v3: squash testpmd and rte_flow into one commit. v2: patch split. Rongwei Liu (3): app/testpmd: fix the testpmd field string sequence ethdev: add VXLAN last reserved field net/mlx5: implement VXLAN last reserved modification app/test-p

[PATCH v3 25/25] net/axgbe: modify debug messages

From: Venkat Kumar Ande Modify debug messages to get better information from debug logs Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) dif

[PATCH v3 24/25] net/axgbe: extend 10Mbps support to MAC version 21H

From: Venkat Kumar Ande MAC version 21H supports the 10Mbps speed. So, extend support to platforms that support it. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v3 23/25] net/axgbe: add support for Rx adaptation

From: Venkat Kumar Ande The existing implementation for non-Autonegotiation 10G speed modes does not enable RX adaptation in the Driver and FW. The RX Equalization settings (AFE settings alone) are manually configured and the existing link-up sequence in the driver does not perform rx adaptation

[PATCH v3 22/25] net/axgbe: add 2.5GbE support to 10G BaseT mode

From: Venkat Kumar Ande Add support to the driver to fully recognize and enable 2.5GbE speed in 10GBaseT mode. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 19/25] net/axgbe: add support for 10 Mbps speed

From: Venkat Kumar Ande Add the necessary changes to support 10 Mbps speed for BaseT and SFP port modes. This is supported in MAC ver >= 30H. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_dev.c | 3 ++ drivers/net/axgbe/axgbe_ethdev.h | 2 +

[PATCH v3 20/25] net/axgbe: separate C22 and C45 transactions

From: Venkat Kumar Ande The xgbe MDIO bus driver can perform both C22 and C45 transfers, when using its MDIO bus hardware. The SFP I2C mdio bus driver only supports C22. Create separate functions for each and register the C45 versions using the new API calls where appropriate. Signed-off-by: Ven

[PATCH v3 18/25] net/axgbe: use definitions for mailbox commands

From: Venkat Kumar Ande Instead of using hardcoded values, use enumerations for mailbox command and sub commands. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.h | 25 + drivers/net/axgbe/axgbe_phy_impl.c | 28

[PATCH v3 21/25] net/axgbe: replace mii generic macro for c45 with AXGBE

From: Venkat Kumar Ande The axgbe driver reuses MII_ADDR_C45 for its own purpose. The values derived with it are never passed to phylib or a linux MDIO bus driver. In order that MII_ADDR_C45 can be removed, add AXGBE specific macro. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian -

[PATCH v3 17/25] net/axgbe: remove unnecessary conversion to bool

From: Venkat Kumar Ande The conversion to bool is not needed, remove it. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axg

[PATCH v3 16/25] net/axgbe: improve SFP 100Mbps auto-negotiation

From: Venkat Kumar Ande After changing speed to 100Mbps as a result of auto-negotiation (AN), some 10/100/1000Mbps SFPs indicate a successful link (no faults or loss of signal), but cannot successfully transmit or receive data. These SFPs required an extra auto-negotiation (AN) after the speed c

[PATCH v3 15/25] net/axgbe: remove field of SFP diagnostic support

From: Venkat Kumar Ande The driver currently sets an indication of whether the SFP supports, and that the driver can obtain, diagnostics data. This isn't currently used by the driver. Remove this field and the logic supporting it. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian -

[PATCH v3 14/25] net/axgbe: remove use of comm owned field

From: Venkat Kumar Ande The comm_owned field can hide logic where double locking is attempted and prevent multiple threads for the same device from accessing the mutex properly. Remove the comm_owned field and use the mutex API exclusively for gaining ownership. Signed-off-by: Venkat Kumar Ande

[PATCH v3 13/25] net/axgbe: fix the false linkup in axgbe PHY status

From: Venkat Kumar Ande In the event of a change in AXGBE mode, the current auto-negotiation needs to be reset and the AN cycle needs to be re-triggered. However, the current code ignores the return value of axgbe_set_mode(), leading to false information as the link is declared without checking t

[PATCH v3 12/25] net/axgbe: delay AN timeout during KR training

From: Venkat Kumar Ande AN restart triggered during KR training not only aborts the KR training process but also move the HW to unstable state. Driver has to wait up to 500ms or until the KR training is completed before restarting AN cycle. Without the fix the user will face KR training failure

[PATCH v3 11/25] net/axgbe: flow Tx Ctrl Registers are h/w version dependent

From: Venkat Kumar Ande There is difference in the TX Flow Control registers (TFCR) between the revisions of the hardware. The older revisions of hardware used to have single register per queue. Whereas, the newer revision of hardware (from ver 30H onwards) have one register per priority. Withou

[PATCH v3 10/25] net/axgbe: check only the minimum speed for cables

From: Venkat Kumar Ande There are cables that exist that can support speeds in excess of 10GbE. The driver, however, restricts the EEPROM advertised nominal bitrate to a specific range, which can prevent usage of cables that can support, for example, up to 25GbE. Rather than checking that an act

[PATCH v3 09/25] net/axgbe: fix logic around active and passive cables

From: Venkat Kumar Ande SFP+ active and passive cables are copper cables with fixed SFP+ end connectors. Due to a misinterpretation of this, SFP+ active cables could end up not being recognized, causing the driver to fail to establish a connection. Introduce a new enum in SFP+ cable types, XGBE_

[PATCH v3 08/25] net/axgbe: fix the SFP codes check for DAC cables

From: Venkat Kumar Ande The current AXGBE code assumes that offset 6 of EEPROM SFP DAC (passive) cables is NULL. However, some cables (the 5 meter and 7 meter Molex passive cables) have non-zero data at offset 6. Fix the logic by moving the passive cable check above the active checks, so as not t

[PATCH v3 07/25] net/axgbe: enable PLL control for fixed PHY modes only

From: Venkat Kumar Ande PLL control setting(RRC) is needed only in fixed PHY configuration to fix the peer-peer issues. Without the PLL control setting, the link up takes longer time in a fixed phy configuration. Without the fix the user will not get the link come UP. Driver implements SW RRC f

[PATCH v3 06/25] net/axgbe: yellow carp devices do not need rrc

From: Venkat Kumar Ande Link stability issues are noticed on Yellow carp platforms when Receiver Reset Cycle is issued. Since the CDR workaround is disabled on these platforms, the Receiver Reset Cycle is not needed. So, avoid issuing rrc on Yellow carp platforms. Without the fix the user will

[PATCH v3 05/25] net/axgbe: disable interrupts during device removal

From: Venkat Kumar Ande Hardware interrupts are enabled during the init, however, they are not disabled during close. Disable all hardware interrupts during close operation to avoid any issues. Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") Cc: sta...@dpdk.org Signed-off-by: Venkat Kumar An

[PATCH v3 04/25] net/axgbe: update DMA coherency values

From: Venkat Kumar Ande Based on the IOMMU configuration, the current cache control settings can result in possible coherency issues. The hardware team has recommended new settings for the PCI device path to eliminate the issue. Without the fix the user will get incorrect data in TSO functionali

[PATCH v3 03/25] net/axgbe: fix fluctuations for 1G BELFUSE SFP

From: Venkat Kumar Ande Frequent link up/down events can happen when a Bel Fuse SFP part is connected to the amd-xgbe device. Try to avoid the frequent link issues by resetting the PHY as documented in Bel Fuse SFP datasheets. Without the fix user will see continuous port link up and down. Fixe

[PATCH v3 02/25] net/axgbe: reset link when the link never comes back

From: Venkat Kumar Ande Normally, auto negotiation and reconnect should be automatically done by the hardware. But there seems to be an issue where auto negotiation has to be restarted manually. This happens because of link training and so even though still connected to the partner the link never

[PATCH v3 01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs

From: Venkat Kumar Ande The XGBE supports performing MDIO operations using an MDIO command request. The driver mistakenly uses the mdio port address as the MDIO command request device address instead of the MDIO command request port address. Additionally, the driver does not properly check for an

Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field

BR Rongwei From: Thomas Monjalon Sent: Tuesday, June 4, 2024 19:59 To: rongwei liu Cc: dev@dpdk.org ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; Suanming Mou ; Dariusz Sosnowski ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [PATCH v2 2/4] ethdev: add VXL

Re: [PATCH v2 3/4] app/testpmd: add VXLAN last reserved modification command

27/05/2024 04:47, Rongwei Liu: > @@ -1005,7 +1005,7 @@ static const char *const flow_field_ids[] = { > "ipv4_proto", > "ipv6_flow_label", "ipv6_traffic_class", > "esp_spi", "esp_seq_num", "esp_proto", > - "random", > + "random", "vxlan_last_rsvd", it is not related to "ra

Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field

27/05/2024 04:47, Rongwei Liu: > Add VXLAN last reserved byte in rte flow packet field. You should squash addition in testpmd in the same patch. Adding a field in rte_flow.h should be atomic with testpmd update. > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM,

Re: [PATCH 0/2] validate actions in HWS table

Hi, From: Gregory Etelson Sent: Sunday, June 2, 2024 9:00 AM To: dev@dpdk.org Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski Subject: [PATCH 0/2] validate actions in HWS table Validate flow actions before creation of HWS template table. Gregory Etelson (2): net/mlx5:

Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field

Hi @Ori Kam@Andrew Rybchenko@NBU-Contact-Thomas Monjalon (EXTERNAL)@Ferruh Yigit   Can you help ACK this patch?   Thanks BR Rongwei ___

Re: [PATCH v13 6/6] test: add unit test for ptr compression

Recheck-request: iol-unit-amd64-testing

Re: [PATCH v13 6/6] test: add unit test for ptr compression

Recheck-request: github-robot

Re: [PATCH v13 0/6] add pointer compression API

Recheck-request: iol-unit-amd64-testing

[PATCH v2 21/21] drivers: adding type to idpf vc queue switch

Adding an argument named type to define queue type in idpf_vc_queue_switch(). This solves the issue of improper queue type in virtchnl2 message. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_virtchnl.c | 8 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 2 +- driver

[PATCH v2 20/21] common/idpf: remove idpf common file

The file is redundant in our implementation and is not required further. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c | 382 - drivers/common/idpf/base/meson.build | 1 - 2 files changed, 383 deletions(-) delete mode 100644 drivers/common

[PATCH v2 19/21] common/idpf: add a new Tx context descriptor structure

Adding a new structure for the context descriptor that contains the support for timesync packets, where the index for timestamping is set. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_lan_txrx.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

[PATCH v2 18/21] common/idpf: enable flow steer capability for vports

Added virtchnl2_flow_types to be used for flow steering. Added flow steer cap flags for vport create. Add flow steer flow types and action types for vport create. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 60 ++-- 1 file changed, 57 inser

[PATCH v2 16/21] common/idpf: add wmb before tail

Introduced through customer's feedback in their attempt to address some bugs this introduces a memory barrier before posting ctlq tail. This makes sure memory writes have a chance to take place before HW starts messing with the descriptors. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/

[PATCH v2 17/21] drivers: add flex array support and fix issues

With the internal Linux upstream feedback that is received on IDPF driver and also some references available online, it is discouraged to use 1-sized array fields in the structures, especially in the new Linux drivers that are going to be upstreamed. Instead, it is recommended to use flex array fie

[PATCH v2 15/21] common/idpf: rename INLINE FLOW STEER to FLOW STEER

This capability bit indicates both inline as well as side band flow steering capability. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/vi

[PATCH v2 14/21] common/idpf: update in PTP message validation

When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++

[PATCH v2 13/21] common/idpf: avoid variable 0-init

Dont initialize the variables if not needed. Also use 'err' instead of 'status', 'ret_code', 'ret' etc. for consistency and change the return label 'sq_send_command_out' to 'err_unlock'. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 63 +-- .

[PATCH v2 12/21] common/idpf: move related defines into enums

Changes all groups of related defines to enums. The names of the enums are chosen to follow the common part of the naming pattern as much as possible. Replaced the common labels from the comments with the enum names. While at it, modify header description based on upstream feedback. Some variabl

[PATCH v2 11/21] common/idpf: use 'pad' and 'reserved' fields appropriately

'pad' naming is used if the field is actually a padding byte and is also used for bytes meant for future addition of new fields, whereas 'reserved' is only used if the field is reserved and cannot be used for any other purpose. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl

[PATCH v2 10/21] common/idpf: update mask of Rx FLEX DESC ADV FF1 M

Mask for VIRTCHNL2_RX_FLEX_DESC_ADV_FF1_M was defined wrongly and this patch fixes it. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2_lan_desc.h b/drivers/com

[PATCH v2 09/21] common/idpf: refactor size check macro

Instead of using 'divide by 0' to check the struct length, use the static_assert macro Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/

[PATCH v2 08/21] common/idpf: compress RXDID mask definitions

Instead of using the long RXDID definitions, introduce a macro which uses common part of the RXDID definitions i.e. VIRTCHNL2_RXDID_ and the bit passed to generate a mask. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 31 ++- 1 file changed, 1

[PATCH v2 07/21] common/idpf: convert data type to 'le'

'u32' data type is used for the struct members in 'virtchnl2_version_info' which should be '__le32'. Make the change accordingly. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/ba

[PATCH v2 06/21] common/idpf: use BIT ULL for large bitmaps

For bitmaps greater than 32 bits, use BIT_ULL instead of BIT macro as reported by compiler. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl

[PATCH v2 05/21] common/idpf: avoid defensive programming

Based on the upstream feedback, driver should not use any defensive programming strategy by checking for NULL pointers and other conditional checks unnecessarily in the code flow to fall back, instead fail and fix the bug in a proper way. Some of the checks are identified and removed/wrapped in th

[PATCH v2 04/21] common/idpf: moved the idpf HW into API header file

There is an issue of recursive header file includes in accessing the idpf_hw structure. The controlq.h has the structure definition and osdep header file needs that. The problem is the controlq.h also needs the osdep header file contents, basically both dependent on each other. Moving the definiti

[PATCH v2 03/21] common/idpf: added new virtchnl2 capability and vport flag

Removed unused VIRTCHNL2_CAP_ADQ capability and use that bit for VIRTCHNL2_CAP_INLINE_FLOW_STEER capability. Added VIRTCHNL2_VPORT_INLINE_FLOW_STEER_ENA port flag to allow enable/disable per vport. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 7 --- 1 file chang

[PATCH v2 02/21] common/idpf: updated IDPF VF device ID

Update IDPF VF device id to 145C. Also added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/idpf_devids.h b/drivers/common/idpf/base/idpf_d

[PATCH v2 01/21] common/idpf: added NVME CPF specific code with defines

Removes NVME dependency on memory allocations and uses a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 23 +++- drivers/common/idpf/base/idpf_controlq_api.h | 7 +- 2 fi

[PATCH v2 00/21] Update MEV TS Base Driver

These patches integrate the latest changes in MEV TS IDPF Base driver. --- v2: - Changed implementation based on review comments - Fixed compilation errors for Windows, Alpine and FreeBSD --- Soumyadeep Hore (21): common/idpf: added NVME CPF specific code with defines common/idpf: updated IDP