> From: Lombardo, Ed [mailto:ed.lomba...@netscout.com]
> Sent: Friday, 3 May 2024 23.19
>
> Hi Dmitry,
> Thank you, I will give this a try.
Many arrays in DPDK are statically allocated at the build-time max array size,
so tweaking DPDK's build-time configuration parameters will reduce the memory
On Thu, 2 May 2024 15:21:16 +0100
Daniel Gregory wrote:
> The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> memorder, which is not constant. This causes compile errors when it is
> enabled with RTE_ARM_USE_WFE. eg.
>
> ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_w
On Fri, 3 May 2024 19:27:30 +0100
Daniel Gregory wrote:
> The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> memorder, which is not constant. This causes compile errors when it is
> enabled with RTE_ARM_USE_WFE. eg.
>
> ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_w
On Fri, 3 May 2024 10:46:05 +0100
Daniel Gregory wrote:
> On Thu, May 02, 2024 at 02:48:26PM -0700, Stephen Hemminger wrote:
> > There are already constant checks like this elsewhere in the file.
>
> Yes, but they're in macros, rather than inlined functions, so my
> understanding was that at c
On Fri, May 03, 2024 at 08:41:09AM +0200, Mattias Rönnblom wrote:
> On 2024-05-02 07:57, Mattias Rönnblom wrote:
> >Add atomic bit test/set/clear/assign/flip and
> >test-and-set/clear/assign/flip functions.
> >
> >All atomic bit functions allow (and indeed, require) the caller to
> >specify a memor
On Fri, 3 May 2024 16:45:47 +0100
Ferruh Yigit wrote:
> For stats reset, use an offset instead of zeroing out actual stats values,
> get_stats() displays diff between stats and offset.
> This way stats only updated in datapath and offset only updated in stats
> reset function. This makes stats re
Hi Dmitry,
Thank you, I will give this a try.
Another angle is how can I calculate or determine when DPDK is initialized how
much total memory DPDK will use. Then I can provide this to our application
core and then they can take the DPDK memory max requirement and subtract it
from the total me
2024-05-03 23:54 (UTC+0300), Dmitry Kozlyuk:
> #define RTE_MAX_MEM_MB_PER_LIST 2024 // see item 4 below
Typo: 2048
2024-05-03 14:48 (UTC+), Lombardo, Ed:
> Hi Dmitry,
> I am not clear on the DPDK memory layout and how to tweak these #define
> values.
Given your statement:
> Currently we configure 2x1G hugepages and single socket.
I suggest the following:
#define RTE_MAX_MEMSEG_LISTS 2 // see i
Hi Bruce,
For the heck of it I tried to build DPDK .a and .h files with rte_config.h
changes of these parmeters.
1st build- change RTE_MAX_MEMSEG_PER_TYPE:
/*-orig: #define RTE_MAX_MEMSEG_PER_TYPE 32768 */
#define RTE_MAX_MEMSEG_PER_TYPE 16384 reduced by 1/2
And executed ninja clean
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 3 May 2024 17.52
>
> On Fri, May 03, 2024 at 04:27:39PM +0100, Bruce Richardson wrote:
> > On Fri, May 03, 2024 at 02:48:12PM +, Lombardo, Ed wrote:
> > > Hi Dmitry,
> > > I am not clear on the DPDK memory layout and
Missed during commit 1ec6a845b5cb
("eal: use stdatomic API in public headers")
Signed-off-by: Daniel Gregory
---
lib/eal/arm/include/rte_pause_64.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/eal/arm/include/rte_pause_64.h
b/lib/eal/arm/include/rte_pause_64.h
Apologies, mis-sent this before attaching a changelog:
v2:
* replaced RTE_ASSERT with assert
* added Fixes: tag
The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
memorder, which is not constant. This causes compile errors when it is
enabled with RTE_ARM_USE_WFE. eg.
../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_until_equal_16’:
../lib/eal/include/rte_common.h:530:56: error: e
On Fri, May 03, 2024 at 05:48:05PM +0100, Bruce Richardson wrote:
> On Fri, May 03, 2024 at 09:46:15AM +, Tom Jones wrote:
> > Add support to the contigmem module on FreeBSD for multiple concurrent
> > files, this enables running multiple dpdk instances with the nic_uio
> > driver.
> >
> > Add
On Fri, May 03, 2024 at 09:46:15AM +, Tom Jones wrote:
> Add support to the contigmem module on FreeBSD for multiple concurrent
> files, this enables running multiple dpdk instances with the nic_uio
> driver.
>
> Add relevant parts in dpdk to support this.
>
> Signed-off-by: Tom Jones
> ---
On Fri, May 03, 2024 at 09:46:15AM +, Tom Jones wrote:
> Add support to the contigmem module on FreeBSD for multiple concurrent
> files, this enables running multiple dpdk instances with the nic_uio
> driver.
>
> Add relevant parts in dpdk to support this.
>
> Signed-off-by: Tom Jones
> ---
On Fri, May 03, 2024 at 04:27:39PM +0100, Bruce Richardson wrote:
> On Fri, May 03, 2024 at 02:48:12PM +, Lombardo, Ed wrote:
> > Hi Dmitry,
> > I am not clear on the DPDK memory layout and how to tweak these #define
> > values.
> >
> > #define RTE_MAX_MEMSEG_PER_LIST 8192
> > #define RTE_M
For stats reset, use an offset instead of zeroing out actual stats values,
get_stats() displays diff between stats and offset.
This way stats only updated in datapath and offset only updated in stats
reset function. This makes stats reset function more reliable.
As stats only written by single thr
On Fri, May 03, 2024 at 02:48:12PM +, Lombardo, Ed wrote:
> Hi Dmitry,
> I am not clear on the DPDK memory layout and how to tweak these #define
> values.
>
> #define RTE_MAX_MEMSEG_PER_LIST 8192
> #define RTE_MAX_MEM_MB_PER_LIST 32768
> #define RTE_MAX_MEMSEG_PER_TYPE 32768
> #define RTE_M
On 5/3/2024 2:54 PM, Aaron Conole wrote:
> - Mykola has questions about submitting for a refactored PMD series
>- Answered some live, referred to the guides in the documentation
> as well.
>- Plan to send a simpler version of the PMD
> - Include any restrictions in docs
>- Tr
Hi Dmitry,
I am not clear on the DPDK memory layout and how to tweak these #define values.
#define RTE_MAX_MEMSEG_PER_LIST 8192
#define RTE_MAX_MEM_MB_PER_LIST 32768
#define RTE_MAX_MEMSEG_PER_TYPE 32768
#define RTE_MAX_MEM_MB_PER_TYPE 65536
I want to limit how much DPDK grabs for memory, but
On Fri, May 03, 2024 at 03:32:20PM +0200, David Marchand wrote:
> - RTE_BUILD_BUG_ON() should not be used indeed.
> IIRC, this issue was introduced with 875f350924b8 ("eal: add a new
> helper for wait until scheme").
> Please add a corresponding Fixes: tag in next revision.
Will do. Should I CC st
Add various features to the base driver that are not specifically
about packet I/O but are present in the shared code snapshot.
Also, update documentation to reflect new base code snapshot version,
as well as document new hardware support.
Signed-off-by: Anatoly Burakov
---
doc/guides/rel_notes
From: Piotr Kwapulinski
Add high level link management support for E610 device, as well as
enable all code paths related to E610 initialization. This makes it so
that E610 can be brought up using ixgbe driver.
Signed-off-by: Carolyn Wyborny
Signed-off-by: Jedrzej Jagielski
Signed-off-by: Piotr
From: Piotr Kwapulinski
Add low level support for accessing NVM in E610 device. NVM operations are
handled via the Admin Command Interface.
Signed-off-by: Stefan Wegrzyn
Signed-off-by: Jedrzej Jagielski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Anatoly Burakov
---
drivers/net/ixgbe/ba
From: Piotr Kwapulinski
Add low level link management support for E610 device. Link management
operations are handled via the Admin Command Interface.
Signed-off-by: Stefan Wegrzyn
Signed-off-by: Jedrzej Jagielski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Anatoly Burakov
---
drivers/n
From: Piotr Kwapulinski
Add low level support for E610 device capabilities detection. The
capabilities are discovered via the Admin Command Interface.
Signed-off-by: Stefan Wegrzyn
Signed-off-by: Jedrzej Jagielski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Anatoly Burakov
---
drivers/n
From: Piotr Kwapulinski
Add low level support for Admin Command Interface (ACI). ACI is the
Firmware interface used by a driver to communicate with E610 adapter. Add
the following ACI features:
- data structures, macros, register definitions
- commands handling
- events handling
Signed-off-by: S
From: Chinh Cao
There are some function prototypes that were introduced at some point
but were never implemented, so remove them.
Signed-off-by: Chinh Cao
---
drivers/net/ixgbe/base/ixgbe_api.h | 1 -
drivers/net/ixgbe/base/ixgbe_x550.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/dr
From: Milosz Szymonek
Add mask for MACLEN indexes in advanced context descriptors (bits 9:15).
IXGBE_ADVTXD_MACLEN_MASK will be used in Windows driver code.
Signed-off-by: Milosz Szymonek
---
drivers/net/ixgbe/base/ixgbe_type.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ix
From: Dawid Zielinski
Added length check against EEPROM size in words to prevent untrusted
loop bound reported by static code analysis.
Signed-off-by: Dawid Zielinski
---
drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe
From: Barbara Skobiej
HWSW semaphore acquisition in Atom C3000 NIC is a two stage process.
Each time two semaphore acquisitions are required. Each second semaphore
failure require re-acquisition of first semaphore. This patch decouples
the two acquisitions preventing potentially hundreds of thous
From: Barbara Skobiej
This patch adds missing QV defines:
- offset of ANVM data
- Immediate Field module pointer offset
- 2.5GBASE-T and 5GBASE-T physical layer types for X550
Signed-off-by: Barbara Skobiej
Signed-off-by: Jan Sokolowski
---
drivers/net/ixgbe/base/ixgbe_type.h | 5 +
1 fil
From: Barbara Skobiej
Including one header file in second header file should be avoided, so
fix it by forward declaring the struct instead.
Signed-off-by: Barbara Skobiej
---
drivers/net/ixgbe/base/ixgbe_mbx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgb
From: Krzysztof Galazka
Extend SFP+ cage crosstalk fix by re-checking link state
after 5ms delay to filter out spurious link up indication
by transceiver with no fibre cable connected.
Signed-off-by: Krzysztof Galazka
Reviewed-by: Jan Sokolowski
---
drivers/net/ixgbe/base/ixgbe_common.c | 19
From: Piotr Skajewski
As there have been a long list of flaws due to missing "break" statement
kernel no longer allow implict fall-through and reports warning during
compilation. Convert all "fall-through" comments to actual code.
Signed-off-by: Piotr Skajewski
Reviewed-by: Michael, Alice
---
From: Marcin Jurczak
This patch removes non-inclusive language from code, user interface
and comments.
Signed-off-by: Marcin Jurczak
Reviewed-by: Michael, Alice
---
drivers/net/ixgbe/base/ixgbe_common.c | 34 +--
drivers/net/ixgbe/base/ixgbe_common.h | 2 +-
drivers/n
From: Slawomir Mrozowicz
Adding a functionality that retrieves information from PF regarding
the link state of a given VF.
It is part of the general functionality that allows the PF driver
to control the state of the virtual link VF devices.
Signed-off-by: Slawomir Mrozowicz
Reviewed-by: Tyl, R
From: Mical MarekX
Unifying FW access method to direct register read/writes across
all Atom(R) C3000 products. Atom(R) C3000 fiber exhibited an issue with
the Host Interface Command execution being locked when
another LAN function attempted to acquire the SWFW sync
on Manageability Host. This res
From: Radoslaw Tyl
Add fw_rst_cnt to store the number of resets after fw update.
This value is required to detect if the EICR.MNG event occurred
after firmware update reset.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Reviewed-by: Mrozowicz, SlawomirX
Reviewed-by: Michael, Alic
From: Radoslaw Tyl
Some function comments have mismatches between actual function names and
function name in comments, which causes warnings with kernel-doc. Fix
comments to match function names.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Reviewed-by: Mrozowicz, SlawomirX
Revi
From: Slawomir Mrozowicz
Issue observed: system crash While loading the driver when debug macros
were defined.
The solution removes the debug macro call from
ixgbe_set_mac_type() function which causes the crash.
So far, the ixgbe_set_mac_type() function has called in the ixgbe driver
ixgbe_prob
From: Radoslaw Tyl
Change max credit and credit refill to a maximum possible value.
Too small values cause the incorrect calculation of the bandwidth limits
to each traffic class for frames larger than 4088 bytes.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Tested-by: Skajewski,
From: Jakub Chylkowski
Current mailbox API does not work as described in documentation and
is prone to errors (for example, it is doing locks on read). Introduce
new mailbox API and provide compatibility functions with old API.
New error codes have been introduced:
- IXGBE_ERR_CONFIG - ixgbe_mbx
From: Jakub Chylkowski
Some of mailbox-related registers have different names than it is
specified in datasheet. Correct these names to correspond to their
datasheet counterparts. Additionally, several calculations are changed
to no longer use magic numbers but dedicated macros instead.
Signed-o
From: Jakub Chylkowski
There is name similarity within IXGBE_VT_MSGTYPE_ACK and
PFMAILBOX.ACK / VFMAILBOX.ACK which may cause confusion. Rename MSGTYPE
macros to SUCCESS and FAILURE as they are not specified in datasheet and
now will be easily distinguishable.
Signed-off-by: Jakub Chylkowski
Re
From: Radoslaw Tyl
Function ixgbe_get_phy_type_from_id() for X550_PHY_ID2 and
X550_PHY_ID3 always return ixgbe_phy_unknown instead of ixgbe_phy_aq
because phy ID's last 4 bits are always masked, and should not be
taken into account when selecting phy type.
This patch adds default PHY ID for X550
From: Piotr Skajewski
When 5000 Base-T was set on PF the VF reported 100 Base-T.
This patch change ixgbe_check_mac_link_vf function
where was incorrect conditional which points to PF mac types,
now it is pointing correctly to VF mac types.
Fixes: 12e20906905c ("net/ixgbe/base: include new speeds
From: Piotr Pietruszewski
This reverts the following commit:
13de249e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G")
The commit removing advertising 2.5G and 5G speeds from
ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G
during the autonegotiatio
This patchset updates IXGBE base driver to latest shared code snapshot,
fixing a few issues as well as adding support for new hardware.
v2:
- Split giant E610 patch into set of smaller patches
- Added release notes
Anatoly Burakov (1):
net/ixgbe/base: add various miscellaneous features
Barbara
Next Meeting will be May 15th, with Bruce as chair.
Attendees
-
- Aaron (chair)
- Morten Brorup
- David Marchand
- Konstantin Ananyev
- Tyler Retzlaff
- Mykola Kostenok
- Paul Szczepanik
- Kevin Traynor
- Jerin Jacob Kollanukkaran
- Nathan Southern
- Patrick Robb
- Stephen Hemminger
- Bruc
On Thu, May 2, 2024 at 4:22 PM Daniel Gregory
wrote:
>
> The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> memorder, which is not constant. This causes compile errors when it is
> enabled with RTE_ARM_USE_WFE. eg.
>
> ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_
On Fri, May 03, 2024 at 02:12:58PM +0100, Tom Jones wrote:
> Hi Bruce,
>
> thanks for letting me know
>
> I'm not tied to anything particularly. This change isn't compatible with the
> previous API, but I'm not against making it so if that is really the best
> thing to do. As is, the dpdk chang
Hi Bruce,
thanks for letting me know
I'm not tied to anything particularly. This change isn't compatible with the
previous API, but I'm not against making it so if that is really the best thing
to do. As is, the dpdk changes and the contigmem changes need to come together
because the API chang
On Thu, Apr 18, 2024 at 10:20 AM David Marchand
wrote:
>
> This series aims at fixing outer UDP checksum for Intel nics (i40e and
> ice).
> The net/hns3 is really similar in its internals and has been aligned.
>
> As I touched testpmd csumonly engine, this series may break other
> vendors outer of
On Fri, May 03, 2024 at 09:46:15AM +, Tom Jones wrote:
> Add support to the contigmem module on FreeBSD for multiple concurrent
> files, this enables running multiple dpdk instances with the nic_uio
> driver.
>
> Add relevant parts in dpdk to support this.
>
> Signed-off-by: Tom Jones ---
T
Add support to the contigmem module on FreeBSD for multiple concurrent
files, this enables running multiple dpdk instances with the nic_uio
driver.
Add relevant parts in dpdk to support this.
Signed-off-by: Tom Jones
---
config/rte_config.h | 2 +
kernel/freebsd/contigmem/con
On 5/3/2024 9:51 AM, Kevin Traynor wrote:
> The documentation is missing the 'config' word.
>
> In app, 'help ports' shows the correct syntax:
>
> port config (port_id) (rxq|txq) (queue_id) ring_size (value)
>
> Fixes: 1a77cffa8143 ("app/testpmd: enable queue ring size configure")
> Cc: sta...@d
On Thu, May 02, 2024 at 02:48:26PM -0700, Stephen Hemminger wrote:
> There are already constant checks like this elsewhere in the file.
Yes, but they're in macros, rather than inlined functions, so my
understanding was that at compile time, macro expansion has put the
memorder constant in the _Sta
The documentation is missing the 'config' word.
In app, 'help ports' shows the correct syntax:
port config (port_id) (rxq|txq) (queue_id) ring_size (value)
Fixes: 1a77cffa8143 ("app/testpmd: enable queue ring size configure")
Cc: sta...@dpdk.org
Signed-off-by: Kevin Traynor
---
doc/guides/tes
61 matches
Mail list logo
