RE: [PATCH] config/arm: sort in alphabetical order

2024-03-06 Thread Morten Brørup
> From: Anoob Joseph [mailto:ano...@marvell.com] > Sent: Thursday, 7 March 2024 07.02 > > Move 'soc_cn9k' above 'soc_cn10k' to have the list alphabetically > sorted. > > Signed-off-by: Anoob Joseph > --- Agree, 9 comes before 10. Reviewed-by: Morten Brørup

RE: [EXTERNAL] Re: [PATCH v2 1/1] app/graph: generate cmdline boilerplate

2024-03-06 Thread Sunil Kumar Kori
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 7, 2024 3:22 AM > To: Sunil Kumar Kori > Cc: Rakesh Kudurumalla ; dev@dpdk.org; > Bruce Richardson > Subject: [EXTERNAL] Re: [PATCH v2 1/1] app/graph: generate cmdline > boilerplate > > Prioritize security for external

[PATCH v2 4/5] eal: fix first time primary autodetect

2024-03-06 Thread Artemy Kovalyov
If the configuration file is absent, the autodetection function should generate and secure it. Otherwise, multiple simultaneous openings could erroneously identify themselves as primary instances. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Artemy Kovalyov ---

[PATCH v2 5/5] eal: fix memzone fbarray cleanup

2024-03-06 Thread Artemy Kovalyov
The initialization of the Memzone file-backed array ensures its uniqueness by employing an exclusive lock. This is crucial because only one primary process can exist per specific shm_id, which is further protected by the exclusive EAL runtime configuration lock. However, during the process closure

[PATCH v2 3/5] ipc: fix mp channel closure to prevent message loss

2024-03-06 Thread Artemy Kovalyov
This commit addresses an issue related to the cleanup of the multiprocess channel. Previously, when closing the channel, there was a risk of losing trailing messages. This issue was particularly noticeable when broadcast message from primary to secondary processes was sent while a secondary process

[PATCH v2 2/5] eal: fix multiprocess hotplug race

2024-03-06 Thread Artemy Kovalyov
There exists a time gap between the creation of the multiprocess channel and the registration of request action handlers. Within this window, a secondary process that receives an eal_dev_mp_request broadcast notification might respond with ENOTSUP. This, in turn, causes the rte_dev_probe() operatio

[PATCH v2 1/5] app/test-mp: add multiprocess test

2024-03-06 Thread Artemy Kovalyov
This commit adds a test scenario that initiates multiple processes concurrently. These processes attach to the same shared heap, with an automatic detection mechanism to identify the primary process. Signed-off-by: Artemy Kovalyov --- app/meson.build | 1 + app/test-mp/main.c | 52

[PATCH 0/5] addressing races in concurrent process startup

2024-03-06 Thread Artemy Kovalyov
In the process of initiating multiple processes concurrently, specifically with automatic detection of the primary process, certain race conditions have been identified. This patch series introduces a straightforward test that showcases the issue and subsequently addresses the problems surfaced by

[PATCH 0/5] addressing races in concurrent process startup

2024-03-06 Thread Artemy Kovalyov
In the process of initiating multiple processes concurrently, specifically with automatic detection of the primary process, certain race conditions have been identified. This patch series introduces a straightforward test that showcases the issue and subsequently addresses the problems surfaced by

[PATCH] net/mlx5: prevent ioctl failure log from flood

2024-03-06 Thread Bing Zhao
From: Eli Britstein The following log is printed in WARNING severity: mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed: Operation not supported Reduce the severity to DEBUG to prevent this log from flooding when there are hundreds of ports probed without supporting this flow

[PATCH] config/arm: sort in alphabetical order

2024-03-06 Thread Anoob Joseph
Move 'soc_cn9k' above 'soc_cn10k' to have the list alphabetically sorted. Signed-off-by: Anoob Joseph --- config/arm/meson.build | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 0c24aa8293..3f5fb0f242

RE: [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts

2024-03-06 Thread Pavan Nikhilesh Bhagavatula
Recheck-request: iol-unit-amd64-testing > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, March 6, 2024 9:20 PM > To: Jerin Jacob ; juraj.lin...@pantheon.tech; > n...@arm.com; wathsala.vithan...@arm.com; Ruifeng Wang > ; Bruce Richardson > Cc: dev@dpdk.org; Pavan N

RE: [PATCH v3] app/eventdev: support DMA adapter test

2024-03-06 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, March 7, 2024 12:36 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; Aakash > Sasidharan ; Amit Prakash Shukla > > Subject:

[PATCH v5 5/7] net/hns3: add names for registers

2024-03-06 Thread Jie Hai
This patch adds names for all registers to be dumped. For those who can be directly accessed by their addresses, a new structure containing both name and address is added and the related arrays is refactored and renamed. For the remaining modules, there may be different meanings on different platf

[PATCH v5 7/7] net/hns3: support filter dump of registers

2024-03-06 Thread Jie Hai
This patch supports reporting names of the dfx registers which filtering them by names. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_regs.c | 277 +-- 1 file changed, 230 insertions(+), 47 deletions(-) diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/h

[PATCH v5 6/7] net/hns3: support filter directly accessed registers

2024-03-06 Thread Jie Hai
This patch supports reporting names of registers which can be directly accessed by addresses and filtering them by names. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_regs.c | 198 +-- 1 file changed, 167 insertions(+), 31 deletions(-) diff --git a/drivers/ne

[PATCH v5 4/7] net/hns3: remove dump format of registers

2024-03-06 Thread Jie Hai
Since the driver is going to support reporting names of all registers, remove the counter and insert of separators between different register modules. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_regs.c | 67 ++-- 1 file changed, 18 insertions(+), 49 deletions

[PATCH v5 3/7] net/hns3: fix dump counter of registers

2024-03-06 Thread Jie Hai
Since the driver dumps the queue interrupt registers according to the intr_tqps_num, the counter should be the same. Fixes: acb3260fac5c ("net/hns3: fix dump register out of range") Fixes: 936eda25e8da ("net/hns3: support dump register") Signed-off-by: Jie Hai Cc: sta...@dpdk.org --- drivers/ne

[PATCH v5 1/7] ethdev: support report register names and filter

2024-03-06 Thread Jie Hai
This patch adds "filter" and "names" fields to "rte_dev_reg_info" structure. Names of registers in data fields can be reported and the registers can be filtered by their names. The new API rte_eth_dev_get_reg_info_ext() is added to support reporting names and filtering by names. And the original A

[PATCH v5 2/7] ethdev: add telemetry cmd for registers

2024-03-06 Thread Jie Hai
This patch adds a telemetry command for registers dump, and supports get registers with specified names. The length of the string exported by telemetry is limited by MAX_OUTPUT_LEN. Therefore, the filter should be more precise. An example usage is shown below: --> /ethdev/regs,0,INTR { "/ethdev/

[PATCH v5 0/7] support dump reigser names and filter them

2024-03-06 Thread Jie Hai
The registers can be dumped through the API rte_eth_dev_get_reg_info. However, only register values are exported, which is inconvenient for users to interpret. Therefore, an extension of the structure "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_info_ext is added to support the capability o

Re: [PATCH v5 0/4] add pointer compression API

2024-03-06 Thread Honnappa Nagarahalli
> On Mar 6, 2024, at 4:31 PM, Paul Szczepanek wrote: > > On 02/03/2024 10:33, Morten Brørup wrote: >> I think that a misconception that arch specific optimizations (such as SIMD >> code) required stuff to go into EAL has been prevailing, and this >> misconception is a main reason why EAL has

[PATCH v3] hash: put GFNI stubs back

2024-03-06 Thread Stephen Hemminger
Make the GFNI stub functions always built. This solves the conditional linking problem. If GFNI is available, they will never get used. Fixes: 07d836e5929d ("hash: uninline GFNI stubs") Signed-off-by: Stephen Hemminger --- v3 - fix typo in call to ___rte_thash_gfni_bulk lib/hash/rte_thash_gfni.

RE: [PATCH v3 5/5] net/cxgbe: use rte macro instead of GCC attribute

2024-03-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 6 March 2024 23.15 > > Use existing __rte_may_alias macro from rte_common.h instead of > directly using __attribute__((__may_alias__)). > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

RE: [PATCH v3 4/5] app/test: use rte macro instead of GCC attribute

2024-03-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 6 March 2024 23.15 > > Use newly added __rte_pure macro from rte_common.h instead of > directly using __attribute__((pure)). > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

Re: [PATCH v5 0/4] add pointer compression API

2024-03-06 Thread Paul Szczepanek
On 02/03/2024 10:33, Morten Brørup wrote: I think that a misconception that arch specific optimizations (such as SIMD code) required stuff to go into EAL has been prevailing, and this misconception is a main reason why EAL has become so bloated. Moving features like pointer compression out of E

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread Paul Szczepanek
On 06/03/2024 16:51, David Marchand wrote: On Wed, Mar 6, 2024 at 5:40 PM Bruce Richardson wrote: On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek wrote: If a library has no global section in the version.map allow it not to h

[PATCH v1 1/1] lib: allow libraries with no sources

2024-03-06 Thread Paul Szczepanek
Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Dhruv Tripathi --- lib/meson.build | 176 +--- 1 file changed, 91 insertions(+), 85 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 4fb01f059b..0fcf3336d1 100

[PATCH v1 0/1] allow libraries with no sources

2024-03-06 Thread Paul Szczepanek
I want to add library which is header only. Attempting to build such a a library causes errors during checks. This skips over building libraries while retaining other library functionality. The added lines are the first and last 5. The rest is indentation. Paul Szczepanek (1): lib: allow librari

[PATCH v3 5/5] net/cxgbe: use rte macro instead of GCC attribute

2024-03-06 Thread Tyler Retzlaff
Use existing __rte_may_alias macro from rte_common.h instead of directly using __attribute__((__may_alias__)). Signed-off-by: Tyler Retzlaff --- drivers/net/cxgbe/base/common.h | 2 +- drivers/net/cxgbe/base/t4_hw.c | 2 +- drivers/net/cxgbe/base/t4vf_hw.c | 2 +- 3 files changed, 3 insertion

[PATCH v3 3/5] rcu: use rte macro instead of GCC attribute

2024-03-06 Thread Tyler Retzlaff
Use existing __rte_may_alias macro from rte_common.h instead of directly using __attribute__((__may_alias__)). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/rcu/rcu_qsbr_pvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rcu_qsbr_pvt.h b/lib/rcu

[PATCH v3 2/5] lpm: use rte macro instead of GCC attribute

2024-03-06 Thread Tyler Retzlaff
Use newly added __rte_pure macro from rte_common.h instead of directly using __attribute__((pure)). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/lpm/rte_lpm.c | 4 ++-- lib/lpm/rte_lpm6.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/lpm/rte_lpm

[PATCH v3 4/5] app/test: use rte macro instead of GCC attribute

2024-03-06 Thread Tyler Retzlaff
Use newly added __rte_pure macro from rte_common.h instead of directly using __attribute__((pure)). Signed-off-by: Tyler Retzlaff --- app/test-fib/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-fib/main.c b/app/test-fib/main.c index 75a5613..c49bfe8 10064

[PATCH v3 1/5] eal: add rte pure attribute macro

2024-03-06 Thread Tyler Retzlaff
Add __rte_pure for __attribute__((pure)) to permit elimination of direct use of __attribute__((pure)) in other libs. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/eal/include/rte_common.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/include/rte_common.

[PATCH v3 0/5] use rte macros instead of GCC __attribute

2024-03-06 Thread Tyler Retzlaff
Clean up direct uses of GCC __attribute__((__pure__)) and __attribute__((__may_alias__)). A checkpatch check already warns for new additions. v3: * update series to clean app/drivers/lib v2: * fix typo __rte_pure -> __rte_may_alias in rcu commit message Tyler Retzlaff (5): eal: add rte pur

Re: [PATCH v2 1/1] app/graph: generate cmdline boilerplate

2024-03-06 Thread Thomas Monjalon
12/12/2023 18:05, sk...@marvell.com: > From: Sunil Kumar Kori > > Use the dpdk-cmdline-gen script to autogenerate all the boilerplate > structs and defines for the commandline part of the application. > > Signed-off-by: Sunil Kumar Kori > Acked-by: Bruce Richardson Sorry this patch was not ap

[PATCH v3] hash: put GFNI stubs back

2024-03-06 Thread Stephen Hemminger
Make the GFNI stub functions always built. This solves the conditional linking problem. If GFNI is available, they will never get used. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash_gfni.c | 9 +++-- lib/hash/rte_thash_gfni.h | 30 +++--- lib/hash/version.m

Re: [PATCH] dumpcap: correctly disable promiscuous mode at exit

2024-03-06 Thread Thomas Monjalon
27/02/2024 19:07, Stephen Hemminger: > On Tue, 27 Feb 2024 11:23:26 +0200 > Isaac Boukris wrote: > > > Signed-off-by: Isaac Boukris > > Reviewed-by: Stephen Hemminger Please could you help providing a message for the commit log?

Re: [PATCH v2] test: remove unnecessary rte_srand

2024-03-06 Thread Thomas Monjalon
04/07/2023 01:21, Stephen Hemminger: > The random number is already initialized to a better random > seed during startup process. The calls to rte_srand() are redundant > and actually make entropy worse. > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [EXT] [PATCH] app/test: don't count skipped tests as executed

2024-03-06 Thread Thomas Monjalon
05/03/2024 16:11, Bruce Richardson: > On Tue, Mar 05, 2024 at 02:36:27PM +, Akhil Goyal wrote: > > > Subject: [EXT] [PATCH] app/test: don't count skipped tests as executed > > > The logic around skipped tests is a little confusing in the unit test > > > runner. > > > * Any explicitly disabled t

Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute

2024-03-06 Thread Tyler Retzlaff
On Wed, Mar 06, 2024 at 09:49:31PM +0100, David Marchand wrote: > On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff > wrote: > > > > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > > checkpatch check already warns for new additions. > > > > v2: > > * fix typo __rte_pure -> __r

Re: [PATCH] tests: assume c source files are utf-8 encoded

2024-03-06 Thread Thomas Monjalon
05/03/2024 14:49, Bruce Richardson: > On Tue, Mar 05, 2024 at 02:46:15PM +0100, Robin Jarry wrote: > > Instead of relying on the default locale from the environment (LC_ALL), > > explicitly read the files as utf-8 encoded. > > > > Fixes: 0aeaf75df879 ("test: define unit tests suites based on test

Re: [PATCH] doc: replace code blocks with includes in logging guide

2024-03-06 Thread David Marchand
On Tue, Feb 27, 2024 at 3:22 PM David Marchand wrote: > > Rather than have a block of code as example that gets unaligned as > time passes, add literal includes. > > The coding style guide points at the cfgfile library, let's use it too > as an example. > > Fixes: 97433132c2ed ("lib: use per line

Re: [PATCH] devtools: require version for experimental symbols

2024-03-06 Thread David Marchand
On Tue, Mar 5, 2024 at 2:50 PM David Marchand wrote: > > Add version to all symbols maps and a check so any experimental symbol > is versioned. > > Signed-off-by: David Marchand Applied with some cosmetic change on the doc for Thomas. -- David Marchand

Re: [PATCH] net/ice: add version in symbols map

2024-03-06 Thread David Marchand
On Tue, Mar 5, 2024 at 11:49 AM Bruce Richardson wrote: > > On Tue, Mar 05, 2024 at 11:36:51AM +0100, David Marchand wrote: > > Fixes: 0d8d7bd720ba ("net/ice: support DDP dump switch rule binary") > > Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree") > > > > Signed-off-by: David Marchand >

Re: [PATCH v5 5/6] lpm: replace zero length array with flex array

2024-03-06 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 06/03/2024 20:13, Tyler Retzlaff wrote: Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/lpm/rte_lpm6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v5 3/6] fib: replace zero length array with flex array

2024-03-06 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 06/03/2024 20:13, Tyler Retzlaff wrote: Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- lib/fib/dir24_8.h | 2 +- lib/fib/trie.h| 2 +- 2

Re: [PATCH v5 1/6] hash: replace zero length array with flex array

2024-03-06 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 06/03/2024 20:13, Tyler Retzlaff wrote: Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --

Re: [PATCH v2 2/3] lpm: use rte macro instead of GCC attribute

2024-03-06 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 28/02/2024 18:47, Tyler Retzlaff wrote: Use newly added __rte_pure macro from rte_common.h instead of directly using __attribute__((pure)). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/lpm/rte_lpm.c | 4 ++-- lib/lpm/rte_lpm6.c | 2 +-

Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute

2024-03-06 Thread David Marchand
On Wed, Feb 28, 2024 at 7:48 PM Tyler Retzlaff wrote: > > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > checkpatch check already warns for new additions. > > v2: > * fix typo __rte_pure -> __rte_may_alias in rcu commit message > > Tyler Retzlaff (3): > eal: add rte pure

Re: [PATCH 0/2] dma/skeleton: add support for SG copy and fill ops

2024-03-06 Thread Thomas Monjalon
> Chengwen Feng (2): > dma/skeleton: support SG copy ops > dma/skeleton: support fill ops Applied, thanks.

Re: [PATCH 1/2] dma/skeleton: support SG copy ops

2024-03-06 Thread Thomas Monjalon
26/01/2024 09:57, Chengwen Feng: > Add support scatter gather copy. > > Signed-off-by: Chengwen Feng > --- > --- a/drivers/dma/skeleton/skeleton_dmadev.c > +++ b/drivers/dma/skeleton/skeleton_dmadev.c > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: BSD-3-Clause > - * Copyright(c) 2021 HiSilicon

[PATCH 2/4] net/mlx5: fix templates clean up of FDB control flow rules

2024-03-06 Thread Dariusz Sosnowski
This patch refactors the creation and clean up of templates used for FDB control flow rules, when HWS is enabled. All pattern and actions templates, and template tables are stored in a separate structure, `mlx5_flow_hw_ctrl_fdb`. It is allocated if and only if E-Switch is enabled. During HWS clean

[PATCH 4/4] net/mlx5: fix flow configure validation

2024-03-06 Thread Dariusz Sosnowski
There's an existing limitation in mlx5 PMD, that all configured flow queues must have the same size. Even though this condition is checked, some allocations are done before that. This lead to segmentation fault during rollback on error in rte_flow_configure() implementation. This patch fixes that

[PATCH 3/4] net/mlx5: fix rollback on failed flow configure

2024-03-06 Thread Dariusz Sosnowski
If rte_flow_configure() failed, then some port resources were either not freed, nor reset to the default state. As a result, assumptions in other places in PMD were invalidated and that lead to segmentation faults during release of HW Steering resources when port was closed. This patch adds missin

[PATCH 1/4] net/mlx5/hws: fix direct index insert on dep wqe

2024-03-06 Thread Dariusz Sosnowski
From: Alex Vesker In case a depend WQE was required and direct index was needed we would not set the direct index on the dep_wqe. This leads to incorrect insertion to index zero. Fixes: 38b5bf6452a6 ("net/mlx5/hws: support insert/distribute RTC properties") Cc: sta...@dpdk.org Signed-off-by: Al

Re: [PATCH] net/tap: allow more that 4 queues

2024-03-06 Thread Stephen Hemminger
On Wed, 6 Mar 2024 16:14:51 + Ferruh Yigit wrote: > On 2/29/2024 5:56 PM, Stephen Hemminger wrote: > > The tap device needs to exchange file descriptors for tx and rx. > > But the EAL MP layer has limit of 8 file descriptors per message. > > The ideal resolution would be to increase the numbe

Re: [PATCH v2 1/5] app/test-mp: add multiprocess test

2024-03-06 Thread David Marchand
On Sun, Dec 17, 2023 at 4:54 AM Artemy Kovalyov wrote: > > This commit adds a test scenario that initiates multiple processes > concurrently. These processes attach to the same shared heap, with an > automatic detection mechanism to identify the primary process. > > Signed-off-by: Artemy Kovalyov

[PATCH v5 6/6] table: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/table/rte_table_acl.c | 2 +- lib/table/rte_table_array.c | 2 +- lib/table/rte_table_hash_cuckoo.c | 2 +- lib/table/rte_table_hash_ext.c|

[PATCH v5 5/6] lpm: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/lpm/rte_lpm6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 46d8f71..5cc1bb2 100644 --- a

[PATCH v5 2/6] rcu: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morte

[PATCH v5 3/6] fib: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- lib/fib/dir24_8.h | 2 +- lib/fib/trie.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fib/dir24_8.h

[PATCH v5 4/6] pipeline: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemming

[PATCH v5 0/6] more replacement of zero length array

2024-03-06 Thread Tyler Retzlaff
Replace some missed zero length arrays not captured in the original series. https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=* Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html v5: * no changes, r

[PATCH v5 1/6] hash: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [PATCH 0/6] Coverity related fixes

2024-03-06 Thread David Marchand
On Fri, Mar 1, 2024 at 6:59 PM Stephen Hemminger wrote: > > Some small stuff that can be picked up after 24.03 > > Stephen Hemminger (6): > test/bpf: make sure mbuf is initialized > net/tap: log if netlink ext ack not possible > examples/l2fwd-keepalive: use rte_drand_max > net/qede: repla

Re: [v11 0/4] PCI Dev and SG copy support

2024-03-06 Thread Thomas Monjalon
29/02/2024 14:48, Gowrishankar Muthukrishnan: > Improve dma-perf application to support PCI dev and SG copy, > along with additional supports as below: > - validate copied memory > - skip tests if not opted. > > v11: > - Review suggestions. > > Gowrishankar Muthukrishnan (4): > app/dma-perf:

Re: [PATCH] drivers: use stdatomic API

2024-03-06 Thread Tyler Retzlaff
withdrawing this series. i will submit a new series that tries to address atomics conversion in all drivers. On Wed, Nov 08, 2023 at 11:34:03PM -0800, Tyler Retzlaff wrote: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > Si

Re: [PATCH v8 0/3] test/dma: add vchan reconfig and SG tests

2024-03-06 Thread Thomas Monjalon
16/11/2023 18:45, Gowrishankar Muthukrishnan: > Gowrishankar Muthukrishnan (3): > test/dma: use unit test framework > test/dma: test multiple vchan > test/dma: add SG copy tests Applied, thanks.

Re: [PATCH v4 0/6] more replacement of zero length array

2024-03-06 Thread Tyler Retzlaff
ping Is this one worth closing out as a part of rc2 so it is done? not sure if it's a priority to have lib ~complete. On Thu, Feb 29, 2024 at 02:58:47PM -0800, Tyler Retzlaff wrote: > Replace some missed zero length arrays not captured in the > original series. > https://patchwork.dpdk.org/proje

Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute

2024-03-06 Thread Tyler Retzlaff
ping. Doesn't seem this series carries high risk, worth considering for rc2/rc3? On Wed, Feb 28, 2024 at 10:47:53AM -0800, Tyler Retzlaff wrote: > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > checkpatch check already warns for new additions. > > v2: > * fix typo __rte_

[PATCH v3] app/eventdev: support DMA adapter test

2024-03-06 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- v3: - Resolved review comments. v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 36 ++

Re: [PATCH v7 00/39] use C11 alignas

2024-03-06 Thread Tyler Retzlaff
On Wed, Mar 06, 2024 at 10:55:36AM +0100, David Marchand wrote: > Hello Tyler, > > On Mon, Mar 4, 2024 at 6:53 PM Tyler Retzlaff > wrote: > > > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > locatio

Re: [PATCH] test: set iova=va mode on ppc64 with --no-huge

2024-03-06 Thread Thomas Monjalon
28/11/2023 15:56, Luca Boccassi: > On Tue, 28 Nov 2023 at 14:40, wrote: > > > > From: Christian Ehrhardt > > > > On ppc64, without huge pages, pa would be the default but fails like: > > EAL: Cannot use IOVA as 'PA' since physical addresses are not available > > > > On a normal system setup we'

Re: [PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled

2024-03-06 Thread Thomas Monjalon
23/11/2023 07:42, Rakesh Kudurumalla: > when RTE_ENABLE_ASSERT is defined test_mbuf application is > failing because we are trying to attach extbuf to a cloned > buffer to which external mbuf is already attached.To make > test_mbuf pass CI we have updated ol_flags. This patch fixes > the same. > >

Re: [PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-03-06 Thread David Marchand
On Tue, Feb 20, 2024 at 2:16 PM Chengwen Feng wrote: > > The struct rte_argparse_arg's flags was 64bit type, uint64_t should be > used instead of uint32_t where the operation happened. Something is strange. An enum in C is represented as an int. Plus, this enum type is not used anywhere: lib/arg

Re: [PATCH v2] hash: make GFNI stubs inline (again)

2024-03-06 Thread Thomas Monjalon
05/03/2024 04:07, Stephen Hemminger: > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols. > > This version puts back the rte_thash_gfni function stubs as > inlines, but instead of logging a message, they panic. > This is intentiona

RE: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Power, Ciara
Hi Aaron, > -Original Message- > From: Aaron Conole > Sent: Wednesday, March 6, 2024 2:57 PM > To: Power, Ciara > Cc: Sivaramakrishnan, VenkatX ; Akhil > Goyal ; Ji, Kai ; pr...@iol.unh.edu; > dev@dpdk.org; De Lara Guarch, Pablo ; > Thomas Monjalon ; David Marchand > ; Kevin Traynor > S

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread David Marchand
On Wed, Mar 6, 2024 at 5:40 PM Bruce Richardson wrote: > > On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: > > On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek > > wrote: > > > > > > If a library has no global section in the version.map > > > allow it not to have symbols and not re

Re: [PATCH v2] build: make buffer headroom configurable

2024-03-06 Thread Thomas Monjalon
27/02/2024 17:10, Morten Brørup: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 27 February 2024 17.02 > > > > While this is not likely a setting that many will need to change, it's > > not > > the first time I've heard of users looking to adjust it. > > > > Bec

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread Bruce Richardson
On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: > On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek > wrote: > > > > If a library has no global section in the version.map > > allow it not to have symbols and not report it as an error. > > This happens if a library doesn't export any

[PATCH v7 3/3] config/arm: allow WFE to be enabled config time

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

[PATCH v7 2/3] config/arm: add support for fallback march

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v7 1/3] config/arm: avoid mcpu and march conflicts

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, discard part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a

Re: [PATCH] net/tap: allow more that 4 queues

2024-03-06 Thread Ferruh Yigit
On 2/29/2024 5:56 PM, Stephen Hemminger wrote: > The tap device needs to exchange file descriptors for tx and rx. > But the EAL MP layer has limit of 8 file descriptors per message. > The ideal resolution would be to increase the number of file > descriptors allowed for rte_mp_sendmsg(), but this w

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread David Marchand
On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek wrote: > > If a library has no global section in the version.map > allow it not to have symbols and not report it as an error. > This happens if a library doesn't export any functions > if they're all inline. > > Signed-off-by: Paul Szczepanek Added

Re: [PATCH v3] config/arm: add Marvell Odyssey

2024-03-06 Thread Thomas Monjalon
06/03/2024 06:50, Anoob Joseph: > --- /dev/null > +++ b/config/arm/arm64_odyssey_linux_gcc > @@ -0,0 +1,17 @@ > +[binaries] > +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc'] > +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++'] > +ar = 'aarch64-marvell-linux-gnu-gcc-ar' > +strip = 'aarch64-marvell-

Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Thomas Monjalon
06/03/2024 16:04, Wathsala Wathawana Vithanage: > > > > > > OK > > > What will become this second patch? > > > > > I will suppress patch 2/2. > > Thanks. > I'm not allowed to suppress it, perhaps someone with admin privileges could > do it. We don't suppress anything :) I can change the status to

Re: [PATCH v2 1/4] config/arm: add Neoverse V2 part number

2024-03-06 Thread Thomas Monjalon
20/02/2024 02:45, Honnappa Nagarahalli: > Add Arm Neoverse V2 CPU part number > > Signed-off-by: Honnappa Nagarahalli > Acked-by: Ruifeng Wang > Reviewed-by: Wathsala Vithanage Series applied, thanks.

RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-06 Thread Power, Ciara
> -Original Message- > From: Patrick Robb > Sent: Wednesday, March 6, 2024 2:59 PM > To: Power, Ciara > Cc: Akhil Goyal ; Dooley, Brian ; > Ji, Kai ; De Lara Guarch, Pablo > ; Aaron Conole ; > dev@dpdk.org; Sivaramakrishnan, VenkatX > ; Wathsala Vithanage > ; tho...@monjalon.net; Marcha

RE: [PATCH v2 45/71] event/dlb2: replace use of fixed size rte_memcpy

2024-03-06 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

[PATCH v2] app/dma-perf: add average latency per worker

2024-03-06 Thread Vipin Varghese
Modify the user display data with total average latency per worker. Signed-off-by: Vipin Varghese V2 Changes: - keep one-digit precision is enough, suggested by Chengwen --- app/test-dma-perf/benchmark.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-dma-perf/be

RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Wathsala Wathawana Vithanage
> > > > OK > > What will become this second patch? > > > I will suppress patch 2/2. > Thanks. I'm not allowed to suppress it, perhaps someone with admin privileges could do it.

[PATCH] app/dma-perf: calrify incorrect NUMA config

2024-03-06 Thread Vipin Varghese
Current commit decalres either `source or destination numa is greater than acture numa` as cause of error. Rephrase as `Source or Destination` is incorrect numa by checking which is greater than available numa. Signed-off-by: Vipin Varghese --- app/test-dma-perf/benchmark.c | 3 ++- 1 file chang

RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Wathsala Wathawana Vithanage
> > Joyce is no longer with Arm, and we have not been able to figure out > > this patch. I think the first patch of this series makes sense. > > This second patch to us looks like a nice to have, rather than > > something that fixes an issue. Therefore, we would like to pull this > > patch out of t

Re: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-06 Thread Patrick Robb
On Wed, Mar 6, 2024 at 6:12 AM Power, Ciara wrote: > > > > And this is also failing http://mails.dpdk.org/archives/test-report/2024- > > March/601301.html > > These need to be fixed in CI infra. > > This function that throws the error is available in the recently tagged 1.4 > equivalent Arm repo,

Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Aaron Conole
"Power, Ciara" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole >> Sent: Tuesday, March 5, 2024 6:37 PM >> To: Power, Ciara >> Cc: Sivaramakrishnan, VenkatX ; Akhil >> Goyal ; Ji, Kai ; pr...@iol.unh.edu; >> dev@dpdk.org >> Subject: Re: reg. https://patches.dpdk.org/pro

[PATCH V2] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-06 Thread Wathsala Vithanage
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.05 in snow3g and zuc documentation. Tag SECLIB-IPSEC-2024.03.05 updates IPSec-MB library version to 1.4. Signed-off-by: Wathsala Vithanage Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Jack Bond-Preston

Re: [PATCH 0/2] build eal & ring libraries with MSVC

2024-03-06 Thread Patrick Robb
On Wed, Mar 6, 2024 at 5:00 AM David Marchand wrote: > > On Tue, Feb 27, 2024 at 8:22 PM Tyler Retzlaff > wrote: > > > > Enable build of eal & ring library when building with MSVC. > > > > This series depends on 2 other series that seem to be near being > > accepted for merge. > > > > https://p

Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build

2024-03-06 Thread Thomas Monjalon
> > > > The platform value would be 'native' only when not cross build. > > > > Move the operation about modifying cpu_instruction_set while platform > > > > equals 'native' to the not cross build branch. > > > > > > > > Fixes: bf66003b51ec ("build: use platform for generic and native > > > > build

  1   2   >