[PATCH v2] net/mlx5: set correct priority for meter policy

2024-02-29 Thread Shun Hao
Currently a meter policy's flows are always using the same priority for all colors, so the red color flow might be before green/yellow ones. This will impact the performance cause green/yellow packets will check red flow first and got miss, then match green/yellow flows, introducing more hops. Thi

[PATCH v1] net/mlx5: set correct priority for meter policy

2024-02-29 Thread Shun Hao
Currently a meter policy's flows are always using the same priority for all colors, so the red color flow might be before green/yellow ones. This will impact the performance cause green/yellow packets will check red flow first and got miss, then match green/yellow flows, introducing more hops. Thi

RedHat QE's test result against DPDK release candidate 24.03-rc1

2024-02-29 Thread YangHang Liu
I tested below 18 scenarios on RHEL9 and didn't find any new dpdk issues. - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS - Guest with device assignment(VF) throughput testin

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

2024-02-29 Thread huangdengdui
On 2024/2/29 17:25, Ferruh Yigit wrote: > On 2/29/2024 3:58 AM, huangdengdui wrote: >> >> >> On 2024/2/28 21:07, Ferruh Yigit wrote: >>> On 2/28/2024 2:27 AM, huangdengdui wrote: On 2024/2/27 0:43, Ferruh Yigit wrote: > On 2/26/2024 3:16 AM, Jie Hai wrote: >> On 2024/2/23

[PATCH v3] net/cnxk: support Tx queue descriptor count

2024-02-29 Thread skoteshwar
From: Satha Rao Added CNXK APIs to get used txq descriptor count. Signed-off-by: Satha Rao --- Depends-on: series-30833 ("ethdev: support Tx queue used count") v2: Updated release notes and fixed API for CPT queues. v3: Addressed review comments doc/guides/nics/features/cnxk.ini |

RE: [PATCH] app/crypto-perf: support TLS record

2024-02-29 Thread Akhil Goyal
> Subject: RE: [PATCH] app/crypto-perf: support TLS record > > > > > Added support for latency and throughput measurement of TLS and DTLS > > security ops. > > > > Signed-off-by: Akhil Goyal > > Acked-by: Anoob Joseph > Applied to dpdk-next-crypto

RE: [EXTERNAL] [PATCH v4] common/qat: add virtual qat device (vQAT)

2024-02-29 Thread Akhil Goyal
> This commit adds virtual QAT device to the Intel > QuickAssist Technology PMD. There are three kinds of > virtual QAT device defined which offer different QAT > service to the customers: symmetric crypto, asymmetric > crypto and compression. > > Signed-off-by: Arkadiusz Kusztal > --- Please reb

RE: [EXTERNAL] [PATCH v8 0/3] add QAT GEN LCE device

2024-02-29 Thread Akhil Goyal
> This patchset adds a new QAT LCE device. > The device currently only supports symmetric crypto, > and only the AES-GCM algorithm. > > v8: Rebased on latest next-crypto-for-main. > v7: > - Squashed patch 1 and 2. > - Fixed formatting to leverage 100 char line limit. > - Removed unnecessary

RE: [RFC PATCH 2/2] power: refactor uncore power management library

2024-02-29 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi Lihuisong, > -Original Message- > From: lihuisong (C) > Sent: Friday, March 1, 2024 9:04 AM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > radu.nico...@intel.com; jer...@marvell.com; cristian.dumitre.

[PATCH] net/mlx5: fix VID assignment in VLAN modify

2024-02-29 Thread Gregory Etelson
PMD uses MODIFY_FIELD to implement standalone OF_SET_VLAN_VID flow action. PMD assigned immediate VLAN Id value to the `.level` member of the `rte_flow_action_modify_data` structure instead of `.value`. That assignment has worked because both members had the same offset in the hosting structure. T

[PATCH] net/ice: fix null pointer dereferences

2024-02-29 Thread Wenwu Ma
This patch fixes two null pointer dereferences detected by coverity scan. Coverity issue: 414096 Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_tm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

RE: [PATCH] app/crypto-perf: support TLS record

2024-02-29 Thread Anoob Joseph
> > Added support for latency and throughput measurement of TLS and DTLS > security ops. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

[dpdk-dev] [PATCH v2 2/2] common/cnxk: fix possible out-of-bounds access

2024-02-29 Thread psatheesh
From: Satheesh Paul The subtraction expression in mbox_memcpy() can wrap around causing an out-of-bounds access. Added a check on 'size' to fix this. Coverity issue: 384431, 384439 Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Cc: sta...@dpdk.org Signed-off-by: Sathee

[dpdk-dev] [PATCH v2 1/2] common/cnxk: remove dead code

2024-02-29 Thread psatheesh
From: Satheesh Paul Removed dead code reported by Coverity. Coverity issue: 380992 Fixes: da1ec39060b2 ("common/cnxk: delay inline device RQ enable to dev start") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Nithin Dabilpuram --- v2: * Split the patch and updated commit messa

Re: [RFC PATCH 2/2] power: refactor uncore power management library

2024-02-29 Thread lihuisong (C)
Hi, 在 2024/2/20 23:33, Sivaprasad Tummala 写道: This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the

[PATCH v2] net/cnxk: performance improvement for SW mbuf free

2024-02-29 Thread Rahul Bhansali
Performance improvement is done for Tx fastpath flag MBUF_NOFF when tx_compl_ena is false and mbuf has an external buffer. In such case, Instead of individual external mbuf free before LMTST, a chain of external mbuf will be created and free all after LMTST. This not only improve the performance bu

Re: [RFC PATCH 1/2] power: refactor core power management library

2024-02-29 Thread lihuisong (C)
在 2024/2/20 23:33, Sivaprasad Tummala 写道: This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories with

Re: [PATCH 55/71] net/bnxt: replace use of fixed size rte_memcpy

2024-02-29 Thread Somnath Kotur
On Fri, Mar 1, 2024 at 4:30 AM Stephen Hemminger wrote: > > Automatically generated by devtools/cocci/rte_memcpy.cocci > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnxt/bnxt_flow.c | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff -

[PATCH] app/dumpcap:fix coredump problem because pcap_dump 3th argument is null

2024-02-29 Thread Tianli Lai
if rte_pktmbuf_read() return NULL, pcap_dump() would coredump. Signed-off-by: Tianli Lai --- app/dumpcap/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index d57db0589a..c941fb92bf 100644 --- a/app/dumpcap/main.c +++

RE: [PATCH 1/3] net/nfp: add the elf module

2024-02-29 Thread Chaoyong He
> On 2/27/2024 11:15 AM, Chaoyong He wrote: > > From: Peng Zhang > > > > Add the elf module, which can get mip information from the firmware > > ELF file. > > > > What is MIP? Microcode Information Page > Is it in the .note section of the ELF binary? Yes > How it is used? Which is an interf

Re: [EXT] Re: [PATCH v10 4/4] app/dma-perf: add SG copy support

2024-02-29 Thread fengchengwen
Hi Gowrishankar, On 2024/2/29 21:16, Gowrishankar Muthukrishnan wrote: > Hi Fengcheng, > >> -Original Message- >> From: fengchengwen >> Sent: Wednesday, February 28, 2024 3:02 PM >> To: Amit Prakash Shukla ; Cheng Jiang >> >> Cc: dev@dpdk.org; Jerin Jacob ; Anoob Joseph >> ; Kevin Laatz

RE: [PATCH 3/3] net/nfp: add force reload firmware option

2024-02-29 Thread Chaoyong He
> On 2/27/2024 11:15 AM, Chaoyong He wrote: > > From: Peng Zhang > > > > Add an option to force reload the firmware. > > > > This option can be ignored in some case, for example: > > When using a 2 port NFP card and both with this reload firmware > > option, only the first one will cause the firmw

RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues

2024-02-29 Thread Long Li
> Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > On Thu, 29 Feb 2024 19:29:11 + > Alan Elder wrote: > > > The previous code allowed the number of Tx queues to be set higher > > than the number of Rx queues. If a packet was sent on a Tx queue with > > index > > >= numb

Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-02-29 Thread fengchengwen
Hi Amit, I think this commit will complicated the test, plus futer we may add more test (e.g. fill) I agree Bruce's advise in the [1], let also support "lcore_dma0/1/2", User could provide dma info by two way: 1) lcore_dma=, which seperate each dma with ", ", but a maximum of a certain number

[PATCH 71/71] examples: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 2 +- examples/l2fwd-cat/cat.c | 3 +-- examples/ptpclient/ptpclient.c | 11 +-- examples/vhost/main.c | 5 ++--- examples/vmdq/main.c

[PATCH 70/71] app/test: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test/packet_burst_generator.c | 4 +-- app/test/test_crc.c | 4 +-- app/test/test_cryptodev.c | 18 ++ app/test/test_event_crypto_adapter.c | 12 ++

[PATCH 69/71] app/test-eventdev: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-eventdev/test_pipeline_common.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pip

[PATCH 68/71] app/graph: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/graph/neigh.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/graph/neigh.c b/app/graph/neigh.c index 22be7361e310..a99d2b6981a2 100644 --- a/app/graph/neigh.c +++

[PATCH 67/71] app/test-pmd: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 48 ++--- app/test-pmd/cmdline_flow.c | 24 +-- app/test-pmd/config.c | 8 +++ 3 files changed, 40 insertions(+

[PATCH 66/71] net/mvpp2: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_tm.c b/drivers/net/mvpp2/mrvl_tm.c index 9fac80b867be..a5cdae6d1d0d 100644 --- a/

[PATCH 65/71] net/hinic: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_flow.c | 40 ++ 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pm

[PATCH 64/71] net/gve/base: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/gve/base/gve_adminq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gve/base/gve_adminq.c b/drivers/net/gve/base/gve_adminq.c index 629d15cfbe77..24b00a1

[PATCH 63/71] net/failsafe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 9c013e041

[PATCH 62/71] net/enic: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index a6aaa760ca91..a940c160c9f1 10

[PATCH 61/71] net/e1000: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_flow.c | 22 ++ drivers/net/e1000/igb_pf.c | 6 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/net/e1000/igb_flow.c b/driv

[PATCH 60/71] net/dpaa2: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_tm.c b/drivers/net/dpaa2/dpaa2_tm.c index 8fe5bfa013bb..1749b1be2295 100644 ---

[PATCH 59/71] net/cxgbe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/clip_tbl.c | 2 +- drivers/net/cxgbe/cxgbe_filter.c | 8 drivers/net/cxgbe/l2t.c | 4 ++-- drivers/net/cxgbe/smt.c | 20 +--- 4 file

[PATCH 58/71] net/cpfl: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_vchnl.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH 57/71] net/cnxk: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_ops.c | 2 +- drivers/net/cnxk/cnxk_tm.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/ne

[PATCH 56/71] net/bonding: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.c | 4 ++-- drivers/net/bonding/rte_eth_bond_flow.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_80

[PATCH 55/71] net/bnxt: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_flow.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index

[PATCH 54/71] net/bnx2x: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci. Note: the indentation in this file does not follow the coding standard of DPDK, so it will get some checkpatch warnings. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 32 +++- driver

[PATCH 53/71] net/axgbe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index dd681f15a01e..7ac3010

[PATCH 52/71] net/avp: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 53d9e38c939b..9bd05301720e 100644

[PATCH 51/71] net/af_xdp: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 2d151e45c7cd..8

[PATCH 50/71] ml/cnxk: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cn10k_ml_model.c | 8 +--- drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++ drivers/ml/cnxk/cnxk_ml_ops.c| 2 +- drivers/ml/cnxk/mvtvm_ml_model.c | 8 +--- drivers/ml/

[PATCH 49/71] mempool/dpaa2: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c in

[PATCH 48/71] mempool/dpaa: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa/dpaa_mempool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index 0b484b3d9c7

[PATCH 47/71] event/octeontx: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/octeontx/timvf_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c index 090b3ed1

[PATCH 46/71] event/dpaa2: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 127345

[PATCH 45/71] event/dlb2: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 271bbce54a3a..5c1cd35dbda6 100644 --- a/

[PATCH 44/71] event/cnxk: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_tim_evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cnxk/cnxk_tim_evdev.c index 6d59fdf9098

[PATCH 41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c index a96779f0

[PATCH 43/71] crypto/scheduler: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 6 +++--- drivers/crypto/scheduler/scheduler_failover.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dri

[PATCH 40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 44528eaf7f7a..3e7b

[PATCH 42/71] crypto/qat: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/qat/qat_sym_session.c | 52 +--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_s

[PATCH 39/71] crypto/cnxk: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_se.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.

[PATCH 37/71] compress/qat: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/qat/qat_comp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 559948a46a12..5bcbef

[PATCH 38/71] crypto/ccp: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_crypto.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 4b84b3303e18.

[PATCH 36/71] common/qat: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_qp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index f95dd33375a0..0c30c4d8c18d 10

[PATCH 35/71] common/idpf: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_virtchnl.c | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/idpf_co

[PATCH 34/71] baseband/la12xx: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index bb

[PATCH 33/71] baseband/acc: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 19 +-- drivers/baseband/acc/rte_vrb_pmd.c| 21 ++--- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/drive

[PATCH 32/71] net/qede: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index fd63262f3a47..32fa2016d260 100644 ---

[PATCH 31/71] net/memif: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/memif/memif_socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 649f8d0e618f..f5a3354

[PATCH 30/71] net/ixgbe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++--- drivers/net/ixgbe/ixgbe_fdir.c| 7 ++-- drivers/net/ixgbe/ixgbe_flow.c| 65 ++- drivers/net/ixgbe/ixgbe_ipsec.c |

[PATCH 28/71] net/idpf: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/idpf/idpf_ethdev.c | 7 --- drivers/net/idpf/idpf_rxtx.c | 10 ++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/ne

[PATCH 29/71] net/ipn3ke: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ipn3ke/ipn3ke_flow.c| 32 - drivers/net/ipn3ke/ipn3ke_representor.c | 16 ++--- drivers/net/ipn3ke/ipn3ke_tm.c | 6 ++--- 3 files changed,

[PATCH 27/71] net/ice: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ice/ice_dcf.c | 5 ++-- drivers/net/ice/ice_dcf_parent.c | 2 +- drivers/net/ice/ice_dcf_sched.c| 11 - drivers/net/ice/ice_diagnose.c | 4 ++-- drivers/net/i

[PATCH 26/71] net/iavf: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/iavf/iavf_fdir.c | 93 +--- drivers/net/iavf/iavf_fsub.c | 50 +++ drivers/net/iavf/iavf_generic_flow.c | 2 +- drivers/net/iavf/iavf_t

[PATCH 25/71] net/i40e: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 108 ++-- drivers/net/i40e/i40e_fdir.c| 28 - drivers/net/i40e/i40e_flow.c| 56 - drivers/net/i40e/i40e_

[PATCH 24/71] net/hns3: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_fdir.c | 2 +- drivers/net/hns3/hns3_flow.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c i

[PATCH 23/71] raw/skeleton: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/skeleton/skeleton_rawdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index

[PATCH 22/71] raw/ifpga: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/afu_pmd_he_hssi.c | 2 +- drivers/raw/ifpga/afu_pmd_he_lpbk.c | 2 +- drivers/raw/ifpga/afu_pmd_he_mem.c | 2 +- drivers/raw/ifpga/afu_pmd_n3000.c | 8 drivers/raw/if

[PATCH 20/71] net/tap: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 69d9da695bed..51861

[PATCH 21/71] net/txgbe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 9 ++--- drivers/net/txgbe/txgbe_fdir.c | 6 +-- drivers/net/txgbe/txgbe_flow.c | 65 ++-- drivers/net/txgbe/txgbe_ipsec.c | 8 ++

[PATCH 19/71] net/sfc: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc.c | 2 +- drivers/net/sfc/sfc_ef10_tx.c | 2 +- drivers/net/sfc/sfc_ethdev.c | 11 +-- drivers/net/sfc/sfc_flow.c | 20 ++-- drivers/net/s

[PATCH 18/71] net/pcap: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c| 2 +- drivers/net/pcap/pcap_osdep_freebsd.c | 2 +- drivers/net/pcap/pcap_osdep_linux.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 16/71] net/ngbe: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ngbe/ngbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_pf.c b/drivers/net/ngbe/ngbe_pf.c index 947ae7fe942a..48f578b06626 100644 --- a

[PATCH 17/71] net/null: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 7c46004f1e33..fd8b01b2

[PATCH 15/71] net/nfp: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_conntrack.c | 2 +- drivers/net/nfp/flower/nfp_flower_flow.c| 16 drivers/net/nfp/flower/nfp_flower_representor.c | 2 +- drivers/net/nfp

[PATCH 14/71] net/mlx5: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_devx.c | 4 ++-- drivers/net/mlx5/mlx5_flow.c | 38 drivers/net/mlx5/mlx5_flow_aso.c | 6 ++--- drivers/net/mlx5/mlx5_flow_hw.c | 16 +

[PATCH 13/71] security: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/security/rte_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index e5c862f5f570..28d59ef38831 100644 --

[PATCH 12/71] rib: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Mostly automatically generated by devtools/cocci/rte_memcpy.cocci The fib/trie.c was relying on headers rte_rib6 -> rte_memcpy -> rte_vect since rib6 is no longer using rte_memcpy need to get rte_vect.h Signed-off-by: Stephen Hemminger --- lib/fib/trie.c | 2 +- lib/rib/rte_rib6.h | 3 +--

[PATCH 11/71] pipeline: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_table_action.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c index dfdbc66b087c..c2312d

[PATCH 10/71] pdcp: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pdcp/pdcp_process.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/pdcp/pdcp_process.c b/lib/pdcp/pdcp_process.c index 9b9b881124b8.

[PATCH 08/71] lpm: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 271bc480dc60..3303463fbd0a 100644 --- a/lib/lpm/rte_lpm6.c +++ b/

[PATCH 09/71] node: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/node/ip6_lookup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c index 309964f60fd6..b8e567ccd92d 100644 --- a/lib/node/i

[PATCH 07/71] net: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/rte_ether.c b/lib/net/rte_ether.c index f59c20289d37..761b38f8053f 100644 --- a/lib/net/rte_ether.c +++

[PATCH 06/71] ip_frag: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv6_fragmentation.c | 4 +--- lib/ip_frag/rte_ipv6_reassembly.c| 6 ++ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/ip_frag/rte_ipv6_fragmentation.c b/l

[PATCH 05/71] cryptodev: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index 886eb7adc4a9..137525dc 100644

[PATCH 04/71] eventdev: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 2 +- lib/eventdev/rte_event_dma_adapter.c| 4 ++-- lib/eventdev/rte_event_timer_adapter.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 03/71] ethdev: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- lib/ethdev/rte_flow.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index f1c658f49e80.

[PATCH 02/71] eal: replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index e541f079

[PATCH 00/71] replace use of fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
The DPDK has a lot of "cargo cult" usage of rte_memcpy. This patch set replaces cases where rte_memcpy is used with a fixed size constant size. Typical example is: rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); which can be replaced with: memcpy(mac_addrs, mac.addr_byte

[PATCH 01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

2024-02-29 Thread Stephen Hemminger
Rte_memcpy should not be used for the simple case of copying a fix size structure because it is slower and will hide problems from code analysis tools. Coverity, fortify and other analyzers special case memcpy(). Gcc (and Clang) are smart enough to inline copies which will be faster. Signed-off-b

[PATCH v4 6/6] table: replace zero length array with flex array

2024-02-29 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/table/rte_table_acl.c | 2 +- lib/table/rte_table_array.c | 2 +- lib/table/rte_table_hash_cuckoo.c | 2 +- lib/table/rte_table_hash_ext.c| 2 +- lib/table/rte_table_ha

[PATCH v4 5/6] lpm: replace zero length array with flex array

2024-02-29 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/lpm/rte_lpm6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 271bc48..08fef82 100644 --- a/lib/lpm/rte_lpm6.c +++ b/li

[PATCH v4 2/6] rcu: replace zero length array with flex array

2024-02-29 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morte

[PATCH v4 3/6] fib: replace zero length array with flex array

2024-02-29 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- lib/fib/dir24_8.h | 2 +- lib/fib/trie.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fib/dir24_8.h

  1   2   3   >