https://bugs.dpdk.org/show_bug.cgi?id=1364
Bug ID: 1364
Summary: telemetry conns may leak in certain situation
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
On Fri, 12 Jan 2024 21:49:13 +0100
Morten Brørup wrote:
> > you can use symver in combination with visibility default
> >
> > https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html
> >
> > anyway just food for thought, it would get me out of having to hack &
> > enhance the .def fro
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Friday, 12 January 2024 21.11
>
> On Thu, Jan 11, 2024 at 09:48:33AM +, Bruce Richardson wrote:
> > On Thu, Jan 11, 2024 at 10:38:05AM +0100, Morten Brørup wrote:
> > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.
Removing obsolete code for ACC101 variant which will not be productized.
Hernan Vargas (1):
baseband/acc: remove acc101
doc/guides/bbdevs/acc100.rst | 18 +-
doc/guides/rel_notes/release_24_03.rst | 1 +
drivers/baseband/acc/acc100_pmd.h | 5 +-
drivers/baseband/acc/acc101_
The ACC101 HW variant is not productized, the relevant code is removed
as obsolete.
Signed-off-by: Hernan Vargas
---
doc/guides/bbdevs/acc100.rst | 18 +-
doc/guides/rel_notes/release_24_03.rst | 1 +
drivers/baseband/acc/acc100_pmd.h | 5 +-
drivers/baseband/acc/acc101_pmd.h
On Fri, Jan 12, 2024 at 09:18:58AM -0800, Stephen Hemminger wrote:
> There maybe some application that was using the internal
> RTE_LOGTYPE_XXX macros. Add a release note to inform the
> developer of potential conflicts.
>
> Signed-off-by: Stephen Hemminger
> ---
Acked-by: Tyler Retzlaff
On Thu, Jan 11, 2024 at 09:48:33AM +, Bruce Richardson wrote:
> On Thu, Jan 11, 2024 at 10:38:05AM +0100, Morten Brørup wrote:
> > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > > Sent: Wednesday, 10 January 2024 17.58
> > >
> > > On Wed, Jan 10, 2024 at 03:01:03PM +, Bru
From: Luca Boccassi
These tests are failing with timeouts on build machines with large amount
of cores, so move them out of the fast suite, which should complete in seconds.
33/77 DPDK:fast-tests / lcores_autotest TIMEOUT50.01s
https://build.opensuse.org/package/live_build_lo
Hi Juraj,
Thank you for your review!
On 12/01/2024 13:24, Juraj Linkeš wrote:
I have two extra suggestions apart from the comments below:
There's a typo inside the "How To Write a Test Suite" section:
In that case, nothing will happen when they're is executed.
And Mypy is missing from the list
There maybe some application that was using the internal
RTE_LOGTYPE_XXX macros. Add a release note to inform the
developer of potential conflicts.
Signed-off-by: Stephen Hemminger
---
doc/guides/rel_notes/release_24_03.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_
On Thu, 11 Jan 2024 20:47:44 +0530
wrote:
> @@ -116,7 +119,9 @@ struct rte_eth_fp_ops {
> eth_tx_descriptor_status_t tx_descriptor_status;
> /** Copy used mbufs from Tx mbuf ring into Rx. */
> eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
> - uintptr_t reserved2[2];
>
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.myt...@oracle.com wrote:
> struct ipv4_l3_l4_tuple v4_tuple = {
> - .src_addr = IPv4(*(src_dst_addr + 0),
> - *(src_dst_addr + 1),
> - *(src_dst_add
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.myt...@oracle.com wrote:
> + if (bpf_skb_load_bytes_relative(skb, 0, &nh, sizeof(nh),
> BPF_HDR_START_NET))
> + return TC_ACT_OK;
> + if (nh.iph.version == 4) {
Using IP header bytes, instead of ether header protocol (in skb->proto)
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.myt...@oracle.com wrote:
> 2) Kernel SKB data pointer access not allowed, instead use the BPF helper
> functions.
This is not true, many of the current kernel BPF examples uses skb pointer.
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.myt...@oracle.com wrote:
> - queue = rsskey->queues[(hash % rsskey->nb_queues) &
> -(TAP_MAX_QUEUES - 1)];
> - skb->cb[1] = QUEUE_OFFSET + queue;
> - /* printt("> rss_l3_l4 hash=0x%x queue=%u\n", hash,
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.myt...@oracle.com wrote:
> From: Madhuker Mythri
>
> When multiple queues configured, internally RSS will be enabled and thus TAP
> BPF RSS byte-code will be loaded on to the Kernel using BPF system calls.
>
> Here, the problem is loading the existin
> -Original Message-
> From: Suanming Mou
> Sent: Friday, January 5, 2024 12:03 AM
> To: ano...@marvell.com; Power, Ciara
> Cc: dev@dpdk.org
> Subject: [PATCH v2 1/2] app/test-crypto-perf: fix invalid memcmp results
>
> The function memcmp() returns an integer less than, equal to, or
> -Original Message-
> From: Suanming Mou
> Sent: Thursday, January 4, 2024 2:24 AM
> To: ano...@marvell.com; Power, Ciara
> Cc: dev@dpdk.org
> Subject: [PATCH v2] app/test-crypto-perf: fix invalid mbuf next operation
>
> In fill_multi_seg_mbuf(), when remaining_segments is 0, rte_mbu
On Thu, Jan 11, 2024 at 7:06 AM Kaiwen Deng wrote:
>
> Txonly forwarding engine does not call the Tx preparation API
> before transmitting packets. This may cause some problems.
>
> TSO breaks when MSS spans more than 8 data fragments. Those
> packets will be dropped by Tx preparation API, but it
On 12/22/2023 3:39 PM, Rushil Gupta wrote:
> Read from shared region to retrieve imissed statistics for GQ from device.
> Tested using `show port xstats ` in interactive mode.
> This metric can be triggered by using queues > cores.
>
Looks good but please check following comments:
Checkpatch giv
On Fri, Jan 12, 2024 at 5:23 AM Juraj Linkeš
wrote:
> > diff --git a/dts/.devcontainer/devcontainer.json
> b/dts/.devcontainer/devcontainer.json
> > new file mode 100644
> > index 00..6313cd3ded
> > --- /dev/null
> > +++ b/dts/.devcontainer/devcontainer.json
> > @@ -0,0 +1,33 @@
> > +// F
On 1/12/2024 12:29 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Friday, 12 January 2024 12.34
>>
>> On 1/11/2024 3:17 PM, jer...@marvell.com wrote:
>>> From: Jerin Jacob
>>>
>>> Introduce a new API to retrieve the number of used descriptors
>>> in a Tx queu
Hi Nicolas,
On 1/10/24 23:28, Nicolas Chautru wrote:
Using common code for the status update
during dequeue operation in the VRB PMD.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 139 +
1 file changed, 40 insertions(+), 99 deletions(-)
On 1/12/2024 12:11 PM, David Marchand wrote:
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>
>
> On Fri, Jan 12, 2024 at 12:34 PM Ferruh Yigit wrote:
>>> diff --g
On 12/18/23 16:43, David Marchand wrote:
Logs generated by helpers common to acc100 and vrb drivers were
emitted with a RTE_LOG_NOTICE == 6 == RTE_LOGTYPE_HASH.
Register a dedicated logtype for this.
Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
Signed-off-by: Da
On 12/18/23 16:43, David Marchand wrote:
This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
all logs for both acc100 and vrb drivers would be emitted for
pmd.baseband.acc logtype.
It seems the intent was to have dedicated logtypes per driver, so
register one for each wi
Tested-by: Martin Spinler
Acked-by: Martin Spinler
On Fri, 2023-12-22 at 09:11 -0800, Stephen Hemminger wrote:
> All drivers should be using dynamic logtype.
>
> Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/nfb/nfb.h|
On 12/18/23 14:59, David Marchand wrote:
diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h
index 9b1b1defc5..01911514bd 100644
--- a/drivers/net/virtio/virtio_logs.h
+++ b/drivers/net/virtio/virtio_logs.h
@@ -16,19 +16,20 @@ extern int virtio_logtype_init;
#
Tested-by: Martin Spinler
Acked-by: Martin Spinler
---
Hi! Thanks for the cleanup. I've tested that patchset and works fine.
I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges
with the "Remove uses of PMD logtype" series as they slightly differs
(both links below).
Stephen,
I have two extra suggestions apart from the comments below:
There's a typo inside the "How To Write a Test Suite" section:
In that case, nothing will happen when they're is executed.
And Mypy is missing from the list of linters in the "DTS Developer
Tools" section, could you please add it?
> diff
On Thu, Jan 11, 2024 at 7:45 AM Harman Kalra wrote:
>
> Adding support for parsing multiple representor devargs strings
> passed to a PCI BDF. There may be scenario where port representors
> for various PFs or VFs under PFs are required and all these are
> representor ports shall be backed by sing
Hi Jerin,
> Introduce a new API to retrieve the number of used descriptors
> in a Tx queue. Applications can leverage this API in the fast path to
> inspect the Tx queue occupancy and take appropriate actions based on the
> available free descriptors.
>
> A notable use case could be implementing
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Friday, 12 January 2024 12.34
>
> On 1/11/2024 3:17 PM, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > Introduce a new API to retrieve the number of used descriptors
> > in a Tx queue. Applications can leverage this API in the fa
On 12/7/2023 6:56 PM, Stephen Hemminger wrote:
> Replace static logtype with dynamic logtype and
> remove dead code. Compile tested on Fedora.
>
> Stephen Hemminger (3):
> net/nfb: remove unused device args
> net/nfb: make device path local to init function
> net/nfb: use dynamic logtype
>
On Fri, Jan 12, 2024 at 12:34 PM Ferruh Yigit wrote:
> > diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h
> > index 4bfaf79c6c..d3f09f390d 100644
> > --- a/lib/ethdev/rte_ethdev_core.h
> > +++ b/lib/ethdev/rte_ethdev_core.h
> > @@ -60,6 +60,9 @@ typedef uint16_t (*eth_recyc
On 12/14/2023 10:24 AM, Chaoyong He wrote:
> This patch series fix some problems of flower firmware.
>
> Long Wu (3):
> net/nfp: fix close representor problem
> net/nfp: fix free resource problem
> net/nfp: free domain ID in close interface
>
Series applied to dpdk-next-net/main, thanks.
On 1/11/2024 3:17 PM, jer...@marvell.com wrote:
> From: Jerin Jacob
>
> Introduce a new API to retrieve the number of used descriptors
> in a Tx queue. Applications can leverage this API in the fast path to
> inspect the Tx queue occupancy and take appropriate actions based on the
> available fre
On Fri, Dec 22, 2023 at 6:46 PM Stephen Hemminger
wrote:
>
> These three libraries were depending on static logtypes.
>
> Stephen Hemminger (3):
> port: convert to dynamic log type
> table: convert to dynamic logtype
> pipeline: convert to a dynamic logtype
>
> lib/log/log.c |
On Mon, Dec 11, 2023 at 9:33 PM Stephen Hemminger
wrote:
>
> With a little setup in eventdev_pmd.h the eventdev drivers
> and API can be converted to dynamic log type.
>
> Signed-off-by: Stephen Hemminger
Applied, thanks.
--
David Marchand
On 1/8/2024 9:15 PM, Morten Brørup wrote:
>> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
>> Sent: Monday, 8 January 2024 11.54
>>
>> On Tue, Dec 19, 2023 at 10:59:48PM +0530, jer...@marvell.com wrote:
>>> From: Jerin Jacob
>>>
>>> Introduce a new API to retrieve the number of availa
Hi Thomas,
On 2023/11/7 4:59, Thomas Monjalon wrote:
> 11/10/2023 11:55, fengchengwen:
>> Hi Thomas,
>>
>> Sorry for the late reply.
>>
>> On 2023/8/14 22:16, Thomas Monjalon wrote:
>>> jeudi 3 août 2023, fengchengwen:
Hi Thomas,
On 2023/7/31 20:48, Thomas Monjalon wrote:
> 10
Add tracepoints at data path APIs for tracing support.
Signed-off-by: Chengwen Feng
Acked-by: Morten Brørup
---
lib/dmadev/meson.build | 2 +-
lib/dmadev/rte_dmadev.h | 56 +++---
lib/dmadev/rte_dmadev_trace_fp.h | 150 +++
lib/dmade
> diff --git a/dts/.devcontainer/devcontainer.json
> b/dts/.devcontainer/devcontainer.json
> new file mode 100644
> index 00..6313cd3ded
> --- /dev/null
> +++ b/dts/.devcontainer/devcontainer.json
> @@ -0,0 +1,33 @@
> +// For format details, see https://aka.ms/devcontainer.json. For config
On 1/12/2024 1:19 AM, Chaoyong He wrote:
>> On 1/11/2024 2:02 AM, Chaoyong He wrote:
On 1/9/2024 7:56 AM, Chaoyong He wrote:
>> On 12/18/2023 1:50 AM, Chaoyong He wrote:
On 12/14/2023 10:24 AM, Chaoyong He wrote:
> From: Long Wu
>
> Set the representor arr
Hi Andrew
Thanks for review
Please find response inline
> -Original Message-
> From: Andrew Rybchenko
> Sent: Friday, January 12, 2024 12:56 PM
> To: Harman Kalra ; Ajit Khaparde
> ; Somnath Kotur
> ; John Daley ;
> Hyong Youb Kim ; Yuying Zhang
> ; Beilei Xing ; Qiming Yang
> ; Qi Zhang
On Fri, Jan 12, 2024 at 1:33 PM David Marchand
wrote:
>
> Hi Jerin,
>
> On Thu, Jan 11, 2024 at 4:32 PM wrote:
> >
> > From: Jerin Jacob
> >
> > Introduce a new API to retrieve the number of used descriptors
> > in a Tx queue. Applications can leverage this API in the fast path to
> > inspect th
On 12/19/23 04:33, Suanming Mou wrote:
The new item type is added for the case user wants to match traffic
based on packet field compare result with other fields or immediate
value.
e.g. take advantage the compare item user will be able to accumulate
a IPv4/TCP packet's TCP data_offset and IPv4
On 1/9/24 17:07, Ori Kam wrote:
-Original Message-
From: Suanming Mou
Sent: Tuesday, December 19, 2023 3:34 AM
Current rte_flow_action_modify_data struct describes the pkt
field perfectly and is used only in action.
It is planned to be used for item as well. This commit renames
it t
Add support for matching VXLAN-GPE tunnel header.
Signed-off-by: Gavin Li
Acked-by: Itamar Gozlan
Acked-by: Dariusz Sosnowski
---
doc/guides/rel_notes/release_24_03.rst | 6 ++
drivers/net/mlx5/hws/mlx5dr_definer.c | 117 +
drivers/net/mlx5/hws/mlx5dr_definer.h | 1
This adds matching on the reserved fields of VXLAN-GPE header (the 16-bits
before Next Protocol and the last 8-bits).
To support all the header fields, tunnel_header_0_1 should be supported by
FW and misc5_cap is set.
If one of the reserved fields is matched on, misc5 is used for matching.
Otherw
Add support for VXLAN-GPE rsvd0 and rsvd1 fields in flow rule pattern to
testpmd
Signed-off-by: Gavin Li
Acked-by: Dariusz Sosnowski
---
app/test-pmd/cmdline_flow.c | 20
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 ++
2 files changed, 22 insertions(+)
Add support for VXLAN-GPE flags field in flow rule pattern to testpmd.
Signed-off-by: Gavin Li
Acked-by: Dariusz Sosnowski
---
app/test-pmd/cmdline_flow.c | 10 ++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1 +
2 files changed, 11 insertions(+)
diff --git a/app/tes
Previously, VXLAN-GPE in DPDK only supports VNI and next protocol header
fields. This patch series add support for flags and reserved field 0 and
1.
Below is the VXLAN-GPE header defined in the lasted draft.
0 1 2 3
0 1 2 3 4 5 6 7 8 9
Hi Jerin,
On Thu, Jan 11, 2024 at 4:32 PM wrote:
>
> From: Jerin Jacob
>
> Introduce a new API to retrieve the number of used descriptors
> in a Tx queue. Applications can leverage this API in the fast path to
> inspect the Tx queue occupancy and take appropriate actions based on the
> available
This commit adds support for matching on the flags field of VXLAN-GPE
header (the first 8-bits).
Signed-off-by: Gavin Li
Acked-by: Dariusz Sosnowski
---
drivers/net/mlx5/mlx5_flow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
i
55 matches
Mail list logo
