[dpdk-dev] [PATCH 2/2] net/cnxk: support PPPoE flow item type

2023-12-13 Thread psatheesh
From: Satheesh Paul Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type for cnxk device. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vec.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1 +

[dpdk-dev] [PATCH 1/2] common/cnxk: support PPPoE flow item type in ROC API

2023-12-13 Thread psatheesh
From: Satheesh Paul Added ROC API changes to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc.h | 1 + drivers/common/cnxk/roc_npc_parse.c | 5 + 2 files changed, 6 insertions(+) diff --git a

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Jerin Jacob
On Thu, Dec 14, 2023 at 10:28 AM Sevincer, Abdullah wrote: > > Acked-by: Abdullah Sevincer Updated the git commit as follows and applied to dpdk-next-net-eventdev/for-main. Thanks event/dlb2: remove unnecessary timer call Consult the timer value only when the driver waits for a tim

[PATCH v2 3/3] net/iavf: add Tx LLDP command

2023-12-13 Thread Zhichao Zeng
This patch adds an IAVF testpmd command "set tx lldp on|off" which will register an mbuf dynflag IAVF_TX_LLDP_DYNFLAG at the application level to indicate the need to send LLDP packet. Currently, it only supports turning on. For avx512, need to close the Tx port first, then "set tx lldp on", and r

[PATCH v2 2/3] net/iavf: support Tx LLDP on AVX512

2023-12-13 Thread Zhichao Zeng
This patch adds an avx512 ctx Tx path that supports context descriptor, filling in the SWTCH_UPLINK bit based on mbuf dynflag IAVF_TX_LLDP_DYNFLAG to support sending LLDP packet. Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx.c| 5 + drivers/net/iavf/iavf_rxtx.h

[PATCH v2 1/3] net/iavf: support Tx LLDP on scalar

2023-12-13 Thread Zhichao Zeng
This patch adds an mbuf dynflag IAVF_TX_LLDP_DYNFLAG to determine whether or not to fill the SWTCH_UPLINK bit in the Tx context descriptor to send LLDP packet. Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx.c| 5 + drivers/net/iavf/rte_pmd_iavf.h | 2 ++ 2 files changed, 7 in

[PATCH v2 0/3] net/iavf: support Tx LLDP on scalar and AVX512

2023-12-13 Thread Zhichao Zeng
This patch set adds an IAVF testpmd command "set tx lldp on|off" which will register an mbuf dynflag IAVF_TX_LLDP_DYNFLAG at the application level, currently only supported turning on. IAVF will fill the SWTCH_UPLINK bit in the Tx context descriptor based on the mbuf dynflag to send the LLDP packe

[PATCH v2] net/ixgbe: fix memoy leak after device init failure

2023-12-13 Thread Yunjian Wang
In ixgbe_ipsec_ctx_create() allocated memory for the 'security_ctx', we should free it when errors occur, otherwise it will lead to memory leak. Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v2: just resend the patch, maintainer feedba

[PATCH v2] net/iavf: support rte flow with mask for FDIR

2023-12-13 Thread Zhichao Zeng
This patch supports rte flow with mask for FDIR, including eth/ipv4/ipv6/tcp/udp flow items, where src/dst for ipv4/ipv6 and sport/dport for tcp/udp are realized by switch filter. Signed-off-by: Zhichao Zeng --- v2: implemented by switch filter --- drivers/net/iavf/iavf_fdir.c | 262 +++

RE: [PATCH RESEND] net/iavf: fix memoy leak in error path

2023-12-13 Thread Zhang, Qi Z
> -Original Message- > From: Yunjian Wang > Sent: Thursday, December 14, 2023 9:46 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; xudin...@huawei.com; > jerry.lili...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [PATCH RESEND] net/iavf: fix memoy le

[PATCH 2/2] net/mlx5: add compare item support

2023-12-13 Thread Suanming Mou
The compare item allows adding flow match with comparison result. This commit adds compare item support to the pmd code. Due to HW limitation: - Only HWS supported. - Only 32-bit comparison is supported. - Only single compare flow is supported in the flow table. - Only match with compare resul

[PATCH 1/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2023-12-13 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2023-12-13 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH 4/4] net/mlx5: add modify field action ADD fields validation

2023-12-13 Thread Suanming Mou
Due to HW limitation, not all the fields are available as ADD_FIELD destination. This commit adds the validation to the destinations. Signed-off-by: Suanming Mou --- doc/guides/rel_notes/release_24_03.rst | 4 drivers/net/mlx5/mlx5_flow_hw.c| 32 ++ 2 files

[PATCH 2/4] net/mlx5: rename modify copy destination to destination

2023-12-13 Thread Suanming Mou
In the mlx5_flow_field_id_to_modify_info() function, for the coming new ADD_FILED operation will also use that dcopy as ADD_FIELD's destination. This commit renames the dcopy to dest which makes things much clearer. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h| 2 +- driver

[PATCH 0/4] net/mlx5: add modify field ADD fields support

2023-12-13 Thread Suanming Mou
Before this series, the modify_field ADD operation in mlx5 PMD only allowed sum of immediate value to field. ADD_FIELD operation allows user to add the src field value to the dest field. Dest field has the sum of src field value and original dst field value. Suanming Mou (4): net/mlx5: add TCP

[PATCH 3/4] net/mlx5: add modify field action ADD fields support

2023-12-13 Thread Suanming Mou
ADD_FIELD operation allows user to add the src field value to the dest field. Dest field has the sum of src field value and original dst field value. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 11 +++ drivers/net/mlx5/mlx5_flow_hw.c | 10 +++--- 2 files changed

[PATCH 1/4] net/mlx5: add TCP/IP length modify field

2023-12-13 Thread Suanming Mou
This commit adds TCP data offset, IPv4 total length, IPv4 IHL, IPv6 payload length in modify field operation. Signed-off-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h | 4 drivers/net/mlx5/mlx5_flow_dv.c | 40 + 2 files changed, 44 insertions(+) diff

RE: [PATCH] ixgbe: fix interrupt clear mask for eimc register

2023-12-13 Thread Zhang, Qi Z
> -Original Message- > From: Simon Ellmann > Sent: Friday, December 8, 2023 11:44 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Simon Ellmann > Subject: [PATCH] ixgbe: fix interrupt clear mask for eimc register > > 32nd bit of the eimc register is reserved according to th

RE: [PATCH] net/i40e: remove redundant judgment in fdir parse

2023-12-13 Thread Zhang, Qi Z
> -Original Message- > From: Kaiwen Deng > Sent: Friday, November 24, 2023 3:01 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Zhang, > Yuying ; Xing, Beilei ; Wu, > Jingjing > Subject: [PATCH] net/i40e: remove redundant judgment in fdir p

[PATCH] ethdev: add dump regs for telemetry

2023-12-13 Thread Jie Hai
The ethdev library now registers a telemetry command for dump regs. An example usage is shown below: --> /ethdev/regs,test { "/ethdev/regs": { "regs_offset": 0, "regs_length": 3192, "regs_width": 4, "device_version": "0x1080f00", "regs_file": "port_0_regs_test" } } Signed-

RE: [EXT] [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Devendra Singh Rawat
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, December 13, 2023 10:06 PM >To: dev@dpdk.org >Cc: Stephen Hemminger ; Devendra Singh >Rawat ; Alok Prasad >Subject: [EXT] [PATCH v3 14/37] net/qede: replace RTE_LOG_DP with >rte_log_dp > >External Email > >--

[PATCH v2] net/ice: fix link update

2023-12-13 Thread Qi Zhang
The ice_aq_get_link_info function is not thread-safe. However, it is possible to simultaneous invocations during both the dev_start and the LSC interrupt handler, potentially leading to unexpected adminq errors. This patch addresses the issue by introducing a thread-safe wrapper that utilizes a spi

RE: [PATCH v3 30/37] raw/ifpga: replace PMD logtype with dynamic type

2023-12-13 Thread Xu, Rosen
Hi, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, December 14, 2023 12:36 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Xu, Rosen > ; Tianfei Zhang > Subject: [PATCH v3 30/37] raw/ifpga: replace PMD logtype with dynamic type > > Driver should not be using PMD logtyp

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Dec 13, 2023 at 11:50:46AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > We only need to consult the timer value when the driver waits for a >> > timeout, so skip making the call to get the current timer/TSC value if >> > the timeout is zero,

RE: [PATCH v3 10/37] net/mana: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Long Li
> Subject: [PATCH v3 10/37] net/mana: replace RTE_LOG_DP with rte_log_dp > > Want datapath logs to use own logtype. > > Signed-off-by: Stephen Hemminger Acked-by: Long Li > --- > drivers/net/mana/mana.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mana

RE: [PATCH v2 10/25] net/mana: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Long Li
> Subject: [PATCH v2 10/25] net/mana: replace RTE_LOG_DP with rte_log_dp > > Want datapath logs to use own logtype. > > Signed-off-by: Stephen Hemminger Acked-by: Long Li > --- > drivers/net/mana/mana.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mana

Re: [PATCH v2 00/14] support new 5760X P7 devices

2023-12-13 Thread Ajit Khaparde
On Wed, Dec 13, 2023 at 6:49 AM Ajit Khaparde wrote: > > On Tue, Dec 12, 2023 at 11:57 PM David Marchand > wrote: > > > > On Wed, Dec 13, 2023 at 6:34 AM Ajit Khaparde > > wrote: > > > > > > On Sat, Dec 9, 2023 at 5:31 PM Ajit Khaparde > > > wrote: > > > > > > > > While some of the patches ref

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Bruce Richardson
On Wed, Dec 13, 2023 at 11:50:46AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > We only need to consult the timer value when the driver waits for a > > timeout, so skip making the call to get the current timer/TSC value if > > the timeout is zero, as no wait will ever be done. > >

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Had a bad config value - retryin

[PATCH v3 37/37] crypto/dpaa_sec, crypto/dpaa2_sec: replace use of PMD logtype

2023-12-13 Thread Stephen Hemminger
Use macro consistently for all logs and rte_log_dp() for datapath. Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 +++--- drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 4 ++-- drivers/crypto/dpaa_sec/dpaa_sec.c | 4 ++-- drivers/crypto/dpaa_sec/dpaa

[PATCH v3 36/37] crypto/scheduler: replace use of logtype PMD

2023-12-13 Thread Stephen Hemminger
Driver has logging macro but not used everywhere. Fixes: 6760463c9f26 ("crypto/scheduler: add mode-specific threshold parameter") Signed-off-by: Stephen Hemminger --- drivers/crypto/scheduler/scheduler_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s

[PATCH v3 35/37] crypto/ccp: do not use PMD logtype

2023-12-13 Thread Stephen Hemminger
This driver has logging macros but not used consistently. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/rte_ccp_pmd.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd

[PATCH v3 34/37] crypto/caam_jr: replace logtype PMD

2023-12-13 Thread Stephen Hemminger
The driver has macros for logging, they just weren't used everywhere. Signed-off-by: Stephen Hemminger --- drivers/crypto/caam_jr/caam_jr.c | 8 +++- drivers/crypto/caam_jr/caam_jr_log.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/caam_jr/caam_jr

[PATCH v3 32/37] event/dpaa, event/dpaa2: use local logtype

2023-12-13 Thread Stephen Hemminger
The driver has macros to use local logtype, but some changes added PMD log messages. Signed-off-by: Stephen Hemminger --- drivers/event/dpaa/dpaa_eventdev.c| 2 +- drivers/event/dpaa2/dpaa2_eventdev.c | 4 ++-- drivers/event/dpaa2/dpaa2_eventdev_logs.h | 2 +- drivers/ev

[PATCH v3 33/37] event/skeleton: replace logtype PMD with dynamic type

2023-12-13 Thread Stephen Hemminger
The skeleton is supposed to match current best practices. Change it to use dynamic logtype. Signed-off-by: Stephen Hemminger --- drivers/event/skeleton/skeleton_eventdev.c | 3 ++- drivers/event/skeleton/skeleton_eventdev.h | 8 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --g

[PATCH v3 31/37] event/dlb2: replace logtype PMD with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Use local logtype for all log messages. Signed-off-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c | 5 ++--- drivers/event/dlb2/dlb2_log.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 050ace0904b4..5a1

[PATCH v3 30/37] raw/ifpga: replace PMD logtype with dynamic type

2023-12-13 Thread Stephen Hemminger
Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h b/drivers/raw

[PATCH v3 29/37] raw/dpaa2_cmdif: replace PMD logtype with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Use local logtype for datapath logs. Signed-off-by: Stephen Hemminger --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h index 8991e8327d68..

[PATCH v3 28/37] raw/cnxk_gpio: replace PMD logtype with dynamic type

2023-12-13 Thread Stephen Hemminger
Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 22 --- drivers/raw/cnxk_gpio/cnxk_gpio.h | 4 +++ drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 31 +++--

[PATCH v3 27/37] raw/cnxk_bphy: replace PMD logtype with dynamic type

2023-12-13 Thread Stephen Hemminger
Driver should not be using PMD logtype, they should have their own logtype. Signed-off-by: Stephen Hemminger --- drivers/raw/cnxk_bphy/cnxk_bphy.c | 3 ++- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 31 +++--- driver

[PATCH v3 26/37] vdpa/ifc: replace use of RTE_LOGTYPE_PMD

2023-12-13 Thread Stephen Hemminger
This driver is using RTE_LOGTYPE_PMD, fix to have a dynamic type. Signed-off-by: Stephen Hemminger --- drivers/vdpa/ifc/base/ifcvf.c | 14 +++--- drivers/vdpa/ifc/base/ifcvf_osdep.h | 9 +++-- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/vdpa/ifc/bas

[PATCH v3 25/37] mempool/dpaa, mempool/dpaa2: do not use logtype PMD

2023-12-13 Thread Stephen Hemminger
The driver already has a logtype, just not consistently used. Signed-off-by: Stephen Hemminger --- drivers/mempool/dpaa/dpaa_mempool.h | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 2 +- 3 files changed, 4 insertions(+),

[PATCH v3 24/37] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/dma/dpaa/dpaa_qdma_logs.h | 5 +++-- drivers/dma/dpaa2/dpaa2_qdma_logs.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/dpaa/dpaa_qdma_logs.h b/drivers/dma/dpaa/dpaa_qdma_l

[PATCH v3 23/37] bus/fslmc: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/fslmc_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h index a1e14dd84e9a..edd74af04d7c 100644 --- a/drivers/bus

[PATCH v3 21/37] basband/la12xx: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h b/drivers/baseband/la12xx/bbdev_la12xx_pmd_logs.h index

[PATCH v3 22/37] bus/cdx: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/bus/cdx/cdx_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h index a1046ce544a6..e432fae00e4d 100644 --- a/drivers/bus/cdx/cdx_log

[PATCH v3 20/37] common/dpaax: do not use PMD logtype

2023-12-13 Thread Stephen Hemminger
Use existing dpaax_logger log type instead of PMD. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/compat.h | 5 - drivers/common/dpaax/dpaax_logs.h | 2 +- drivers/common/dpaax/version.map | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v3 19/37] common/sfc_efx: remove use of PMD logtype

2023-12-13 Thread Stephen Hemminger
This code was implemented in a slightly different manner than all the other logging code (for no good reason). Make it the same and handle errors in same way as other drivers. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/sfc_efx.c | 11 ++- drivers/common/sfc_efx/sfc_e

[PATCH v3 18/37] common/cpt: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_pmd_logs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/cpt_pmd_logs.h b/drivers/common/cpt/cpt_pmd_logs.h index 174326c6ce38..6b78fcb6b6fc 100644 --- a/d

[PATCH v3 17/37] common/cnxk: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_platform.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h index ba23b2e

[PATCH v3 16/37] net/vmxnet3: do not use PMD logtype

2023-12-13 Thread Stephen Hemminger
The driver used a slightly different (and older) format for datapath logs. Remove PMD logtype here. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- drivers/net/vmxnet3/vmxnet3_logs.h | 12 2 files changed, 9 insertions(+), 5 deletions(-) diff --

[PATCH v3 15/37] net/virtio: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_logs.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h index 9b1b1defc5a6..0447ee961fb6 1

[PATCH v3 14/37] net/qede: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/qede/qede_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 3187d97bb7b0..f7aa14df7e3b 100644 --- a/driver

[PATCH v3 13/37] net/pfe: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_logs.h | 3 +-- drivers/net/pfe/pfe_logs.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_logs.h b/drivers/net/octeontx/octeo

[PATCH v3 12/37] net/octeon_ep: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/octeon_ep/otx_ep_common.h | 7 +++ drivers/net/octeon_ep/otx_ep_rxtx.c | 5 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octe

[PATCH v3 11/37] net/mvpp2: do not use PMD logtype

2023-12-13 Thread Stephen Hemminger
The driver already has a logtype but it was not being used in one place. Fixes: 9e79d810911d ("net/mvpp2: support Tx scatter/gather") Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrv

[PATCH v3 10/37] net/mana: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/mana/mana.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h index 6836872dc257..8d60f9172d44 100644 --- a/drivers/net/mana/mana.h +++ b/dr

[PATCH v3 09/37] net/igc: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Junfeng Guo --- drivers/net/igc/igc_logs.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/igc/igc_logs.h b/drivers/net/igc/igc_logs.h index 11071a32b542..ffa1981bae32 10

[PATCH v3 08/37] net/enetc, net/enetfec: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/enetc/enetc_logs.h | 2 +- drivers/net/enetfec/enet_pmd_logs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/enetc/enetc_logs.h b/drivers/net/enetc/enetc_logs.h index

[PATCH v3 07/37] net/dpaa2: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa2_pmd_logs.h | 2 +- drivers/net/dpaa2/dpaa2_sparser.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_et

[PATCH v3 06/37] net/dpaa: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index ef4c06d

[PATCH v3 05/37] net/bnxt: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h | 5 + drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- drivers/net/bnxt/bnxt_txr.c | 4 +--- 4 fi

[PATCH v3 04/37] net/avp: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/avp/avp_logs.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/avp/avp_logs.h b/drivers/net/avp/avp_logs.h index 6e297c7a4a81..0ae95a7685c5 100644 --- a/d

[PATCH v3 03/37] net/atlantic: replace RTE_LOG_DP with rte_log_dp

2023-12-13 Thread Stephen Hemminger
Want datapath logs to use own logtype. Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_logs.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h index e3dba334fe92..c2a3a6320c58 10064

[PATCH v3 02/37] log: add rte_log_dp()

2023-12-13 Thread Stephen Hemminger
Add a new macro for logging in datapath using a logtype. The existing macro RTE_LOG_DP() takes log type suffix (i.e. PMD) like RTE_LOG(). This macro allows using a dynamic type. Ideally, rte_log_dp() could be an always_inline function but GCC and Clang will not inline a function with variable numb

[PATCH v3 01/37] log: fix doc comment for RTE_LOG_DP()

2023-12-13 Thread Stephen Hemminger
The macro does not return a numeric status, only void. Fixes: 5d8f0baf69ea ("log: do not drop debug logs at compile time") Signed-off-by: Stephen Hemminger --- lib/log/rte_log.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h index 4d207b8da2cd..05

[PATCH v3 00/37] Replace uso of RTE_LOGTYPE_PMD

2023-12-13 Thread Stephen Hemminger
The generic RTE_LOGTYPE_PMD is a leftover and should be removed. As a first step, fix many drivers to not use it, and add a helper for the RTE_LOG_DP(). Most of this patchset is boiler plate but there were some places where use of PMD type snuck in with later changes to the original driver. v3 -

Re: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Aaron Conole
Bruce Richardson writes: > We only need to consult the timer value when the driver waits for a > timeout, so skip making the call to get the current timer/TSC value if > the timeout is zero, as no wait will ever be done. > > Signed-off-by: Bruce Richardson > --- Recheck-request: github-robot

RE: [PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

Re: [PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD

2023-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2023 09:00:48 +0100 David Marchand wrote: > On Wed, Dec 13, 2023 at 5:19 AM Stephen Hemminger > wrote: > > > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > > As a first step, fix many drivers to not use it, and add a > > helper for the RTE_LOG_DP(). > > I

Re: [PATCH v2 00/14] support new 5760X P7 devices

2023-12-13 Thread Ajit Khaparde
On Tue, Dec 12, 2023 at 11:57 PM David Marchand wrote: > > On Wed, Dec 13, 2023 at 6:34 AM Ajit Khaparde > wrote: > > > > On Sat, Dec 9, 2023 at 5:31 PM Ajit Khaparde > > wrote: > > > > > > While some of the patches refactor and improve existing code, > > > this series adds support for the new

Re: [PATCH v3 2/9] eventdev: clarify all-types flag documentation

2023-12-13 Thread Mattias Rönnblom
On 2023-12-12 12:32, Bruce Richardson wrote: Rather than requiring that any device advertising the RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered and parallel scheduling, we can redefine the field so that it basically means that you don't need to specify the queue schedulin

Re: [PATCH v3 2/9] eventdev: clarify all-types flag documentation

2023-12-13 Thread Jerin Jacob
On Tue, Dec 12, 2023 at 6:58 PM Bruce Richardson wrote: > > Rather than requiring that any device advertising the > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES flag support all of atomic, ordered > and parallel scheduling, we can redefine the field so that it basically > means that you don't need to specify

[v4] net/af_xdp: enable uds_path instead of use_cni

2023-12-13 Thread Maryam Tahhan
With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a DPDK pod is requesting multiple net devices and these devices are from different pools, then the container attempts to mount all the netdev UDSes in the pod as /tmp/afxdp.sock. Which means th

[PATCH] event/dlb2: remove unnecessary timer call

2023-12-13 Thread Bruce Richardson
We only need to consult the timer value when the driver waits for a timeout, so skip making the call to get the current timer/TSC value if the timeout is zero, as no wait will ever be done. Signed-off-by: Bruce Richardson --- drivers/event/dlb2/dlb2.c | 6 -- 1 file changed, 4 insertions(+),

Re: [v3] net/af_xdp: enable uds-path instead of use_cni

2023-12-13 Thread Maryam Tahhan
On 12/12/2023 14:25, Koikkara Reeny, Shibin wrote: Thank you Maryam updating the document. I have added some comment below. Also what do you think about changing the name of the document file "af_xdp_cni.rst" to "af_xdp_dp.rst" ? Yes - I can update. Background -- -The standar

[PATCH v3] examples/packet_ordering: fix segfault in disable_reorder mode

2023-12-13 Thread Qian Hao
The packet_ordering example works in two modes (opt via --disable-reorder): - When reorder is enabled: rx_thread - N*worker_thread - send_thread - When reorder is disabled: rx_thread - N*worker_thread - tx_thread N parallel worker_thread(s) generate out-of-order packets. When reorder is enable

[PATCH v2] examples/packet_ordering: fix segfault in disable_reorder mode

2023-12-13 Thread Qian Hao
The packet_ordering example works in two modes (opt via --disable-reorder): - When reorder is enabled: rx_thread - N*worker_thread - send_thread - When reorder is disabled: rx_thread - N*worker_thread - tx_thread N parallel worker_thread(s) generate out-of-order packets. When reorder is enable

Re: [PATCH 0/2] fix problem in Rx

2023-12-13 Thread Ferruh Yigit
On 12/11/2023 5:45 AM, Chaoyong He wrote: > Fix two problems in the receive function. > > Long Wu (2): > net/nfp: fix receive function memory leak > net/nfp: fix invalid Rx descriptor data > Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v2 00/25] Replace use of RTE_LOGTYPE_PMD

2023-12-13 Thread David Marchand
On Wed, Dec 13, 2023 at 5:19 AM Stephen Hemminger wrote: > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > As a first step, fix many drivers to not use it, and add a > helper for the RTE_LOG_DP(). I don't see why we need a new rte_log_dp helper. The #define RTE_LOGTYPE_XXX tr