RE: [PATCH v4 00/10] Replace zero length arrays

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 20 November 2023 18.07 > > Zero length arrays are a GNU extension that has been > superseded by flex arrays. > > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > > These are places found by cocci/zero_length_array

RE: [PATCH v1] test/crypto: fix timeout in Rx inject

> > Fix the timeout condition for rx in Rx inject. > > Fixes: 69e1a909aa08 (test/crypto: add Rx inject) > > Signed-off-by: Vidya Sagar Velumuri > Acked-by: Anoob Joseph

[PATCH v1] test/crypto: fix timeout in Rx inject

Fix the timeout condition for rx in Rx inject. Fixes: 69e1a909aa08 (test/crypto: add Rx inject) Signed-off-by: Vidya Sagar Velumuri diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 96a3f36d73..58561ededf 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptode

RE: [EXT] [PATCH v2 2/3] usertools/rss: add --info flag

> -Original Message- > From: Robin Jarry > Sent: Monday, November 20, 2023 9:53 PM > To: dev@dpdk.org > Subject: [EXT] [PATCH v2 2/3] usertools/rss: add --info flag > > External Email > > -- > Add a flag to print the RSS

RE: [EXT] [PATCH v2 1/3] usertools/rss: add driver abstractions

> -Original Message- > From: Robin Jarry > Sent: Monday, November 20, 2023 9:53 PM > To: dev@dpdk.org > Subject: [EXT] [PATCH v2 1/3] usertools/rss: add driver abstractions > > External Email > > -- > The default RETA si

RE: [EXT] [PATCH 1/2] usertools/rss: add driver abstractions

> -Original Message- > From: Robin Jarry > Sent: Monday, October 23, 2023 1:37 PM > To: dev@dpdk.org > Cc: Sunil Kumar Kori ; tho...@monjalon.net; > jerinjac...@gmail.com; Robin Jarry > Subject: [EXT] [PATCH 1/2] usertools/rss: add driver abstractions > > External Email > >

RE: [EXT] [PATCH v2 3/3] usertools/rss: add CNXK well-known key

Thanks Robin for adding key for CNXK platform. Regards Sunil Kumar Kori > -Original Message- > From: Robin Jarry > Sent: Monday, November 20, 2023 9:53 PM > To: dev@dpdk.org > Cc: Sunil Kumar Kori > Subject: [EXT] [PATCH v2 3/3] usertools/rss: add CNXK well-known key > > External Emai

RE: [EXT] [PATCH v4 03/10] security: replace zero length array with flex array

> Zero length arrays are GNU extension. Replace with standard flex array. > > Signed-off-by: Stephen Hemminger > Reviewed-by: Tyler Retzlaff Acked-by: Anoob Joseph

RE: [EXT] [PATCH v4 02/10] cryptodev: replace zero length array with flex array

> Zero length arrays are GNU extension. Replace with standard flex array. > > Signed-off-by: Stephen Hemminger > Reviewed-by: Tyler Retzlaff Acked-by: Anoob Joseph

Re: [PATCH v2 01/16] eal: verify strdup return value

在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup() return value logic. Fixes: 293c53d8b23c ("eal: add telemetry callbacks") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/common/eal_common_options.c | 24 +++

Re: [PATCH v2 04/16] bus/vdev: verify strdup return value

Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup return value logic. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/vdev/vdev.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v2 16/16] examples/vhost: verify strdup return value

Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup return value logic. Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/vhost/main.c | 3 +++ 1 file changed, 3 insertions(+) d

Re: [PATCH v2 11/16] app/test: verify strdup return value

Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test/process.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app

Re: [PATCH 00/21] replace strtok with strtok_r

On 2023/11/15 23:08, Stephen Hemminger wrote: On Wed, 15 Nov 2023 12:27:37 +0100 Morten Brørup wrote: just a final follow up, i can see that we already have a rte_strerror here to do the replace with reentrant dance. it is probably good to follow the already established pattern for this and ha

Re: [PATCH v2 13/16] app/test-dma-perf: verify strdup return value

Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup return value logic. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-dma-perf/main.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH v2 14/16] app/testpmd: verify strdup return value

Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [PATCH v5 5/5] net/mvneta: fix possible out-of-bounds write

Acked-by: Huisong Li 在 2023/11/6 15:31, Chengwen Feng 写道: The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Sig

RE: [PATCH v4 05/10] net/nfp: replace zero length array with flex array

Acked-by: Chaoyong He > Zero length arrays are GNU extension. Replace with standard flex array. > > Signed-off-by: Stephen Hemminger > Acked-by: Niklas Söderlund > Reviewed-by: Tyler Retzlaff > --- > drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

RE: [PATCH 24.03 3/8] event/dlb2: add schedule-type capability flags

Acked-by: Abdullah Sevincer

Re: [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types

On Mon, Nov 20, 2023 at 11:18:14PM +0530, Jerin Jacob wrote: > On Mon, Nov 20, 2023 at 11:08 PM Bruce Richardson > wrote: > > > > Not all eventdev's support all scheduling types, for example, some may > > only support atomic scheduling or others only support ordered > > scheduling. There is curren

Re: [PATCH 24.03 1/8] eventdev: add capability flags for supported sched types

On Mon, Nov 20, 2023 at 11:08 PM Bruce Richardson wrote: > > Not all eventdev's support all scheduling types, for example, some may > only support atomic scheduling or others only support ordered > scheduling. There is currently no clear indication for each driver what > sched types it supports, s

Re: [dpdk-dev] [PATCH v2] doc: define qualification criteria for external library

On Sun, Nov 19, 2023 at 2:23 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Sunday, 19 November 2023 08.08 > > > > On Fri, Nov 17, 2023 at 1:57 PM Morten Brørup > > wrote: > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > Sent: Frida

Re: [PATCH v7 07/21] dts: dts runner and main docstring update

On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 128 --- dts/main.py | 8 ++- 2 files changed, 112 insertions(+), 24 del

Re: release candidate 23.11-rc3

Hi, IBM - Power Systems DPDK v23.11-rc3-2-g6d7129a6e9 * Build CI on Fedora 30,31,34,36,37,38 for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 9.2 kernel: 5.14.0-284.25.1.el9_2.ppc64le with gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC)

[PATCH 24.03 8/8] event/sw: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/sw.ini | 3 +++ drivers/event/sw/sw_evdev.c | 3 +++ 2 files changed, 6 insertions(+) d

[PATCH 24.03 7/8] event/opdl: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- Maintainers, please check this patch carefully, as I'm not sure the correct way to document this. According to the docs for th

[PATCH 24.03 6/8] event/octeontx: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/octeontx.ini | 3 +++ drivers/event/octeontx/ssovf_evdev.c | 3 +++ 2 files changed, 6 inse

[PATCH 24.03 5/8] event/dsw: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/dsw.ini | 1 + drivers/event/dsw/dsw_evdev.c | 1 + 2 files changed, 2 insertions(+) dif

[PATCH 24.03 4/8] event/dpaa*: add schedule-type capability flags

Document explicitly the scheduling types supported by these drivers, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/dpaa.ini | 2 ++ doc/guides/eventdevs/features/dpaa2.ini | 2 ++ drivers/event/dpaa/dpaa_event

[PATCH 24.03 3/8] event/dlb2: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/dlb2.ini | 3 +++ drivers/event/dlb2/dlb2.c | 5 - 2 files changed, 7 insertions

[PATCH 24.03 2/8] event/cnxk: add schedule-type capability flags

Document explicitly the scheduling types supported by this driver, both via info_get() function, and via table in the documentation. Signed-off-by: Bruce Richardson --- doc/guides/eventdevs/features/cnxk.ini | 3 +++ drivers/event/cnxk/cnxk_eventdev.c | 5 - 2 files changed, 7 insertions

[PATCH 24.03 1/8] eventdev: add capability flags for supported sched types

Not all eventdev's support all scheduling types, for example, some may only support atomic scheduling or others only support ordered scheduling. There is currently no clear indication for each driver what sched types it supports, so add capability flags to be indicated on return from rte_event_dev_

[PATCH 24.03 0/8] document scheduling types for eventdev drivers

The various eventdev drivers, while fitting under a common API, do not all support all scheduling types. The eventdev API is missing some way to query the particular scheduling support for a driver, a key piece of information for application developers. This patchset adds the necessary capability f

[PATCH v4 10/10] common/dpaxx: remove zero length array

There is a place holder zero length array in this driver. But since the structure is embedded in other structures, it could not have been safely used anyway. There doesn't appear to be any uses of it in the current code. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/desc/ips

[PATCH v4 09/10] net/cpfl: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers

[PATCH v4 08/10] pdcp: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff Acked-by: Anoob Joseph --- lib/pdcp/pdcp_entity.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pdcp/pdcp_entity.h b/lib/pdcp/pdcp_enti

[PATCH v4 07/10] net/mlx5: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_prm.h | 2 +- drivers/net/mlx5/mlx5.h| 4 ++-- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_tx.h | 3 ++-

[PATCH v4 06/10] net/enic: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Acked-by: John Daley Reviewed-by: Tyler Retzlaff --- drivers/net/enic/base/vnic_devcmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/base/vnic_devcm

[PATCH v4 05/10] net/nfp: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Acked-by: Niklas Söderlund Reviewed-by: Tyler Retzlaff --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/flowe

[PATCH v4 04/10] pipeline: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- lib/pipeline/rte_swx_pipeline_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/p

[PATCH v4 03/10] security: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- drivers/crypto/cnxk/cn10k_ipsec.h | 4 +++- drivers/crypto/cnxk/cn9k_ipsec.h | 4 +++- lib/security/rte_security_driver.h | 2 +- 3 files changed, 7 insert

[PATCH v4 02/10] cryptodev: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- drivers/crypto/cnxk/cnxk_se.h | 5 - lib/cryptodev/cryptodev_pmd.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/c

[PATCH v4 01/10] member: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Reviewed-by: Tyler Retzlaff --- lib/member/rte_member_heap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h i

[PATCH v4 00/10] Replace zero length arrays

Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html These are places found by cocci/zero_length_array.cocci v4 - fix issues reported by clang where zero length array was embedded in security structures in cn10k

Re: [PATCH] net/gve: add support for 4K ring size only for DQO

On 11/20/2023 8:04 AM, Rushil Gupta wrote: > Bump up the dpdk dqo driver ring size to 4096. > The queue size is controlled by queue_setup method. > > Signed-off-by: Rushil Gupta > Reviewed-by: Joshua Washington > Applied to dpdk-next-net/main, thanks.

Re: [PATCH v3] config/arm: correct cpu arch for cross build

20/11/2023 10:24, Joyce Kong: > The cn10k cross build file sets cpu to 'armv8.6-a' while > it is armv8.5-a arch. > Meanwhile, the cpu field in the cross file doesn't take > effect as config/arm/meson.build controls machine_args > for march. Then change the 'cpu' value in all arm cross > files to 'a

Re: [PATCH v6 2/2] dts: reformat to 100 line length

20/11/2023 13:36, Juraj Linkeš: > Reformat to 100 from the previous 88 to unify with C recommendations. > > The C recommendation is the maximum with the ideal being 80. The Python > tools are not suitable for this flexibility. > > We require all patches with DTS code to be validated with the > de

Re: [PATCH v2 3/3] usertools/rss: add CNXK well-known key

On Mon, 20 Nov 2023 17:22:59 +0100 Robin Jarry wrote: > diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py > index fd225a697f08..be9b3d760c03 100755 > --- a/usertools/dpdk-rss-flows.py > +++ b/usertools/dpdk-rss-flows.py > @@ -226,6 +226,23 @@ def reta_size(self, num_queues: i

Re: [PATCH v7 06/21] dts: logger and utils docstring update

On Mon, Nov 20, 2023 at 5:23 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/logger.py | 72 ++--- > > dt

Re: [PATCH v7 04/21] dts: exceptions docstring update

On Mon, Nov 20, 2023 at 5:22 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/__init__.py | 12 - > > dts/framework/exception.py

Re: [PATCH v7 09/21] dts: test result docstring update

On Thu, Nov 16, 2023 at 11:47 PM Jeremy Spewock wrote: > > The only comments I had on this were a few places where I think attribute > sections should be class variables instead. I tried to mark all of the places > I saw it and it could be a difference where because of the way they are > subcla

Re: [PATCH] buildtools: allow reusing dpdk-cmdline-gen.py when used a subproject

On Mon, Nov 20, 2023 at 05:28:15PM +0100, Robin Jarry wrote: > When DPDK is used as a subproject, allow declaring wrap files that > provide dpdk-cmdline-gen.py. > > This way, find_program('dpdk-cmdline-gen.py') will return the path to > the script in the DPDK subproject source tree. > > Link: >

[PATCH] buildtools: allow reusing dpdk-cmdline-gen.py when used a subproject

When DPDK is used as a subproject, allow declaring wrap files that provide dpdk-cmdline-gen.py. This way, find_program('dpdk-cmdline-gen.py') will return the path to the script in the DPDK subproject source tree. Link: https://mesonbuild.com/Wrap-dependency-system-manual.html#provide-section Link

Re: [PATCH v7 08/21] dts: test suite docstring update

On Thu, Nov 16, 2023 at 11:16 PM Jeremy Spewock wrote: > > > > On Wed, Nov 15, 2023 at 8:12 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> dts/framework/test_suite.py | 223

[PATCH v2 3/3] usertools/rss: add CNXK well-known key

Add default RSS key for CNXK platforms. CNXK platform uses 48 bytes long key for hash calculations and a default RETA size of 64. Example: ~$ usertools/dpdk-rss-flows.py 8 28.0.0.0/24 40.0.0.0/24 -k cnxk SRC_IP DST_IP QUEUE 28.0.0.140.0.0.1 7 28.0.0.140.0.0.2 2

[PATCH v2 2/3] usertools/rss: add --info flag

Add a flag to print the RSS key and RETA size that are used to compute balanced traffic. Example: $ usertools/dpdk-rss-flows.py -i 4 1.0.0.0 2.2.0.0/24 -k mlx RSS key: 2cc681d15bdbf4f7fca28319db1a3e946b9e38d92c9c03d1ad9944a7d… RETA size: 4 SRC_IP DST_IP QUEUE 1.0.0.02.2.0.1

[PATCH v2 1/3] usertools/rss: add driver abstractions

The default RETA size is not the same for all drivers. In some drivers (mlx5), the RETA size may also be dependent on the number of RX queues. Introduce a new DriverInfo abstraction for known keys. Define a simple API to expose the RSS key and RETA size (based on the number of RX queues). Use tha

Re: [PATCH v7 06/21] dts: logger and utils docstring update

On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 ++--- dts/framework/utils.py | 88 + 2 files ch

Re: [PATCH v7 04/21] dts: exceptions docstring update

On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+),

Re: [PATCH v7 07/21] dts: dts runner and main docstring update

On Thu, Nov 16, 2023 at 10:51 PM Jeremy Spewock wrote: > > > > On Wed, Nov 15, 2023 at 8:11 AM Juraj Linkeš > wrote: >> >> Format according to the Google format and PEP257, with slight >> deviations. >> >> Signed-off-by: Juraj Linkeš >> --- >> dts/framework/dts.py | 128 +++

Re: [PATCH v7 01/21] dts: code adjustments for doc generation

On Thu, Nov 16, 2023 at 10:05 PM Jeremy Spewock wrote: > > > > On Wed, Nov 15, 2023 at 8:11 AM Juraj Linkeš > wrote: >> >> The standard Python tool for generating API documentation, Sphinx, >> imports modules one-by-one when generating the documentation. This >> requires code changes: >> * prope

Re: [PATCH v7 03/21] dts: add basic developer docs

On 11/15/23 13:09, Juraj Linkeš wrote: Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/

Re: [PATCH v7 02/21] dts: add docstring checker

On 11/15/23 13:09, Juraj Linkeš wrote: Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working v

Re: [PATCH v7 01/21] dts: code adjustments for doc generation

On 11/15/23 13:09, Juraj Linkeš wrote: The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by

Re: [PATCH v2 0/3] doc/hns3: update the features for hns3

> On 11/20/2023 11:14 AM, Huisong Li wrote: >> This series fix some feature description and update features for hns3. >> >> Hope this series merge into 23.11. >> >> --- >> v2: patch [2/3] add fixes tag of each feature to track the relevant code >> commit. >> >> Huisong Li (3): >> doc/hns

RE: [EXT] Re: [PATCH 1/2] usertools/rss: add driver abstractions

Sure Robin, I will review it and revert ASAP. Regards Sunil Kumar Kori > -Original Message- > From: Robin Jarry > Sent: Monday, November 20, 2023 6:59 PM > To: dev@dpdk.org > Cc: Sunil Kumar Kori ; tho...@monjalon.net; > jerinjac...@gmail.com > Subject: [EXT] Re: [PATCH 1/2]

Re: [PATCH v3 4/7] dts: allow passing parameters into interactive apps

On Fri, Nov 17, 2023 at 7:08 PM Jeremy Spewock wrote: > > > > On Thu, Nov 16, 2023 at 1:53 PM Juraj Linkeš > wrote: >> >> On Mon, Nov 13, 2023 at 9:28 PM wrote: >> > >> > From: Jeremy Spewock >> > >> > Modified interactive applications to allow for the ability to pass >> > parameters into the

Re: [PATCH v3 5/7] dts: add optional packet filtering to scapy sniffer

On Fri, Nov 17, 2023 at 7:06 PM Jeremy Spewock wrote: > > > > On Thu, Nov 16, 2023 at 1:34 PM Juraj Linkeš > wrote: >> >> As I'm thinking about the filtering, it's not a trivial manner. For >> now, I'd like to pass a class instead of multiple parameters, as that >> will be easier to extend if we

Re: [PATCH 1/2] usertools/rss: add driver abstractions

Hi, Jerin, Sunil Komar, Could you have a look at this series and report if it brings the needed abstractions for integrating CNXK? Thanks!

Re: [RFC PATCH] usertools: add telemetry exporter

Gentle ping. Is anybody interested in this?

Re: [PATCH v7 21/21] dts: test suites docstring update

On 11/20/23 10:17, Juraj Linkeš wrote: On Thu, Nov 16, 2023 at 6:36 PM Yoan Picchi wrote: On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 +

Re: [PATCH] cmdline-gen: fix error when command list has empty lines

17/11/2023 12:22, Bruce Richardson: > On Thu, Nov 16, 2023 at 12:18:13PM +0100, Robin Jarry wrote: > > Fix the following error when a command list file contains empty lines: > > > > Traceback (most recent call last): > > File "buildtools/dpdk-cmdline-gen.py", line 202, in > > main() > > F

[PATCH v6 2/2] dts: reformat to 100 line length

Reformat to 100 from the previous 88 to unify with C recommendations. The C recommendation is the maximum with the ideal being 80. The Python tools are not suitable for this flexibility. We require all patches with DTS code to be validated with the devtools/dts-check-format.sh script, part of whi

[PATCH v6 1/2] doc: increase python max line length to 100

Unify with C recommendations which allow line length of up to 100 characters. Signed-off-by: Juraj Linkeš Acked-by: Bruce Richardson --- .editorconfig| 2 +- doc/guides/contributing/coding_style.rst | 1 + dts/pyproject.toml | 4 ++-- 3 files ch

RE: [PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow

Acked-by: Jie Hai mailto:haij...@huawei.com>> Hai Jie Email：haij...@huawei.com 发件人： lihuisong (C)mailto:lihuis...@huawei.com>> 收件人： devmailto:dev@dpdk.org>>;ferruh.yigitmailto:ferruh.yi...@amd.com>>;haijiemailto:haij...@huawei.com>>

RE: [PATCH v2 2/3] doc/hns3: update the features for hns3

Acked-by: Jie Hai mailto:haij...@huawei.com>> Hai Jie Email：haij...@huawei.com 发件人： lihuisong (C)mailto:lihuis...@huawei.com>> 收件人： devmailto:dev@dpdk.org>>;ferruh.yigitmailto:ferruh.yi...@amd.com>>;haijiemailto:haij...@huawei.com>>

RE: [PATCH v2 1/3] doc/hns3: fix compilation option about max queue number

Acked-by: Jie Hai mailto:haij...@huawei.com>> Hai Jie Email：haij...@huawei.com 发件人： lihuisong (C)mailto:lihuis...@huawei.com>> 收件人： devmailto:dev@dpdk.org>>;ferruh.yigitmailto:ferruh.yi...@amd.com>>;haijiemailto:haij...@huawei.com>>;

[PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow

The hns3 driver supports for creating rule base on input tuple, hash key, queues and hash algorithm. But hash key, queues and hash algorithm are the global configuration for hardware which will affect other rules. The rule just setting input tuple is completely independent. Fixes: 63a0f65c9572 ("d

[PATCH v2 2/3] doc/hns3: update the features for hns3

Update the features for hns3. - "Basic stats" and "Extended stats" supported by Fixes: 8839c5e202f3 ("net/hns3: support device stats") - "Traffic Management API" supported by Fixes: c09c7847d892 ("net/hns3: support traffic management") - "Speed capabilities" supported by Fixes: 09e0de1f411b ("ne

[PATCH v2 0/3] doc/hns3: update the features for hns3

This series fix some feature description and update features for hns3. Hope this series merge into 23.11. --- v2: patch [2/3] add fixes tag of each feature to track the relevant code commit. Huisong Li (3): doc/hns3: fix compilation option about max queue number doc/hns3: update the fe

[PATCH v2 1/3] doc/hns3: fix compilation option about max queue number

This patch fixes the description of compilation option about setting max queue number. The maximum queue number of HIP09 and HIP10 is determined by the RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF and the value the firmware report. Fixes: 21938cf4e43e ("doc: add build config option in hns3 guide") Cc: sta..

Re: [PATCH 2/3] doc/hns3: update the features for hns3

在 2023/11/20 18:53, Ferruh Yigit 写道: On 11/20/2023 10:48 AM, lihuisong (C) wrote: 在 2023/11/20 17:56, Ferruh Yigit 写道: On 11/20/2023 7:55 AM, Huisong Li wrote: Update the features for hns3. Signed-off-by: Huisong Li ---   doc/guides/nics/hns3.rst | 10 +-   1 file changed, 9 inser

Re: [PATCH 2/3] doc/hns3: update the features for hns3

On 11/20/2023 10:48 AM, lihuisong (C) wrote: > > 在 2023/11/20 17:56, Ferruh Yigit 写道: >> On 11/20/2023 7:55 AM, Huisong Li wrote: >>> Update the features for hns3. >>> >>> Signed-off-by: Huisong Li >>> --- >>>   doc/guides/nics/hns3.rst | 10 +- >>>   1 file changed, 9 insertions(+), 1 del

Re: [PATCH 2/3] doc/hns3: update the features for hns3

在 2023/11/20 17:56, Ferruh Yigit 写道: On 11/20/2023 7:55 AM, Huisong Li wrote: Update the features for hns3. Signed-off-by: Huisong Li --- doc/guides/nics/hns3.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

On 11/17/2023 4:22 PM, Stephen Hemminger wrote: > On Fri, 17 Nov 2023 09:29:41 + > Ferruh Yigit wrote: > I agree using 'l3_len' instead is correct fix. But this requires ABI/API change, plus do we have any reason to keep the padding, discarding it as this patch does i

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

On 11/20/2023 9:21 AM, Deng, KaiwenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, November 17, 2023 8:50 AM >> To: Stephen Hemminger >> Cc: Deng, KaiwenX ; dev@dpdk.org; >> sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Singh, Aman Deep ; >> Zhang, Yuying

Re: [PATCH 0/3] doc/hns3: fix hns3 doc

On 11/20/2023 7:54 AM, Huisong Li wrote: > This series fix some feature description and update features for hns3. > > Hope this series merge into 23.11. > > Huisong Li (3): > doc/hns3: fix compilation option about max queue number > doc/hns3: update the features for hns3 > doc/hns3: fix the

Re: [PATCH v7 21/21] dts: test suites docstring update

On Thu, Nov 16, 2023 at 6:36 PM Yoan Picchi wrote: > > On 11/15/23 13:09, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/tests/TestSuite_hello_world.py | 16 + > > dts/tests/TestS

Re: [PATCH 2/3] doc/hns3: update the features for hns3

On 11/20/2023 7:55 AM, Huisong Li wrote: > Update the features for hns3. > > Signed-off-by: Huisong Li > --- > doc/guides/nics/hns3.rst | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst > index 7eac1b3c92..11d0

Re: [PATCH v2] net/txgbe: fix out of bound access

On 11/20/2023 1:51 AM, Jiawen Wu wrote: > On Friday, November 17, 2023 6:12 PM, ferruh.yi...@amd.com wrote: >> Reported by SuSe CI [1] by GCC [2], possibly false positive. Error: >> >> In function 'txgbe_host_interface_command', >> inlined from 'txgbe_host_interface_command' >> a

RE: [PATCH] app/test-pmd: fix L4 checksum with padding data

> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 17, 2023 9:14 AM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Singh, Aman Deep ; > Zhang, Yuying ; Matz, Olivier > ; De Lara Guarch, Pablo > > Subject: Re: [PATCH] app/test-p

[PATCH v3] config/arm: correct cpu arch for cross build

The cn10k cross build file sets cpu to 'armv8.6-a' while it is armv8.5-a arch. Meanwhile, the cpu field in the cross file doesn't take effect as config/arm/meson.build controls machine_args for march. Then change the 'cpu' value in all arm cross files to 'auto'. Signed-off-by: Joyce Kong Reviewed

RE: [PATCH] app/test-pmd: fix L4 checksum with padding data

> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 17, 2023 8:50 AM > To: Stephen Hemminger > Cc: Deng, KaiwenX ; dev@dpdk.org; > sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Singh, Aman Deep ; > Zhang, Yuying ; Matz, Olivier > ; De Lara Guarch, Pablo > > Subject:

RE: [PATCH v2] config/arm: correct cpu arch for cross build

> -Original Message- > From: Thomas Monjalon > Sent: Sunday, November 12, 2023 8:54 PM > To: Ruifeng Wang ; Joyce Kong > > Cc: bruce.richard...@intel.com; dev@dpdk.org; nd > Subject: Re: [PATCH v2] config/arm: correct cpu arch for cross build > > 07/11/2023 04:26, Joyce Kong: > > The

[PATCH] net/mlx5: fix offset field size in conntrack action

In mlx5 PMD, struct mlx5_aso_ct_action represents a single ASO CT object inside a ASO CT bulk, which is used to implement conntrack flow action. offset field, which is 16 bits wide, in this struct represents an offset of the given object inside a bulk. When SW Steering flow engine is used, ASO CT

[PATCH] net/gve: add support for 4K ring size only for DQO

Bump up the dpdk dqo driver ring size to 4096. The queue size is controlled by queue_setup method. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.c | 8 drivers/net/gve/gve_ethdev.c | 4 ++-- drivers/net/gve/gve_ethdev.h | 1 +