RE: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 13 November 2023 00.32 > > On Sun, 12 Nov 2023 09:30:24 +0100 > Morten Brørup wrote: > > > > > +static_assert(sizeof(struct rte_event) == 16, "Event structure > size > > > is not 16-bytes in size"); > > > > + > > > >

RE: [PATCH] net/mlx5/hws: fix typo in the log

2023-11-12 Thread Suanming Mou
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, November 13, 2023 3:21 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; Suanming > Mou ; Ori Kam > Cc: dev@dpdk.org; Erez Shitrit ; sta...@dpdk.org > Subject: [PATCH] net/mlx5/hws: fix typo in the log > > Change "cu

[PATCH] net/mlx5: zero encap UDP csum for IPv4 too

2023-11-12 Thread Bing Zhao
From: Eli Britstein A zero UDP csum indicates it should not be validated by the receiver. The HW may not calculate UDP csum after encap. The cited commit made sure the UDP csum is zero for UDP over IPv6, mistakenly not handling UDP over IPv4. Fix it. Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP

[PATCH] net/mlx5: fix shared Rx queue list management

2023-11-12 Thread Bing Zhao
In shared Rx queue case, the shared control structure could only be released after the last port's dereference in the group. There is another management list that holding all of the used Rx queues' structures for a port. If the reference count of a control structure is changed to zero during port

[PATCH] net/mlx5: fix shared Rx queue list management

2023-11-12 Thread Bing Zhao
In shared Rx queue case, the shared control structure could only be released after the last port's dereference in the group. There is another management list that holding all of the used Rx queues' structures for a port. If the reference count of a control structure is changed to zero during port

[PATCH] net/mlx5/hws: fix typo in the log

2023-11-12 Thread Bing Zhao
Change "cureent" to "current". Fixes: fa16fead9a68 ("net/mlx5/hws: support rule update after its creation") Cc: ere...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/m

RE: [EXT] [PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment

2023-11-12 Thread Akhil Goyal
> add negative test cases for 3DES CBC and AES CBC > cipher algorithms for buffer misalignment > > Signed-off-by: Sivaramakrishnan Venkat > --- > app/test/test_cryptodev.c | 321 - > app/test/test_cryptodev_aes_test_vectors.h | 119 > app/test/test_c

Re: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-12 Thread Ruifeng Wang
On 2023/11/10 9:18 PM, Morten Brørup wrote: Dear Ruifeng, Hi Morten, +CC: all CPU architecture maintainers, I'm trying to figure out the requirements for supporting unaligned memory access in DPDK (specifically the ring library), and need your expert feedback. The #define RTE_ARCH_STRICT

RE: [EXT] [PATCH] crypto/openssl: fix asym memory leaks

2023-11-12 Thread Akhil Goyal
> -- > Numerous memory leaks were detected by ASAN > in the OpenSSL PMD asymmetric code path. > > These are now fixed to free all variables allocated > by OpenSSL functions such as BN_bin2bn and > OSSL_PARAM_BLD_new. > > Some nee

RE: [PATCH v4] crypto/openssl: fix memory leaks in asym ops

2023-11-12 Thread Akhil Goyal
> Subject: [PATCH v4] crypto/openssl: fix memory leaks in asym ops > > Fix memory leaks in Asymmetric ops, as reported by valgrind. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > v4: > - patch rebased. Applied to dpdk-next-crypto Added-fixes tags and Ciara's ack from v3. Thanks.

[PATCH v4] crypto/openssl: fix memory leaks in asym ops

2023-11-12 Thread Gowrishankar Muthukrishnan
Fix memory leaks in Asymmetric ops, as reported by valgrind. Signed-off-by: Gowrishankar Muthukrishnan --- v4: - patch rebased. --- drivers/crypto/openssl/rte_openssl_pmd.c | 28 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 16 +++ 2 files changed, 28 insertio

Re: [PATCH] event/dlb2: fix missing queue ordering capability flag

2023-11-12 Thread Jerin Jacob
On Mon, Nov 13, 2023 at 2:05 AM Sevincer, Abdullah wrote: > > Acked-by: Abdullah Sevincer Applied to dpdk-next-eventdev/for-main. Thanks

[PATCH v1 1/1] ml/cnxk: fix fast-path synchronization

2023-11-12 Thread Srikanth Yalavarthi
Segfaults are reported with TVM/LLVM models as NULL value is read by dequeue thread for the op handle. This is due synchronization issue between enqueue and dequeue threads. This fix ensures the op handle written to internal request structure is committed before the dequeue threads read the handle

RE: [EXT] Re: [PATCH v4] examples/l2fwd-macsec: add MACsec forwarding application

2023-11-12 Thread Akhil Goyal
> Hi Akhil, > > 09/11/2023 22:01, Akhil Goyal: > > Added a new application based on l2fwd to demonstrate inline protocol > > offload MACsec performance using rte_security APIs. > > In general we try to avoid adding a new example application. > Does this one has been discussed already with the tec

[PATCH v6 4/4] app/dma-perf: add SG copy support

2023-11-12 Thread Gowrishankar Muthukrishnan
Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph --- app/test-dma-perf/benchmark.c | 274 +- app/test-dma-perf/config.ini | 19 ++- app/test-dma-perf/main.c | 34 - app/test-dma-perf/main.h | 5 +- 4 files c

[PATCH v6 3/4] app/dma-perf: validate copied memory

2023-11-12 Thread Gowrishankar Muthukrishnan
Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++- app/test-dma-perf/main.h | 2 +- 3 files changed, 32

[PATCH v6 2/4] app/dma-perf: add PCI device support

2023-11-12 Thread Gowrishankar Muthukrishnan
From: Amit Prakash Shukla Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph --- v6: - fix mbuf IOVA with remote address --- --- app/test-dma-perf/benchmark.c | 108 +++

[PATCH v6 1/4] app/dma-perf: add skip support

2023-11-12 Thread Gowrishankar Muthukrishnan
From: Amit Prakash Shukla Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 23 +++ app/test-dma-perf/main.h | 1 + 3 files changed, 26 i

[PATCH v6 0/4] PCI Dev and SG copy support

2023-11-12 Thread Gowrishankar Muthukrishnan
Improve dma-perf application to support PCI dev and SG copy, along with additional supports below: - validate copied memory - skip tests if not opted. v6: - PCI patch updated. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support Gowrishankar Muthukr

RE: [PATCH] net/cpfl: refactor flow parser

2023-11-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 13, 2023 1:39 AM > To: Qiao, Wenjing ; Zhang, Qi Z > > Cc: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org; Marchand, David > Subject: Re: [PATCH] net/cpfl: refactor flow parser > > 07/11/2023 09:34, wenjing.q...@i

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-12 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Friday, November 10, 2023 4:44 AM > To: Konstantin Ananyev ; Ruifeng Wang > ; Honnappa Nagarahalli > > Cc: dev@dpdk.org; david.march...@redhat.com; olivier.m...@6wind.com; > Dharmik Jayesh Thakkar ; nd > ; andrew.rybche...@oktetlabs.ru;

Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-12 Thread Stephen Hemminger
On Sun, 12 Nov 2023 07:16:10 + Trevor Tao wrote: > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > by default, but some hw and/or virtual interface does not > support the RSS and offload mode presupposed, e.g., some > virtio interfaces in the cloud don't support > RSS and the erro

Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Stephen Hemminger
On Sun, 12 Nov 2023 09:30:24 +0100 Morten Brørup wrote: > > > +static_assert(sizeof(struct rte_event) == 16, "Event structure size > > is not 16-bytes in size"); > > > + > > > static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS]; > > > > Please don't reinvent RTE_BUILD_BUG_ON(

RE: [PATCH] event/dlb2: fix missing queue ordering capability flag

2023-11-12 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

Re: [PATCH] net/cpfl: fix coverity issues

2023-11-12 Thread Thomas Monjalon
07/11/2023 01:18, Zhang, Qi Z: > From: Qiao, Wenjing > > From: Wenjing Qiao > > > > Fix integer handling issues, tainted_scalar issues, uninit issues, overrun > > issues > > and control flow issues reported by coverity scan. > > > > Coverity issue: 403259 > > Coverity issue: 403261 > > Coverit

Re: [PATCH] net/cpfl: refactor flow parser

2023-11-12 Thread Thomas Monjalon
07/11/2023 09:34, wenjing.q...@intel.com: > From: Wenjing Qiao > > Use strncpy instead of memcpy for string copy and rename macro. I really wonder why memcpy was used for string copy. As you fix it, why not using strlcpy, as recommended by checkpatch? Qi, why do you keep ignoring warnings repor

RE: [PATCH] net/mvpp2: fix null dereference in vmwa release

2023-11-12 Thread Raslan Darawsheh
Hi Weiguo, > -Original Message- > From: Weiguo Li > Sent: Saturday, November 4, 2023 12:29 PM > To: Ophir Munk > Cc: lir...@marvell.com; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mvpp2: fix null dereference in vmwa release > > Pointer 'mrvl_cfg' is dereferenced and then compa

Re: [PATCH v7 23/25] node: remove some of the experimental tags

2023-11-12 Thread David Marchand
On Tue, Oct 24, 2023 at 4:57 AM Stephen Hemminger wrote: > > The node library has been around long enough that experimental > tag should be removed. The IPv6 support was added in 23.03 > but that is still enough time that it can be marked stable. > > The logtype variable should have been marked i

RE: [PATCH 1/1] net/mlx5: fix inline data length for multisegment packets

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Friday, November 10, 2023 11:50 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Suanming Mou ; > sta...@dpdk.org > Subject: [PATCH 1/1] net/mlx5: fix inline data length for multisegment packets > > If packet data len

RE: [PATCH] net/mlx5: fix unbind of incorrect hairpin queue

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Thursday, November 9, 2023 8:01 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix unbind of incorrect hairpin

RE: [PATCH] net/mlx5: fix expected hairpin queue states

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Thursday, November 9, 2023 8:04 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix expected hairpin queue stat

RE: [PATCH] net/mlx5: fix use after free on Rx queue start

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Thursday, November 9, 2023 7:58 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Xueming(Steven) Li > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix use after free on

RE: [PATCH 0/2] net/mlx5: fix flow rules for external SQ

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, November 9, 2023 10:56 AM > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5: fix flow rules for external SQ > > If representor matching was enabled (device argument repr_matching_en is > equal to 1, defau

RE: [PATCH v1 0/2] fix IPv6 routing extension mismatching

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 9, 2023 10:41 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: [PATCH v1 0/2] fix IPv6 routing extension mismatching > > Fix pot

RE: [PATCH] net/mlx5: fix job flow memory calculation

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, November 9, 2023 10:12 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh ; Dariusz > Sosnowski > Subject: [PATCH] net/mlx5: fix job flow memory calculation > > The upd_flow is the fina

RE: [PATCH] net/mlx5: fix counter query during port close

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, November 9, 2023 10:08 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix counter query during port close > > Currently, the counter query service threa

RE: [PATCH] net/mlx5: fix the validation of the sample encap action

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Tuesday, November 7, 2023 5:08 PM > To: Suanming Mou ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the validation of the sample encap acti

RE: [PATCH] net/mlx5: fix the unlock mismatch issue

2023-11-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Weiguo Li > Sent: Saturday, November 4, 2023 6:08 AM > To: Alexander Kozyrev > Cc: Slava Ovsiienko ; dev@dpdk.org; > sta...@dpdk.org; Weiguo Li > Subject: [PATCH] net/mlx5: fix the unlock mismatch issue > > The 'need_lock' parameter controls whether the

Re: [PATCH v5 3/5] pcapng: modify timestamp calculation

2023-11-12 Thread Thomas Monjalon
09/11/2023 20:45, Stephen Hemminger: > The computation of timestamp is best done in the part of > pcapng library that is in secondary process. > The secondary process is already doing a bunch of system > calls which makes it not performance sensitive. > This does change the rte_pcapng_copy() > and

Re: [PATCH v3 ] dumpcap: fix mbuf pool ring type

2023-11-12 Thread Thomas Monjalon
09/11/2023 08:21, Morten Brørup: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 8 November 2023 18.48 > > > > The internal buffer pool used for copies of mbufs captured > > needs to be thread safe. If capturing on multiple interfaces > > or multiple queues, t

Re: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-12 Thread Thomas Monjalon
25/09/2023 17:10, Sivaprasad Tummala: > From: Sivaprasad Tummala > > By default, max lcores are limited to 128 for x86 platforms. > On AMD EPYC processors, this limit needs to be increased to > leverage all the cores. > > The patch adjusts the limit specifically for native compilation > on AMD E

Re: [PATCH v2 2/2] bus/cdx: add bus master enable/disable APIs

2023-11-12 Thread Thomas Monjalon
07/11/2023 15:25, Gupta, Nipun: > > On 11/3/2023 4:50 PM, Shubham Rohila wrote: > > Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to > > enable or disable bus master functionality for cdx devices. > > > > Signed-off-by: Shubham Rohila > > --- > > v2 > > - Fix indentations and alp

Re: [PATCH v2] config/arm: correct cpu arch for cross build

2023-11-12 Thread Thomas Monjalon
07/11/2023 04:26, Joyce Kong: > The cn10k cross build file sets cpu to 'armv8.6-a' while > it is armv8.5-a arch. > The cpu field in the cross file doesn't take effect as > config/arm/meson.build controls machine_args for march. > Then correct the value in arm cross files to 'auto'. > > Signed-off-

Re: [PATCH] eal: provide trace point register macro for MSVC

2023-11-12 Thread Thomas Monjalon
01/11/2023 23:47, Tyler Retzlaff: > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > MSVC that allocates segments for the trace point using MSVC specific > features > > Signed-off-by: Tyler Retzlaff > --- > +#ifdef RTE_TOOLCHAIN_MSVC > +#define RTE_TRACE_POINT_REGISTER(tra

RE: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Sunday, 12 November 2023 01.01 > > On Fri, 6 Oct 2023 11:29:32 +0100 > Bruce Richardson wrote: > > > diff --git a/lib/eventdev/rte_eventdev.c > b/lib/eventdev/rte_eventdev.c > > index 95373bbaad..adc9751cef 100644 > > --- a/l