Re: [PATCH v2] lpm: improve performance with copious IPv4 peering routes

Hello Jeffrey, On Fri, Nov 10, 2023 at 12:11 AM Warrington, Jeffrey wrote: > > Minimize the performance impact of large numbers of BGP peering > routes by updating LPM's IPv4 code to use a hash like the IPv6 code. > > Co-authored-by: Julien Charbon > Signed-off-by: Julien Charbon > Signed-off-b

Re: [PATCH] event/dlb2: fix missing queue ordering capability flag

On Thu, Nov 9, 2023 at 11:14 PM Bruce Richardson wrote: > > The dlb2 driver did not advertise the fact that events could be enqueued > to it for any queues, not just those in numerical sequence. Add the > missing bit to the capabilities flag returned from the info_get() > function. > > Fixes: d39e

Re: [EXT] [PATCH] test/eventdev: avoid configuring port or queue twice

On Wed, Nov 8, 2023 at 12:22 AM Pavan Nikhilesh Bhagavatula wrote: > > > > In the basic sanity tests of eventdev for queue and port setup, queue 0 > > was configured separately before running a loop to configure the rest of > > the queues. This loop started from 0, so reconfigured queue 0, and a >

[PATCH v3] app/testpmd: fix indirect action list ID size

Testpmd maps indirect action lists handlers into application IDs. Testpmd API defines indirect IDs as 32 bits values. The patch fixes indirect IDs size in ACTION_INDIRECT_LIST_HANDLE and ACTION_INDIRECT_LIST_CONF tokens Fixes: 72a3dec7126f ("ethdev: add indirect flow list action") Signed-off-by:

RE: [PATCH 08/16] net/nfp: verify strdup return value

> [You don't often get email from fengcheng...@huawei.com. Learn why this > is important at https://aka.ms/LearnAboutSenderIdentification ] > > Add verify strdup return value logic. > > Fixes: 3d21da66c06b ("net/nfp: create security session") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen F

[PATCH 10/16] app/pdump: verify strdup return value

Add verify strdup return value logic. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/pdump/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 7a1c7bdf60..a9205e130b 10

[PATCH 13/16] app/test-dma-perf: verify strdup return value

Add verify strdup return value logic. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-dma-perf/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c inde

[PATCH 16/16] examples/vhost: verify strdup return value

Add verify strdup return value logic. Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/vhost/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c

[PATCH 14/16] app/testpmd: verify strdup return value

Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 912b

[PATCH 15/16] examples/qos_sched: fix memory leak when parse args

Should free the memory which allocated by strdup(). Fixes: 035b6a4f4bba ("examples/qos_sched: fix out-of-bounds option parsing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/qos_sched/args.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/qos_sch

[PATCH 12/16] app/test-crypto-perf: verify strdup return value

Add verify strdup return value logic. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-crypto-perf/cperf_options_parsing.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cp

[PATCH 11/16] app/test: verify strdup return value

Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test/process.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/process.h b/app/test/process.h index af7bc3e0de..c576c42349

[PATCH 06/16] event/cnxk: verify strdup return value

Add verify strdup return value logic. Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/cnxk/cnxk_eventdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/driv

[PATCH 05/16] dma/idxd: verify strdup return value

Add verify strdup return value logic. Fixes: e888bb1278c6 ("dma/idxd: add bus device probing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/dma/idxd/idxd_bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dm

[PATCH 09/16] app/dumpcap: verify strdup return value

Add verify strdup return value logic. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/dumpcap/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 64294bbfb3

[PATCH 08/16] net/nfp: verify strdup return value

Add verify strdup return value logic. Fixes: 3d21da66c06b ("net/nfp: create security session") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/nfp/nfp_ipsec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c inde

[PATCH 07/16] net/failsafe: fix memory leak when parse args

Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe

[PATCH 02/16] bus/dpaa: verify strdup return value

Add verify strdup return value logic. Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/dpaa/dpaa_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index e5

[PATCH 04/16] bus/vdev: verify strdup return value

Add verify strdup return value logic. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/vdev/vdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 7974b2

[PATCH 01/16] eal: verify strdup return value

Add verify strdup() return value logic. Fixes: 293c53d8b23c ("eal: add telemetry callbacks") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/common/eal_common_options.c | 24 ++-- lib/eal/linux/eal_

[PATCH 00/16] verify strdup return value

This patchset mainly fix the return value of strdup not checked which may lead to segment fault. It also include two commits which fix memory leak of strdup. Chengwen Feng (16): eal: verify strdup return value bus/dpaa: verify strdup return value bus/fslmc: verify strdup return value bus/v

[PATCH 03/16] bus/fslmc: verify strdup return value

Add verify strdup return value logic. Fixes: e67a61614d0b ("bus/fslmc: support device iteration") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/fslmc/fslmc_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bu

Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code

On 2023/11/10 2:50, Ferruh Yigit wrote: On 11/8/2023 3:44 AM, Jie Hai wrote: This patchset fixes failure on sync mailbox and refactors some codes on mailbox. Dengdui Huang (5): net/hns3: fix sync mailbox failure forever net/hns3: refactor VF mailbox message struct net/hns3: refactor PF

[PATCH v2 6/6] net/hns3: refactor handle mailbox function

From: Dengdui Huang The mailbox messages of the PF and VF are processed in the same function. The PF and VF call the same function to process the messages. This code is excessive coupling and isn't good for maintenance. Therefore, this patch separates the interfaces that handle PF mailbox message

[PATCH v2 2/6] net/hns3: use stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_cmd.c | 22 +++- drivers/net/hns3/hns3_dcb.c | 3 +- drivers/net/hns3/hns3_ethdev.c| 51 --

[PATCH v2 5/6] net/hns3: refactor send mailbox function

From: Dengdui Huang The 'hns3_send_mbx_msg' function has following problem: 1. the name is vague, missing caller indication. 2. too many input parameters because the filling messages are placed in commands the send command. Therefore, a common interface is encapsulated to fill in the mailbox

[PATCH v2 0/6] net/hns3: fix and refactor some codes

This patchset fixes the failure on sync mailbox and refactors some codes on mailbox, also replace gcc builtin __atomic_xxx with rte_atomic_xxx. -- v2: 1. fix misspelling error in commit log and codes. 2. replace __atomic_xxx with rte_atomic_xxx. -- Dengdui Huang (5): net/hns3: fix sync mailbox

[PATCH v2 4/6] net/hns3: refactor PF mailbox message struct

From: Dengdui Huang The data region in PF to VF mbx message command is used to communicate with VF driver. And this data region exists as an array. As a result, some complicated feature commands, like mailbox response, link change event, close promisc mode, reset request and update pvid state, ha

[PATCH v2 1/6] net/hns3: fix sync mailbox failure forever

From: Dengdui Huang Currently, hns3 VF driver uses the following points to match the response and request message for the mailbox synchronous message between VF and PF. 1. req_msg_data which is consist of message code and subcode, is used to match request and response. 2. head means the number

[PATCH v2 3/6] net/hns3: refactor VF mailbox message struct

From: Dengdui Huang The data region in VF to PF mbx message command is used to communicate with PF driver. And this data region exists as an array. As a result, some complicated feature commands, like setting promisc mode, map/unmap ring vector and setting VLAN id, have to use magic number to set

[PATCH v2] examples/ethtool: fix pause configuration

Currently, the pause command in ethtool to enable Rx/Tx pause has the following problem. Namely, Assume that the device supports flow control auto-negotiation to set pause parameters, which will the device that does not support flow control auto-negotiation fails to run this command. This patch su

[Bug 1308] meson_tests/driver：link_bonding_rssconf_autotest test failed

https://bugs.dpdk.org/show_bug.cgi?id=1308 Jiale Song (songx.ji...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|

[PATCH v2 7/7] dts: allow configuring MTU of ports

From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 7 +++ dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v2 6/7] dts: add pci addresses to EAL parameters

From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevent PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 9 + 1 file changed, 9 insertions(+) dif

[PATCH v2 4/7] dts: allow passing parameters into interactive apps

From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- dts/

[PATCH v2 5/7] dts: add optional packet filtering to scapy sniffer

From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v2 3/7] dts: add scatter to the yaml schema

From: Jeremy Spewock Allow for scatter to be specificed in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/conf

[PATCH v2 2/7] dts: add waiting for port up in testpmd

From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Signed-off-by: Jeremy Spewock --- .../remote_sessi

[PATCH v2 1/7] dts: Add scatter test suite

From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v2 0/7] dts: Port scatter suite over

From: Jeremy Spewock This patch ports over the functionality of the scatter testing suite from "old dts." The idea of the suite is the coverage it provides should be parity with the ethdev testing suite in old DTS. This new version is just because of the update to the patch which it depends on.

[PATCH v3 1/1] dts: bind to DPDK driver before running test suites

From: Jeremy Spewock Modifies the current process so that we bind to os_driver_for_dpdk from the configuration file before running test suites and bind back to the os_driver afterwards. This allows test suites to assume that the ports are bound to a DPDK supported driver or bind to either driver

[PATCH v3 0/1] dts: Add the ability to bind ports to drivers

From: Jeremy Spewock Changes in this version address the comments on the last and change what was necessary. Now, we no longer modprobe the driver, but the decision was made to still make driver binding exclusive to the SUT for the time being due to the uncertainty of what binding drivers on the

[PATCH v2] lpm: improve performance with copious IPv4 peering routes

Minimize the performance impact of large numbers of BGP peering routes by updating LPM's IPv4 code to use a hash like the IPv6 code. Co-authored-by: Julien Charbon Signed-off-by: Julien Charbon Signed-off-by: Jeff Warrington Co-authored-by: Nicolas Witkowski Signed-off-by: Nicolas Witkowski C

[PATCH v1 7/7] dts: allow configuring MTU of ports

From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 7 +++ dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v1 6/7] dts: add pci addresses to EAL parameters

From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevent PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 9 + 1 file changed, 9 insertions(+) dif

[PATCH v1 5/7] dts: add optional packet filtering to scapy sniffer

From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v1 4/7] dts: allow passing parameters into interactive apps

From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- dts/

[PATCH v1 3/7] dts: add scatter to the yaml schema

From: Jeremy Spewock Allow for scatter to be specificed in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/conf

[PATCH v1 2/7] dts: add waiting for port up in testpmd

From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Signed-off-by: Jeremy Spewock --- .../remote_sessi

[PATCH v1 1/7] dts: Add scatter test suite

From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v1 0/7] dts: Port scatter suite over

From: Jeremy Spewock This patch ports over the functionality of the scatter testing suite from "old dts." The idea of the suite is the coverage it provides should be parity with the ethdev testing suite in old DTS. Depends-on: series-30228 ("dts: Add the ability to bind ports to drivers") Jerem

[PATCH v2 1/1] dts: allow configuring MTU of ports

From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 7 +++ dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v2 0/1] dts: Add the ability to bind ports to drivers

From: Jeremy Spewock Changes in this version address the comments on the last and change what was necessary. Now, we no longer modprobe the driver, but the decision was made to still make driver binding exclusive to the SUT for the time being due to the uncertainty of what binding drivers on the

Re: [PATCH v4] examples/l2fwd-macsec: add MACsec forwarding application

Hi Akhil, 09/11/2023 22:01, Akhil Goyal: > Added a new application based on l2fwd to demonstrate inline protocol > offload MACsec performance using rte_security APIs. In general we try to avoid adding a new example application. Does this one has been discussed already with the techboard? We need

[PATCH v4] examples/l2fwd-macsec: add MACsec forwarding application

Added a new application based on l2fwd to demonstrate inline protocol offload MACsec performance using rte_security APIs. Example command: ./dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 -c 0x6 -- -p 0x3 \ --mcs-tx-portmask 0x1 --mcs-rx-portmask 0x2 --mcs-port-config \ '(0,02:03:04:05:06:07,01:

RE: [EXT] [PATCH] crypto/mlx5: fix crypto dev leak

> For the case crypto initialize failed, the allocated crypto dev should > be destroyed, otherwise the dev leaked. Current PMD returns directly > instead of releasing the dev. > > This commit fixes the crypto dev leak when initialize failed. > > Fixes: a27f6a2e1f30 ("crypto/mlx5: split AES-XTS")

Re: RFC acceptable handling of VLAs across toolchains

On Wed, Nov 08, 2023 at 08:51:54AM -0800, Stephen Hemminger wrote: > On Tue, 7 Nov 2023 11:32:20 -0800 > Tyler Retzlaff wrote: > > > hi folks, > > > > i'm seeking advice. we have use of VLAs which are now optional in > > standard C. some toolchains provide a conformant implementation and msvc >

RE: [PATCH v2] test/cryptodev: add ECDH tests

> Subject: [PATCH v2] test/cryptodev: add ECDH tests > > Add ECDH tests. > > Signed-off-by: Gowrishankar Muthukrishnan > Change-Id: I88099e2ba8e058fbb519a06d09ebb3ece7c7e27f > --- > v2: > - rebased due to patch conflict. Applied to dpdk-next-crypto Removed change-id while merging.

RE: [PATCH v3] crypto/openssl: fix memory leaks in asym ops

> Subject: [PATCH v3] crypto/openssl: fix memory leaks in asym ops > > Fix memory leaks in Asymmetric ops, as reported by valgrind. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > v3: > - changes as suggested in v2. The patch conflicts with Stephen's patch to remove the null checks before

[PATCH] ethdev: add extension keyword to statement expression macro

add missing __extension__ keyword to macros using gcc statement expression extension. Signed-off-by: Tyler Retzlaff --- lib/ethdev/rte_mtr.c | 10 +- lib/ethdev/rte_tm.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/ethdev/rte_mtr.c b/lib/ethdev/rte_mtr

RE: [EXT] [PATCH 0/2] remove unnecessary null checks in OpenSSL usage

> OpenSSL follows null free conventions > > Stephen Hemminger (2): > nullfree: add matches for null free cases from OpenSSL > crypto/openssl: remove unnecessary NULL checks before free > > devtools/cocci/nullfree.cocci| 9 + > drivers/crypto/openssl/rte_openssl_pmd.c

RE: [PATCH v5 2/5] dumpcap: allow multiple invocations

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 November 2023 20.46 > > If dumpcap is run twice with each instance pointing a different > interface, it would fail because of overlap in ring a pool names. > Fix by putting process id in the name. > > It is still no

Re: [PATCH v2] app/testpmd: fix indirect action list parameters parsing

On Thu, Nov 09, 2023 at 11:41:37AM -0800, Stephen Hemminger wrote: > On Thu, 9 Nov 2023 20:36:37 +0200 > Gregory Etelson wrote: > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 0d521159e9..397f9bc3eb 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

Hello Ferruh, Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And please describe what is the observ

[PATCH v5 5/5] test: cleanups to pcapng test

Overhaul of the pcapng test: - promote it to be a fast test so it gets regularly run. - create null device and use i. - use UDP discard packets that are valid so that for debugging the resulting pcapng file can be looked at with wireshark. - do basic checks on resulting pcap file that l

[PATCH v5 4/5] pcapng: avoid using alloca()

The function alloca() like VLA's has problems if the caller passes a large value. Instead use a fixed size buffer (2K) which will be more than sufficient for the info related blocks in the file. Add bounds checks as well. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pcapng/r

[PATCH v5 3/5] pcapng: modify timestamp calculation

The computation of timestamp is best done in the part of pcapng library that is in secondary process. The secondary process is already doing a bunch of system calls which makes it not performance sensitive. This does change the rte_pcapng_copy() and rte_pcapng_write_stats() experimental API's. Sim

[PATCH v5 2/5] dumpcap: allow multiple invocations

If dumpcap is run twice with each instance pointing a different interface, it would fail because of overlap in ring a pool names. Fix by putting process id in the name. It is still not allowed to do multiple invocations on the same interface because only one callback is allowed and only one copy o

[PATCH v5 1/5] pdump: fix setting rte_errno on mp error

The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Ste

[PATCH v5 0/5] dumpcap and pcapng fixes

This series has bugfixes and tests for dumpcap and pcapng. It should be in 23.11! It fixes issues related to timestamping. The design choices are to maximize performance in the primary process; and do all the time adjustment in the secondary (dumpcap) since the dumpcap needs to system calls anyway

Re: [PATCH v2] app/testpmd: fix indirect action list parameters parsing

On Thu, 9 Nov 2023 20:36:37 +0200 Gregory Etelson wrote: > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 0d521159e9..397f9bc3eb 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -11331,7 +11331,7 @@ parse_indlst_id2ptr(struct cont

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

On 11/9/2023 6:22 PM, Etelson, Gregory wrote: > Hello Ferruh, > >>> Indirect actions list arguments parser was configured to place target >>> number into 64bit value, while the code provided 32bits memory. >>> >> >> Hi Gregory, >> >> Can you please give more details why 'id' needs to be 64 bits, w

Re: [PATCH 2/5] net/hns3: refactor VF mailbox message struct

On 11/8/2023 3:44 AM, Jie Hai wrote: > From: Dengdui Huang > > The data region in VF to PF mbx memssage command is > s/memssage/message/ Same for next patch > used to communicate with PF driver. And this data > region exists as an array. As a result, some complicated > feature commands, like

Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code

On 11/8/2023 3:44 AM, Jie Hai wrote: > This patchset fixes failure on sync mailbox and refactors some codes on > mailbox. > > Dengdui Huang (5): > net/hns3: fix sync mailbox failure forever > net/hns3: refactor VF mailbox message struct > net/hns3: refactor PF mailbox message struct > net

[RFC] event/dsw: support explicit release only mode

Add the RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capability to the DSW event device. This feature may be used by an EAL thread to pull more work from the work scheduler, without giving up the option to forward events originating from a previous dequeue batch. This in turn allows an EAL thread to

[PATCH v2] app/testpmd: fix indirect action list parameters parsing

Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. The patch updated variable size for translation results. Fixes: 72a3dec7126f ("ethdev: add indirect flow list action") Signed-off-by: Gregory Etelson --- v2: defi

RE: [PATCH v4 2/5] dumpcap: allow multiple invocations

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 November 2023 18.34 > > If dumpcap is run twice with each instance pointing a different > interface, it would fail because of overlap in ring a pool names. > Fix by putting process id in the name. > > It is still no

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

Hello Ferruh, Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And please describe what is the observ

RE: [PATCH v3 2/5] dumpcap: allow multiple invocations

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 November 2023 18.16 > > On Thu, 9 Nov 2023 08:50:10 +0100 > Morten Brørup wrote: > > > > rte_exit(EXIT_FAILURE, > > > "Packet dump enable on %u:%s failed %s\n", > > >

[PATCH] net/mlx5: fix expected hairpin queue states

This patch fixes the expected SQ and RQ states used in MODIFY_SQ and MODIFY_RQ during unbinding of the hairpin queues. When unbinding the queue objects, they are in RDY state and are transitioning to RST state, instead of going from RST to RST state. Also, this patch fixes the constants used for R

[PATCH] net/mlx5: fix unbind of incorrect hairpin queue

Let's take an application with the following configuration: - It uses 2 ports. - Each port has 3 Rx queues and 3 Tx queues. - On each port, Rx queues have a following purposes: - Rx queue 0 - SW queue, - Rx queue 1 - hairpin queue, bound to Tx queue on the same port, - Rx queue 2 - hairpin q

[PATCH] net/mlx5: fix use after free on Rx queue start

If RX queue is not started yet, then a mlx5_rxq_obj struct used for storing HW queue objects will be allocated and added to the list held in port's private data structure. After that allocation, Rx queue HW object configuration is done. If that configuration failed, then mlx5_rxq_obj struct is free

[PATCH] event/dlb2: fix missing queue ordering capability flag

The dlb2 driver did not advertise the fact that events could be enqueued to it for any queues, not just those in numerical sequence. Add the missing bit to the capabilities flag returned from the info_get() function. Fixes: d39e23f26e1e ("event/dlb2: fix advertized capabilities") Fixes: e7c9971a85

[PATCH v4 5/5] test: cleanups to pcapng test

Overhaul of the pcapng test: - promote it to be a fast test so it gets regularly run. - create null device and use i. - use UDP discard packets that are valid so that for debugging the resulting pcapng file can be looked at with wireshark. - do basic checks on resulting pcap file that l

[PATCH v4 4/5] pcapng: avoid using alloca()

The function alloca() like VLA's has problems if the caller passes a large value. Instead use a fixed size buffer (2K) which will be more than sufficient for the info related blocks in the file. Add bounds checks as well. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pcapng/r

[PATCH v4 3/5] pcapng: modify timestamp calculation

The computation of timestamp is best done in the part of pcapng library that is in secondary process. The secondary process is already doing a bunch of system calls which makes it not performance sensitive. This does change the rte_pcapng_copy() and rte_pcapng_write_stats() experimental API's. Sim

[PATCH v4 1/5] pdump: fix setting rte_errno on mp error

The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Ste

[PATCH v4 2/5] dumpcap: allow multiple invocations

If dumpcap is run twice with each instance pointing a different interface, it would fail because of overlap in ring a pool names. Fix by putting process id in the name. It is still not allowed to do multiple invocations on the same interface because only one callback is allowed and only one copy o

[PATCH v4 0/5] dumpcap and pcapng fixes

This series has bugfixes and tests for dumpcap and pcapng. It should be in 23.11! It fixes issues related to timestamping. The design choices are to maximize performance in the primary process; and do all the time adjustment in the secondary (dumpcap) since the dumpcap needs to system calls anyway

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

On Thu, Nov 09, 2023 at 09:26:27AM -0800, Rahul Gupta wrote: > On (11/08/23 16:40), Thomas Monjalon wrote: > > Date: Wed, 08 Nov 2023 16:40:07 +0100 > > From: Thomas Monjalon > > To: rahul gupta , Dmitry Kozlyuk > > > > Cc: Stephen Hemminger , Rahul Gupta > > , dev@dpdk.org, > > sovar...@linux

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

On (11/08/23 16:40), Thomas Monjalon wrote: > Date: Wed, 08 Nov 2023 16:40:07 +0100 > From: Thomas Monjalon > To: rahul gupta , Dmitry Kozlyuk > > Cc: Stephen Hemminger , Rahul Gupta > , dev@dpdk.org, > sovar...@linux.microsoft.com, ok...@kernel.org, > sujithsan...@microsoft.com, sowmini.vara

RE: [PATCH] config/x86: config support for AMD EPYC processors

> Hi Konstantin, Morten, > > > -Original Message- > > From: Konstantin Ananyev > > Sent: Tuesday, November 7, 2023 8:03 PM > > To: Morten Brørup ; Thomas Monjalon > > ; Kevin Traynor ; Tummala, > > Sivaprasad ; David Marchand > > ; Yigit, Ferruh ; > > bruce.richard...@intel.com; konstan

RE: [PATCH v3 4/5] pcapng: avoid using alloca()

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 November 2023 16.45 > > On Thu, 9 Nov 2023 09:21:22 +0100 > Morten Brørup wrote: > > > I can't find the definition of BUFSIZ. Please make sure to add a > comment to the definition of BUFSIZ mentioning - like in you

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

On 11/8/2023 4:34 PM, Gregory Etelson wrote: > Indirect actions list arguments parser was configured to place target > number into 64bit value, while the code provided 32bits memory. > Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And p

RE: [PATCH] net/ena: fix coverity issues

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 9, 2023 5:54 PM > To: Brandes, Shai > Cc: dev@dpdk.org; Beider, Ron ; Atrash, Wajeeh > ; Bernstein, Amit > Subject: RE: [EXTERNAL] [PATCH] net/ena: fix coverity issues > > CAUTION: This email originated from outside

RE: [PATCH v3 2/5] dumpcap: allow multiple invocations

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 9 November 2023 16.40 > > On Thu, 9 Nov 2023 08:50:10 +0100 > Morten Brørup wrote: > > > > Signed-off-by: Stephen Hemminger > > > --- > > > > Minor detail: getpid() returns int, so prefer %d over %u. > > Let me che

Re: [PATCH] net/ena: fix coverity issues

On 11/9/2023 3:25 PM, Brandes, Shai wrote: > See inside > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, November 9, 2023 4:30 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org; Beider, Ron ; Atrash, Wajeeh >> ; Bernstein, Amit >> Subject: RE: [EXTERNAL] [PATCH] net/ena: fix c

Re: [PATCH v3 00/10] test-bbdev changes for 23.11

On 11/4/23 00:34, Nicolas Chautru wrote: v3: python script argument fix marked as deprecation first, with formal fix in following release. Maxime let me know if you want to something more formal in the release notes to call it out, currently embedded in script and commit me

Re: [PATCH v3 0/2] FlexRAN SDK update for 23.11

On 10/28/23 00:03, Nicolas Chautru wrote: v3: rebase typo fixed. v2: rebase typo fixed. Upstreaming SDK workaround for ACC100 and updating documentation for new SDK release. Hernan Vargas (2): baseband/acc: support ACC100 deRM corner case SDK doc: update FlexRAN SDK links doc/gui

Re: [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD

On 11/4/23 00:45, Nicolas Chautru wrote: Fix bug for the VRB1 PMD in LDPC Encoder TB mode. Targeting the rc3 if possible. Nicolas Chautru (1): baseband/acc: fix for TB mode on VRB1 drivers/baseband/acc/rte_vrb_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to

  1   2   >