Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-23 Thread Juraj Linkeš
On Mon, Oct 23, 2023 at 1:52 PM Yoan Picchi wrote: > > On 10/23/23 07:44, Juraj Linkeš wrote: > > > > > >> > >> My only nitpick comment would be on the name of the file common.py that > >> only contain the MesonArgs class. Looks good otherwise > > > > Could you elaborate a bit more, Yoan? The com

RE: [PATCH] net/iavf: fix Tx offloading flags check

2023-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Radu Nicolau > Sent: Tuesday, October 24, 2023 12:38 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Nicolau, Radu ; > sta...@dpdk.org; Marchand, David > Subject: [PATCH] net/iavf: fix Tx offloading flags check > > Use IAVF_TX_OFFLOAD_MASK flags

RE: [PATCH v1] net/cpfl: fix incorrect status calculation

2023-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Monday, October 23, 2023 5:01 PM > To: Zhang, Yuying ; Zhang, Yuying > ; dev@dpdk.org; Zhang, Qi Z > ; Wu, Jingjing > Subject: RE: [PATCH v1] net/cpfl: fix incorrect status calculation > > > > > -Original Message- > > From: Zhan

RE: [PATCH v1] net/idpf: fix incorrect status calculation

2023-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Monday, October 23, 2023 5:01 PM > To: Zhang, Yuying ; dev@dpdk.org; Zhang, Qi Z > ; Wu, Jingjing > Cc: sta...@dpdk.org > Subject: RE: [PATCH v1] net/idpf: fix incorrect status calculation > > > > > -Original Message- > > Fro

[PATCH v7 25/25] cryptodev: mark older API's stable

2023-10-23 Thread Stephen Hemminger
All the cryptodev API's from 2022 backwards should be stable at this point. Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.h | 31 -- lib/cryptodev/version.map | 77 +++ 2 files changed, 32 insertions(+), 76 deletions(-) diff --g

[PATCH v7 24/25] eventdev: make many API's stable

2023-10-23 Thread Stephen Hemminger
All API's in eventdev up to 22.11 release should be made stable. Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.h | 4 --- lib/eventdev/rte_event_eth_rx_adapter.h | 6 - lib/eventdev/rte_event_eth_tx_adapter.h | 3 --- lib/eventdev/rte_event_timer_adapter.h |

[PATCH v7 23/25] node: remove some of the experimental tags

2023-10-23 Thread Stephen Hemminger
The node library has been around long enough that experimental tag should be removed. The IPv6 support was added in 23.03 but that is still enough time that it can be marked stable. The logtype variable should have been marked internal since it is not intended to be used outside of library. Sign

[PATCH v7 22/25] compressdev: remove experimental flag

2023-10-23 Thread Stephen Hemminger
The compressdev was added back in 2018. Remove the experimental flag and make ABI stable. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- MAINTAINERS | 2 +- lib/compressdev/rte_comp.h| 6 -- lib/compressdev/rte_compressdev.h | 26

[PATCH v7 21/25] ipsec: remove experimental from SA API

2023-10-23 Thread Stephen Hemminger
These API's were added in 21.11, remove experimental flag. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ipsec/rte_ipsec.h | 2 -- lib/ipsec/version.map | 9 + 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/ipsec/rte_ipsec.h b/lib/ipsec/rte_ip

[PATCH v7 20/25] bbdev: remove experimental tag

2023-10-23 Thread Stephen Hemminger
The API's for bbdev were last added to in 22.11. Remove experimental flag now. Signed-off-by: Stephen Hemminger Acked-by: Maxime Coquelin --- lib/bbdev/rte_bbdev.h| 4 lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 15 +++ 3 files changed, 7 insertions(+), 14

[PATCH v7 19/25] security: remove experimental flag

2023-10-23 Thread Stephen Hemminger
Update security API's to stable: __rte_security_set_pkt_metadata 21.11 rte_security_dynfield_offset20.11 rte_security_macsec_XXX 22.11 rte_security_session_stats_get 18.11 Signed-off-by: Stephen Hemminger Acked-by: Akhil

[PATCH v7 18/25] member: remove experimental tag

2023-10-23 Thread Stephen Hemminger
The member library last received new API's in 22.11. All the API's should be marked stable by now. Signed-off-by: Stephen Hemminger --- lib/member/rte_member.h | 54 - lib/member/version.map | 12 +++-- 2 files changed, 3 insertions(+), 63 deletions(-

[PATCH v7 17/25] ip_frag: mark a couple of functions stable

2023-10-23 Thread Stephen Hemminger
There were two functions added in 22.11 which were marked as experimental. Remove the experimental tag. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ip_frag/rte_ip_frag.h | 2 -- lib/ip_frag/version.map | 9 ++--- 2 files changed, 2 insertions(+), 9 deletions(-)

[PATCH v7 16/25] kvargs: remove experimental flag

2023-10-23 Thread Stephen Hemminger
The function rte_kvargs_get_with_value was added in 21.11 so experimental flag can be removed. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/kvargs/rte_kvargs.h | 4 lib/kvargs/version.map | 8 +--- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/l

[PATCH v7 15/25] power: remove experimental from API's

2023-10-23 Thread Stephen Hemminger
The power management API's were last changed in 22.11 release. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/power/rte_power.h | 4 --- lib/power/rte_power_guest_channel.h | 4 --- lib/power/rte_power_pmd_mgmt.h | 40 - lib/power/r

[PATCH v7 14/25] meter: remove experimental warning from comments

2023-10-23 Thread Stephen Hemminger
The API's for rte_meter_trtcm were documented as experimental with warning in documentation but the API's were not marked as experimental in version.map and/or with __rte_experimental. This patch removes the warnings from the docbook comment. Signed-off-by: Stephen Hemminger Acked-by: Bruce Rich

[PATCH v7 13/25] dmadev: mark API's as not experimental

2023-10-23 Thread Stephen Hemminger
These were added in 20.11 time now to remove experimental flag. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 2 +- lib/dmadev/rte_dmadev.h | 85 - lib/dmadev/version.map | 2 +- 3 fi

[PATCH v7 12/25] sched: remove experimental

2023-10-23 Thread Stephen Hemminger
The overcommit and PIE support was added back in 2020. Remove experimental tag. Signed-off-by: Stephen Hemminger Acked-by: Cristian Dumitrescu --- lib/sched/rte_pie.h | 8 lib/sched/rte_sched.h | 5 - lib/sched/version.map | 18 -- 3 files changed, 4 insertions(

[PATCH v7 10/25] hash: remove experimental from toeplitz hash

2023-10-23 Thread Stephen Hemminger
The rte_thash_ functions have been around since 2020. Remove experimental tag. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/hash/rte_thash.h | 44 --- lib/hash/rte_thash_gfni.h | 8 --- lib/hash/rte_thash_x86_gfni.h | 8 -

[PATCH v7 11/25] timer: remove experimental from rte_timer_next_ticks

2023-10-23 Thread Stephen Hemminger
Function was added in 20.11, remove experimental flag. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/timer/rte_timer.h | 4 lib/timer/version.map | 7 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/timer/rte_timer.h b/lib/timer/rte_timer.h

[PATCH v7 09/25] mbuf: remove experimental from create_extbuf

2023-10-23 Thread Stephen Hemminger
This API was added in 2020 and should no longer be experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/mbuf/rte_mbuf.h | 1 - lib/mbuf/version.map | 8 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h

[PATCH v7 08/25] lpm: remove experimental

2023-10-23 Thread Stephen Hemminger
The function to associate RCU with LPM was added several releases ago. Remove experimental. Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm.h | 4 lib/lpm/version.map | 7 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h ind

[PATCH v7 06/25] net: remove experimental from functions

2023-10-23 Thread Stephen Hemminger
These functions have been around long enough should no longer be experimental. Signed-off-by: Stephen Hemminger --- lib/net/rte_ip.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index 7f58dc6f6a9c..2cb5be222cdd 100644 --- a/lib/net/r

[PATCH v7 07/25] rcu: remove experimental from rte_rcu_qbsr

2023-10-23 Thread Stephen Hemminger
These functions were added back in 2020. Remove experimental flag. Signed-off-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli --- lib/rcu/rte_rcu_qsbr.h | 20 lib/rcu/version.map| 15 --- 2 files changed, 4 insertions(+), 31 deletions(-) diff --git

[PATCH v7 05/25] pcapng: mark API's as stable

2023-10-23 Thread Stephen Hemminger
This API was added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.h | 11 --- lib/pcapng/version.map | 6 ++ 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcap

[PATCH v7 04/25] pdump: make API's stable

2023-10-23 Thread Stephen Hemminger
The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/pdump/rte_pdump.h | 12 lib/pdump/version.map | 11 +++ 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib

[PATCH v7 03/25] ethdev: mark rte_tm API's as stable

2023-10-23 Thread Stephen Hemminger
These API's have been around since 20.11, mark them as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Cristian Dumitrescu --- MAINTAINERS| 2 +- lib/ethdev/rte_tm.h| 34 --- lib/ethdev/version.map | 62 --

[PATCH v7 02/25] cmdline: make experimental API's stable

2023-10-23 Thread Stephen Hemminger
These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h| 1 - lib/cmdline/cmdline_parse.h | 4 lib/cmdline/cmdline_rdline.h | 4 lib/cmdline/version.map | 26 --

[PATCH v7 01/25] bpf: make rte_bpf_dump and rte_bpf_convert stable API's

2023-10-23 Thread Stephen Hemminger
These two API's were introduced in 22.11 and can now be made not experimental. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/rte_bpf.h | 2 -- lib/bpf/version.map | 9 ++--- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/bpf/rte_bpf.h b/lib/

[PATCH v7 00/25] Promote 22.11 and older API's to stable

2023-10-23 Thread Stephen Hemminger
Since 23.11 is an LTS release it is time to remove the experimental bandaid off many API's. There are about 890 API's marked with experimental on current main branch. This addresses the easy to remove ones and gets it down to about 510 places. The rule is any API that has been in since 22.11 needs

Re: [PATCH] app/testpmd: support config all offload

2023-10-23 Thread lihuisong (C)
It is more better if support config these offloads for all ports using one command. Some driver may select their Rx/Tx function. If user want to run many ports in an app, they may not specify any port to start, like "dpdk-testpmd -l 10-18 -- -i". In this case, it will be very helpful to modify t

[PATCH v6 04/25] pdump: make API's stable

2023-10-23 Thread Stephen Hemminger
The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/pdump/rte_pdump.h | 12 lib/pdump/version.map | 11 +++ 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib

[PATCH v6 03/25] ethdev: mark rte_tm API's as stable

2023-10-23 Thread Stephen Hemminger
These API's have been around since 20.11, mark them as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Cristian Dumitrescu --- MAINTAINERS| 2 +- lib/ethdev/rte_tm.h| 34 --- lib/ethdev/version.map | 62 --

[PATCH v6 02/25] cmdline: make experimental API's stable

2023-10-23 Thread Stephen Hemminger
These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h| 1 - lib/cmdline/cmdline_parse.h | 4 lib/cmdline/cmdline_rdline.h | 4 lib/cmdline/version.map | 26 --

[PATCH v6 01/25] bpf: make rte_bpf_dump and rte_bpf_convert stable API's

2023-10-23 Thread Stephen Hemminger
These two API's were introduced in 22.11 and can now be made not experimental. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/rte_bpf.h | 2 -- lib/bpf/version.map | 9 ++--- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/bpf/rte_bpf.h b/lib/

[PATCH v6 00/25] Promite many experimental API's to stable

2023-10-23 Thread Stephen Hemminger
Since 23.11 is an LTS release it is time to remove the experimental bandaid off many API's. There are about 890 API's marked with experimental on current main branch. This addresses the easy to remove ones and gets it down to about 510 places. The rule is any API that has been in since 22.11 needs

Re: [PATCH v5 14/26] meter: remove experimental warning from comments

2023-10-23 Thread Stephen Hemminger
On Mon, 23 Oct 2023 09:29:52 +0200 David Marchand wrote: > On Fri, Oct 20, 2023 at 11:00 PM Stephen Hemminger > wrote: > > > > The API's for rte_meter_trtcm were never properly flagged > > as experimental; missing __rte_experimental but there was > > an experimental comment in the docbook commen

[PATCH v2 25/25] doc: add the common and vDPA document

2023-10-23 Thread Chaoyong He
Add the document for nfp common library and vDPA PMD. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- MAINTAINERS| 8 doc/guides/platform/index.rst | 1 + doc/guides/platform/nfp.rst| 30 ++ doc/gui

[PATCH v2 24/25] vdpa/nfp: add nfp vDPA device operations

2023-10-23 Thread Chaoyong He
Implement the corresponding nfp vDPA opetation functions. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 213 1 file changed, 213 insertions(+) diff --git a/drivers/vdp

[PATCH v2 23/25] vdpa/nfp: add the notify related logic

2023-10-23 Thread Chaoyong He
Add the logic to process vDPA notify relay. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 155 +++ drivers/vdpa/nfp/nfp_vdpa_core.c | 61 drivers/vdpa/nfp/nfp

[PATCH v2 22/25] drivers: add the datapath update logic

2023-10-23 Thread Chaoyong He
Add the vDPA datapath update logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 315 +++ drivers/vdpa/nfp/nfp_vdpa_core.c

[PATCH v2 21/25] vdpa/nfp: add the hardware init logic

2023-10-23 Thread Chaoyong He
Add the hardware initialize logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/meson.build | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 10 ++ drivers/vdpa/nfp/nfp_vdpa_core.c | 54 +

[PATCH v2 20/25] vdpa/nfp: add the logic of remap PCI memory

2023-10-23 Thread Chaoyong He
Add the logic of remap PCI memory. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 65 - 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp

[PATCH v2 19/25] drivers: add the basic framework of vDPA PMD

2023-10-23 Thread Chaoyong He
Add the basic framework of vDPA PMD. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_pci.c | 1 + drivers/common/nfp/nfp_common_pci.h | 1 + drivers/vdpa/nfp/meson.build| 7 ++ drivers/vdpa/nfp

[PATCH v2 18/25] drivers/vdpa: introduce the NFP vDPA library

2023-10-23 Thread Chaoyong He
Introduce the very basic NFP vDPA library. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/meson.build| 1 + drivers/vdpa/nfp/meson.build| 16 drivers/vdpa/nfp/nfp_vdpa_log.c | 9 + dri

[PATCH v2 17/25] drivers: move device module to common library

2023-10-23 Thread Chaoyong He
Move the device module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build| 1 + drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.c | 0 drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.h | 3 +++ d

[PATCH v2 16/25] drivers: move platform module to common library

2023-10-23 Thread Chaoyong He
Move the platform module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/{net/nfp/nfpcore => common/nfp}/nfp_platform.h | 0 drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 2 +- drivers/net/nfp/nfp_net_ctrl.c

[PATCH v2 15/25] drivers: move queue logic to common module

2023-10-23 Thread Chaoyong He
Move the queue enable/disable logic to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 49 drivers/common/nfp/nfp_common.h | 7 + drivers/common/nfp/version.map | 2 ++

[PATCH v2 14/25] drivers: add the nfp common module

2023-10-23 Thread Chaoyong He
Add the nfp common module in the nfp common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build | 3 +- drivers/common/nfp/nfp_common.c | 177 +++ drivers/common/nfp/nfp_common.h | 232 +++

[PATCH v2 13/25] drivers: add the common ctrl module

2023-10-23 Thread Chaoyong He
Add the common ctrl module. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 374 +++ drivers/net/nfp/nfp_net_ctrl.h | 365 +- 2 files changed, 375 insertions(+), 364 deletio

[PATCH v2 12/25] net/nfp: rename parameter in related logic

2023-10-23 Thread Chaoyong He
Rename parameter 'hw' into 'net_hw' in the related logic, to make the name more accurate. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 +-- drivers/net/nfp/nfp_ethdev.c| 86 +++ drivers/net/nf

[PATCH v2 11/25] net/nfp: extract the MAC address data field

2023-10-23 Thread Chaoyong He
Extract the 'mac_addr' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 14 +++--- drivers/net/nfp/nfp_ethdev_vf.c | 18 +- drivers/n

[PATCH v2 10/25] net/nfp: change the parameter of reconfig

2023-10-23 Thread Chaoyong He
Extract the 'reconfig_lock' data field into the super class, also change the parameter of the related APIs, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 50 + drivers/net/nfp/

[PATCH v2 09/25] net/nfp: change the parameter of APIs

2023-10-23 Thread Chaoyong He
Change the parameter of some APIs from 'struct nfp_net_hw' into the super class 'struct nfp_hw', prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 24 ++-- .../net/nfp/flower/nfp

[PATCH v2 08/25] net/nfp: extract the ctrl data field

2023-10-23 Thread Chaoyong He
Extract the 'ctrl' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 ++--- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 2 +- drivers/net/nfp/nfdk/nfp_nfdk_dp

[PATCH v2 07/25] net/nfp: extract the ctrl BAR data field

2023-10-23 Thread Chaoyong He
Extract the 'ctrl_bar' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 drivers/net/nfp/nfp_ethdev.c| 14 +++--- drivers/net/n

[PATCH v2 06/25] net/nfp: extract the qcp data field

2023-10-23 Thread Chaoyong He
Extract the 'qcp_cfg' data field into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 8 drivers/net/nfp/nfp_net_common.h | 2 +- 2 files changed, 5 insertions(+),

[PATCH v2 05/25] net/nfp: extract the cap data field

2023-10-23 Thread Chaoyong He
Extract the 'cap' and 'cap_ext' data field into the super class, ready for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 6 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 12 ++-- drivers/net/nfp/nfdk/n

[PATCH v2 04/25] net/nfp: rename ctrl module name

2023-10-23 Thread Chaoyong He
Rename the 'nfp_ctrl' module into 'nfp_net_ctrl' module, because which is more suitable and we will add 'nfp_common_ctrl' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build| 2

[PATCH v2 03/25] net/nfp: rename common module name

2023-10-23 Thread Chaoyong He
Rename the 'nfp_common' module into 'nfp_net_common' module, because which is more suitable and we will add 'nfp_common' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.h

[PATCH v2 02/25] net/nfp: make VF PMD using of NFP common module

2023-10-23 Thread Chaoyong He
Modify the logic of NFP VF PMD, make it using of the NFP common module and link into the 'nfp_drivers_list'. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build | 6 +- drivers/net/nfp/nfp_ethdev_vf.c | 1

[PATCH v2 01/25] drivers: introduce the NFP common library

2023-10-23 Thread Chaoyong He
A new NFP vdpa PMD will be added to support vdpa operations by NFP adapters. This vdpa PMD share some logic with the net/nfp PMD. So create a new common library in drivers/common for NFP PMDs. We import a 'nfp_class_driver' layer and which can support various device type in addition to the ethern

[PATCH v2 00/25] add the NFP vDPA PMD

2023-10-23 Thread Chaoyong He
This patch series aims to add the NFP vDPA PMD, we also grab the common logic into the `drivers/common/nfp` directory. --- v2: * Grab more logic into the `drivers/common/nfp` directory. * Delete some logic which should be when moving logic. --- Chaoyong He (25): drivers: introduce the NFP commo

Re: [PATCH v3] app/dma-perf: fix physical address seg-fault

2023-10-23 Thread lihuisong (C)
在 2023/10/19 12:19, Vipin Varghese 写道: do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_p

Re: [PATCH v2] eal/linux: eal/linux: verify mmu type for DPDK support (ppc64le)

2023-10-23 Thread David Christensen
On 10/23/23 4:19 PM, David Christensen wrote: diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h index ebd496b537cf..7d84adb5b328 100644 --- a/lib/eal/common/eal_private.h +++ b/lib/eal/common/eal_private.h @@ -354,6 +354,13 @@ unsigned eal_cpu_core_id(unsigned lcore_id)

[PATCH v5] bus/pci: fix legacy device IO port map in secondary process

2023-10-23 Thread Wenwu Ma
When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v5: - adding checks to vfio setup v4: - adjus

RE: [PATCH] bus/ifpga: fix driver header dependency

2023-10-23 Thread Xu, Rosen
Hi, > -Original Message- > From: David Marchand > Sent: Monday, October 23, 2023 10:46 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Xu, Rosen > Subject: [PATCH] bus/ifpga: fix driver header dependency > > The driver header bus_ifpga_driver.h was not self sufficient. > Fix this by includ

[PATCH v2] eal/linux: eal/linux: verify mmu type for DPDK support (ppc64le)

2023-10-23 Thread David Christensen
IBM POWER systems support more than one type of memory management unit (MMU). The Power ISA 3.0 specification, which applies to P9 and later CPUs, defined a new Radix MMU which, among other things, allows an anonymous memory page mapping to be converted into a hugepage mapping at a specific addres

Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le)

2023-10-23 Thread David Christensen
On 10/17/23 5:39 AM, Thomas Monjalon wrote: I feel this function should not be implemented in the common EAL. What about adding a new function in lib/eal/ppc/ ? And add the "return true" for other architectures? Would it be more appropriate in the lib/eal/common level or lib/eal/linux only?

[PATCH v2 3/7] net/mlx5/hws: add support for fragmented ptype match

2023-10-23 Thread Alexander Kozyrev
Expand packet type matching with support of the Fragmented IP (Internet Protocol) packet type. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 + 2 files changed, 46 insertions(+), 10 deletion

[PATCH v2 7/7] net/mlx5/hws: fix integrity bits level

2023-10-23 Thread Alexander Kozyrev
The level field in the integrity item is not taken into account in the current implementation of hardware steering. Use this value instead of trying to find out the encapsulation level according to the protocol items involved. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Signed-off-by:

[PATCH v2 6/7] net/mlx5/hws: remove csum check from L3 ok check

2023-10-23 Thread Alexander Kozyrev
From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enab

[PATCH v2 5/7] doc: add packet type matching item to release notes

2023-10-23 Thread Alexander Kozyrev
Document new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes. Signed-off-by: Alexander Kozyrev --- doc/guides/rel_notes/release_23_11.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index 0a6fc76a9d..548e3

[PATCH v2 4/7] doc: add PMD ptype item limitations

2023-10-23 Thread Alexander Kozyrev
From: Michael Baum Add limitations for ptype item support in "mlx5.rst" file. Signed-off-by: Michael Baum --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 +++ 2 files changed, 16 insertions(+) diff --git a/doc/guides/nics/features/mlx5.ini b/d

[PATCH v2 2/7] net/mlx5: add support for ptype match in hardware steering

2023-10-23 Thread Alexander Kozyrev
The packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_defin

[PATCH v2 1/7] ethdev: fix ESP packet type description

2023-10-23 Thread Alexander Kozyrev
The correct protocol number for ESP (IP Encapsulating Security Payload) packet type is 50. 51 is IPSec AH (Authentication Header). Fixes: 1e84afd3906b ("mbuf: add security crypto flags and fields") Signed-off-by: Alexander Kozyrev --- lib/mbuf/rte_mbuf_ptype.h | 4 ++-- 1 file changed, 2 inserti

[PATCH v2 0/7] ptype matching support in mlx5

2023-10-23 Thread Alexander Kozyrev
Add support for RTE_FLOW_ITEM_TYPE_PTYPE in mlx5 PMD. Alexander Kozyrev (5): ethdev: fix ESP packet type description net/mlx5: add support for ptype match in hardware steering net/mlx5/hws: add support for fragmented ptype match doc: add packet type matching item to release notes net/mlx

[PATCH] net/iavf: fix Tx offloading flags check

2023-10-23 Thread Radu Nicolau
Use IAVF_TX_OFFLOAD_MASK flags instead of IAVF_TX_CKSUM_OFFLOAD_MASK. Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") Cc: sta...@dpdk.org Cc: david.march...@redhat.com Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH v2 08/14] eal: make seqcount and seqlock stable

2023-10-23 Thread Mattias Rönnblom
On 2023-10-20 23:41, Stephen Hemminger wrote: These were add back in 22.07 release. Signed-off-by: Stephen Hemminger Acked-by: Mattias Rönnblom --- lib/eal/include/rte_seqcount.h | 23 --- lib/eal/include/rte_seqlock.h | 21 - 2 files changed, 44 de

Re: [PATCH v2 04/14] eal: make rte_drand a stable API

2023-10-23 Thread Mattias Rönnblom
On 2023-10-20 23:41, Stephen Hemminger wrote: This API was added in 2020. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_random.h | 4 lib/eal/version.map | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/eal/include/rte_random.h b/lib/eal/i

Eventdev dequeue-enqueue event correlation

2023-10-23 Thread Mattias Rönnblom
Hi. Consider an Eventdev app using atomic-type scheduling doing something like: struct rte_event events[3]; rte_event_dequeue_burst(dev_id, port_id, events, 3, 0); /* Assume three events were dequeued, and the application decides * it's best off to processing event 0 and 2 con

Re: [PATCH v1 06/11] test/bbdev: assert failed test for queue configure

2023-10-23 Thread Kevin Traynor
On 23/10/2023 10:07, Maxime Coquelin wrote: With LTS maintainers actually added... sorry. On 10/23/23 11:05, Maxime Coquelin wrote: On 10/19/23 14:12, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, October 19, 2023 10:47 AM To: Chautru,

Re: [PATCH] bus/ifpga: fix driver header dependency

2023-10-23 Thread Bruce Richardson
On Mon, Oct 23, 2023 at 04:46:17PM +0200, David Marchand wrote: > The driver header bus_ifpga_driver.h was not self sufficient. > Fix this by including dev_driver.h. > > Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand >

[PATCH] bus/ifpga: fix driver header dependency

2023-10-23 Thread David Marchand
The driver header bus_ifpga_driver.h was not self sufficient. Fix this by including dev_driver.h. Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/ifpga/bus_ifpga_driver.h | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH] bitops: mark new symbols as stable

2023-10-23 Thread David Marchand
On Mon, Oct 23, 2023 at 10:47 AM Kevin Traynor wrote: > >> Calling an experimental symbol from an inline helper triggers a warning > >> when > >> such code is not compiled with experimental API. > >> This can be seen when rte_bitops.h gets (indirectly) included in OVS > >> builds. > >> > >> On t

RE: [EXT] Re: [PATCH 1/1] build: update link args and includes for libarchive

2023-10-23 Thread Srikanth Yalavarthi
> -Original Message- > From: Bruce Richardson > Sent: 23 October 2023 18:36 > To: Srikanth Yalavarthi > Cc: dmitry.kozl...@gmail.com; Aaron Conole ; Igor > Russkikh ; David Marchand > ; dev@dpdk.org; Shivah Shankar Shankar > Narayan Rao ; Jerin Jacob Kollanukkaran > ; sta...@dpdk.org > Su

RE: [EXT] [PATCH v2] doc: update QAT kernel module entry

2023-10-23 Thread Akhil Goyal
> The Kernel Module entry for 2.0 devices was incorrect in the doc table. > Updated table with Kernel Module qat_4xxx. > > Fixes: f4eac3a09c51 ("common/qat: enable GEN4 b devices") > Cc: arkadiuszx.kusz...@intel.com > > Signed-off-by: Brian Dooley Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v1] cryptodev: clarify usage of the block ciphers

2023-10-23 Thread Akhil Goyal
> Subject: [EXT] [PATCH v1] cryptodev: clarify usage of the block ciphers > > External Email > > -- > From: Arkadiusz Kusztal > > Some of the API comments incorrectly limited the usage of symmetric > crypto fields to block ciph

RE: [PATCH] crypto/openssl: fix memory leaks in SM2 ops

2023-10-23 Thread Akhil Goyal
> Subject: [PATCH] crypto/openssl: fix memory leaks in SM2 ops > > Fix memory leaks in SM2 ops, as reported by valgrind. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 45 ++-- > 1 file changed, 26 insertions(+), 19 deletions

RE: [PATCH] app/test: add modexp group tests

2023-10-23 Thread Akhil Goyal
Hi Gowri, > Subject: [PATCH] app/test: add modexp group tests > > Add modexp tests for groups 5, 14, 15, 16, 17 and 18. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Can you rebase this patch so that CI can run?

[PATCH v6 9/9] examples/ntb: auto-generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/ntb/Makefile | 12 ++- examples/ntb/commands.list | 11 ++ examples/ntb/meson.build | 7 ++ examples/ntb/ntb_fwd.c

[PATCH v6 8/9] buildtools/dpdk-cmdline-gen: support option strings

2023-10-23 Thread Bruce Richardson
Add support to the commandline generator for option strings, where there are only a limited number of acceptable values to be passed as a parameter. Signed-off-by: Bruce Richardson --- buildtools/dpdk-cmdline-gen.py| 7 +++ doc/guides/prog_guide/cmdline.rst | 7 +++ 2 files changed,

[PATCH v6 7/9] examples/vdpa: auto-generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/vdpa/Makefile | 12 ++-- examples/vdpa/commands.list | 8 +++ examples/vdpa/main.c| 131 ++

[PATCH v6 6/9] examples/bond: auto-generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- Note: the original help text on some of the commands in this example were not useful "this command do not handle any arguments". Ther

[PATCH v6 5/9] examples/hotplug_mp: auto-generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/hotplug_mp/Makefile| 12 +- examples/multi_process/hotplug_mp/commands.c | 147 ++ example

[PATCH v6 4/9] examples/simple_mp: auto-generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/simple_mp/Makefile | 12 +- examples/multi_process/simple_mp/meson.build | 9 ++ .../multi_process/simpl

[PATCH v6 3/9] ci: allow use of DPDK tools when building examples

2023-10-23 Thread Bruce Richardson
To allow use of the DPDK python scripts (installed in $(prefix)/bin) from within the makefiles of our examples, we need to export the PATH variable with the location of our installed scripts from within our CI scripts. This matches what is already done for other paths e.g. the PKG_CONFIG_PATH varia

[PATCH v6 2/9] buildtools: script to generate cmdline boilerplate

2023-10-23 Thread Bruce Richardson
Provide a "dpdk-cmdline-gen.py" script for application developers to quickly generate the boilerplate code necessary for using the cmdline library. Example of use: The script takes an input file with a list of commands the user wants in the app, where the parameter variables are tagged with the ty

[PATCH v6 1/9] doc/prog_guide: new chapter on cmdline library

2023-10-23 Thread Bruce Richardson
The cmdline library was not documented in our programmers guide, so add a new chapter on it. This chapter covers step-by-step how to use the library, rather than focusing on the library internals. This complements the existing cmdline example app document, providing more details on the process of u

[PATCH v6 0/9] document and simplify use of cmdline

2023-10-23 Thread Bruce Richardson
The DPDK commandline library is widely used by apps and examples within DPDK, but it is not documented in our programmers guide and it requires a lot of boilerplate code definitions in order to used. We can improve this situation by creating a simple python script to automatically generate the boil

  1   2   >