Re: [PATCH] ethdev: fix incorrect function name in comment

在 2023/10/20 23:12, Ferruh Yigit 写道: On 10/20/2023 2:05 PM, Bruce Richardson wrote: For those using the function comments as a guide, provide the name of the correct callback function to use when wanting to count dropped packets from the ethdev tx buffering system. Fixes: d6c99e62c852 ("ethde

Re: [PATCH] mempool: fix internal function documentation

Acked-by: Huisong Li 在 2023/10/20 22:46, Ferruh Yigit 写道: static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the intern

[PATCH v2 14/14] eal: make rte_version API's stable

These have been around since 2020 releases. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_version.h | 6 -- lib/eal/version.map | 16 ++-- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/lib/eal/include/rte_version.h b/lib/eal/include/rte_ver

[PATCH v2 13/14] eal: mark rte_vect simd bandwidth API as stable

These were added back in 20.11. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_vect.h | 8 lib/eal/version.map| 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_vec

[PATCH v2 12/14] eal: mark rte_eal_vfio_get_token stable

This API was added in 20.08 release. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_eal.h | 4 lib/eal/version.map | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h index cd318ee14152..c2256f832e51 1

[PATCH v2 11/14] eal: mark rte_power API's stable

These were added back in 2020. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_power_intrinsics.h | 16 lib/eal/version.map| 12 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/lib/eal/include/generic/rte_

[PATCH v2 10/14] eal: mark rte_atomic128_cmp_exchange as stable

This has been around since 2021. Signed-off-by: Stephen Hemminger --- lib/eal/arm/include/rte_atomic_64.h | 1 - lib/eal/include/generic/rte_atomic.h | 1 - lib/eal/x86/include/rte_atomic_64.h | 1 - 3 files changed, 3 deletions(-) diff --git a/lib/eal/arm/include/rte_atomic_64.h b/lib/eal/a

[PATCH v2 09/14] eal: mark rte_intr_XXX API's as stable

These were added back in 2020. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_interrupts.h | 28 lib/eal/version.map | 14 +++--- 2 files changed, 7 insertions(+), 35 deletions(-) diff --git a/lib/eal/include/rte_interrupts.h b/lib/eal

[PATCH v2 08/14] eal: make seqcount and seqlock stable

These were add back in 22.07 release. Signed-off-by: Stephen Hemminger Acked-by: Mattias Rönnblom --- lib/eal/include/rte_seqcount.h | 23 --- lib/eal/include/rte_seqlock.h | 21 - 2 files changed, 44 deletions(-) diff --git a/lib/eal/include/rte_seqcou

[PATCH v2 07/14] eal: make pflock API stable

Added in 21.11 release. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_pflock.h | 20 1 file changed, 20 deletions(-) diff --git a/lib/eal/include/rte_pflock.h b/lib/eal/include/rte_pflock.h index 553504bb6dd9..9aaf56f715cc 100644 --- a/lib/eal/include/rte_pflock.

[PATCH v2 06/14] eal: make rte_devargs_reset stable

Was added in 20.05 release. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_devargs.h | 1 - lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/include/rte_devargs.h b/lib/eal/include/rte_devargs.h index 91267981b1de..add8032e73cb

[PATCH v2 05/14] eal: make rte_service_lcore_may_be_active stable

This API was added in 2020. Signed-off-by: Stephen Hemminger Acked-by: Harry van Haaren --- lib/eal/include/rte_service.h | 1 - lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/include/rte_service.h b/lib/eal/include/rte_service.h inde

[PATCH v2 04/14] eal: make rte_drand a stable API

This API was added in 2020. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_random.h | 4 lib/eal/version.map | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h index c12eb07ea818..ea74ca02004

[PATCH v2 03/14] eal: make rte_class API's stable

These API's have been around for a while. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_class.h | 4 lib/eal/version.map | 10 -- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/eal/include/rte_class.h b/lib/eal/include/rte_class.h index 47b17

[PATCH v2 02/14] eal: mark rte_dev API's as stable

These have been around since 2020. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_dev.h | 32 lib/eal/version.map | 28 +++- 2 files changed, 11 insertions(+), 49 deletions(-) diff --git a/lib/eal/include/rte_dev.h b/lib/e

[PATCH v2 01/14] eal: make bitops a stable API

These were added in 20.05 release. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_bitmap.h | 8 lib/eal/include/rte_bitops.h | 40 2 files changed, 48 deletions(-) diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h i

[PATCH v2 00/14] eal: mark older API's as stable

About 80 function in EAL were marked experimental and should have been made stable by now. v2 - rebase and fix some bits in wrong patch Stephen Hemminger (14): eal: make bitops a stable API eal: mark rte_dev API's as stable eal: make rte_class API's stable eal: make rte_drand a stable API

[PATCH v5 26/26] cryptodev: mark older API's stable

All the cryptodev API's from 2022 backwards shoudl be stable at this point. Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.h | 31 -- lib/cryptodev/version.map | 77 +++ 2 files changed, 32 insertions(+), 76 deletions(-) diff --g

[PATCH v5 25/26] eventdev: make many API's stable

All API's in eventdev up to 22.11 release should be made stable. Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.h | 4 --- lib/eventdev/rte_event_eth_rx_adapter.h | 6 - lib/eventdev/rte_event_eth_tx_adapter.h | 3 --- lib/eventdev/rte_event_timer_adapter.h |

[PATCH v5 24/26] node: remove some of the experimental tags

The node library has been around long enough that experimental tag should be removed. The IPv6 support was added in 23.03 but that is still enough time that it can be marked stable. The logtype variable should have been marked internal since it is not intended to be used outside of library. Sign

[PATCH v5 23/26] regexdev: remove experimental tag

This library was added in 22.11. Time to make it not experimental. Signed-off-by: Stephen Hemminger --- lib/regexdev/rte_regexdev.h | 92 - lib/regexdev/version.map| 2 +- 2 files changed, 1 insertion(+), 93 deletions(-) diff --git a/lib/regexdev/rte_reg

[PATCH v5 22/26] compressdev: remove experimental flag

The compressdev can not hide under the experimental flag. Remove the experimental flag and require ABI to be stable. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 2 +- lib/compressdev/rte_comp.h| 6 -- lib/compressdev/rte_compressdev.h | 26 -

[PATCH v5 21/26] ipsec: remove experimental from SA API

These API's were added in 21.11, remove experimental flag. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ipsec/rte_ipsec.h | 2 -- lib/ipsec/version.map | 9 + 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/ipsec/rte_ipsec.h b/lib/ipsec/rte_ip

[PATCH v5 19/26] security: remove experimental flag from macsec

The rte_security API's for macsec were added in 22.11. Therefore remove the experimental tag. There is also one helper function for setting packet metadata that should have been marked internal. Signed-off-by: Stephen Hemminger Acked-by: Akhil Goyal --- lib/security/rte_security.h | 27 ---

[PATCH v5 20/26] bbdev: remove experimental tag

The API's for bbdev were last added to in 22.11. Remove experimental flag now. Signed-off-by: Stephen Hemminger Acked-by: Maxime Coquelin --- lib/bbdev/rte_bbdev.h| 4 lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 15 +++ 3 files changed, 7 insertions(+), 14

[PATCH v5 18/26] member: remove experimental tag

The member library last received new API's in 22.11. All the API's should be marked stable by now. Signed-off-by: Stephen Hemminger --- lib/member/rte_member.h | 54 - lib/member/version.map | 12 +++-- 2 files changed, 3 insertions(+), 63 deletions(-

[PATCH v5 17/26] ip_frag: mark a couple of functions stable

There were two functions added in 22.11 which were marked as experimental. Remove the experimental tag. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ip_frag/rte_ip_frag.h | 2 -- lib/ip_frag/version.map | 9 ++--- 2 files changed, 2 insertions(+), 9 deletions(-)

[PATCH v5 16/26] kvargs: remove experimental flag

The function rte_kvargs_get_with_value was added in 21.11 so experimental flag can be removed. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/kvargs/rte_kvargs.h | 4 lib/kvargs/version.map | 8 +--- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/l

[PATCH v5 15/26] power: remove experimental from API's

The power management API's were last changed in 22.11 release. Therefore remove experimental for 23.11 release. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/power/rte_power.h | 4 --- lib/power/rte_power_guest_channel.h | 4 --- lib/power/rte_power_pmd_mgmt.h

[PATCH v5 14/26] meter: remove experimental warning from comments

The API's for rte_meter_trtcm were never properly flagged as experimental; missing __rte_experimental but there was an experimental comment in the docbook comment. Remove the comment. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Cristian Dumitrescu --- lib/meter/rte_me

[PATCH v5 13/26] dmadev: mark API's as not experimental

These were added in 20.11 time now to remove experimental flag. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 2 +- lib/dmadev/rte_dmadev.h | 85 - lib/dmadev/version.map | 2 +- 3 fi

[PATCH v5 12/26] sched: remove experimental

The overcommit and PIE support was added back in 2020. Remove experimental tag. Signed-off-by: Stephen Hemminger Acked-by: Cristian Dumitrescu --- lib/sched/rte_pie.h | 8 lib/sched/rte_sched.h | 5 - lib/sched/version.map | 18 -- 3 files changed, 4 insertions(

[PATCH v5 11/26] timer: remove experimental from rte_timer_next_ticks

Function was added in 20.11, remove experimental flag. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.h | 4 lib/timer/version.map | 7 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/timer/rte_timer.h b/lib/timer/rte_timer.h index d3927d5b6bac..153d1993

[PATCH v5 10/26] hash: remove experimental from toeplitz hash

The rte_thash_ functions have been around since 2020. Remove experimental tag. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.h | 44 --- lib/hash/rte_thash_gfni.h | 8 --- lib/hash/rte_thash_x86_gfni.h | 8 --- lib/hash/version.map

[PATCH v5 09/26] mbuf: remove experimental from create_extbuf

This API was added in 2020 and should no longer be experimental. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/mbuf/rte_mbuf.h | 1 - lib/mbuf/version.map | 8 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h

[PATCH v5 08/26] lpm: remove experimental

The function to associate RCU with LPM was added several releases ago. Remove experimental. Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm.h | 4 lib/lpm/version.map | 7 +-- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h ind

[PATCH v5 07/26] rcu: remove experimental from rte_rcu_qbsr

These functions were added back in 2020. Remove experimental flag. Signed-off-by: Stephen Hemminger Reviewed-by: Honnappa Nagarahalli --- lib/rcu/rte_rcu_qsbr.h | 20 lib/rcu/version.map| 15 --- 2 files changed, 4 insertions(+), 31 deletions(-) diff --git

[PATCH v5 06/26] net: remove experimental from functions

These functions have been around long enough should no longer be experimental. Signed-off-by: Stephen Hemminger --- lib/net/rte_ip.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index 7f58dc6f6a9c..2cb5be222cdd 100644 --- a/lib/net/r

[PATCH v5 05/26] pcapng: mark API's as stable

This API was added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.h | 11 --- lib/pcapng/version.map | 6 ++ 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcap

[PATCH v5 04/26] pdump: make API's stable

The filtering API's were added in 22.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pdump/rte_pdump.h | 12 lib/pdump/version.map | 11 +++ 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdu

[PATCH v5 03/26] ethdev: mark rte_tm API's as stable

These API's have been around since 20.11, mark them as not experimental. Signed-off-by: Stephen Hemminger Acked-by: Cristian Dumitrescu --- MAINTAINERS| 2 +- lib/ethdev/rte_tm.h| 34 --- lib/ethdev/version.map | 62 --

[PATCH v5 02/26] cmdline: make experimental API's stable

These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h| 1 - lib/cmdline/cmdline_parse.h | 4 lib/cmdline/cmdline_rdline.h | 4 lib/cmdline/version.map | 26 --

[PATCH v5 01/26] bpf: make rte_bpf_dump and rte_bpf_convert stable API's

These two API's were introduced in 22.11 and can now be made not experimental. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/rte_bpf.h | 2 -- lib/bpf/version.map | 9 ++--- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/bpf/rte_bpf.h b/lib/

[PATCH v5 00/26] Promote many experimental API's to stable

Since 23.11 is an LTS release it is time to remove the experimental bandaid off many API's. There are about 890 API's marked with experimental on current main branch. This addresses the easy to remove ones and gets it down to about 510 places. The rule is any API that has been in since 22.11 needs

Re: [PATCH v3 22/29] vhost: remove experimental from some API's

On Fri, 20 Oct 2023 09:41:48 +0200 Maxime Coquelin wrote: > I think we should wait before remove experimental tag on all the Vhost > async APIs. Indeed, it was intended to be used by OVS, but the proposed > architecture was nacked by the OVS maintainers. I'm not aware of any > other user of these

[PATCH] distributor: enhance error handling for consistency

>From fe8850cb3b7c1051784e5587b9f79beeaf87a804 Mon Sep 17 00:00:00 2001From: >bullvolkan Date: Fri, 20 Oct 2023 21:48:30 >+0300Subject: [PATCH] distributor: enhance error handling for consistency   This commit improves error handling in the distributor component to en

[PATCH 1/1] build: update link args and includes for libarchive

In order to avoid linking with all libraries listed as Libs.private in libarchive.pc, libarchive is not added to ext_deps during meson setup. Since libarchive is not added to ext_deps, cross-compilation or native compilation with libarchive installed in non-standard location fails with errors rela

Minutes of Technical Board meeting 18-October-23

Members Attending - Aaron Conole Bruce Richardson Hemant Agrawal Honappa Nagarahalli Jerin Jacob Kevin Traynor (Chair) Konstantin Ananyev Maxime Coquelin Stephen Hemminger Thomas Monjalon NOTE: The technical board meetings are on every second Wednesday at 3 pm UTC. Meetings are pu

RE: [PATCH] mempool: fix internal function documentation

> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Friday, 20 October 2023 16.47 > > static function `rte_mempool_do_generic_get()` returns zero on success, > not >=0 as its function comment documents. > > Since this function called by public API, the comment causes confusion > on the pub

Re: [PATCH] docs: add note about experimental API in LTS

On 10/20/2023 4:01 PM, Bruce Richardson wrote: > On Fri, Oct 20, 2023 at 03:19:30PM +0100, Kevin Traynor wrote: >> The justification and impact for changing experimental API on LTS >> branches is different from the main branch. So the policy that is >> being used for allowing experimental APIs to c

Re: [PATCH] ethdev: fix incorrect function name in comment

On 10/20/2023 2:05 PM, Bruce Richardson wrote: > For those using the function comments as a guide, provide the name of > the correct callback function to use when wanting to count dropped > packets from the ethdev tx buffering system. > > Fixes: d6c99e62c852 ("ethdev: add buffered Tx") > Cc: sta..

Re: [PATCH v4] app/test: add support for skipping tests

+stable on CC, to allow it be considered for possible backport. It's a change to the unit test app, so not affecting any ABI or any end-user app. On Fri, Oct 20, 2023 at 11:02:07AM -0400, Patrick Robb wrote: >On Mon, Oct 9, 2023 at 4:03 PM Patrick Robb <[1]pr...@iol.unh.edu> >wrote: > >

Re: [PATCH] docs: add note about experimental API in LTS

On Fri, Oct 20, 2023 at 03:19:30PM +0100, Kevin Traynor wrote: > The justification and impact for changing experimental API on LTS > branches is different from the main branch. So the policy that is > being used for allowing experimental APIs to change is stricter on > the LTS branches. > > This w

Re: [PATCH v4] app/test: add support for skipping tests

On Mon, Oct 9, 2023 at 4:03 PM Patrick Robb wrote: > >> Hello, > > Yes, backporting would be ideal from a CI perspective because without it > we can't run arm64 testing on LTS tests. But I know there are other > considerations which also have to be weighed. > > David also has a patch[1] which sho

[PATCH] mempool: fix internal function documentation

static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the internal function documentation for return value. Fixes: af75078fec

[PATCH] docs: add note about experimental API in LTS

The justification and impact for changing experimental API on LTS branches is different from the main branch. So the policy that is being used for allowing experimental APIs to change is stricter on the LTS branches. This was not documented anywhere, so add some documentation. Suggested-by: David

[PATCH] ethdev: fix incorrect function name in comment

For those using the function comments as a guide, provide the name of the correct callback function to use when wanting to count dropped packets from the ethdev tx buffering system. Fixes: d6c99e62c852 ("ethdev: add buffered Tx") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/ethde

[PATCH] ethdev: refresh shared memory reference in secondary process

In the process of releasing ethdev port in the primary process, secondary processes are asked to stop referencing such a port. Doing so, those processes can't predict whether the primary process will later invalidate/free the shared memory. So they may live with a reference to an old shared memory

Coverity components list needs updating

Lincoln, CC: DPDK Coverity admins, Could you please (delegate to someone to) update the list of Components in Coverity. The list uses the obsolete directory names /lib/librte_xyz/ instead of /lib/xyz/, and thus the vast majority of code is bundled into the catch-all "Other" category. This makes

RE: [PATCH v4 06/28] pcapng: mark API's as stable

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 19 October 2023 21.10 > > This API was added in 23.11 and can now be marked as not > experimental. If they were added in 23.11 they would be brand new. The same typo is present in other patches in this series.

Re: [PATCH] maintainers: update email address

Hi Chenbo, On Fri, Oct 20, 2023 at 10:52 AM Chenbo Xia wrote: > > I left Intel and joined Nvidia, so update my email address. > > Signed-off-by: Chenbo Xia > --- > .mailmap| 2 +- > MAINTAINERS | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/.mailmap

RE: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Thomas Monjalon > ; Dumitrescu, Cristian > ; Ferruh Yigit ; > Andrew Rybchenko > Subject: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable > > Th

RE: [PATCH v4 04/28] ethdev: mark rte_tm API's as stable

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Thomas Monjalon > ; Dumitrescu, Cristian > ; Ferruh Yigit ; > Andrew Rybchenko > Subject: [PATCH v4 04/28] ethdev: mark rte_tm API's as stable > > The

RE: [PATCH v4 13/28] sched: remove experimental

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 13/28] sched: remove experimental > > The overcommit and PIE support was added back in 2020. > Remove expe

RE: [PATCH v4 15/28] meter: remove experimental warning from comments

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Richardson, Bruce > ; Dumitrescu, Cristian > > Subject: [PATCH v4 15/28] meter: remove experimental warning from > comments > > The API's for rte_mete

RE: [PATCH v4 27/28] table: remove experimental from API

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 27/28] table: remove experimental from API > > Though this library is marked for deprecation in future. >

RE: [PATCH v4 28/28] port: make API's stable

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, October 19, 2023 8:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 28/28] port: make API's stable > > Follow the guidelines already in deprecation.rst and > make the API's s

[PATCH v2 0/7] fix race-condition of proactive error handling mode

This patch fixes race-condition of proactive error handling mode, the discussion thread [1]. [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ Chengwen Feng (7): ethdev: fix race-condition of proactive error handling mode net/hns3: replace fp

[PATCH v2 7/7] doc: testpmd support event handling section

Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 80 doc/guides/testpmd_app_ug/index.rst | 1 + 2 files changed, 81 insertions(+) create mode 100644 do

[PATCH v2 6/7] app/testpmd: extract event handling to event.c

This patch extract event handling (including eth-event and dev-event) to a new file 'event.c'. Signed-off-by: Chengwen Feng --- app/test-pmd/event.c | 390 ++ app/test-pmd/meson.build | 1 + app/test-pmd/parameters.c | 36 +--- app/test-pmd/testpmd.c

[PATCH v2 5/7] app/testpmd: add error recovery usage demo

This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that fail to recovery and need to be removed whe

[PATCH v2 4/7] net/bnxt: use fp ops setup function

Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/ne

[PATCH v2 2/7] net/hns3: replace fp ops config function

This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/net/hns3/hns3

[PATCH v2 1/7] ethdev: fix race-condition of proactive error handling mode

In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft

[PATCH v2 3/7] net/bnxt: fix race-condition when report error recovery

If set data path functions to dummy functions before reports error recovering event, there maybe a race-condition with data path threads, this patch fixes it by setting data path functions to dummy functions only after reports such event. Fixes: e11052f3a46f ("net/bnxt: support proactive error han

Re: [PATCH v4 16/28] power: remove experimental from API's

On 19/10/2023 20:10, Stephen Hemminger wrote: The power management API's were last changed in 22.11 release. Therefore remove experimental for 23.11 release. Signed-off-by: Stephen Hemminger --- Acked-by: David Hunt

Re: [PATCH v2 16/29] power: remove experimental from API's

On 09/08/2023 01:10, Stephen Hemminger wrote: The power management API's were last changed in 22.11 release. Therefore remove experimental for 23.11 release. Signed-off-by: Stephen Hemminger --- Acked-by: David Hunt

Re: [PATCH] maintainers: update email address

On 10/20/23 10:51, Chenbo Xia wrote: I left Intel and joined Nvidia, so update my email address. Signed-off-by: Chenbo Xia --- .mailmap| 2 +- MAINTAINERS | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) Welcime back Chenbo :) Acked-by: Maxime Coquelin Maxim

Re: [PATCH] net/virtio: fix the setting of the vector for link state interrupt

Hi Wenwu, Please reword the commit title to something: net/virtio: fix link state interrupt vector setting On 8/7/23 05:15, Wenwu Ma wrote: The settings of the vector for link state interrupts should be done before the initialization of the device is completed. Fixes: ee85024cf5f7 ("net/virtio

[PATCH] maintainers: update email address

I left Intel and joined Nvidia, so update my email address. Signed-off-by: Chenbo Xia --- .mailmap| 2 +- MAINTAINERS | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.mailmap b/.mailmap index 3f5bab26a8..2ff31b008f 100644 --- a/.mailmap +++ b/.mailmap @@ -2

[PATCH v2 6/7] vhost: fix missing lock protection in power monitor API

The power monitor get API is missing both access lock protection and access status check. Fixes: 34fd4373ce76 ("vhost: add power monitor API") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/7] vhost: fix check on virtqueue access in async registration

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: 78639d54563a ("vhost: introduce async enqueue registration API") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 14

[PATCH v2 7/7] vhost: fix checking virtqueue access in stats API

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: be75dc99ea1f ("vhost: support per-virtqueue statistics") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 21 +++

[PATCH v2 5/7] vhost: fix check on virtqueue access in in-flight getter

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhos

[PATCH v2 3/7] vhost: fix checking virtqueue access when notifying guest

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: d761d455a0e4 ("vhost: add operation to offload the interrupt kick") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c |

[PATCH v2 0/7] vhost: ensure virtqueue access status is checked

Li Feng initially reported segmentation fault in rte_vhost_vring_call() because of not checking the virtqueue metadata can be accessed. This should be achieved by checking the access_ok status field of the virtqueue. This series also takes the opportunity to fix the other APIs. This is split in m

[PATCH v2 2/7] vhost: fix missing check on virtqueue access

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: 4e0de8dac853 ("vhost: protect vring access done by application") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 16

[PATCH v2 1/7] vhost: fix missing vring call check on virtqueue access

Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection") Fixes: 830f7e790732 ("vhost

Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access

On 10/19/23 09:24, David Marchand wrote: On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin wrote: Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Even if adding the lock was not enough, I would

Re: [PATCH v4 22/28] bbdev: remove experimental tag

On 10/19/23 21:10, Stephen Hemminger wrote: The API's for bbdev were last added to in 22.11. Remove experimental flag now. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.h| 4 lib/bbdev/rte_bbdev_op.h | 2 -- lib/bbdev/version.map| 15 +++ 3 files ch

Re: [PATCH v4 21/28] vhost: remove experimental from some API's

On 10/19/23 21:10, Stephen Hemminger wrote: All API's that before 22.11 release should have experimental tag removed. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h| 5 lib/vhost/rte_vhost_async.h | 19 -- lib/vhost/rte_vhost_crypto.h | 1 - lib/v

Re: [PATCH v3 22/29] vhost: remove experimental from some API's

On 10/19/23 18:55, Stephen Hemminger wrote: All API's that before 22.11 release should have experimental tag removed. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h| 5 lib/vhost/rte_vhost_async.h | 19 -- lib/vhost/rte_vhost_crypto.h | 1 - lib/v